On 09/11/2017 12:20 PM, Christophe JAILLET wrote:
All other error handling paths in this function go through the 'error'
label. This one should do the same.
Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.")
Signed-off-by: Christophe JAILLET
---
I think that the comment above
dump(struct sk_buff *skb, struct
> netlink_callback *cb)
> int err = 0;
> int fidx = 0;
>
> - if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb,
> - IFLA_MAX, ifla_policy, NULL) == 0) {
> + err = nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb,
> + IFLA_MAX, ifla_policy, NULL);
> + if (err < 0) {
> + return -EINVAL;
> + } else if (err == 0) {
> if (tb[IFLA_MASTER])
> br_idx = nla_get_u32(tb[IFLA_MASTER]);
> }
Fix looks right to me.
Reviewed-by: Greg Rose
On Tue, Feb 24, 2015 at 8:25 AM, Daniel Baluta wrote:
> On Tue, Feb 24, 2015 at 6:14 PM, Greg Rose wrote:
>> I'm excited - what's NFC?
>
>
> Please don't do top posting.
My apologies - my smartphone interface rather sucks sometimes.
>
> Other than
I'm excited - what's NFC?
- Greg
On Tue, Feb 24, 2015 at 2:01 AM, Robert Dolca wrote:
> This patch adds support for Intel's FieldsPeak NFC solution.
> The device is enumerated with ACPI and platform init.
>
> In order to implement the driver the nci_core_conn_create was
> modified in order to re
On Mon, 23 Dec 2013 09:20:37 -0800
Alexander Duyck wrote:
> On 12/22/2013 09:09 PM, Ding Tianhong wrote:
> > Use the recently added and possibly more efficient
> > ether_addr_equal_unaligned to instead of memcmp.
> >
> > Cc: "David S. Miller"
> > Cc: net...@vger.kernel.org
> > Cc: linux-kernel@v
On Tue, 12 Nov 2013 18:02:57 +0800
Jason Wang wrote:
> We currently use hdr_len as a hint of head length which is advertised
> by guest. But when guest advertise a very big value, it can lead to
> an 64K+ allocating of kmalloc() which has a very high possibility of
> failure when host memory is f
On Tue, 14 May 2013 19:48:22 -0700
Yinghai Lu wrote:
> Found kernel try to load mlx4 drivers for VFs before
> PF's is loaded when the drivers are built-in, and kernel
> command line include probe_vfs=63, num_vfs=63.
>
> [ 169.581682] calling mlx4_init+0x0/0x119 @ 1
> [ 169.595681] mlx4_core:
t; fixed regardless. git bisected to:
This definitely looks like a bug. You should be able to use both
methods without a problem. I'll look into it and see if I can figure
out what's going on.
- Greg
>
> commit fa44f2f185f7f9da19d331929bb1b56c1ccd1d93
> Author: Greg Rose
&
8 matches
Mail list logo
