[PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

The driver stores the result of irq_set_type() in the internal variables irq_trig_raise and irq_trig_fall, which later are used to determine the GPIOs that must be re-configured as input. These variables retain their value between gpiolib's export / unexport, resulting in an incorrect state in

[PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

The driver stores the result of irq_set_type() in the internal variables irq_trig_raise and irq_trig_fall, which later are used to determine the GPIOs that must be re-configured as input. These variables retain their value between gpiolib's export / unexport, resulting in an incorrect state in

Re: [PATCH RFT] regulator: tps6105x: Convert to use regmap helper functions

Hi, On Wed., 07/10/2015 08:47 +0800, Axel Lin wrote: > Since commit 7e5071199355 ("mfd: tps6105x: Use i2c regmap to access > registers"), we can use regmap helper functions instead of open coded. > > Signed-off-by: Axel Lin > --- > Hi Grigoryev, > I don't have this h/w, can you help test this

Re: [PATCH RFT] regulator: tps6105x: Convert to use regmap helper functions

Hi, On Wed., 07/10/2015 08:47 +0800, Axel Lin wrote: > Since commit 7e5071199355 ("mfd: tps6105x: Use i2c regmap to access > registers"), we can use regmap helper functions instead of open coded. > > Signed-off-by: Axel Lin > --- > Hi Grigoryev, > I don't have this h/w, can

[PATCH] mfd: tps6105x: Use i2c regmap to access registers

This patch modifies tps6105x and associated function driver to use regmap instead of operating directly on i2c. Signed-off-by: Denis Grigoryev --- drivers/mfd/tps6105x.c | 78 ++ drivers/regulator/tps6105x-regulator.c | 16 +++

[PATCH] mfd: tps6105x: Use i2c regmap to access registers

This patch modifies tps6105x and associated function driver to use regmap instead of operating directly on i2c. Signed-off-by: Denis Grigoryev --- drivers/mfd/tps6105x.c | 78 ++ drivers/regulator/tps6105x-regulator.c | 16

[PATCH v5] mfd: tps6105x: Fix possible NULL pointer access.

tps6105 driver provides two cells. One is for GPIO and another one is for selected mode depending on platform data. When tps6105x is used in GPIO-only mode, this driver calls mfd_add_devices() with mfd_cell .name == NULL. This value causes an oops in platform_device_register() later. The

[PATCH v4] mfd: tps6105x: Fix possible NULL pointer access.

tps6105x driver provides two cells. One is for GPIO and another one is for selected mode depending on platform data. When tps6105x is used in GPIO-only mode, this driver calls mfd_add_devices() with mfd_cell .name == NULL. This value causes an oops in platform_device_register() later. The

[PATCH v5] mfd: tps6105x: Fix possible NULL pointer access.

tps6105 driver provides two cells. One is for GPIO and another one is for selected mode depending on platform data. When tps6105x is used in GPIO-only mode, this driver calls mfd_add_devices() with mfd_cell .name == NULL. This value causes an oops in platform_device_register() later. The

[PATCH v4] mfd: tps6105x: Fix possible NULL pointer access.

tps6105x driver provides two cells. One is for GPIO and another one is for selected mode depending on platform data. When tps6105x is used in GPIO-only mode, this driver calls mfd_add_devices() with mfd_cell .name == NULL. This value causes an oops in platform_device_register() later. The

[PATCH v3] mfd: tps6105x: Fix NULL pointer access.

When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in platform_device_register() later. This patch adds an mfd_cell for each possible mode thereby excluding .name assignment in runtime. Signed-off-by: Denis

Re: [PATCH v2] mfd: tps6105x: Fix NULL pointer access.

Oh, sorry. With further testing I realized that I made a mistake and typos. I will send the patch v3. My apologies for the flood. I'm new in LKML. On Mon., 21/09/2015 at 13:41 +, Grigoryev Denis wrote: > When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls > mfd_add_d

[PATCH v2] mfd: tps6105x: Fix NULL pointer access.

When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in platform_device_register() later. This patch adds an mfd_cell for each possible mode thereby excluding runtime .name assignment. Signed-off-by: Denis

Re: [PATCH] mfd: tps6105x: Fix NULL pointer access.

On Sat., 20/09/2015 в 05:20 +0100, Lee Jones wrote: > On Fri, 04 Sep 2015, Grigoryev Denis wrote: > > > When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls > > mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in > > platf

[PATCH v2] mfd: tps6105x: Fix NULL pointer access.

When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in platform_device_register() later. This patch adds an mfd_cell for each possible mode thereby excluding runtime .name assignment. Signed-off-by: Denis

Re: [PATCH] mfd: tps6105x: Fix NULL pointer access.

On Sat., 20/09/2015 в 05:20 +0100, Lee Jones wrote: > On Fri, 04 Sep 2015, Grigoryev Denis wrote: > > > When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls > > mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in > > platf

[PATCH v3] mfd: tps6105x: Fix NULL pointer access.

When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in platform_device_register() later. This patch adds an mfd_cell for each possible mode thereby excluding .name assignment in runtime. Signed-off-by: Denis

Re: [PATCH v2] mfd: tps6105x: Fix NULL pointer access.

Oh, sorry. With further testing I realized that I made a mistake and typos. I will send the patch v3. My apologies for the flood. I'm new in LKML. On Mon., 21/09/2015 at 13:41 +, Grigoryev Denis wrote: > When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls > mfd_add_d

[PATCH] mfd: tps6105x: Fix NULL pointer access.

When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in platform_device_register() later. This patch reorders mfd_cell structures and makes code to call mfd_add_devices() with proper number of cells. Signed-off-by:

[PATCH] mfd: tps6105x: Fix NULL pointer access.

When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in platform_device_register() later. This patch reorders mfd_cell structures and makes code to call mfd_add_devices() with proper number of cells. Signed-off-by: