Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
I've done more tests, maybe it can give you more hints. I don't see that much differences between both (with and without patches) in this cases. -- Guilhem Lettron CoreCPU Avg_MHz Busy% Bzy_MHz TSC_MHz IRQ SMI POLLC1_ACPI C2_ACPI C3_ACPI POLL% C1_ACPI%C2_ACPI

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 15:41, Zhang Rui wrote: > > > This is really hard to read. > can you please attach the two turbostat output as attachments? of course :) Guilhem Lettron turbostat version 20.03.20 - Len Brown CPUID(0): GenuineIntel 0x1b CPUID levels; 0x8000

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 15:17, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:59 PM Guilhem Lettron wrote: > > > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only report > > "C1_ACPI", "C2_ACPI" and "C3_ACPI&quo

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
6.70 3 3 221 9.01 2451 1497 4944 22 7 2627 2536 1447 0.00 9.32 41.41 39.55 23.38 0.00 67.61 54 3 7 167 7.39 2266 1497 4391 22 3 2238 2157 1668 0.00 7.39 35.25 49.42 25.00 > > Artem. > Guilhem Lettron

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 15:09, Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only > > report "C1_ACPI", "C2_ACPI" and "C3_ACPI". > > Did y

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > > > Use the same C-states as SKL > > Why is this change needed? On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only report "C1_

[PATCH] intel_idle: Add ICL support

2020-08-26 Thread Guilhem Lettron
Use the same C-states as SKL Signed-off-by: Guilhem Lettron --- drivers/idle/intel_idle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index 8e0fb1a5bdbd..1bb539f09a4f 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle