Re: [PATCH v6 07/13] KVM: s390: introduce struct kvm_s390_gisa_interrupt

2019-01-28 Thread Halil Pasic
ixed ASAP but does not affect the validity of this patch). Reviewed-by: Halil Pasic > --- > arch/s390/include/asm/kvm_host.h | 6 - > arch/s390/kvm/interrupt.c| 52 > +++- > arch/s390/kvm/kvm-s390.c | 2 +- > 3 files cha

Re: [PATCH v6 06/13] KVM: s390: remove kvm_s390_ from gisa static inline functions

2019-01-28 Thread Halil Pasic
Janosch Frank , David > Hildenbrand , Cornelia Huck , Halil > Pasic , Pierre Morel , Michael > Mueller > Subject: [PATCH v6 06/13] KVM: s390: remove kvm_s390_ from gisa static inline > functions > Date: Thu, 24 Jan 2019 13:59:32 +0100 > X-Mailer: git-send-email 2.13.4 > >

Re: [PATCH v6 05/13] KVM: s390: use pending_irqs_no_gisa() where appropriate

2019-01-28 Thread Halil Pasic
guess this is just a tiny optimization. Reviewed-by: Halil Pasic > --- > arch/s390/kvm/interrupt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c > index 005dbe7252e7..cb48736867ed 100644 >

Re: [PATCH v6 06/13] KVM: s390: remove kvm_s390_ from gisa static inline functions

2019-01-28 Thread Halil Pasic
On Thu, 24 Jan 2019 13:59:32 +0100 Michael Mueller wrote: > This will shorten the length of code lines. All GISA related > static inline functions are local to interrupt.c. > > Signed-off-by: Michael Mueller Reviewed-by: Halil Pasic [..]

Re: [PATCH v6 04/13] KVM: s390: coding style kvm_s390_gisa_init/clear()

2019-01-28 Thread Halil Pasic
On Thu, 24 Jan 2019 13:59:30 +0100 Michael Mueller wrote: > The change helps to reduce line length and > increases code readability. > > Signed-off-by: Michael Mueller > Reviewed-by: Cornelia Huck > Reviewed-by: Pierre Morel Reviewed-by: Halil Pasic > --- > arch/s

Re: [PATCH v6 02/13] KVM: s390: make bitmap declaration consitent

2019-01-28 Thread Halil Pasic
On Thu, 24 Jan 2019 13:59:28 +0100 Michael Mueller wrote: > Use a consistent bitmap declaration throughout the code. > > Signed-off-by: Michael Mueller Reviewed-by: Halil Pasic > --- > arch/s390/include/asm/kvm_host.h | 2 +- > arch/s390/kvm/interrupt.c| 2 +- >

Re: [PATCH v6 01/13] KVM: s390: drop obsolete else path

2019-01-28 Thread Halil Pasic
On Thu, 24 Jan 2019 13:59:27 +0100 Michael Mueller wrote: > The explicit else path specified in set_intercept_indicators_io > is not required as the function returns in case the first branch > is taken anyway. > > Signed-off-by: Michael Mueller Reviewed-by: Halil Pasic >

Re: [virtio-dev] Re: [PATCH 1/2] virtio: fix virtio_config_ops description

2019-01-14 Thread Halil Pasic
ll optional callbacks > > > > Signed-off-by: Cornelia Huck Reviewed-by: Halil Pasic > > --- > > include/linux/virtio_config.h | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/virtio_confi

Re: [PATCH v5 13/15] KVM: s390: add function process_gib_alert_list()

2019-01-09 Thread Halil Pasic
On Wed, 9 Jan 2019 15:49:56 +0100 Pierre Morel wrote: > On 09/01/2019 14:10, Halil Pasic wrote: > > On Wed, 9 Jan 2019 13:14:17 +0100 > > Pierre Morel wrote: > > > >> On 08/01/2019 16:21, Michael Mueller wrote: > >>> > >>> > >>>

Re: [PATCH v5 13/15] KVM: s390: add function process_gib_alert_list()

2019-01-09 Thread Halil Pasic
On Wed, 9 Jan 2019 13:14:17 +0100 Pierre Morel wrote: > On 08/01/2019 16:21, Michael Mueller wrote: > > > > > > On 08.01.19 13:59, Halil Pasic wrote: > >> On Wed, 19 Dec 2018 20:17:54 +0100 > >> Michael Mueller wrote: > >> > >>> This

Re: [PATCH v5 13/15] KVM: s390: add function process_gib_alert_list()

2019-01-08 Thread Halil Pasic
On Tue, 8 Jan 2019 16:21:17 +0100 Michael Mueller wrote: > >> + gisa->next_alert = origin; > >> + kvm = container_of(gisa, struct sie_page2, gisa)->kvm; > >> + /* Kick suitable vcpus */ > >> + __floating_airqs_kick(kvm); > >

Re: [PATCH v5 13/15] KVM: s390: add function process_gib_alert_list()

2019-01-08 Thread Halil Pasic
On Mon, 7 Jan 2019 20:18:03 +0100 Michael Mueller wrote: > > > On 03.01.19 15:43, Pierre Morel wrote: > > On 19/12/2018 20:17, Michael Mueller wrote: > >> This function processes the Gib Alert List (GAL). It is required > >> to run when either a gib alert interruption has been received or > >>

Re: [PATCH v5 10/15] KVM: s390: add functions to (un)register GISC with GISA

2019-01-08 Thread Halil Pasic
On Tue, 8 Jan 2019 14:41:35 +0100 Cornelia Huck wrote: > On Tue, 8 Jan 2019 14:36:13 +0100 > Halil Pasic wrote: > > > On Tue, 8 Jan 2019 11:34:44 +0100 > > Cornelia Huck wrote: > > > > > > >> > > > > >>> + spin_un

Re: [PATCH v5 10/15] KVM: s390: add functions to (un)register GISC with GISA

2019-01-08 Thread Halil Pasic
On Tue, 8 Jan 2019 11:34:44 +0100 Cornelia Huck wrote: > > >> > > >>> + spin_unlock(>arch.iam_ref_lock); > > >>> + > > >>> + return gib->nisc; > > >>> +} > > >>> +EXPORT_SYMBOL_GPL(kvm_s390_gisc_register); > > >>> + > > >>> +int kvm_s390_gisc_unregister(struct kvm *kvm, u32 gisc)

Re: [PATCH v5 13/15] KVM: s390: add function process_gib_alert_list()

2019-01-08 Thread Halil Pasic
On Wed, 19 Dec 2018 20:17:54 +0100 Michael Mueller wrote: > This function processes the Gib Alert List (GAL). It is required > to run when either a gib alert interruption has been received or > a gisa that is in the alert list is cleared or dropped. > > The GAL is build up by millicode, when

Re: [PATCH v5 11/15] KVM: s390: restore IAM in get_ipm() when IPM is clean

2019-01-06 Thread Halil Pasic
On Wed, 19 Dec 2018 20:17:52 +0100 Michael Mueller wrote: > The patch adds the parameter irq_flags and allows to > restore the Interruption Alert Mask (IAM) in the GISA > atomically while guaranteeing the IPM is clean. > > The function returns the IPM of the GISA. If the returned > value is

Re: [virtio-dev] [PATCH v2 1/2] virtio-balloon: tweak config_changed implementation

2019-01-04 Thread Halil Pasic
contexts. > The config_read_bitmap is used as a flag to the workqueue callbacks > about the related config fields that need to be read. > > Reported-by: Christian Borntraeger > Signed-off-by: Wei Wang Reviewed-by: Halil Pasic

Re: [PATCH 2/2] virtio: document virtio_config_ops restrictions

2019-01-03 Thread Halil Pasic
On Thu, 3 Jan 2019 17:08:04 +0100 Cornelia Huck wrote: > Some transports (e.g. virtio-ccw) implement virtio operations that > seem to be a simple read/write as something more involved that > cannot be done from an atomic context. > > Give at least a hint about that. > > Signed-off-by:

Re: [PATCH v1 2/2] virtio-balloon: improve update_balloon_size_func

2019-01-03 Thread Halil Pasic
On Thu, 3 Jan 2019 13:31:02 +0800 Wei Wang wrote: > There is no need to update the balloon actual register when there is no > ballooning request. This patch avoids update_balloon_size when diff is 0. > > Signed-off-by: Wei Wang Reviewed-by: Halil Pasic I would be also fi

Re: [PATCH v1 1/2] virtio-balloon: tweak config_changed implementation

2019-01-03 Thread Halil Pasic
o read config (aka. get()). But I'm fine with your formulation as well. > , so we tweak the virtballoon_changed implementation > by moving the config read operations into the related workqueue contexts. > > Signed-off-by: Wei Wang Reviewed-by: Halil Pasic [..]

Re: [virtio-dev] RE: [PATCH v1 0/2] Virtio: fix some vq allocation issues

2019-01-02 Thread Halil Pasic
On Wed, 2 Jan 2019 19:02:33 +0100 Cornelia Huck wrote: > On Wed, 2 Jan 2019 16:59:19 +0100 > Halil Pasic wrote: > > > On Wed, 2 Jan 2019 14:23:38 +0100 > > Cornelia Huck wrote: > > > > > On Wed, 2 Jan 2019 10:53:14 +0100 > > > Cornelia Huck wro

Re: [virtio-dev] RE: [PATCH v1 0/2] Virtio: fix some vq allocation issues

2019-01-02 Thread Halil Pasic
On Wed, 2 Jan 2019 14:23:38 +0100 Cornelia Huck wrote: > On Wed, 2 Jan 2019 10:53:14 +0100 > Cornelia Huck wrote: > > > On Tue, 1 Jan 2019 00:40:19 +0100 > > Halil Pasic wrote: > > > > As I said, at the moment I don't have a preference regarding the fix,

Re: [virtio-dev] RE: [PATCH v1 0/2] Virtio: fix some vq allocation issues

2019-01-02 Thread Halil Pasic
On Wed, 2 Jan 2019 10:53:14 +0100 Cornelia Huck wrote: > On Tue, 1 Jan 2019 00:40:19 +0100 > Halil Pasic wrote: > > > On Mon, 31 Dec 2018 06:03:51 + > > "Wang, Wei W" wrote: > > > > > On Sunday, December 30, 2018 2:06 PM, Halil Pasic wrote

Re: [virtio-dev] RE: [PATCH v1 0/2] Virtio: fix some vq allocation issues

2018-12-31 Thread Halil Pasic
On Mon, 31 Dec 2018 06:03:51 + "Wang, Wei W" wrote: > On Sunday, December 30, 2018 2:06 PM, Halil Pasic wrote: > > > > I guess you are the first one trying to read virtio config from within > > interrupt > > context. AFAICT this never worked.

Re: [PATCH v1 0/2] Virtio: fix some vq allocation issues

2018-12-29 Thread Halil Pasic
On Sat, 29 Dec 2018 02:45:49 + "Wang, Wei W" wrote: > On Friday, December 28, 2018 3:57 PM, Christian Borntraeger wrote: > > On 28.12.2018 03:26, Wei Wang wrote: > > > Some vqs don't need to be allocated when the related feature bits are > > > disabled. Callers notice the vq allocation layer

Re: [PATCH v5 05/15] KVM: s390: unify pending_irqs() and pending_irqs_no_gisa()

2018-12-20 Thread Halil Pasic
On Thu, 20 Dec 2018 12:49:56 +0100 Michael Mueller wrote: > > > On 20.12.18 12:06, Cornelia Huck wrote: > > On Wed, 19 Dec 2018 20:17:46 +0100 > > Michael Mueller wrote: > > > >> Use a single function with parameter irq_flags to differentiate > >> between cases. > >> > >> New irq flag: > >>

Re: [PATCH v3 6/6] vfio: ccw: serialize the write system calls

2018-12-14 Thread Halil Pasic
On Thu, 13 Dec 2018 16:39:53 +0100 Cornelia Huck wrote: > On Wed, 28 Nov 2018 13:41:07 +0100 > Pierre Morel wrote: > > > When the user program is QEMU we rely on the QEMU lock to serialize > > the calls to the driver. > > > > In the general case we need to make sure that two data transfer are

Re: [PATCH] MAINTAINERS/vfio-ccw: add Farhan and Eric, make Halil Reviewer

2018-12-12 Thread Halil Pasic
On Wed, 12 Dec 2018 15:59:29 +0100 Christian Borntraeger wrote: > Eric and Farhan will help with maintaining vfio-ccw. > > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Farhan Ali > Cc: Eric Farman > Signed-off-by: Christian Borntraeger Acked-by: Halil Pasic >

Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Halil Pasic
On Fri, 16 Nov 2018 11:47:48 +0100 Petr Tesarik wrote: > The driver uses test_facility(), but does not include the > corresponding include file explicitly. The driver currently builds > only thanks to the following include chain: > > vfio_ap_drv.c > > > > >

Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Halil Pasic
On Fri, 16 Nov 2018 11:47:48 +0100 Petr Tesarik wrote: > The driver uses test_facility(), but does not include the > corresponding include file explicitly. The driver currently builds > only thanks to the following include chain: > > vfio_ap_drv.c > > > > >

Re: [PATCH v1 0/2] KVM: s390: Tracing APCB changes

2018-10-05 Thread Halil Pasic
On 10/05/2018 10:31 AM, Pierre Morel wrote: > In the first patch we define kvm_arch_crypto_set_masks, > a new function to centralize the setup the APCB masks > inside the CRYCB SIE satelite and add KVM_EVENT() to > kvm_arch_crypto_set_masks and kvm_arch_crypto_clear_masks. > > In the second

Re: [PATCH v1 0/2] KVM: s390: Tracing APCB changes

2018-10-05 Thread Halil Pasic
On 10/05/2018 10:31 AM, Pierre Morel wrote: > In the first patch we define kvm_arch_crypto_set_masks, > a new function to centralize the setup the APCB masks > inside the CRYCB SIE satelite and add KVM_EVENT() to > kvm_arch_crypto_set_masks and kvm_arch_crypto_clear_masks. > > In the second

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Halil Pasic
On 09/28/2018 03:35 PM, Cornelia Huck wrote: > On Fri, 28 Sep 2018 09:33:21 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Fixes case statement in vfio_ap_mdev_copy_masks() function in >> vfio-ap-ops.c. >> --- >> drivers/s390/crypto/vfio_ap_ops.c | 3 ++- >> 1 file changed, 2

Re: [FIXUP v11] fixup! s390: vfio-ap: implement mediated device open callback

2018-09-28 Thread Halil Pasic
On 09/28/2018 03:35 PM, Cornelia Huck wrote: > On Fri, 28 Sep 2018 09:33:21 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak >> >> Fixes case statement in vfio_ap_mdev_copy_masks() function in >> vfio-ap-ops.c. >> --- >> drivers/s390/crypto/vfio_ap_ops.c | 3 ++- >> 1 file changed, 2

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-27 Thread Halil Pasic
On 09/27/2018 12:42 AM, Alex Williamson wrote: > On Tue, 25 Sep 2018 19:16:41 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak [..] >> + >> +2. Secure the AP queues to be used by the three guests so that the host can >> not >> + access them. To secure them, there are two sysfs files

Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

2018-09-27 Thread Halil Pasic
On 09/27/2018 12:42 AM, Alex Williamson wrote: > On Tue, 25 Sep 2018 19:16:41 -0400 > Tony Krowiak wrote: > >> From: Tony Krowiak [..] >> + >> +2. Secure the AP queues to be used by the three guests so that the host can >> not >> + access them. To secure them, there are two sysfs files

Re: [PATCH v10 13/26] s390: vfio-ap: zeroize the AP queues

2018-09-24 Thread Halil Pasic
d. >> >> Zeroizing a queue resets the queue, clears all pending >> messages for the queue entries and disables adapter interruptions >> associated with the queue. >> >> Signed-off-by: Tony Krowiak >> Reviewed-by: Halil Pasic >> Tested-by: M

Re: [PATCH v10 13/26] s390: vfio-ap: zeroize the AP queues

2018-09-24 Thread Halil Pasic
d. >> >> Zeroizing a queue resets the queue, clears all pending >> messages for the queue entries and disables adapter interruptions >> associated with the queue. >> >> Signed-off-by: Tony Krowiak >> Reviewed-by: Halil Pasic >> Tested-by: M

Re: [PATCH v10 10/26] KVM: s390: interfaces to clear CRYCB masks

2018-09-24 Thread Halil Pasic
l the patch description is correct. Regards, Halil >> >> Signed-off-by: Tony Krowiak >> Acked-by: Halil Pasic >> Tested-by: Michael Mueller >> Tested-by: Farhan Ali >> Tested-by: Pierre Morel >> Signed-off-by: Christian Borntraeger >

Re: [PATCH v10 10/26] KVM: s390: interfaces to clear CRYCB masks

2018-09-24 Thread Halil Pasic
l the patch description is correct. Regards, Halil >> >> Signed-off-by: Tony Krowiak >> Acked-by: Halil Pasic >> Tested-by: Michael Mueller >> Tested-by: Farhan Ali >> Tested-by: Pierre Morel >> Signed-off-by: Christian Borntraeger >

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-18 Thread Halil Pasic
On 09/12/2018 09:43 PM, Tony Krowiak wrote: > +/** > + * vfio_ap_mdev_open_once > + * > + * @matrix_mdev: a mediated matrix device > + * > + * Return 0 if no other mediated matrix device has been opened for the > + * KVM guest assigned to @matrix_mdev; otherwise, returns an error. > + */ >

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-18 Thread Halil Pasic
On 09/12/2018 09:43 PM, Tony Krowiak wrote: > +/** > + * vfio_ap_mdev_open_once > + * > + * @matrix_mdev: a mediated matrix device > + * > + * Return 0 if no other mediated matrix device has been opened for the > + * KVM guest assigned to @matrix_mdev; otherwise, returns an error. > + */ >

Re: [PATCH v9 13/22] s390: vfio-ap: sysfs interface to view matrix mdev matrix

2018-09-13 Thread Halil Pasic
eadable format. I would prefer an interface where one can set at least one whole mask in one go over the current one that let us manipulate just one bit at a time. Hallil Signed-off-by: Tony Krowiak Reviewed-by: Halil Pasic Tested-by: Michael Mueller Tested-by: Farhan Ali Tested-by: Pier

Re: [PATCH v9 13/22] s390: vfio-ap: sysfs interface to view matrix mdev matrix

2018-09-13 Thread Halil Pasic
eadable format. I would prefer an interface where one can set at least one whole mask in one go over the current one that let us manipulate just one bit at a time. Hallil Signed-off-by: Tony Krowiak Reviewed-by: Halil Pasic Tested-by: Michael Mueller Tested-by: Farhan Ali Tested-by: Pier

Re: [PATCH v9 09/22] s390: vfio-ap: register matrix device with VFIO mdev framework

2018-09-10 Thread Halil Pasic
ces/vfio_ap/matrix/[$uuid] Signed-off-by: Tony Krowiak Reviewed-by: Halil Pasic Tested-by: Michael Mueller Tested-by: Farhan Ali Signed-off-by: Christian Borntraeger ---   MAINTAINERS   |    1 +   drivers/s390/crypto/Makefile  |    2 +-   drivers/s390/cry

Re: [PATCH v9 09/22] s390: vfio-ap: register matrix device with VFIO mdev framework

2018-09-10 Thread Halil Pasic
ces/vfio_ap/matrix/[$uuid] Signed-off-by: Tony Krowiak Reviewed-by: Halil Pasic Tested-by: Michael Mueller Tested-by: Farhan Ali Signed-off-by: Christian Borntraeger ---   MAINTAINERS   |    1 +   drivers/s390/crypto/Makefile  |    2 +-   drivers/s390/cry

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-27 Thread Halil Pasic
On 08/27/2018 03:51 PM, Cornelia Huck wrote: On Mon, 27 Aug 2018 09:47:58 -0400 Tony Krowiak wrote: On 08/27/2018 04:33 AM, Cornelia Huck wrote: On Thu, 23 Aug 2018 10:16:59 -0400 Tony Krowiak wrote: On 08/23/2018 06:25 AM, Cornelia Huck wrote: On Wed, 22 Aug 2018 15:16:19 -0400

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-27 Thread Halil Pasic
On 08/27/2018 03:51 PM, Cornelia Huck wrote: On Mon, 27 Aug 2018 09:47:58 -0400 Tony Krowiak wrote: On 08/27/2018 04:33 AM, Cornelia Huck wrote: On Thu, 23 Aug 2018 10:16:59 -0400 Tony Krowiak wrote: On 08/23/2018 06:25 AM, Cornelia Huck wrote: On Wed, 22 Aug 2018 15:16:19 -0400

Re: [PATCH v9 21/22] KVM: s390: CPU model support for AP virtualization

2018-08-24 Thread Halil Pasic
On 08/23/2018 07:40 PM, David Hildenbrand wrote: On 23.08.2018 19:35, Tony Krowiak wrote: On 08/23/2018 10:59 AM, Pierre Morel wrote: On 23/08/2018 15:38, David Hildenbrand wrote: On 23.08.2018 15:22, Halil Pasic wrote: On 08/23/2018 02:47 PM, Pierre Morel wrote: On 23/08/2018 13:12

Re: [PATCH v9 21/22] KVM: s390: CPU model support for AP virtualization

2018-08-24 Thread Halil Pasic
On 08/23/2018 07:40 PM, David Hildenbrand wrote: On 23.08.2018 19:35, Tony Krowiak wrote: On 08/23/2018 10:59 AM, Pierre Morel wrote: On 23/08/2018 15:38, David Hildenbrand wrote: On 23.08.2018 15:22, Halil Pasic wrote: On 08/23/2018 02:47 PM, Pierre Morel wrote: On 23/08/2018 13:12

Re: [PATCH v9 21/22] KVM: s390: CPU model support for AP virtualization

2018-08-23 Thread Halil Pasic
On 08/23/2018 02:47 PM, Pierre Morel wrote: On 23/08/2018 13:12, David Hildenbrand wrote: [..] I'm confused, which 128 bit? Me too :) , I was assuming this block to be 128bit, but the qci block has 128 bytes And looking at arch/s390/include/asm/ap.h, there is a lot of information

Re: [PATCH v9 21/22] KVM: s390: CPU model support for AP virtualization

2018-08-23 Thread Halil Pasic
On 08/23/2018 02:47 PM, Pierre Morel wrote: On 23/08/2018 13:12, David Hildenbrand wrote: [..] I'm confused, which 128 bit? Me too :) , I was assuming this block to be 128bit, but the qci block has 128 bytes And looking at arch/s390/include/asm/ap.h, there is a lot of information

Re: [PATCH v9 21/22] KVM: s390: CPU model support for AP virtualization

2018-08-23 Thread Halil Pasic
, then no AP devices will be available to the guest regardless of the guest's matrix configuration for the virtual machine. This is a limitation of the Linux AP bus. Signed-off-by: Tony Krowiak Reviewed-by: Christian Borntraeger Reviewed-by: Halil Pasic Tested-by: Michael Mueller

Re: [PATCH v9 21/22] KVM: s390: CPU model support for AP virtualization

2018-08-23 Thread Halil Pasic
, then no AP devices will be available to the guest regardless of the guest's matrix configuration for the virtual machine. This is a limitation of the Linux AP bus. Signed-off-by: Tony Krowiak Reviewed-by: Christian Borntraeger Reviewed-by: Halil Pasic Tested-by: Michael Mueller

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-23 Thread Halil Pasic
On 08/22/2018 09:16 PM, Tony Krowiak wrote: On 08/22/2018 01:11 PM, Halil Pasic wrote: On 08/22/2018 05:48 PM, Christian Borntraeger wrote: On 08/22/2018 05:34 PM, Pierre Morel wrote: On 22/08/2018 17:11, Christian Borntraeger wrote: On 08/22/2018 01:03 PM, Pierre Morel wrote: That's

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-23 Thread Halil Pasic
On 08/22/2018 09:16 PM, Tony Krowiak wrote: On 08/22/2018 01:11 PM, Halil Pasic wrote: On 08/22/2018 05:48 PM, Christian Borntraeger wrote: On 08/22/2018 05:34 PM, Pierre Morel wrote: On 22/08/2018 17:11, Christian Borntraeger wrote: On 08/22/2018 01:03 PM, Pierre Morel wrote: That's

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-22 Thread Halil Pasic
On 08/22/2018 05:48 PM, Christian Borntraeger wrote: On 08/22/2018 05:34 PM, Pierre Morel wrote: On 22/08/2018 17:11, Christian Borntraeger wrote: On 08/22/2018 01:03 PM, Pierre Morel wrote: That's interesting. IMHO this quote is quite a half-full half-empty cup one: * it mandates the

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-22 Thread Halil Pasic
On 08/22/2018 05:48 PM, Christian Borntraeger wrote: On 08/22/2018 05:34 PM, Pierre Morel wrote: On 22/08/2018 17:11, Christian Borntraeger wrote: On 08/22/2018 01:03 PM, Pierre Morel wrote: That's interesting. IMHO this quote is quite a half-full half-empty cup one: * it mandates the

Re: [PATCH v9 22/22] s390: doc: detailed specifications for AP virtualization

2018-08-22 Thread Halil Pasic
On 08/22/2018 12:13 PM, Harald Freudenberger wrote: ... about control domains Talked with the s390 firmware guys. The convention that the control domain mask is a superset of the usage domain mask is only true for 1st level guests. It is absolutely valid to run a kvm guest with restricted

Re: [PATCH v9 22/22] s390: doc: detailed specifications for AP virtualization

2018-08-22 Thread Halil Pasic
On 08/22/2018 12:13 PM, Harald Freudenberger wrote: ... about control domains Talked with the s390 firmware guys. The convention that the control domain mask is a superset of the usage domain mask is only true for 1st level guests. It is absolutely valid to run a kvm guest with restricted

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-22 Thread Halil Pasic
On 08/22/2018 11:42 AM, Cornelia Huck wrote: On Wed, 22 Aug 2018 01:18:20 +0200 Halil Pasic wrote: On 08/21/2018 07:07 PM, Tony Krowiak wrote: This convention has been enforced by the kernel since v1. This is also enforced by both the LPAR as well as in z/VM. The following is from the PR

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-22 Thread Halil Pasic
On 08/22/2018 11:42 AM, Cornelia Huck wrote: On Wed, 22 Aug 2018 01:18:20 +0200 Halil Pasic wrote: On 08/21/2018 07:07 PM, Tony Krowiak wrote: This convention has been enforced by the kernel since v1. This is also enforced by both the LPAR as well as in z/VM. The following is from the PR

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-21 Thread Halil Pasic
On 08/21/2018 07:07 PM, Tony Krowiak wrote: On 08/21/2018 11:25 AM, Cornelia Huck wrote: On Mon, 20 Aug 2018 13:41:32 -0400 Tony Krowiak wrote: On 08/20/2018 10:23 AM, Cornelia Huck wrote: On Mon, 13 Aug 2018 17:48:09 -0400 Tony Krowiak wrote: From: Tony Krowiak Provides the sysfs

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-21 Thread Halil Pasic
On 08/21/2018 07:07 PM, Tony Krowiak wrote: On 08/21/2018 11:25 AM, Cornelia Huck wrote: On Mon, 20 Aug 2018 13:41:32 -0400 Tony Krowiak wrote: On 08/20/2018 10:23 AM, Cornelia Huck wrote: On Mon, 13 Aug 2018 17:48:09 -0400 Tony Krowiak wrote: From: Tony Krowiak Provides the sysfs

Re: [PATCH v9 22/22] s390: doc: detailed specifications for AP virtualization

2018-08-21 Thread Halil Pasic
On 08/20/2018 10:16 PM, Tony Krowiak wrote: Does the SIE complain if you specify a control domain that the host does not have access to (I'd guess so)? The SIE does not complain if you specify a domain to which the host - or a lower level guest - does not have access. The firmware performs 

Re: [PATCH v9 22/22] s390: doc: detailed specifications for AP virtualization

2018-08-21 Thread Halil Pasic
On 08/20/2018 10:16 PM, Tony Krowiak wrote: Does the SIE complain if you specify a control domain that the host does not have access to (I'd guess so)? The SIE does not complain if you specify a domain to which the host - or a lower level guest - does not have access. The firmware performs 

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-20 Thread Halil Pasic
On 08/20/2018 04:23 PM, Cornelia Huck wrote: On Mon, 13 Aug 2018 17:48:09 -0400 Tony Krowiak wrote: From: Tony Krowiak Provides the sysfs interfaces for: 1. Assigning AP control domains to the mediated matrix device 2. Unassigning AP control domains from a mediated matrix device 3.

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-20 Thread Halil Pasic
On 08/20/2018 04:23 PM, Cornelia Huck wrote: On Mon, 13 Aug 2018 17:48:09 -0400 Tony Krowiak wrote: From: Tony Krowiak Provides the sysfs interfaces for: 1. Assigning AP control domains to the mediated matrix device 2. Unassigning AP control domains from a mediated matrix device 3.

Re: [PATCH v6 13/21] s390: vfio-ap: sysfs interface to view matrix mdev matrix

2018-07-13 Thread Halil Pasic
On 07/13/2018 02:24 PM, Tony Krowiak wrote: On 07/09/2018 04:38 PM, Pierre Morel wrote: On 09/07/2018 14:20, Pierre Morel wrote: On 29/06/2018 23:11, Tony Krowiak wrote: Provides a sysfs interface to view the AP matrix configured for the mediated matrix device. The relevant sysfs

Re: [PATCH v6 13/21] s390: vfio-ap: sysfs interface to view matrix mdev matrix

2018-07-13 Thread Halil Pasic
On 07/13/2018 02:24 PM, Tony Krowiak wrote: On 07/09/2018 04:38 PM, Pierre Morel wrote: On 09/07/2018 14:20, Pierre Morel wrote: On 29/06/2018 23:11, Tony Krowiak wrote: Provides a sysfs interface to view the AP matrix configured for the mediated matrix device. The relevant sysfs

Re: [PATCH v6 14/21] s390: vfio-ap: implement mediated device open callback

2018-07-13 Thread Halil Pasic
On 07/12/2018 06:03 PM, Tony Krowiak wrote: +static int vfio_ap_mdev_open(struct mdev_device *mdev) +{ +struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev); +struct ap_matrix_dev *matrix_dev = +to_ap_matrix_dev(mdev_parent_dev(mdev)); +unsigned long events; +

Re: [PATCH v6 14/21] s390: vfio-ap: implement mediated device open callback

2018-07-13 Thread Halil Pasic
On 07/12/2018 06:03 PM, Tony Krowiak wrote: +static int vfio_ap_mdev_open(struct mdev_device *mdev) +{ +struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev); +struct ap_matrix_dev *matrix_dev = +to_ap_matrix_dev(mdev_parent_dev(mdev)); +unsigned long events; +

Re: [PATCH v6 15/21] s390: vfio-ap: configure the guest's AP matrix

2018-07-12 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: From: Tony Krowiak Configures the AP adapters, usage domains and control domains for the [..] +static inline void kvm_ap_clear_crycb_masks(struct ap_matrix_mdev *matrix_mdev) +{ + memset(_mdev->kvm->arch.crypto.crycb->apcb0, 0, +

Re: [PATCH v6 15/21] s390: vfio-ap: configure the guest's AP matrix

2018-07-12 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: From: Tony Krowiak Configures the AP adapters, usage domains and control domains for the [..] +static inline void kvm_ap_clear_crycb_masks(struct ap_matrix_mdev *matrix_mdev) +{ + memset(_mdev->kvm->arch.crypto.crycb->apcb0, 0, +

Re: [PATCH v6 14/21] s390: vfio-ap: implement mediated device open callback

2018-07-12 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified, the vfio_ap device driver will get access to the guest's kvm

Re: [PATCH v6 14/21] s390: vfio-ap: implement mediated device open callback

2018-07-12 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified, the vfio_ap device driver will get access to the guest's kvm

Re: [PATCH v6 15/21] s390: vfio-ap: configure the guest's AP matrix

2018-07-11 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: From: Tony Krowiak Configures the AP adapters, usage domains and control domains for the KVM guest from the matrix configured via the mediated matrix device's sysfs attribute files. [..] + +static void kvm_ap_set_crycb_masks(struct

Re: [PATCH v6 15/21] s390: vfio-ap: configure the guest's AP matrix

2018-07-11 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: From: Tony Krowiak Configures the AP adapters, usage domains and control domains for the KVM guest from the matrix configured via the mediated matrix device's sysfs attribute files. [..] + +static void kvm_ap_set_crycb_masks(struct

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-09 Thread Halil Pasic
On 07/09/2018 05:21 AM, Pierre Morel wrote: On 03/07/2018 01:10, Halil Pasic wrote: On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-09 Thread Halil Pasic
On 07/09/2018 05:21 AM, Pierre Morel wrote: On 03/07/2018 01:10, Halil Pasic wrote: On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how

Re: [PATCH v6 09/21] s390: vfio-ap: structure for storing mdev matrix

2018-07-06 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: From: Tony Krowiak Introduces a new structure for storing the AP matrix configured for the mediated matrix device via its sysfs attributes files. Signed-off-by: Tony Krowiak --- drivers/s390/crypto/vfio_ap_ops.c | 12

Re: [PATCH v6 09/21] s390: vfio-ap: structure for storing mdev matrix

2018-07-06 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: From: Tony Krowiak Introduces a new structure for storing the AP matrix configured for the mediated matrix device via its sysfs attributes files. Signed-off-by: Tony Krowiak --- drivers/s390/crypto/vfio_ap_ops.c | 12

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 04:30 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 15:58:37 +0200 Halil Pasic wrote: On 07/03/2018 03:25 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 14:20:11 +0200 Halil Pasic wrote: On 07/03/2018 01:52 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 11:22:10 +0200 Halil

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 04:30 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 15:58:37 +0200 Halil Pasic wrote: On 07/03/2018 03:25 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 14:20:11 +0200 Halil Pasic wrote: On 07/03/2018 01:52 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 11:22:10 +0200 Halil

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 03:25 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 14:20:11 +0200 Halil Pasic wrote: On 07/03/2018 01:52 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 11:22:10 +0200 Halil Pasic wrote: [..] Let me try to invoke the DASD analogy. If one for some reason wants to detach

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 03:25 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 14:20:11 +0200 Halil Pasic wrote: On 07/03/2018 01:52 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 11:22:10 +0200 Halil Pasic wrote: [..] Let me try to invoke the DASD analogy. If one for some reason wants to detach

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 01:52 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 11:22:10 +0200 Halil Pasic wrote: [..] Let me try to invoke the DASD analogy. If one for some reason wants to detach a DASD the procedure to follow seems to be (see https://www.ibm.com/support/knowledgecenter/en/linuxonibm

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 01:52 PM, Cornelia Huck wrote: On Tue, 3 Jul 2018 11:22:10 +0200 Halil Pasic wrote: [..] Let me try to invoke the DASD analogy. If one for some reason wants to detach a DASD the procedure to follow seems to be (see https://www.ibm.com/support/knowledgecenter/en/linuxonibm

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 09:46 AM, Harald Freudenberger wrote: On 02.07.2018 18:28, Halil Pasic wrote: On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-03 Thread Halil Pasic
On 07/03/2018 09:46 AM, Harald Freudenberger wrote: On 02.07.2018 18:28, Halil Pasic wrote: On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-02 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-02 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-02 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak

Re: [PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-07-02 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak

Re: [PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization

2018-07-02 Thread Halil Pasic
, then no AP devices will be available to the guest regardless of the guest's matrix configuration. This is a limitation of the AP bus running under the guest. Reviewed-by: Christian Borntraeger Reviewed-by: Halil Pasic Signed-off-by: Tony Krowiak I think it probably should be at the end

Re: [PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization

2018-07-02 Thread Halil Pasic
, then no AP devices will be available to the guest regardless of the guest's matrix configuration. This is a limitation of the AP bus running under the guest. Reviewed-by: Christian Borntraeger Reviewed-by: Halil Pasic Signed-off-by: Tony Krowiak I think it probably should be at the end

Re: [PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization

2018-07-02 Thread Halil Pasic
Borntraeger Reviewed-by: Halil Pasic Signed-off-by: Tony Krowiak I think it probably should be at the end of the series, other than that its good. If I move this to the end of the series, the very next patch checks the KVM_S390_VM_CPU_FEAT_AP feature? The point is the following: never expose

Re: [PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization

2018-07-02 Thread Halil Pasic
Borntraeger Reviewed-by: Halil Pasic Signed-off-by: Tony Krowiak I think it probably should be at the end of the series, other than that its good. If I move this to the end of the series, the very next patch checks the KVM_S390_VM_CPU_FEAT_AP feature? The point is the following: never expose

Re: [PATCH v6 07/21] s390: vfio-ap: base implementation of VFIO AP device driver

2018-07-02 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: Introduces a new AP device driver. This device driver is built on the VFIO mediated device framework. The framework provides sysfs interfaces that facilitate passthrough access by guests to devices installed on the linux host. The VFIO AP device

Re: [PATCH v6 07/21] s390: vfio-ap: base implementation of VFIO AP device driver

2018-07-02 Thread Halil Pasic
On 06/29/2018 11:11 PM, Tony Krowiak wrote: Introduces a new AP device driver. This device driver is built on the VFIO mediated device framework. The framework provides sysfs interfaces that facilitate passthrough access by guests to devices installed on the linux host. The VFIO AP device

<    1   2   3   4   >