nks for your thorough report
on the issue my changes caused and pass on my apologies to your Mom!
>
> > On Fri 11 Sep 20, 09:25, Hamish Martin wrote:
> > > Some integrated OHCI controller hubs do not expose all ports of
> > > the hub
> > > to pins on the SoC. In
The 'distrust_firmware' module parameter dates from 2004 and the USB
subsystem is a lot more mature and reliable now than it was then.
Alter the default to false now.
Suggested-by: Alan Stern
Signed-off-by: Hamish Martin
---
drivers/usb/host/ohci-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1
set to per-port rather than the previous behaviour where it was either
none or global over-current protection depending on the value at
function entry.
Suggested-by: Alan Stern
Signed-off-by: Hamish Martin
---
Notes:
Changes in v2:
- remove clearing of RH_A_PSM in OHCI_QUIRK_HUB_P
On Wed, 2020-09-09 at 10:05 -0400, Alan Stern wrote:
> On Wed, Sep 09, 2020 at 03:57:34PM +1200, Hamish Martin wrote:
> > Some integrated OHCI controller hubs do not expose all ports of the
> > hub
> > to pins on the SoC. In some cases the unconnected ports generate
>
set to per-port rather than the previous behaviour where it was either
none or global over-current protection depending on the value at
function entry.
Suggested-by: Alan Stern
Signed-off-by: Hamish Martin
---
drivers/usb/host/ohci-hcd.c | 17 +++--
1 file changed, 11 insert
On Mon, 2020-09-07 at 10:59 -0400, st...@rowland.harvard.edu wrote:
> On Mon, Sep 07, 2020 at 01:50:10AM +0000, Hamish Martin wrote:
> > Hi Alan,
> >
> > Thanks for your quick feedback. My replies are inline below.
> >
> > On Fri, 2020-09-04 at 11:45 -0400, Alan
Hi Alan,
Thanks for your quick feedback. My replies are inline below.
On Fri, 2020-09-04 at 11:45 -0400, Alan Stern wrote:
> On Fri, Sep 04, 2020 at 03:22:46PM +1200, Hamish Martin wrote:
> > Some integrated OHCI controller hubs do not expose all ports of the
> > hub
> &g
OHCI overcurrent protection defaults to Global or "ganged" overcurrent
protection mode. This new property allows for the Individual Port
Over-current Protection to be selected when required.
Signed-off-by: Hamish Martin
---
Documentation/devicetree/bindings/usb/generic-ohci.yaml |
Add a dt-binding to select per-port overcurrent protection mode so handle
spurious overcurrent events from unconnected ports.
Hamish Martin (2):
usb: ohci: Add per-port overcurrent quirk
dt-bindings: usb: generic-ohci: Document per-port-overcurrent property
Documentation/devicetree/bindings
for ohci-platform driver is to use "ganged"
overcurrent protection mode. This leads to the spurious overcurrent
events affecting all ports in the hub.
Allow this to be rectified by specifying per-port overcurrent protection
mode via the device tree.
Signed-off-by: Hamish Martin
---
driver
> err_request_irq:
> uio_dev_del_attributes(idev);
> err_uio_dev_add_attributes:
> - device_unregister(>dev);
> + device_del(>dev);
> err_device_create:
> uio_free_minor(idev);
> + put_device(>dev);
> return ret;
> }
> EXPORT_SYMBOL_GPL(__uio_register_device);
Looks good to me. Thanks for dealing with those issues.
Reviewed-by: Hamish Martin
Hi Xiubo,
Tested-by: Hamish Martin
I see these were already merged into Linus' tree but I wanted to let you
know that I tested v4.18-rc4 (which contains these three patches) and
the issue which led to my original series is still fixed and this patch
series of yours has caused no regression
Hi Xiubo,
Tested-by: Hamish Martin
I see these were already merged into Linus' tree but I wanted to let you
know that I tested v4.18-rc4 (which contains these three patches) and
the issue which led to my original series is still fixed and this patch
series of yours has caused no regression
Looks ok to me.
Reviewed-by: Hamish Martin
On 07/06/2018 02:57 PM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> For the target_core_user use case, after the device is unregistered
> it maybe still opened in user space, then the kernel will crash, like:
>
> [ 251.163692] BUG
Looks ok to me.
Reviewed-by: Hamish Martin
On 07/06/2018 02:57 PM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> For the target_core_user use case, after the device is unregistered
> it maybe still opened in user space, then the kernel will crash, like:
>
> [ 251.163692] BUG
Looks ok to me.
Reviewed-by: Hamish Martin
On 07/06/2018 02:57 PM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> We are hitting a regression with the following commit:
>
> commit a93e7b331568227500186a465fee3c2cb5dffd1f
> Author: Hamish Martin
> Date: Mon May 1
Looks ok to me.
Reviewed-by: Hamish Martin
On 07/06/2018 02:57 PM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> We are hitting a regression with the following commit:
>
> commit a93e7b331568227500186a465fee3c2cb5dffd1f
> Author: Hamish Martin
> Date: Mon May 1
Hi Xiubo,
Thanks for your patch that addresses the regression found with my
earlier commit.
I will take your code and run it in our scenario that showed the bug
that led to my commit. Unfortunately I won't be able to get that done
until mid-next week. I intend to report back to you by July
Hi Xiubo,
Thanks for your patch that addresses the regression found with my
earlier commit.
I will take your code and run it in our scenario that showed the bug
that led to my commit. Unfortunately I won't be able to get that done
until mid-next week. I intend to report back to you by July
.
On 06/21/2018 04:06 AM, Mike Christie wrote:
> Hi Hamish,
>
> I am hitting a regression with your patch:
>
> commit a93e7b331568227500186a465fee3c2cb5dffd1f
> Author: Hamish Martin
> Date: Mon May 14 13:32:23 2018 +1200
>
> uio: Prevent device destruction while f
.
On 06/21/2018 04:06 AM, Mike Christie wrote:
> Hi Hamish,
>
> I am hitting a regression with your patch:
>
> commit a93e7b331568227500186a465fee3c2cb5dffd1f
> Author: Hamish Martin
> Date: Mon May 14 13:32:23 2018 +1200
>
> uio: Prevent device destruction while f
-off-by: Hamish Martin <hamish.mar...@alliedtelesis.co.nz>
Reviewed-by: Chris Packham <chris.pack...@alliedtelesis.co.nz>
---
v2: Resolve compiler error detected by kbuild test robot due to missing
include of device.h in uio_driver.h
drivers/uio/uio.c
-off-by: Hamish Martin
Reviewed-by: Chris Packham
---
v2: Resolve compiler error detected by kbuild test robot due to missing
include of device.h in uio_driver.h
drivers/uio/uio.c | 98 ++
include/linux/uio_driver.h | 4 +-
2 files
Drive all return paths for uio_write() through a single block at the
end of the function.
Signed-off-by: Hamish Martin <hamish.mar...@alliedtelesis.co.nz>
Reviewed-by: Chris Packham <chris.pack...@alliedtelesis.co.nz>
---
v2: no changes
drivers/uio/uio.c | 25 +
bfe e93f0038 2fa9 40de0030 3c60
---[ end trace 8badf75b83f45856 ]---
Hamish Martin (2):
uio: Reduce return paths from uio_write()
uio: Prevent device destruction while fds are open
drivers/uio/uio.c | 121 -
include/linux/ui
Drive all return paths for uio_write() through a single block at the
end of the function.
Signed-off-by: Hamish Martin
Reviewed-by: Chris Packham
---
v2: no changes
drivers/uio/uio.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/uio
2fa9 40de0030 3c60
---[ end trace 8badf75b83f45856 ]---
Hamish Martin (2):
uio: Reduce return paths from uio_write()
uio: Prevent device destruction while fds are open
drivers/uio/uio.c | 121 -
include/linux/uio_driver.h | 4 +-
2 fil
-off-by: Hamish Martin <hamish.mar...@alliedtelesis.co.nz>
Reviewed-by: Chris Packham <chris.pack...@alliedtelesis.co.nz>
---
drivers/uio/uio.c | 98 ++
include/linux/uio_driver.h | 3 +-
2 files changed, 74 insertions(+), 27 deleti
-off-by: Hamish Martin
Reviewed-by: Chris Packham
---
drivers/uio/uio.c | 98 ++
include/linux/uio_driver.h | 3 +-
2 files changed, 74 insertions(+), 27 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index dd44df17004d
bfe e93f0038 2fa9 40de0030 3c60
---[ end trace 8badf75b83f45856 ]---
Hamish Martin (2):
uio: Reduce return paths from uio_write()
uio: Prevent device destruction while fds are open
drivers/uio/uio.c | 121 -
include/linux/ui
Drive all return paths for uio_write() through a single block at the
end of the function.
Signed-off-by: Hamish Martin <hamish.mar...@alliedtelesis.co.nz>
Reviewed-by: Chris Packham <chris.pack...@alliedtelesis.co.nz>
---
drivers/uio/uio.c | 25 +
1 file
2fa9 40de0030 3c60
---[ end trace 8badf75b83f45856 ]---
Hamish Martin (2):
uio: Reduce return paths from uio_write()
uio: Prevent device destruction while fds are open
drivers/uio/uio.c | 121 -
include/linux/uio_driver.h | 3 +-
2 fil
Drive all return paths for uio_write() through a single block at the
end of the function.
Signed-off-by: Hamish Martin
Reviewed-by: Chris Packham
---
drivers/uio/uio.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio
33 matches
Mail list logo
