Re: [PATCH] ASoC: cs53l30: Do not ignore errors if mclk is specified

2016-07-29 Thread Handrigan, Paul
On 7/28/16, 5:43 PM, "Nicolin Chen" wrote: >When the clock is specified, there could be other errors besides >the EPROBE_DEFER so don't ignore them. > >Signed-off-by: Nicolin Chen >--- > sound/soc/codecs/cs53l30.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/sound

Re: [PATCH] ASoC: cs35l33: mark PM functions as __maybe_unused

2016-06-29 Thread Handrigan, Paul
On 6/29/16, 9:33 AM, "Arnd Bergmann" wrote: >The newly added cs35l33 driver produces a harmless warning when >CONFIG_PM is disabled: > >sound/soc/codecs/cs35l33.c:908:12: error: 'cs35l33_runtime_suspend' >defined but not used [-Werror=unused-function] >sound/soc/codecs/cs35l33.c:868:12: error:

Re: [PATCH v2] ASoC: cs53l30: Add MUTE pin control support via GPIO

2016-06-22 Thread Handrigan, Paul
On 6/21/16, 6:50 PM, "Nicolin Chen" wrote: >The codec chip has a physical MUTE pin to let users control it via >GPIO. So this patch add a mute control support to the driver. > >Signed-off-by: Nicolin Chen >--- >Changelog: >v1->v2 > * Revise the DT binding part regarding the active state of the

Re: [PATCH] ASoC: cs53l30: Set idle_bias_off true

2016-06-20 Thread Handrigan, Paul
On 6/17/16, 8:31 PM, "Nicolin Chen" wrote: >The driver is using the set_bias_level to control the power on and >off so it should get SND_SOC_BIAS_OFF in order to proceed normal >powering sequences. This patch enables the idle_bias_off option so >the DAPM core will set the bias level to SND_SOC_

Re: [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings

2016-06-17 Thread Handrigan, Paul
On 6/17/16, 12:22 PM, "weiyj...@163.com" wrote: >From: Wei Yongjun > >Fixes the following sparse warnings: > >sound/soc/codecs/cs53l30.c:182:20: warning: > symbol 'input1_sel_values' was not declared. Should it be static? >sound/soc/codecs/cs53l30.c:202:20: warning: > symbol 'input2_sel_values

Re: [alsa-devel] [PATCH V2 linux-next] ASoC: cs53l30: include gpio/consumer.h

2016-06-06 Thread Handrigan, Paul
On 6/6/16, 12:05 PM, "Fabian Frederick" wrote: >cs53l30 breaks kernel compilation when CONFIG_GPIOLIB is disabled. > >sound/soc/codecs/cs53l30.c:931:2: error: implicit declaration of >function devm_gpiod_get_optional [-Werror=implicit-function-declaration] > cs53l30->reset_gpio = devm_gpiod_ge

Re: [PATCH 1/2] ASoC: cs53l30: Rename the volume controls for preamplifier

2016-05-31 Thread Handrigan, Paul
On 5/31/16, 6:06 PM, "Nicolin Chen" wrote: >Volume controls should end with 'Volume', so this patch renames them for >ADC preamplifier. > >Signed-off-by: Nicolin Chen >--- > sound/soc/codecs/cs53l30.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/sound/soc/codecs/c

Re: [PATCH 2/2] ASoC: cs53l30: Check return value of regcache_sync()

2016-05-31 Thread Handrigan, Paul
On 5/31/16, 6:06 PM, "Nicolin Chen" wrote: >Regcache_sync() might fail. So this patch adds a return value Check for >it. > >Signed-off-by: Nicolin Chen >--- > sound/soc/codecs/cs53l30.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/sound/soc/codecs/cs53l30.c b/sou