;
case DISCONNECT:{
/* Accept message by clearing
ACK */
NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE);
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote:
From: Hannes Reinecke
Some old drivers partially implemented support for linked commands using
a "proposed" next_link pointer in struct scsi_cmnd that never actually
existed. Remove this code.
Signed-off-by: Finn Thain
---
This is
+++---
drivers/scsi/atari_NCR5380.c |2 +-
2 files changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 9
insertions(+), 1 deletion(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 1
-by: Finn Thain
---
drivers/scsi/NCR5380.c | 12 +---
drivers/scsi/atari_NCR5380.c | 11 ++-
2 files changed, 15 insertions(+), 8 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@sus
4 files changed, 15 insertions(+), 161 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F
files changed, 55 insertions(+), 30 deletions(-)
Hmm. I really, _really_, wish we could move away from the 'magic'
definitions and use a proper function template.
But maybe next time.
So:
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stora
ory.git.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer
selection completes.
So just poll for BSY. We can sleep while polling now that we have a
suitable workqueue.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053
in chip register
access times between different 5380 hardware implementations.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products
mp; FLAG_NCR53C400)
hostdata->flags = FLAG_HAS_LAST_BYTE_SENT | flags;
Wouldn't it be better to use a normal (ie bound) workqueue here?
SCSI-2 is pretty much single-threaded, so shifting things onto arbitrary
CPUs don't sound very appealing.
Cheers,
Hannes
--
Dr. Hannes Rei
/history.git added some pointless release_region() calls in dtc.c,
pas16.c and t128.c.
Fix these issues.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 6
USLEEP_POLL, USLEEP_SLEEP,
#endif
#ifdef AUTOPROBE_IRQ
"AUTOPROBE_IRQ "
Wouldn't it make more sense to remove the USLEEP_WAITLONG completely?
From what I can see it is meant to indicate that WAITLONG is enabled,
but we've just removed that functionality...
Cheers
On 12/22/2015 02:17 AM, Finn Thain wrote:
NCR5380.c is not compliant with the SCSI-2 standard (at least, not with
the draft revision 10L that I have to refer to). The selection algorithm
in atari_NCR5380.c is correct, so use that.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16
csi/g_NCR5380.c |4 -
4 files changed, 15 insertions(+), 161 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Ma
191d.c |2 +-
drivers/scsi/g_NCR5380.c |2 +-
5 files changed, 3 insertions(+), 25 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUS
| 157
++-
2 files changed, 282 insertions(+), 30 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 9040
| 194 +++---
drivers/scsi/NCR5380.h |2
drivers/scsi/atari_NCR5380.c | 239
---
3 files changed, 249 insertions(+), 186 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries
selection completes.
So just poll for BSY. We can sleep while polling now that we have a
suitable workqueue.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stor
ory.git.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5,
| 30 +++---
drivers/scsi/atari_NCR5380.c |2 +-
2 files changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +
On 12/22/2015 02:18 AM, Finn Thain wrote:
From: Hannes Reinecke <h...@suse.de>
Some old drivers partially implemented support for linked commands using
a "proposed" next_link pointer in struct scsi_cmnd that never actually
existed. Remove this code.
Signed-off-by:
|1
drivers/scsi/atari_NCR5380.c | 80
+++
2 files changed, 6 insertions(+), 75 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
fth...@telegraphics.com.au>
---
drivers/scsi/NCR5380.c | 12 +---
drivers/scsi/NCR5380.h |1 -
2 files changed, 5 insertions(+), 8 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stor
0.c |7 ---
drivers/scsi/atari_NCR5380.c | 11 ---
2 files changed, 18 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 68
|4 --
drivers/scsi/g_NCR5380.c |2 -
4 files changed, 25 insertions(+), 53 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LIN
on FLAG_NO_DMA_FIXUPS. Do the same for the DMA case,
to eliminate the READ_OVERRUNS macro.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
le impact there. In the SMP case the new lock should be
uncontested even when the SCSI bus is contested.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries &
|2
drivers/scsi/g_NCR5380.c |1
drivers/scsi/sun3_scsi.c |2
6 files changed, 9 insertions(+), 162 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
enabled in the atari_NCR5380.c core driver.
Well, using ->host_scribble allows for an easy check on the midlayer if
a command has been properly released by the LLDD. But that's just a
side-note.
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
.au>
---
drivers/scsi/NCR5380.c | 31 ++--
drivers/scsi/atari_NCR5380.c | 46
---
2 files changed, 55 insertions(+), 22 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Han
in chip register
access times between different 5380 hardware implementations.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
.au>
---
drivers/scsi/NCR5380.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUS
break;
}
+ break;
case DISCONNECT:{
/* Accept message by clearing
ACK */
NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE);
Reviewed-by: Hannes Reinecke <h...@suse.com
f.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 904
5380.c | 115
+++
drivers/scsi/atari_NCR5380.c | 50 ++
2 files changed, 93 insertions(+), 72 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stor
ged, 4 insertions(+), 3 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild
s/scsi/g_NCR5380.c |6 ++
drivers/scsi/mac_scsi.c |1 -
drivers/scsi/pas16.c |4
drivers/scsi/t128.c |3 ---
12 files changed, 7 insertions(+), 34 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Han
5380.c |2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 9040
it later maybe
*/
if (flags & FLAG_NCR53C400)
hostdata->flags = FLAG_HAS_LAST_BYTE_SENT | flags;
Wouldn't it be better to use a normal (ie bound) workqueue here?
SCSI-2 is pretty much single-threaded, so shifting things onto arbitrary
CPUs don't so
-by: Finn Thain <fth...@telegraphics.com.au>
---
drivers/scsi/NCR5380.c | 12 +---
drivers/scsi/atari_NCR5380.c | 11 ++-
2 files changed, 15 insertions(+), 8 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Han
|9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 9040
-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnber
.c |8 -
drivers/scsi/g_NCR5380.c |2
4 files changed, 180 insertions(+), 173 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911
fth...@telegraphics.com.au>
---
drivers/scsi/NCR5380.c | 66
---
drivers/scsi/atari_NCR5380.c | 62
2 files changed, 75 insertions(+), 53 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com
s/scsi/atari_NCR5380.c | 20 +++-
2 files changed, 17 insertions(+), 26 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LIN
--
3 files changed, 38 insertions(+), 30 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnber
d(USLEEP_SLEEP)
+USLEEP_POLL, USLEEP_SLEEP,
#endif
#ifdef AUTOPROBE_IRQ
"AUTOPROBE_IRQ "
Wouldn't it make more sense to remove the USLEEP_WAITLONG completely?
From what I can see it is meant to indicate that WAITLONG is enabled,
but we've just removed t
/history.git added some pointless release_region() calls in dtc.c,
pas16.c and t128.c.
Fix these issues.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
t128.h |2 ++
11 files changed, 55 insertions(+), 30 deletions(-)
Hmm. I really, _really_, wish we could move away from the 'magic'
definitions and use a proper function template.
But maybe next time.
So:
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
-
| 26 +-
drivers/scsi/atari_NCR5380.c | 34 +-
2 files changed, 34 insertions(+), 26 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stor
.au>
---
drivers/scsi/NCR5380.c | 44 ++---
drivers/scsi/atari_NCR5380.c | 57
++-
2 files changed, 49 insertions(+), 52 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Han
(+), 1 deletion(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffe
| 32
drivers/scsi/t128.h |8
12 files changed, 82 insertions(+), 111 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LIN
in the assignment are swapped. Fix this and
cleanup some obsolete comments.
Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
---
drivers/scsi/atari_NCR5380.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
fth...@telegraphics.com.au>
---
drivers/scsi/NCR5380.c | 19 ---
drivers/scsi/atari_NCR5380.c | 32
2 files changed, 51 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Han
| 36
drivers/scsi/atari_NCR5380.c | 43
+++
2 files changed, 47 insertions(+), 32 deletions(-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stor
clear from the
patch.
So:
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guil
clear from the
patch.
So:
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J
On 12/18/2015 03:02 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote:
On 12/18/2015 02:49 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than
On 12/18/2015 02:49 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than that. To figure out the actual size one has to read
the VPD area until the 'end marker' is reached.
Trying
f FC attributes are not configured
- Add a module parameter allowing to disable FC attributes even if
they are compiled in. Remember: this is a virtualized guest, and
people might want so save kernel memory wherever they can. So always
attaching to the fc transport template will make th
+ storvsc_on_receive(stor_device,
(struct vstor_packet *)packet,
request);
}
Hmm. I would've thought the compiler optimizes this away. Have you
checked whether it actually makes a diffe
ss_sub_channels)
handle_multichannel_storage(device, max_chns);
The same applies here; please make the FC support configurable both
during configuration and during runtime.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de
Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürn
not disable the attribute on error
- move size calculation into the pci_vpd_ops structure
Hannes Reinecke (2):
pci: Update VPD definitions
pci: Update VPD size with correct length
drivers/pci/access.c | 81
drivers/pci/pci.h| 1
-by: Hannes Reinecke
---
include/linux/pci.h | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index e828e7b..1e6856d 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1827,12 +1827,13 @@ bool
Helgaas
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 81
drivers/pci/pci.h| 1 +
2 files changed, 82 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..2e23fc7 100644
--- a/drivers/pci/access.c
gt;
Cc: Bjorn Helgaas <bhelg...@google.com>
Signed-off-by: Hannes Reinecke <h...@suse.com>
---
include/linux/pci.h | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index e828e7b..1e6856d 100644
-
not disable the attribute on error
- move size calculation into the pci_vpd_ops structure
Hannes Reinecke (2):
pci: Update VPD definitions
pci: Update VPD size with correct length
drivers/pci/access.c | 81
drivers/pci/pci.h| 1
}
Hmm. I would've thought the compiler optimizes this away. Have you
checked whether it actually makes a difference in the assembler output?
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
S
.du...@gmail.com>
Cc: Bjorn Helgaas <helg...@kernel.org>
Signed-off-by: Hannes Reinecke <h...@suse.de>
---
drivers/pci/access.c | 81
drivers/pci/pci.h| 1 +
2 files changed, 82 insertions(+)
diff --git a/drivers/pci/acce
_port_wwn[8];
u8 primary_node_wwn[8];
u8 secondary_port_wwn[8];
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUS
if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
- vstor_packet->status != 0)
- return -EINVAL;
-
if (process_sub_channels)
handle_multichannel_storage(device, max_chns);
The same applies here; please make the FC support configurable both
and
people might want so save kernel memory wherever they can. So always
attaching to the fc transport template will make them very unhappy.
Alternatively you could split out FC device handling into a separate
driver, but seeing the diff that's probably overkill.
Cheers,
Hannes
--
Dr. Hannes
On 12/18/2015 03:02 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke <h...@suse.de> wrote:
On 12/18/2015 02:49 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke <h...@suse.de> wrote:
PCI-2.2 VPD entries have a maximum
On 12/18/2015 02:49 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke <h...@suse.de> wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than that. To figure out the actual size one has to read
the VPD area until the 'end
On 12/17/2015 06:13 PM, Alexander Duyck wrote:
On Wed, Dec 16, 2015 at 11:59 PM, Hannes Reinecke wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than that. To figure out the actual size one has to read
the VPD area until the 'end marker' is reached.
Trying
actually triggered this patchset), or
hang your machine (if you're really unlucky).
So this patchset validates the VPD data, setting the VPD attribute to
the correct size or disabling VPD access altogether if no valid data
is found.
Hannes Reinecke (2):
pci: Update VPD definitions
pci: Update VPD
-by: Hannes Reinecke
---
include/linux/pci.h | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 6ae25aa..2fe2b5c 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1836,12 +1836,13 @@ bool
: Alexander Duyck
Cc: Bjorn Helgaas
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 57
1 file changed, 57 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..0a647b1 100644
--- a/drivers/pci/access.c
gt;
Cc: Bjorn Helgaas <bhelg...@google.com>
Signed-off-by: Hannes Reinecke <h...@suse.com>
---
include/linux/pci.h | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 6ae25aa..2fe2b5c 100644
-
: Alexander Duyck <alexander.du...@gmail.com>
Cc: Bjorn Helgaas <helg...@kernel.org>
Signed-off-by: Hannes Reinecke <h...@suse.de>
---
drivers/pci/access.c | 57
1 file changed, 57 insertions(+)
diff --git a/drivers/pci/access.c b/dr
actually triggered this patchset), or
hang your machine (if you're really unlucky).
So this patchset validates the VPD data, setting the VPD attribute to
the correct size or disabling VPD access altogether if no valid data
is found.
Hannes Reinecke (2):
pci: Update VPD definitions
pci: Update VPD
On 12/17/2015 06:13 PM, Alexander Duyck wrote:
On Wed, Dec 16, 2015 at 11:59 PM, Hannes Reinecke <h...@suse.de> wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than that. To figure out the actual size one has to read
the VPD area until the 'end
On Wednesday, December 16, 2015 09:13:35 AM Alexander Duyck wrote:
> On Wed, Dec 16, 2015 at 9:01 AM, Hannes Reinecke wrote:
> > On Wednesday, December 16, 2015 08:52:10 AM Alexander Duyck wrote:
> >> On Wed, Dec 16, 2015 at 2:49 AM, Hannes Reinecke wrote:
> >> >
On Wednesday, December 16, 2015 08:52:10 AM Alexander Duyck wrote:
> On Wed, Dec 16, 2015 at 2:49 AM, Hannes Reinecke wrote:
> > PCI-2.2 VPD entries have a maximum size of 32k, but might actually
> > be smaller than that. To figure out the actual size one has to read
> &g
: Alexander Duyck
Cc: Michal Kubecek
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..ab571a5 100644
--- a/drivers/pci/access.c
+++ b
: Alexander Duyck
Cc: Michal Kubecek
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..afa86d6 100644
--- a/drivers/pci/access.c
+++ b
On Wednesday, December 16, 2015 08:52:10 AM Alexander Duyck wrote:
> On Wed, Dec 16, 2015 at 2:49 AM, Hannes Reinecke <h...@suse.de> wrote:
> > PCI-2.2 VPD entries have a maximum size of 32k, but might actually
> > be smaller than that. To figure out the actual size one ha
On Wednesday, December 16, 2015 09:13:35 AM Alexander Duyck wrote:
> On Wed, Dec 16, 2015 at 9:01 AM, Hannes Reinecke <h...@suse.de> wrote:
> > On Wednesday, December 16, 2015 08:52:10 AM Alexander Duyck wrote:
> >> On Wed, Dec 16, 2015 at 2:49 AM, Hannes Reine
: Alexander Duyck <alexander.du...@gmail.com>
Cc: Michal Kubecek <mkube...@suse.com>
Signed-off-by: Hannes Reinecke <h...@suse.de>
---
drivers/pci/access.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/drivers/pci/access.c b/dr
: Alexander Duyck <alexander.h.du...@redhat.com>
Cc: Michal Kubecek <mkube...@suse.com>
Signed-off-by: Hannes Reinecke <h...@suse.de>
---
drivers/pci/access.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/drivers/pci/access.c b/dr
g with Ewan here.
Martin, I guess it's up to you to tell us whether you absolutely
need a module parameter ...
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5,
uld say no.
Agreeing with Ewan here.
Martin, I guess it's up to you to tell us whether you absolutely
need a module parameter ...
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX
On 12/11/2015 09:36 AM, Sudip Mukherjee wrote:
We were getting build warning about unused variables "vpd_pg83" and "d"
Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
Cc: Hannes Reinecke
Signed-off-by: Sudip Mukherjee
---
build warning with next-20151
On 12/11/2015 09:36 AM, Sudip Mukherjee wrote:
We were getting build warning about unused variables "vpd_pg83" and "d"
Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
Cc: Hannes Reinecke <h...@suse.de>
Signed-off-by: Sudip Mukherjee <s
make sure they are
always
loaded if they are enabled in the kernel config.
Signed-off-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by: Hannes Reinecke
Acked-by: Mike Snitzer
Signed-off-by: James Bottomley
This was an involved commit so I didn't try to revert. Any ideas here?
F
at bus scan time to make sure they are
always
loaded if they are enabled in the kernel config.
Signed-off-by: Christoph Hellwig <h...@lst.de>
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
Reviewed-by: Hannes Reinecke <h...@suse.de>
Acked-by: Mike Snitzer <sni
1001 - 1100 of 1903 matches
Mail list logo
