Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-12-01 Thread Hannes Reinecke
On 11/13/2015 09:57 PM, Jeff Moyer wrote: Hi Hannes, Hannes Reinecke writes: When running on files the physical blocksize is actually 4k, How did you come to that conclusion? Are you basing it on the file system block size? If so, that's configurable at mkfs time and can be anything from

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-12-01 Thread Hannes Reinecke
On 11/13/2015 09:57 PM, Jeff Moyer wrote: Hi Hannes, Hannes Reinecke <h...@suse.de> writes: When running on files the physical blocksize is actually 4k, How did you come to that conclusion? Are you basing it on the file system block size? If so, that's configurable at mkfs time a

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Hannes Reinecke
On 11/29/2015 06:05 PM, Markus Trippelsdorf wrote: > On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: >> On Sun, Nov 29 2015 at 11:15am -0500, >> Markus Trippelsdorf wrote: >> >>> On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: >>>> On 11/2

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Hannes Reinecke
On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote: >> On Thu, Nov 26 2015 at 2:46am -0500, >> Hannes Reinecke wrote: >> >>> When a cloned request is retried on other queues it always needs >>>

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Hannes Reinecke
On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote: >> On Thu, Nov 26 2015 at 2:46am -0500, >> Hannes Reinecke <h...@suse.de> wrote: >> >>> When a cloned request is retried on other queues it always needs

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Hannes Reinecke
On 11/29/2015 06:05 PM, Markus Trippelsdorf wrote: > On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: >> On Sun, Nov 29 2015 at 11:15am -0500, >> Markus Trippelsdorf <mar...@trippelsdorf.de> wrote: >> >>> On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote:

Re: QUEUE_FLAG_NO_SG_MERGE and non-block-mq

2015-11-27 Thread Hannes Reinecke
On 11/26/2015 10:21 AM, Ming Lei wrote: > On Thu, Nov 26, 2015 at 4:13 PM, Hannes Reinecke wrote: >> Hi all, >> >> while investigating the crash in scsi_lib.c I found a rather curious >> behaviour for QUEUE_FLAG_NO_SG_MERGE. >> >> While the flag

Re: QUEUE_FLAG_NO_SG_MERGE and non-block-mq

2015-11-27 Thread Hannes Reinecke
On 11/26/2015 10:21 AM, Ming Lei wrote: > On Thu, Nov 26, 2015 at 4:13 PM, Hannes Reinecke <h...@suse.de> wrote: >> Hi all, >> >> while investigating the crash in scsi_lib.c I found a rather curious >> behaviour for QUEUE_FLAG_NO_SG_MERGE.

QUEUE_FLAG_NO_SG_MERGE and non-block-mq

2015-11-26 Thread Hannes Reinecke
as advertised? Or, to be precise, which only works for blk-mq? Should we make it work for non-block-mq, too? Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 9

QUEUE_FLAG_NO_SG_MERGE and non-block-mq

2015-11-26 Thread Hannes Reinecke
as advertised? Or, to be precise, which only works for blk-mq? Should we make it work for non-block-mq, too? Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 9

[PATCH] block: Always check queue limits for cloned requests

2015-11-25 Thread Hannes Reinecke
() to blk_cloned_rq_check_limits() and removes the symbol export, as the new function should only be used for cloned requests and never exported. Cc: Mike Snitzer Cc: Ewan Milne Cc: Jeff Moyer Signed-off-by: Hannes Reinecke --- block/blk-core.c | 21 +++-- include/linux/blkdev.h | 1 - 2

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 06:56 PM, Jens Axboe wrote: On 11/25/2015 02:04 AM, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 07:01 PM, Mike Snitzer wrote: On Wed, Nov 25 2015 at 4:04am -0500, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug

Re: [PATCH v3 5/5] arcmsr: changes driver version number

2015-11-25 Thread Hannes Reinecke
> 512 > #define ARCMSR_MAX_XFER_SECTORS_B > 4096 > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: [PATCH v3 4/5] arcmsr: adds code for support areca new adapter ARC1203

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 12:49 PM, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Signed-of-by: Ching Huang > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSerie

Re: [PATCH v3 3/5] arcmsr: modifies codes for more readable

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 12:45 PM, Ching Huang wrote: > From: Ching Huang > > Modifies codes for more readable > > Signed-of-by: Ching Huang > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSerie

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-25 Thread Hannes Reinecke
coherent(>pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; > } > > static bool arcmsr_hbaC_get_config(struct AdapterControlBlock *pACB) > > Reviewed-by: Hannes Reinecke Cheers, Han

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 12:36 PM, Ching Huang wrote: > From: Ching Huang > > Fixed getting wrong configuration data of adapter type B and type D. > > Signed-of-by: Ching Huang > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/20/2015 04:28 PM, Ewan Milne wrote: > On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: >> Can't we have a joint effort here? >> I've been spending a _LOT_ of time trying to debug things here, but >> none of the ideas I've come up with have been able to fix any

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 06:56 PM, Jens Axboe wrote: On 11/25/2015 02:04 AM, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 07:01 PM, Mike Snitzer wrote: On Wed, Nov 25 2015 at 4:04am -0500, Hannes Reinecke <h...@suse.de> wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ o

[PATCH] block: Always check queue limits for cloned requests

2015-11-25 Thread Hannes Reinecke
() to blk_cloned_rq_check_limits() and removes the symbol export, as the new function should only be used for cloned requests and never exported. Cc: Mike Snitzer <snit...@redhat.com> Cc: Ewan Milne <emi...@redhat.com> Cc: Jeff Moyer <jmo...@redhat.com> Signed-off-by: Hannes Reinecke <h...@su

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/20/2015 04:28 PM, Ewan Milne wrote: > On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: >> Can't we have a joint effort here? >> I've been spending a _LOT_ of time trying to debug things here, but >> none of the ideas I've come up with have been able to fix any

Re: [PATCH v3 5/5] arcmsr: changes driver version number

2015-11-25 Thread Hannes Reinecke
CMSR_MAX_XFER_SECTORS > 512 > #define ARCMSR_MAX_XFER_SECTORS_B > 4096 > > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v3 4/5] arcmsr: adds code for support areca new adapter ARC1203

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 12:49 PM, Ching Huang wrote: > From: Ching Huang <ching2...@areca.com.tw> > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Signed-of-by: Ching Huang <ching2...@areca.com.tw> > > --- > Reviewed-by: Hannes Reinecke <h...@suse.com>

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-25 Thread Hannes Reinecke
return true; > +err_free_dma: > + dma_free_coherent(>pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; > } > > static bool arcmsr_hbaC_get_config(struct AdapterControlBlock *p

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 12:36 PM, Ching Huang wrote: > From: Ching Huang <ching2...@areca.com.tw> > > Fixed getting wrong configuration data of adapter type B and type D. > > Signed-of-by: Ching Huang <ching2...@areca.com.tw> > > --- > Reviewed-by: Hannes Reinecke <

Re: [PATCH v3 3/5] arcmsr: modifies codes for more readable

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 12:45 PM, Ching Huang wrote: > From: Ching Huang <ching2...@areca.com.tw> > > Modifies codes for more readable > > Signed-of-by: Ching Huang <ching2...@areca.com.tw> > > --- > Reviewed-by: Hannes Reinecke <h...@suse.com>

Re: [PATCH v2 3/3] arcmsr: changes driver version number

2015-11-24 Thread Hannes Reinecke
> 512 > #define ARCMSR_MAX_XFER_SECTORS_B > 4096 > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

2015-11-24 Thread Hannes Reinecke
s,4,16-19*/ > return true; > +err_free_dma: > + dma_free_coherent(>pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; > } > And this is actually a bugfix, but hey. > stati

Re: [PATCH v2 1/3] arcmsr: fixed getting wrong configuration data

2015-11-24 Thread Hannes Reinecke
On 11/25/2015 04:21 AM, Ching Huang wrote: > From: Ching Huang > > Fixed getting wrong configuration data of adapter type B and type D. > > Signed-of-by: Ching Huang > > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v2 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

2015-11-24 Thread Hannes Reinecke
CONFIG_SCSI_CONSTANTS=y impact by 8k > > drivers/scsi/constants.c | 859 > ++--- > drivers/scsi/sense_codes.h | 826 +++ > 2 files changed, 847 insertions(+), 838 deletions(-) > create mode 100644 drivers/scsi

Re: [PATCH 0/2] arcmsr: support areca new adapter ARC1203

2015-11-24 Thread Hannes Reinecke
series. Otherwise it'll be hard to keep track of which patch belongs to which version. Thanks. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH] scsi: use sector_div instead of do_div

2015-11-24 Thread Hannes Reinecke
-2780,7 +2780,7 @@ static unsigned long lba_to_map_index(sector_t lba) > lba += scsi_debug_unmap_granularity - > scsi_debug_unmap_alignment; > } > - do_div(lba, scsi_debug_unmap_granularity); > + sector_div(lba, scsi_debug_unmap_granularity

Re: [PATCH v2 1/3] arcmsr: fixed getting wrong configuration data

2015-11-24 Thread Hannes Reinecke
On 11/25/2015 04:21 AM, Ching Huang wrote: > From: Ching Huang <ching2...@areca.com.tw> > > Fixed getting wrong configuration data of adapter type B and type D. > > Signed-of-by: Ching Huang <ching2...@areca.com.tw> > > --- Reviewed-by: Hannes Reinecke <h.

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

2015-11-24 Thread Hannes Reinecke
r[25]); > /*firm_cfg_version,25,100-103*/ > /*firm_ide_channels,4,16-19*/ > return true; > +err_free_dma: > + dma_free_coherent(>pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; >

Re: [PATCH v2 3/3] arcmsr: changes driver version number

2015-11-24 Thread Hannes Reinecke
CMSR_MAX_XFER_SECTORS > 512 > #define ARCMSR_MAX_XFER_SECTORS_B > 4096 > > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH] scsi: use sector_div instead of do_div

2015-11-24 Thread Hannes Reinecke
t; @@ -2780,7 +2780,7 @@ static unsigned long lba_to_map_index(sector_t lba) > lba += scsi_debug_unmap_granularity - > scsi_debug_unmap_alignment; > } > - do_div(lba, scsi_debug_unmap_granularity); > + sector_div(lba, scsi_debug_un

Re: [PATCH 0/2] arcmsr: support areca new adapter ARC1203

2015-11-24 Thread Hannes Reinecke
add it as the last patch in the series. Otherwise it'll be hard to keep track of which patch belongs to which version. Thanks. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxf

Re: [PATCH v2 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

2015-11-24 Thread Hannes Reinecke
CONFIG_SCSI_CONSTANTS=y impact by 8k > > drivers/scsi/constants.c | 859 > ++--- > drivers/scsi/sense_codes.h | 826 +++ > 2 files changed, 847 insertions(+), 838 deletions(-) > create mode 100644 drivers/scs

Re: MPT2SAS boot fail... due to silently loosing the driver

2015-11-23 Thread Hannes Reinecke
al options map onto that. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton

Re: MPT2SAS boot fail... due to silently loosing the driver

2015-11-23 Thread Hannes Reinecke
al options map onto that. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-22 Thread Hannes Reinecke
On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here, but none of the ideas I've come up with have been able to fix anything. Yes. I'm not the one

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-22 Thread Hannes Reinecke
On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here, but none of the ideas I've come up with have been able to fix anything. Yes. I'm not the one

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-20 Thread Hannes Reinecke
On 11/20/2015 03:38 PM, Ewan Milne wrote: > On Thu, 2015-11-19 at 16:35 +0100, Hannes Reinecke wrote: >> On 11/19/2015 09:23 AM, Christoph Hellwig wrote: >>> It's pretty much guaranteed a block layer bug, most likely in the >>> merge bios to request infrastucture wher

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-20 Thread Hannes Reinecke
On 11/20/2015 03:38 PM, Ewan Milne wrote: > On Thu, 2015-11-19 at 16:35 +0100, Hannes Reinecke wrote: >> On 11/19/2015 09:23 AM, Christoph Hellwig wrote: >>> It's pretty much guaranteed a block layer bug, most likely in the >>> merge bios to request infrastucture wher

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-19 Thread Hannes Reinecke
ric block-layer problem. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB

Re: [PATCH v3 RESEND_2] scsi: report 'INQUIRY result too short' once per host

2015-11-19 Thread Hannes Reinecke
lude/scsi/scsi_host.h > @@ -668,6 +668,9 @@ struct Scsi_Host { > unsigned use_blk_mq:1; > unsigned use_cmd_list:1; > > + /* Host responded with short (<36 bytes) INQUIRY result */ > + unsigned short_inquiry:1; > + > /* >* Optional work queue to be utilized by the tr

Re: [PATCH 16/71] ncr5380: Proceed with next command after NCR5380_select() calls scsi_done

2015-11-19 Thread Hannes Reinecke
and the main loop should proceed with > the next command in the issue queue. Clarify this logic. > > Signed-off-by: Finn Thain > > --- > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: [PATCH 15/71] ncr5380: Always escalate bad target time-out in NCR5380_select()

2015-11-19 Thread Hannes Reinecke
> drivers/scsi/NCR5380.h |6 -- > drivers/scsi/atari_NCR5380.c | 13 - > 3 files changed, 32 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: [PATCH 14/71] ncr5380: Use return instead of goto in NCR5380_select()

2015-11-19 Thread Hannes Reinecke
Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 30 -- > drivers/scsi/atari_NCR5380.c |6 +++--- > 2 files changed, 11 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 13/71] ncr5380: Remove redundant register writes

2015-11-19 Thread Hannes Reinecke
On 11/18/2015 09:35 AM, Finn Thain wrote: > Remove the duplicate write to the Select Enable Register that appeared > in v1.1.38. > > Also remove the redundant write to Initiator Command Register prior to > calling do_abort(). > > Signed-off-by: Finn Thain > > --- R

Re: [PATCH 12/71] ncr5380: Remove unused hostdata->aborted flag

2015-11-19 Thread Hannes Reinecke
On 11/18/2015 09:35 AM, Finn Thain wrote: > The aborted flag was introduced in v1.1.38 but never used. Remove it. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Stor

Re: [PATCH 11/71] ncr5380: Simplify bus reset handlers

2015-11-19 Thread Hannes Reinecke
erious problems for > EH purposes. Those problems are addressed later in this series. > > --- > drivers/scsi/NCR5380.c | 20 +++- > drivers/scsi/atari_NCR5380.c | 30 -- > 2 files changed, 23 insertions(+), 27 deletions(-

Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT

2015-11-19 Thread Hannes Reinecke
c| 60 +-- > drivers/scsi/mac_scsi.c | 65 > ++- > drivers/scsi/sun3_scsi.c | 47 --- > 7 files changed, 51 insertions(+), 178 deletions(-) > Reviewed-by: Hannes Rei

Re: [PATCH 09/71] atari_NCR5380: Reset bus on driver initialization if required

2015-11-19 Thread Hannes Reinecke
+++ > 2 files changed, 134 insertions(+), 12 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH,

Re: [PATCH 08/71] ncr5380: Move NCR53C400-specific code

2015-11-19 Thread Hannes Reinecke
+ > 3 files changed, 20 insertions(+), 27 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürn

Re: [PATCH 07/71] ncr5380: Split NCR5380_init() into two functions

2015-11-19 Thread Hannes Reinecke
ation and bus reset. Again, > the solution is to move the bus reset code into NCR5380_maybe_reset_bus(). > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-19 Thread Hannes Reinecke
ric block-layer problem. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB

Re: [PATCH 09/71] atari_NCR5380: Reset bus on driver initialization if required

2015-11-19 Thread Hannes Reinecke
--- > drivers/scsi/atari_NCR5380.c | 113 > +++ > 2 files changed, 134 insertions(+), 12 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT

2015-11-19 Thread Hannes Reinecke
s/scsi/atari_scsi.c| 60 +-- > drivers/scsi/mac_scsi.c | 65 > ++- > drivers/scsi/sun3_scsi.c | 47 --- > 7 files changed, 51 insertions(+

Re: [PATCH 11/71] ncr5380: Simplify bus reset handlers

2015-11-19 Thread Hannes Reinecke
d, 23 insertions(+), 27 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F.

Re: [PATCH 07/71] ncr5380: Split NCR5380_init() into two functions

2015-11-19 Thread Hannes Reinecke
ation and bus reset. Again, > the solution is to move the bus reset code into NCR5380_maybe_reset_bus(). > > Signed-off-by: Finn Thain <fth...@telegraphics.com.au> > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezS

Re: [PATCH 08/71] ncr5380: Move NCR53C400-specific code

2015-11-19 Thread Hannes Reinecke
drivers/scsi/g_NCR5380.h |6 ++ > 3 files changed, 20 insertions(+), 27 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 7

Re: [PATCH 12/71] ncr5380: Remove unused hostdata->aborted flag

2015-11-19 Thread Hannes Reinecke
On 11/18/2015 09:35 AM, Finn Thain wrote: > The aborted flag was introduced in v1.1.38 but never used. Remove it. > > Signed-off-by: Finn Thain <fth...@telegraphics.com.au> > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 13/71] ncr5380: Remove redundant register writes

2015-11-19 Thread Hannes Reinecke
h...@telegraphics.com.au> > > --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendö

Re: [PATCH 14/71] ncr5380: Use return instead of goto in NCR5380_select()

2015-11-19 Thread Hannes Reinecke
d-off-by: Finn Thain <fth...@telegraphics.com.au> > > --- > drivers/scsi/NCR5380.c | 30 -- > drivers/scsi/atari_NCR5380.c |6 +++--- > 2 files changed, 11 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke <h..

Re: [PATCH 15/71] ncr5380: Always escalate bad target time-out in NCR5380_select()

2015-11-19 Thread Hannes Reinecke
5380.c | 13 - > drivers/scsi/NCR5380.h |6 -- > drivers/scsi/atari_NCR5380.c | 13 ----- > 3 files changed, 32 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes

Re: [PATCH 16/71] ncr5380: Proceed with next command after NCR5380_select() calls scsi_done

2015-11-19 Thread Hannes Reinecke
and the main loop should proceed with > the next command in the issue queue. Clarify this logic. > > Signed-off-by: Finn Thain <fth...@telegraphics.com.au> > > --- > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v3 RESEND_2] scsi: report 'INQUIRY result too short' once per host

2015-11-19 Thread Hannes Reinecke
b/include/scsi/scsi_host.h > @@ -668,6 +668,9 @@ struct Scsi_Host { > unsigned use_blk_mq:1; > unsigned use_cmd_list:1; > > + /* Host responded with short (<36 bytes) INQUIRY result */ > + unsigned short_inquiry:1; > + > /* >* Optional work queu

Re: [PATCH 06/71] ncr5380: Remove NCR5380_instance_name macro

2015-11-18 Thread Hannes Reinecke
(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284

Re: [PATCH 05/71] ncr5380: Remove NCR5380_local_declare and NCR5380_setup macros

2015-11-18 Thread Hannes Reinecke
tions". Signed-off-by: Finn Thain --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smit

Re: [PATCH 03/71] ncr5380: Eliminate PDEBUG*, TDEBUG* and DTCDEBUG* macros

2015-11-18 Thread Hannes Reinecke
--- drivers/scsi/pas16.c | 21 +++-- drivers/scsi/pas16.h | 16 drivers/scsi/t128.c | 18 ++ drivers/scsi/t128.h | 16 6 files changed, 19 insertions(+), 97 deletions(-) Reviewed-by: Hannes Reinecke

Re: [PATCH 04/71] ncr5380: Remove more pointless macros

2015-11-18 Thread Hannes Reinecke
-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284

Re: [PATCH 02/71] ncr5380: Remove redundant static variable initializers

2015-11-18 Thread Hannes Reinecke
.c |4 ++-- 6 files changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 9

Re: [PATCH 01/71] atari_scsi: Fix SCSI host ID setting

2015-11-18 Thread Hannes Reinecke
. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. G

Re: [PATCH 02/71] ncr5380: Remove redundant static variable initializers

2015-11-18 Thread Hannes Reinecke
|8 drivers/scsi/t128.c |4 ++-- 6 files changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +

Re: [PATCH 01/71] atari_scsi: Fix SCSI host ID setting

2015-11-18 Thread Hannes Reinecke
. Signed-off-by: Finn Thain <fth...@telegraphics.com.au> Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5

Re: [PATCH 05/71] ncr5380: Remove NCR5380_local_declare and NCR5380_setup macros

2015-11-18 Thread Hannes Reinecke
tions". Signed-off-by: Finn Thain <fth...@telegraphics.com.au> --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Max

Re: [PATCH 03/71] ncr5380: Eliminate PDEBUG*, TDEBUG* and DTCDEBUG* macros

2015-11-18 Thread Hannes Reinecke
etions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Up

Re: [PATCH 04/71] ncr5380: Remove more pointless macros

2015-11-18 Thread Hannes Reinecke
+), 48 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Sm

Re: [PATCH 06/71] ncr5380: Remove NCR5380_instance_name macro

2015-11-18 Thread Hannes Reinecke
rtions(+), 6 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-16 Thread Hannes Reinecke
> scsi_cmnd *scp, > return ASC_BUSY; > } > scsiqp->sense_addr = cpu_to_le32(sense_addr); > - scsiqp->sense_len = cpu_to_le32(SCSI_SENSE_BUFFERSIZE); > + scsiqp->sense_len = SCSI_SENSE_BUFFERSIZE; > > /* Build AD

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-11-16 Thread Hannes Reinecke
modprobe parameters. We actually had customers running into a host_no overflow due to excessive host allocations and freeing done by iSCSI. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-11-16 Thread Hannes Reinecke
t. Then have it enabled via a modprobe parameters. We actually had customers running into a host_no overflow due to excessive host allocations and freeing done by iSCSI. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

2015-11-16 Thread Hannes Reinecke
d *boardp, struct > scsi_cmnd *scp, > return ASC_BUSY; > } > scsiqp->sense_addr = cpu_to_le32(sense_addr); > - scsiqp->sense_len = cpu_to_le32(SCSI_SENSE_BUFFERSIZE); > + scsiqp->sense_len = SCSI_SENSE_BUFFERSIZE; > > /* Build

Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

2015-11-12 Thread Hannes Reinecke
&& sas_is_tlr_enabled(scmd->device) && scmd->cmd_len != 32) > mpi_control |= MPI2_SCSIIO_CONTROL_TLR_ON; > > smid = mpt3sas_base_get_smid_scsiio(ioc, ioc->scsi_io_cb_idx, scmd); > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Ha

Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

2015-11-12 Thread Hannes Reinecke
mp; > - scmd->cmd_len != 32) > + && sas_is_tlr_enabled(scmd->device) && scmd->cmd_len != 32) > mpi_control |= MPI2_SCSIIO_CONTROL_TLR_ON; > > smid = mpt3sas_base_get_smid_scsiio(ioc, ioc->scsi_io_cb_idx, scmd); > Reviewed-by: Hannes Reinecke

Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

2015-11-11 Thread Hannes Reinecke
h > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_config.c > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_ctl.c > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_ctl.h > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_debug.h > delete mode 100644 drivers/scs

Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

2015-11-11 Thread Hannes Reinecke
> drivers/scsi/mpt3sas/mpt3sas_ctl.c| 18 +--- > drivers/scsi/mpt3sas/mpt3sas_module.c | 1 + > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 39 > ++- > 6 files changed, 62 insertions(+), 8 deletions(-) > I'd rather shorten that to 'hba_mpi_versio

Re: [PATCH RESEND 09/25] mpt3sas: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

2015-11-11 Thread Hannes Reinecke
t *)_data->ConfigElement[0]; > if (ioc->shost_recovery) { > - > +#ifndef SCSI_MPT2SAS > for (i = 0; i < event_data->NumElements; i++, element++) { > if (element->ReasonCode == MPI2_EVENT_IR_CHANGE_RC_HIDE) >

Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

2015-11-11 Thread Hannes Reinecke
h > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_config.c > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_ctl.c > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_ctl.h > delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_debug.h > delete mode 100644 drivers/scsi/mpt2sas/mpt2

Re: [PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

2015-11-11 Thread Hannes Reinecke
rtions(+), 8 deletions(-) > I'd rather shorten that to 'hba_mpi_version'. Other than that it's okay. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürn

Re: [PATCH RESEND 09/25] mpt3sas: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

2015-11-11 Thread Hannes Reinecke
> MPT3SAS_ADAPTER *ioc, > > element = (Mpi2EventIrConfigElement_t *)_data->ConfigElement[0]; > if (ioc->shost_recovery) { > - > +#ifndef SCSI_MPT2SAS > for (i = 0; i < event_data->NumElements; i++, element++) { > if (elemen

[PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set_capacity

2015-11-10 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/block/loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index e790487..7272055 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c

[PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field

2015-11-10 Thread Hannes Reinecke
The current LOOP_SET_STATUS64 ioctl has two unused fields 'init[2]', which can be used in conjunction with the LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 25 - 1 file changed, 20 insertions

[PATCH 1/4] loop: Enable correct physical blocksize

2015-11-10 Thread Hannes Reinecke
When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing loop_set_status ioctl. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 9 - 1 file changed, 8 insertions

[PATCH 3/4] loop: Add 'lo_logical_blocksize'

2015-11-10 Thread Hannes Reinecke
Add a new field 'lo_logical_blocksize' to hold the logical blocksize of the loop device. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 9 +++-- drivers/block/loop.h | 1 + include/uapi/linux/loop.h | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git

[PATCHv3 0/4] loop: enable different physical blocksizes

2015-11-10 Thread Hannes Reinecke
patches Changes to v2: - Drop lo_flags setting in loop_set_fd as suggested by Ming Lei Hannes Reinecke (4): loop: Enable correct physical blocksize loop: Remove unused 'bdev' argument from loop_set_capacity loop: Add 'lo_logical_blocksize' loop: Pass logical blocksize in 'lo_init[0]' ioctl field

[PATCHv3 0/4] loop: enable different physical blocksizes

2015-11-10 Thread Hannes Reinecke
patches Changes to v2: - Drop lo_flags setting in loop_set_fd as suggested by Ming Lei Hannes Reinecke (4): loop: Enable correct physical blocksize loop: Remove unused 'bdev' argument from loop_set_capacity loop: Add 'lo_logical_blocksize' loop: Pass logical blocksize in 'lo_init[0]' ioctl field

<    7   8   9   10   11   12   13   14   15   16   >