Re: remove the cmd_type field from struct request

2017-01-31 Thread Hannes Reinecke
. (And we have disabled the IDE drivers since SLES11, where we still support Itanium.) So they can be safely assumed defunct at this time. I'm all for removing them. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053

Re: remove the cmd_type field from struct request

2017-01-31 Thread Hannes Reinecke
. (And we have disabled the IDE drivers since SLES11, where we still support Itanium.) So they can be safely assumed defunct at this time. I'm all for removing them. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053

Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements

2017-01-31 Thread Hannes Reinecke
On 01/31/2017 01:31 AM, Bart Van Assche wrote: > On Wed, 2017-01-18 at 10:48 +0100, Hannes Reinecke wrote: >> @@ -1488,26 +1487,13 @@ static unsigned long disk_events_poll_jiffies(struct >> gendisk *disk) >> void disk_block_events(struct gendisk *disk) >> { >&g

Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements

2017-01-31 Thread Hannes Reinecke
On 01/31/2017 01:31 AM, Bart Van Assche wrote: > On Wed, 2017-01-18 at 10:48 +0100, Hannes Reinecke wrote: >> @@ -1488,26 +1487,13 @@ static unsigned long disk_events_poll_jiffies(struct >> gendisk *disk) >> void disk_block_events(struct gendisk *disk) >> { >&g

Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes

2017-01-29 Thread Hannes Reinecke
; include/linux/blkdev.h |1 + > include/linux/genhd.h | 17 + > 5 files changed, 59 insertions(+), 8 deletions(-) > Please check the patchset from Jan Kara (cf 'BDI lifetime fix' on linux-block), which attempts to solve the same problem. Cheers, Hannes -- Dr.

Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes

2017-01-29 Thread Hannes Reinecke
+++ > drivers/scsi/sd.c | 41 + > include/linux/blkdev.h |1 + > include/linux/genhd.h | 17 + > 5 files changed, 59 insertions(+), 8 deletions(-) > Please check the patchset from Jan Kara (cf 'BDI lifet

[PATCH] genhd: Do not hold event lock when scheduling workqueue elements

2017-01-18 Thread Hannes Reinecke
[ 989.716542] SyS_open+0x1e/0x20 [ 989.716546] entry_SYSCALL_64_fastpath+0x23/0xc6 Signed-off-by: Hannes Reinecke <h...@suse.com> diff --git a/block/genhd.c b/block/genhd.c index fcd6d4f..ae46caa 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1426,8 +1426,7 @@ struct disk_events {

[PATCH] genhd: Do not hold event lock when scheduling workqueue elements

2017-01-18 Thread Hannes Reinecke
[ 989.716542] SyS_open+0x1e/0x20 [ 989.716546] entry_SYSCALL_64_fastpath+0x23/0xc6 Signed-off-by: Hannes Reinecke diff --git a/block/genhd.c b/block/genhd.c index fcd6d4f..ae46caa 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1426,8 +1426,7 @@ struct disk_events { struct gendisk

Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature

2017-01-16 Thread Hannes Reinecke
nous LUN remapping? And we really should make sure to have a single FC host in the guest presenting all LUNs. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nü

Re: [PATCH 0/2] virtio-scsi: Implement FC_HOST feature

2017-01-16 Thread Hannes Reinecke
nous LUN remapping? And we really should make sure to have a single FC host in the guest presenting all LUNs. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nü

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-16 Thread Hannes Reinecke
On 01/13/2017 05:02 PM, Jens Axboe wrote: > On 01/13/2017 09:00 AM, Jens Axboe wrote: >> On 01/13/2017 08:59 AM, Hannes Reinecke wrote: >>> On 01/13/2017 04:34 PM, Jens Axboe wrote: >>>> On 01/13/2017 08:33 AM, Hannes Reinecke wrote: >>> [ .. ] >>>&g

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-16 Thread Hannes Reinecke
On 01/13/2017 05:02 PM, Jens Axboe wrote: > On 01/13/2017 09:00 AM, Jens Axboe wrote: >> On 01/13/2017 08:59 AM, Hannes Reinecke wrote: >>> On 01/13/2017 04:34 PM, Jens Axboe wrote: >>>> On 01/13/2017 08:33 AM, Hannes Reinecke wrote: >>> [ .. ] >>>&g

Re: [PATCH 08/10] blk-mq-sched: add framework for MQ capable IO schedulers

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 05:41 PM, Omar Sandoval wrote: > On Fri, Jan 13, 2017 at 12:15:17PM +0100, Hannes Reinecke wrote: >> On 01/11/2017 10:40 PM, Jens Axboe wrote: >>> This adds a set of hooks that intercepts the blk-mq path of >>> allocating/inserting/issuing/completin

Re: [PATCH 08/10] blk-mq-sched: add framework for MQ capable IO schedulers

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 05:41 PM, Omar Sandoval wrote: > On Fri, Jan 13, 2017 at 12:15:17PM +0100, Hannes Reinecke wrote: >> On 01/11/2017 10:40 PM, Jens Axboe wrote: >>> This adds a set of hooks that intercepts the blk-mq path of >>> allocating/inserting/issuing/completin

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 04:34 PM, Jens Axboe wrote: > On 01/13/2017 08:33 AM, Hannes Reinecke wrote: [ .. ] >> Ah, indeed. >> There is an ominous udev rule here, trying to switch to 'deadline'. >> >> # cat 60-ssd-scheduler.rules >> # do not edit this file, it will be overwri

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 04:34 PM, Jens Axboe wrote: > On 01/13/2017 08:33 AM, Hannes Reinecke wrote: [ .. ] >> Ah, indeed. >> There is an ominous udev rule here, trying to switch to 'deadline'. >> >> # cat 60-ssd-scheduler.rules >> # do not edit this file, it will be overwri

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 04:23 PM, Jens Axboe wrote: > On 01/13/2017 04:04 AM, Hannes Reinecke wrote: >> On 01/13/2017 09:15 AM, Hannes Reinecke wrote: >>> On 01/11/2017 10:39 PM, Jens Axboe wrote: >>>> Another year, another posting of this patchset. The previous posting

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 04:23 PM, Jens Axboe wrote: > On 01/13/2017 04:04 AM, Hannes Reinecke wrote: >> On 01/13/2017 09:15 AM, Hannes Reinecke wrote: >>> On 01/11/2017 10:39 PM, Jens Axboe wrote: >>>> Another year, another posting of this patchset. The previous posting

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 12:04 PM, Hannes Reinecke wrote: > On 01/13/2017 09:15 AM, Hannes Reinecke wrote: >> On 01/11/2017 10:39 PM, Jens Axboe wrote: >>> Another year, another posting of this patchset. The previous posting >>> was here: >>> >>> https:/

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 12:04 PM, Hannes Reinecke wrote: > On 01/13/2017 09:15 AM, Hannes Reinecke wrote: >> On 01/11/2017 10:39 PM, Jens Axboe wrote: >>> Another year, another posting of this patchset. The previous posting >>> was here: >>> >>> https:/

Re: [PATCH 08/10] blk-mq-sched: add framework for MQ capable IO schedulers

2017-01-13 Thread Hannes Reinecke
Surely there is one already, right? Things like '->init_request' assume a fully populated array, so moving one entry to another location is ... interesting. I would have thought we need to do a request cloning here, otherwise this would introduce a memory leak, right? (Not to m

Re: [PATCH 08/10] blk-mq-sched: add framework for MQ capable IO schedulers

2017-01-13 Thread Hannes Reinecke
ready, right? Things like '->init_request' assume a fully populated array, so moving one entry to another location is ... interesting. I would have thought we need to do a request cloning here, otherwise this would introduce a memory leak, right? (Not to mention

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 09:15 AM, Hannes Reinecke wrote: > On 01/11/2017 10:39 PM, Jens Axboe wrote: >> Another year, another posting of this patchset. The previous posting >> was here: >> >> https://www.spinics.net/lists/kernel/msg2406106.html >> >> (yes, I'v

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
On 01/13/2017 09:15 AM, Hannes Reinecke wrote: > On 01/11/2017 10:39 PM, Jens Axboe wrote: >> Another year, another posting of this patchset. The previous posting >> was here: >> >> https://www.spinics.net/lists/kernel/msg2406106.html >> >> (yes, I'v

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
8.987716] async_port_probe+0x43/0x60 [libata] [ 28.987718] async_run_entry_fn+0x37/0x150 [ 28.987722] process_one_work+0x1d0/0x660 Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH,

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
8.987716] async_port_probe+0x43/0x60 [libata] [ 28.987718] async_run_entry_fn+0x37/0x150 [ 28.987722] process_one_work+0x1d0/0x660 Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH,

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
port_opcode+0xab/0x100 checking ... Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-13 Thread Hannes Reinecke
port_opcode+0xab/0x100 checking ... Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-24 Thread Hannes Reinecke
want to head to; I might be able to work on this start of January. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer,

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-24 Thread Hannes Reinecke
want to head to; I might be able to work on this start of January. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer,

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-21 Thread Hannes Reinecke
_might_ end up with a residual smaller than the physical sector size. But that should be handled by firmware; after all, that's what the 'e' implies, right? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-21 Thread Hannes Reinecke
_might_ end up with a residual smaller than the physical sector size. But that should be handled by firmware; after all, that's what the 'e' implies, right? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911

Re: [PATCH 4/7] blk-flush: run the queue when inserting blk-mq flush

2016-12-08 Thread Hannes Reinecke
l(>queuelist, >queue_head); return; Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH 4/7] blk-flush: run the queue when inserting blk-mq flush

2016-12-08 Thread Hannes Reinecke
queuelist, >queue_head); return; Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smit

Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper

2016-12-08 Thread Hannes Reinecke
files changed, 48 insertions(+), 38 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 9040

Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper

2016-12-08 Thread Hannes Reinecke
insertions(+), 38 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. G

Re: [PATCH 3/7] elevator: make the rqhash helpers exported

2016-12-08 Thread Hannes Reinecke
On 12/08/2016 09:13 PM, Jens Axboe wrote: Signed-off-by: Jens Axboe <ax...@fb.com> --- block/elevator.c | 8 include/linux/elevator.h | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -

Re: [PATCH 3/7] elevator: make the rqhash helpers exported

2016-12-08 Thread Hannes Reinecke
On 12/08/2016 09:13 PM, Jens Axboe wrote: Signed-off-by: Jens Axboe --- block/elevator.c | 8 include/linux/elevator.h | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead

Re: Regarding "scsi_lib: Decode T10 vendor IDs" d230823a1c4c3e97afd4c934b86b3975d5e20249

2016-11-25 Thread Hannes Reinecke
was not to prefer a longer T10 to a NAA identifier. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.com +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)

Re: Regarding "scsi_lib: Decode T10 vendor IDs" d230823a1c4c3e97afd4c934b86b3975d5e20249

2016-11-25 Thread Hannes Reinecke
was not to prefer a longer T10 to a NAA identifier. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.com +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)

Re: [PATCH] scsi: hpsa: fix uninitialized variable access

2016-11-22 Thread Hannes Reinecke
vers/scsi/hpsa.c @@ -2031,7 +2031,7 @@ static struct hpsa_scsi_dev_t *lookup_hpsa_scsi_dev(struct ctlr_info *h, static int hpsa_slave_alloc(struct scsi_device *sdev) { - struct hpsa_scsi_dev_t *sd; + struct hpsa_scsi_dev_t *sd = NULL; unsigned long flags; struct ctlr_info *h;

Re: [PATCH] scsi: hpsa: fix uninitialized variable access

2016-11-22 Thread Hannes Reinecke
1,7 +2031,7 @@ static struct hpsa_scsi_dev_t *lookup_hpsa_scsi_dev(struct ctlr_info *h, static int hpsa_slave_alloc(struct scsi_device *sdev) { - struct hpsa_scsi_dev_t *sd; + struct hpsa_scsi_dev_t *sd = NULL; unsigned long flags; struct ctlr_info *h; Cheers, Hannes --

Re: [PATCH/RFC] add "failfast" support for raid1/raid10.

2016-11-17 Thread Hannes Reinecke
o while the FAILFAST flag is a mere convenience for SCSI, it's a positive must for S/390 if you want to have a functional RAID. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX Gm

Re: [PATCH/RFC] add "failfast" support for raid1/raid10.

2016-11-17 Thread Hannes Reinecke
o while the FAILFAST flag is a mere convenience for SCSI, it's a positive must for S/390 if you want to have a functional RAID. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX Gm

Re: [PATCH v4 07/15] scsi: fc: implement kref backed reference counting

2016-11-17 Thread Hannes Reinecke
'struct fc_bsg_job' and 'struct bsg_job'. > > Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> > --- > drivers/scsi/scsi_transport_fc.c | 40 > +++- > include/scsi/scsi_transport_fc.h | 4 +--- > 2 files changed, 12 insertions(+), 32

Re: [PATCH v4 07/15] scsi: fc: implement kref backed reference counting

2016-11-17 Thread Hannes Reinecke
'struct fc_bsg_job' and 'struct bsg_job'. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/scsi_transport_fc.c | 40 > +++- > include/scsi/scsi_transport_fc.h | 4 +--- > 2 files changed, 12 insertions(+), 32 deletions(-) > Revi

Re: "hpsa: Change SAS transport devices to bus 0." commit breaks hpacucli on old controller firmware

2016-11-17 Thread Hannes Reinecke
physicals + nlogicals; > > So the first logical volume gets BTL 0:0:0 and then we attempt to add in > the controller > using the same BTL values at the end of the list. Thus you get the > "device not added" messages. > > The change to bus 0 was because the SA

Re: "hpsa: Change SAS transport devices to bus 0." commit breaks hpacucli on old controller firmware

2016-11-17 Thread Hannes Reinecke
physicals + nlogicals; > > So the first logical volume gets BTL 0:0:0 and then we attempt to add in > the controller > using the same BTL values at the end of the list. Thus you get the > "device not added" messages. > > The change to bus 0 was because the SA

Re: [PATCH 3/7] genirq/affinity: Handle pre/post vectors in irq_create_affinity_masks()

2016-11-08 Thread Hannes Reinecke
changed, 31 insertions(+), 25 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH 3/7] genirq/affinity: Handle pre/post vectors in irq_create_affinity_masks()

2016-11-08 Thread Hannes Reinecke
(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 2

Re: [PATCH 2/7] genirq/affinity: Handle pre/post vectors in irq_calc_affinity_vectors()

2016-11-08 Thread Hannes Reinecke
it through struct irq_affinity. Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/pci/msi.c | 8 include/linux/interrupt.h | 4 ++-- kernel/irq/affinity.c | 24 ++-- 3 files changed, 16 insertions(+), 20 deletions(-) Reviewed-by: Hannes Reine

Re: [PATCH 2/7] genirq/affinity: Handle pre/post vectors in irq_calc_affinity_vectors()

2016-11-08 Thread Hannes Reinecke
it through struct irq_affinity. Signed-off-by: Christoph Hellwig --- drivers/pci/msi.c | 8 include/linux/interrupt.h | 4 ++-- kernel/irq/affinity.c | 24 ++-- 3 files changed, 16 insertions(+), 20 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes

Re: [RFC PATCH] pci: add pci_irq_get_affinity_vector()

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 04:11 PM, Christoph Hellwig wrote: On Tue, Nov 08, 2016 at 04:08:51PM +0100, Hannes Reinecke wrote: The use-case here is that one needs to feed the MSI-X index into the driver command structure. While we can extract that number trivially with scsi-mq, but for scsi-sq we don't have

Re: [RFC PATCH] pci: add pci_irq_get_affinity_vector()

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 04:11 PM, Christoph Hellwig wrote: On Tue, Nov 08, 2016 at 04:08:51PM +0100, Hannes Reinecke wrote: The use-case here is that one needs to feed the MSI-X index into the driver command structure. While we can extract that number trivially with scsi-mq, but for scsi-sq we don't have

Re: [RFC PATCH] pci: add pci_irq_get_affinity_vector()

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 03:56 PM, Christoph Hellwig wrote: On Tue, Nov 08, 2016 at 08:47:21AM +0100, Hannes Reinecke wrote: Add a reverse-mapping function to return the interrupt vector for any CPU if interrupt affinity is enabled. What's the use case of it? Also as-is this won't work due to the non

Re: [RFC PATCH] pci: add pci_irq_get_affinity_vector()

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 03:56 PM, Christoph Hellwig wrote: On Tue, Nov 08, 2016 at 08:47:21AM +0100, Hannes Reinecke wrote: Add a reverse-mapping function to return the interrupt vector for any CPU if interrupt affinity is enabled. What's the use case of it? Also as-is this won't work due to the non

Re: [PATCH 3/7] genirq/affinity: Handle pre/post vectors in irq_create_affinity_masks()

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 03:55 PM, Christoph Hellwig wrote: [please trim the f***king context in your replies, thanks..] On Tue, Nov 08, 2016 at 09:15:27AM +0100, Hannes Reinecke wrote: +irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd) { - int n, nodes, vecs_per_node

Re: [PATCH 3/7] genirq/affinity: Handle pre/post vectors in irq_create_affinity_masks()

2016-11-08 Thread Hannes Reinecke
On 11/08/2016 03:55 PM, Christoph Hellwig wrote: [please trim the f***king context in your replies, thanks..] On Tue, Nov 08, 2016 at 09:15:27AM +0100, Hannes Reinecke wrote: +irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd) { - int n, nodes, vecs_per_node

Re: [PATCH 6/7] pci: Remove the irq_affinity mask from struct pci_dev

2016-11-08 Thread Hannes Reinecke
source[DEVICE_COUNT_RESOURCE]; /* I/O and memory regions + expansion ROMs */ bool match_driver; /* Skip attaching driver */ Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Network

Re: [PATCH 6/7] pci: Remove the irq_affinity mask from struct pci_dev

2016-11-08 Thread Hannes Reinecke
[DEVICE_COUNT_RESOURCE]; /* I/O and memory regions + expansion ROMs */ bool match_driver; /* Skip attaching driver */ Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 7

Re: [PATCH 5/7] pci/msi: Provide pci_alloc_irq_vectors_affinity()

2016-11-08 Thread Hannes Reinecke
x/pci.h | 24 +++- 2 files changed, 32 insertions(+), 12 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH

Re: [PATCH 5/7] pci/msi: Provide pci_alloc_irq_vectors_affinity()

2016-11-08 Thread Hannes Reinecke
, 32 insertions(+), 12 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithar

Re: [PATCH 4/7] pci/msi: Propagate irq affinity description through the MSI code

2016-11-08 Thread Hannes Reinecke
i/msi.c | 62 +-- 1 file changed, 33 insertions(+), 29 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LIN

Re: [PATCH 4/7] pci/msi: Propagate irq affinity description through the MSI code

2016-11-08 Thread Hannes Reinecke
file changed, 33 insertions(+), 29 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffe

Re: [PATCH 3/7] genirq/affinity: Handle pre/post vectors in irq_create_affinity_masks()

2016-11-08 Thread Hannes Reinecke
nodemask_t nodemsk = NODE_MASK_NONE; struct cpumask *masks; cpumask_var_t nmsk; Check for NULL affd? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Max

Re: [PATCH 3/7] genirq/affinity: Handle pre/post vectors in irq_create_affinity_masks()

2016-11-08 Thread Hannes Reinecke
ASK_NONE; struct cpumask *masks; cpumask_var_t nmsk; Check for NULL affd? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. I

Re: [PATCH 2/7] genirq/affinity: Handle pre/post vectors in irq_calc_affinity_vectors()

2016-11-08 Thread Hannes Reinecke
onst struct irq_affinity *affd) { - int cpus, ret; + int resv = affd->pre_vectors + affd->post_vectors; + int vecs = maxvec - resv; + int cpus; Shouldn't you check for NULL affd here? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Sto

Re: [PATCH 2/7] genirq/affinity: Handle pre/post vectors in irq_calc_affinity_vectors()

2016-11-08 Thread Hannes Reinecke
- int cpus, ret; + int resv = affd->pre_vectors + affd->post_vectors; + int vecs = maxvec - resv; + int cpus; Shouldn't you check for NULL affd here? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 1/7] genirq/affinity: Introduce struct irq_affinity

2016-11-08 Thread Hannes Reinecke
post_vectors; +}; + #if defined(CONFIG_SMP) extern cpumask_var_t irq_default_affinity; Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LIN

Re: [PATCH 1/7] genirq/affinity: Introduce struct irq_affinity

2016-11-08 Thread Hannes Reinecke
) extern cpumask_var_t irq_default_affinity; Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffe

[RFC PATCH] pci: add pci_irq_get_affinity_vector()

2016-11-07 Thread Hannes Reinecke
Add a reverse-mapping function to return the interrupt vector for any CPU if interrupt affinity is enabled. Signed-off-by: Hannes Reinecke <h...@suse.com> --- drivers/pci/msi.c | 36 include/linux/pci.h | 1 + 2 files changed, 37 insertions(+) diff

[RFC PATCH] pci: add pci_irq_get_affinity_vector()

2016-11-07 Thread Hannes Reinecke
Add a reverse-mapping function to return the interrupt vector for any CPU if interrupt affinity is enabled. Signed-off-by: Hannes Reinecke --- drivers/pci/msi.c | 36 include/linux/pci.h | 1 + 2 files changed, 37 insertions(+) diff --git a/drivers/pci

Re: [PATCH 2/2] blk-mq: add a first_vec argument to blk_mq_pci_map_queues

2016-11-07 Thread Hannes Reinecke
vers/nvme/host/pci.c| 2 +- > include/linux/blk-mq-pci.h | 3 ++- > 3 files changed, 7 insertions(+), 4 deletions(-) > With this patch smartpqi doesn't compile anymore; it still uses the old interface. So to get this merged you probably should send a patch for that one, too. Che

Re: [PATCH 2/2] blk-mq: add a first_vec argument to blk_mq_pci_map_queues

2016-11-07 Thread Hannes Reinecke
> include/linux/blk-mq-pci.h | 3 ++- > 3 files changed, 7 insertions(+), 4 deletions(-) > With this patch smartpqi doesn't compile anymore; it still uses the old interface. So to get this merged you probably should send a patch for that one, too. Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 2/2] blk-mq: add a first_vec argument to blk_mq_pci_map_queues

2016-11-07 Thread Hannes Reinecke
vers/nvme/host/pci.c| 2 +- > include/linux/blk-mq-pci.h | 3 ++- > 3 files changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 2/2] blk-mq: add a first_vec argument to blk_mq_pci_map_queues

2016-11-07 Thread Hannes Reinecke
> include/linux/blk-mq-pci.h | 3 ++- > 3 files changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX G

Re: [PATCH 1/2] irq,pci: allow drivers to specify complex affinity requirement

2016-11-07 Thread Hannes Reinecke
| 65 > --- > 4 files changed, 98 insertions(+), 68 deletions(-) > Good idea. Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 1/2] irq,pci: allow drivers to specify complex affinity requirement

2016-11-07 Thread Hannes Reinecke
--- > 4 files changed, 98 insertions(+), 68 deletions(-) > Good idea. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SU

[PATCH 2/2] loop: support 4k physical blocksize

2016-11-03 Thread Hannes Reinecke
blocksize. Signed-off-by: Hannes Reinecke <h...@suse.com> --- drivers/block/loop.c | 36 +++- drivers/block/loop.h | 1 + include/uapi/linux/loop.h | 1 + 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/drivers/block/loop.c b/d

[PATCH 2/2] loop: support 4k physical blocksize

2016-11-03 Thread Hannes Reinecke
blocksize. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 36 +++- drivers/block/loop.h | 1 + include/uapi/linux/loop.h | 1 + 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index

[PATCHv4 0/2] loop: enable different logical blocksizes

2016-11-03 Thread Hannes Reinecke
. Changes to v1: - Move LO_FLAGS_BLOCKSIZE definition - Reshuffle patches Changes to v2: - Include reviews from Ming Lei Changes to v3: - Include reviews from Christoph - Merge patches Hannes Reinecke (2): loop: Remove unused 'bdev' argument from loop_set_capacity loop: support 4k physical blocksize

[PATCHv3 1/2] loop: Remove unused 'bdev' argument from loop_set_capacity

2016-11-03 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke <h...@suse.de> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Ming Lei <tom.leim...@gmail.com> --- drivers/block/loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/lo

[PATCHv4 0/2] loop: enable different logical blocksizes

2016-11-03 Thread Hannes Reinecke
. Changes to v1: - Move LO_FLAGS_BLOCKSIZE definition - Reshuffle patches Changes to v2: - Include reviews from Ming Lei Changes to v3: - Include reviews from Christoph - Merge patches Hannes Reinecke (2): loop: Remove unused 'bdev' argument from loop_set_capacity loop: support 4k physical blocksize

[PATCHv3 1/2] loop: Remove unused 'bdev' argument from loop_set_capacity

2016-11-03 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Reviewed-by: Ming Lei --- drivers/block/loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index fa1b7a9..3008dec 100644 --- a/drivers/block/loop.c +++ b

Re: [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field

2016-11-03 Thread Hannes Reinecke
On 11/01/2016 03:02 PM, Christoph Hellwig wrote: On Mon, Oct 31, 2016 at 08:37:19PM +0100, Hannes Reinecke wrote: The current LOOP_SET_STATUS64 ioctl has two unused fields 'init[2]', which can be used in conjunction with the LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize. Can we

Re: [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field

2016-11-03 Thread Hannes Reinecke
On 11/01/2016 03:02 PM, Christoph Hellwig wrote: On Mon, Oct 31, 2016 at 08:37:19PM +0100, Hannes Reinecke wrote: The current LOOP_SET_STATUS64 ioctl has two unused fields 'init[2]', which can be used in conjunction with the LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize. Can we

Re: [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field

2016-11-01 Thread Hannes Reinecke
On 11/01/2016 03:02 PM, Christoph Hellwig wrote: On Mon, Oct 31, 2016 at 08:37:19PM +0100, Hannes Reinecke wrote: The current LOOP_SET_STATUS64 ioctl has two unused fields 'init[2]', which can be used in conjunction with the LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize. Can we

Re: [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field

2016-11-01 Thread Hannes Reinecke
On 11/01/2016 03:02 PM, Christoph Hellwig wrote: On Mon, Oct 31, 2016 at 08:37:19PM +0100, Hannes Reinecke wrote: The current LOOP_SET_STATUS64 ioctl has two unused fields 'init[2]', which can be used in conjunction with the LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize. Can we

Re: [PATCH 3/4] loop: Add 'lo_logical_blocksize'

2016-11-01 Thread Hannes Reinecke
On 11/01/2016 03:01 PM, Christoph Hellwig wrote: On Mon, Oct 31, 2016 at 08:37:18PM +0100, Hannes Reinecke wrote: Add a new field 'lo_logical_blocksize' to hold the logical blocksize of the loop device. Why do we use the same flag for both block sizes? If there is a good reason

Re: [PATCH 3/4] loop: Add 'lo_logical_blocksize'

2016-11-01 Thread Hannes Reinecke
On 11/01/2016 03:01 PM, Christoph Hellwig wrote: On Mon, Oct 31, 2016 at 08:37:18PM +0100, Hannes Reinecke wrote: Add a new field 'lo_logical_blocksize' to hold the logical blocksize of the loop device. Why do we use the same flag for both block sizes? If there is a good reason

[PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field

2016-10-31 Thread Hannes Reinecke
The current LOOP_SET_STATUS64 ioctl has two unused fields 'init[2]', which can be used in conjunction with the LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize. Signed-off-by: Hannes Reinecke <h...@suse.de> --- drivers/block/loop.c | 24 +++- 1 file chang

[PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field

2016-10-31 Thread Hannes Reinecke
The current LOOP_SET_STATUS64 ioctl has two unused fields 'init[2]', which can be used in conjunction with the LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 24 +++- 1 file changed, 19 insertions(+), 5

[PATCHv3 0/4] loop: enable different physical blocksizes

2016-10-31 Thread Hannes Reinecke
patches Changes to v2: - Include reviews from Ming Lei Hannes Reinecke (4): loop: Remove unused 'bdev' argument from loop_set_capacity loop: Enable correct physical blocksize loop: Add 'lo_logical_blocksize' loop: Pass logical blocksize in 'lo_init[0]' ioctl field drivers/block/loop.c

[PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity

2016-10-31 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke <h...@suse.de> Reviewed-by: Christoph Hellwig <h...@lst.de> --- drivers/block/loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index fa1b7a9..3008dec 100644 --- a/drivers/block/

[PATCH 2/4] loop: Enable correct physical blocksize

2016-10-31 Thread Hannes Reinecke
When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing loop_set_status ioctl. Signed-off-by: Hannes Reinecke <h...@suse.de> --- drivers/block/loop.c | 9 - i

[PATCHv3 0/4] loop: enable different physical blocksizes

2016-10-31 Thread Hannes Reinecke
patches Changes to v2: - Include reviews from Ming Lei Hannes Reinecke (4): loop: Remove unused 'bdev' argument from loop_set_capacity loop: Enable correct physical blocksize loop: Add 'lo_logical_blocksize' loop: Pass logical blocksize in 'lo_init[0]' ioctl field drivers/block/loop.c

[PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity

2016-10-31 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/block/loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index fa1b7a9..3008dec 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c

[PATCH 2/4] loop: Enable correct physical blocksize

2016-10-31 Thread Hannes Reinecke
When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing loop_set_status ioctl. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 9 - include/uapi/linux

[PATCH 3/4] loop: Add 'lo_logical_blocksize'

2016-10-31 Thread Hannes Reinecke
Add a new field 'lo_logical_blocksize' to hold the logical blocksize of the loop device. Signed-off-by: Hannes Reinecke <h...@suse.de> --- drivers/block/loop.c | 9 +++-- drivers/block/loop.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/d

[PATCH 3/4] loop: Add 'lo_logical_blocksize'

2016-10-31 Thread Hannes Reinecke
Add a new field 'lo_logical_blocksize' to hold the logical blocksize of the loop device. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 9 +++-- drivers/block/loop.h | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c

<    1   2   3   4   5   6   7   8   9   10   >