f->thread)
goto free_conf;
- }
return conf;
free_conf:
Actually I prefer having error messages, especially if you have several
possible failures all leading to the same return value.
Without it debugging becomes really hard.
Cheers,
Hannes
--
D
eturn conf;
free_conf:
Actually I prefer having error messages, especially if you have several
possible failures all leading to the same return value.
Without it debugging becomes really hard.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
tipathing.
As it stands using dm-events from multipathing is a massive resource
drain (we have to allocate a waiting thread for each device), and we
more-or-less disregard that information anyway as it is an ex-post
notification made _after_ someone modified the table.
Given that in most case
tipathing.
As it stands using dm-events from multipathing is a massive resource
drain (we have to allocate a waiting thread for each device), and we
more-or-less disregard that information anyway as it is an ex-post
notification made _after_ someone modified the table.
Given that in most case
hanged, 495 insertions(+), 487 deletions(-)
> delete mode 100644 drivers/scsi/g_NCR5380_mmio.c
>
For this series:
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
hanged, 495 insertions(+), 487 deletions(-)
> delete mode 100644 drivers/scsi/g_NCR5380_mmio.c
>
For this series:
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
interrupt routine to do all sorts of things, and are
thereby well versed to keep interrupts disabled for an extented amount
of time.
However, we don't really have a good way of handling a request firmware
here; we probably would need to implement a workqueue to handle this
properly ...
Cheers,
Hannes
interrupt routine to do all sorts of things, and are
thereby well versed to keep interrupts disabled for an extented amount
of time.
However, we don't really have a good way of handling a request firmware
here; we probably would need to implement a workqueue to handle this
properly ...
Cheers,
Hannes
ng the most
prominent other one).
And while they might support ATA_12/ATA_16, there is no indication that
you can pass DSM TRIM that way.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH,
ng the most
prominent other one).
And while they might support ATA_12/ATA_16, there is no indication that
you can pass DSM TRIM that way.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH,
e->consumer) {
> - dev_printk(KERN_DEBUG, >dev, "Failed to allocate"
> + dev_printk(KERN_DEBUG, >dev, "Failed to allocate "
> "memory for producer, consumer\n");
>
_DEBUG, >dev, "Failed to allocate"
> + dev_printk(KERN_DEBUG, >dev, "Failed to allocate "
> "memory for producer, consumer\n");
> goto fail_alloc_dma_buf;
> }
>
---
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 20
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
; 1 file changed, 10 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
break;
> case SAS_SATA_DEV:
> + case SAS_SATA_PENDING:
> if (parent_dev && DEV_IS_EXPANDER(parent_dev->dev_type))
> qw0 = HISI_SAS_DEV_TYPE_STP << ITCT_HDR_DEV_TYPE_OFF;
> else
>
Reviewed-b
config_id_frame_v1_hw()
> in start_phy_v1_hw() since it will be used for
> PHY reset functions.
>
> Signed-off-by: John Garry
> Signed-off-by: Xiang Chen
> ---
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 10 --
> 1 file changed, 10 deletions(-)
>
Reviewed-by: Hannes Re
TA_DEV:
> + case SAS_SATA_PENDING:
> if (parent_dev && DEV_IS_EXPANDER(parent_dev->dev_type))
> qw0 = HISI_SAS_DEV_TYPE_STP << ITCT_HDR_DEV_TYPE_OFF;
> else
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
; 1 file changed, 10 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
config_id_frame_v2_hw()
> in start_phy_v2_hw() since it will be used for
> PHY reset functions.
>
> Signed-off-by: John Garry
> Signed-off-by: Xiang Chen
> ---
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 10 --
> 1 file changed, 10 deletions(-)
>
Reviewed-by: Hannes Re
tify_buffer[3]));
> hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD4,
> - identify_buffer[3]);
> + __swab32(identify_buffer[4]));
> hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD5,
> __swab32(identify_buffer[5]
, TX_ID_DWORD4,
> - identify_buffer[3]);
> + __swab32(identify_buffer[4]));
> hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD5,
> __swab32(identify_buffer[5]));
> }
>
Reviewed-by: Hannes Reinecke
Cheers,
Hann
a, phy_no, TX_ID_DWORD4,
> - identify_buffer[3]);
> + __swab32(identify_buffer[4]));
> hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD5,
> __swab32(identify_buffer[5]));
> }
>
Reviewed-by: Hannes Reinecke <h...@suse.c
; + __swab32(identify_buffer[4]));
> hisi_sas_phy_write32(hisi_hba, phy_no, TX_ID_DWORD5,
> __swab32(identify_buffer[5]));
> }
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stor
ed-off-by: Xiang Chen <chenxian...@hisilicon.com>
> Signed-off-by: John Garry <john.ga...@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...
isilicon.com>
> Signed-off-by: John Garry <john.ga...@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 26 ++
> 1 file changed, 6 insertions(+), 20 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. H
ed-off-by: Xiang Chen
> Signed-off-by: John Garry
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@
Xiang Chen
> Signed-off-by: John Garry
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 26 ++----
> 1 file changed, 6 insertions(+), 20 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
sas_write32(hisi_hba, DLVRY_QUEUE_ENABLE, 0);
>
> /* Disable all of the PHYs */
> for (i = 0; i < hisi_hba->n_phy; i++) {
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
- link_rate = hisi_sas_read32(hisi_hba, PHY_CONN_RATE);
> - link_rate = (link_rate >> (phy_no * 4)) & 0xf;
> sas_phy->linkrate = link_rate;
> hard_phy_linkrate = hisi_sas_phy_read32(hisi_hba, phy_no,
> HARD_
ABLE, 0);
>
> /* Disable all of the PHYs */
> for (i = 0; i < hisi_hba->n_phy; i++) {
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX
- link_rate = (link_rate >> (phy_no * 4)) & 0xf;
> sas_phy->linkrate = link_rate;
> hard_phy_linkrate = hisi_sas_phy_read32(hisi_hba, phy_no,
> HARD_PHY_LINKRATE);
>
Reviewed-by: Hannes Reine
f(unsigned long);
> + s = hisi_hba->slot_index_count / BITS_PER_BYTE;
> hisi_hba->slot_index_tags = devm_kzalloc(dev, s, GFP_KERNEL);
> if (!hisi_hba->slot_index_tags)
> goto err_out;
>
Reviewed-by: Hannes Reinecke <h...@
s = hisi_hba->slot_index_count / BITS_PER_BYTE;
> hisi_hba->slot_index_tags = devm_kzalloc(dev, s, GFP_KERNEL);
> if (!hisi_hba->slot_index_tags)
> goto err_out;
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSe
memset(slot, 0, sizeof(*slot));
> + /* slot memory is fully zeroed when it is reused */
> }
> EXPORT_SYMBOL_GPL(hisi_sas_slot_task_free);
>
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
sizeof(*slot));
> + /* slot memory is fully zeroed when it is reused */
> }
> EXPORT_SYMBOL_GPL(hisi_sas_slot_task_free);
>
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911
5 +--
> drivers/scsi/libsas/sas_internal.h |3 ++
> drivers/scsi/libsas/sas_phy.c | 50 -
> drivers/scsi/libsas/sas_port.c | 23 --
> include/scsi/libsas.h |8 -
> 6 files changed, 66 insertions(+), 84 deletions(
y.c | 50 -
> drivers/scsi/libsas/sas_port.c | 23 --
> include/scsi/libsas.h | 8 -
> 6 files changed, 66 insertions(+), 84 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
= 0; i < hisi_hba->n_phy; i++) {
> - hisi_sas_phy_write32(hisi_hba, i, CHL_INT2_MSK, 0x6a);
> - hisi_sas_phy_read32(hisi_hba, i, CHL_INT2_MSK);
> - }
> -
> setup_timer(timer, start_phys_v2_hw, (unsigned long)hisi_hba);
> mod_timer(timer, jif
_phy; i++) {
> - hisi_sas_phy_write32(hisi_hba, i, CHL_INT2_MSK, 0x6a);
> - hisi_sas_phy_read32(hisi_hba, i, CHL_INT2_MSK);
> - }
> -
> setup_timer(timer, start_phys_v2_hw, (unsigned long)hisi_hba);
> mod_timer(timer, jiffies + HZ);
> }
>
Rev
v2_hw.c | 9 ++---
> 4 files changed, 25 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Cheers
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products
> 4 files changed, 25 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Cheers
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
: John Garry <john.ga...@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas.h | 1 +
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 6 ++
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 5 ++---
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke &l
rry
> ---
> drivers/scsi/hisi_sas/hisi_sas.h | 1 +
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 6 ++
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 5 ++---
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reine
es to be had where this rewrite
could be looked at.
Which makes contributing _really_ hard and very frustrating; and I think
this indeed would be a suitable topic for KS.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911
es to be had where this rewrite
could be looked at.
Which makes contributing _really_ hard and very frustrating; and I think
this indeed would be a suitable topic for KS.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911
On 08/24/2016 04:07 PM, John Garry wrote:
> On 24/08/2016 13:59, Hannes Reinecke wrote:
>> On 08/24/2016 01:05 PM, John Garry wrote:
>>> Add code in slot_complete_v2_hw() to deal with the
>>> slots which have completed due to internal abort.
>>>
>>>
On 08/24/2016 04:07 PM, John Garry wrote:
> On 24/08/2016 13:59, Hannes Reinecke wrote:
>> On 08/24/2016 01:05 PM, John Garry wrote:
>>> Add code in slot_complete_v2_hw() to deal with the
>>> slots which have completed due to internal abort.
>>>
>>>
; #define HISI_SAS_MAX_PHYS9
> #define HISI_SAS_MAX_QUEUES 32
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfelds
8311360..ca55ec2 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas.h
> +++ b/drivers/scsi/hisi_sas/hisi_sas.h
> @@ -23,7 +23,7 @@
> #include
> #include
>
> -#define DRV_VERSION "v1.5"
> +#define DRV_VERSION "v1.6"
>
> #define HISI_SAS_MAX_PHYS9
&
break;
> + }
> +
> + if (task->task_status.resp == SAS_TASK_COMPLETE &&
> task->task_status.stat == SAS_DATA_UNDERRUN) {
> /* no error, but return the number of bytes of
>* underrun
&g
t_attached) {
> if (sas_protocol_ata(task->task_proto)) {
> struct task_status_struct *ts = >task_status;
>
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage &
> +
> + if (task->task_status.resp == SAS_TASK_COMPLETE &&
> task->task_status.stat == SAS_DATA_UNDERRUN) {
> /* no error, but return the number of bytes of
>* underrun
>
if (sas_protocol_ata(task->task_proto)) {
> struct task_status_struct *ts = >task_status;
>
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
has succeeded, it's just
that for some reason the associated command couldn't be found.
So couldn't this be due to a race condition, and the command has in fact
been aborted correctly (and the code is just too slow acknowledging it)?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
/* abort single io, controller don't find
> + * the io need to abort
> + */
> + ts->stat = TMF_RESP_FUNC_FAILED;
> + goto out;
Hmm. This will cause the SCSI EH to kick in.
And then, according to the description abort has succeeded, it's j
3 insertions(+)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smith
On 08/24/2016 01:05 PM, John Garry wrote:
> Add function to prepare the an internal abort
> for v2 hw.
>
> Signed-off-by: John Garry
> ---
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 33 +
> 1 file changed, 33 insertions(+)
>
Reviewed-by:
e.
>
> Signed-off-by: John Garry <john.ga...@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 16 ++--
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
e.
>
> Signed-off-by: John Garry
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 16 ++--
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.
HISI_SAS_INT_ABT_DEV, 0);
> +
> hisi_hba->hw->free_device(hisi_hba, sas_dev);
> device->lldd_dev = NULL;
> memset(sas_dev, 0, sizeof(*sas_dev));
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
0);
> +
> hisi_hba->hw->free_device(hisi_hba, sas_dev);
> device->lldd_dev = NULL;
> memset(sas_dev, 0, sizeof(*sas_dev));
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
Garry <john.ga...@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas.h | 8 ++
> drivers/scsi/hisi_sas/hisi_sas_main.c | 163
> ++
> 2 files changed, 171 insertions(+)
>
Reviewed-by: Hannes Reinecke <h...@suse.com&
arry
> ---
> drivers/scsi/hisi_sas/hisi_sas.h | 8 ++
> drivers/scsi/hisi_sas/hisi_sas_main.c | 163
> ++++++
> 2 files changed, 171 insertions(+)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead
ve you measure the performance impact here?
The main idea behind using an RB-tree is that each single element will
fit in the CPU cache; using an array will prevent that.
So we will increase the number of cache flushes, and most likely a
performance penalty, too.
Hence I'd rather like to see a performa
The main idea behind using an RB-tree is that each single element will
fit in the CPU cache; using an array will prevent that.
So we will increase the number of cache flushes, and most likely a
performance penalty, too.
Hence I'd rather like to see a performance measurement here before going
down
+-
> include/linux/ata.h | 69 +++-
> 2 files changed, 292 insertions(+), 57 deletions(-)
>
Thanks for doing this.
It has been on my To-Do list for a long time, and it's good to see the
UNMAP/TRIM SATL cleaned up finally.
Cheers,
Hannes
--
Dr. Hannes Rei
| 69 +++-
> 2 files changed, 292 insertions(+), 57 deletions(-)
>
Thanks for doing this.
It has been on my To-Do list for a long time, and it's good to see the
UNMAP/TRIM SATL cleaned up finally.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Netw
& ATA_DFLAG_PIO))
> + tf->command = ATA_CMD_WRITE_LOG_EXT;
> }
>
> tf->flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE | ATA_TFLAG_LBA48 |
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage
tf->command = ATA_CMD_WRITE_LOG_EXT;
> }
>
> tf->flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE | ATA_TFLAG_LBA48 |
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
A_PROT_NCQ;
> @@ -3441,7 +3468,9 @@ static unsigned int ata_scsi_write_same_xlat(struct
> ata_queued_cmd *qc)
> tf->command = ATA_CMD_DSM;
> }
> } else {
> - ata_format_sct_write_same(scmd, block, n_block);
> + size = ata_format_sct_write_same(scmd, block, n_block);
> + if (size != len)
> + goto invalid_param_len;
>
> tf->hob_feature = 0;
> tf->feature = 0;
>
Why is this not folded into the previous patches?
This mostly patches code which you've already modified and/or initiated,
right?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
68,9 @@ static unsigned int ata_scsi_write_same_xlat(struct
> ata_queued_cmd *qc)
> tf->command = ATA_CMD_DSM;
> }
> } else {
> - ata_format_sct_write_same(scmd, block, n_block);
> + size = ata_format_sct_write_same(scmd, block, n_block);
> + if (size != len)
> + goto invalid_param_len;
>
> tf->hob_feature = 0;
> tf->feature = 0;
>
Why is this not folded into the previous patches?
This mostly patches code which you've already modified and/or initiated,
right?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
-
> include/linux/ata.h | 26 --
> 2 files changed, 51 insertions(+), 31 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Network
--
> 2 files changed, 51 insertions(+), 31 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 9
++---
> include/linux/ata.h | 43 ++
> 2 files changed, 213 insertions(+), 29 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
anged to honor the UNMAP flag -> TRIM, no UNMAP -> SCT.
> v3:
> - Demux UNMAP/TRIM from WRITE SAME
> v2:
> - Remove fugly ata hacking from sd.c
>
> drivers/ata/libata-scsi.c | 199
> +++---
> include/linux/ata.h |
{ FC_PORTSPEED_10GBIT, SPEED_1 },
> + { FC_PORTSPEED_16GBIT, 16000 },
> + { FC_PORTSPEED_20GBIT, SPEED_2 },
> + { FC_PORTSPEED_25GBIT, SPEED_25000 },
> + { FC_PORTSPEED_32GBIT, 32000 },
> + { FC_PORTSPEED_40GBIT, SPEED_40000 },
> + { FC_PORTSPEED_50GBIT, SPEED
> + { FC_PORTSPEED_16GBIT, 16000 },
> + { FC_PORTSPEED_20GBIT, SPEED_2 },
> + { FC_PORTSPEED_25GBIT, SPEED_25000 },
> + { FC_PORTSPEED_32GBIT, 32000 },
> + { FC_PORTSPEED_40GBIT, SPEED_4 },
> + { FC_PORTSPEED_50GBIT, SPEED_5 },
> +
sa driver has some sdevs handled by the SAS transport class (for
the pass-through devices) and some sdevs (eg logical volumes) which are not.
As 'is_sas_attached' only checks if the _host_ has the SAS transport
class attached (which it will have), it will not work as expected for
devices
sa driver has some sdevs handled by the SAS transport class (for
the pass-through devices) and some sdevs (eg logical volumes) which are not.
As 'is_sas_attached' only checks if the _host_ has the SAS transport
class attached (which it will have), it will not work as expected for
devices
On 08/09/2016 08:12 PM, Alexander Duyck wrote:
> On Tue, Aug 9, 2016 at 5:54 AM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote:
>> On 10/02/16 08:04, Bjorn Helgaas wrote:
>>> On Wed, Jan 13, 2016 at 12:25:34PM +0100, Hannes Reinecke wrote:
>>>> PCI-2.2 VP
On 08/09/2016 08:12 PM, Alexander Duyck wrote:
> On Tue, Aug 9, 2016 at 5:54 AM, Alexey Kardashevskiy wrote:
>> On 10/02/16 08:04, Bjorn Helgaas wrote:
>>> On Wed, Jan 13, 2016 at 12:25:34PM +0100, Hannes Reinecke wrote:
>>>> PCI-2.2 VPD entries have a maximum s
On 08/05/2016 10:35 PM, Shaun Tancheff wrote:
> On Tue, Aug 2, 2016 at 8:29 PM, Damien Le Moal <damien.lem...@hgst.com> wrote:
>> Hannes, Shaun,
>>
>> Let me add some more comments.
>>
>>> On Aug 2, 2016, at 23:35, Hannes Reinecke <h...@suse.de&
On 08/05/2016 10:35 PM, Shaun Tancheff wrote:
> On Tue, Aug 2, 2016 at 8:29 PM, Damien Le Moal wrote:
>> Hannes, Shaun,
>>
>> Let me add some more comments.
>>
>>> On Aug 2, 2016, at 23:35, Hannes Reinecke wrote:
>>>
>>> On 08/01/2016 07:07 P
ourse we need to
re-read the zone information on failure (and I thought I did that?).
Plus the error information will be propagated via the usual mechanism,
so they need to take care of updating any information in ->private_data.
I'm perfectly fine with integrating your patches for the va
the zone information on failure (and I thought I did that?).
Plus the error information will be propagated via the usual mechanism,
so they need to take care of updating any information in ->private_data.
I'm perfectly fine with integrating your patches for the various
blkdev_XX callouts and a
t; the HBA.
>
> Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
t; the HBA.
>
> Signed-off-by: Johannes Thumshirn
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@
formant device,
resulting in lots of unhappy customers until we've got the whitelist
settled.
Having to discuss with customers why Linux doesn't follow the specs is
infinitely harder than discussing with customers whose _hardware_
doesn't follow the specs.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
y problem that turns up, I think we're done. If we
> get any more we can consider either blacklisting all CD type devices or
> raising the conformance bar to SPC-3.
>
I'm fully with James here.
The alternative would be to whitelist _every_ conformant device,
resulting in l
the case of non-full bvecs/pages
> block/blk-merge.c | 35 ---
> 1 file changed, 32 insertions(+), 3 deletions(-)
>
Hmm. So everybody is suffering because someone _might_ be using bio_clone?
Why can't we fixup bio_clone() (or the callers of which) to corr
;
Hmm. So everybody is suffering because someone _might_ be using bio_clone?
Why can't we fixup bio_clone() (or the callers of which) to correctly
set the queue limits?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
On 06/06/2016 05:40 PM, Mike Christie wrote:
On 06/06/2016 01:46 AM, Hannes Reinecke wrote:
On 06/05/2016 09:32 PM, mchri...@redhat.com wrote:
From: Mike Christie <mchri...@redhat.com>
Separate the op from the rq_flag_bits and have the target layer
set/get the bio using bio_set_op
On 06/06/2016 05:40 PM, Mike Christie wrote:
On 06/06/2016 01:46 AM, Hannes Reinecke wrote:
On 06/05/2016 09:32 PM, mchri...@redhat.com wrote:
From: Mike Christie
Separate the op from the rq_flag_bits and have the target layer
set/get the bio using bio_set_op_attrs/bio_op.
Signed-off
ore.c | 2 +-
> drivers/md/dm-flakey.c | 2 +-
> drivers/md/raid5.c | 6 +++---
> fs/btrfs/check-integrity.c | 4 ++--
> fs/btrfs/inode.c | 2 +-
> include/linux/blk_types.h | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
>
Reviewed-by
| 2 +-
> drivers/md/raid5.c | 6 +++---
> fs/btrfs/check-integrity.c | 4 ++--
> fs/btrfs/inode.c | 2 +-
> include/linux/blk_types.h | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Ha
e/trace/events/f2fs.h | 1 -
> 6 files changed, 46 insertions(+), 63 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUS
ux/bio.h | 3 ---
> include/linux/blk_types.h | 52
> +
> include/linux/blkdev.h | 14
> include/linux/fs.h | 37 +---
> include/trace/events/f2fs.h | 1 -
> 6 files changed, 46 in
bdev;
> unsigned intbi_flags; /* status, command, etc */
> int bi_error;
> - unsigned long bi_rw; /* bottom bits READ/WRITE,
> - * top bits priority
> - */
&
/
> int bi_error;
> - unsigned long bi_rw; /* bottom bits READ/WRITE,
> - * top bits priority
> - */
> + unsigned long bi_rw; /* R
601 - 700 of 1903 matches
Mail list logo
