eful until selection completes.
So just poll for BSY. We can sleep while polling now that we have a
suitable workqueue.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49
on in chip register
access times between different 5380 hardware implementations.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Prod
check it later maybe
*/
if (flags & FLAG_NCR53C400)
hostdata->flags = FLAG_HAS_LAST_BYTE_SENT | flags;
Wouldn't it be better to use a normal (ie bound) workqueue here?
SCSI-2 is pretty much single-threaded, so shifting things onto arbitrary
CP
/history.git added some pointless release_region() calls in dtc.c,
pas16.c and t128.c.
Fix these issues.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 6
USLEEP_POLL, USLEEP_SLEEP,
#endif
#ifdef AUTOPROBE_IRQ
"AUTOPROBE_IRQ "
Wouldn't it make more sense to remove the USLEEP_WAITLONG completely?
From what I can see it is meant to indicate that WAITLONG is enabled,
but we've just removed that func
On 12/22/2015 02:17 AM, Finn Thain wrote:
NCR5380.c is not compliant with the SCSI-2 standard (at least, not with
the draft revision 10L that I have to refer to). The selection algorithm
in atari_NCR5380.c is correct, so use that.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
, as it's not immediately clear from the
patch.
So:
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Ime
On 12/18/2015 03:02 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 5:57 AM, Hannes Reinecke wrote:
On 12/18/2015 02:49 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than
On 12/18/2015 02:49 PM, Alexander Duyck wrote:
On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than that. To figure out the actual size one has to read
the VPD area until the 'end marker' is reach
ght want so save kernel memory wherever they can. So always
attaching to the fc transport template will make them very unhappy.
Alternatively you could split out FC device handling into a separate
driver, but seeing the diff that's probably overkill.
Cheers,
Hannes
--
Dr. Hannes Reinecke
y. Have you
checked whether it actually makes a difference in the assembler output?
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer,
tion != VSTOR_OPERATION_COMPLETE_IO ||
- vstor_packet->status != 0)
- return -EINVAL;
-
if (process_sub_channels)
handle_multichannel_storage(device, max_chns);
The same applies here; please make the FC support configurable both
during configuration and during runtime.
annes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnbe
pci function devices
- Do not disable the attribute on error
- move size calculation into the pci_vpd_ops structure
Hannes Reinecke (2):
pci: Update VPD definitions
pci: Update VPD size with correct length
drivers/pci/access.c | 81
lgaas
Signed-off-by: Hannes Reinecke
---
include/linux/pci.h | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index e828e7b..1e6856d 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1827
be read.
Cc: Alexander Duyck
Cc: Bjorn Helgaas
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 81
drivers/pci/pci.h| 1 +
2 files changed, 82 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..2
On 12/17/2015 06:13 PM, Alexander Duyck wrote:
On Wed, Dec 16, 2015 at 11:59 PM, Hannes Reinecke wrote:
PCI-2.2 VPD entries have a maximum size of 32k, but might actually
be smaller than that. To figure out the actual size one has to read
the VPD area until the 'end marker' is reach
ernel warning (which actually triggered this patchset), or
hang your machine (if you're really unlucky).
So this patchset validates the VPD data, setting the VPD attribute to
the correct size or disabling VPD access altogether if no valid data
is found.
Hannes Reinecke (2):
pci: Update VPD defi
lgaas
Signed-off-by: Hannes Reinecke
---
include/linux/pci.h | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 6ae25aa..2fe2b5c 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1836
valid data
could be read.
Cc: Alexander Duyck
Cc: Bjorn Helgaas
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 57
1 file changed, 57 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..0a647b1 100
On Wednesday, December 16, 2015 09:13:35 AM Alexander Duyck wrote:
> On Wed, Dec 16, 2015 at 9:01 AM, Hannes Reinecke wrote:
> > On Wednesday, December 16, 2015 08:52:10 AM Alexander Duyck wrote:
> >> On Wed, Dec 16, 2015 at 2:49 AM, Hannes Reinecke wrote:
> >> >
On Wednesday, December 16, 2015 08:52:10 AM Alexander Duyck wrote:
> On Wed, Dec 16, 2015 at 2:49 AM, Hannes Reinecke wrote:
> > PCI-2.2 VPD entries have a maximum size of 32k, but might actually
> > be smaller than that. To figure out the actual size one has to read
> > t
valid data
could be read.
Cc: Alexander Duyck
Cc: Michal Kubecek
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..ab571a5 100644
--
valid data
could be read.
Cc: Alexander Duyck
Cc: Michal Kubecek
Signed-off-by: Hannes Reinecke
---
drivers/pci/access.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 59ac36f..afa86d6 100644
--
I would say no.
Agreeing with Ewan here.
Martin, I guess it's up to you to tell us whether you absolutely
need a module parameter ...
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SU
On 12/11/2015 09:36 AM, Sudip Mukherjee wrote:
We were getting build warning about unused variables "vpd_pg83" and "d"
Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
Cc: Hannes Reinecke
Signed-off-by: Sudip Mukherjee
---
build warning with next-20151
me to make sure they are
always
loaded if they are enabled in the kernel config.
Signed-off-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by: Hannes Reinecke
Acked-by: Mike Snitzer
Signed-off-by: James Bottomley
This was an involved commit so I didn't try to revert. Any ide
On 11/13/2015 09:57 PM, Jeff Moyer wrote:
Hi Hannes,
Hannes Reinecke writes:
When running on files the physical blocksize is actually 4k,
How did you come to that conclusion? Are you basing it on the file
system block size? If so, that's configurable at mkfs time and can be
anything
On 11/29/2015 06:05 PM, Markus Trippelsdorf wrote:
> On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote:
>> On Sun, Nov 29 2015 at 11:15am -0500,
>> Markus Trippelsdorf wrote:
>>
>>> On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote:
>>>> On 11/2
On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote:
> On 2015.11.26 at 08:11 -0500, Mike Snitzer wrote:
>> On Thu, Nov 26 2015 at 2:46am -0500,
>> Hannes Reinecke wrote:
>>
>>> When a cloned request is retried on other queues it always needs
>>> to be c
On 11/26/2015 10:21 AM, Ming Lei wrote:
> On Thu, Nov 26, 2015 at 4:13 PM, Hannes Reinecke wrote:
>> Hi all,
>>
>> while investigating the crash in scsi_lib.c I found a rather curious
>> behaviour for QUEUE_FLAG_NO_SG_MERGE.
>>
>> While the flag is
x27;t work as advertised?
Or, to be precise, which only works for blk-mq?
Should we make it work for non-block-mq, too?
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfel
blk_cloned_rq_check_limits() and removes the symbol
export, as the new function should only be used for
cloned requests and never exported.
Cc: Mike Snitzer
Cc: Ewan Milne
Cc: Jeff Moyer
Signed-off-by: Hannes Reinecke
---
block/blk-core.c | 21 +++--
include/linux/blkdev.h | 1 -
2
On 11/25/2015 06:56 PM, Jens Axboe wrote:
On 11/25/2015 02:04 AM, Hannes Reinecke wrote:
On 11/20/2015 04:28 PM, Ewan Milne wrote:
On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote:
Can't we have a joint effort here?
I've been spending a _LOT_ of time trying to debug things
On 11/25/2015 07:01 PM, Mike Snitzer wrote:
On Wed, Nov 25 2015 at 4:04am -0500,
Hannes Reinecke wrote:
On 11/20/2015 04:28 PM, Ewan Milne wrote:
On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote:
Can't we have a joint effort here?
I've been spending a _LOT_ of time tryin
> 512
> #define ARCMSR_MAX_XFER_SECTORS_B
> 4096
>
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de
On 11/25/2015 12:49 PM, Ching Huang wrote:
> From: Ching Huang
>
> Support areca new PCIe to SATA RAID adapter ARC1203
>
> Signed-of-by: Ching Huang
>
> ---
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSerie
On 11/25/2015 12:45 PM, Ching Huang wrote:
> From: Ching Huang
>
> Modifies codes for more readable
>
> Signed-of-by: Ching Huang
>
> ---
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSerie
free_coherent(&acb->pdev->dev, acb->roundup_ccbsize,
> + acb->dma_coherent2, acb->dma_coherent_handle2);
> + return false;
> }
>
> static bool arcmsr_hbaC_get_config(struct AdapterControlBlock *pACB)
>
>
Reviewed-by: Hannes Rei
On 11/25/2015 12:36 PM, Ching Huang wrote:
> From: Ching Huang
>
> Fixed getting wrong configuration data of adapter type B and type D.
>
> Signed-of-by: Ching Huang
>
> ---
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 11/20/2015 04:28 PM, Ewan Milne wrote:
> On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote:
>> Can't we have a joint effort here?
>> I've been spending a _LOT_ of time trying to debug things here, but
>> none of the ideas I've come up with have been
> 512
> #define ARCMSR_MAX_XFER_SECTORS_B
> 4096
>
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de
_cfg_version,25,100-103*/
> /*firm_ide_channels,4,16-19*/
> return true;
> +err_free_dma:
> + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize,
> + acb->dma_coherent2, acb->dma_coherent_handle2);
> + return false;
> }
>
On 11/25/2015 04:21 AM, Ching Huang wrote:
> From: Ching Huang
>
> Fixed getting wrong configuration data of adapter type B and type D.
>
> Signed-of-by: Ching Huang
>
> ---
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
o separate file
> scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k
>
> drivers/scsi/constants.c | 859
> ++---
> drivers/scsi/sense_codes.h | 826 +++
> 2 files changed, 847 insertions(+), 838 deletions(-)
&g
series.
Otherwise it'll be hard to keep track of which patch belongs to
which version.
Thanks.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nür
gt; }
> @@ -2780,7 +2780,7 @@ static unsigned long lba_to_map_index(sector_t lba)
> lba += scsi_debug_unmap_granularity -
> scsi_debug_unmap_alignment;
> }
> - do_div(lba, scsi_debug_unmap_granularity);
> + sector_div(lba, scsi_debug_un
riginal options map onto that.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Nor
On 11/20/2015 04:28 PM, Ewan Milne wrote:
On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote:
Can't we have a joint effort here?
I've been spending a _LOT_ of time trying to debug things here, but
none of the ideas I've come up with have been able to fix anything.
Yes.
On 11/20/2015 03:38 PM, Ewan Milne wrote:
> On Thu, 2015-11-19 at 16:35 +0100, Hannes Reinecke wrote:
>> On 11/19/2015 09:23 AM, Christoph Hellwig wrote:
>>> It's pretty much guaranteed a block layer bug, most likely in the
>>> merge bios to request infrastucture
actually a generic block-layer problem.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu
ude/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -668,6 +668,9 @@ struct Scsi_Host {
> unsigned use_blk_mq:1;
> unsigned use_cmd_list:1;
>
> + /* Host responded with short (<36 bytes) INQUIRY result */
> + unsigned short_inquiry:1;
> +
> /*
>* Optional
and the main loop should proceed with
> the next command in the issue queue. Clarify this logic.
>
> Signed-off-by: Finn Thain
>
> ---
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de
-
> drivers/scsi/NCR5380.h |6 --
> drivers/scsi/atari_NCR5380.c | 13 -
> 3 files changed, 32 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de
Signed-off-by: Finn Thain
>
> ---
> drivers/scsi/NCR5380.c | 30 --
> drivers/scsi/atari_NCR5380.c |6 +++---
> 2 files changed, 11 insertions(+), 25 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 11/18/2015 09:35 AM, Finn Thain wrote:
> Remove the duplicate write to the Select Enable Register that appeared
> in v1.1.38.
>
> Also remove the redundant write to Initiator Command Register prior to
> calling do_abort().
>
> Signed-off-by: Finn Thain
>
> ---
R
On 11/18/2015 09:35 AM, Finn Thain wrote:
> The aborted flag was introduced in v1.1.38 but never used. Remove it.
>
> Signed-off-by: Finn Thain
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Stor
erious problems for
> EH purposes. Those problems are addressed later in this series.
>
> ---
> drivers/scsi/NCR5380.c | 20 +++-
> drivers/scsi/atari_NCR5380.c | 30 --
> 2 files changed, 23 insertions(+), 27 deletions(-
c| 60 +--
> drivers/scsi/mac_scsi.c | 65
> ++-
> drivers/scsi/sun3_scsi.c | 47 ---
> 7 files changed, 51 insertions(+), 178 deletions(-)
>
Reviewed-by: Hannes Rei
+++
> 2 files changed, 134 insertions(+), 12 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH,
+
> 3 files changed, 20 insertions(+), 27 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürn
tion and bus reset. Again,
> the solution is to move the bus reset code into NCR5380_maybe_reset_bus().
>
> Signed-off-by: Finn Thain
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de
(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284
t;optimizations".
Signed-off-by: Finn Thain
---
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffe
27 ---
drivers/scsi/pas16.c | 21 +++--
drivers/scsi/pas16.h | 16
drivers/scsi/t128.c | 18 ++
drivers/scsi/t128.h | 16
6 files changed, 19 insertions(+), 97 deletions(-)
Reviewed-by: Hannes Rei
: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284
.c |4 ++--
6 files changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 9
.
Signed-off-by: Finn Thain
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. G
oard *boardp, struct
> scsi_cmnd *scp,
> return ASC_BUSY;
> }
> scsiqp->sense_addr = cpu_to_le32(sense_addr);
> - scsiqp->sense_len = cpu_to_le32(SCSI_SENSE_BUFFERSIZE);
> + scsiqp->sense_len = SCSI_SENSE_BUFFERSIZE;
>
&g
led via a modprobe parameters.
We actually had customers running into a host_no overflow due to
excessive host allocations and freeing done by iSCSI.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053
cmd->cmd_len != 32)
> + && sas_is_tlr_enabled(scmd->device) && scmd->cmd_len != 32)
> mpi_control |= MPI2_SCSIIO_CONTROL_TLR_ON;
>
> smid = mpt3sas_base_get_smid_scsiio(ioc, ioc->scsi_io_cb_idx, scmd);
>
Reviewed-by: Hannes Rei
pe.h
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_base.c
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_base.h
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_config.c
> delete mode 100644 drivers/scsi/mpt2sas/mpt2sas_ctl.c
> delete mode 100644 drivers/
pt3sas_base.h | 3 +++
> drivers/scsi/mpt3sas/mpt3sas_ctl.c| 18 +---
> drivers/scsi/mpt3sas/mpt3sas_module.c | 1 +
> drivers/scsi/mpt3sas/mpt3sas_scsih.c | 39
> ++-
> 6 files changed, 62 insertions(+), 8 deletions(-)
>
I'd rather s
ct
> MPT3SAS_ADAPTER *ioc,
>
> element = (Mpi2EventIrConfigElement_t *)&event_data->ConfigElement[0];
> if (ioc->shost_recovery) {
> -
> +#ifndef SCSI_MPT2SAS
> for (i = 0; i < event_data->NumElements; i++, element++) {
> if (element-
Signed-off-by: Hannes Reinecke
Reviewed-by: Christoph Hellwig
---
drivers/block/loop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index e790487..7272055 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
The current LOOP_SET_STATUS64 ioctl has two unused fields
'init[2]', which can be used in conjunction with the
LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize.
Signed-off-by: Hannes Reinecke
---
drivers/block/loop.c | 25 -
1 file changed, 20
When running on files the physical blocksize is actually 4k,
so we should be announcing it as such. This is enabled with
a new LO_FLAGS_BLOCKSIZE flag value to the existing
loop_set_status ioctl.
Signed-off-by: Hannes Reinecke
---
drivers/block/loop.c | 9 -
1 file changed, 8 insertions
Add a new field 'lo_logical_blocksize' to hold the logical
blocksize of the loop device.
Signed-off-by: Hannes Reinecke
---
drivers/block/loop.c | 9 +++--
drivers/block/loop.h | 1 +
include/uapi/linux/loop.h | 1 +
3 files changed, 9 insertions(+), 2 deletions(-)
di
Reshuffle patches
Changes to v2:
- Drop lo_flags setting in loop_set_fd as suggested by Ming Lei
Hannes Reinecke (4):
loop: Enable correct physical blocksize
loop: Remove unused 'bdev' argument from loop_set_capacity
loop: Add 'lo_logical_blocksize'
loop: Pass logical blocksi
se syscon to handle ctrl reg access
> - get SAS address from device tree
> - do not set cmd_per_lun to 1
> - remove remove controller id
> - use static wq in phy struct
> - process control phy in caller context
> - fix port->port_attached issue for rmmod
>
> [1] http:/
On 11/09/2015 03:59 PM, Laurent Vivier wrote:
>
>
> On 09/11/2015 15:50, Hannes Reinecke wrote:
>> On 11/09/2015 03:47 PM, Laurent Vivier wrote:
>>> This patch allows to define the maximum LUN numbers.
>>> As defined in 4.6.9 of SAM-4, the encoding of LUN is
&
#define IBMVSCSI_MAX_CMDS_PER_LUN 64
> +#define IBMVSCSI_MAX_LUN 32
>
> /* ----
> * Data Structures
>
Please set max_lun to 31, and remove everything else.
As discussed, max_lun is the max number of LUNs supported by the
do with QEMU; this is a driver limitation.
Please fixup the description.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Sm
o implement
a worker thread handling the reply descriptor, and having the
interrupt only to fetch the reply descriptor.
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxf
t feels decidedly odd.
Why do you probe for 64bit if 32bit fails?
Typically it's the other way round, on the grounds that 64bit DMA
should be preferred over 32bit.
Can you explain why it needs to be done the other way round here?
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 11/05/2015 12:06 AM, Brian King wrote:
> On 11/04/2015 07:02 AM, Hannes Reinecke wrote:
>> On 11/04/2015 12:46 PM, Laurent Vivier wrote:
>>>
>>>
>>> On 04/11/2015 12:16, Hannes Reinecke wrote:
>>>> On 11/04/2015 11:20 AM, Laurent Vivier wrote:
>
On 11/04/2015 12:46 PM, Laurent Vivier wrote:
>
>
> On 04/11/2015 12:16, Hannes Reinecke wrote:
>> On 11/04/2015 11:20 AM, Laurent Vivier wrote:
>>> QEMU allows until 32 LUNs.
>>>
>>> Signed-off-by: Laurent Vivier
>>> ---
>>> drive
er of bytes it can use.
Otherwise the scanning algorithm in scsi_scan.c should do the
correct thing, independent on the 'max_lun' setting.
If qemu has some issues here someone should rather fix qemu ...
Cheers,
Hannes
--
Dr. Hannes ReineckezSeries & S
On 10/30/2015 01:45 PM, Arnd Bergmann wrote:
> On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote:
>>> @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba)
>>> h->req_cnt = cpu_to_le16(hba->rq_count+1);
>>> h->status_sz
scsi: ufs: add missing memory barriers
> scsi: ufs: commit descriptors before setting the doorbell
> scsi: ufs: add wrapper for retrying sending query attribute
>
> drivers/scsi/ufs/ufshcd.c | 408
> ++++--
> drivers/scsi/ufs/ufshcd.h
that the inline sense code is 18 bytes;
if you issue a request sense directly there is not such limitation.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
stex_gettime(&h->hosttime);
> + h->hosttime = cpu_to_le64(ktime_get_real_seconds());
> h->partner_type = HMU_PARTNER_TYPE;
> h->extra_offset = h->extra_size = 0;
> scratch_size = (hba->sts_count+1)*sizeof(u32);
>
Just remove 'h
nged, 9 insertions(+), 3 deletions(-)
>
Why not printk_once?
Should achieve the same result, and we're saving yet another flag...
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, M
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_enable_iface_clk"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
> Reviewed-by: Akinobu Mita
> Reviewed-by: Subhash Jadavani
> Reviewed-by: Gilad Bro
;
>
> Reviewed-by: Akinobu Mita
> Reviewed-by: Subhash Jadavani
> Reviewed-by: Gilad Broner
> Signed-off-by: Yaniv Gardi
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49
scaling feature,
> as well as support for HS-G3 power mode.
>
> Reviewed-by: Subhash Jadavani
> Reviewed-by: Gilad Broner
> Signed-off-by: Yaniv Gardi
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de
d-off-by: Yaniv Gardi
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG
me, but only
>being called by the new probe function of the UFS variant.
>
> Reviewed-by: Rob Herring
> Reviewed-by: Gilad Broner
> Signed-off-by: Yaniv Gardi
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Stora
d-off-by: Yaniv Gardi
>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 1 -
> drivers/scsi/ufs/ufshcd.c | 104
> +---
> drivers/scsi/ufs/ufshcd.h | 98 +
> 3 files changed, 137 insertions(+), 66 deletions(-
d-off-by: Yaniv Gardi
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürn
601 - 700 of 1031 matches
Mail list logo