On 03/14/2014 11:58 AM, Christoph Hellwig wrote:
> On Fri, Mar 14, 2014 at 10:52:55AM +0100, Hannes Reinecke wrote:
>> No, I haven't. This issue is only exhibited if you try to run
>> multipath on a non-SCSI device (in this case it was cciss).
>> But then that projec
So this patch hasn't had any application in the real world and
I haven't pursued with it upstream.
But if Mike feels it'll be a good idea nevertheless I can easily
send an updated version.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.d
hink trying to
> use dm-multipath on any blk-mq device will go horribly crash and boom at
> the moment.
>
That was actually one of my plans, move dm-multipath over to use
blk-mq. But then I'd need to discuss with Jens et al how to best
achieve this; the current static
increase the define for the SCSI stack.
And, btw, so far I haven't come across any issue where a sense
buffer overflow occurred. We first need to implement a proper sense
code handling (descriptor sense parsing etc) before we need to worry
about this.
Cheers,
Hannes
--
Dr. Hannes
On 03/12/2014 11:55 AM, Christoph Hellwig wrote:
> On Wed, Mar 12, 2014 at 11:50:13AM +0100, Hannes Reinecke wrote:
>> >From the device-mapper side we have these patches which are not
>> included upstream:
>
> Another one on the dm side that seems useful is:
>
&
On 03/12/2014 11:28 AM, Christoph Hellwig wrote:
> On Sat, Mar 08, 2014 at 08:51:18PM +0100, Hannes Reinecke wrote:
>> Hey, calm down.
>> I've made the fix just two days ago. And was quite surprised that
>> I've been the first hitting that; should've crashed
On 03/08/2014 07:13 PM, Mike Snitzer wrote:
On Sat, Mar 8, 2014 at 2:51 PM, Hannes Reinecke wrote:
On 03/08/2014 06:33 PM, Mike Snitzer wrote:
On Sat, Mar 8, 2014 at 10:52 AM, Christoph Hellwig
wrote:
On Fri, Mar 07, 2014 at 03:45:09PM -0500, Jeff Moyer wrote:
Hi, Christoph,
Did you
ntly any questions, and redo the patchset.
Which I did. Frequently, But, alas, it's up to the maintainer to apply
them. And I can only ask and hope. The usual story...
I'll be sending the patch soon, Monday at latest.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries &am
_scsi_cmd_req {
>>
>
> Hi Fam, how did you test this?
>
Is there a specific reason _not_ to use the linux default?
The SCSI stack typically limits the sense code to
SCSI_SENSE_BUFFERSIZE, so using other values have a
limited sense.
Literally :-)
Cheers,
Hannes
--
Dr. Hannes Reinec
On 02/27/2014 12:30 PM, David Herrmann wrote:
> From: Hannes Reinecke
>
> The 'active' sysfs attribute should refer to the currently active tty
> devices the console is running on, not the currently active console. The
> console structure doesn't refer to any dev
On 02/24/2014 03:58 PM, David Herrmann wrote:
> Hi
>
> On Mon, Feb 24, 2014 at 3:50 PM, Hannes Reinecke wrote:
>> The 'active' sysfs attribute should refer to the currently
>> active tty devices the console is running on, not the currently
>> active cons
n 'active', not
the console names.
But we need to take care for the virtual console to always display
'tty0' so as not to break existing programs.
Cc: Lennart Poettering
Cc: Kay Sievers
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Signed-off-by: Werner Fink
Signed-off-by: Hannes
.
>
> Oh, nice catch. We have to use cs[i]->index of course. I only
> hand-edited the patch, I didn't even compile-test. But I guess you get
> the idea of special-casing tty0.
>
Okay, that's a good idea.
I'll be redoing the patch.
Cheers,
Hannes
--
Dr. Hannes Rei
he proper check for serial console.
Which, of course, means we have to stay with a broken kernel interface
for ever and ever.
Innovation, here we come.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
S
On 02/21/2014 03:48 PM, Josh Boyer wrote:
> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman
> wrote:
>> 3.13-stable review patch. If anyone has any objections, please let me know.
>>
>> ------
>>
>> From: Hannes Reinecke
>>
>>
rlying device (which defaults
to PAGE_SIZE for files).
Eventually it might be useful to select the blocksize per device, but
the interface for that will need to be discussed.
Hannes Reinecke (2):
loop: Display correct physical blocksize
loop: Add module parameter 'lbs' to set logical blocksi
The loop device already knows about the physical blocksize
(= blocksize of the underlying file). This patch adds a
module option 'lbs' to specify the blocksize directly
or '0' for using the blocksize from the underlying file.
Signed-off-by: Hannes Reinecke
---
drive
When running on files the physical blocksize is actually 4k,
so we should be announcing it as such.
Signed-off-by: Hannes Reinecke
---
drivers/block/loop.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 66e8c3b
n 'active', not
the console names.
Cc: Lennart Poettering
Cc: Kay Sievers
Cc: Greg Kroah-Hartmann
Cc: Jiri Slaby
Cc: David Herrmann
Signed-off-by: Werner Fink
Signed-off-by: Hannes Reinecke
---
Documentation/ABI/testing/sysfs-tty | 3 ++-
drivers/tty/tty
On 02/05/2014 01:53 PM, David Herrmann wrote:
> Hi
>
> On Wed, Feb 5, 2014 at 11:11 AM, Hannes Reinecke wrote:
>> The 'active' sysfs attribute should refer to the currently
>> active tty devices the console is running on, not the currently
>> active cons
On 02/06/2014 04:29 PM, Greg Kroah-Hartman wrote:
> On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote:
>> The 'active' sysfs attribute should refer to the currently
>> active tty devices the console is running on, not the currently
>> activ
n 'active', not
the console names.
Cc: Lennart Poettering
Cc: Kay Sievers
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Signed-off-by: Werner Fink
Signed-off-by: Hannes Reinecke
---
drivers/tty/tty_io.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --g
n 'active', not
the console names.
Cc: Lennart Poettering
Cc: Kay Sievers
Signed-off-by: Werner Fink
Signed-off-by: Hannes Reinecke
---
drivers/tty/tty_io.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io
s.
Plus it would make live really easy for those type of devices.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer
gt; {0x1926103C, "Smart Array P731m", &SA5_access},
>>> {0x1928103C, "Smart Array P230i", &SA5_access},
>>> {0x1929103C, "Smart Array P530", &SA5_access},
>>> + {0x192A103C, "Smart Array P531", &SA5_acces
On 01/08/2014 04:23 PM, Martin K. Petersen wrote:
"Hannes" == Hannes Reinecke writes:
Hannes,
Hannes> As there is no user (apart from oracleasm) no-one can attach
Hannes> protection information to any data, so even the most dedicated
Hannes> admin cannot exercise this p
On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote:
On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote:
On 12/24/2013 04:35 AM, Chen Gang wrote:
On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote:
On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote:
The related fix patch changed
.54b1e52 100644
--- a/drivers/target/target_core_alua.c
+++ b/drivers/target/target_core_alua.c
@@ -477,8 +477,7 @@ static inline int core_alua_state_lba_dependent(
u8 *alua_ascq)
{
struct se_device *dev = cmd->se_dev;
- u32 segment_size, segment_mult, sectors;
-
On 01/07/2014 10:43 PM, Martin K. Petersen wrote:
>>>>>> "Hannes" == Hannes Reinecke writes:
>
> Hannes> Plus (as hch rightly pointed out) as there is no defined
> Hannes> userland interface the question is why we bother with all the
> Hannes>
was a polite feigned interest ...)
We need to come up with a concise story here (either integrate with
filesystems or have a userland interface), otherwise it's just dead
code and indeed should be removed.
Plus so far I've had exactly _one_ request for DIX, and even
On 01/07/2014 02:36 AM, Darrick J. Wong wrote:
> On Fri, Jan 03, 2014 at 03:03:42PM -0500, Martin K. Petersen wrote:
>>>>>>> "Hannes" == Hannes Reinecke writes:
>>
>> Hannes> Personally, I doubt it's a good idea to kill it off, but a
>&g
f, but
a proper (userland) API for it has been a long time missing.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer,
truct instruction {
> #define AIC_OP_JC16 0x9105
> #define AIC_OP_JNC16 0x9205
> #define AIC_OP_CALL160x9305
> -#define AIC_OP_CALL160x9305
>
> /* Page extension is low three bits of second opcode byte. */
> #define AIC_OP_JMPF 0xA005
>
A
On 10/21/2013 08:07 AM, vaughan wrote:
On 10/16/2013 02:52 PM, Hannes Reinecke wrote:
But seeing that this approach raises quite some issues I've attached a
different patch. Vaughan, could you test with that, too? Should be
functionally equivalent to the previous one. Cheers, Hannes
Hi H
stly done by people outside of HP.
>
> Signed-off-by: Mike Miller
Finally.
All thumbs up for this.
Acked-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, M
On 10/14/2013 05:24 PM, Steffen Maier wrote:
> On 10/14/2013 03:32 PM, Hannes Reinecke wrote:
>> On 10/14/2013 03:18 PM, Hannes Reinecke wrote:
>>> On 10/14/2013 02:51 PM, Steffen Maier wrote:
>>>> On 10/14/2013 01:13 PM, Hannes Reinecke wrote:
>>>>&
On 10/15/2013 05:32 AM, vaughan wrote:
> On 10/14/2013 07:13 PM, Hannes Reinecke wrote:
>> In the log, inquiry to LUN7 return a sense - asc,ascq=04h,0Ch
>> (Logical unit not accessible, target port in unavailable state).
>> And this is ignored, so scsi_probe_lun() retu
On 10/14/2013 03:18 PM, Hannes Reinecke wrote:
> On 10/14/2013 02:51 PM, Steffen Maier wrote:
>> Hi Hannes,
>>
>> On 10/14/2013 01:13 PM, Hannes Reinecke wrote:
>>> On 10/13/2013 07:23 PM, Vaughan Cao wrote:
>>>> Hi James,
>>>>
>>>>
On 10/14/2013 02:51 PM, Steffen Maier wrote:
> Hi Hannes,
>
> On 10/14/2013 01:13 PM, Hannes Reinecke wrote:
>> On 10/13/2013 07:23 PM, Vaughan Cao wrote:
>>> Hi James,
>>>
>>> [1.] One line summary of the problem:
>>> special sense code asc,as
ng an 'INQUIRY' to the
device.
SPC explicitely states that the INQUIRY command should _not_ fail
for unavailable devices.
But yeah, we probably should work around this issues.
Nevertheless, please raise this issue with your array vendor.
Please try the attached patch.
Cheers,
Hannes
-
inder a few
> months later[1]. That prompted Josh Boyer to remove this old driver from
> the Fedora build[2].
>
> And now that driver is disabled in all kernels that Fedora currently
> ships. I'm not familiar with any complaints about this decision.
>
Ok, good to know.
So thi
m’:
>>drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in
>> enumerated type ‘ahc_chip’ [-Wswitch]
>>drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in
>> enumerated type ‘ahc_chip’ [-Wswitch]
>>
>> [2] http://git.kernel.org
on fails _and_ there are commands send to the device
then the error handling will kick in, but it won't be triggered
directly.
Not sure if that makes a difference, though.
> Signed-off-by: Marcus Meissner
>
Acked-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 08/28/2013 09:04 AM, Hannes Reinecke wrote:
> On 08/27/2013 04:28 PM, Jeff Moyer wrote:
>> Hi,
>>
>> We have several reports (against a distro kernel) of panics in
>> blk_requeue_request that look like this:
>>
>> kernel BUG at block/blk-core.c:1045!
&
o things a bit more.
It looks as if you're on the right track, although I doubt your
patch will fix the issue for me :-(
Thing is, you're right there is a race window between requeuing
and softirq triggering, which could well be fixed by your patch.
So for that reason alone I would like to
ll will be well.
>
> This RFC patch moves the BUG_ON(test_bit(REQ_ATOM_COMPLETE,
> &req->atomic_flags)); from blk_add_timer to the only caller that could
> trip over it (blk_start_request). It then inverts the calls to
> blk_clear_rq_complete and blk_add_timer in blk_rq_timed_
to be tricky.
This leaves me with two choices:
- Tear down the command pool altogether whenever I need to
reconfigure the device (which is going to be painful)
- Allocate some max nr_hw_queues, and mark the superfluous
ones as 'unused' or something. Seeing the a sane max nr_hw_queues
w
for discussion.
>>>
>>> The parties to be included in such a discussion are:
>>>
>>> - Jens Axboe (blk-mq author)
>>> - James Bottomley (scsi maintainer)
>>> - Christoph Hellwig (scsi)
>>> - Martin Petersen (scsi)
>>>
correct BLIST flag set.
I know of some older Hitachi and EMC firmware which would pretend to
be SCSI-2, but supporting more than 256 LUNs per host.
Which, of course, it totally bonkers.
I'll be posting my 64-bit LUN patchset, that should fix this issue.
Cheers,
Hannes
--
Dr. Hannes Reine
gram.c aicasm_scan.c aicasm_macro_scan.c -o aicasm -ldb
> aicasm_symbol.c:48:19: fatal error: aicdb.h: No such file or directory
> compilation terminated.
>
>
> random config file attached.
>
>
You need to install berkeley db ...
Cheers,
Hannes
--
Dr. Hannes Reinecke
t in the kernel.
And no, you cannot use the kernel itself as grub is run _prior_ to
the kernel.
As there is no common naming scheme for block devices each and
every block device driver has implemented it own.
So grub need to re-implement each and every device naming
for these drivers.
The approach fr
unsigned int cmd_flags)
> {
> if (unlikely(cmd_flags & REQ_DISCARD))
> - return q->limits.max_discard_sectors;
> + return min(q->limits.max_discard_sectors, UINT_MAX >> 9);
>
> if (unlikely(cmd_
r.kernel.org
Hmm?
What is the general stance on /proc entries for devices?
I was under the impression that it was marked as deprecated.
Is it not? Has it been resurrected?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911
INQUIRY command shall return CHECK
>> CONDITION status only when the device server is unable to return
>> the requested INQUIRY data
>
> Thanks James. I will further investigate the issue on our platform.
>
Or check if you can use W_LUN for scanning.
I'
derik Himpe
Cc: David Haerdeman
Cc: Alan Stern
Signed-off-by: Hannes Reinecke
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index 622b4a4..2647e75 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -173,6 +173,7 @@ int usb_hcd_pci_probe(struct pci_dev
Cc: Thomas Renninger
Cc: Yinghai Lu
Cc: Frederik Himpe
Cc: David Haerdeman
Signed-off-by: Hannes Reinecke
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 8e64adf..e583444 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2536,7 +2536,7 @@ int usb_add_
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote:
[+cc Andy]
On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke wrote:
On 02/20/2013 05:57 PM, Yinghai Lu wrote:
On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote:
Apparently this device is meant to use MSI _only_ so the BIOS developer
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote:
[+cc Andy]
On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke wrote:
On 02/20/2013 05:57 PM, Yinghai Lu wrote:
On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote:
Apparently this device is meant to use MSI _only_ so the BIOS developer
On 02/26/2013 02:29 PM, David Härdeman wrote:
On Thu, Feb 21, 2013 at 07:53:14AM +0100, Hannes Reinecke wrote:
On 02/20/2013 05:57 PM, Yinghai Lu wrote:
it seems you mess pin with interrupt line.
current code:
unsigned char irq;
pci_read_config_byte(dev, PCI_INTERRUPT_PIN
updated to do ROD copy, then we
will have some real-world data.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746
On 02/20/2013 05:57 PM, Yinghai Lu wrote:
On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote:
Apparently this device is meant to use MSI _only_ so the BIOS developer
didn't feel the need to assign an INTx here.
According to PCI-3.0, section 6.8 (Message Signalled Interrupts):
h wasn't broken
before.
Cc: Jiri Kosina
Signed-off-by: Hannes Reinecke
diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c
index 5451bef..5b95dc1 100644
--- a/drivers/message/i2o/i2o_config.c
+++ b/drivers/message/i2o/i2o_config.c
@@ -883,10 +883,9 @@ static
On 02/19/2013 08:40 PM, Yinghai Lu wrote:
On Mon, Feb 18, 2013 at 2:09 AM, Hannes Reinecke wrote:
The PCI config space reseves a byte for the interrupt line,
so irq 255 actually refers to 'not set'.
However, the 'irq' field for struct pci_dev is an integer,
so the orig
g these attributes from udev ...
Please consider adding a default attribute which return '-EINVAL' or
somesuch when the function pointers are not set.
But _not_ adding it via device_create_file(). That's evil.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries &
@vger.kernel.org
Signed-off-by: Hannes Reinecke
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 6186f03..a2db887f 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -923,7 +923,8 @@ static void pci_read_irq(struct pci_dev *dev)
dev->pin = irq;
if (irq)
kmemcheck complained about the use of uninitialized memory.
So there.
Cc: David Woodhouse
Signed-off-by: Hannes Reinecke
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 86e2f4a..2623a57 100644
--- a/drivers/iommu/dmar.c
+++ b/drivers/iommu/dmar.c
@@ -1040,7 +1040,7 @@ int
bdev_get_queue() needs to check for a valid bd_disk pointer,
otherwise it'll dereference a NULL pointer.
Signed-off-by: Hannes Reinecke
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f94bc83..7e28aaa 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -
Whenever a request has been aborted internally by the driver
there is no sense data to be had. And printing lots of messages
stalls the system, so better to print out a short one-liner.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd_erp.c |8
1 files changed, 8
The DASD driver is using FASTFAIL as an equivalent to the
transport errors in SCSI. And the 'steal lock' function maps
roughly to a reservation error. So we should be returning the
appropriate error codes when completing a request.
Cc: Jens Axboe
Signed-off-by: Hannes Reinecke
---
rq_timed_out_fn might have been unset while the request
was in flight, so we need to check for it in blk_rq_timed_out().
Cc: Jens Axboe
Signed-off-by: Hannes Reinecke
---
block/blk-timeout.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/blk-timeout.c b
Instead of having the number of retries hard-coded in the various
functions we should be using a default retry value, which can
be modified via sysfs.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd_devmap.c | 41 ++
drivers/s390/block
-off-by: Hannes Reinecke
Acked-by: Stefan Weinhuber
---
drivers/s390/block/dasd.c | 76
drivers/s390/block/dasd_diag.c |5 ++-
drivers/s390/block/dasd_eckd.c |4 ++
drivers/s390/block/dasd_fba.c |5 ++-
4 files changed, 88 insertions
This patch adds a 'timeout' attibute to the DASD driver.
When set to non-zero, the blk_timeout function will
be enabled with the timeout specified in the attribute.
Setting 'timeout' to '0' will disable block timeouts.
Signed-off-by: Hannes Reinecke
---
drivers/s
circumstances.
Changes since v1:
- Fixed lock inversion in dasd_times_out()
- Checked for 'device->block' when writing to 'timeout' attribute
- Check against 'UINT_MAX' when verifying the 'timeout' value
Hannes Reinecke (9):
dasd: Clarify comment
dasd: make num
on is activated.
The DASD_FLAG_ABORTIO is also evaluated in
__dasd_process_request_queue to abort all
new request which would have the
DASD_CQR_FLAGS_FAILFAST bit set.
The flag can be set with the new ioctls 'BIODASDABORTIO'
and removed with 'BIODASDALLOWIO'.
Signed-off-by: Hannes
dasd_cancel_req will never return 1, only 0.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 29225e1..09ddf70 100644
--- a/drivers/s390/block
_ the first request which already have expired.
So we need to check all requests in the device tasklet.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
On 01/29/2013 04:17 PM, Stefan Weinhuber wrote:
Hannes Reinecke wrote on 2013-01-29 08:12:00:
[..]
+static ssize_t
+dasd_timeout_store(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct dasd_device *device;
+ struct request_queue *q
On 01/29/2013 12:36 PM, Heiko Carstens wrote:
On Tue, Jan 29, 2013 at 08:12:00AM +0100, Hannes Reinecke wrote:
This patch adds a 'timeout' attibute to the DASD driver.
When set to non-zero, the blk_timeout function will
be enabled with the timeout specified in the attribute.
Settin
On 01/29/2013 12:32 PM, Heiko Carstens wrote:
On Tue, Jan 29, 2013 at 08:11:56AM +0100, Hannes Reinecke wrote:
This patch implements generic block layer timeout handling
callbacks for DASDs. When the timeout expires the respective
cqr is aborted.
With this timeout handler time-critical request
rq_timed_out_fn might have been unset while the request
was in flight, so we need to check for it in blk_rq_timed_out().
Cc: Jens Axboe
Signed-off-by: Hannes Reinecke
---
block/blk-timeout.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/blk-timeout.c b
Whenever a request has been aborted internally by the driver
there is no sense data to be had. And printing lots of messages
stalls the system, so better to print out a short one-liner.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd_erp.c |8
1 files changed, 8
This patch adds a 'timeout' attibute to the DASD driver.
When set to non-zero, the blk_timeout function will
be enabled with the timeout specified in the attribute.
Setting 'timeout' to '0' will disable block timeouts.
Signed-off-by: Hannes Reinecke
---
drivers/s
on is activated.
The DASD_FLAG_ABORTIO is also evaluated in
__dasd_process_request_queue to abort all
new request which would have the
DASD_CQR_FLAGS_FAILFAST bit set.
The flag can be set with the new ioctls 'BIODASDABORTIO'
and removed with 'BIODASDALLOWIO'.
Signed-off-by: Hannes
The DASD driver is using FASTFAIL as an equivalent to the
transport errors in SCSI. And the 'steal lock' function maps
roughly to a reservation error. So we should be returning the
appropriate error codes when completing a request.
Cc: Jens Axboe
Signed-off-by: Hannes Reinecke
---
_ the first request which already have expired.
So we need to check all requests in the device tasklet.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
circumstances.
Please apply.
Hannes Reinecke (9):
dasd: Clarify comment
dasd: make number of retries configurable
dasd: process all requests in the device tasklet
dasd: Implement block timeout handling
dasd: Reduce amount of messages for specific errors
dasd: detailed I/O errors
block: check
dasd_cancel_req will never return 1, only 0.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 29225e1..09ddf70 100644
--- a/drivers/s390/block
Instead of having the number of retries hard-coded in the various
functions we should be using a default retry value, which can
be modified via sysfs.
Signed-off-by: Hannes Reinecke
---
drivers/s390/block/dasd_devmap.c | 41 ++
drivers/s390/block
-off-by: Hannes Reinecke
Acked-by: Stefan Weinhuber
---
drivers/s390/block/dasd.c | 76
drivers/s390/block/dasd_diag.c |5 ++-
drivers/s390/block/dasd_eckd.c |4 ++
drivers/s390/block/dasd_fba.c |5 ++-
4 files changed, 88 insertions
The compiler complained about missing section annotations.
Fix it.
Signed-off-by: Hannes Reinecke
Cc: Anton Vorontsov
Cc: Colin Cross
Cc: Kees Cook
Cc: Tony Luck
---
fs/pstore/ram.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/fs/pstore/ram.c b/fs
codes like -ENOLINK when the nexus
is dropped. Quite useful in multipathed or clustered environs.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Haw
ait);
> +
> /**
> * bio_advance - increment/complete a bio by some number of bytes
> * @bio: bio to advance
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index d985e90..3bf696b 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -252,6 +25
for doing so etc).
None of the FC driver do this, despite the fact that resizing a disk
is even easier here.
I even tried to remove that line once, but then got told off by then
Adaptec that I would break their apps.
Since then there's a patch in the SLES kernel for adding a module
option
*/
scsicmd->device->removable = 1;
To the extend of my knowledge aacraid does this _precisely_ to allow
for resizing; in effect every open() will trigger a device revalidation.
So I guess by just setting the 'removable' flag you should be okay.
You might need to re
On 07/20/2012 01:30 PM, Dan Carpenter wrote:
> "ahd" can be NULL here and it gets dereferenced inside the call to
> ahd_name().
>
> Signed-off-by: Dan Carpenter
>
Acked-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeri
I've Cc:-ed the aic7xxx people.
>
> Thanks for testing Ingo.
>
> James - I plan to submit this via kbuild.git in about 10 hours.
> Let me know if you would like it to go in via scsi and I
> will drop you an updated patch (need to elaboarte a bit more
James Bottomley wrote:
> On Fri, 2007-12-14 at 10:00 +0100, Hannes Reinecke wrote:
>> James Bottomley wrote:
>>> On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote:
>>>> OK, thanks. I'll assume that James and Hannes have this in hand (or will
>>>
oing: rebasing the
> scsi-misc tree to remove this commit:
>
> commit 8655a546c83fc43f0a73416bbd126d02de7ad6c0
> Author: Hannes Reinecke <[EMAIL PROTECTED]>
> Date: Tue Nov 6 09:23:40 2007 +0100
>
> [SCSI] Do not requeue requests
installment.
>
> I've bisected it to the following patch in git-scsi-misc branch.
> Revert on top of 2.6.24-rc4-mm1 also helps.
>
> commit 8655a546c83fc43f0a73416bbd126d02de7ad6c0
> Author: Hannes Reinecke <[EMAIL PROTECTED]>
> Date: Tue Nov 6 09:23:40
901 - 1000 of 1031 matches
Mail list logo
