Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-17 Thread Hannes Reinecke
On 02/16/2016 05:56 PM, John Garry wrote: > On 16/02/2016 15:33, Hannes Reinecke wrote: >> On 02/16/2016 01:22 PM, John Garry wrote: >>> In high-datarate aging tests, it is found that >>> the SCSI framework can periodically >>> issue lu resets to the device. Thi

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-17 Thread Hannes Reinecke
On 02/16/2016 05:56 PM, John Garry wrote: > On 16/02/2016 15:33, Hannes Reinecke wrote: >> On 02/16/2016 01:22 PM, John Garry wrote: >>> In high-datarate aging tests, it is found that >>> the SCSI framework can periodically >>> issue lu resets to the device. Thi

Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-17 Thread Hannes Reinecke
On 02/16/2016 05:13 PM, John Garry wrote: > On 16/02/2016 15:31, Hannes Reinecke wrote: >> On 02/16/2016 01:22 PM, John Garry wrote: >>> When TRANS_TX_CREDIT_TIMEOUT_ERR or >>> TRANS_TX_CLOSE_NORMAL_ERR errors occur for a >>> command, the command should be re-at

Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-17 Thread Hannes Reinecke
On 02/16/2016 05:13 PM, John Garry wrote: > On 16/02/2016 15:31, Hannes Reinecke wrote: >> On 02/16/2016 01:22 PM, John Garry wrote: >>> When TRANS_TX_CREDIT_TIMEOUT_ERR or >>> TRANS_TX_CLOSE_NORMAL_ERR errors occur for a >>> command, the command should be re-at

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread Hannes Reinecke
he same command, > causing the timeouts. > To overcome this, the queue depth for the device needs > to be reduced to 64 (from 256, set in > sas_slave_configure()). > Hmm. TASK SET FULL should cause the queue depth to be reduced automatically, no? Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-16 Thread Hannes Reinecke
he same command, > causing the timeouts. > To overcome this, the queue depth for the device needs > to be reduced to 64 (from 256, set in > sas_slave_configure()). > Hmm. TASK SET FULL should cause the queue depth to be reduced automatically, no? Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 4/6] hisi_sas: use slot abort in v2 hw

2016-02-16 Thread Hannes Reinecke
slot_err_v2_hw(hisi_hba, task, slot); > + slot_err_v2_hw(hisi_hba, task, slot, _slot); > + if (unlikely(abort_slot)) { > + queue_work(hisi_hba->wq, >abort_slot); > + sts = ts->stat; > + goto

Re: [PATCH 4/6] hisi_sas: use slot abort in v2 hw

2016-02-16 Thread Hannes Reinecke
+ slot_err_v2_hw(hisi_hba, task, slot, _slot); > + if (unlikely(abort_slot)) { > + queue_work(hisi_hba->wq, >abort_slot); > + sts = ts->stat; > + goto out_1; > + } > g

Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-16 Thread Hannes Reinecke
ue_work(hisi_hba->wq, >abort_slot); > + sts = ts->stat; > + goto out_1; > + } > goto out; > } > What is the 'abort_slot' variable for? Currently it's just a counter, no? So why the weird pointer pass

Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-16 Thread Hannes Reinecke
lot); > + sts = ts->stat; > + goto out_1; > + } > goto out; > } > What is the 'abort_slot' variable for? Currently it's just a counter, no? So why the weird pointer passing? And it does feel weird. Apparent

Re: [PATCH 2/6] hisi_sas: add hisi_sas_slot_abort()

2016-02-16 Thread Hannes Reinecke
prep(struct sas_task *task, struct hisi_hba > *hisi_hba, > int is_tmf, struct hisi_sas_tmf_task *tmf, > int *pass) Do you really need to query the task first? As per SAM a successful return from an ABORT TASK TMF has this meaning: A response of

Re: [PATCH 2/6] hisi_sas: add hisi_sas_slot_abort()

2016-02-16 Thread Hannes Reinecke
ct hisi_hba > *hisi_hba, > int is_tmf, struct hisi_sas_tmf_task *tmf, > int *pass) Do you really need to query the task first? As per SAM a successful return from an ABORT TASK TMF has this meaning: A response of FUNCTION COMPLETE shal

Re: [PATCH 1/6] hisi_sas: add TMF_RESP_FUNC_SUCC check

2016-02-16 Thread Hannes Reinecke
PLETE && > + task->task_status.stat == TMF_RESP_FUNC_SUCC) { > + res = TMF_RESP_FUNC_SUCC; > + break; > + } > + > + if (task->task_status.resp == SAS_TASK_COMPLETE && > task->task_sta

Re: [PATCH 1/6] hisi_sas: add TMF_RESP_FUNC_SUCC check

2016-02-16 Thread Hannes Reinecke
task->task_status.stat == TMF_RESP_FUNC_SUCC) { > + res = TMF_RESP_FUNC_SUCC; > + break; > + } > + > + if (task->task_status.resp == SAS_TASK_COMPLETE && > task->task_status.stat == SAS_DATA_UND

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

2016-02-09 Thread Hannes Reinecke
On 02/09/2016 10:04 PM, Bjorn Helgaas wrote: > On Wed, Jan 13, 2016 at 12:25:34PM +0100, Hannes Reinecke wrote: >> PCI-2.2 VPD entries have a maximum size of 32k, but might actually >> be smaller than that. To figure out the actual size one has to read >> the VPD area

Re: [PATCHv2 2/4] pci: allow access to VPD attributes with size '0'

2016-02-09 Thread Hannes Reinecke
On 02/09/2016 09:53 PM, Bjorn Helgaas wrote: > Hi Hannes, > > On Wed, Jan 13, 2016 at 12:25:33PM +0100, Hannes Reinecke wrote: >> It is not always possible to determine the actual size of the VPD >> data, so allow access to them if the size is set to '0'. >> >&g

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

2016-02-09 Thread Hannes Reinecke
On 02/09/2016 10:04 PM, Bjorn Helgaas wrote: > On Wed, Jan 13, 2016 at 12:25:34PM +0100, Hannes Reinecke wrote: >> PCI-2.2 VPD entries have a maximum size of 32k, but might actually >> be smaller than that. To figure out the actual size one has to read >> the VPD area

Re: [PATCHv2 2/4] pci: allow access to VPD attributes with size '0'

2016-02-09 Thread Hannes Reinecke
On 02/09/2016 09:53 PM, Bjorn Helgaas wrote: > Hi Hannes, > > On Wed, Jan 13, 2016 at 12:25:33PM +0100, Hannes Reinecke wrote: >> It is not always possible to determine the actual size of the VPD >> data, so allow access to them if the size is set to '0'. >> >>

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Hannes Reinecke
oncat > these three entries to make a unique identifier: > > /sys/block/nvmeXnY/device/serial > /sys/block/nvmeXnY/device/model > /sys/block/nvmeXnY/nsid Ok, so what about having a 'wwid' attribute which provides combined information (like scsi has)? Cheers, Hannes -- Dr. H

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Hannes Reinecke
oncat > these three entries to make a unique identifier: > > /sys/block/nvmeXnY/device/serial > /sys/block/nvmeXnY/device/model > /sys/block/nvmeXnY/nsid Ok, so what about having a 'wwid' attribute which provides combined information (like scsi has)? Cheers, Hannes -- Dr. H

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-07 Thread Hannes Reinecke
> systemd with the rules that work for me. > Why, but you can. That's precisely what I did with the transition to sg_inq; I've added a new set of rules (55-sg_inq.rules and 59-sg-symlinks.rules) which will override the values from 60-persistent-storage.rules. Do we have defined sysfs attri

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-07 Thread Hannes Reinecke
he respective rules (using sg_inq) to udev. There's no mentioning of any NVMe specific sysfs attributes whatsoever. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr.

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-07 Thread Hannes Reinecke
> systemd with the rules that work for me. > Why, but you can. That's precisely what I did with the transition to sg_inq; I've added a new set of rules (55-sg_inq.rules and 59-sg-symlinks.rules) which will override the values from 60-persistent-storage.rules. Do we have defined sysfs attri

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-07 Thread Hannes Reinecke
he respective rules (using sg_inq) to udev. There's no mentioning of any NVMe specific sysfs attributes whatsoever. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr.

Re: [PATCH v2] dm pref-path: provides preferred path load balance policy

2016-01-30 Thread Hannes Reinecke
s different, but what do I know ... 2. For people that need to be able to control the exact priority, I'm redoing the weighted handler to allow better ways to specify the paths in a presistent manner. It won't be as simple as the alua method, but it will be actually usable, unlike it's curren

Re: [PATCH v2] dm pref-path: provides preferred path load balance policy

2016-01-30 Thread Hannes Reinecke
s different, but what do I know ... 2. For people that need to be able to control the exact priority, I'm redoing the weighted handler to allow better ways to specify the paths in a presistent manner. It won't be as simple as the alua method, but it will be actually usable, unlike it's curren

Re: [PATCH 2/2] scsi: Fix RCU handling for VPD pages

2016-01-20 Thread Hannes Reinecke
+), 42 deletions(-) > Thanks for fixing this up. I didn't really like the two distinct variables for vpd buffer and length, too, but hadn't thought of using a struct for here. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking

Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-01-20 Thread Hannes Reinecke
slightly pointless, given that we're testing the inverse condition in scsi_attach_vpd()? And in anycase, I guess we should be using the same logic sd.c is using. Please see the attached patch. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-01-20 Thread Hannes Reinecke
> Isn't this slightly pointless, given that we're testing the inverse condition in scsi_attach_vpd()? And in anycase, I guess we should be using the same logic sd.c is using. Please see the attached patch. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networki

Re: [PATCH 2/2] scsi: Fix RCU handling for VPD pages

2016-01-20 Thread Hannes Reinecke
changed, 50 insertions(+), 42 deletions(-) > Thanks for fixing this up. I didn't really like the two distinct variables for vpd buffer and length, too, but hadn't thought of using a struct for here. Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr.

Re: [PATCH V4 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-28 Thread Hannes Reinecke
;); My original question still stands: Where is the point if supporting FC devices if CONFIG_SCSI_FC_ATTRS is disabled? I would rather disable FC support completely if that option is deselected; otherwise you'll end up with a strange cross-breed which presents FC LUNs but no attributes. Cheer

Re: [PATCH V4 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-28 Thread Hannes Reinecke
+#if IS_ENABLED(CONFIG_SCSI_FC_ATTRS) + fc_release_transport(fc_transport_template); +#endif } MODULE_LICENSE("GPL"); My original question still stands: Where is the point if supporting FC devices if CONFIG_SCSI_FC_ATTRS is disabled? I would rather disable FC support com

Re: [PATCH v3 20/77] ncr5380: Introduce unbound workqueue

2015-12-22 Thread Hannes Reinecke
On 12/22/2015 01:44 PM, Finn Thain wrote: On Tue, 22 Dec 2015, Hannes Reinecke wrote: On 12/22/2015 02:17 AM, Finn Thain wrote: Allocate a work queue that will permit busy waiting and sleeping. This means NCR5380_init() can potentially fail, so add this error path. Signed-off-by: Finn Thain

Re: [PATCH v3 18/77] ncr5380: Eliminate USLEEP_WAITLONG delay

2015-12-22 Thread Hannes Reinecke
On 12/22/2015 01:38 PM, Finn Thain wrote: On Tue, 22 Dec 2015, Hannes Reinecke wrote: On 12/22/2015 02:17 AM, Finn Thain wrote: Linux 2.1.105 introduced the USLEEP_WAITLONG delay, apparently "needed for Mustek scanners". It is intended to stall the issue queue for

Re: [PATCH v3 77/77] ncr5380: Add support for HP C2502

2015-12-22 Thread Hannes Reinecke
Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürn

Re: [PATCH v3 76/77] ncr5380: Fix wait for 53C80 registers registers after PDMA

2015-12-22 Thread Hannes Reinecke
++--- 1 file changed, 6 insertions(+), 31 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Haw

Re: [PATCH v3 73/77] ncr5380: Use runtime register mapping

2015-12-22 Thread Hannes Reinecke
Zary Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 1

Re: [PATCH v3 74/77] ncr5380: Enable PDMA for NCR53C400A

2015-12-22 Thread Hannes Reinecke
to Ondrej's version: - An 'if' statement is now a 'switch' statement. - Throw an error if MMIO register locations are not known. --- drivers/scsi/g_NCR5380.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes

Re: [PATCH v3 75/77] ncr5380: Enable PDMA for DTC chips

2015-12-22 Thread Hannes Reinecke
-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürn

Re: [PATCH v3 72/77] ncr5380: Fix pseudo DMA transfers on 53C400

2015-12-22 Thread Hannes Reinecke
on 53C400 (Canon FG2-5202). Signed-off-by: Ondrej Zary Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 9

Re: [PATCH v3 70/77] atari_NCR5380: Merge changes from NCR5380.c

2015-12-22 Thread Hannes Reinecke
that 'diff' can be used to reveal the important ones, to facilitate reunification. Signed-off-by: Finn Thain --- drivers/scsi/atari_NCR5380.c | 108 +-- 1 file changed, 64 insertions(+), 44 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes

Re: [PATCH v3 71/77] ncr5380: Cleanup whitespace and parentheses

2015-12-22 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 30 +++--- drivers/scsi/atari_NCR5380.c | 26 +- 2 files changed, 32 insertions(+), 24 deletions(-) Reviewed-by: Hannes Reinecke

Re: [PATCH v3 69/77] ncr5380: Merge changes from atari_NCR5380.c

2015-12-22 Thread Hannes Reinecke
forks so that 'diff' can be used to reveal the important ones, to facilitate reunification. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 155 +++-- 1 file changed, 87 insertions(+), 68 deletions(-) Reviewed-by: Hannes Reinecke Cheers

Re: [PATCH v3 67/77] ncr5380: Cleanup comments

2015-12-22 Thread Hannes Reinecke
-- drivers/scsi/NCR5380.c | 154 ++- drivers/scsi/atari_NCR5380.c | 97 +++ 2 files changed, 48 insertions(+), 203 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.d

Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

2015-12-22 Thread Hannes Reinecke
+-- drivers/scsi/atari_NCR5380.c | 110 2 files changed, 330 insertions(+), 330 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688

Re: [PATCH v3 66/77] ncr5380: Fix soft lockups

2015-12-22 Thread Hannes Reinecke
changed, 16 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendör

Re: [PATCH v3 65/77] atari_scsi, sun3_scsi: Remove global Scsi_Host pointer

2015-12-22 Thread Hannes Reinecke
|5 +- drivers/scsi/atari_scsi.c| 29 - drivers/scsi/sun3_scsi.c | 72 ++- 3 files changed, 36 insertions(+), 70 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries

Re: [PATCH v3 64/77] atari_NCR5380: Eliminate HOSTNO macro

2015-12-22 Thread Hannes Reinecke
insertions(+), 89 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746

Re: [PATCH v3 63/77] atari_NCR5380: Remove HOSTNO macro from printk() and seq_printf() calls

2015-12-22 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Remove the HOSTNO macro that is peculiar to atari_NCR5380.c and contributes to the problem of divergence of the NCR5380 core drivers. Keep NCR5380.c in sync. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes

Re: [PATCH v3 62/77] ncr5380: Implement new eh_bus_reset_handler

2015-12-22 Thread Hannes Reinecke
Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list:

Re: [PATCH v3 61/77] ncr5380: Fix EH during arbitration and selection

2015-12-22 Thread Hannes Reinecke
+-- drivers/scsi/NCR5380.h |4 +- drivers/scsi/atari_NCR5380.c | 82 +++ 3 files changed, 119 insertions(+), 43 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries

Re: [PATCH v3 66/77] ncr5380: Fix soft lockups

2015-12-22 Thread Hannes Reinecke
t128.c |1 + 10 files changed, 16 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxf

Re: [PATCH v3 65/77] atari_scsi, sun3_scsi: Remove global Scsi_Host pointer

2015-12-22 Thread Hannes Reinecke
.au> --- drivers/scsi/atari_NCR5380.c |5 +- drivers/scsi/atari_scsi.c| 29 - drivers/scsi/sun3_scsi.c | 72 ++- 3 files changed, 36 insertions(+), 70 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers,

Re: [PATCH v3 69/77] ncr5380: Merge changes from atari_NCR5380.c

2015-12-22 Thread Hannes Reinecke
viewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -

Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

2015-12-22 Thread Hannes Reinecke
5380.c | 550 +-- drivers/scsi/atari_NCR5380.c | 110 2 files changed, 330 insertions(+), 330 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Stor

Re: [PATCH v3 67/77] ncr5380: Cleanup comments

2015-12-22 Thread Hannes Reinecke
gt; --- drivers/scsi/NCR5380.c | 154 ++- drivers/scsi/atari_NCR5380.c | 97 +++ 2 files changed, 48 insertions(+), 203 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reine

Re: [PATCH v3 77/77] ncr5380: Add support for HP C2502

2015-12-22 Thread Hannes Reinecke
Ondrej Zary <li...@rainbow-software.org> Signed-off-by: Finn Thain <fth...@telegraphics.com.au> Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053

Re: [PATCH v3 73/77] ncr5380: Use runtime register mapping

2015-12-22 Thread Hannes Reinecke
/outsb. Signed-off-by: Ondrej Zary <li...@rainbow-software.org> Signed-off-by: Finn Thain <fth...@telegraphics.com.au> Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de

Re: [PATCH v3 76/77] ncr5380: Fix wait for 53C80 registers registers after PDMA

2015-12-22 Thread Hannes Reinecke
n Thain <fth...@telegraphics.com.au> --- drivers/scsi/g_NCR5380.c | 37 ++--- 1 file changed, 6 insertions(+), 31 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSerie

Re: [PATCH v3 74/77] ncr5380: Enable PDMA for NCR53C400A

2015-12-22 Thread Hannes Reinecke
ged, 19 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J

Re: [PATCH v3 75/77] ncr5380: Enable PDMA for DTC chips

2015-12-22 Thread Hannes Reinecke
ed-off-by: Ondrej Zary <li...@rainbow-software.org> Signed-off-by: Finn Thain <fth...@telegraphics.com.au> Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053

Re: [PATCH v3 72/77] ncr5380: Fix pseudo DMA transfers on 53C400

2015-12-22 Thread Hannes Reinecke
f it's not. This makes PDMA work on 53C400 (Canon FG2-5202). Signed-off-by: Ondrej Zary <li...@rainbow-software.org> Signed-off-by: Finn Thain <fth...@telegraphics.com.au> Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v3 70/77] atari_NCR5380: Merge changes from NCR5380.c

2015-12-22 Thread Hannes Reinecke
Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To

Re: [PATCH v3 71/77] ncr5380: Cleanup whitespace and parentheses

2015-12-22 Thread Hannes Reinecke
etions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16

Re: [PATCH v3 61/77] ncr5380: Fix EH during arbitration and selection

2015-12-22 Thread Hannes Reinecke
5380.c | 76 +-- drivers/scsi/NCR5380.h |4 +- drivers/scsi/atari_NCR5380.c | 82 +++ 3 files changed, 119 insertions(+), 43 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers,

Re: [PATCH v3 63/77] atari_NCR5380: Remove HOSTNO macro from printk() and seq_printf() calls

2015-12-22 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Remove the HOSTNO macro that is peculiar to atari_NCR5380.c and contributes to the problem of divergence of the NCR5380 core drivers. Keep NCR5380.c in sync. Signed-off-by: Finn Thain <fth...@telegraphics.com.au> Reviewed-by: Hannes Reine

Re: [PATCH v3 62/77] ncr5380: Implement new eh_bus_reset_handler

2015-12-22 Thread Hannes Reinecke
etions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16

Re: [PATCH v3 64/77] atari_NCR5380: Eliminate HOSTNO macro

2015-12-22 Thread Hannes Reinecke
| 102 +++ 2 files changed, 84 insertions(+), 89 deletions(-) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnber

Re: [PATCH v3 18/77] ncr5380: Eliminate USLEEP_WAITLONG delay

2015-12-22 Thread Hannes Reinecke
On 12/22/2015 01:38 PM, Finn Thain wrote: On Tue, 22 Dec 2015, Hannes Reinecke wrote: On 12/22/2015 02:17 AM, Finn Thain wrote: Linux 2.1.105 introduced the USLEEP_WAITLONG delay, apparently "needed for Mustek scanners". It is intended to stall the issue queue for

Re: [PATCH v3 20/77] ncr5380: Introduce unbound workqueue

2015-12-22 Thread Hannes Reinecke
On 12/22/2015 01:44 PM, Finn Thain wrote: On Tue, 22 Dec 2015, Hannes Reinecke wrote: On 12/22/2015 02:17 AM, Finn Thain wrote: Allocate a work queue that will permit busy waiting and sleeping. This means NCR5380_init() can potentially fail, so add this error path. Signed-off-by: Finn Thain

Re: [PATCH v3 60/77] ncr5380: Implement new eh_abort_handler

2015-12-21 Thread Hannes Reinecke
insertions(+), 30 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746

Re: [PATCH v3 59/77] ncr5380: Fix autosense bugs

2015-12-21 Thread Hannes Reinecke
|2 drivers/scsi/atari_NCR5380.c | 239 --- 3 files changed, 249 insertions(+), 186 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de

Re: [PATCH v3 58/77] ncr5380: Refactor command completion

2015-12-21 Thread Hannes Reinecke
| 31 ++-- drivers/scsi/atari_NCR5380.c | 46 --- 2 files changed, 55 insertions(+), 22 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@sus

Re: [PATCH v3 57/77] ncr5380: Use standard list data structure

2015-12-21 Thread Hannes Reinecke
ore driver. Well, using ->host_scribble allows for an easy check on the midlayer if a command has been properly released by the LLDD. But that's just a side-note. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h.

Re: [PATCH v3 56/77] ncr5380: Remove redundant volatile qualifiers

2015-12-21 Thread Hannes Reinecke
insertions(+), 7 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 1

Re: [PATCH v3 55/77] ncr5380: Remove LIST and REMOVE macros

2015-12-21 Thread Hannes Reinecke
--- drivers/scsi/NCR5380.c | 19 --- drivers/scsi/atari_NCR5380.c | 32 2 files changed, 51 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@sus

Re: [PATCH v3 54/77] ncr5380: Use dsprintk() for queue debugging

2015-12-21 Thread Hannes Reinecke
/atari_NCR5380.c | 43 +++ 2 files changed, 47 insertions(+), 32 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE L

Re: [PATCH v3 53/77] ncr5380: Use shost_priv helper

2015-12-21 Thread Hannes Reinecke
+++- 2 files changed, 17 insertions(+), 26 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Haw

Re: [PATCH v3 52/77] ncr5380: Remove H_NO macro and introduce dsprintk

2015-12-21 Thread Hannes Reinecke
(+), 30 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746

Re: [PATCH v3 51/77] ncr5380: Remove command list debug code

2015-12-21 Thread Hannes Reinecke
|1 drivers/scsi/sun3_scsi.c |2 6 files changed, 9 insertions(+), 162 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldst

Re: [PATCH v3 50/77] ncr5380: Change instance->host_lock to hostdata->lock

2015-12-21 Thread Hannes Reinecke
le impact there. In the SMP case the new lock should be uncontested even when the SCSI bus is contested. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 6

Re: [PATCH v3 49/77] ncr5380: Remove redundant ICR_ARBITRATION_LOST test and eliminate FLAG_DTC3181E

2015-12-21 Thread Hannes Reinecke
/g_NCR5380.c |2 +- 5 files changed, 3 insertions(+), 25 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg G

Re: [PATCH v3 48/77] atari_NCR5380: Fix queue_size limit

2015-12-21 Thread Hannes Reinecke
in the assignment are swapped. Fix this and cleanup some obsolete comments. Signed-off-by: Finn Thain --- drivers/scsi/atari_NCR5380.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries

Re: [PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers

2015-12-21 Thread Hannes Reinecke
12 files changed, 82 insertions(+), 111 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Haw

Re: [PATCH v3 46/77] ncr5380: Fix NDEBUG_NO_DATAOUT flag

2015-12-21 Thread Hannes Reinecke
-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this

Re: [PATCH v3 45/77] ncr5380: Cleanup #include directives

2015-12-21 Thread Hannes Reinecke
++ drivers/scsi/mac_scsi.c |1 - drivers/scsi/pas16.c |4 drivers/scsi/t128.c |3 --- 12 files changed, 7 insertions(+), 34 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@sus

Re: [PATCH v3 44/77] ncr5380: Fix off-by-one bug in extended_msg[] bounds check

2015-12-21 Thread Hannes Reinecke
(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubsc

Re: [PATCH v3 43/77] ncr5380: Standardize reselection handling

2015-12-21 Thread Hannes Reinecke
+++ drivers/scsi/atari_NCR5380.c | 50 ++ 2 files changed, 93 insertions(+), 72 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688

Re: [PATCH v3 41/77] ncr5380: Replace redundant flags with FLAG_NO_DMA_FIXUP

2015-12-21 Thread Hannes Reinecke
|2 - 4 files changed, 25 insertions(+), 53 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Haw

Re: [PATCH v3 42/77] ncr5380: Replace READ_OVERRUNS macro with FLAG_NO_DMA_FIXUPS

2015-12-21 Thread Hannes Reinecke
on FLAG_NO_DMA_FIXUPS. Do the same for the DMA case, to eliminate the READ_OVERRUNS macro. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfel

Re: [PATCH v3 40/77] ncr5380: Introduce NCR5380_poll_politely2

2015-12-21 Thread Hannes Reinecke
--- drivers/scsi/NCR5380.c | 66 --- drivers/scsi/atari_NCR5380.c | 62 2 files changed, 75 insertions(+), 53 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v3 39/77] ncr5380: Standardize interrupt handling

2015-12-21 Thread Hannes Reinecke
rs/scsi/g_NCR5380.c |2 4 files changed, 180 insertions(+), 173 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nü

Re: [PATCH v3 38/77] ncr5380: Remove UNSAFE macro

2015-12-21 Thread Hannes Reinecke
f. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer,

Re: [PATCH v3 37/77] ncr5380: Standardize work queueing algorithm

2015-12-21 Thread Hannes Reinecke
| 80 +++ 2 files changed, 6 insertions(+), 75 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products

Re: [PATCH v3 36/77] ncr5380: Use work_struct instead of delayed_work

2015-12-21 Thread Hannes Reinecke
--- drivers/scsi/NCR5380.c | 12 +--- drivers/scsi/NCR5380.h |1 - 2 files changed, 5 insertions(+), 8 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688

Re: [PATCH v3 35/77] ncr5380: Dont wait for BUS FREE after disconnect

2015-12-21 Thread Hannes Reinecke
ivers/scsi/atari_NCR5380.c | 11 --- 2 files changed, 18 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH v3 34/77] atari_NCR5380: Use arbitration timeout

2015-12-21 Thread Hannes Reinecke
| 44 ++--- drivers/scsi/atari_NCR5380.c | 57 ++- 2 files changed, 49 insertions(+), 52 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@sus

Re: [PATCH v3 33/77] atari_NCR5380: Set do_abort() timeouts

2015-12-21 Thread Hannes Reinecke
/scsi/atari_NCR5380.c | 34 +- 2 files changed, 34 insertions(+), 26 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Prod

Re: [PATCH v3 32/77] ncr5380: Fix bus phase in do_abort()

2015-12-21 Thread Hannes Reinecke
-off-by: Finn Thain Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746

Re: [PATCH v3 31/77] ncr5380: Fix !REQ timeout in do_abort()

2015-12-21 Thread Hannes Reinecke
/NCR5380.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg G

<    5   6   7   8   9   10   11   12   13   14   >