Re: [PATCH v2 00/12] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-01-18 Thread Hans de Goede
Hi, On 1/18/21 10:55 AM, Lee Jones wrote: > On Sun, 17 Jan 2021, Hans de Goede wrote: > >> Hi All, >> >> This series reworks the arizona codec jack-detect support to use >> the snd_soc_jack helpers instead of direct extcon reporting. >> >> T

[PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-17 Thread Hans de Goede
Hartmann, combined with insights in things like the speaker GPIO from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1]. [1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel Cc: Christian Hartmann Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede

[PATCH v3 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data()

2021-01-17 Thread Hans de Goede
functions (this could happen on e.g. manual driver binding through sysfs). Suggested-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v2: - New patch in v2 of this patchset --- drivers/mfd/arizona-core.c | 11 --- drivers/mfd/arizona-i2c.c | 10 ++ drivers/mfd/arizona

[PATCH v3 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2021-01-17 Thread Hans de Goede
ine driver and ACPI hooks, the BYT-CR detection quirk which these devices need will be added in a separate patch. BugLink: https://github.com/thesofproject/linux/issues/2485 Co-authored-by: Pierre-Louis Bossart Signed-off-by: Pierre-Louis Bossart Reviewed-by: Andy Shevchenko Signed-off-by: Han

[PATCH v3 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-01-17 Thread Hans de Goede
. and 2. still have their IPC IRQ at index 0 rather then 5 Add a DMI quirk table to check for the few known models with this issue, so that the right IPC IRQ index is used on these systems. Reviewed-by: Andy Shevchenko Acked-by: Pierre-Louis Bossart Signed-off-by: Hans de Goede --- sound/soc

[PATCH v3 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")

2021-01-17 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/mfd/arizona-i2c.c | 1 + drivers/mfd/arizona-spi.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c index 4b58e3ad6eb6..2a4a3a164d0a 100644 --- a/drivers/mfd/arizona-i2c.c +++ b/drivers/mfd/ari

[PATCH v3 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-01-17 Thread Hans de Goede
Hi All, Here is v3 of my series to add support for Intel Bay Trail based devices which use a WM5102 codec for audio output/input. New in v3 is that the compile error when CONFIG_ACPI is unset should be gone. Everything else is the same as in v2, see the cover-letter of v2 below: This was

[PATCH v2 03/12] ASoC: arizona-jack: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2021-01-17 Thread Hans de Goede
2 steps when arizona_hpdet_irq runs after the jack has been unplugged. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/code

[PATCH v2 09/12] ASoC: arizona-jack: Use snd_soc_jack to report jack events

2021-01-17 Thread Hans de Goede
Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 149 +--- sound/soc/codecs/arizona.h | 7 +- 2 files changed, 47 insertions(+), 109 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c index eb46087f3ab7..51

[PATCH v2 10/12] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library

2021-01-17 Thread Hans de Goede
Make all arizona codec drivers for which drivers/mfd/arizona-core.c used to instantiate a "arizona-extcon" child-device use the new arizona-jack.c library for jack-detection. This has been tested on a Lenovo Yoga Tablet 2 1051L with a WM5102 codec. Signed-off-by: Hans de Goede ---

[PATCH v2 08/12] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-01-17 Thread Hans de Goede
ers for codecs which are converted to use the new helper functions from arizona-jack.c are modified to create a snd_soc_jack through snd_soc_card_jack_new() and register this jack with the codec through snd_soc_component_set_jack(). Signed-off-by: Hans de Goede --- sound/soc/codecs/Makef

[PATCH v2 12/12] extcon: arizona: Drop the arizona extcon driver

2021-01-17 Thread Hans de Goede
vices for it to bind to), so it can be dropped. Signed-off-by: Hans de Goede --- MAINTAINERS |1 - drivers/extcon/Kconfig |8 - drivers/extcon/Makefile |1 - drivers/extcon/extcon-arizona.c | 1816 --- 4 files cha

[PATCH v2 11/12] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-01-17 Thread Hans de Goede
Add jack detect support by creating a jack and calling snd_soc_component_set_jack to register the created jack with the codec. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/intel/boards/bytcr_wm5102.c | 28 ++- 1 file changed, 27 insertions

[PATCH v2 04/12] ASoC: arizona-jack: Fix various races on driver unbind

2021-01-17 Thread Hans de Goede
of various theoretically possible races caused by the wrong ordering inside arizona_extcon_remove(), this fixes the ordering fixing all possible races, including the reported oops. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c

[PATCH v2 02/12] ASoC: arizona-jack: Add arizona-jack.c

2021-01-17 Thread Hans de Goede
functions. Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 1816 +++ 1 file changed, 1816 insertions(+) create mode 100644 sound/soc/codecs/arizona-jack.c diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c new file mode

[PATCH v2 07/12] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-01-17 Thread Hans de Goede
k.c functions. Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 42 ++--- sound/soc/codecs/arizona.h | 1 - 2 files changed, 18 insertions(+), 25 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c in

[PATCH v2 05/12] ASoC: arizona-jack: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2021-01-17 Thread Hans de Goede
ked-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c index 76aacbac5869..72d23b15108c 100644 --- a/sound/soc/codecs/arizona-jack.c ++

[PATCH v2 01/12] mfd: arizona: Drop arizona-extcon cells

2021-01-17 Thread Hans de Goede
The arizona jack-dection handling is being reworked so that the codec-child-device drivers directly handle jack-detect themselves, so it is no longer necessary to instantiate "arizona-extcon" child-devices. Signed-off-by: Hans de Goede --- drivers/mfd/arizona-core.c | 20 -

[PATCH v2 06/12] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv

2021-01-17 Thread Hans de Goede
. Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 97 ++--- sound/soc/codecs/arizona.h | 36 2 files changed, 65 insertions(+), 68 deletions(-) diff --git a/sound/soc/codecs/arizona-jack.c b/sound/soc/codecs/arizona-jack.c index

[PATCH v2 00/12] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-01-17 Thread Hans de Goede
Hi All, This series reworks the arizona codec jack-detect support to use the snd_soc_jack helpers instead of direct extcon reporting. This is done by reworking the extcon driver into an arizona-jackdet library and then modifying the codec drivers to use that directly, replacing the old separate

[PATCH v2 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-17 Thread Hans de Goede
Hartmann, combined with insights in things like the speaker GPIO from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1]. [1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel Cc: Christian Hartmann Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede

[PATCH v2 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-01-17 Thread Hans de Goede
. and 2. still have their IPC IRQ at index 0 rather then 5 Add a DMI quirk table to check for the few known models with this issue, so that the right IPC IRQ index is used on these systems. Reviewed-by: Andy Shevchenko Acked-by: Pierre-Louis Bossart Signed-off-by: Hans de Goede --- sound/soc

[PATCH v2 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2021-01-17 Thread Hans de Goede
ine driver and ACPI hooks, the BYT-CR detection quirk which these devices need will be added in a separate patch. BugLink: https://github.com/thesofproject/linux/issues/2485 Co-authored-by: Pierre-Louis Bossart Signed-off-by: Pierre-Louis Bossart Reviewed-by: Andy Shevchenko Signed-off-by: Han

[PATCH v2 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data()

2021-01-17 Thread Hans de Goede
functions (this could happen on e.g. manual driver binding through sysfs). Suggested-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v2: - New patch in v2 of this patchset --- drivers/mfd/arizona-core.c | 11 --- drivers/mfd/arizona-i2c.c | 10 ++ drivers/mfd/arizona

[PATCH v2 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-01-17 Thread Hans de Goede
Hi All, Here is v2 of my series to add support for Intel Bay Trail based devices which use a WM5102 codec for audio output/input. This was developed and tested on a Lenovo Yoga Tablet 1051L. The biggest difference from v1 is that, based on all the discussions about the jack-detect stuff, I've

[PATCH v2 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")

2021-01-17 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/mfd/arizona-i2c.c | 1 + drivers/mfd/arizona-spi.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c index 4b58e3ad6eb6..2a4a3a164d0a 100644 --- a/drivers/mfd/arizona-i2c.c +++ b/drivers/mfd/ari

Re: [PATCH 03/14] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-01-16 Thread Hans de Goede
Hi, Thank you for the review. On 12/28/20 3:14 PM, Andy Shevchenko wrote: > On Sun, Dec 27, 2020 at 11:16 PM Hans de Goede wrote: >> >> The Intel Bay Trail (x86/ACPI) based Lenovo Yoga Tablet 2 series use >> a WM5102 codec connected over SPI. >> >> Add suppor

Re: [PATCH 13/14] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2021-01-16 Thread Hans de Goede
Hi, Thank you for the review. On 12/29/20 2:58 PM, Charles Keepax wrote: > On Sun, Dec 27, 2020 at 10:12:31PM +0100, Hans de Goede wrote: >> From: Pierre-Louis Bossart >> >> Add a new ASoc Machine driver for Intel Baytrail platforms with a >> Wolfson Mi

Re: [PATCH v1 2/2] ACPI: scan: Adjust white space in acpi_device_add()

2021-01-16 Thread Hans de Goede
Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/acpi/scan.c |9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > Index: linux-pm/drivers/acpi/scan.c > =

Re: [PATCH v1 1/2] ACPI: scan: Rearrange memory allocation in acpi_device_add()

2021-01-16 Thread Hans de Goede
_const(acpi_device_hid(device), GFP_KERNEL); if (!acpi_device_bus_id || !bus_id) { kfree(acpi_device_bus_id); kfree(bus_id); result = -ENOMEM; goto err_unlock; } acpi_devic

Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error

2021-01-15 Thread Hans de Goede
Hi All, On 1/14/21 3:50 PM, Kyle Tso wrote: > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyle...@google.com > > "usb: typec: tcpm: AMS and Collision Avoidance" > - removed the signed-off > - modified the coding style suggested from Heikki > - added FR_SWAP AMS handling > > "usb:

Re: [PATCH v5 1/3] usb: typec: tcpm: AMS and Collision Avoidance

2021-01-13 Thread Hans de Goede
Hi, On 1/13/21 3:46 PM, Kyle Tso wrote: > On Wed, Jan 13, 2021 at 2:11 PM Badhri Jagan Sridharan > wrote: >> >> Hi Kyle, >> >> Do you want to handle the FAST_ROLE_SWAP case as well ? >> > I forgot this part > Thanks for catching this. > I will fix it. That sounds like a v6 is upcoming which

Re: [PATCH] genirq: Fix [devm_]irq_alloc_desc returning irq 0

2021-01-13 Thread Hans de Goede
Hi, On 12/21/20 7:56 PM, Hans de Goede wrote: > Since commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 > is invalid"), having a linux-irq with number 0 will trigger a WARN > when calling platform_get_irq*() to retrieve that linux-irq. > > Since [devm

Re: [PATCH fixes v4] platform/x86: ideapad-laptop: Disable touchpad_switch for ELAN0634

2021-01-13 Thread Hans de Goede
Hi, On 1/7/21 3:44 PM, Jiaxun Yang wrote: > Newer ideapads (e.g.: Yoga 14s, 720S 14) come with ELAN0634 touchpad do not > use EC to switch touchpad. > > Reading VPCCMD_R_TOUCHPAD will return zero thus touchpad may be blocked > unexpectedly. > Writing VPCCMD_W_TOUCHPAD may cause a spurious key

Re: [PATCH][next] platform/surface: fix potential integer overflow on shift of a int

2021-01-13 Thread Hans de Goede
Hi, On 1/11/21 3:46 PM, Colin King wrote: > From: Colin Ian King > > The left shift of int 32 bit integer constant 1 is evaluated using 32 bit > arithmetic and then passed as a 64 bit function argument. In the case where > func is 32 or more this can lead to an oveflow. Avoid this by shifting

Re: [GIT PULL] platform-drivers-x86 for 5.11-1

2021-01-13 Thread Hans de Goede
Hi, On 12/16/20 10:21 AM, Hans de Goede wrote: > Hi, > > On 12/16/20 1:17 AM, Linus Torvalds wrote: >> On Mon, Dec 14, 2020 at 4:43 AM Hans de Goede wrote: >>> >>> - New Intel PMT telemetry and crashlog drivers >> >> These have _very_ annoying Kconfi

Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller)

2021-01-13 Thread Hans de Goede
Hi, On 1/12/21 11:30 PM, Pavel Machek wrote: > Hi! > >> Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm (which >> still >> emulates good old piix ATA controllers) I get the below lockdep splat early >> on during boot: >> >> This seems to be led-class related but also

Re: [PATCH v2 0/3] PinePhone volume key (LRADC) wakeup support

2021-01-13 Thread Hans de Goede
ice tree > > Ondrej Jirman (1): > input: sun4i-lradc-keys - Add wakup support > > Samuel Holland (2): > dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property > arm64: dts: allwinner: pinephone: Support volume key wakeup Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede Regards, Hans

5.11 new lockdep warning related to led-class code (also may involve ata / piix controller)

2021-01-12 Thread Hans de Goede
Hi All, Booting a 5.11-rc2 kernel with lockdep enabled inside a virtualbox vm (which still emulates good old piix ATA controllers) I get the below lockdep splat early on during boot: This seems to be led-class related but also seems to have a (P)ATA part to it. To the best of my knowledge this

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-12 Thread Hans de Goede
Hi, I know there already is a v3 out and I will try to get around to reviewing that soon, still 1 remark about the discussion surrounding v2: On 1/11/21 2:42 PM, Perry Yuan wrote: >>> *The flow is like this: >>> 1) User presses key. HW does stuff with this key (timeout is started) >>> 2)

Re: [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error

2021-01-12 Thread Hans de Goede
Hi, On 1/12/21 12:53 PM, Greg KH wrote: > On Wed, Jan 06, 2021 at 12:39:24AM +0800, Kyle Tso wrote: >> This series include previous patch "[v4] AMS and Collision Avoidance" >> https://lore.kernel.org/r/20201217030632.903718-1-kyle...@google.com >> and two more patches "Protocol Error handling"

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirks for DeeQ X5-Z8300

2021-01-11 Thread Hans de Goede
nternal/headset microphones. >> >> Signed-off-by: Chris Chiu > > You probably need to re-send and CC: maintainers (Mark Brown, Takashi Iwai) > and Hans de Goede who's been supporting all those quirks. > > I don't think the changes below are fully correct, m

Re: [PATCH 04/14] mfd: arizona: Allow building arizona MFD-core as module

2021-01-11 Thread Hans de Goede
Hi, First of all thank you for the review and for all your comments (also in the other part of the thread). On 12/29/20 1:00 PM, Charles Keepax wrote: > On Sun, Dec 27, 2020 at 10:12:22PM +0100, Hans de Goede wrote: >> There is no reason why the arizona core,irq and codec model

Re: [PATCH 00/14] MFD/extcon/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-01-11 Thread Hans de Goede
Hi, On 12/28/20 3:19 PM, Andy Shevchenko wrote: > On Sun, Dec 27, 2020 at 11:15 PM Hans de Goede wrote: >> >> Hi All, >> >> This patch series adds support for Intel Bay Trail based device which use >> a WM5102 codec for audio output/input. This was developed and

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-06 Thread Hans de Goede
Hi Perry, On 12/28/20 2:28 PM, Perry Yuan wrote: > From: Perry Yuan > > add support for dell privacy driver for the dell units equipped > hardware privacy design, which protect users privacy > of audio and camera from hardware level. once the audio or camera > privacy mode enabled, any

Re: [PATCH v3 0/9] Add support for Microsoft Surface System Aggregator Module

2021-01-06 Thread Hans de Goede
Hi, On 12/21/20 7:39 PM, Maximilian Luz wrote: > Hello, > > Here is version three of the Surface System Aggregator Module (SAM/SSAM) > driver series, adding initial support for the embedded controller on 5th > and later generation Microsoft Surface devices. Initial support includes > the ACPI

Re: (hid-logitech) Support for non-DJ receivers

2021-01-06 Thread Hans de Goede
Hi Filipe, On 1/6/21 8:07 PM, Filipe LaĆ­ns wrote: > Hey, > > Some of the new Logitech receivers do not have the DJ interface, this creates > an > issue userspace applications like libratbag, as seen in [1], because we can't > identify the device based on the hidraw PID. > > There are two

Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-06 Thread Hans de Goede
Hi, On 1/5/21 6:18 PM, Rafael J. Wysocki wrote: > On Mon, Jan 4, 2021 at 9:58 PM Hans de Goede wrote: >> Patch 1/2 does use a slightly different approach then I suggest above, >> thinking more about this it would be cleaner IMHO to just pass the >> cur_profile poi

Re: [PATCH] thinkpad_acpi: fix: use scnprintf instead of snprintf.

2021-01-06 Thread Hans de Goede
Hi, On 1/6/21 10:01 AM, Joe Perches wrote: > On Wed, 2021-01-06 at 14:36 +0800, YANG LI wrote: >> The snprintf() function returns the number of characters which would >> have been printed if there were enough space, but the scnprintf() >> returns the number of characters which were actually

Re: [PATCH v2 1/2] ACPI: platform-profile: Introduce object pointers to callbacks

2021-01-05 Thread Hans de Goede
Hi, On 1/5/21 2:14 PM, Jiaxun Yang wrote: > Add a object pointer to handler callbacks to avoid having > global variables everywhere. > > Signed-off-by: Jiaxun Yang > Suggested-by: Hans de Goede Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans &

Re: [External] Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-05 Thread Hans de Goede
Hi, On 1/4/21 10:58 PM, Mark Pearson wrote: > On 04/01/2021 15:58, Hans de Goede wrote: >> Hi, >> >> On 1/4/21 9:33 PM, Rafael J. Wysocki wrote: >>> On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede >>> wrote: >>>> >>>> Hi, >>>

Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-04 Thread Hans de Goede
Hi, On 1/4/21 9:33 PM, Rafael J. Wysocki wrote: > On Mon, Jan 4, 2021 at 3:36 PM Hans de Goede wrote: >> >> Hi, >> >> On 1/1/21 1:56 PM, Jiaxun Yang wrote: >>> Tested on Lenovo Yoga-14SARE Chinese Edition. >>> >>> Jiaxun Yang (2): >>>

[PATCH] cfg80211: Fix "suspicious RCU usage in wiphy_apply_custom_regulatory" warning/backtrace

2021-01-04 Thread Hans de Goede
calls, to allow drivers to call wiphy_apply_custom_regulatory more then once if necessary. Cc: Ilan Peer Fixes: beee24695157 ("cfg80211: Save the regulatory domain when setting custom regulator") Signed-off-by: Hans de Goede --- net/wireless/reg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status' set but not used

2021-01-04 Thread Hans de Goede
;): > >drivers/platform/surface/surface3-wmi.c: In function 's3_wmi_query_block': >>> drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status' >>> set but not used [-Wunused-but-set-variable] > 60 | acpi_status status; > |

Re: [PATCH] platform/x86: intel-vbtn: Support for tablet mode on Dell Inspiron 7352

2021-01-04 Thread Hans de Goede
Hi, On 12/26/20 9:53 PM, Arnold Gozum wrote: > The Dell Inspiron 7352 is a 2-in-1 model that has chassis-type "Notebook". > Add this model to the dmi_switches_allow_list. > > Signed-off-by: Arnold Gozum Thank you for your patch, I've applied this patch to my review-hans branch:

Re: [PATCH 0/2] IdeaPad platform profile support

2021-01-04 Thread Hans de Goede
Hi, On 1/1/21 1:56 PM, Jiaxun Yang wrote: > Tested on Lenovo Yoga-14SARE Chinese Edition. > > Jiaxun Yang (2): > ACPI: platform-profile: Introduce data parameter to handler > platform/x86: ideapad-laptop: DYTC Platform profile support > > drivers/acpi/platform_profile.c | 4 +- >

Re: [PATCH 1/2] ACPI: platform-profile: Introduce data parameter to handler

2021-01-04 Thread Hans de Goede
Hi, On 1/1/21 1:56 PM, Jiaxun Yang wrote: > Add a data parameter to handler callbacks to avoid having > global variables everywhere. > > Signed-off-by: Jiaxun Yang Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/acpi/platf

Re: [PATCH] ACPI / scan: Don't create platform device for INT3515 ACPI nodes

2021-01-04 Thread Hans de Goede
Hi, On 1/4/21 1:23 PM, Andy Shevchenko wrote: > On Mon, Jan 04, 2021 at 12:59:39PM +0100, Hans de Goede wrote: >> On 12/23/20 3:36 PM, Heikki Krogerus wrote: >>> There are several reports about the tps6598x causing >>> interrupt flood on boards with the INT3515 ACPI

Re: [PATCH] ACPI / scan: Don't create platform device for INT3515 ACPI nodes

2021-01-04 Thread Hans de Goede
Hi, On 12/23/20 3:36 PM, Heikki Krogerus wrote: > There are several reports about the tps6598x causing > interrupt flood on boards with the INT3515 ACPI node, which > then causes instability. There appears to be several > problems with the interrupt. One problem is that the > I2CSerialBus

Re: tools/power/x86/intel-speed-select: Fixes for regression

2021-01-04 Thread Hans de Goede
Hi, On 1/4/21 12:56 PM, Hans de Goede wrote: > Hi, > > On 12/21/20 8:18 AM, Srinivas Pandruvada wrote: >> One side-effect of fixing the scaling frequency limits using the >> commit eacc9c5a927e ("cpufreq: intel_pstate: Fix intel_pstate_get_hwp_max() >> f

Re: tools/power/x86/intel-speed-select: Fixes for regression

2021-01-04 Thread Hans de Goede
Hi, On 12/21/20 8:18 AM, Srinivas Pandruvada wrote: > One side-effect of fixing the scaling frequency limits using the > commit eacc9c5a927e ("cpufreq: intel_pstate: Fix intel_pstate_get_hwp_max() > for turbo disabled") causes stale HWP_CAP.GUARANTEED to be used as max. > Without processing HWP

Re: [PATCH] platform/surface: SURFACE_PLATFORMS should depend on ACPI

2021-01-04 Thread Hans de Goede
Hi, On 12/16/20 2:37 PM, Geert Uytterhoeven wrote: > All Microsoft Surface platform-specific device drivers depend on ACPI, > but the gatekeeper symbol SURFACE_PLATFORMS does not. Hence when the > user is configuring a kernel without ACPI support, he is still asked > about Microsoft Surface

Re: [PATCH v2 -next] platform: surface: fix non-PM_SLEEP build warnings

2021-01-04 Thread Hans de Goede
> > Fixes: 274335f1c557 ("platform/surface: Add Driver to set up lid GPEs on MS > Surface device") > Signed-off-by: Randy Dunlap > Cc: Maximilian Luz > Cc: Hans de Goede > Cc: platform-driver-...@vger.kernel.org > --- > v2: dropped Maximilian's RVB

Re: [PATCH fixes v3] platform/x86: ideapad-laptop: Disable touchpad_switch for ELAN0634

2021-01-04 Thread Hans de Goede
Hi, On 1/3/21 4:36 AM, Jiaxun Yang wrote: > Newer ideapads (e.g.: Yoga 14s, 720S 14) come with ELAN0634 touchpad do not > use EC to switch touchpad. > > Reading VPCCMD_R_TOUCHPAD will return zero thus touchpad may be blocked > unexpectedly. > Writing VPCCMD_W_TOUCHPAD may cause a spurious key

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2021-01-01 Thread Hans de Goede
Hi, On 12/30/20 2:38 PM, Mark Brown wrote: > On Tue, Dec 29, 2020 at 04:33:09PM +0100, Hans de Goede wrote: >> On 12/29/20 4:08 PM, Mark Brown wrote: >>> The whole purpose of creating sound/core/jack.c is to abstract away the >>> userspace interfaces from the

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-30 Thread Hans de Goede
Hi, On 12/30/20 12:23 PM, Richard Fitzgerald wrote: > On 30/12/2020 11:04, Hans de Goede wrote: >> Hi, >> >> On 12/29/20 5:51 PM, Richard Fitzgerald wrote: >>> >>> >>> On 29/12/2020 15:40, Hans de Goede wrote: >>>> Hi, >>>>

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-30 Thread Hans de Goede
Hi, On 12/29/20 5:51 PM, Richard Fitzgerald wrote: > > > On 29/12/2020 15:40, Hans de Goede wrote: >> Hi, >> >> On 12/29/20 4:15 PM, Mark Brown wrote: >>> On Tue, Dec 29, 2020 at 03:06:35PM +, Charles Keepax wrote: >>> >>>> There i

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Hans de Goede
Hi, On 12/29/20 4:15 PM, Mark Brown wrote: > On Tue, Dec 29, 2020 at 03:06:35PM +, Charles Keepax wrote: > >> There is maybe more argument for porting the Arizona code across >> anyways, since for a long time Android didn't properly support extcon >> either. It supported the earlier out of

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Hans de Goede
Hi, On 12/29/20 4:08 PM, Mark Brown wrote: > On Tue, Dec 29, 2020 at 02:57:38PM +0100, Hans de Goede wrote: >> On 12/29/20 2:06 PM, Charles Keepax wrote: > >>> I would agree with Mark though that if extcon exists for external >>> connectors it seems odd that au

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-29 Thread Hans de Goede
Hi, On 12/29/20 2:06 PM, Charles Keepax wrote: > On Mon, Dec 28, 2020 at 04:28:07PM +, Mark Brown wrote: >> On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote: >> >>> And more in general AFAIK extcon is sort of deprecated and it is >>> not advise

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-28 Thread Hans de Goede
Hi, On 12/28/20 1:21 PM, Mark Brown wrote: > On Sun, Dec 27, 2020 at 10:12:19PM +0100, Hans de Goede wrote: >> The Linux Arizona driver uses the MFD framework to create several >> sub-devices for the Arizona codec and then uses a driver per function. >> >> The jack-det

[PATCH 12/14] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2020-12-27 Thread Hans de Goede
. and 2. still have their IPC IRQ at index 0 rather then 5 Add a DMI quirk table to check for the few known models with this issue, so that the right IPC IRQ index is used on these systems. Signed-off-by: Hans de Goede --- sound/soc/intel/common/soc-intel-quirks.h | 25 +++ 1

[PATCH 09/14] extcon: arizona: Add arizona_set_extcon_state() helper

2020-12-27 Thread Hans de Goede
All the callers of extcon_set_state_sync() log an error on failure, without doing any further error-handling (as there is nothing they can do about the error). Factor this out into a helper to remove some duplicate code. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 47

[PATCH 14/14] ASoC: Intel: bytcr_wm5102: Add jack detect support

2020-12-27 Thread Hans de Goede
this to the extcon-arizona driver through the shared arizona data struct. The extcon-arizona code already depends on (waits for with -EPROBE_DEFER) the snd_card being registered by the machine driver, so this does not cause any ordering issues. Signed-off-by: Hans de Goede --- sound/soc/intel/boards

[PATCH 10/14] extcon: arizona: Also report jack state through snd_soc_jack_report()

2020-12-27 Thread Hans de Goede
the ASoC jack so that jack-detection works with standard Linux userspace. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index

[PATCH 13/14] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2020-12-27 Thread Hans de Goede
ine driver and ACPI hooks, the BYT-CR detection quirk which these devices need will be added in a separate patch. Co-authored-by: Pierre-Louis Bossart Signed-off-by: Pierre-Louis Bossart Signed-off-by: Hans de Goede --- sound/soc/intel/boards/Kconfig| 12 + sound/soc/intel/board

[PATCH 11/14] extcon: arizona: Use ASoC jack input-device when available

2020-12-27 Thread Hans de Goede
me headset. This relies on the machine-driver setting up the jack-input-device to report the EV_KEY key-codes configured in arizona_pdata.micd_ranges, before registering it. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 46 +++-- 1 file changed, 32

[PATCH 05/14] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2020-12-27 Thread Hans de Goede
2 steps when arizona_hpdet_irq runs after the jack has been unplugged. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index aae8

[PATCH 06/14] extcon: arizona: Fix various races on driver unbind

2020-12-27 Thread Hans de Goede
of various theoretically possible races caused by the wrong ordering inside arizona_extcon_remove(), this fixes the ordering fixing all possible races, including the reported oops. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 40 + 1 file changed

[PATCH 08/14] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2020-12-27 Thread Hans de Goede
The initial value of the GPIO should match the info->micd_modes[0].gpio value. arizona_extcon_probe() already stores the necessary flag in a mode variable, but instead of passing mode as flags to the gpiod_get() it was using a hardcoded GPIOD_OUT_LOW. Signed-off-by: Hans de Goede --- driv

[PATCH 07/14] extcon: arizona: Fix modalias

2020-12-27 Thread Hans de Goede
Fix the modalias so that the driver will be loaded automatically. The module's name is "extcon-arizona", following other extcon module-names. But the driver's and platform-device's name is "arizona-extcon" and the modalias must match that. Signed-off-by: Hans de Goede --- d

[PATCH 04/14] mfd: arizona: Allow building arizona MFD-core as module

2020-12-27 Thread Hans de Goede
that the arizona MFD-core can be built as a module. This is especially useful on x86 platforms with a WM5102 codec, this allows the arizona MFD driver necessary for the WM5102 codec to be enabled in generic distro-kernels without growing the base kernel-image size. Signed-off-by: Hans de Goede

[PATCH 03/14] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2020-12-27 Thread Hans de Goede
Hartmann, combined with insights in things like the speaker GPIO from the android-x86 android port for the Lenovo Yoga Tablet 2 1051F/L [1]. [1] https://github.com/Kitsune/Android_Yoga_Tablet_2-1051F_Kernel Cc: Christian Hartmann Signed-off-by: Hans de Goede --- drivers/mfd/arizona-spi.c

[PATCH 02/14] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")

2020-12-27 Thread Hans de Goede
the shared probing code runs. Add a doftdep for this to both modules to ensure that this requirement is met. Note this mirrors the existing MODULE_SOFTDEP("pre: wm8994_regulator") in the wm8994 code, which has a similar init sequence. Signed-off-by: Hans de Goede --- drivers/mfd/arizona

[PATCH 00/14] MFD/extcon/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2020-12-27 Thread Hans de Goede
Hi All, This patch series adds support for Intel Bay Trail based device which use a WM5102 codec for audio output/input. This was developed and tested on a Lenovo Yoga Tablet 1051L. This series consists of 3 parts: 1. Arizona MFD drv patches for ACPI bindings, better jack-detect support and

[PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-27 Thread Hans de Goede
to report jack-detect state, so that jack-detection works with standard Linux userspace. The extcon-arizona code already depends on (waits for with -EPROBE_DEFER) the snd_card being registered by the machine driver, so this does not cause any ordering issues. Signed-off-by: Hans de Goede

[PATCH] genirq: Fix [devm_]irq_alloc_desc returning irq 0

2020-12-21 Thread Hans de Goede
end trace ceece38854223a0b ]--- Change the 'from' parameter passed to __[devm_]irq_alloc_descs() by the [devm_]irq_alloc_desc macros from 0 to 1, so that these macros will no longer return 0. Cc: Bjorn Helgaas Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid") Si

Re: [PATCH v2 3/3] thermal/core: Remove ms based delay fields

2020-12-17 Thread Hans de Goede
Signed-off-by: Daniel Lezcano > Reviewed-by: Lukasz Luba I assume that you will merge this through the thermal tree, here is my ack for doing so for the pdx86 bits: Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/acerhdf.c | 3 ++- >

Re: [PATCH] platform/surface: SURFACE_PLATFORMS should depend on ACPI

2020-12-16 Thread Hans de Goede
soft Surface drivers, even though this question is > irrelevant. > > Fix this by moving the dependency on ACPI from the individual driver > symbols to SURFACE_PLATFORMS. > > Signed-off-by: Geert Uytterhoeven Thanks, patch looks good to me: Reviewed-by: Hans de Goede Maximilian, c

Re: [GIT PULL] platform-drivers-x86 for 5.11-1

2020-12-16 Thread Hans de Goede
Hi, On 12/16/20 1:17 AM, Linus Torvalds wrote: > On Mon, Dec 14, 2020 at 4:43 AM Hans de Goede wrote: >> >> - New Intel PMT telemetry and crashlog drivers > > These have _very_ annoying Kconfig setups. > > First it asks about INTEL_PMT support. > >

Re: [PATCH v2 9/9] platform/surface: Add Surface ACPI Notify driver

2020-12-15 Thread Hans de Goede
re required to provide said > functionality on those devices. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - add copyright lines > - change SPDX identifier to GPL-2.0

Re: [PATCH v2 8/9] platform/surface: Add Surface Aggregator user-space interface

2020-12-15 Thread Hans de Goede
Hi, On 12/3/20 10:26 PM, Maximilian Luz wrote: > Add a misc-device providing user-space access to the Surface Aggregator > EC, mainly intended for debugging, testing, and reverse-engineering. > This interface gives user-space applications the ability to send > requests to the EC and receive the

Re: [PATCH v2 7/9] docs: driver-api: Add Surface Aggregator subsystem documentation

2020-12-15 Thread Hans de Goede
> > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - change SPDX identifier to GPL-2.0+ (was GPL-2.0-or-later) > - fix typos > > Changes in v2: > - add archit

Re: [PATCH v2 6/9] platform/surface: aggregator: Add dedicated bus and device type

2020-12-15 Thread Hans de Goede
need to manually establish device links for that purpose > in the client driver (as has to be done with the platform devices). > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): &g

Re: [PATCH v2 6/9] platform/surface: aggregator: Add dedicated bus and device type

2020-12-15 Thread Hans de Goede
need to manually establish device links for that purpose > in the client driver (as has to be done with the platform devices). > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): &g

Re: [PATCH v2 5/9] platform/surface: aggregator: Add error injection capabilities

2020-12-15 Thread Hans de Goede
ebugging of > the Surface Aggregator communication layer. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - remove unnecessary default in Kconfig entry > > Cha

Re: [PATCH v2 4/9] platform/surface: aggregator: Add trace points

2020-12-15 Thread Hans de Goede
th the error injection capabilities introduced in the > subsequent commit. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > Changes in v1 (from RFC): > - add copyright line > - change SPDX

Re: [PATCH v2 3/9] platform/surface: aggregator: Add event item allocation caching

2020-12-15 Thread Hans de Goede
ost other event types. In case of a larger event payload, event item > allocation will fall back to kzalloc(). > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > .../platform/surface/aggregator/controller.c |

Re: [PATCH v2 2/9] platform/surface: aggregator: Add control packet allocation caching

2020-12-15 Thread Hans de Goede
nses) that it may > warrant caching their allocations to reduce possible memory > fragmentation. > > Signed-off-by: Maximilian Luz Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/surface/aggregator/core.c| 27 ++-

Re: [PATCH v5 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-15 Thread Hans de Goede
t; systems") > Reviewed-by: Alexander Duyck > Signed-off-by: Mario Limonciello Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 45 +- > 1 file changed, 2 insertions(+), 43 del

<    1   2   3   4   5   6   7   8   9   10   >