Re: [net-next PATCH 0/8] configuration support for switch headers & phy

2021-03-31 Thread Hariprasad Kelam
> -Original Message- > From: Andrew Lunn > Sent: Sunday, March 28, 2021 11:17 PM > To: Sunil Kovvuri > Cc: Hariprasad Kelam ; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; k...@kernel.org; da...@davemloft.net; > Sunil Kovvuri Goutham ; Linu Cherian >

Re: [net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to control PAM4 on/off

2021-03-23 Thread Hariprasad Kelam
Hi Andrew, Please see inline, > -Original Message- > From: Andrew Lunn > Sent: Sunday, March 21, 2021 7:58 PM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; k...@kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutha

Re: [net-next PATCH 0/8] configuration support for switch headers & phy

2021-03-23 Thread Hariprasad Kelam
Hi Andrew , Please see inline, > -Original Message- > From: Andrew Lunn > Sent: Sunday, March 21, 2021 7:45 PM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; k...@kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutha

[net-next PATCH 8/8] octeontx2-pf: Add ntuple filter support for FDSA

2021-03-21 Thread Hariprasad Kelam
flow-type ether user-def 0x1e To send traffic with vlan id 30 to PF ethtool -U eth0 flow-type ether dst xx vlan 30 m 0xf000 To send traffic with Srcport 20 to vf 0 ethtool -U eth0 flow-type ether vf 0 user-def 0x14 Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Goutham

[net-next PATCH 7/8] octeontx2-af: Add flow steering support for FDSA tag

2021-03-21 Thread Hariprasad Kelam
features .Rx vtag Type 6 is reserved to strip FDSA tag. Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 1 + drivers/net/ethernet/marvell/octeontx2/af/npc.h| 8 drivers/net/ethernet/marvell/octeontx2/af/rvu.h

[net-next PATCH 5/8] octeontx2-af: Put CGX LMAC also in Higig2 mode

2021-03-21 Thread Hariprasad Kelam
such that when user enables higig2, 802.3 pause frames are disabled and higig2 pause frames are enabled vice versa. Other changes - CGX HW doesn't support timestamping when in Higig2 mode, so made PTP and Higig2 settings mutually exclusive. Signed-off-by: Hariprasad Kelam Signed-off

[net-next PATCH 4/8] octeontx2-af: Do not allow VFs to overwrite PKIND config

2021-03-21 Thread Hariprasad Kelam
to ensure the same. Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Goutham --- .../net/ethernet/marvell/octeontx2/af/cgx.c | 12 +++ .../net/ethernet/marvell/octeontx2/af/cgx.h | 1 + .../net/ethernet/marvell/octeontx2/af/rvu.h | 1 + .../ethernet/marvell/octeontx2/af/rvu_cgx.c

[net-next PATCH 6/8] octeontx2-pf: Support to enable EDSA/Higig2 pkts parsing

2021-03-21 Thread Hariprasad Kelam
these PKINDs into hardware for proper pkt parsing. Patch also handles changes to max frame size due to additional headers in pkt. higig2: ethtool --set-priv-flags eth0 higig2 on/off edsa: ethtool --set-priv-flags eth0 edsa on/off Signed-off-by: Hariprasad Kelam Signed-off

[net-next PATCH 3/8] octeontx2-af: Support for parsing pkts with switch headers

2021-03-21 Thread Hariprasad Kelam
a separate Pkind is chosen on Rx and/or Tx sides to tell to KPU to parse the pkts accordingly. Signed-off-by: Hariprasad Kelam Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham --- .../net/ethernet/marvell/octeontx2/af/mbox.h | 14 + .../net/ethernet/marvell/octeontx2/af/npc.h | 6

[net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to control PAM4 on/off

2021-03-21 Thread Hariprasad Kelam
Manlunas Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Goutham --- .../marvell/octeontx2/nic/otx2_ethtool.c | 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic

[net-next PATCH 1/8] octeontx2-af: Add new CGX_CMDs to set and get PHY modulation type

2021-03-21 Thread Hariprasad Kelam
From: Felix Manlunas Implement commands to set and get PHY line-side modulation type (NRZ or PAM4) from firmware. Signed-off-by: Felix Manlunas Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Goutham --- .../net/ethernet/marvell/octeontx2/af/cgx.c | 29 + .../net

[net-next PATCH 0/8] configuration support for switch headers & phy

2021-03-21 Thread Hariprasad Kelam
on/off Hariprasad Kelam (6): octeontx2-af: Support for parsing pkts with switch headers octeontx2-af: Do not allow VFs to overwrite PKIND config octeontx2-af: Put CGX LMAC also in Higig2 mode octeontx2-pf: Support to enable EDSA/Higig2 pkts parsing octeontx2-af: Add flow steering support

[net PATCH v2 8/8] octeontx2-af: Fix uninitialized variable warning

2021-03-18 Thread Hariprasad Kelam
From: Subbaraya Sundeep Initialize l4_key_offset variable to fix uninitialized variable compiler warning. Fixes: b9b7421a01d8 ("octeontx2-af: Support ESP/AH RSS hashing") Signed-off-by: Subbaraya Sundeep Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- d

[net PATCH v2 7/8] octeontx2-af: fix infinite loop in unmapping NPC counter

2021-03-18 Thread Hariprasad Kelam
mbox message is processed by AF driver after that. Fix this by updating entry value before checking next mcam entry. Fixes: a958dd59f9ce ("octeontx2-af: Map or unmap NPC MCAM entry and counter") Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethern

[net PATCH v2 6/8] octeontx2-pf: Clear RSS enable flag on interace down

2021-03-18 Thread Hariprasad Kelam
/get RSS configuration. Fixes: 85069e95e531 ("octeontx2-pf: Receive side scaling support") Signed-off-by: Geetha sowjanya Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 5 + 1 file changed, 5 insertion

[net PATCH v2 4/8] octeontx2-af: Return correct CGX RX fifo size

2021-03-18 Thread Hariprasad Kelam
ation") Signed-off-by: Subbaraya Sundeep Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- .../net/ethernet/marvell/octeontx2/af/rvu.h| 1 + .../ethernet/marvell/octeontx2/af/rvu_cgx.c| 18 -- .../marvell/octeontx2/af/rvu_debugfs.c | 9 ++

[net PATCH v2 5/8] octeontx2-af: Fix irq free in rvu teardown

2021-03-18 Thread Hariprasad Kelam
: Add mailbox IRQ and msg handlers") Signed-off-by: Geetha sowjanya Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell

[net PATCH v2 3/8] octeontx2-af: Remove TOS field from MKEX TX

2021-03-18 Thread Hariprasad Kelam
en TX rule is installed with DMAC as match criteria since DMAC gets overwritten and cannot be supported. This patch fixes the issue by removing TOS field from MKEX TX profile. Fixes: 42006910b5ea ("octeontx2-af: cleanup KPU config data") Signed-off-by: Subbaraya Sundeep Signed-off-by: Haripras

[net PATCH v2 0/8] octeontx2: miscellaneous fixes

2021-03-18 Thread Hariprasad Kelam
- remove code improvement patch - make commit description more clear Geetha sowjanya (2): octeontx2-af: Fix irq free in rvu teardown octeontx2-pf: Clear RSS enable flag on interace down Hariprasad Kelam (1): octeontx2-af: fix infinite loop in unmapping NPC counter Rakesh Babu

[net PATCH v2 2/8] octeontx2-af: Formatting debugfs entry rsrc_alloc.

2021-03-18 Thread Hariprasad Kelam
0 0 Fixes: 23205e6d06d4 ("octeontx2-af: Dump current resource provisioning status") Signed-off-by: Rakesh Babu Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- .../marvell/octeontx2/af/rvu_debugfs.c| 46 --- 1 file c

[net PATCH v2 1/8] octeontx2-pf: Do not modify number of rules

2021-03-18 Thread Hariprasad Kelam
rule_cnt member. But currently driver modifies it by modifying rss_context. Hence fix it by using a local variable. Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") Signed-off-by: Subbaraya Sundeep Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- d

[net PATCH 9/9] octeontx2-af: Fix uninitialized variable warning

2021-03-16 Thread Hariprasad Kelam
From: Subbaraya Sundeep Initialize l4_key_offset variable to fix uninitialized variable compiler warning. Fixes: b9b7421("octeontx2-af: Support ESP/AH RSS hashing") Signed-off-by: Subbaraya Sundeep Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/ne

[net PATCH 8/9] octeontx2-af: fix infinite loop in unmapping counter

2021-03-16 Thread Hariprasad Kelam
Current code does not break from loop due to entry value miscalculation. Hence correct the same. Fixes: a958dd59("octeontx2-af: Map or unmap NPC MCAM entry and counter") Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethernet/marvell/octeontx2/af

[net PATCH 7/9] octeontx2-pf: Clear RSS enable flag on interace down

2021-03-16 Thread Hariprasad Kelam
/get RSS configuration. Fixes: 85069e95e("octeontx2-pf: Receive side scaling support") Signed-off-by: Geetha sowjanya Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 5 + 1 file changed, 5 insertion

[net PATCH 6/9] octeontx2-af: Fix irq free in rvu teardown

2021-03-16 Thread Hariprasad Kelam
: Add mailbox IRQ and msg handlers") Signed-off-by: Geetha sowjanya Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/oc

[net PATCH 5/9] octeontx2-af: Return correct CGX RX fifo size

2021-03-16 Thread Hariprasad Kelam
t;) Signed-off-by: Subbaraya Sundeep Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethernet/marvell/octeontx2/af/rvu.h| 1 + drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c| 18 -- .../net/ethernet/marvell/octeontx2/af/rvu

[net PATCH 3/9] octeontx2-af: Do not allocate memory for devlink private

2021-03-16 Thread Hariprasad Kelam
ya Sundeep Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c b/drivers/net/ethern

[net PATCH 4/9] octeontx2-af: Remove TOS field from MKEX TX

2021-03-16 Thread Hariprasad Kelam
From: Subbaraya Sundeep TOS overlaps with DMAC field in mcam search key and hence installing rules for TX side are failing. Hence remove TOS field from TX profile. Fixes: 42006910("octeontx2-af: cleanup KPU config data") Signed-off-by: Subbaraya Sundeep Signed-off-by: Hariprasad Kel

[net PATCH 1/9] octeontx2-pf: Do not modify number of rules

2021-03-16 Thread Hariprasad Kelam
rule_cnt member. But currently driver modifies it by modifying rss_context. Hence fix it by using a local variable. Fixes: 81a43620("octeontx2-pf: Add RSS multi group support") Signed-off-by: Subbaraya Sundeep Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- d

[net PATCH 2/9] octeontx2-af: Formatting debugfs entry rsrc_alloc.

2021-03-16 Thread Hariprasad Kelam
0 0 Fixes: 23205e6d("octeontx2-af: Dump current resource provisioning status") Signed-off-by: Rakesh Babu Signed-off-by: Hariprasad Kelam Signed-off-by: Sunil Kovvuri Goutham --- .../ethernet/marvell/octeontx2/af/rvu_debugfs.c| 46 ++ 1 file c

[net PATCH 0/9] octeontx2: miscellaneous fixes

2021-03-16 Thread Hariprasad Kelam
This series of patches fixes various issues related to NPC MCAM entry management, debugfs, devlink, CGX LMAC mapping, RSS config etc Geetha sowjanya (2): octeontx2-af: Fix irq free in rvu teardown octeontx2-pf: Clear RSS enable flag on interace down Hariprasad Kelam (1): octeontx2-af: fix

[PATCH v2][next] octeontx2-pf: Fix out-of-bounds read warning in otx2_get_fecparam()

2021-02-12 Thread Hariprasad Kelam
Looks good to me. Thanks, Hariprasad k > -Original Message- > From: Gustavo A. R. Silva > Sent: Friday, February 12, 2021 8:36 PM > To: Sunil Kovvuri Goutham ; Geethasowjanya > Akula ; Subbaraya Sundeep Bhatta > ; Hariprasad Kelam ; David > S. Miller ; J

[PATCH][next] octeontx2-pf: Fix out-of-bounds read in otx2_get_fecparam()

2021-02-12 Thread Hariprasad Kelam
Hi Gustavo , Please see inline, > -Original Message- > From: Gustavo A. R. Silva > Sent: Friday, February 12, 2021 5:53 PM > To: Sunil Kovvuri Goutham ; Geethasowjanya > Akula ; Subbaraya Sundeep Bhatta > ; Hariprasad Kelam ; David > S. Miller ; Jakub Kicinski

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

2021-02-10 Thread Hariprasad Kelam
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Tuesday, February 9, 2021 11:56 PM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; willemdebruijn.ker...@gmail.com; > and...@lunn.ch; Sunil K

[Patch v4 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-02-09 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam

[Patch v4 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-09 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet

[Patch v4 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-02-09 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg --- .../ethernet/marvell/octeontx2/nic/otx2_common.c | 20 +++ .../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 + .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 160

[Patch v4 net-next 0/7] ethtool support for fec and link configuration

2021-02-09 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

[Patch v4 net-next 1/7] octeontx2-af: forward error correction configuration

2021-02-09 Thread Hariprasad Kelam
timeout to accomdate firmware command response timeout. Along with new CGX_CMD_SET_FEC command add other commands to sync with kernel enum list with firmware. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg --- drivers

[Patch v4 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-02-09 Thread Hariprasad Kelam
: Speed: 10Mb/s Duplex: Full Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 158 + 1 file changed, 158 insertions(+) diff

[Patch v4 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-02-09 Thread Hariprasad Kelam
and CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync with firmware's enum list. Signed-off-by: Felix Manlunas Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/marvell/octeontx2/af

[Patch v4 net-next 4/7] octeontx2-af: Physical link configuration support

2021-02-09 Thread Hariprasad Kelam
and read these parameters. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 58 +- drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 + .../net

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-07 Thread Hariprasad Kelam
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Saturday, February 6, 2021 12:56 AM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; willemdebruijn.ker...@gmail.com; > and...@lunn.ch; Sunil K

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-05 Thread Hariprasad Kelam
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Friday, February 5, 2021 12:21 AM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; willemdebruijn.ker...@gmail.com; > and...@lunn.ch; Sunil K

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-04 Thread Hariprasad Kelam
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Wednesday, February 3, 2021 6:59 AM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; willemdebruijn.ker...@gmail.com; > and...@lunn.ch; Sunil K

Re: [Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-02-04 Thread Hariprasad Kelam
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Wednesday, February 3, 2021 6:54 AM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; willemdebruijn.ker...@gmail.com; > and...@lunn.ch; Sunil K

Re: [Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-02-04 Thread Hariprasad Kelam
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Wednesday, February 3, 2021 6:42 AM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; willemdebruijn.ker...@gmail.com; > and...@lunn.ch; Sunil K

[Patch v3 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam

[Patch v3 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-31 Thread Hariprasad Kelam
and read these parameters. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 58 +- drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 + .../net/ethernet/marvell/octeontx2/af

[Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-01-31 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

[Patch v3 net-next 1/7] octeontx2-af: forward error correction configuration

2021-01-31 Thread Hariprasad Kelam
timeout to accomdate firmware command response timeout. Along with new CGX_CMD_SET_FEC command add other commands to sync with kernel enum list with firmware. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2

[Patch v3 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-31 Thread Hariprasad Kelam
and CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync with firmware's enum list. Signed-off-by: Felix Manlunas Signed-off-by: Christina Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 12

[Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-01-31 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_common.c | 20 +++ .../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 + .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 181 - .../net/ethernet/marvell/octeontx2

[Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-01-31 Thread Hariprasad Kelam
: Speed: 10Mb/s Duplex: Full Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 151 + 1 file changed, 151 insertions(+) diff --git a/drivers/net/ethernet

[Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-01-31 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic

[Patch v3 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam

[Patch v3 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-31 Thread Hariprasad Kelam
and read these parameters. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 58 +- drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 + .../net/ethernet/marvell/octeontx2/af

[Patch v3 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-31 Thread Hariprasad Kelam
and CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync with firmware's enum list. Signed-off-by: Felix Manlunas Signed-off-by: Christina Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 12

[Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-01-31 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic

[Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-01-31 Thread Hariprasad Kelam
: Speed: 10Mb/s Duplex: Full Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 151 + 1 file changed, 151 insertions(+) diff --git a/drivers/net/ethernet

[Patch v3 net-next 1/7] octeontx2-af: forward error correction configuration

2021-01-31 Thread Hariprasad Kelam
timeout to accomdate firmware command response timeout. Along with new CGX_CMD_SET_FEC command add other commands to sync with kernel enum list with firmware. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2

[Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-01-31 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_common.c | 20 +++ .../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 + .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 181 - .../net/ethernet/marvell/octeontx2

[Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-01-31 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

Re: [Patch v2 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-30 Thread Hariprasad Kelam
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Saturday, January 30, 2021 7:57 PM > To: Hariprasad Kelam > Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub > Kicinski ; Sunil Kovvuri Goutham > ; Linu Cherian ; > G

Re: [Patch v2 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-01-30 Thread Hariprasad Kelam
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Thursday, January 28, 2021 2:01 AM > To: Hariprasad Kelam > Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub > Kicinski ; Sunil Kovvuri Goutham > ; Linu Cherian ; > G

Re: [Patch v2 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-30 Thread Hariprasad Kelam
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Thursday, January 28, 2021 2:04 AM > To: Hariprasad Kelam > Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub > Kicinski ; Sunil Kovvuri Goutham > ; Linu Cherian

Re: [Patch v2 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-30 Thread Hariprasad Kelam
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Thursday, January 28, 2021 1:50 AM > To: Hariprasad Kelam > Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub > Kicinski ; Sunil Kovvuri Goutham > ; Linu Cherian ; > G

Re: [Patch v2 net-next 1/7] octeontx2-af: forward error correction configuration

2021-01-30 Thread Hariprasad Kelam
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Thursday, January 28, 2021 1:45 AM > To: Hariprasad Kelam > Cc: Network Development ; LKML ker...@vger.kernel.org>; David Miller ; Jakub > Kicinski ; Sunil Kovvuri Goutham > ; Linu Cherian ; > G

Re: [Patch v2 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-01-30 Thread Hariprasad Kelam
Hi Andrew Lunn, > -Original Message- > From: Andrew Lunn > Sent: Wednesday, January 27, 2021 7:22 PM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; k...@kernel.org; Sunil Kovvuri Goutham > ; Linu Cheri

Re: [Patch v2 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-30 Thread Hariprasad Kelam
Hi Andrew Lunn, > -Original Message- > From: Andrew Lunn > Sent: Wednesday, January 27, 2021 6:56 PM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; k...@kernel.org; Sunil Kovvuri Goutham > ; Linu Cheri

[Patch v2 net-next 1/7] octeontx2-af: forward error correction configuration

2021-01-27 Thread Hariprasad Kelam
timeout to accomdate firmware command response timeout. Along with new CGX_CMD_SET_FEC command add other commands to sync with kernel enum list with firmware. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2

[Patch v2 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-01-26 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_common.c | 23 +++ .../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 + .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 181 - .../net/ethernet/marvell/octeontx2

[Patch v2 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-26 Thread Hariprasad Kelam
and CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync with firmware's enum list. Signed-off-by: Felix Manlunas Signed-off-by: Christina Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 12

[Patch v2 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-01-26 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic

[Patch v2 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-01-26 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam

[Patch v2 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-01-26 Thread Hariprasad Kelam
: Speed: 10Mb/s Duplex: Full Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 159 + 1 file changed, 159 insertions(+) diff --git a/drivers/net/ethernet

[Patch v2 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-26 Thread Hariprasad Kelam
and read these parameters. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 60 +- drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 + .../net/ethernet/marvell/octeontx2/af

[Patch v2 net-next 0/7] ethtool support for fec and link configuration

2021-01-26 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

RE: [EXT] Re: [net-next PATCH 3/7] octeontx2-pf: ethtool fec mode support

2021-01-24 Thread Hariprasad Kelam
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Saturday, January 23, 2021 10:00 AM > To: Hariprasad Kelam > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutham ; > Linu Cherian ; Geethasowjanya

[net-next PATCH 1/7] octeontx2-af: forward error correction configuration

2021-01-21 Thread Hariprasad Kelam
timeout to accomdate firmware command response timeout. Along with new CGX_CMD_SET_FEC command add other commands to sync with kernel enum list with firmware. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2

[net-next PATCH 4/7] octeontx2-af: Physical link configuration support

2021-01-21 Thread Hariprasad Kelam
and read these parameters. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 60 +- drivers/net/ethernet/marvell/octeontx2/af/cgx.h| 2 + .../net/ethernet/marvell/octeontx2/af

[net-next PATCH 6/7] octeontx2-pf: ethtool physical link status

2021-01-21 Thread Hariprasad Kelam
: Speed: 10Mb/s Duplex: Full Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 157 + 1 file changed, 157 insertions(+) diff --git a/drivers/net/ethernet

[net-next PATCH 3/7] octeontx2-pf: ethtool fec mode support

2021-01-21 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_common.c | 23 +++ .../ethernet/marvell/octeontx2/nic/otx2_common.h | 6 + .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 174 - .../net/ethernet/marvell/octeontx2

[net-next PATCH 7/7] octeontx2-pf: ethtool physical link configuration

2021-01-21 Thread Hariprasad Kelam
-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam --- .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic

[net-next PATCH 5/7] octeontx2-af: advertised link modes support on cgx

2021-01-21 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam

[net-next PATCH 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-21 Thread Hariprasad Kelam
and CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync with firmware's enum list. Signed-off-by: Felix Manlunas Signed-off-by: Christina Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Hariprasad Kelam --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c| 12

[net-next PATCH 0/7] ethtool support for fec and link configuration

2021-01-20 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

[PATCH] staging: rtl8723bs: core: Remove unneeded declaration WFD_OUI

2019-08-19 Thread Hariprasad Kelam
Remove unneeded declaration "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 02f547

[PATCH] staging: rtl8192u: Add NULL check post kzalloc

2019-08-03 Thread Hariprasad Kelam
Collect returns status of kzalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index fe1f279..3240442

[Patch v2] staging: rtl8192e: Make use kmemdup

2019-08-03 Thread Hariprasad Kelam
As kmemdup API does kmalloc + memcpy . We can make use of it instead of calling kmalloc and memcpy independetly. Signed-off-by: Hariprasad Kelam --- v2 - remove the netdev_info() uses for allocation failures drivers/staging/rtl8192e/rtllib_softmac.c | 24 +++- 1 file

Re: [PATCH] staging: rtl8192e: Make use kmemdup

2019-08-03 Thread Hariprasad Kelam
On Sat, Aug 03, 2019 at 10:52:04AM -0700, Joe Perches wrote: > On Sat, 2019-08-03 at 23:10 +0530, Hariprasad Kelam wrote: > > As kmemdup API does kmalloc + memcpy . We can make use of it instead of > > calling kmalloc and memcpy independetly. > [] > > diff --git a/

[PATCH] staging: rtl8192e: Make use kmemdup

2019-08-03 Thread Hariprasad Kelam
As kmemdup API does kmalloc + memcpy . We can make use of it instead of calling kmalloc and memcpy independetly. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192e/rtllib_softmac.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[Patch v2 10/10] staging: rtl8723bs: core: Remove Macro "IS_MAC_ADDRESS_BROADCAST"

2019-07-31 Thread Hariprasad Kelam
Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use it ,use generic API "is_broadcast_ether_addr" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[Patch v2 09/10] staging: rtl8723bs: core: Remove unneeded variables sgi_20m,sgi_40m and sgi_80m

2019-07-31 Thread Hariprasad Kelam
htpriv.sgi_* variables are of type u8 ,instead of storing them in local variables ,its better to read value directly from structure. Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 --- 1 file changed, 4 insertions(+), 7

[Patch v2 08/10] staging: rtl8723bs: core: Remove unneeded extern WFD_OUI

2019-07-31 Thread Hariprasad Kelam
Remove unneeded extern variable "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/cor

[Patch v2 07/10] staging: rtl8723bs: Remove unneeded function argument for init_addba_retry_timer

2019-07-31 Thread Hariprasad Kelam
init_addba_retry_timer does not use padapter, so only keep psta Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/os_dep/mlme_linux.c| 2 +- 3

[Patch v2 06/10] staging: rtl8723bs: os_dep: Remove unused defines related to combo scan

2019-07-31 Thread Hariprasad Kelam
Remove below defines WEXT_CSCAN_AMOUNT WEXT_CSCAN_BUF_LEN WEXT_CSCAN_NPROBE_SECTION Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b

[Patch v2 05/10] staging: rtl8723bs: os_dep: Remove unused defines

2019-07-31 Thread Hariprasad Kelam
Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[Patch v2 04/10] staging: rtl8723bs: hal: Remove function argument padapter

2019-07-31 Thread Hariprasad Kelam
Remove function argument "padapter" in rtl8723bs_init_recv_priv function as its not being used Signed-off-by: Hariprasad Kelam --- v4 - Add patch number drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++-- drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +- drivers/staging

[Patch v2 03/10] staging: rtl8723bs: os_dep: Remove unused function argument sdio_device_id

2019-07-31 Thread Hariprasad Kelam
Remove passing pdid as function argument to rtw_sdio_if1_init as it is not being used Signed-off-by: Hariprasad Kelam --- v3 - Add patch number drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

  1   2   3   4   >