Re: [PATCH 2/4] Bluetooth: hci_qca: Don't vote for specific voltage

2019-10-20 Thread Harish Bandi
+ Bala On 2019-10-18 23:52, Matthias Kaehlcke wrote: On Thu, Oct 17, 2019 at 10:24:02PM -0700, Bjorn Andersson wrote: Devices with specific voltage requirements should not request voltage from the driver, but instead rely on the system configuration to define appropriate voltages for each rai

Re: [PATCH 3/4] Bluetooth: hci_qca: Use regulator bulk enable/disable

2019-10-18 Thread Harish Bandi
On 2019-10-18 10:54, Bjorn Andersson wrote: With the regulator_set_load() and regulator_set_voltage() out of the enable/disable code paths the code can now use the standard regulator bulk enable/disable API. By cloning num_vregs into struct qca_power there's no need to lug around a reference t

Re: [PATCH 4/4] Bluetooth: hci_qca: Split qca_power_setup()

2019-10-18 Thread Harish Bandi
On 2019-10-18 10:54, Bjorn Andersson wrote: Split and rename qca_power_setup() in order to simplify each code path and to clarify that it is unrelated to qca_power_off() and qca_power_setup(). Signed-off-by: Bjorn Andersson --- drivers/bluetooth/hci_qca.c | 61 ++---

Re: [PATCH 1/4] Bluetooth: hci_qca: Update regulator_set_load() usage

2019-10-18 Thread Harish Bandi
On 2019-10-18 10:54, Bjorn Andersson wrote: Since the introduction of '5451781dadf8 ("regulator: core: Only count load for enabled consumers")' in v5.0, the requested load of a regulator consumer is only accounted for when said consumer is voted enabled. So there's no need to vote for load eve

Re: [PATCH 2/4] Bluetooth: hci_qca: Don't vote for specific voltage

2019-10-18 Thread Harish Bandi
On 2019-10-18 10:54, Bjorn Andersson wrote: Devices with specific voltage requirements should not request voltage from the driver, but instead rely on the system configuration to define appropriate voltages for each rail. This ensures that PMIC and board variations are accounted for, something

Re: [PATCH 0/4] Bluetooth: hci_qca: Regulator usage cleanup

2019-10-18 Thread Harish Bandi
On 2019-10-18 10:54, Bjorn Andersson wrote: Clean up the regulator usage in hci_qca and in particular don't regulator_set_voltage() for fixed voltages. It cleans up the driver, but more important it makes bluetooth work on my Lenovo Yoga C630, where the regulator for vddch0 is defined with a vo

Re: [PATCH] Bluetooth: hci_qca: fix in-band sleep enablement

2019-10-11 Thread Harish Bandi
++ Balakrishna On 2019-10-09 14:21, Claire Chang wrote: Enabling in-band sleep when there is no patch/nvm-config found and bluetooth is running with the original fw/config. Fixes: ba8f35979002 ("Bluetooth: hci_qca: Avoid setup failure on missing rampatch") Fixes: 7dc5fe0814c3 ("Bluetooth: hci_q

[PATCH v1] bluetooth: hci_qca: disable irqs when spinlock is acquired

2019-09-03 Thread Harish Bandi
Looks like Deadlock is observed in hci_qca while performing stress and stability tests. Since same lock is getting acquired from qca_wq_awake_rx and hci_ibs_tx_idle_timeout seeing spinlock recursion, irqs should be disable while acquiring the spinlock always. Signed-off-by: Harish Bandi

[PATCH v3] Bluetooth: hci_qca: wait for Pre shutdown complete event before sending the Power off pulse

2019-08-30 Thread Harish Bandi
From: Harish Bandi When SoC receives pre shut down command, it share the same with other COEX shared clients. So SoC needs a short time after sending VS pre shutdown command before turning off the regulators and sending the power off pulse. Along with short delay, needs to wait for command

[PATCH v2] Bluetooth: hci_qca: wait for Pre shutdown complete event before sending the Power off pulse

2019-08-30 Thread Harish Bandi
shutdown VS command Signed-off-by: Harish Bandi Reviewed-by: Balakrishna Godavarthi --- Changes in V2: - Modified commit text. --- drivers/bluetooth/btqca.c | 22 ++ drivers/bluetooth/hci_qca.c | 5 + 2 files changed, 27 insertions(+) diff --git a/drivers/bluetooth

[PATCH v2] Bluetooth: hci_qca: wait for Pre shutdown complete event before sending the Power off pulse

2019-08-29 Thread Harish Bandi
shutdown VS command Signed-off-by: Harish Bandi Reviewed-by: Balakrishna Godavarthi --- Changes in V2: - Modified commit text. --- drivers/bluetooth/btqca.c | 22 ++ drivers/bluetooth/hci_qca.c | 5 + 2 files changed, 27 insertions(+) diff --git a/drivers/bluetooth

Re: [PATCH v1] Bluetooth: hci_qca: wait for Pre shutdown to command complete event before sending the Power off pulse

2019-08-08 Thread Harish Bandi
Hi Matthias, On 2019-08-08 20:29, Matthias Kaehlcke wrote: On Thu, Aug 08, 2019 at 02:55:53PM +0530, Harish Bandi wrote: When SoC receives pre shut down command, it share the same with other COEX shared clients. So SoC needs a short time after sending VS pre shutdown command before turning off

Re: [PATCH v1] Bluetooth: hci_qca: wait for Pre shutdown to command complete event before sending the Power off pulse

2019-08-08 Thread Harish Bandi
Hi Bala, On 2019-08-08 16:25, Balakrishna Godavarthi wrote: Hi Harish, On 2019-08-08 14:55, Harish Bandi wrote: When SoC receives pre shut down command, it share the same with other COEX shared clients. So SoC needs a short time after sending VS pre shutdown command before turning off the

[PATCH v1] Bluetooth: hci_qca: wait for Pre shutdown to command complete event before sending the Power off pulse

2019-08-08 Thread Harish Bandi
When SoC receives pre shut down command, it share the same with other COEX shared clients. So SoC needs a short time after sending VS pre shutdown command before turning off the regulators and sending the power off pulse. Signed-off-by: Harish Bandi --- drivers/bluetooth/btqca.c | 5

[PATCH v1] Bluetooth: hci_qca: Send VS pre shutdown command.

2019-07-11 Thread Harish Bandi
WCN399x chips are coex chips, it needs a VS pre shutdown command while turning off the BT. So that chip can inform BT is OFF to other active clients. Signed-off-by: Harish Bandi --- drivers/bluetooth/btqca.c | 21 + drivers/bluetooth/btqca.h | 7 +++ drivers

Re: [PATCH v6 1/2] Bluetooth: hci_qca: Load customized NVM based on the device property

2019-06-06 Thread Harish Bandi
a->soc_type)) { qcadev->btsoc_type = data->soc_type; qcadev->bt_power = devm_kzalloc(&serdev->dev, Tested for WCN3998. Tested-by: Harish Bandi Thanks, Harish

[PATCH v8 0/2] Enable Bluetooth functionality for WCN3998.

2019-04-26 Thread Harish Bandi
in V4: Added is_qca_soc_type_wcn399x_family helper function to get the soc type is wcn399x or not. Changes in V3: updated to latest code base. Harish Bandi (2): Bluetooth: hci_qca: Added support for WCN3998 dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

[PATCH v8 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-04-26 Thread Harish Bandi
Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi Reviewed-by: Matthias Kaehlcke Reviewed-by: Balakrishna Godavarthi --- Changes in V8: - Removed export of qca_is_wcn399x() and

[PATCH v8 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-04-26 Thread Harish Bandi
Add compatible string for the Qualcomm WCN3998 Bluetooth controller Signed-off-by: Harish Bandi Reviewed-by: Rob Herring --- Changes in V7: - Added robh reviewed by tag in commit text --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH v7 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-04-25 Thread Harish Bandi
Hi Marcel, On 2019-04-25 18:17, Marcel Holtmann wrote: Hi Harish, Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi Reviewed-by: Matthias Kaehlcke --- Changes in V7

[PATCH v7 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-04-25 Thread Harish Bandi
Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi Reviewed-by: Matthias Kaehlcke --- Changes in V7: - Initialized rom_ver to 0 to fix compiler warning --- drivers/bluetooth

[PATCH v7 0/2] Enable Bluetooth functionality for WCN3998.

2019-04-25 Thread Harish Bandi
to latest code base. Harish Bandi (2): Bluetooth: hci_qca: Added support for WCN3998 dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998 .../devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +-- drivers/bluetooth/btqca.c | 12

[PATCH v7 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-04-25 Thread Harish Bandi
Add compatible string for the Qualcomm WCN3998 Bluetooth controller Signed-off-by: Harish Bandi --- Changes in V6: - Changed Commit text --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation

Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

2019-04-24 Thread Harish Bandi
in dts. tested 20 times with bd address missing in dts. tested 20 times with bd address available in dts. Tested-by: Harish Bandi Thanks, Harish

Re: [PATCH v6 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-04-01 Thread Harish Bandi
Hi Rob, Could you please help to review DT bindings patch. On 2019-03-27 17:58, Harish Bandi wrote: This patch enables regulators for the Qualcomm Bluetooth WCN3998 controller. Signed-off-by: Harish Bandi --- Changes in V6: - no changes --- Documentation/devicetree/bindings/net/qualcomm

Re: [PATCH v6 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-28 Thread Harish Bandi
] [cannot apply to v5.1-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Harish-Bandi/Bluetooth-hci_qca-Added-support-for-WCN3998/20190328-213357 base: https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH v6 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-28 Thread Harish Bandi
Hi Matthias, On 2019-03-27 22:26, Matthias Kaehlcke wrote: On Wed, Mar 27, 2019 at 05:58:42PM +0530, Harish Bandi wrote: Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi

Re: [PATCH v6 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-03-28 Thread Harish Bandi
Hi Matthias, On 2019-03-27 22:59, Matthias Kaehlcke wrote: On Wed, Mar 27, 2019 at 05:58:43PM +0530, Harish Bandi wrote: This patch enables regulators for the Qualcomm Bluetooth WCN3998 controller. I commented on this on v3, but you didn't update it: No, it doesn't. The ne

[PATCH v6 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-03-27 Thread Harish Bandi
This patch enables regulators for the Qualcomm Bluetooth WCN3998 controller. Signed-off-by: Harish Bandi --- Changes in V6: - no changes --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation

[PATCH v6 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-27 Thread Harish Bandi
Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi --- Changes in V6: - changed return value to false in the qca_is_wcn399x()stub --- drivers/bluetooth/btqca.c | 13

[PATCH v6 0/2] Enable Bluetooth functionality for WCN3998.

2019-03-27 Thread Harish Bandi
function to btqca.c modified the DT document for wcn399x as per driver code Changes in V4: Added is_qca_soc_type_wcn399x_family helper function to get the soc type is wcn399x or not. Changes in V3: updated to latest code base. Harish Bandi (2): Bluetooth: hci_qca: Added support for WCN3998 dt

Re: [PATCH v5 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-27 Thread Harish Bandi
Hi Matthias, On 2019-03-27 05:14, Matthias Kaehlcke wrote: On Tue, Mar 26, 2019 at 05:15:55PM +0530, Harish Bandi wrote: Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi

Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3998

2019-03-27 Thread Harish Bandi
dd them in new version of patches. > > > > > > On Tue, Mar 12, 2019 at 05:52:59PM +0530, Harish Bandi wrote: > > > > This patch enables regulators for the Qualcomm Bluetooth wcn3998 > > > > controller. > > > > > > No, it doesn&

[PATCH v5 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-03-26 Thread Harish Bandi
This patch enables regulators for the Qualcomm Bluetooth WCN3998 controller. Signed-off-by: Harish Bandi --- Changes in V5: - modified the DT document for wcn399x to make inline - in function call with driver code --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++-- 1

[PATCH v5 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-26 Thread Harish Bandi
Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi --- Changes in V5: - changed is_qca_soc_type_wcn399x_family to - qca_is_wcn399x helper function - moved the qca_is_wcn399x

[PATCH v5 0/2] Enable Bluetooth functionality for WCN3998.

2019-03-26 Thread Harish Bandi
Changes in V4: Added is_qca_soc_type_wcn399x_family helper function to get the soc type is wcn399x or not. Changes in V3: updated to latest code base. Harish Bandi (2): Bluetooth: hci_qca: Added support for WCN3998 dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

[PATCH v4 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-03-25 Thread Harish Bandi
This patch enables regulators for the Qualcomm Bluetooth WCN3998 controller. Signed-off-by: Harish Bandi --- Changes in V4: - Removed new compatible WCN3998 - changed wcn3990 to wcn399* to represent wcn399* family --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 7 --- 1

[PATCH v4 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-25 Thread Harish Bandi
Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi --- Changes in V4: - Added is_qca_soc_type_wcn399x_family helper function - to get the soc type is wcn399x or not. --- drivers

[PATCH v4 0/2] Enable Bluetooth functionality for WCN3998.

2019-03-25 Thread Harish Bandi
compatible for WCN3998. Removed the Reading of regulator values from dts. Added new compatible for WCN3998. Changes in V4: Added is_qca_soc_type_wcn399x_family helper function to get the soc type is wcn399x or not. Changes in V3: updated to latest code base. Harish Bandi (2): Bluetooth

[PATCH v4 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998

2019-03-25 Thread Harish Bandi
This patch enables regulators for the Qualcomm Bluetooth WCN3998 controller. Signed-off-by: Harish Bandi --- Changes in V4: - Removed new compatible WCN3998 - changed wcn3990 to wcn399* to represent wcn399* family --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 7 --- 1

[PATCH v4 1/2] Bluetooth: hci_qca: Added support for WCN3998

2019-03-25 Thread Harish Bandi
Added new compatible for WCN3998 and corresponding voltage and current values to WCN3998 compatible. Changed driver code to support WCN3998 Signed-off-by: Harish Bandi --- Changes in V4: - Added is_qca_soc_type_wcn399x_family helper function - to get the soc type is wcn399x or not. --- drivers

[PATCH v4 0/2] Enable Bluetooth functionality for WCN3998.

2019-03-25 Thread Harish Bandi
compatible for WCN3998. Removed the Reading of regulator values from dts. Added new compatible for WCN3998. Changes in V4: Added is_qca_soc_type_wcn399x_family helper function to get the soc type is wcn399x or not. Changes in V3: updated to latest code base. Harish Bandi (2): Bluetooth

[PATCH v3 0/2] Enable Bluetooth functionality for wcn3998.

2019-03-12 Thread Harish Bandi
compatible for wcn3998. Removed the Reading of regulator values from dts. Added new compatible for wcn3998. Changed in V3: updated to latest code base. Harish Bandi (2): Bluetooth: hci_qca: Added support for wcn3998 dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3998

[PATCH v3 1/2] Bluetooth: hci_qca: Added support for wcn3998

2019-03-12 Thread Harish Bandi
Added new compatible for wcn3998 and corresponding voltage and current values to wcn3998 compatible. Changed driver code to support wcn3998 Signed-off-by: Harish Bandi --- changes in v3: - updated to latest code base. --- drivers/bluetooth/btqca.c | 4 ++-- drivers/bluetooth/btqca.h | 3

[PATCH v3 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3998

2019-03-12 Thread Harish Bandi
This patch enables regulators for the Qualcomm Bluetooth wcn3998 controller. Signed-off-by: Harish Bandi --- changes in v3: - updated to latest code base. --- .../devicetree/bindings/net/qualcomm-bluetooth.txt| 15 +++ 1 file changed, 15 insertions(+) diff --git a

[PATCH v2 0/2] Enable Bluetooth functionality for wcn3998.

2019-03-08 Thread Harish Bandi
compatible for wcn3998. Removed the Reading of regulator values from dts. Added new compatible for wcn3998. Harish Bandi (2): Bluetooth: hci_qca: Added support for wcn3998 dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3998 .../devicetree/bindings/net/qualcomm

[PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3998

2019-03-08 Thread Harish Bandi
This patch enables regulators for the Qualcomm Bluetooth wcn3998 controller. Signed-off-by: Harish Bandi --- Changes in V2: - Removed the regulator values in dts. - Added new compatible for wcn3998. --- .../devicetree/bindings/net/qualcomm-bluetooth.txt| 15 +++ 1 file

[PATCH v2 1/2] Bluetooth: hci_qca: Added support for wcn3998

2019-03-08 Thread Harish Bandi
Added new compatible for wcn3998 and corresponding voltage and current values to wcn3998 compatible. Changed driver code to support wcn3998 Signed-off-by: Harish Bandi --- Changes in V2: - Removed the Reading of regulator values from dts. - Added new compatible for wcn3998. --- drivers

[PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2019-03-07 Thread Harish Bandi
This patch enables regulators for the Qualcomm Bluetooth wcn3990 controller. Added entry for regulator currents, min and max voltages Signed-off-by: Harish Bandi --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 12 1 file changed, 12 insertions(+) diff --git a

[PATCH v1 1/2] Bluetooth: hci_qca: Added support to read the regulator values from DTS

2019-03-07 Thread Harish Bandi
the regulators, it will set the those current and voltage values. If no values set in DTS, it will read the default values and set those values only. This change will help in supporting multiple platforms. Signed-off-by: Harish Bandi --- drivers/bluetooth/hci_qca.c | 76

[PATCH v1 0/2] Enable Bluetooth functionality for wcn3998.

2019-03-07 Thread Harish Bandi
leveraging the existing code of wcn3990 along with readiing the voltages from the dts file. Harish Bandi (2): Bluetooth: hci_qca: Added support to read the regulator values from DTS dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990 .../devicetree/bindings/net