Insu Yun schrieb am 19.10.2015 um 18:08:
> Since devm_regulator_get returns address or error, not NULL,
> it needs to be checked with IS_ERR, not IS_ERR_OR_NULL.
>
Actually, it does return NULL, if regulator support is disabled
(see [1]).
Insu Yun schrieb am 19.10.2015 um 18:08:
> Since devm_regulator_get returns address or error, not NULL,
> it needs to be checked with IS_ERR, not IS_ERR_OR_NULL.
>
Actually, it does return NULL, if regulator support is disabled
(see [1]).
Markus Pargmann schrieb am 12.08.2015 um 12:12:
> There are some fields of this struct undocumented or old. This patch
> updates the missing comments.
>
> Signed-off-by: Markus Pargmann
> ---
> include/linux/regmap.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
Markus Pargmann schrieb am 12.08.2015 um 12:12:
There are some fields of this struct undocumented or old. This patch
updates the missing comments.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
include/linux/regmap.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
Hartmut Knaack schrieb am 02.08.2015 um 21:32:
> Jonathan Cameron schrieb am 02.08.2015 um 19:27:
>> On 24/07/15 14:18, Cristina Opriceana wrote:
>>> Fix kernel docs for structures and functions in order to
>>> remove some warnings when the documentation gets ge
Jonathan Cameron schrieb am 02.08.2015 um 19:33:
> On 24/07/15 14:21, Cristina Opriceana wrote:
>> Fix kernel docs warnings by adding the missing fields,
>> each with its associated description.
>>
>> Signed-off-by: Cristina Opriceana
> Applied. Thanks
>
> Jonathan
>> ---
>>
Jonathan Cameron schrieb am 02.08.2015 um 19:27:
> On 24/07/15 14:18, Cristina Opriceana wrote:
>> Fix kernel docs for structures and functions in order to
>> remove some warnings when the documentation gets generated.
>>
>> Signed-off-by: Cristina Opriceana
> Applied with another typo fixed up.
Jonathan Cameron schrieb am 02.08.2015 um 19:27:
On 24/07/15 14:18, Cristina Opriceana wrote:
Fix kernel docs for structures and functions in order to
remove some warnings when the documentation gets generated.
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
Applied with
Hartmut Knaack schrieb am 02.08.2015 um 21:32:
Jonathan Cameron schrieb am 02.08.2015 um 19:27:
On 24/07/15 14:18, Cristina Opriceana wrote:
Fix kernel docs for structures and functions in order to
remove some warnings when the documentation gets generated.
Signed-off-by: Cristina Opriceana
Jonathan Cameron schrieb am 02.08.2015 um 19:33:
On 24/07/15 14:21, Cristina Opriceana wrote:
Fix kernel docs warnings by adding the missing fields,
each with its associated description.
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
Applied. Thanks
Jonathan
---
Irina Tirdea schrieb am 24.07.2015 um 15:28:
> Running generic_buffer without enabling any channel of the
> sensor will fail without printing any error message.
>
> Add an error message that indicates buffer enable failed.
>
> Signed-off-by: Irina Tirdea
Acked-by: Hartmut Knaa
Irina Tirdea schrieb am 24.07.2015 um 15:28:
Running generic_buffer without enabling any channel of the
sensor will fail without printing any error message.
Add an error message that indicates buffer enable failed.
Signed-off-by: Irina Tirdea irina.tir...@intel.com
Acked-by: Hartmut Knaack
Irina Tirdea schrieb am 23.07.2015 um 19:22:
> Running generic_buffer without enabling any channel of the
> sensor will fail without printing any error message.
>
> Add an error message that indicates buffer enable failed.
Hi,
please make use of the error code stored in ret (with negative sign),
being 0. Before printing,
> the mask is applied to the raw value, thus generating a final value of 0.
>
> Fix the mask by shifting a 64 bit value instead of an integer.
>
> Signed-off-by: Irina Tirdea
Acked-by: Hartmut Knaack
> ---
> tools/iio/iio_utils.c | 2 +-
> 1 f
Irina Tirdea schrieb am 23.07.2015 um 19:22:
Running generic_buffer without enabling any channel of the
sensor will fail without printing any error message.
Add an error message that indicates buffer enable failed.
Hi,
please make use of the error code stored in ret (with negative sign), as
,
the mask is applied to the raw value, thus generating a final value of 0.
Fix the mask by shifting a 64 bit value instead of an integer.
Signed-off-by: Irina Tirdea irina.tir...@intel.com
Acked-by: Hartmut Knaack knaac...@gmx.de
---
tools/iio/iio_utils.c | 2 +-
1 file changed, 1 insertion
ood so far. Two off-by-one indentation issues spotted however
(checkpatch didn't spot at least the first one), but after fixing you can
add my
Reviewed-by: Hartmut Knaack
> Signed-off-by: Cristina Opriceana
> ---
> Changes since v2:
> - merge all replacements in one commit
>
Cristina Opriceana schrieb am 13.07.2015 um 15:20:
> Calculation of the length of an array can be done with the ARRAY_SIZE
> macro to make code more abstract and remove the associated
> checkpatch.pl warning.
>
> Signed-off-by: Cristina Opriceana
Acked-by: Hartmut Knaack
>
Cristina Opriceana schrieb am 13.07.2015 um 15:17:
> Single statement blocks don’t need braces.
> Found with checkpatch.pl.
>
> Signed-off-by: Cristina Opriceana
Acked-by: Hartmut Knaack
> ---
Oops, that slipped through my hands. Thanks for taking care of this
Cristina Opriceana schrieb am 13.07.2015 um 15:15:
> Remove explicit NULL comparison and write it in its simpler form as
> recommended by checkpatch.pl.
>
> Signed-off-by: Cristina Opriceana
Reviewed-by: Hartmut Knaack
> ---
Every instance covered, consistency improved. Not eve
Cristina Opriceana schrieb am 13.07.2015 um 15:17:
Single statement blocks don’t need braces.
Found with checkpatch.pl.
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
Acked-by: Hartmut Knaack knaac...@gmx.de
---
Oops, that slipped through my hands. Thanks for taking care
Cristina Opriceana schrieb am 13.07.2015 um 15:15:
Remove explicit NULL comparison and write it in its simpler form as
recommended by checkpatch.pl.
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
Every instance covered
Cristina Opriceana schrieb am 13.07.2015 um 15:20:
Calculation of the length of an array can be done with the ARRAY_SIZE
macro to make code more abstract and remove the associated
checkpatch.pl warning.
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
Acked-by: Hartmut Knaack
-by-one indentation issues spotted however
(checkpatch didn't spot at least the first one), but after fixing you can
add my
Reviewed-by: Hartmut Knaack knaac...@gmx.de
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
---
Changes since v2:
- merge all replacements in one commit
Cristina Georgiana Opriceana schrieb am 12.07.2015 um 13:38:
> On Sat, Jul 11, 2015 at 12:42 AM, Hartmut Knaack wrote:
>> Cristina Opriceana schrieb am 10.07.2015 um 12:56:
>>> Replace printf error messages with fprintf(stderr, ...) in order
>>> to ensure consistenc
Cristina Georgiana Opriceana schrieb am 12.07.2015 um 13:38:
On Sat, Jul 11, 2015 at 12:42 AM, Hartmut Knaack knaac...@gmx.de wrote:
Cristina Opriceana schrieb am 10.07.2015 um 12:56:
Replace printf error messages with fprintf(stderr, ...) in order
to ensure consistency and to make faults
Cristina Opriceana schrieb am 10.07.2015 um 12:56:
> Replace printf error messages with fprintf(stderr, ...) in order
> to ensure consistency and to make faults easier to identify.
> This patch uses coccinelle to detect and apply the changes.
>
Hi Cristina,
I just had a look at the series. You
Cristina Opriceana schrieb am 10.07.2015 um 12:56:
Replace printf error messages with fprintf(stderr, ...) in order
to ensure consistency and to make faults easier to identify.
This patch uses coccinelle to detect and apply the changes.
Hi Cristina,
I just had a look at the series. You have
Daniel Baluta schrieb am 29.06.2015 um 09:52:
> On Mon, Jun 29, 2015 at 2:07 AM, Hartmut Knaack wrote:
>> Daniel Baluta schrieb am 24.04.2015 um 17:58:
>>> Minimal implementation for MMC35240 3-axis magnetometer
>>> sensor. It provides processed readings and possiblity
Daniel Baluta schrieb am 29.06.2015 um 09:52:
On Mon, Jun 29, 2015 at 2:07 AM, Hartmut Knaack knaac...@gmx.de wrote:
Daniel Baluta schrieb am 24.04.2015 um 17:58:
Minimal implementation for MMC35240 3-axis magnetometer
sensor. It provides processed readings and possiblity to change
Daniel Baluta schrieb am 24.04.2015 um 17:58:
> Minimal implementation for MMC35240 3-axis magnetometer
> sensor. It provides processed readings and possiblity to change
> the sampling frequency.
>
Hi Daniel,
please find a few issues inline, which you could address in a next
rework patch set. I
Daniel Baluta schrieb am 24.04.2015 um 17:58:
Minimal implementation for MMC35240 3-axis magnetometer
sensor. It provides processed readings and possiblity to change
the sampling frequency.
Hi Daniel,
please find a few issues inline, which you could address in a next
rework patch set. I
Irina Tirdea schrieb am 13.04.2015 um 17:40:
> This is a set of follow-up patches for the mma9553 driver that fixes
> issues as suggested by Hartmut and Daniel.
>
Finally, I got around to this series. Looks good to me.
Thanks,
Hartmut
> Changes in v2:
> - split some of the the v1 patches into
Irina Tirdea schrieb am 13.04.2015 um 17:40:
This is a set of follow-up patches for the mma9553 driver that fixes
issues as suggested by Hartmut and Daniel.
Finally, I got around to this series. Looks good to me.
Thanks,
Hartmut
Changes in v2:
- split some of the the v1 patches into
t is almost certainly
> the correct device already.
>
> Acked-by: Manuel Stahl
> Acked-by: Hartmut Knaack
I don't recall acking on this. Anyway, no objection on the patch content.
Hartmut
> Signed-off-by: NeilBrown
>
> ---
> v1 of this was sent in November. I got som
the correct device already.
Acked-by: Manuel Stahl manuel.st...@iis.fraunhofer.de
Acked-by: Hartmut Knaack knaac...@gmx.de
I don't recall acking on this. Anyway, no objection on the patch content.
Hartmut
Signed-off-by: NeilBrown n...@brown.name
---
v1 of this was sent in November. I got
Irina Tirdea schrieb am 27.01.2015 um 19:41:
> Add support for Freescale MMA9553L Intelligent Pedometer Platform.
>
> The following functionalities are supported:
> - step counter (counts the number of steps using a HW register)
> - step detector (generates an iio event at every step the user
Irina Tirdea schrieb am 27.01.2015 um 19:41:
Add support for Freescale MMA9553L Intelligent Pedometer Platform.
The following functionalities are supported:
- step counter (counts the number of steps using a HW register)
- step detector (generates an iio event at every step the user takes)
Irina Tirdea schrieb am 11.01.2015 um 20:10:
> Human activity sensors report the energy burnt by the user.
> One of this devices is Freescale's MMA9553L
> (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf)
> that computes the number of calories based on weight and step rate.
Irina Tirdea schrieb am 11.01.2015 um 20:10:
Human activity sensors report the energy burnt by the user.
One of this devices is Freescale's MMA9553L
(http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf)
that computes the number of calories based on weight and step rate.
t;>>
>>>> On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas
>>>> wrote:
>>>>> +Mika
>>>>>
>>>>> On Sat, 2014-12-20 at 13:26 -0800, Srinivas Pandruvada wrote:
>>>>>> On Sat, 2014-12-20 at 00:25 +0200, Dani
:29 PM, Pandruvada, Srinivas
srinivas.pandruv...@intel.com wrote:
+Mika
On Sat, 2014-12-20 at 13:26 -0800, Srinivas Pandruvada wrote:
On Sat, 2014-12-20 at 00:25 +0200, Daniel Baluta wrote:
On Sat, Dec 20, 2014 at 12:16 AM, Hartmut Knaack knaac...@gmx.de
wrote:
Daniel Baluta schrieb am
Daniel Baluta schrieb am 05.01.2015 um 10:21:
> odr_bits values are between 0 and 11, so we can use the index
> in kmx61_samp_freq_table instead of odr_bits structure member.
>
> Signed-off-by: Daniel Baluta
Reviewed-by: Hartmut Knaack
> ---
> Changes since v1:
> * u
Daniel Baluta schrieb am 05.01.2015 um 10:21:
odr_bits values are between 0 and 11, so we can use the index
in kmx61_samp_freq_table instead of odr_bits structure member.
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
Changes since v1
Jonathan Cameron schrieb am 04.01.2015 um 11:55:
> On 01/01/15 13:53, Hartmut Knaack wrote:
>> Daniel Baluta schrieb am 23.12.2014 um 14:22:
>>> odr_bits values are between 0 and 11, so we can use the index
>>> in kmx61_samp_freq_table instead of odr_bits structure m
Jonathan Cameron schrieb am 04.01.2015 um 11:55:
On 01/01/15 13:53, Hartmut Knaack wrote:
Daniel Baluta schrieb am 23.12.2014 um 14:22:
odr_bits values are between 0 and 11, so we can use the index
in kmx61_samp_freq_table instead of odr_bits structure member.
Basically looking good, but I
Adam Thomson schrieb am 22.12.2014 um 17:51:
> This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC.
>
> Signed-off-by: Adam Thomson
Reviewed-by: Hartmut Knaack
> ---
> drivers/iio/adc/Kconfig| 9 +
> drivers/iio/adc/Makefile | 1 +
>
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> We have two IIO devices and we need to adjust the base
> when reading data.
>
> Signed-off-by: Daniel Baluta
Reviewed-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 8 +++-
> 1 file changed, 7 insertions(+), 1
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> odr_bits values are between 0 and 11, so we can use the index
> in kmx61_samp_freq_table instead of odr_bits structure member.
Basically looking good, but I would feel more comfortable to check
against the boundaries of the table. Please see inline.
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> Useful in the debugging phase, not needed now.
>
> Signed-off-by: Daniel Baluta
Acked-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/imu/kmx61.c b
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> Signed-off-by: Daniel Baluta
Acked-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> index 30
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> Signed-off-by: Daniel Baluta
Acked-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> index 33
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> Signed-off-by: Daniel Baluta
Reviewed-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> i
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> Signed-off-by: Daniel Baluta
Acked-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> This fixes parts of kmx61 error handling to make code easier to read and to be
> more consistent with IIO coding conventions:
> * prefer as single point for error handling instead of duplicating code
> for each function
> * directly
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> ..except while in an error handler, where there is nothing
> to be done anyway.
>
> Signed-off-by: Daniel Baluta
Reviewed-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 11 +--
> 1 file changed, 9 inser
Daniel Baluta schrieb am 23.12.2014 um 14:22:
> Signed-off-by: Daniel Baluta
Reviewed-by: Hartmut Knaack
> ---
> drivers/iio/imu/kmx61.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> index 972424b..fe0cee7 1
Daniel Baluta schrieb am 23.12.2014 um 14:22:
This fixes parts of kmx61 error handling to make code easier to read and to be
more consistent with IIO coding conventions:
* prefer as single point for error handling instead of duplicating code
for each function
* directly
Daniel Baluta schrieb am 23.12.2014 um 14:22:
odr_bits values are between 0 and 11, so we can use the index
in kmx61_samp_freq_table instead of odr_bits structure member.
Basically looking good, but I would feel more comfortable to check
against the boundaries of the table. Please see inline.
Daniel Baluta schrieb am 23.12.2014 um 14:22:
..except while in an error handler, where there is nothing
to be done anyway.
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 11 +--
1 file changed, 9
Daniel Baluta schrieb am 23.12.2014 um 14:22:
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu
Daniel Baluta schrieb am 23.12.2014 um 14:22:
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Acked-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/imu/kmx61.c b/drivers
Daniel Baluta schrieb am 23.12.2014 um 14:22:
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Acked-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
Daniel Baluta schrieb am 23.12.2014 um 14:22:
Useful in the debugging phase, not needed now.
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Acked-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iio/imu
Daniel Baluta schrieb am 23.12.2014 um 14:22:
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Acked-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
Daniel Baluta schrieb am 23.12.2014 um 14:22:
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
index 972424b
Daniel Baluta schrieb am 23.12.2014 um 14:22:
We have two IIO devices and we need to adjust the base
when reading data.
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/imu/kmx61.c | 8 +++-
1 file changed, 7 insertions
Adam Thomson schrieb am 22.12.2014 um 17:51:
This patch adds support for DA9150 Charger Fuel-Gauge IC GPADC.
Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/adc/Kconfig| 9 +
drivers/iio/adc/Makefile
Jonathan Cameron schrieb am 26.12.2014 um 12:51:
> On 15/12/14 11:39, Nikolaus Schulz wrote:
>> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI
>> interface.
>>
>> Changes in v3:
>> * Small fixes in the documentation of struct dac8554_state
>> * Replace some magic
Jonathan Cameron schrieb am 26.12.2014 um 12:51:
On 15/12/14 11:39, Nikolaus Schulz wrote:
The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI
interface.
Changes in v3:
* Small fixes in the documentation of struct dac8554_state
* Replace some magic constants with macros
Daniel Baluta schrieb am 18.12.2014 um 18:16:
> When using ACPI, if acpi_match_device fails then chipset enum will be
> uninitialized and _def_array[chipset] will point to some bad address.
>
> This fixes the following compilation warning:
>
> drivers/iio/magnetometer/ak8975.c: In function
Daniel Baluta schrieb am 18.12.2014 um 18:16:
When using ACPI, if acpi_match_device fails then chipset enum will be
uninitialized and ak_def_array[chipset] will point to some bad address.
This fixes the following compilation warning:
drivers/iio/magnetometer/ak8975.c: In function
i-z" to "three_state" as per
> ABI/testing/sysfs-bus-iio
> * Register device late in probe function
> * Avoid powerdown broadcast update, which touches all DAC on the bus
>
> Signed-off-by: Nikolaus Schulz
Reviewed-by: Hartmut Knaack
&g
broadcast update, which touches all DAC on the bus
Signed-off-by: Nikolaus Schulz nikolaus.sch...@avionic-design.de
Reviewed-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/dac/Kconfig | 11 ++
drivers/iio/dac/Makefile | 1 +
drivers/iio/dac/ti-dac8554.c | 381
Karol Wrona schrieb am 05.12.2014 um 20:54:
> This patch adds gyroscope iio driver which uses sensorhub as data
> provider.
>
This one has got a more serious issue.
> Change-Id: Ia16bc92159d062a29957de8e62ea3fefdcd7985a
> Signed-off-by: Karol Wrona
> Acked-by: Kyungmin Park
> ---
>
Karol Wrona schrieb am 05.12.2014 um 20:54:
> This patch adds accelerometer iio driver which uses sensorhub as data
> provider.
>
Also looking very good now. One more whitespace issue remaining.
> Change-Id: I4686741b7401ec5cbf4b5d0f2a5cc146fbe24d53
> Signed-off-by: Karol Wrona
> Acked-by:
Karol Wrona schrieb am 05.12.2014 um 20:54:
> This patch adds common library for sensorhub iio drivers.
>
Looks good to me, overall. Just one very small nitpick.
> Change-Id: I1038cb31c051f7e8ffde696a4121518daa5af081
> Signed-off-by: Karol Wrona
> Acked-by: Kyungmin Park
> ---
>
Karol Wrona schrieb am 05.12.2014 um 20:54:
> Sensorhub is MCU dedicated to collect data and manage several sensors.
> Sensorhub is a spi device which provides a layer for IIO devices. It provides
> some data parsing and common mechanism for sensorhub sensors.
>
> Adds common sensorhub library
Karol Wrona schrieb am 05.12.2014 um 20:54:
Sensorhub is MCU dedicated to collect data and manage several sensors.
Sensorhub is a spi device which provides a layer for IIO devices. It provides
some data parsing and common mechanism for sensorhub sensors.
Adds common sensorhub library for
Karol Wrona schrieb am 05.12.2014 um 20:54:
This patch adds common library for sensorhub iio drivers.
Looks good to me, overall. Just one very small nitpick.
Change-Id: I1038cb31c051f7e8ffde696a4121518daa5af081
Signed-off-by: Karol Wrona k.wr...@samsung.com
Acked-by: Kyungmin Park
Karol Wrona schrieb am 05.12.2014 um 20:54:
This patch adds accelerometer iio driver which uses sensorhub as data
provider.
Also looking very good now. One more whitespace issue remaining.
Change-Id: I4686741b7401ec5cbf4b5d0f2a5cc146fbe24d53
Signed-off-by: Karol Wrona k.wr...@samsung.com
Karol Wrona schrieb am 05.12.2014 um 20:54:
This patch adds gyroscope iio driver which uses sensorhub as data
provider.
This one has got a more serious issue.
Change-Id: Ia16bc92159d062a29957de8e62ea3fefdcd7985a
Signed-off-by: Karol Wrona k.wr...@samsung.com
Acked-by: Kyungmin Park
Daniel Baluta schrieb am 03.12.2014 um 14:31:
> We use WUFE (Wake Up from Sleep Engine) and BTSE (Back to Sleep Engine)
> to detect general motion input.
>
A few recommendations, issues and questions inline.
> Signed-off-by: Daniel Baluta
> ---
> drivers/iio/imu/kmx61.c | 433
>
Daniel Baluta schrieb am 03.12.2014 um 14:31:
We use WUFE (Wake Up from Sleep Engine) and BTSE (Back to Sleep Engine)
to detect general motion input.
A few recommendations, issues and questions inline.
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
---
drivers/iio/imu/kmx61.c | 433
Daniel Baluta schrieb am 03.12.2014 um 14:31:
> This creates a data ready trigger per IIO device.
>
I found some issues here, and some recommendations. See inline.
> Signed-off-by: Daniel Baluta
> ---
> drivers/iio/imu/Kconfig | 2 +
> drivers/iio/imu/kmx61.c | 295
>
Daniel Baluta schrieb am 03.12.2014 um 14:31:
> By default both sensors are ACTIVE, in this way the driver
> will work even if CONFIG_PM_RUNTIME is not selected.
>
Since kmx61_set_power_state() can return error codes, wouldn't it be better to
handle them (as long as you are not using it in an
Daniel Baluta schrieb am 03.12.2014 um 14:31:
> Minimal implementation for KMX61 6-axis accelerometer/magnetometer. It exports
> raw accel/magn readings together with scale and sampling frequency.
>
> This driver uses two IIO devices one for accelerometer and one for
> magnetometer.
>
Hi
Richard Weinberger schrieb am 03.12.2014 um 00:32:
> As we access i-1 we must not start with i=0.
>
> Signed-off-by: Richard Weinberger
Acked-by: Hartmut Knaack
> ---
> drivers/iio/humidity/dht11.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
Richard Weinberger schrieb am 03.12.2014 um 00:32:
> Make sure that the read function is not interrupted...
There is already a mutex iio_dev->info_exist_lock used to serialize
iio_channel_read(), which in turn accesses _read_raw(). See [1].
Richard Weinberger schrieb am 03.12.2014 um 00:32:
Make sure that the read function is not interrupted...
There is already a mutex iio_dev-info_exist_lock used to serialize
iio_channel_read(), which in turn accesses _read_raw(). See [1].
[1]http://lxr.free-electrons.com/ident?i=iio_channel_read
Richard Weinberger schrieb am 03.12.2014 um 00:32:
As we access i-1 we must not start with i=0.
Signed-off-by: Richard Weinberger rich...@nod.at
Acked-by: Hartmut Knaack knaac...@gmx.de
---
drivers/iio/humidity/dht11.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Daniel Baluta schrieb am 03.12.2014 um 14:31:
Minimal implementation for KMX61 6-axis accelerometer/magnetometer. It exports
raw accel/magn readings together with scale and sampling frequency.
This driver uses two IIO devices one for accelerometer and one for
magnetometer.
Hi Daniel,
I
Daniel Baluta schrieb am 03.12.2014 um 14:31:
By default both sensors are ACTIVE, in this way the driver
will work even if CONFIG_PM_RUNTIME is not selected.
Since kmx61_set_power_state() can return error codes, wouldn't it be better to
handle them (as long as you are not using it in an error
Daniel Baluta schrieb am 03.12.2014 um 14:31:
This creates a data ready trigger per IIO device.
I found some issues here, and some recommendations. See inline.
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
---
drivers/iio/imu/Kconfig | 2 +
drivers/iio/imu/kmx61.c | 295
Hartmut Knaack schrieb am 13.12.2014 um 12:18:
> Nikolaus Schulz schrieb am 12.12.2014 um 16:58:
>> On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote:
>>> Nikolaus Schulz schrieb am 24.11.2014 um 20:50:
>>>> The TI DAC8554 is a quad-channel Digital-t
Nikolaus Schulz schrieb am 12.12.2014 um 16:58:
> On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote:
>> Nikolaus Schulz schrieb am 24.11.2014 um 20:50:
>>> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI
>>> interface.
>>>
&
Nikolaus Schulz schrieb am 12.12.2014 um 16:58:
On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote:
Nikolaus Schulz schrieb am 24.11.2014 um 20:50:
The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI
interface.
Changes in v2:
* Use DMA-safe buffer for SPI
Hartmut Knaack schrieb am 13.12.2014 um 12:18:
Nikolaus Schulz schrieb am 12.12.2014 um 16:58:
On Sat, Dec 06, 2014 at 12:36:19PM +0100, Hartmut Knaack wrote:
Nikolaus Schulz schrieb am 24.11.2014 um 20:50:
The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI
interface
Nikolaus Schulz schrieb am 24.11.2014 um 20:50:
> The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI
> interface.
>
> Changes in v2:
> * Use DMA-safe buffer for SPI transfer
> * Normalize powerdown_mode name "hi-z" to "three_state" as per
> ABI/testing/sysfs-bus-iio
> *
Nikolaus Schulz schrieb am 24.11.2014 um 20:50:
The TI DAC8554 is a quad-channel Digital-to-Analog Converter with an SPI
interface.
Changes in v2:
* Use DMA-safe buffer for SPI transfer
* Normalize powerdown_mode name hi-z to three_state as per
ABI/testing/sysfs-bus-iio
* Register
1 - 100 of 236 matches
Mail list logo
