Re: [PATCH] iio: adc: rockchip_saradc: add support for rk3066-tsadc variant

Heiko Stübner schrieb: > Older Rockchip SoCs, at least the rk3066, used a slightly modified saradc > for temperature measurements. This so called tsadc does not contain any > active parts like temperature interrupts and only supports polling the > current temperature. The returned voltage can then

Re: [PATCH v3] iio: Add Dyna-Image AL3320A ambient light sensor driver

Daniel Baluta schrieb: > Minimal implementation. This driver provides raw illuminance readings. > > This is based on drivers/hwmon/al3320.c (*) driver from msm tree written > by Tsechih Lin > > * https://android.googlesource.com/kernel/msm.git > > Signed-off-by: Daniel Baluta Hi, I think you shou

Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

Arnd Bergmann schrieb: > This adds support for the touchscreen on Samsung s3c64xx. > The driver is completely untested but shows roughly how > it could be done, following the example of the at91 driver. > > Open questions include: > > - compared to the old plat-samsung/adc driver, there is > no s

Re: [PATCH 2/2] iio: adc: exynos_adc: Add support for S3C24xx ADC

Chanwoo Choi schrieb: > This patch add support for s3c2410/s3c2416/s3c2440/s3c2443 ADC. The s3c24xx > is alomost same as ADCv1. But, There are a little difference as following: > - ADCMUX register address to select channel > - ADCDAT mask (10bit or 12bit ADC resolution according to SoC version) Hi,

Re: [PATCH 1/2] iio: adc: exynos_adc: add support for s3c64xx adc

Chanwoo Choi schrieb: > From: Arnd Bergmann > > The ADC in s3c64xx is almost the same as exynosv1, but > has a different 'select' method. Adding this here will be > helpful to move over the existing s3c64xx platform from the > legacy plat-samsung/adc driver to the new exynos-adc. > > Signed-off-by

Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support

Jonathan Cameron schrieb: > On 18/07/14 20:29, Arnd Bergmann wrote: >> This adds support for the touchscreen on Samsung s3c64xx. >> The driver is completely untested but shows roughly how >> it could be done, following the example of the at91 driver. >> > Hi Arnd, > >> Open questions include: >> >>

Re: [PATCH 1/2] iio: exynos-adc: add support for s3c64xx adc

Arnd Bergmann schrieb: > The ADC in s3c64xx is almost the same as exynosv1, but > has a different 'select' method. Adding this here will be > helpful to move over the existing s3c64xx platform from the > legacy plat-samsung/adc driver to the new exynos-adc. > > Signed-off-by: Arnd Bergmann > --- T

Re: [PATCH v5 1/2] iio: adc: add driver for Rockchip saradc

er Reviewed-by: Hartmut Knaack > --- Looks good to me. The fact, that SARADC_DLY_PU_SOC_MASK is defined but never used should be fine under the given circumstances, that no datasheet with register definitions is publicly available. > changes since v4: > - address comments from Hartmut

Re: [PATCH v3 1/2] iio: adc: add driver for Rockchip saradc

Heiko Stübner schrieb: > The ADC is a 3-channel signal-ended 10-bit Successive Approximation > Register (SAR) A/D Converter. It uses the supply and ground as its reference > and converts the analog input signal into 10-bit binary digital codes. Is there a datasheet available anywhere, or just under

Re: [PATCH 2/2] dt-bindings: document Rockchip saradc

Heiko Stübner schrieb: > This add the necessary binding documentation for the saradc found in all > recent > processors from Rockchip. > > Signed-off-by: Heiko Stuebner > --- Spotted some typos, see inline. > .../bindings/iio/adc/rockchip-saradc.txt | 28 > ++ > 1

Re: [PATCH] iio:trigger: Introduce the use of devm_kzalloc

Himangi Saraogi schrieb: > This patch introduces the use of the managed version of kzalloc and > removes the kfrees in the probe and remove functions. Also, the labels > are renamed to order them. Since you are already on it, better drop label "out" and return the errorcode immediately after check

Re: [PATCH v7] iio: add support of the max1027

Philippe Reynes schrieb: > This driver add partial support of the > maxim 1027/1029/1031. Differential mode is not > supported. > > It was tested on armadeus apf27 board. > > Signed-off-by: Philippe Reynes Reviewed-by: Hartmut Knaack > --- Not sure if it's too late,

Re: [PATCH v6] iio: add support of the max1027

feedback) >> - add validate_trigger >> - add validate_device >> - remove useless (void *) cast >> - use allocated buffer for spi_write >> >> v4: (thanks Jonathan Cameron for the feedback) >> - use iio_trigger_generic_data_rdy_poll >> >> v3: (thanks H

Re: [PATCH v6] iio: add support of the max1027

the feedback) > - add validate_trigger > - add validate_device > - remove useless (void *) cast > - use allocated buffer for spi_write > > v4: (thanks Jonathan Cameron for the feedback) > - use iio_trigger_generic_data_rdy_poll > > v3: (thanks Hartmut Knaack, Lars-Peter C

Re: [PATCH v2] iio: add support of the max1027

trem schrieb: > Hi Hartmut, > > First, thanks a lot for this feedback, I really appreciate it. > > > On 26/05/14 00:52, Hartmut Knaack wrote: >> Philippe Reynes schrieb: >>> This driver add partial support of the >>> maxim 1027/1029/1031. Differential

Re: [PATCH v2] iio: add support of the max1027

mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt > create mode 100644 drivers/staging/iio/adc/max1027.c > > Changelog: > v2: (thanks Hartmut Knaack and Jonathan Cameron for the feedback) > - really use devm_* > - use demux magic > - use spi_read and spi_w

Re: [PATCH] iio: add support of the max1027

Philippe Reynes schrieb: > This driver add partial support of the > maxim 1027/1029/1031. Differential mode is not > supported. > > It was tested on armadeus apf27 board. > > Signed-off-by: Philippe Reynes > --- > .../devicetree/bindings/iio/adc/max1027-adc.txt| 19 + > drivers/staging/iio/

Re: [patch v2] [patch] staging: iio: ad799x: remove some unneeded IS_ERR() checks

f);" fails, > then we call "regulator_disable(st->vref);" and that's a mistake because > "st->vref" is not enabled. > > I fixed these problems and Hartmut Knaack pointed out a couple unneeded > IS_ERR() checks in ad799x_remove() so I have removed those as well. &

<    1   2