Re: [dm-devel] [PATCH -next] md: dm-ebs-target: fix build errors & Kconfig entry

2020-04-29 Thread Heinz Mauelshagen
-ebs-target.c:(.text+0x7fe): undefined reference to `dm_bufio_write_dirty_buffers' ld: drivers/md/dm-ebs-target.o: in function `ebs_ctr': dm-ebs-target.c:(.text+0xa82): undefined reference to `dm_bufio_client_create' Signed-off-by: Randy Dunlap Cc: Heinz Mauelshagen Cc: Alasdair K

[PATCH] null_blk: fix checking for REQ_FUA

2019-02-22 Thread Heinz Mauelshagen
null_handle_bio() erroneously uses the bio_op macro which masks respective request flag bits including REQ_FUA out thus failing the check. Fix by checking bio->bi_opf directly. Signed-off-by: Heinz Mauelshagen --- drivers/block/null_blk_main.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] md: fix md_write_start() deadlock w/o metadata devices

2018-02-02 Thread Heinz Mauelshagen
oid waiting. Once on it, check for non-existing superblocks in md_super_write(). Link: https://bugzilla.kernel.org/show_bug.cgi?id=198647 Fixes: cc27b0c78c796 ("md: fix deadlock between mddev_suspend() and md_write_start()") Signed-off-by: Heinz Mauelshagen --- drivers/md/md.c | 10 ++

Re: [dm-devel] [PATCH][RFC] dm raid: Fix NULL pointer dereference for raid1 without bitmap

2017-03-30 Thread Heinz Mauelshagen
Acked-by: Heinz Mauelshagen This is the simplest way to solve the issue at hand (bitmap_load() returns success with non-existing bitmap). Heinz On 03/30/2017 05:14 PM, km...@yandex-team.ru wrote: From: Dmitry Bilunov 4257e08 introduces a bitmap resize call during preresume phase. User can

Re: [PATCH 1/1] dm raid: fix compat_features validation

2016-10-14 Thread Heinz Mauelshagen
On 10/11/2016 07:44 PM, Mike Snitzer wrote: On Tue, Oct 11 2016 at 11:44am -0400, Heinz Mauelshagen wrote: On 10/11/2016 05:38 PM, Andy Whitcroft wrote: On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote: Andy, good catch. We should rather check for V190 support only in

Re: [PATCH 1/1 V2] dm raid: fix compat_features validation

2016-10-11 Thread Heinz Mauelshagen
Acked-by: Heinz Mauelshagen On 10/11/2016 06:21 PM, Andy Whitcroft wrote: From a30fba068e41214cb0ffcb14e68722482765e0c9 Mon Sep 17 00:00:00 2001 From: Andy Whitcroft Date: Tue, 11 Oct 2016 15:16:57 +0100 In ecbfb9f118bce4 ("dm raid: add raid level takeover support") a new

Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation

2016-10-11 Thread Heinz Mauelshagen
On 10/11/2016 05:38 PM, Andy Whitcroft wrote: On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote: Andy, good catch. We should rather check for V190 support only in case any compat feature flags are actually set. { + if (le32_to_cpu(sb->compat_featu

Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation

2016-10-11 Thread Heinz Mauelshagen
Andy, good catch. We should rather check for V190 support only in case any compat feature flags are actually set. I.e.: diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 8abde6b..2a39700 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2258,7 +2258,8 @@ static in

Re: [PATCH] dm raid: don't use 'const' in function return

2016-06-16 Thread Heinz Mauelshagen
Thanks Arnd. On 06/16/2016 11:03 AM, Arnd Bergmann wrote: A newly introduced function has 'const int' as the return type, but as "make W=1" reports, that has no meaning: drivers/md/dm-raid.c:510:18: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers] This chan

*** Announcement: dmraid 1.0.0.rc7 ***

2005-04-11 Thread Heinz Mauelshagen
angelog from dmraid 1.0.0.rc6 to 1.0.0.rc72005.04.07 FIXES: -- o pdc.c, hpt37x.c, hpt45x.c: fixed size in sectors() for RAID1 MISCELANIOUS: o sil_valid() displays the area number where the checksum is invalid now. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

*** Announcement: dmraid 1.0.0.rc6 ***

2005-03-01 Thread Heinz Mauelshagen
evmapper.c: check target type registered before trying to load table record o misc.c: avoid find_percent(). =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Heinz Mauelshagen Red Hat GmbH Consulting Development Engineer