On Sat, Aug 16, 2014 at 4:51 AM, Greg KH <gre...@linuxfoundation.org> wrote: > On Fri, Aug 15, 2014 at 11:48:05PM +0530, Hema Prathaban wrote: >> This patch fixes the following warning using checkpatch.pl >> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then >> dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... >> >> Signed-off-by: Hema Prathaban <hemakl...@gmail.com> >> --- >> drivers/staging/lustre/lustre/libcfs/debug.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c >> b/drivers/staging/lustre/lustre/libcfs/debug.c >> index 6b58469..8143ebe 100644 >> --- a/drivers/staging/lustre/lustre/libcfs/debug.c >> +++ b/drivers/staging/lustre/lustre/libcfs/debug.c >> @@ -344,7 +344,7 @@ void libcfs_debug_dumplog_internal(void *arg) >> snprintf(debug_file_name, sizeof(debug_file_name) - 1, >> "%s.%ld.%ld", libcfs_debug_file_path_arr, >> get_seconds(), (long_ptr_t)arg); >> - printk(KERN_ALERT "LustreError: dumping log to %s\n", >> + pr_alert(KERN_ALERT "LustreError: dumping log to %s\n", >> debug_file_name); >> cfs_tracefile_dump_all_pages(debug_file_name); >> libcfs_run_debug_log_upcall(debug_file_name); >> @@ -376,7 +376,7 @@ void libcfs_debug_dumplog(void) >> (void *)(long)current_pid(), >> "libcfs_debug_dumper"); >> if (IS_ERR(dumper)) >> - printk(KERN_ERR "LustreError: cannot start log dump thread:" >> + pr_err(KERN_ERR "LustreError: cannot start log dump thread:" > > You need to take the printk prefix off of these types of lines if you > are using the pr_*() macro, otherwise you will get a mess in the system > log. > > thanks, > > greg k-h
Hi Greg, I have resented my patches. Thanks Hema -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/