Re: [PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set

2021-01-11 Thread Holger Assmann
On Thu, 17.12.20 um 02:13 Jakub Kicinski wrote: Thanks for the patch, minor nits below. Thanks for the Feedback! I will work it in for my v2. + + if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)) !a && !b reads better IMHO We've chosen this variant because it is

[PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set

2020-12-16 Thread Holger Assmann
hw clock driver") Fixes: cc4c9001ce31 ("net: stmmac: Switch stmmac_hwtimestamp to generic HW Interface Helpers") Reported-by: Michael Olbrich Signed-off-by: Ahmad Fatoum Signed-off-by: Holger Assmann --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 121 -- 1 file

[PATCH 2/2] net: stmmac: drop no longer variable priv member

2020-12-16 Thread Holger Assmann
. Signed-off-by: Ahmad Fatoum Signed-off-by: Holger Assmann --- drivers/net/ethernet/stmicro/stmmac/dwmac5.c| 7 +++ drivers/net/ethernet/stmicro/stmmac/dwmac5.h| 2 +- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 7 +++ drivers/net/ethernet/stmicro/stmmac/hwif.

[PATCH] ARM: dts: stm32: lxa-mc1: enable DDR50 mode on eMMC

2020-08-28 Thread Holger Assmann
From: Ahmad Fatoum The "eMMC high-speed DDR mode (3.3V I/O)" at 50MHz is supported on the eMMC-interface of the lxa-mc1. Set it in the device tree to benefit from the speed improvement. Signed-off-by: Ahmad Fatoum Signed-off-by: Holger Assmann --- arch/arm/boot/dts/stm32mp157c-l

[PATCH] i2c: stm32: remove unnecessary DMA kernel error log

2020-08-14 Thread Holger Assmann
lead to DMA being intentionally off for specific devices. This patch removes the unnecessary error message. Fixes: e07a89775c71 ("i2c: stm32: don't print an error on probe deferral") Signed-off-by: Holger Assmann --- drivers/i2c/busses/i2c-stm32.c | 5 - 1 file changed, 5 deletion

[PATCH] serial: stm32: avoid kernel warning on absence of optional IRQ

2020-08-13 Thread Holger Assmann
mainline device trees trigger an unnecessary kernel warning. Use of platform_get_irq_optional() avoids this. Fixes: 2c58e56096dd ("serial: stm32: fix the get_irq error case") Signed-off-by: Holger Assmann --- drivers/tty/serial/stm32-usart.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays

2020-08-07 Thread Holger Assmann
d with "rgmii-id" work fine on this board, so drop the explicit timings in the device tree and thereby silence the warning. Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board") Signed-off-by: Holger Assmann --- arch/arm/boot/dts/stm32mp157c-lxa-mc1.