Re: [PATCH v5 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-29 Thread Hong jinkun
On 2014/10/22 15:58, Ulf Hansson wrote: [...] + + list_for_each_entry(de, >dev_list, node) { + i += 1; + pm_clk_resume(pd->dev); Do you really need to call pm_clk_resume() number of times that there are devices in power domain? Did you want it to be

Re: [PATCH v5 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-29 Thread Hong jinkun
On 2014/10/22 15:58, Ulf Hansson wrote: [...] + + list_for_each_entry(de, pd-dev_list, node) { + i += 1; + pm_clk_resume(pd-dev); Do you really need to call pm_clk_resume() number of times that there are devices in power domain? Did you want it to be

Re: [PATCH v7 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-28 Thread Hong jinkun
在 2014/10/28 7:39, Dmitry Torokhov 写道: On Fri, Oct 24, 2014 at 09:44:31AM -0700, Dmitry Torokhov wrote: Hi Jinkun, On Fri, Oct 24, 2014 at 12:29:19AM -0700, jinkun.hong wrote: +static int rockchip_pd_power(struct rockchip_domain *pd, bool power_on) +{ + int ret = 0; + struct

Re: [PATCH v7 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-28 Thread Hong jinkun
在 2014/10/28 7:39, Dmitry Torokhov 写道: On Fri, Oct 24, 2014 at 09:44:31AM -0700, Dmitry Torokhov wrote: Hi Jinkun, On Fri, Oct 24, 2014 at 12:29:19AM -0700, jinkun.hong wrote: +static int rockchip_pd_power(struct rockchip_domain *pd, bool power_on) +{ + int ret = 0; + struct

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-21 Thread Hong jinkun
在 2014/10/21 5:31, Kevin Hilman 写道: "jinkun.hong" writes: From: "jinkun.hong" Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai Signed-off-by: jinkun.hong [...] +static int rockchip_pmu_set_idle_request(struct

Re: [PATCH v5 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-21 Thread Hong jinkun
p/pm_domains.c new file mode 100644 index 000..8f13445 --- /dev/null +++ b/arch/arm/mach-rockchip/pm_domains.c @@ -0,0 +1,368 @@ +/* + * Rockchip Generic power domain support. + * + * Copyright (c) 2014 ROCKCHIP, Co. Ltd. + * Author: Hong Jinkun + * + * This program is free softwar

Re: [PATCH v5 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-21 Thread Hong jinkun
-rockchip/pm_domains.c b/arch/arm/mach-rockchip/pm_domains.c new file mode 100644 index 000..8f13445 --- /dev/null +++ b/arch/arm/mach-rockchip/pm_domains.c @@ -0,0 +1,368 @@ +/* + * Rockchip Generic power domain support. + * + * Copyright (c) 2014 ROCKCHIP, Co. Ltd. + * Author: Hong Jinkun

Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform

2014-10-21 Thread Hong jinkun
在 2014/10/21 5:31, Kevin Hilman 写道: jinkun.hong jinkun.h...@rock-chips.com writes: From: jinkun.hong jinkun.h...@rock-chips.com Add power domain drivers based on generic power domain for Rockchip platform, and support RK3288. Signed-off-by: Jack Dai jack@rock-chips.com Signed-off-by: