Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Honggang LI
On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > From Avihai, > > Relaxed Ordering is a PCIe mechanism that relaxes the strict ordering > imposed on PCI transactions, and thus, can improve performance. > > Until now, relaxed ordering could be set only

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

2018-03-15 Thread Honggang LI
On Thu, Mar 15, 2018 at 08:47:44AM -0400, Hal Rosenstock wrote: > On 3/15/2018 8:43 AM, Honggang LI wrote: > > On Thu, Mar 15, 2018 at 08:32:02AM -0400, Hal Rosenstock wrote: > >> On 3/15/2018 8:01 AM, Hal Rosenstock wrote: > >>> On 3/15/2018 5:02 AM, Honggang LI w

[PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X

2018-03-15 Thread Honggang LI
From: Honggang Li commit f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE"). Before this patch applied, the mlx5_ib driver set default active_width and active_speed to IB_WIDTH_4X and IB_SPEED_QDR. When the RoCE port is down, the RoCE port did not neg

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

2018-03-15 Thread Honggang LI
On Thu, Mar 15, 2018 at 08:32:02AM -0400, Hal Rosenstock wrote: > On 3/15/2018 8:01 AM, Hal Rosenstock wrote: > > On 3/15/2018 5:02 AM, Honggang LI wrote: > >> From: Honggang Li > >> > >> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

2018-03-15 Thread Honggang LI
On Thu, Mar 15, 2018 at 08:01:08AM -0400, Hal Rosenstock wrote: > On 3/15/2018 5:02 AM, Honggang LI wrote: > > From: Honggang Li > > > > commit f1b65df5a232 ("IB/mlx5: Add support for active_width and > > active_speed in RoCE"). Before this patch applie

[PATCH 0/2] IB/core: Set invalid active widths to 1X when port is not active

2018-03-15 Thread Honggang LI
From: Honggang Li Before the mlx5 RoCE port negotiate the active rate and width with remote side, the mlx5_ib driver set them to zero. The tool 'ibstat' of 'infiniband-diags' package will panic as it read invalid width from the sys file. Set the active widths to lowest

[PATCH 1/2] IB/core: Set speed string to SDR for invalid active rates

2018-03-15 Thread Honggang LI
From: Honggang Li commit f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE"). Before this patch applied, the mlx5_ib driver set default active_width and active_speed to IB_WIDTH_4X and IB_SPEED_QDR. Now, the active_width and active_speed are zeros if the Ro

[PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

2018-03-15 Thread Honggang LI
From: Honggang Li commit f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE"). Before this patch applied, the mlx5_ib driver set default active_width and active_speed to IB_WIDTH_4X and IB_SPEED_QDR. When the RoCE port is down, the RoCE port did not neg

[PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

2017-05-11 Thread Honggang LI
From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. Otherwise kernel panic. [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE): mlx5_ib0.8006: link becomes ready [ 28.156790] BUG: unable to handle

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Honggang LI
On Tue, Apr 25, 2017 at 01:32:59PM +0300, Or Gerlitz wrote: > On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: > > From: Honggang Li > > > > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which > > is smaller than IPOIB_HARD_LEN. ipoib_hard_heade

[PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Honggang LI
From: Honggang Li Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the size of headroom to avoid skb_under_panic. [ 122.871493] ipoib_hard_header: skb->head= 8808179d9400, skb->data= 880817

[PATCH] RDMA/cxgb3: device driver frees DMA memory with different size

2016-05-22 Thread Honggang LI
From: Honggang Li [ 598.852037] [ cut here ] [ 598.856698] WARNING: at lib/dma-debug.c:887 check_unmap+0xf8/0x920() [ 598.863079] cxgb3 :01:00.0: DMA-API: device driver frees DMA memory with different size [device address=0x0331] [map size=17 bytes

[linux-next PATCH] IB/core: change rdma_gid2ip into void function as it always return zero

2015-04-29 Thread Honggang Li
Signed-off-by: Honggang Li --- drivers/infiniband/core/addr.c | 13 +++-- include/rdma/ib_addr.h | 3 +-- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index f80da50..38339d2 100644 --- a/drivers

[PATCH linux-next v5] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-15 Thread Honggang Li
- cosnole log - Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size to firmware') Signed-off-by: Honggang Li --- .../net/ethernet/mellanox/mlx5/core/pagealloc.c| 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH linux-next v3] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-15 Thread Honggang Li
7;s comment. ere...@dev.mellanox.co.il Fixes: 5aa7add8f14b ("infiniband/ipoib: implement ndo_get_iflink") Signed-off-by: Honggang Li --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/

Re: [PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-15 Thread Honggang LI
On Wed, Apr 15, 2015 at 08:27:23AM +0300, Or Gerlitz wrote: > On 4/15/2015 6:19 AM, Honggang Li wrote: > >Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to firmware) > > This isn't the way to write the fix note, do it that way > > Fixes: bf

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-15 Thread Honggang LI
On Tue, Apr 14, 2015 at 07:30:03PM +0300, Erez Shitrit wrote: > > @@ -846,7 +846,10 @@ static int ipoib_get_iflink(const struct net_device > > *dev) > > { > > struct ipoib_dev_priv *priv = netdev_priv(dev); > > > > - return priv->parent->ifindex; > > + if (priv && priv->parent

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang LI
There was network accident in the office. I can't find this email in public mailing list. So, I reset it. If you had recived this, please ignore it. thanks On Wed, Apr 15, 2015 at 01:16:40PM +0800, Honggang LI wrote: > On Tue, Apr 14, 2015 at 07:30:03PM +0300, Erez Shitr

[PATCH linux-next v4] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Honggang Li
- cosnole log - Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size to firmware') Signed-off-by: Honggang Li --- drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Honggang Li
- cosnole log - Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to firmware) Signed-off-by: Honggang Li --- .../net/ethernet/mellanox/mlx5/core/pagealloc.c| 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx

Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 10:23:16PM +0300, Eli Cohen wrote: > On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote: > > @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr) > > static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id) > &

[PATCH] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang Li
;8b> 80 20 01 00 00 c9 c3 0f 1f 84 00 00 00 00 00 55 48 89 e5 66 RIP [] ipoib_get_iflink+0x10/0x20 [ib_ipoib] RSP CR2: 0120 ---[ end trace a8610f6e9640eb85 ]--- Fixes: 5aa7add8f14b ("infiniband/ipoib: implement ndo_get_iflink") Signed-off-by: Honggang Li --- dr

[PATCH linux-next v2] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang Li
f88026eb1c7c0, priv->parent = (null) ipoib_get_iflink dev = 880225c8a000, priv = 880225c8a7c0, priv->parent = (null) ipoib_get_iflink dev = 880225c8a000, priv = 880225c8a7c0, priv->parent = (null) ----- console log --- Hong

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 05:49:55PM +0200, Nicolas Dichtel wrote: > Le 14/04/2015 17:44, Honggang LI a écrit : > >On Tue, Apr 14, 2015 at 08:34:33AM -0700, Eric Dumazet wrote: > >>On Tue, 2015-04-14 at 23:20 +0800, Honggang Li wrote: > >>>Starting monitoring for VG v

Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 05:37:57PM +0200, Andrew Lunn wrote: > > > > > And I suspect that it is the same for ipvlan and dsa. > > I agree about DSA. I don't see any way this could happen. > > Andrew I only keep the ipoib patch and drop the rest patches. thanks -- To unsubscribe from this list:

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 08:34:33AM -0700, Eric Dumazet wrote: > On Tue, 2015-04-14 at 23:20 +0800, Honggang Li wrote: > > Starting monitoring for VG vg_rdma01: 3 logical volume(s) in volume > > group "vg_rdma01" monitored > > [ OK ] > > > &g

Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 04:26:27PM +0100, Patrick McHardy wrote: > > That is completely useless. vlan (=netdev_priv) can not be NULL as > netdev_priv() never returns NULL and vlan->lowerdev is always valid > because a macvlan wouldn't make much sense otherwise. OK, please drop this patch. thanks

[PATCH linux-next 4/4] net/dsa: fix possible NULL pointer dereference in dsa_slave_get_iflink

2015-04-14 Thread Honggang Li
Signed-off-by: Honggang Li --- net/dsa/slave.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 827cda56..070b599 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -59,7 +59,10 @@ static int dsa_slave_get_iflink(const struct

[PATCH linux-next 2/4] ipvlan: fix possible NULL pointer dereference in ipvlan_get_iflink

2015-04-14 Thread Honggang Li
Signed-off-by: Honggang Li --- drivers/net/ipvlan/ipvlan_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 77b92a0..479fcf7 100644 --- a/drivers/net/ipvlan/ipvlan_main.c +++ b/drivers/net

[PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Honggang Li
Signed-off-by: Honggang Li --- drivers/net/macvlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index b227a13..1e59f39 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -998,7 +998,9 @@ static int

[PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang Li
;8b> 80 20 01 00 00 c9 c3 0f 1f 84 00 00 00 00 00 55 48 89 e5 66 RIP [] ipoib_get_iflink+0x10/0x20 [ib_ipoib] RSP CR2: 0120 ---[ end trace a8610f6e9640eb85 ]--- Signed-off-by: Honggang Li --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 5 - 1 file changed, 4 insertion

[PATCH linux-next 0/4] fix possile NULL pointer dereference in ndo_get_iflink callback functions

2015-04-14 Thread Honggang Li
single patch. However, those files have be maintained by different maintainers. So, I split it for review. It also will be convenient to remove one or more patches with the rest not be affected. Honggang Li (4): infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink ipvlan

[PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-13 Thread Honggang Li
- cosnole log - Signed-off-by: Honggang Li --- drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c i

Re: [linux-next PATCH] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-13 Thread Honggang LI
On Mon, Apr 13, 2015 at 06:47:11AM +, Eli Cohen wrote: > On Mon, Apr 13, 2015 at 08:33:33AM +0800, Honggang LI wrote: > > > > Yes, replaced all of the PAGE_MASK in the file. Please see attched new > > patch. > > > > I think you need to send the new patch

Re: [linux-next PATCH] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-12 Thread Honggang LI
UM_4K_IN_PAGE, will reserve the high four bytes. So, free_4k/find_fw_page will randomly failed. thanks > int err; > int nid = dev_to_node(&dev->pdev->dev); > > -- > 1.8.3.1 > >From 393cfb80c10e8e3a89baf7d235dde7aa3c64837d Mon Sep 17 00:00:00 2001 From:

[linux-next PATCH] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-12 Thread Honggang Li
- cosnole log - Signed-off-by: Honggang Li --- drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c index df

[linux-next PATCH] staging: unisys/virthba/virthba.c print u64 with %llu

2014-08-19 Thread Honggang Li
] drivers/staging/unisys/virthba/virthba.o Signed-off-by: Honggang Li --- drivers/staging/unisys/virthba/virthba.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba/virthba.c index 049eeab..53615df

[linux-next PATCH] print u64 with %llu

2014-08-19 Thread Honggang Li
e CHECKPATCH in MAINTAINERS. [real@name linux-next]$ Honggang Li (1): staging: unisys/virthba/virthba.c print u64 with %llu drivers/staging/unisys/virthba/virthba.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line "

[linux-next PATCH] print u64 with %llu

2014-08-19 Thread Honggang Li
There are printk format issue and coding style issue for the lines changed by this patch. This patch only fix the format issue. Please take those coding style errors as false positives for this patch. Honggang Li (1): staging: unisys/virthba/virthba.c print u64 with %llu drivers/staging

[linux-next PATCH] Free percpu allocation info for uniprocessor system

2014-08-12 Thread Honggang Li
align=32 |-- Recent UML is broken because of the commit: "resource: provide new functions to walk through resources" As a result, the patch had been tested on x86 and x86_64 UML virtual machines based on linux-next-v3.16. Honggang Li (1): Free percpu

[PATCH] Free percpu allocation info for uniprocessor system

2014-08-12 Thread Honggang Li
Currently, only SMP system free the percpu allocation info. Uniprocessor system should free it too. For example, one x86 UML virtual machine with 256MB memory, UML kernel wastes one page memory. Signed-off-by: Honggang Li --- mm/percpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm

[PATCH 0/2 linux-next] coding style clean up for lustre/osc/osc_dev.c

2014-06-12 Thread Honggang Li
Patches clean up coding style issue of the file: linux-next/drivers/staging/lustre/lustre/osc/osc_dev.c Honggang Li (2): lustre/osc/osc_dev.c remove space between sizeof and open parenthesis lustre/osc/osc_dev.c add a blank line after declarations drivers/staging/lustre/lustre/osc/osc_dev.c

[PATCH 2/2] lustre/osc/osc_dev.c add a blank line after declarations

2014-06-12 Thread Honggang Li
Signed-off-by: Honggang Li --- drivers/staging/lustre/lustre/osc/osc_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/lustre/lustre/osc/osc_dev.c b/drivers/staging/lustre/lustre/osc/osc_dev.c index 5249e66..048a5a5 100644 --- a/drivers/staging/lustre/lustre/osc

[PATCH 1/2] lustre/osc/osc_dev.c remove space between sizeof and open parenthesis

2014-06-12 Thread Honggang Li
Signed-off-by: Honggang Li --- drivers/staging/lustre/lustre/osc/osc_dev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_dev.c b/drivers/staging/lustre/lustre/osc/osc_dev.c index a7c1ec0..5249e66 100644 --- a/drivers

[PATCH linux-next] remove csum_partial_copy_generic_i386 to clean up exception table

2014-06-04 Thread Honggang Li
: Honggang Li (1): remove csum_partial_copy_generic_i386 to clean up exception table arch/x86/um/checksum_32.S | 239 -- 1 file changed, 239 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

[PATCH] remove csum_partial_copy_generic_i386 to clean up exception table

2014-06-04 Thread Honggang Li
arch/x86/um/checksum_32.S had been copy & paste from x86. When build x86 uml, csum_partial_copy_generic_i386 mess up the exception table. In fact, exception table dose not work in uml kernel. And csum_partial_copy_generic_i386 never been called. So, delete it. Signed-off-by: Honggan

Re: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-14 Thread Honggang LI
On 11/14/2013 09:43 PM, Venkat Venkatsubra wrote: > > -Original Message- > From: Honggang LI [mailto:ho...@redhat.com] > Sent: Wednesday, November 13, 2013 6:56 PM > To: Josh Hunt; Venkat Venkatsubra > Cc: David Miller; jjo...@suse.com; LKML; net...@vger.kernel.org >

Re: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-13 Thread Honggang LI
On 11/14/2013 01:40 AM, Josh Hunt wrote: > On Wed, Nov 13, 2013 at 9:16 AM, Venkat Venkatsubra > wrote: >> >> -Original Message- >> From: Josh Hunt [mailto:joshhun...@gmail.com] >> Sent: Tuesday, November 12, 2013 10:25 PM >> To: David Miller >> Cc: jjo...@suse.com; LKML; Venkat Venkatsubr