Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-02-03 Thread Hridya Valsaraju
On Wed, Feb 3, 2021 at 2:25 AM Daniel Vetter wrote: > > On Mon, Feb 01, 2021 at 01:02:30PM -0800, Hridya Valsaraju wrote: > > On Mon, Feb 1, 2021 at 10:37 AM Daniel Vetter wrote: > > > > > > On Thu, Jan 28, 2021 at 1:03 PM Sumit Semwal > > > wrote: >

Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-02-01 Thread Hridya Valsaraju
i Hridya, > > > > > > > > On Wed, 27 Jan 2021 at 17:36, Greg KH > > > > wrote: > > > >> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: > > > >>> This patch allows statistics to be enabled for each DMA-BUF in >

Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-02-01 Thread Hridya Valsaraju
On Thu, Jan 28, 2021 at 6:35 AM Sumit Semwal wrote: > > Hi Simon, > > On Thu, 28 Jan 2021 at 20:01, Simon Ser wrote: > > > > On Thursday, January 28th, 2021 at 1:03 PM, Sumit Semwal > > wrote: > > > > > Since he didn't comment over Hridya's last clarification about the > > > tracepoints to trac

Re: [PATCH v4 3/4] dt-bindings: reserved-memory: Make DMA-BUF CMA heap DT-configurable

2021-01-27 Thread Hridya Valsaraju
iguous Memory Allocator (CMA) and > > + supports bulk allocation of fixed size pages. > > + > > +maintainers: > > + - Hyesoo Yu > > + - John Stultz > > + - Minchan Kim > > + - Hridya Valsaraju > > + > > + > > +properties: > >

[PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-26 Thread Hridya Valsaraju
-review.googlesource.com/c/platform/system/memory/libmeminfo/+/1549734 Signed-off-by: Hridya Valsaraju Reported-by: kernel test robot --- Changes in v3: Fix a warning reported by the kernel test robot. Changes in v2: -Move statistics to /sys/kernel/dmabuf/buffers in oder to allow addition of other DMA-BUF

Re: [Linaro-mm-sig] [PATCH v2] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-20 Thread Hridya Valsaraju
On Wed, Jan 20, 2021 at 4:42 AM Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 1:22 PM Christian König > wrote: > > > > Am 19.01.21 um 23:57 schrieb Hridya Valsaraju: > > > This patch allows statistics to be enabled for each DMA-BUF in >

Re: [Linaro-mm-sig] [PATCH v2] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-20 Thread Hridya Valsaraju
On Wed, Jan 20, 2021 at 4:22 AM Christian König wrote: > > Am 19.01.21 um 23:57 schrieb Hridya Valsaraju: > > This patch allows statistics to be enabled for each DMA-BUF in > > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. > > > > The following stats wi

[PATCH v2] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-19 Thread Hridya Valsaraju
-review.googlesource.com/c/platform/system/memory/libmeminfo/+/1549734 Signed-off-by: Hridya Valsaraju --- Changes in v2: -Move statistics to /sys/kernel/dmabuf/buffers in oder to allow addition of other DMA-BUF-related sysfs stats in future. Based on feedback from Daniel Vetter. -Each attachment has its own

Re: [PATCH v3 3/4] dt-bindings: reserved-memory: Make DMA-BUF CMA heap DT-configurable

2021-01-14 Thread Hridya Valsaraju
> > > > Signed-off-by: Hyesoo Yu > > Signed-off-by: Minchan Kim > > Signed-off-by: Hridya Valsaraju > > Change-Id: I8fb231e5a8360e2d8f65947e155b12aa664dde01 > > Drop this. > > > --- > > .../reserved-memory/dma_heap_chunk.yaml | 58 ++

Re: [PATCH v3 3/4] dt-bindings: reserved-memory: Make DMA-BUF CMA heap DT-configurable

2021-01-13 Thread Hridya Valsaraju
ulk allocation of higher order pages. > > > > Signed-off-by: Hyesoo Yu > > Signed-off-by: Minchan Kim > > Signed-off-by: Hridya Valsaraju > > Change-Id: I8fb231e5a8360e2d8f65947e155b12aa664dde01 > > --- > > .../reserved-memory/dma_heap_chunk.yaml | 58 +++

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-11 Thread Hridya Valsaraju
Thank you Christian! On Fri, Dec 11, 2020 at 12:03 AM Christian König wrote: > > Am 10.12.20 um 23:41 schrieb Hridya Valsaraju: > > Thanks again for the reviews! > > > > On Thu, Dec 10, 2020 at 3:03 AM Christian König > > wrote: > >> Am 10.12.20 um 11:5

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Hridya Valsaraju
n Thu, Dec 10, 2020 at 10:58:50AM +0100, Christian König wrote: > >>>> In general a good idea, but I have a few concern/comments here. > >>>> > >>>> Am 10.12.20 um 05:43 schrieb Hridya Valsaraju: > >>>>> This patch allows statistics

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Hridya Valsaraju
Thank you for the reviews Greg, Christian and Daniel! On Thu, Dec 10, 2020 at 1:59 AM Christian König wrote: > > In general a good idea, but I have a few concern/comments here. > > Am 10.12.20 um 05:43 schrieb Hridya Valsaraju: > > This patch allows statistics to be enabled f

[PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-09 Thread Hridya Valsaraju
/ Signed-off-by: Hridya Valsaraju --- Documentation/ABI/testing/sysfs-kernel-dmabuf | 32 drivers/dma-buf/Kconfig | 11 ++ drivers/dma-buf/Makefile | 1 + drivers/dma-buf/dma-buf-sysfs-stats.c | 162 ++ drivers/dma-buf/dma

Re: [PATCH] staging: ion: remove from the tree

2020-08-27 Thread Hridya Valsaraju
he Android kernel developers) who are both annoyed at > > > > > the current situation. Because of this problem, just drop the > > > > > in-kernel > > > > > copy of the ion code now, as it's not used, and is only causing > > > > > problems &g

Re: [PATCH] staging: ion: fix spelling mistake in function name "detatch" -> "detach"

2020-08-06 Thread Hridya Valsaraju
On Wed, Aug 5, 2020 at 4:26 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in the function name ion_dma_buf_detatch. > Fix it by removing the extraneous t. > > Signed-off-by: Colin Ian King > --- Thanks Colin! Acked-by: Hridya Valsar

Re: [PATCH] binder: prevent transactions to context manager from its own process.

2019-10-14 Thread Hridya Valsaraju
On Fri, Oct 11, 2019 at 3:11 PM Jann Horn wrote: > > On Fri, Oct 11, 2019 at 11:59 PM Jann Horn wrote: > > (I think you could also let A receive a handle > > to itself and then transact with itself, but I haven't tested that.) > > Ignore this sentence, that's obviously wrong because same-binder_p

Re: [PATCH] binder: prevent UAF read in print_binder_transaction_log_entry()

2019-10-08 Thread Hridya Valsaraju
l.com > Cc: Joel Fernandes > Cc: Todd Kjos > Cc: Hridya Valsaraju > Signed-off-by: Christian Brauner Reviewed-by: Hridya Valsaraju Thank you for sending out this fix Christian! Regards, Hridya > --- > drivers/android/binder.c | 4 +++- > drivers/android/binder_

Re: UAF read in print_binder_transaction_log_entry() on ANDROID_BINDERFS kernels

2019-10-07 Thread Hridya Valsaraju
Thank you for letting us know about the issue Jann. I will work on a fix and send out the same for review once ready. Regards, Hridya On Mon, Oct 7, 2019 at 2:04 PM Todd Kjos wrote: > > +Hridya Valsaraju > > > On Mon, Oct 7, 2019 at 1:50 PM Jann Horn wrote: > > > >

Re: [PATCH v3 0/4] Add binder state and statistics to binderfs

2019-09-27 Thread Hridya Valsaraju
On Fri, Sep 27, 2019 at 6:19 AM Christian Brauner wrote: > > On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote: > > Currently, the only way to access binder state and > > statistics is through debugfs. We need a way to > > access the same even when debugfs i

Re: [PATCH v3 0/4] Add binder state and statistics to binderfs

2019-09-04 Thread Hridya Valsaraju
On Wed, Sep 4, 2019 at 7:20 AM Joel Fernandes wrote: > > On September 4, 2019 7:19:35 AM EDT, Christian Brauner > wrote: > >On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote: > >> Currently, the only way to access binder state and > >> statistics

Re: [PATCH v3 0/4] Add binder state and statistics to binderfs

2019-09-04 Thread Hridya Valsaraju
wrote: > > > >On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote: > > > >> Currently, the only way to access binder state and > > > >> statistics is through debugfs. We need a way to > > > >> access the same even when debugfs is n

[PATCH v3 2/4] binder: Add stats, state and transactions files

2019-09-03 Thread Hridya Valsaraju
Christian Brauner Signed-off-by: Hridya Valsaraju --- Changes in v3: - Use set_nlink() instead of inc_nlink() in binderfs_create_dir() as per Christian Brauner. - Replace parent->d_inode usage with d_inode(parent) in binderfs_create_file() for consistency as per Christian Brauner.

[PATCH v3 3/4] binder: Make transaction_log available in binderfs

2019-09-03 Thread Hridya Valsaraju
fs/binder_logs/transaction_log This change provides an alternate option to access these files when debugfs is not mounted. Acked-by: Christian Brauner Signed-off-by: Hridya Valsaraju --- Changes in v2: -Consistent variable naming accross functions as per Christian Brauner. drivers/

[PATCH v3 4/4] binder: Add binder_proc logging to binderfs

2019-09-03 Thread Hridya Valsaraju
in debugfs. If a binderfs instance is mounted at path /dev/binderfs, this file would be present at /dev/binderfs/binder_logs/proc. This change provides an alternate way to access this file when debugfs is not mounted. Acked-by: Christian Brauner Signed-off-by: Hridya Valsaraju --- Cha

[PATCH v3 1/4] binder: add a mount option to show global stats

2019-09-03 Thread Hridya Valsaraju
tial user namespace. An attempt to use the option to mount a binderfs instance in another user namespace will return an EPERM error. Signed-off-by: Hridya Valsaraju --- Changes in v2: - Improve error check in binderfs_parse_mount_opts() as per Greg Kroah-Hartman. - Change pr_info()

[PATCH v3 0/4] Add binder state and statistics to binderfs

2019-09-03 Thread Hridya Valsaraju
/kernel/debug/binder/transaction_log /sys/kernel/debug/binder/transactions Hridya Valsaraju (4): binder: add a mount option to show global stats binder: Add stats, state and transactions files binder: Make transaction_log available in binderfs binder: Add binder_proc logging to binderfs driv

Re: [PATCH v2 3/4] binder: Make transaction_log available in binderfs

2019-08-30 Thread Hridya Valsaraju
On Fri, Aug 30, 2019 at 4:34 AM Christian Brauner wrote: > > On Thu, Aug 29, 2019 at 02:18:11PM -0700, Hridya Valsaraju wrote: > > Currently, the binder transaction log files 'transaction_log' > > and 'failed_transaction_log' live in debugfs at the followin

Re: [PATCH v2 2/4] binder: Add stats, state and transactions files

2019-08-30 Thread Hridya Valsaraju
On Fri, Aug 30, 2019 at 4:32 AM Christian Brauner wrote: > > On Thu, Aug 29, 2019 at 02:18:10PM -0700, Hridya Valsaraju wrote: > > The following binder stat files currently live in debugfs. > > > > /sys/kernel/debug/binder/state > > /sys/kernel/debug/binder/stat

[PATCH v2 4/4] binder: Add binder_proc logging to binderfs

2019-08-29 Thread Hridya Valsaraju
in debugfs. If a binderfs instance is mounted at path /dev/binderfs, this file would be present at /dev/binderfs/binder_logs/proc. This change provides an alternate way to access this file when debugfs is not mounted. Signed-off-by: Hridya Valsaraju --- Changes in v2: - Consistent variable nam

[PATCH v2 1/4] binder: add a mount option to show global stats

2019-08-29 Thread Hridya Valsaraju
tial user namespace. An attempt to use the option to mount a binderfs instance in another user namespace will return an EPERM error. Signed-off-by: Hridya Valsaraju --- Changes in v2: - Improve error check in binderfs_parse_mount_opts() as per Greg Kroah-Hartman. - Change pr_info()

[PATCH v2 2/4] binder: Add stats, state and transactions files

2019-08-29 Thread Hridya Valsaraju
a binderfs instance is mounted at path /dev/binderfs, the above files will be available at the following locations: /dev/binderfs/binder_logs/state /dev/binderfs/binder_logs/stats /dev/binderfs/binder_logs/transactions This provides a way to access them even when debugfs is not mounted. Signed-off-

[PATCH v2 0/4] Add binder state and statistics to binderfs

2019-08-29 Thread Hridya Valsaraju
/kernel/debug/binder/transaction_log /sys/kernel/debug/binder/transactions Hridya Valsaraju (4): binder: add a mount option to show global stats binder: Add stats, state and transactions files binder: Make transaction_log available in binderfs binder: Add binder_proc logging to binderfs driv

[PATCH v2 3/4] binder: Make transaction_log available in binderfs

2019-08-29 Thread Hridya Valsaraju
fs/binder_logs/transaction_log This change provides an alternate option to access these files when debugfs is not mounted. Signed-off-by: Hridya Valsaraju --- Changes in v2: -Consistent variable naming accross functions as per Christian Brauner. drivers/android/binder.c | 34 +-

Re: [PATCH 4/4] binder: Add binder_proc logging to binderfs

2019-08-28 Thread Hridya Valsaraju
On Wed, Aug 28, 2019 at 9:21 AM Todd Kjos wrote: > > On Wed, Aug 28, 2019 at 6:08 AM Christian Brauner > wrote: > > > > On Tue, Aug 27, 2019 at 01:41:52PM -0700, Hridya Valsaraju wrote: > > > Currently /sys/kernel/debug/binder/proc contains > > > the de

Re: [PATCH 2/4] binder: Add stats, state and transactions files

2019-08-28 Thread Hridya Valsaraju
On Wed, Aug 28, 2019 at 5:58 AM Christian Brauner wrote: > > On Tue, Aug 27, 2019 at 01:41:50PM -0700, Hridya Valsaraju wrote: > > The following binder stat files currently live in debugfs. > > > > /sys/kernel/debug/binder/state > > /sys/kernel/debug/binder/stat

Re: [PATCH 1/4] binder: add a mount option to show global stats

2019-08-28 Thread Hridya Valsaraju
On Wed, Aug 28, 2019 at 5:39 AM Christian Brauner wrote: > > On Wed, Aug 28, 2019 at 11:22:37AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Aug 27, 2019 at 01:41:49PM -0700, Hridya Valsaraju wrote: > > > Currently, all binder state and statistics live in debugfs. > >

[PATCH 3/4] binder: Make transaction_log available in binderfs

2019-08-27 Thread Hridya Valsaraju
fs/binder_logs/transaction_log This change provides an alternate option to access these files when debugfs is not mounted. Signed-off-by: Hridya Valsaraju --- drivers/android/binder.c | 34 +-- drivers/android/binder_internal.h | 30 +

[PATCH 4/4] binder: Add binder_proc logging to binderfs

2019-08-27 Thread Hridya Valsaraju
in debugfs. If a binderfs instance is mounted at path /dev/binderfs, this file would be present at /dev/binderfs/binder_logs/proc. This change provides an alternate way to access this file when debugfs is not mounted. Signed-off-by: Hridya Valsaraju --- drivers/android/binder.c

[PATCH 2/4] binder: Add stats, state and transactions files

2019-08-27 Thread Hridya Valsaraju
a binderfs instance is mounted at path /dev/binderfs, the above files will be available at the following locations: /dev/binderfs/binder_logs/state /dev/binderfs/binder_logs/stats /dev/binderfs/binder_logs/transactions This provides a way to access them even when debugfs is not mounted. Signed-off-

[PATCH 1/4] binder: add a mount option to show global stats

2019-08-27 Thread Hridya Valsaraju
tial user namespace. An attempt to use the option to mount a binderfs instance in another user namespace will return an EPERM error. Signed-off-by: Hridya Valsaraju --- drivers/android/binderfs.c | 47 -- 1 file changed, 45 insertions(+), 2 deletions(-

[PATCH 0/4] Add binder state and statistics to binderfs

2019-08-27 Thread Hridya Valsaraju
/kernel/debug/binder/transaction_log /sys/kernel/debug/binder/transactions Hridya Valsaraju (4): binder: add a mount option to show global stats binder: Add stats, state and transactions files binder: Make transaction_log available in binderfs binder: Add binder_proc logging to binderfs driv

Re: [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured

2019-08-09 Thread Hridya Valsaraju
On Fri, Aug 9, 2019 at 11:22 AM Christian Brauner wrote: > > On Fri, Aug 09, 2019 at 04:50:16PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 08, 2019 at 03:27:25PM -0700, Hridya Valsaraju wrote: > > > Currently, since each binderfs instance needs its own > > >

Re: [PATCH v3 2/2] binder: Validate the default binderfs device names.

2019-08-09 Thread Hridya Valsaraju
On Fri, Aug 9, 2019 at 11:14 AM Christian Brauner wrote: > > On Fri, Aug 09, 2019 at 04:55:08PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 08, 2019 at 03:27:26PM -0700, Hridya Valsaraju wrote: > > > Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. &g

[PATCH v3 0/2] Add default binderfs devices

2019-08-08 Thread Hridya Valsaraju
devices for each binderfs instance by creating them automatically. Hridya Valsaraju (2): binder: Add default binder devices through binderfs when configured binder: Validate the default binderfs device names. drivers/android/binder.c | 5 +++-- drivers/android/binder_internal.h | 2

[PATCH v3 1/2] binder: Add default binder devices through binderfs when configured

2019-08-08 Thread Hridya Valsaraju
Signed-off-by: Christian Brauner Signed-off-by: Hridya Valsaraju --- Changes in v2: - Updated commit message as per Greg Kroah-Hartman. - Removed new module parameter creation as per Greg Kroah-Hartman/Christian Brauner. - Refactored device name length check into a new patch as per Greg Kroah

[PATCH v3 2/2] binder: Validate the default binderfs device names.

2019-08-08 Thread Hridya Valsaraju
: Hridya Valsaraju --- drivers/android/binderfs.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c index aee46dd1be91..55c5adb87585 100644 --- a/drivers/android/binderfs.c +++ b/drivers/android/binderfs.c @@ -570,6 +570,18

Re: [PATCH v2 1/2] binder: Add default binder devices through binderfs when configured

2019-08-07 Thread Hridya Valsaraju
On Wed, Aug 7, 2019 at 4:02 AM Dan Carpenter wrote: > > On Tue, Aug 06, 2019 at 11:40:05AM -0700, Hridya Valsaraju wrote: > > @@ -467,6 +466,9 @@ static int binderfs_fill_super(struct super_block *sb, > > void *data, int silent) > > int ret; > >

[PATCH v2 1/2] binder: Add default binder devices through binderfs when configured

2019-08-06 Thread Hridya Valsaraju
Signed-off-by: Christian Brauner Signed-off-by: Hridya Valsaraju --- Changes in v2: - Updated commit message as per Greg Kroah-Hartman. - Removed new module parameter creation as per Greg Kroah-Hartman/Christian Brauner. - Refactored device name length check into a new patch as per Greg Kroah

[PATCH v2 0/2] Add default binderfs devices

2019-08-06 Thread Hridya Valsaraju
devices for each binderfs instance by creating them automatically. Hridya Valsaraju (2): binder: Add default binder devices through binderfs when configured binder: Validate the default binderfs device names. drivers/android/binder.c | 5 +++-- drivers/android/binder_internal.h | 2

[PATCH v2 2/2] binder: Validate the default binderfs device names.

2019-08-06 Thread Hridya Valsaraju
: Hridya Valsaraju --- drivers/android/binderfs.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c index 886b4e0f482f..52c8bd361906 100644 --- a/drivers/android/binderfs.c +++ b/drivers/android/binderfs.c @@ -572,6 +572,18

Re: [PATCH] Add default binder devices through binderfs when configured

2019-08-02 Thread Hridya Valsaraju
On Fri, Aug 2, 2019 at 8:06 AM Christian Brauner wrote: > > On Fri, Aug 02, 2019 at 08:18:38AM +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 01, 2019 at 03:35:56PM -0700, Hridya Valsaraju wrote: > > > If CONFIG_ANDROID_BINDERFS is set, the default binder devic

[PATCH] Add default binder devices through binderfs when configured

2019-08-01 Thread Hridya Valsaraju
If CONFIG_ANDROID_BINDERFS is set, the default binder devices specified by CONFIG_ANDROID_BINDER_DEVICES are created in each binderfs instance instead of global devices being created by the binder driver. Co-developed-by: Christian Brauner Signed-off-by: Christian Brauner Signed-off-by: Hridya

[PATCH] binder: prevent transactions to context manager from its own process.

2019-07-15 Thread Hridya Valsaraju
manager. Reported-by: syzbot+8b3c354d33c4ac78b...@syzkaller.appspotmail.com Signed-off-by: Hridya Valsaraju --- drivers/android/binder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index e4d25ebec5be..89b9cedae088 100644 --- a