On Wed, Feb 3, 2021 at 2:25 AM Daniel Vetter wrote:
>
> On Mon, Feb 01, 2021 at 01:02:30PM -0800, Hridya Valsaraju wrote:
> > On Mon, Feb 1, 2021 at 10:37 AM Daniel Vetter wrote:
> > >
> > > On Thu, Jan 28, 2021 at 1:03 PM Sumit Semwal
> > > wrote:
>
i Hridya,
> > > >
> > > > On Wed, 27 Jan 2021 at 17:36, Greg KH
> > > > wrote:
> > > >> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote:
> > > >>> This patch allows statistics to be enabled for each DMA-BUF in
>
On Thu, Jan 28, 2021 at 6:35 AM Sumit Semwal wrote:
>
> Hi Simon,
>
> On Thu, 28 Jan 2021 at 20:01, Simon Ser wrote:
> >
> > On Thursday, January 28th, 2021 at 1:03 PM, Sumit Semwal
> > wrote:
> >
> > > Since he didn't comment over Hridya's last clarification about the
> > > tracepoints to trac
iguous Memory Allocator (CMA) and
> > + supports bulk allocation of fixed size pages.
> > +
> > +maintainers:
> > + - Hyesoo Yu
> > + - John Stultz
> > + - Minchan Kim
> > + - Hridya Valsaraju
> > +
> > +
> > +properties:
> >
-review.googlesource.com/c/platform/system/memory/libmeminfo/+/1549734
Signed-off-by: Hridya Valsaraju
Reported-by: kernel test robot
---
Changes in v3:
Fix a warning reported by the kernel test robot.
Changes in v2:
-Move statistics to /sys/kernel/dmabuf/buffers in oder to allow addition
of other DMA-BUF
On Wed, Jan 20, 2021 at 4:42 AM Daniel Vetter wrote:
>
> On Wed, Jan 20, 2021 at 1:22 PM Christian König
> wrote:
> >
> > Am 19.01.21 um 23:57 schrieb Hridya Valsaraju:
> > > This patch allows statistics to be enabled for each DMA-BUF in
>
On Wed, Jan 20, 2021 at 4:22 AM Christian König
wrote:
>
> Am 19.01.21 um 23:57 schrieb Hridya Valsaraju:
> > This patch allows statistics to be enabled for each DMA-BUF in
> > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS.
> >
> > The following stats wi
-review.googlesource.com/c/platform/system/memory/libmeminfo/+/1549734
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
-Move statistics to /sys/kernel/dmabuf/buffers in oder to allow addition
of other DMA-BUF-related sysfs stats in future. Based on feedback from
Daniel Vetter.
-Each attachment has its own
> >
> > Signed-off-by: Hyesoo Yu
> > Signed-off-by: Minchan Kim
> > Signed-off-by: Hridya Valsaraju
> > Change-Id: I8fb231e5a8360e2d8f65947e155b12aa664dde01
>
> Drop this.
>
> > ---
> > .../reserved-memory/dma_heap_chunk.yaml | 58 ++
ulk allocation of higher order pages.
> >
> > Signed-off-by: Hyesoo Yu
> > Signed-off-by: Minchan Kim
> > Signed-off-by: Hridya Valsaraju
> > Change-Id: I8fb231e5a8360e2d8f65947e155b12aa664dde01
> > ---
> > .../reserved-memory/dma_heap_chunk.yaml | 58 +++
Thank you Christian!
On Fri, Dec 11, 2020 at 12:03 AM Christian König
wrote:
>
> Am 10.12.20 um 23:41 schrieb Hridya Valsaraju:
> > Thanks again for the reviews!
> >
> > On Thu, Dec 10, 2020 at 3:03 AM Christian König
> > wrote:
> >> Am 10.12.20 um 11:5
n Thu, Dec 10, 2020 at 10:58:50AM +0100, Christian König wrote:
> >>>> In general a good idea, but I have a few concern/comments here.
> >>>>
> >>>> Am 10.12.20 um 05:43 schrieb Hridya Valsaraju:
> >>>>> This patch allows statistics
Thank you for the reviews Greg, Christian and Daniel!
On Thu, Dec 10, 2020 at 1:59 AM Christian König
wrote:
>
> In general a good idea, but I have a few concern/comments here.
>
> Am 10.12.20 um 05:43 schrieb Hridya Valsaraju:
> > This patch allows statistics to be enabled f
/
Signed-off-by: Hridya Valsaraju
---
Documentation/ABI/testing/sysfs-kernel-dmabuf | 32
drivers/dma-buf/Kconfig | 11 ++
drivers/dma-buf/Makefile | 1 +
drivers/dma-buf/dma-buf-sysfs-stats.c | 162 ++
drivers/dma-buf/dma
he Android kernel developers) who are both annoyed at
> > > > > the current situation. Because of this problem, just drop the
> > > > > in-kernel
> > > > > copy of the ion code now, as it's not used, and is only causing
> > > > > problems
&g
On Wed, Aug 5, 2020 at 4:26 AM Colin King wrote:
>
> From: Colin Ian King
>
> There is a spelling mistake in the function name ion_dma_buf_detatch.
> Fix it by removing the extraneous t.
>
> Signed-off-by: Colin Ian King
> ---
Thanks Colin!
Acked-by: Hridya Valsar
On Fri, Oct 11, 2019 at 3:11 PM Jann Horn wrote:
>
> On Fri, Oct 11, 2019 at 11:59 PM Jann Horn wrote:
> > (I think you could also let A receive a handle
> > to itself and then transact with itself, but I haven't tested that.)
>
> Ignore this sentence, that's obviously wrong because same-binder_p
l.com
> Cc: Joel Fernandes
> Cc: Todd Kjos
> Cc: Hridya Valsaraju
> Signed-off-by: Christian Brauner
Reviewed-by: Hridya Valsaraju
Thank you for sending out this fix Christian!
Regards,
Hridya
> ---
> drivers/android/binder.c | 4 +++-
> drivers/android/binder_
Thank you for letting us know about the issue Jann. I will work on a
fix and send out the same for review once ready.
Regards,
Hridya
On Mon, Oct 7, 2019 at 2:04 PM Todd Kjos wrote:
>
> +Hridya Valsaraju
>
>
> On Mon, Oct 7, 2019 at 1:50 PM Jann Horn wrote:
> >
> >
On Fri, Sep 27, 2019 at 6:19 AM Christian Brauner
wrote:
>
> On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote:
> > Currently, the only way to access binder state and
> > statistics is through debugfs. We need a way to
> > access the same even when debugfs i
On Wed, Sep 4, 2019 at 7:20 AM Joel Fernandes wrote:
>
> On September 4, 2019 7:19:35 AM EDT, Christian Brauner
> wrote:
> >On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote:
> >> Currently, the only way to access binder state and
> >> statistics
wrote:
> > > >On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote:
> > > >> Currently, the only way to access binder state and
> > > >> statistics is through debugfs. We need a way to
> > > >> access the same even when debugfs is n
Christian Brauner
Signed-off-by: Hridya Valsaraju
---
Changes in v3:
- Use set_nlink() instead of inc_nlink() in binderfs_create_dir() as
per Christian Brauner.
- Replace parent->d_inode usage with d_inode(parent) in
binderfs_create_file() for consistency as per Christian Brauner.
fs/binder_logs/transaction_log
This change provides an alternate option to access these files when
debugfs is not mounted.
Acked-by: Christian Brauner
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
-Consistent variable naming accross functions as per Christian Brauner.
drivers/
in debugfs.
If a binderfs instance is mounted at path /dev/binderfs,
this file would be present at /dev/binderfs/binder_logs/proc.
This change provides an alternate way to access this file when debugfs
is not mounted.
Acked-by: Christian Brauner
Signed-off-by: Hridya Valsaraju
---
Cha
tial user namespace.
An attempt to use the option to mount a binderfs instance in
another user namespace will return an EPERM error.
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
- Improve error check in binderfs_parse_mount_opts() as per Greg
Kroah-Hartman.
- Change pr_info()
/kernel/debug/binder/transaction_log
/sys/kernel/debug/binder/transactions
Hridya Valsaraju (4):
binder: add a mount option to show global stats
binder: Add stats, state and transactions files
binder: Make transaction_log available in binderfs
binder: Add binder_proc logging to binderfs
driv
On Fri, Aug 30, 2019 at 4:34 AM Christian Brauner
wrote:
>
> On Thu, Aug 29, 2019 at 02:18:11PM -0700, Hridya Valsaraju wrote:
> > Currently, the binder transaction log files 'transaction_log'
> > and 'failed_transaction_log' live in debugfs at the followin
On Fri, Aug 30, 2019 at 4:32 AM Christian Brauner
wrote:
>
> On Thu, Aug 29, 2019 at 02:18:10PM -0700, Hridya Valsaraju wrote:
> > The following binder stat files currently live in debugfs.
> >
> > /sys/kernel/debug/binder/state
> > /sys/kernel/debug/binder/stat
in debugfs.
If a binderfs instance is mounted at path /dev/binderfs,
this file would be present at /dev/binderfs/binder_logs/proc.
This change provides an alternate way to access this file when debugfs
is not mounted.
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
- Consistent variable nam
tial user namespace.
An attempt to use the option to mount a binderfs instance in
another user namespace will return an EPERM error.
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
- Improve error check in binderfs_parse_mount_opts() as per Greg
Kroah-Hartman.
- Change pr_info()
a binderfs
instance is mounted at path /dev/binderfs, the above files will be
available at the following locations:
/dev/binderfs/binder_logs/state
/dev/binderfs/binder_logs/stats
/dev/binderfs/binder_logs/transactions
This provides a way to access them even when debugfs is not mounted.
Signed-off-
/kernel/debug/binder/transaction_log
/sys/kernel/debug/binder/transactions
Hridya Valsaraju (4):
binder: add a mount option to show global stats
binder: Add stats, state and transactions files
binder: Make transaction_log available in binderfs
binder: Add binder_proc logging to binderfs
driv
fs/binder_logs/transaction_log
This change provides an alternate option to access these files when
debugfs is not mounted.
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
-Consistent variable naming accross functions as per Christian Brauner.
drivers/android/binder.c | 34 +-
On Wed, Aug 28, 2019 at 9:21 AM Todd Kjos wrote:
>
> On Wed, Aug 28, 2019 at 6:08 AM Christian Brauner
> wrote:
> >
> > On Tue, Aug 27, 2019 at 01:41:52PM -0700, Hridya Valsaraju wrote:
> > > Currently /sys/kernel/debug/binder/proc contains
> > > the de
On Wed, Aug 28, 2019 at 5:58 AM Christian Brauner
wrote:
>
> On Tue, Aug 27, 2019 at 01:41:50PM -0700, Hridya Valsaraju wrote:
> > The following binder stat files currently live in debugfs.
> >
> > /sys/kernel/debug/binder/state
> > /sys/kernel/debug/binder/stat
On Wed, Aug 28, 2019 at 5:39 AM Christian Brauner
wrote:
>
> On Wed, Aug 28, 2019 at 11:22:37AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Aug 27, 2019 at 01:41:49PM -0700, Hridya Valsaraju wrote:
> > > Currently, all binder state and statistics live in debugfs.
> >
fs/binder_logs/transaction_log
This change provides an alternate option to access these files when
debugfs is not mounted.
Signed-off-by: Hridya Valsaraju
---
drivers/android/binder.c | 34 +--
drivers/android/binder_internal.h | 30 +
in debugfs.
If a binderfs instance is mounted at path /dev/binderfs,
this file would be present at /dev/binderfs/binder_logs/proc.
This change provides an alternate way to access this file when debugfs
is not mounted.
Signed-off-by: Hridya Valsaraju
---
drivers/android/binder.c
a binderfs
instance is mounted at path /dev/binderfs, the above files will be
available at the following locations:
/dev/binderfs/binder_logs/state
/dev/binderfs/binder_logs/stats
/dev/binderfs/binder_logs/transactions
This provides a way to access them even when debugfs is not mounted.
Signed-off-
tial user namespace.
An attempt to use the option to mount a binderfs instance in
another user namespace will return an EPERM error.
Signed-off-by: Hridya Valsaraju
---
drivers/android/binderfs.c | 47 --
1 file changed, 45 insertions(+), 2 deletions(-
/kernel/debug/binder/transaction_log
/sys/kernel/debug/binder/transactions
Hridya Valsaraju (4):
binder: add a mount option to show global stats
binder: Add stats, state and transactions files
binder: Make transaction_log available in binderfs
binder: Add binder_proc logging to binderfs
driv
On Fri, Aug 9, 2019 at 11:22 AM Christian Brauner
wrote:
>
> On Fri, Aug 09, 2019 at 04:50:16PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Aug 08, 2019 at 03:27:25PM -0700, Hridya Valsaraju wrote:
> > > Currently, since each binderfs instance needs its own
> > >
On Fri, Aug 9, 2019 at 11:14 AM Christian Brauner
wrote:
>
> On Fri, Aug 09, 2019 at 04:55:08PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Aug 08, 2019 at 03:27:26PM -0700, Hridya Valsaraju wrote:
> > > Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME.
&g
devices for each binderfs instance by creating them
automatically.
Hridya Valsaraju (2):
binder: Add default binder devices through binderfs when configured
binder: Validate the default binderfs device names.
drivers/android/binder.c | 5 +++--
drivers/android/binder_internal.h | 2
Signed-off-by: Christian Brauner
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
- Updated commit message as per Greg Kroah-Hartman.
- Removed new module parameter creation as per Greg
Kroah-Hartman/Christian Brauner.
- Refactored device name length check into a new patch as per Greg
Kroah
: Hridya Valsaraju
---
drivers/android/binderfs.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index aee46dd1be91..55c5adb87585 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -570,6 +570,18
On Wed, Aug 7, 2019 at 4:02 AM Dan Carpenter wrote:
>
> On Tue, Aug 06, 2019 at 11:40:05AM -0700, Hridya Valsaraju wrote:
> > @@ -467,6 +466,9 @@ static int binderfs_fill_super(struct super_block *sb,
> > void *data, int silent)
> > int ret;
> >
Signed-off-by: Christian Brauner
Signed-off-by: Hridya Valsaraju
---
Changes in v2:
- Updated commit message as per Greg Kroah-Hartman.
- Removed new module parameter creation as per Greg
Kroah-Hartman/Christian Brauner.
- Refactored device name length check into a new patch as per Greg
Kroah
devices for each binderfs instance by creating them
automatically.
Hridya Valsaraju (2):
binder: Add default binder devices through binderfs when configured
binder: Validate the default binderfs device names.
drivers/android/binder.c | 5 +++--
drivers/android/binder_internal.h | 2
: Hridya Valsaraju
---
drivers/android/binderfs.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 886b4e0f482f..52c8bd361906 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -572,6 +572,18
On Fri, Aug 2, 2019 at 8:06 AM Christian Brauner wrote:
>
> On Fri, Aug 02, 2019 at 08:18:38AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Aug 01, 2019 at 03:35:56PM -0700, Hridya Valsaraju wrote:
> > > If CONFIG_ANDROID_BINDERFS is set, the default binder devic
If CONFIG_ANDROID_BINDERFS is set, the default binder devices
specified by CONFIG_ANDROID_BINDER_DEVICES are created in each
binderfs instance instead of global devices being created by
the binder driver.
Co-developed-by: Christian Brauner
Signed-off-by: Christian Brauner
Signed-off-by: Hridya
manager.
Reported-by: syzbot+8b3c354d33c4ac78b...@syzkaller.appspotmail.com
Signed-off-by: Hridya Valsaraju
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index e4d25ebec5be..89b9cedae088 100644
--- a
54 matches
Mail list logo
