Re: [PATCH 1/6] ARM: dts: rockchip: add basic dtsi file for RK3229 SoC

Hi Jacob and Heiko: On 2017年06月21日 12:11, Jacob Chen wrote: > Hi, > > 2017-06-20 18:48 GMT+08:00 Heiko Stübner >: > > Hi Frank, > > > > Am Dienstag, 20. Juni 2017, 15:13:00 CEST schrieb Frank Wang: > >> Hi Heiko, > >> > >> On 2017/6/19 20:30, Heiko

Re: [PATCH 1/6] ARM: dts: rockchip: add basic dtsi file for RK3229 SoC

Hi Jacob and Heiko: On 2017年06月21日 12:11, Jacob Chen wrote: > Hi, > > 2017-06-20 18:48 GMT+08:00 Heiko Stübner >: > > Hi Frank, > > > > Am Dienstag, 20. Juni 2017, 15:13:00 CEST schrieb Frank Wang: > >> Hi Heiko, > >> > >> On 2017/6/19 20:30, Heiko Stübner wrote: > >> > Hi

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

Hi Daniel: On 2016年06月13日 21:06, Daniel Lezcano wrote: > On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote: >> This series patches had been tested on rockchip inside kernel. >> In order to support the rk3399 SoC timer and turn off interrupts and IPIs to >> save power in idle. > > For my

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

Hi Daniel: On 2016年06月13日 21:06, Daniel Lezcano wrote: > On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote: >> This series patches had been tested on rockchip inside kernel. >> In order to support the rk3399 SoC timer and turn off interrupts and IPIs to >> save power in idle. > > For my

Re: [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq

Hi Doug: On 2016年06月01日 01:03, Doug Anderson wrote: > Hi, > > On Mon, May 30, 2016 at 4:09 PM, Daniel Lezcano > <daniel.lezc...@linaro.org> wrote: >> On 05/25/2016 11:49 AM, Caesar Wang wrote: >>> >>> From: Huang Tao <huang...@rock-chips.com> >&

Re: [PATCH 2/5] clocksource: rockchip: remove unnecessary clear irq before request_irq

Hi Doug: On 2016年06月01日 01:03, Doug Anderson wrote: > Hi, > > On Mon, May 30, 2016 at 4:09 PM, Daniel Lezcano > wrote: >> On 05/25/2016 11:49 AM, Caesar Wang wrote: >>> >>> From: Huang Tao >>> >>> rk_timer_interrupt_clear and rk_timer_disab

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

Hi Daniel: On 2016年05月31日 22:06, Daniel Lezcano wrote: >> >> @@ -46,15 +48,20 @@ static inline void __iomem *rk_base(struct >> clock_event_device *ce) >> return rk_timer(ce)->base; >> } >> >> +static inline void __iomem *rk_ctrl(struct clock_event_device *ce) >> +{ >> +return

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

Hi Daniel: On 2016年05月31日 22:06, Daniel Lezcano wrote: >> >> @@ -46,15 +48,20 @@ static inline void __iomem *rk_base(struct >> clock_event_device *ce) >> return rk_timer(ce)->base; >> } >> >> +static inline void __iomem *rk_ctrl(struct clock_event_device *ce) >> +{ >> +return

Re: [PATCH 3/5] clocksource: rockchip: add dynamic irq flag to the timer

Hi Daniel: On 2016年05月31日 07:16, Daniel Lezcano wrote: > On 05/25/2016 11:50 AM, Caesar Wang wrote: >> From: Huang Tao <huang...@rock-chips.com> >> >> The rockchip timer is broadcast timer. Add CLOCK_EVT_FEAT_DYNIRQ >> flag and set cpumask to all cpu to save powe

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

Hi Daniel: On 2016年05月31日 07:28, Daniel Lezcano wrote: > On 05/25/2016 11:50 AM, Caesar Wang wrote: >> From: Huang Tao <huang...@rock-chips.com> >> >> The CONTROL register offset is different from old SoCs. >> For Linux driver, there are not functional ch

Re: [PATCH 3/5] clocksource: rockchip: add dynamic irq flag to the timer

Hi Daniel: On 2016年05月31日 07:16, Daniel Lezcano wrote: > On 05/25/2016 11:50 AM, Caesar Wang wrote: >> From: Huang Tao >> >> The rockchip timer is broadcast timer. Add CLOCK_EVT_FEAT_DYNIRQ >> flag and set cpumask to all cpu to save power by avoid unnecessary >> w

Re: [PATCH 4/5] clocksource: rockchip: add support for rk3399 SoC

Hi Daniel: On 2016年05月31日 07:28, Daniel Lezcano wrote: > On 05/25/2016 11:50 AM, Caesar Wang wrote: >> From: Huang Tao >> >> The CONTROL register offset is different from old SoCs. >> For Linux driver, there are not functional changes at all. >> Let's call it v

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Mark: On 2016年04月25日 18:47, Mark Rutland wrote: > On Mon, Apr 25, 2016 at 06:19:28PM +0800, Huang, Tao wrote: >> Hi, Mark: >> On 2016年04月25日 18:05, Mark Rutland wrote: >>> On Mon, Apr 25, 2016 at 05:48:51PM +0800, Huang, Tao wrote: >>>>

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Mark: On 2016年04月25日 18:47, Mark Rutland wrote: > On Mon, Apr 25, 2016 at 06:19:28PM +0800, Huang, Tao wrote: >> Hi, Mark: >> On 2016年04月25日 18:05, Mark Rutland wrote: >>> On Mon, Apr 25, 2016 at 05:48:51PM +0800, Huang, Tao wrote: >>>>

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Marc: On 2016年04月25日 18:39, Marc Zyngier wrote: > On 25/04/16 11:06, Marc Zyngier wrote: >> On 25/04/16 10:48, Huang, Tao wrote: >>> Hi, Marc: >>> On 2016年04月21日 19:30, Marc Zyngier wrote: >>>> On Thu, 21 Apr 2016 18:47:20 +0800 >>>> "Hu

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Marc: On 2016年04月25日 18:39, Marc Zyngier wrote: > On 25/04/16 11:06, Marc Zyngier wrote: >> On 25/04/16 10:48, Huang, Tao wrote: >>> Hi, Marc: >>> On 2016年04月21日 19:30, Marc Zyngier wrote: >>>> On Thu, 21 Apr 2016 18:47:20 +0800 >>>> "Hu

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Mark: On 2016年04月25日 18:05, Mark Rutland wrote: > On Mon, Apr 25, 2016 at 05:48:51PM +0800, Huang, Tao wrote: >> Hi, Marc: >> On 2016年04月21日 19:30, Marc Zyngier wrote: >>> On Thu, 21 Apr 2016 18:47:20 +0800 >>> "Huang, Tao" <huang...@rock-chips.com

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Mark: On 2016年04月25日 18:05, Mark Rutland wrote: > On Mon, Apr 25, 2016 at 05:48:51PM +0800, Huang, Tao wrote: >> Hi, Marc: >> On 2016年04月21日 19:30, Marc Zyngier wrote: >>> On Thu, 21 Apr 2016 18:47:20 +0800 >>> "Huang, Tao" wrote: >>> &g

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Marc: On 2016年04月21日 19:30, Marc Zyngier wrote: > On Thu, 21 Apr 2016 18:47:20 +0800 > "Huang, Tao" <huang...@rock-chips.com> wrote: > >> Hi, Mark: >> On 2016年04月21日 18:19, Mark Rutland wrote: >>> On Thu, Apr 21, 2016 at 11:58:12AM +0800, J

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Hi, Marc: On 2016年04月21日 19:30, Marc Zyngier wrote: > On Thu, 21 Apr 2016 18:47:20 +0800 > "Huang, Tao" wrote: > >> Hi, Mark: >> On 2016年04月21日 18:19, Mark Rutland wrote: >>> On Thu, Apr 21, 2016 at 11:58:12AM +0800, Jianqun

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

The I2C controller uses the APB clock/clk_i2c as the working clock. The APB clock will determine the I2C bus clock, clk_i2c is the function clk, up to 200MHz. Chips such as RK3288/3368 only uses APB clock. So old driver do not work on RK3399. Thanks, Huang, Tao

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

The I2C controller uses the APB clock/clk_i2c as the working clock. The APB clock will determine the I2C bus clock, clk_i2c is the function clk, up to 200MHz. Chips such as RK3288/3368 only uses APB clock. So old driver do not work on RK3399. Thanks, Huang, Tao

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

interrupt-affinity = <_b0>, <_b1>; }; but unfortunately, the arm pmu driver do not support PPI in two cluster well, so we have to replace with this implementation. > In this case things are messier as the same PPI number is being used > across clusters. Marc (Cc'd) has been working on PPI partitions, which > should allow us to support that. Great! So what we can do right now? Wait this feature, and delete arm-pmu node? Thanks, Huang, Tao

Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

interrupt-affinity = <_b0>, <_b1>; }; but unfortunately, the arm pmu driver do not support PPI in two cluster well, so we have to replace with this implementation. > In this case things are messier as the same PPI number is being used > across clusters. Marc (Cc'd) has been working on PPI partitions, which > should allow us to support that. Great! So what we can do right now? Wait this feature, and delete arm-pmu node? Thanks, Huang, Tao

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

nsure that CS line is in non-active state after spi_setup()"). And spi_set_cs will call spi->master->set_cs, and set_cs callback will access register. Without clk enable, I believe some drivers will failed to run. Best Regards, Huang, Tao

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

nsure that CS line is in non-active state after spi_setup()"). And spi_set_cs will call spi->master->set_cs, and set_cs callback will access register. Without clk enable, I believe some drivers will failed to run. Best Regards, Huang, Tao

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

Hi, Mark: Another way to solve this bug is add runtime PM support while spi setup. Some other chips may have some problem, for example mt65xx and orion, which access hardware register too. On 2016年02月24日 18:00, Huibin Hong wrote: > Rockchip_spi_set_cs could be called by spi_setup, but >

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

Hi, Mark: Another way to solve this bug is add runtime PM support while spi setup. Some other chips may have some problem, for example mt65xx and orion, which access hardware register too. On 2016年02月24日 18:00, Huibin Hong wrote: > Rockchip_spi_set_cs could be called by spi_setup, but >

Re: [PATCH] i2c: rk3x: init module as subsys call

Hi, Heiko: On 2016年01月05日 16:00, Heiko Stuebner wrote: > Hi Tao, > > Am Dienstag, 5. Januar 2016, 15:42:32 schrieb Huang, Tao: >> I don't think this is a good idea. This will trigger a lots of init call >> failed. Before pmic init, all i2c device driver transmit will faile

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

new PMIC driver, for example rk818, define a new struct rk818. How can we get this pointer from RTC driver? So another way to solve this problem is introduce common struct share between all PMIC driver. For example rk8xx. We solve this problem by create new regmap to access PMIC. As I say before, it make R

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

p to access PMIC. As I say before, it make RTC driver independent of PMIC driver. Do you agree this change? Thanks! Huang, Tao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] i2c: rk3x: init module as subsys call

Hi, Heiko: On 2016年01月05日 16:00, Heiko Stuebner wrote: > Hi Tao, > > Am Dienstag, 5. Januar 2016, 15:42:32 schrieb Huang, Tao: >> I don't think this is a good idea. This will trigger a lots of init call >> failed. Before pmic init, all i2c device driver transmit will faile

Re: [PATCH] i2c: rk3x: init module as subsys call

ld be subsys, and we can easy resolve this problem, why we depends on a complicated and slow implementation? > > Your touchscreen will have a "xyz-supply" property and I think the > regulator-framework should already emit a -EPROBE_DEFER at regulator_get, > when the regulat

Re: [PATCH] i2c: rk3x: init module as subsys call

lator_get, > when the regulator is specified but not available yet. Unfortunately, mostly driver do not support regulator api. They are suppose power is on. Thanks. Huang, Tao > > > Heiko > >> >> Signed-off-by: Xu Jianqun <jay...@rock-chips.com> >> --- >&

Re: [RESEND PATCH 0/1] Fix the "hard LOCKUP" when running a heavy loading

Hello Russell: 在 2015年11月03日 19:14, Russell King - ARM Linux 写道: > On Tue, Nov 03, 2015 at 04:10:08PM +0800, Caesar Wang wrote: >> As the Russell said: >> "in other words, which can be handled by updating a control register in >> the firmware or boot loader" >> Maybe the better solution is in

Re: [RESEND PATCH 0/1] Fix the "hard LOCKUP" when running a heavy loading

Hello Russell: 在 2015年11月03日 19:14, Russell King - ARM Linux 写道: > On Tue, Nov 03, 2015 at 04:10:08PM +0800, Caesar Wang wrote: >> As the Russell said: >> "in other words, which can be handled by updating a control register in >> the firmware or boot loader" >> Maybe the better solution is in

Re: [PATCH] ARM: rockchip: restore dapswjdp after suspend

Hi, Doug: 在 2015年05月21日 04:34, Doug Anderson 写道: > In the commit (0ea001d ARM: rockchip: disable dapswjdp during suspend) > we made the assumption that we didn't need to restore dapswjdp after > suspend because "the MASKROM will enable it back". > > It turns out that's not a safe assumption. In

Re: [PATCH] ARM: rockchip: restore dapswjdp after suspend

Hi, Doug: 在 2015年05月21日 04:34, Doug Anderson 写道: In the commit (0ea001d ARM: rockchip: disable dapswjdp during suspend) we made the assumption that we didn't need to restore dapswjdp after suspend because the MASKROM will enable it back. It turns out that's not a safe assumption. In some

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

Dear Eduardo Bezerra Valentin: 在 2014年08月29日 19:39, edubez...@gmail.com 写道: > Hello Zhao, > > On Thu, Aug 28, 2014 at 9:54 PM, 赵仪峰 wrote: >> Hi Heiko， >> >>The TS-ADC on RK3288 has two component, a tsadc and a tsadc controller. >> The tsadc controller is similar like the thermal manager unit

Re: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc

Hi, 在 2014年08月29日 19:22, Mark Rutland 写道: >> 在 2014年08月28日 23:11, Mark Rutland 写道: >>> To clarify: if there are low power states that the CPU can enter where >>> we lose state, then this patch isn't correct. >> Right now, the software of RK3288 SoC only support CPU hotplug >> (cpu_on/off) and

Re: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc

Hi, 在 2014年08月29日 19:22, Mark Rutland 写道: 在 2014年08月28日 23:11, Mark Rutland 写道: To clarify: if there are low power states that the CPU can enter where we lose state, then this patch isn't correct. Right now, the software of RK3288 SoC only support CPU hotplug (cpu_on/off) and power off all

Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

Dear Eduardo Bezerra Valentin: 在 2014年08月29日 19:39, edubez...@gmail.com 写道: Hello Zhao, On Thu, Aug 28, 2014 at 9:54 PM, 赵仪峰 z...@rock-chips.com wrote: Hi Heiko， The TS-ADC on RK3288 has two component, a tsadc and a tsadc controller. The tsadc controller is similar like the thermal

Re: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc

Hi, Mark: 在 2014年08月28日 23:11, Mark Rutland 写道: > To clarify: if there are low power states that the CPU can enter where > we lose state, then this patch isn't correct. Right now, the software of RK3288 SoC only support CPU hotplug (cpu_on/off) and power off all CPUs on suspend. We do not

Re: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc

Hi, Mark: 在 2014年08月28日 23:11, Mark Rutland 写道: To clarify: if there are low power states that the CPU can enter where we lose state, then this patch isn't correct. Right now, the software of RK3288 SoC only support CPU hotplug (cpu_on/off) and power off all CPUs on suspend. We do not implement

Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

Hi, Mark: 于 2014年07月02日 01:07, Mark Brown 写道: >> +static inline void i2s_writel(struct rk_i2s_dev *i2s, u32 value, >> > +unsigned int offset) >> > +{ >> > + writel_relaxed(value, i2s->regs + offset); >> > +} >> > + >> > +static inline u32 i2s_readl(struct rk_i2s_dev *i2s,

Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

Hi, Mark: 于 2014年07月02日 01:07, Mark Brown 写道: +static inline void i2s_writel(struct rk_i2s_dev *i2s, u32 value, +unsigned int offset) +{ + writel_relaxed(value, i2s-regs + offset); +} + +static inline u32 i2s_readl(struct rk_i2s_dev *i2s, unsigned int offset)