Re: [PATCH] ubi: Remove ubi_io_is_bad call from scan_peb

Please, ignore this patch. I made a mistake. while headers are read, ubi_io_is_bad is called only when chk_io is true. 2017-09-26 13:54 GMT+09:00 Hyunchul Lee : > From: Hyunchul Lee > > When erase count and volume identifier headers are read, > ubi_io_is_bad

Re: [PATCH] ubi: Remove ubi_io_is_bad call from scan_peb

Please, ignore this patch. I made a mistake. while headers are read, ubi_io_is_bad is called only when chk_io is true. 2017-09-26 13:54 GMT+09:00 Hyunchul Lee : > From: Hyunchul Lee > > When erase count and volume identifier headers are read, > ubi_io_is_bad is called. So instead of calling

RE: [PATCH 15/17] tracing/uprobes: Add support for full argument access methods

Patches look good to me. Signed-off-by: Hyeoncheol Lee -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Friday, January 03, 2014 6:02 AM To: Steven Rostedt Cc: Namhyung Kim; Oleg Nesterov; Masami Hiramatsu; Srikar Dronamraju; Hyeoncheol Lee; zhangwei(Jovi

RE: [PATCH 15/17] tracing/uprobes: Add support for full argument access methods

Patches look good to me. Signed-off-by: Hyeoncheol Lee cheol@lge.com -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: Friday, January 03, 2014 6:02 AM To: Steven Rostedt Cc: Namhyung Kim; Oleg Nesterov; Masami Hiramatsu; Srikar Dronamraju; Hyeoncheol Lee

[PATCH] fat: instead of constant number, use the i_blkbits of struct inode to calculate the number of blocks

To calculate the number of blocks from the number of clusters, use the i_blkbits of struct inode instead of 9. Signed-off-by: Hyeoncheol Lee --- fs/fat/misc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/misc.c b/fs/fat/misc.c index 6d93360..ccdf663 100644

[PATCH] fat: instead of constant number, use the i_blkbits of struct inode to calculate the number of blocks

To calculate the number of blocks from the number of clusters, use the i_blkbits of struct inode instead of 9. Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- fs/fat/misc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/misc.c b/fs/fat/misc.c index 6d93360

[tip:perf/core] perf probe: Allow of casting an array of char to string

Commit-ID: 7ce28b5b5b320e26ac6a0e352d5005bce3530e05 Gitweb: http://git.kernel.org/tip/7ce28b5b5b320e26ac6a0e352d5005bce3530e05 Author: Hyeoncheol Lee AuthorDate: Tue, 11 Sep 2012 16:57:28 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 24 Jan 2013 16:40:20 -0300 perf probe

[tip:perf/core] perf probe: Allow of casting an array of char to string

Commit-ID: 7ce28b5b5b320e26ac6a0e352d5005bce3530e05 Gitweb: http://git.kernel.org/tip/7ce28b5b5b320e26ac6a0e352d5005bce3530e05 Author: Hyeoncheol Lee hyc@gmail.com AuthorDate: Tue, 11 Sep 2012 16:57:28 +0900 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate: Thu, 24 Jan

[PATCH] uprobes tracer: Add support for @ADDR, @stackN, dereference, bitfield arguments

fetch type information tables and fetch type functions. But they share printing type functions and some fetch type functions for register, dereference, and bitfield. The common functions are defined in trace_probe.c. Signed-off-by: Hyeoncheol Lee Cc: Masami Hiramatsu Cc: Srikar Dronamraju --- v2

[PATCH] uprobes tracer: Add support for @ADDR, @stackN, dereference, bitfield arguments

fetch type information tables and fetch type functions. But they share printing type functions and some fetch type functions for register, dereference, and bitfield. The common functions are defined in trace_probe.c. Signed-off-by: Hyeoncheol Lee hyc@gmail.com Cc: Masami Hiramatsu

[PATCH v2] uprobes tracer: Add stack/memory/retval access support

for register, retval, and memory dereference. Common functions are defined in trace_probe.c. Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyeoncheol Lee --- v2 - separate fetch type functions for uprobes and kprobes tracer kernel/trace/trace_kprobe.c | 147

[PATCH v2] uprobes tracer: Add stack/memory/retval access support

for register, retval, and memory dereference. Common functions are defined in trace_probe.c. Signed-off-by: Hyeoncheol Lee --- v2 - separate fetch type functions for uprobes and kprobes tracer kernel/trace/trace_kprobe.c | 147 +- kernel/trace/trace_probe.c | 292

[PATCH v2] uprobes tracer: Add stack/memory/retval access support

for register, retval, and memory dereference. Common functions are defined in trace_probe.c. Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- v2 - separate fetch type functions for uprobes and kprobes tracer kernel/trace/trace_kprobe.c | 147 +- kernel/trace

[PATCH v2] uprobes tracer: Add stack/memory/retval access support

for register, retval, and memory dereference. Common functions are defined in trace_probe.c. Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- v2 - separate fetch type functions for uprobes

[PATCH v2] perf probe: convert_name_to_addr() allocated the wrong size buffers for names

The function allocated wrong size buffers for names Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyeoncheol Lee --- v2: - Added a comment for MAX_ADDRNAME_LEN tools/perf/util/probe-event.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] uprobes tracer: Add stack/memory/retval access support

2012/10/16 Masami Hiramatsu : > (2012/10/16 18:02), Hyeoncheol Lee wrote: >> Event arguments except @SYM are supported. They are @ADDR, >> $stack, $stackN, $retval, and offs(arguments). >> >> Cc: Masami Hiramatsu >> Cc: Srikar Dronamraju

[PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffers for names

The function allocated wrong size buffers for names Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyeoncheol Lee --- tools/perf/util/probe-event.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util

[PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffers for names

The function allocated wrong size buffers for names Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- tools/perf/util/probe-event.c | 11 +++ 1 file changed, 7 insertions(+), 4

Re: [PATCH] uprobes tracer: Add stack/memory/retval access support

2012/10/16 Masami Hiramatsu masami.hiramatsu...@hitachi.com: (2012/10/16 18:02), Hyeoncheol Lee wrote: Event arguments except @SYM are supported. They are @ADDR, $stack, $stackN, $retval, and offs(arguments). Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri

[PATCH v2] perf probe: convert_name_to_addr() allocated the wrong size buffers for names

The function allocated wrong size buffers for names Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- v2: - Added a comment for MAX_ADDRNAME_LEN tools/perf/util/probe-event.c | 17

[PATCH] uprobes tracer: Add stack/memory/retval access support

Event arguments except @SYM are supported. They are @ADDR, $stack, $stackN, $retval, and offs(arguments). Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyeoncheol Lee --- kernel/trace/trace_kprobe.c |6 +- kernel/trace/trace_probe.c | 162

Re: [PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffer for a function name

Hi, 2012/10/16 Srikar Dronamraju : > * Masami Hiramatsu [2012-10-16 13:19:57]: > >> (2012/10/16 10:37), Hyeoncheol Lee wrote: >> > convert_name_to_addr() allocated sizeof(char *) * MAX_PROBE_ARGS >> > bytes for a function name >> >> Yeah, that one was

Re: [PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffer for a function name

Hi, 2012/10/16 Masami Hiramatsu : > (2012/10/16 10:37), Hyeoncheol Lee wrote: >> convert_name_to_addr() allocated sizeof(char *) * MAX_PROBE_ARGS >> bytes for a function name > > Yeah, that one was from my laziness... > >> >> Cc: Masami Hiramatsu >

Re: [PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffer for a function name

Hi, 2012/10/16 Masami Hiramatsu masami.hiramatsu...@hitachi.com: (2012/10/16 10:37), Hyeoncheol Lee wrote: convert_name_to_addr() allocated sizeof(char *) * MAX_PROBE_ARGS bytes for a function name Yeah, that one was from my laziness... Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com

Re: [PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffer for a function name

Hi, 2012/10/16 Srikar Dronamraju sri...@linux.vnet.ibm.com: * Masami Hiramatsu masami.hiramatsu...@hitachi.com [2012-10-16 13:19:57]: (2012/10/16 10:37), Hyeoncheol Lee wrote: convert_name_to_addr() allocated sizeof(char *) * MAX_PROBE_ARGS bytes for a function name Yeah, that one

[PATCH] uprobes tracer: Add stack/memory/retval access support

Event arguments except @SYM are supported. They are @ADDR, $stack, $stackN, $retval, and offs(arguments). Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- kernel/trace/trace_kprobe.c |6

[PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffer for a function name

convert_name_to_addr() allocated sizeof(char *) * MAX_PROBE_ARGS bytes for a function name Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyeoncheol Lee --- tools/perf/util/probe-event.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/util

[PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffer for a function name

convert_name_to_addr() allocated sizeof(char *) * MAX_PROBE_ARGS bytes for a function name Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- tools/perf/util/probe-event.c |5 +++-- 1 file

[PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables

When showing accessible variables, an enum type variable was printed in "variable-name" format. Change this format into "enum variable-name". Cc: Masami Hiramatsu Signed-off-by: Hyeoncheol Lee --- tools/perf/util/dwarf-aux.c |2 ++ 1 file changed, 2 insertions(+) dif

Re: [QUESTION] Can uprobe_event support @ADDR, $retval, offs(FETCHARG)?

2012/9/26 Srikar Dronamraju : >> >> Perhaps, it is not so small things, but at least, we can try. >> In the userspace, memories(pages) can be paged out on swap or >> files. In that case, memory dereference function needs to track >> down the data on the disk and it causes I/O. This means we will

Re: [QUESTION] Can uprobe_event support @ADDR, $retval, offs(FETCHARG)?

Hi, 2012/9/26 Masami Hiramatsu : > (2012/09/26 11:52), Hyeoncheol Lee wrote: >> Hi, >> >> uprobe_event only supports %REG arguments. I think that memory fetch, >> return value fetch, memory dereference functions in >> kernel/trace/trace_probe.c are good f

Re: [QUESTION] Can uprobe_event support @ADDR, $retval, offs(FETCHARG)?

Hi, 2012/9/26 Masami Hiramatsu masami.hiramatsu...@hitachi.com: (2012/09/26 11:52), Hyeoncheol Lee wrote: Hi, uprobe_event only supports %REG arguments. I think that memory fetch, return value fetch, memory dereference functions in kernel/trace/trace_probe.c are good for uprobe_event. So

Re: [QUESTION] Can uprobe_event support @ADDR, $retval, offs(FETCHARG)?

2012/9/26 Srikar Dronamraju sri...@linux.vnet.ibm.com: Perhaps, it is not so small things, but at least, we can try. In the userspace, memories(pages) can be paged out on swap or files. In that case, memory dereference function needs to track down the data on the disk and it causes I/O. This

[PATCH] perf probe: print an enum type variable in enum variable-name format when showing accessible variables

When showing accessible variables, an enum type variable was printed in variable-name format. Change this format into enum variable-name. Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- tools/perf/util/dwarf-aux.c |2 ++ 1 file

[PATCH] perf probe: Allow of casting an array of char to string

Before casting a type of a variable to string, convert_variable_type() confirms that the type is a pointer or an array. if it is a pointer to char, it is casted to string. but in case of an array of char, it isn't Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyeoncheol Lee

[tip:perf/core] perf probe: Add union member access support

Commit-ID: 7b0295b3db20a89b3296673871858b9ab6b68404 Gitweb: http://git.kernel.org/tip/7b0295b3db20a89b3296673871858b9ab6b68404 Author: Hyeoncheol Lee AuthorDate: Wed, 12 Sep 2012 16:57:45 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 14 Sep 2012 15:48:08 -0300 perf probe

[tip:perf/core] perf probe: Add union member access support

Commit-ID: 7b0295b3db20a89b3296673871858b9ab6b68404 Gitweb: http://git.kernel.org/tip/7b0295b3db20a89b3296673871858b9ab6b68404 Author: Hyeoncheol Lee hyc@gmail.com AuthorDate: Wed, 12 Sep 2012 16:57:45 +0900 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate: Fri, 14 Sep

[PATCH] perf probe: Allow of casting an array of char to string

...@linux.vnet.ibm.com Signed-off-by: Hyeoncheol Lee hyc@gmail.com --- tools/perf/util/probe-finder.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c index 1daf5c1..be03293 100644 --- a/tools/perf/util

[PATCH -tip/perf/core] perf probe: Add union member access support

Union members can be accessed with '.' or '->' like data structure member access Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: Hyunchul Lee --- tools/perf/util/probe-finder.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git

[PATCH -tip/perf/core] perf probe: Add union member access support

Union members can be accessed with '.' or '-' like data structure member access Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Signed-off-by: Hyunchul Lee hyc@gmail.com --- tools/perf/util/probe-finder.c | 24 1

[PATCH -tip/perf/core ] perf probe: Allow of casting an array of char to string

Before casting a type of a variable to string, convert_variable_type() confirms that the type is a pointer or an array. then if it is a pointer to char, it is casted to string. but in case of an array of char, it isn't Cc: Masami Hiramatsu Cc: Srikar Dronamraju Signed-off-by: H.C. Lee ---

[PATCH -tip/perf/core ] perf probe: Allow of casting an array of char to string

Before casting a type of a variable to string, convert_variable_type() confirms that the type is a pointer or an array. then if it is a pointer to char, it is casted to string. but in case of an array of char, it isn't Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju