)` and `DAS08AOX_AO_MSB_REG(x)` respectively, and
add some comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
in the comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
index 4e8756a..8aa8011 100644
)` and `DAS08JR_AO_MSB_REG(x)` respectively, and
add some comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers
Clean up the Comedi das08 module a bit, mostly for consistent naming
of things.
01) staging: comedi: das08.h: reformat copyright comment
02) staging: comedi: das08.h: change description in copyright header
comment
03) staging: comedi: das08.h: reformat remaining comments
04) staging: comedi:
`.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 20 ++--
drivers/staging/comedi/drivers/das08.h | 5 +++--
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers
for boards that support
programmable gain.
This will also allow range tables to be included for convenience for
those boards that support multiple ranges by DIP switches. Those boards
are currently initialized to use a single unknown range.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
NTR_EN_BIT 0x800 /* enable interrupt on dma
terminal count */
#define DMA_DEM_EN_BIT 0x1000 /* enables demand mode dma */
#define I8253_BASE_REG0x14
OK.
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=(
DMA_INTR_EN_BIT 0x800 /* enable interrupt on dma
terminal count */
#define DMA_DEM_EN_BIT 0x1000 /* enables demand mode dma */
#define I8253_BASE_REG0x14
OK.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo
t comedi_device *dev,
The patch itself looks fine!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
*dev,
The patch itself looks fine!
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
ai_poll_ptr; /* how many samples transfer poll */
+ unsigned int max_812_ai_mode0_rangewait; /* settling time for gain */
unsigned int use_diff:1;
unsigned int use_mpc508:1;
unsigned int use_ext_trg:1;
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail
!= chansegment[i % seglen]) {
dev_dbg(dev->class_dev,
"bad channel or range number!
chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
i, CR_CHAN(chansegment[i]),
Reviewed-by: Ian Abbott
*/
+ unsigned int ai_poll_ptr; /* how many samples transfer poll */
+ unsigned int max_812_ai_mode0_rangewait; /* settling time for gain */
unsigned int use_diff:1;
unsigned int use_mpc508:1;
unsigned int use_ext_trg:1;
Reviewed-by: Ian Abbott abbo...@mev.co.uk
]) {
dev_dbg(dev-class_dev,
bad channel or range number!
chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n,
i, CR_CHAN(chansegment[i]),
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail
ndirectly takes care of the use of `NULL`.) It uses `struct
comedi_device *` in various function prototypes, so add an incomplete
declaration of `struct comedi_device`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/comedi_isadma.h | 4
1 file changed, 4 insertions(+)
diff --g
omedi_insn` structures in various function prototypes, so declare those
as incomplete types. It use the `bool` type, so include
. It also uses the `__iomem` tag, but that seems to be
taken care of indirectly by including .
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/comedi_
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200.c | 37 ++-
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/comedi
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200.h | 40 +--
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/comedi
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott
---
.../staging/comedi/drivers/amplc_dio200_common.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi
Use braces when the single statement following an `if` (or `else`)
spans more than one line (including any preceding comments).
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200_common.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200_pci.c | 35 ---
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/comedi
struct
comedi_device` as an incomplete type. It also uses `bool`, so include
to declare it.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_dio200.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/comedi/drivers/amplc_dio200.h
b/drivers/staging/comedi/
A few coding style cleanups for the Comedi amplc_dio200* modules, and to
make the "amplc_dio200.h" header file self-reliant.
1) staging: comedi: amplc_dio200.h: reformat copyright comment
2) staging: comedi: amplc_dio200.h: make self-reliant
3) staging: comedi: amplc_dio200.c: reformat copyright
n't bother including the header file.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/addi_watchdog.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi_watchdog.h
b/drivers/staging/comedi/drivers/addi_watchdog.h
index 83b
parameter names to
the callback function pointer type wherever it occurs to make the usage
clearer.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/8255.c | 26 +-
drivers/staging/comedi/drivers/8255.h | 12 ++--
2 files changed, 19 insertions(+), 19
e types
incompletely and don't bother including "comedidev.h".
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/8255.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.h
b/drivers/staging/comedi/drivers/8255.h
ler. Unfortunately, it is
unable to obtain the base address of the region if the call to
`subdev_8255_init()` failed.
Fix the I/O region leak by releasing the region in the "attach" handler
directly if the call to `subdev_8255_init()` fails.
Signed-off-by: Ian Abbott
---
drivers/sta
These patches are for the Comedi "8255" driver module (including the
creation of a new "comedi_8255" module split off from it).
Patch 1 fixes a problem cleaning up on failure in the Comedi "8255" driver.
Patch 2 is just a minor change to header file inclusion.
Patch 3 is a documentation fix.
nown to the "8255"
module, so add a new, exported function `subdev_8255_regbase()` to
retrieve it.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/Kconfig | 18 +-
drivers/staging/comedi/drivers/8255.c| 223 +
drivers/staging/comedi/drivers/
bother including comedidev.h.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.h
b/drivers/staging/comedi/drivers/8255.h
index 934b940..977cfe4 100644
to
the callback function pointer type wherever it occurs to make the usage
clearer.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.c | 26 +-
drivers/staging/comedi/drivers/8255.h | 12 ++--
2 files changed, 19 insertions(+), 19
if the call to
`subdev_8255_init()` failed.
Fix the I/O region leak by releasing the region in the attach handler
directly if the call to `subdev_8255_init()` fails.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/8255.c | 9 -
1 file changed, 8 insertions
These patches are for the Comedi 8255 driver module (including the
creation of a new comedi_8255 module split off from it).
Patch 1 fixes a problem cleaning up on failure in the Comedi 8255 driver.
Patch 2 is just a minor change to header file inclusion.
Patch 3 is a documentation fix.
Patch 4
in order to release the I/O port regions it requested
in its attach routine. The comedi_8255 module stores it in a
subdevice private data structure that is no longer known to the 8255
module, so add a new, exported function `subdev_8255_regbase()` to
retrieve it.
Signed-off-by: Ian Abbott abbo
the header file.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/addi_watchdog.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi_watchdog.h
b/drivers/staging/comedi/drivers/addi_watchdog.h
index 83b47be..3f8e738
takes care of the use of `NULL`.) It uses `struct
comedi_device *` in various function prototypes, so add an incomplete
declaration of `struct comedi_device`.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_isadma.h | 4
1 file changed, 4 insertions
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
.../staging/comedi/drivers/amplc_dio200_common.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_dio200.c | 37 ++-
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_dio200.h | 40 +--
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers
A few coding style cleanups for the Comedi amplc_dio200* modules, and to
make the amplc_dio200.h header file self-reliant.
1) staging: comedi: amplc_dio200.h: reformat copyright comment
2) staging: comedi: amplc_dio200.h: make self-reliant
3) staging: comedi: amplc_dio200.c: reformat copyright
Use braces when the single statement following an `if` (or `else`)
spans more than one line (including any preceding comments).
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_dio200_common.c | 17 +++--
1 file changed, 11 insertions(+), 6
` as an incomplete type. It also uses `bool`, so include
linux/types.h to declare it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_dio200.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/comedi/drivers/amplc_dio200.h
b/drivers/staging
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_dio200_pci.c | 35 ---
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers
` structures in various function prototypes, so declare those
as incomplete types. It use the `bool` type, so include
linux/types.h. It also uses the `__iomem` tag, but that seems to be
taken care of indirectly by including linux/types.h.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
"*/" characters), so I had to split them over several
lines.
yes, i noticed. its almost 84 char. but after applying your patch also
it comes to 81.
Really? I only see 80 characters.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/
rnal calibration sources) */
+ /*
+* set adc to read from inputs
+* (not internal calibration sources)
+*/
devpriv->i2c_cal_range_bits = adc_src_4020_bits(4);
/* set channels to +-5
rom master clock by dividing by (x + 3) where x is
+ * 24 bit number
*/
static void check_adc_timing(struct comedi_device *dev, struct comedi_cmd
*cmd)
{
Looks good.
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http
of the */ characters), so I had to split them over several
lines.
yes, i noticed. its almost 84 char. but after applying your patch also
it comes to 81.
Really? I only see 80 characters.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http
)
+*/
devpriv-i2c_cal_range_bits = adc_src_4020_bits(4);
/* set channels to +-5 volt input ranges */
for (i = 0; i s-n_chan; i++)
Looks good.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
master clock by dividing by (x + 3) where x is
+ * 24 bit number
*/
static void check_adc_timing(struct comedi_device *dev, struct comedi_cmd
*cmd)
{
Looks good.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
__func__, reg);
return 0;
}
Apart from that niggle, the patch looks good!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=(
: unhandled register=0x%x\n,
__func__, reg);
return 0;
}
Apart from that niggle, the patch looks good!
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http
nks. The patch is fine, but Hartley has already sent the same fix to
, and Greg was intending to apply that one.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linu
-start_arg) +
Thanks. The patch is fine, but Hartley has already sent the same fix to
de...@linuxdriverproject.org, and Greg was intending to apply that one.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe
s Nick
if (channel < 4)
return 1 << channel;
So, yes.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
if (channel 4)
return 1 channel;
So, yes.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Use the usual style for block comments. Squash double spaces after
comment opening sequence. Move some comments after opening braces to
following line.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 59 ++-
1 file changed, 34 insertions
ich points to a string literal and ends
up getting assigned to `dev->board_name`.
Get rid of the multiple board type support, and set `dev->board_name` to
point to the original string literal pointed to by
`hpdi_boards[0].name`. This string is visible to userspace.
Signed-off-by: Ian Abbott
---
Fix all the checkpatch issues "CHECK: Prefer using the BIT macro".
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 82 +++
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c
Use the `PCI_DEVICE_SUB()` macro in the initializer of the PCI module
device table `gsc_hpdi_pci_table[]`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c
b
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt". `udelay()` is only called once
from a place where sleeping is allowed. Replace it with a call to
`usleep_range()` with a reasonable upper limit.
Signed-off-by:
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c
b/drivers/staging/comedi/drivers/gsc_hpdi.c
index 51ab801..e929618 100644
--- a/drivers/staging/comedi/drivers
Simplify (eliminate) the board type matching code, since only a single
board type is supported. Reformat the comments. Fix the checkpatch
issues. Use a better module description string.
1) staging: comedi: gsc_hpdi: tidy up comments
2) staging: comedi: gsc_hpdi: remove multiple board type
deletions(-)
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
, 98 insertions(+), 98 deletions(-)
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
literal and ends
up getting assigned to `dev-board_name`.
Get rid of the multiple board type support, and set `dev-board_name` to
point to the original string literal pointed to by
`hpdi_boards[0].name`. This string is visible to userspace.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c
b/drivers/staging/comedi/drivers/gsc_hpdi.c
index 51ab801..e929618 100644
--- a/drivers/staging
Use the `PCI_DEVICE_SUB()` macro in the initializer of the PCI module
device table `gsc_hpdi_pci_table[]`.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi
Fix all the checkpatch issues CHECK: Prefer using the BIT macro.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 82 +++
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/comedi/drivers
Use the usual style for block comments. Squash double spaces after
comment opening sequence. Move some comments after opening braces to
following line.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 59 ++-
1 file changed
Simplify (eliminate) the board type matching code, since only a single
board type is supported. Reformat the comments. Fix the checkpatch
issues. Use a better module description string.
1) staging: comedi: gsc_hpdi: tidy up comments
2) staging: comedi: gsc_hpdi: remove multiple board type
Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt. `udelay()` is only called once
from a place where sleeping is allowed. Replace it with a call to
`usleep_range()` with a reasonable upper limit.
Signed-off-by: Ian Abbott abbo
The Comedi driver modules build fine if the inclusion of
is removed from "mite.h", so remove it. However, since "mite.c" calls
`kzalloc()`, include there.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.c | 1 +
drivers/staging/comedi/drivers/mite.h |
The macro `PCIMIO_COMPAT` is defined, but never used. Remove it.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.h
b/drivers/staging/comedi/drivers/mite.h
index cf45f88..620de2e 100644
ve the inclusion of "../comedi_pci.h" from "mite.h", and add enough
other includes and (incomplete) `struct` declarations to make it compile
without warnings or errors even when included first in a .c file.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.h |
Use the usual style for block comments. Squash double spaces after
comment opening sequences.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.h | 59 ++-
1 file changed, 30 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/comedi
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/drivers/staging/comedi/drivers/mite.c
index b514ad1..fa7ae2c 100644
--- a/drivers/staging/comedi/drivers/mite.c
+++ b
Reformat some function declarations to avoid bunching up near column 80.
Also add a blank line after a `struct` definition.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.h | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers
The definition of the macro `USE_KMALLOC` is commented out, and nothing
refers to it. Remove the commented out macro.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/drivers
Use the usual style for block comments. Squash double spaces after
comment opening sequences.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/mite.c | 105 +-
1 file changed, 54 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/comedi
1) staging: comedi: mite: move #include
2) staging: comedi: mite.h: remove PCIMIO_COMPAT
3) staging: comedi: mite.c: remove commented out USE_KMALLOC
4) staging: comedi: mite.h: remove "../comedi_pci.h" and make
self-reliant
5) staging: comedi: mite.h: reformat some comments
6) staging:
The definition of the macro `USE_KMALLOC` is commented out, and nothing
refers to it. Remove the commented out macro.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/drivers/staging/comedi/drivers/mite.c
index b514ad1..fa7ae2c 100644
--- a/drivers/staging/comedi
Reformat some function declarations to avoid bunching up near column 80.
Also add a blank line after a `struct` definition.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git
Use the usual style for block comments. Squash double spaces after
comment opening sequences.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 59 ++-
1 file changed, 30 insertions(+), 29 deletions(-)
diff --git a/drivers
Use the usual style for block comments. Squash double spaces after
comment opening sequences.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 105 +-
1 file changed, 54 insertions(+), 51 deletions(-)
diff --git a/drivers
1) staging: comedi: mite: move #include linux/slab.h
2) staging: comedi: mite.h: remove PCIMIO_COMPAT
3) staging: comedi: mite.c: remove commented out USE_KMALLOC
4) staging: comedi: mite.h: remove ../comedi_pci.h and make
self-reliant
5) staging: comedi: mite.h: reformat some comments
6)
The Comedi driver modules build fine if the inclusion of linux/slab.h
is removed from mite.h, so remove it. However, since mite.c calls
`kzalloc()`, include linux/slab.h there.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 1 +
drivers/staging/comedi
The macro `PCIMIO_COMPAT` is defined, but never used. Remove it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.h
b/drivers/staging/comedi/drivers/mite.h
index
other includes and (incomplete) `struct` declarations to make it compile
without warnings or errors even when included first in a .c file.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
s, in particular the "amplc_dio200_common" module.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_fops.c | 24 --
drivers/staging/comedi/comedi_internal.h | 1 +
drivers/staging/comedi/comedidev.h | 1 +
drivers/staging/comedi/driver
Keep the details of the comedi subdevice `runflags` member local to
"comedi_fops.c". In particular, the usage of the
`COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well
with the others. It's used as a marker to indicate the subdevice's
`private` pointer can be automatically
The `COMEDI_SRF_...` macros define flag combinations in the `runflags`
member of `struct comedi_subdevice`. They are only used directly in
"comedi_fops.c", so move them to there.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_fops.c | 17 +
drivers/stag
This has already been done for some comedi drivers.
Thanks,
Ian A.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@
already been done for some comedi drivers.
Thanks,
Ian A.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Keep the details of the comedi subdevice `runflags` member local to
comedi_fops.c. In particular, the usage of the
`COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well
with the others. It's used as a marker to indicate the subdevice's
`private` pointer can be automatically freed
The `COMEDI_SRF_...` macros define flag combinations in the `runflags`
member of `struct comedi_subdevice`. They are only used directly in
comedi_fops.c, so move them to there.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedi_fops.c | 17 +
drivers
module.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedi_fops.c | 24 --
drivers/staging/comedi/comedi_internal.h | 1 +
drivers/staging/comedi/comedidev.h | 1 +
drivers/staging/comedi/drivers.c
On 31/03/15 17:13, Hartley Sweeten wrote:
On Tuesday, March 31, 2015 2:43 AM, Ian Abbott wrote:
On 30/03/15 17:47, Hartley Sweeten wrote:
On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote:
`comedi_event()` is called from low-level drivers to handle comedi
asynchronous command event flags
1101 - 1200 of 2849 matches
Mail list logo
