/drivers/s626.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
int chan;
- uint16_t setup =
+ u16 setup =
/* Preload upon index. */
S626_SET_STD_LOADSRC(S626_LOADSRC_INDX) |
/* Disable hardware index. */
Ditto.
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo.
tup =
+ u16 setup =
/* Preload upon index. */
S626_SET_STD_LOADSRC(S626_LOADSRC_INDX) |
/* Disable hardware index. */
Ditto.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3, v4: No change.
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 26
Fix checkpatch issue: "CHECK: Please use a blank line after
function/struct/union/enum declarations".
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Fixed typo in patch description: `black line` --
Fix checkpatch issue: "CHECK: Please use a blank line after
function/struct/union/enum declarations".
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Fixed typo in patch description: `black line` --> `blank line`.
v3, v4: No change.
---
drivers/staging/c
Reformat one of the block comments to conform to the usual style (it's
the only one that doesn't).
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2, v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboa
Reformat one of the block comments to conform to the usual style (it's
the only one that doesn't).
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2, v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 6 --
1 file changed, 4 insertions(+), 2 deletions
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
Other CamelCase issues in this patch will be dealt with by l
microseconds one is called as each 16-bit word of
firmware data is written. Replace it with a fairly tight
`usleep_range(10, 20)` to avoid slowing down firmware loading too much.
The firmware is fairly short, so this would only slow it down firmware
loading by about 20 milliseconds or so.
Signed-off-by: Ian
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DB2K_REG_DACS_SET` for the value `0x0080`
that triggers setting one of the references.
Signed-off-by: Ian Abbott <a
is write-only.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 39 ++-
1 file
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
Other CamelCase issues in this patch will be dealt with by later
patches in the series.
v2: Shortened prefix from
microseconds one is called as each 16-bit word of
firmware data is written. Replace it with a fairly tight
`usleep_range(10, 20)` to avoid slowing down firmware loading too much.
The firmware is fairly short, so this would only slow it down firmware
loading by about 20 milliseconds or so.
Signed-off-by: Ian
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DB2K_REG_DACS_SET` for the value `0x0080`
that triggers setting one of the references.
Signed-off-by: Ian Abbott
Reviewed-by: H
is write-only.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 39 ++-
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git
el, but the existing code only works for channels 0
and 1. The driver only supports two DAC channels at the moment, so the
bug is currently harmless, but fix it so we can support four DAC
channels on some board models.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by
are currently used by the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 21 +++--
Rename the macros that define values for the trigger control register to
avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened
el, but the existing code only works for channels 0
and 1. The driver only supports two DAC channels at the moment, so the
bug is currently harmless, but fix it so we can support four DAC
channels on some board models.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: S
are currently used by the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff
Rename the macros that define values for the trigger control register to
avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3, v4: No change
Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Ad
s series of patches to the daqboard2000 driver is mostly to fix the
checkpatch.pl warnings. There is one warning remaining about one of the
`udelay` calls with a parameter of 10 microseconds, but I decided to
leave it alone, as converting it to `usleep_range` could increase
firmware loading time.
Fix checkpatch issues of the form "CHECK: spaces preferred around that
'*' (ctx:VxV)".
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
CamelCase issues in this patch will be dealt with by later patches.
Rename the macros defining values for the acquisition control register
to avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened
Rename functions to avoid CamelCase warnings from checkpatch, and to use
namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Rebased due to v2 changes in previous patches.
v3, v
Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Added comments to offset and gain values that should be read from
EEPROM
s series of patches to the daqboard2000 driver is mostly to fix the
checkpatch.pl warnings. There is one warning remaining about one of the
`udelay` calls with a parameter of 10 microseconds, but I decided to
leave it alone, as converting it to `usleep_range` could increase
firmware loading time.
Fix checkpatch issues of the form "CHECK: spaces preferred around that
'*' (ctx:VxV)".
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
CamelCase issues in this patch will be dealt with by later patches.
v2, v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard
Rename the macros defining values for the acquisition control register
to avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3: Rebased due to v3
Rename functions to avoid CamelCase warnings from checkpatch, and to use
namespace associated with the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Rebased due to v2 changes in previous patches.
v3, v4: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c
On 19/05/16 11:16, Ian Abbott wrote:
On 19/05/16 11:02, Ian Abbott wrote:
On 18/05/16 13:36, Ian Abbott wrote:
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) stagi
On 19/05/16 11:16, Ian Abbott wrote:
On 19/05/16 11:02, Ian Abbott wrote:
On 18/05/16 13:36, Ian Abbott wrote:
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) stagi
On 19/05/16 17:49, Hartley Sweeten wrote:
On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote:
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten
On 19/05/16 17:49, Hartley Sweeten wrote:
On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote:
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
Other CamelCase issues
On 19/05/16 11:02, Ian Abbott wrote:
On 18/05/16 13:36, Ian Abbott wrote:
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) staging: comedi: daqboard2000: remove com
On 19/05/16 11:02, Ian Abbott wrote:
On 18/05/16 13:36, Ian Abbott wrote:
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) staging: comedi: daqboard2000: remove com
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DB2K_REG_DACS_SET` for the value `0x0080`
that triggers setting one of the references.
Signed-off-by: Ian Abbott <a
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DB2K_REG_DACS_SET` for the value `0x0080`
that triggers setting one of the references.
Signed-off-by: Ian Abbott
Reviewed-by: H
On 19/05/16 10:58, Ian Abbott wrote:
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x0080` that triggers setting one
On 19/05/16 10:58, Ian Abbott wrote:
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x0080` that triggers setting one
On 18/05/16 13:36, Ian Abbott wrote:
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) staging: comedi: daqboard2000: remove commented out code
02) staging: comedi: da
On 18/05/16 13:36, Ian Abbott wrote:
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) staging: comedi: daqboard2000: remove commented out code
02) staging: comedi: da
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x0080` that triggers setting one of the references.
Signed-off-by: Ian Abbott <a
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x0080` that triggers setting one of the references.
Signed-off-by: Ian Abbott
Reviewed
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
Other CamelCase issues in this patch will be dealt with by l
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
Other CamelCase issues in this patch will be dealt with by later
patches in the series.
v2: Shortened prefix from
Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: ad
Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: added comments to offset and gain values that should be read from
EEPROM
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) staging: comedi: daqboard2000: remove commented out code
02) staging: comedi: daqboard2000: use usual block comment style
03)
Patches 03 and 06 have checkpatch warnings themselves about CamelCase
issues, but they are not "new" issues, and are resolved by the later
patches in the series.
01) staging: comedi: daqboard2000: remove commented out code
02) staging: comedi: daqboard2000: use usual block comment style
03)
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging/co
Fix checkpatch issues of the form "CHECK: spaces preferred around that
'*' (ctx:VxV)".
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
CamelCase issues in this patch will be dealt with by later patches.
v2: N
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging/comedi/drivers/daqboard2000.c | 26 +-
1
Fix checkpatch issues of the form "CHECK: spaces preferred around that
'*' (ctx:VxV)".
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
CamelCase issues in this patch will be dealt with by later patches.
v2: No change.
---
drivers/staging/comedi/drivers/daqboard
Rename the macros that define values for the trigger control register to
avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened
Rename the macros that define values for the trigger control register to
avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging
is write-only.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging/comedi/drivers/daqboard2000.c | 39 ++-
1 file changed, 20 inser
is write-only.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging/comedi/drivers/daqboard2000.c | 39 ++-
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi
are currently used by the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging/comedi/drivers/daqboard2000.c | 21 +++--
1 fil
are currently used by the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging/comedi/drivers/daqboard2000.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers
Rename functions to avoid CamelCase warnings from checkpatch, and to use
namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: No change, except to some diff context lines from prev
microseconds one is called as each 16-bit word of
firmware data is written. Replace it with a fairly tight
`usleep_range(10, 20)` to avoid slowing down firmware loading too much.
The firmware is fairly short, so this would only slow it down firmware
loading by about 20 milliseconds or so.
Signed-off-by: Ian
Rename functions to avoid CamelCase warnings from checkpatch, and to use
namespace associated with the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: No change, except to some diff context lines from previous patches.
---
drivers/staging/comedi/drivers/daqboard2000.c
microseconds one is called as each 16-bit word of
firmware data is written. Replace it with a fairly tight
`usleep_range(10, 20)` to avoid slowing down firmware loading too much.
The firmware is fairly short, so this would only slow it down firmware
loading by about 20 milliseconds or so.
Signed-off-by: Ian
el, but the existing code only works for channels 0
and 1. The driver only supports two DAC channels at the moment, so the
bug is currently harmless, but fix it so we can support four DAC
channels on some board models.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by
el, but the existing code only works for channels 0
and 1. The driver only supports two DAC channels at the moment, so the
bug is currently harmless, but fix it so we can support four DAC
channels on some board models.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: S
Reformat one of the block comments to conform to the usual style (it's
the only one that doesn't).
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 6 ++
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
Other CamelCase issues in this patch will be dealt with by l
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x80` that triggers setting one of the references.
Signed-off-by: Ian Abbott <a
Fix checkpatch issue: "CHECK: Please use a blank line after
function/struct/union/enum declarations".
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Fixed typo in patch description: `black line` --> `
Reformat one of the block comments to conform to the usual style (it's
the only one that doesn't).
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: No change.
---
drivers/staging/comedi/drivers/daqboard2000.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
Other CamelCase issues in this patch will be dealt with by later
patches in the series.
v2: Shortened prefix from
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x80` that triggers setting one of the references.
Signed-off-by: Ian Abbott
Reviewed
Fix checkpatch issue: "CHECK: Please use a blank line after
function/struct/union/enum declarations".
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Fixed typo in patch description: `black line` --> `blank line`.
---
drivers/staging/comedi/drivers/daqboard2000.c
Rename the macros defining values for the acquisition control register
to avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
---
v2: Shortened
Rename the macros defining values for the acquisition control register
to avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
---
drivers/staging
On 17/05/16 18:46, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
This series of patches to the daqboard2000 driver is mostly to fix the
checkpatch.pl warnings. There is one warning remaining about one of the
`udelay` calls with a parameter of 10 microseconds, but I
On 17/05/16 18:46, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
This series of patches to the daqboard2000 driver is mostly to fix the
checkpatch.pl warnings. There is one warning remaining about one of the
`udelay` calls with a parameter of 10 microseconds, but I
On 17/05/16 18:27, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
Other CamelCase issues in this
On 17/05/16 18:42, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
The checkpatch.pl warns about two `udelay(x)` calls, one of 100
microseconds, and one of 10 microseconds. The 100 microseconds one is
used when waiting for FPGA to become ready to accept firmware
On 17/05/16 18:27, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott
---
Other CamelCase issues in this patch will be dealt
On 17/05/16 18:42, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
The checkpatch.pl warns about two `udelay(x)` calls, one of 100
microseconds, and one of 10 microseconds. The 100 microseconds one is
used when waiting for FPGA to become ready to accept firmware
On 17/05/16 18:22, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.
On 17/05/16 18:22, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 26
On 17/05/16 18:14, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott <a
On 17/05/16 18:14, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott
---
drivers
<ravishankark...@gmail.com>
---
drivers/staging/comedi/drivers/pcmmio.c | 40 -
1 file changed, 20 insertions(+), 20 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk>
On 18/05/16 05:57, Ravishankar Karkala Mallikarjunayya wrote:
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/pcmmio.c | 40 -
1 file changed, 20 insertions(+), 20 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abb
At this point, it's probably best if you start again, and repost an
updated, and self-consistent, version 2 of your original series of 4
patches, tagged as "[PATCH v2 1/4]" etc. At the moment, everything is
too messed up.
--
-=( Ian Abbott @ MEV Ltd.
est if you start again, and repost an
updated, and self-consistent, version 2 of your original series of 4
patches, tagged as "[PATCH v2 1/4]" etc. At the moment, everything is
too messed up.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
*/
};
There's something weird going on above. In addition to reformatting the
comments, it's also replacing the type descriptors of some of the
members (using `u32` instead of `uint32_t` etc.). It looks like bits of
the patches from your earlier series have crept into this one.
thing weird going on above. In addition to reformatting the
comments, it's also replacing the type descriptors of some of the
members (using `u32` instead of `uint32_t` etc.). It looks like bits of
the patches from your earlier series have crept into this one.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=
nt val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
int ret;
/* D/A transfer rate is about 8ms */
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
ark...@gmail.com>
---
drivers/staging/comedi/drivers/dt2801.c | 95 +
1 file changed, 50 insertions(+), 45 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <ab
/staging/comedi/drivers/dt2801.c | 95 +
1 file changed, 50 insertions(+), 45 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 6 --
1 file changed, 6 del
501 - 600 of 2849 matches
Mail list logo
