Remove some commented out code. Some of it uses constructs that don't
exist in the driver, and probably come from the source code for the MS
Windows driver.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 6 --
1 file changed, 6 deletions(-)
diff --git
Fix checkpatch issues of the form "CHECK: spaces preferred around that
'*' (ctx:VxV)".
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
CamelCase issues in this patch will be dealt with by later patches.
---
drivers/staging/comedi/drivers/daqboard2000.c | 8
1
Fix checkpatch issues of the form "CHECK: spaces preferred around that
'*' (ctx:VxV)".
Signed-off-by: Ian Abbott
---
CamelCase issues in this patch will be dealt with by later patches.
---
drivers/staging/comedi/drivers/daqboard2000.c | 8
1 file changed, 4 insertions(+), 4
Rename the macros defining values for the acquisition control register
to avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 50 ---
Rename the macros defining values for the acquisition control register
to avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 50 ---
1 file changed, 23 insertions
is write-only.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 39 ++-
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
b/drivers/staging/comedi/drivers/daqboard
is write-only.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 39 ++-
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
b/drivers/staging/comedi/drivers/daqboard2000.c
index 3634331
are currently used by the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
b/drivers/staging/comedi/d
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
Other CamelCase issues in this patch will be dealt with by later
patches in the series.
---
drivers/staging/comedi/d
are currently used by the driver.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
b/drivers/staging/comedi/drivers/daqboard2000.c
index
Rename the macros defining register offsets to avoid CamelCase, and to
use namespace associated with the driver.
Signed-off-by: Ian Abbott
---
Other CamelCase issues in this patch will be dealt with by later
patches in the series.
---
drivers/staging/comedi/drivers/daqboard2000.c | 112
el, but the existing code only works for channels 0
and 1. The driver only supports two DAC channels at the moment, so the
bug is currently harmless, but fix it so we can support four DAC
channels on some board models.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/com
Rename the macros that define values for the trigger control register to
avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 26 ++
Rename the macros that define values for the trigger control register to
avoid CamelCase, and to make it clearer which register they are
associated with.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 26 ++
1 file changed, 14 insertions
el, but the existing code only works for channels 0
and 1. The driver only supports two DAC channels at the moment, so the
bug is currently harmless, but fix it so we can support four DAC
channels on some board models.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x80` that triggers setting one of the references.
Signed-off-by: Ian Abbott <a
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x80` that triggers setting one of the references.
Signed-off-by: Ian Abbott
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/d
Rename the macros defining values for the Serial EEPROM Control Register
to avoid CamelCase.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/comedi
microseconds one is called as each 16-bit word of
firmware data is written. A longer sleep would slow down firmware
loading, so leave it alone.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Rename functions to avoid CamelCase warnings from checkpatch, and to use
namespace associated with the driver.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 80 ++-
1 file changed, 41 insertions(+), 39 deletions(-)
microseconds one is called as each 16-bit word of
firmware data is written. A longer sleep would slow down firmware
loading, so leave it alone.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Rename functions to avoid CamelCase warnings from checkpatch, and to use
namespace associated with the driver.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 80 ++-
1 file changed, 41 insertions(+), 39 deletions(-)
diff --git a/drivers
Reformat one of the block comments to conform to the usual style (it's
the only one that doesn't).
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/
Reformat one of the block comments to conform to the usual style (it's
the only one that doesn't).
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
This series of patches to the daqboard2000 driver is mostly to fix the
checkpatch.pl warnings. There is one warning remaining about one of the
`udelay` calls with a parameter of 10 microseconds, but I decided to
leave it alone, as converting it to `usleep_range` could increase
firmware loading
This series of patches to the daqboard2000 driver is mostly to fix the
checkpatch.pl warnings. There is one warning remaining about one of the
`udelay` calls with a parameter of 10 microseconds, but I decided to
leave it alone, as converting it to `usleep_range` could increase
firmware loading
Fix checkpatch issue: "CHECK: Please use a black line after
function/struct/union/enum declarations".
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/daqboard2000.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/driver
Fix checkpatch issue: "CHECK: Please use a black line after
function/struct/union/enum declarations".
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/daqboard2000.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/daqboard2000.c
b/drive
oesn't compile. Also, there are several other CamelCase issues in
this driver, although probably too many to deal with in a single patch.
I'll have a shot at a slightly more extensive clean-up.
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
other CamelCase issues in
this driver, although probably too many to deal with in a single patch.
I'll have a shot at a slightly more extensive clean-up.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
ld fix up the
block comments to conform to that style, that would be great!
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
to conform to that style, that would be great!
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
(i = 0; i > insn->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mai
->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
andshake_eoc,
0);
+ ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+0);
if (ret)
return ret;
}
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd
patch is reasonable, but messes up the alignment of those comments,
especially the multi-line comments.
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+0);
if (ret)
return ret;
}
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web
the alignment of those comments,
especially the multi-line comments.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
->private;
uint16_t cra;
uint16_t crb;
- unsigned cntsrc, clkmult, clkpol;
+ unsigned int cntsrc, clkmult, clkpol;
/* Initialize CRA and CRB images. */
/* IndexSrc is passed through. */
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
_t cra;
uint16_t crb;
- unsigned cntsrc, clkmult, clkpol;
+ unsigned int cntsrc, clkmult, clkpol;
/* Initialize CRA and CRB images. */
/* IndexSrc is passed through. */
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.
rn s626_send_dac(dev, val);
}
Thanks!
That's not our usual commenting style, but it will do for now. (Our
usual style for "end of line" comments that don't fit on the line is to
convert them to comments on the preceding lines.)
Reviewed-by: Ian Abbott <abbo...@mev.co.uk&
Thanks!
That's not our usual commenting style, but it will do for now. (Our
usual style for "end of line" comments that don't fit on the line is to
convert them to comments on the preceding lines.)
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=(
truct comedi_device *dev,
unsigned long arg,
(s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY;
- ACCESS_ONCE(cfp->write_subdev) = s_new;
+ WRITE_ONCE(cfp->write_subdev, s_new);
return 0;
}
Thanks!
Reviewed-by: Ian Abbott
,
unsigned long arg,
(s_old->async->cmd.flags & CMDF_WRITE))
return -EBUSY;
- ACCESS_ONCE(cfp->write_subdev) = s_new;
+ WRITE_ONCE(cfp->write_subdev, s_new);
return 0;
}
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
In the kernel-doc comment for the `idr_for_each_entry_continue`, it is
called `idr_for_each_entry`. Correct the name in the comment.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
Cc: Andreas Gruenbacher <agr...@linbit.com>
Cc: Jens Axboe <ax...@fb.com>
Cc: Philipp Rei
In the kernel-doc comment for the `idr_for_each_entry_continue`, it is
called `idr_for_each_entry`. Correct the name in the comment.
Signed-off-by: Ian Abbott
Cc: Andreas Gruenbacher
Cc: Jens Axboe
Cc: Philipp Reisner
Cc: Randy Dunlap
---
include/linux/idr.h | 3 ++-
1 file changed, 2
On 06/04/16 10:41, Ian Abbott wrote:
On 06/04/16 02:21, Hartley Sweeten wrote:
On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
The variable unipolar was never used.
Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk>
---
There may be a chance that readin
On 06/04/16 10:41, Ian Abbott wrote:
On 06/04/16 02:21, Hartley Sweeten wrote:
On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
The variable unipolar was never used.
Signed-off-by: Sudip Mukherjee
---
There may be a chance that reading from DAS1800_CONTROL_C is necessary
before
he bug fix be placed at the top of your patch series?
Thanks.
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
patch series?
Thanks.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
struct comedi_device *dev);
bool comedi_is_subdevice_running(struct comedi_subdevice *s);
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
comedi_is_subdevice_running(struct comedi_subdevice *s);
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
The zero-length file "ni_mio_c_common.c" was inadvertantly created by
commit e563637b5fef ("staging: comedi: Use ARRAY_SIZE for sizes of
arrays"). Remove it.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/ni_mio_c_common.c | 0
1
The zero-length file "ni_mio_c_common.c" was inadvertantly created by
commit e563637b5fef ("staging: comedi: Use ARRAY_SIZE for sizes of
arrays"). Remove it.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_mio_c_common.c | 0
1 file changed, 0 insert
is fine, thanks.
Just a note on that dodgy-looking '>>' in the DT2821_CHANCSR_PRESLA
macro I seems to be a typo in 0f8e8c5ab67a ("staging: comedi:
dt282x: tidy up the register map and bit defines"). It should be a
left-shift. Fortunately, it isn't used, but we ought to correct it
sometime.
Reviewed-b
oking '>>' in the DT2821_CHANCSR_PRESLA
macro I seems to be a typo in 0f8e8c5ab67a ("staging: comedi:
dt282x: tidy up the register map and bit defines"). It should be a
left-shift. Fortunately, it isn't used, but we ought to correct it
sometime.
Re
), 156 deletions(-)
The patch would be okay, but it doesn't apply to the "staging-next"
branch of Greg's staging.git on git.kernel.org. (It doesn't apply to
the "master" branch of linux-next.git either.)
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
be okay, but it doesn't apply to the "staging-next"
branch of Greg's staging.git on git.kernel.org. (It doesn't apply to
the "master" branch of linux-next.git either.)
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
com>
---
drivers/staging/comedi/drivers/ni_tio.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
/ni_tio.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
kala Mallikarjunayya <ravishankark...@gmail.com>
---
drivers/staging/comedi/drivers/ni_tio.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: &l
kala Mallikarjunayya
---
drivers/staging/comedi/drivers/ni_tio.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
ark...@gmail.com>
---
drivers/staging/comedi/drivers/s626.c | 38 ++-
1 file changed, 24 insertions(+), 14 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
andshake_eoc,
0);
+ ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+0);
if (ret)
return ret;
}
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd
), 156 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
/staging/comedi/drivers/s626.c | 38 ++-
1 file changed, 24 insertions(+), 14 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+0);
if (ret)
return ret;
}
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web
-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
for the patch to adjust the whitespace on that line.
Ideally, the 'NITIO_INPUT_SEL_REG(cidx)' should line up with 'counter'
on the previous line, but that would take the line over 80 characters.
The current amount of whitespace is a compromise, but there is no need
to change it.
--
-=(
whitespace on that line.
Ideally, the 'NITIO_INPUT_SEL_REG(cidx)' should line up with 'counter'
on the previous line, but that would take the line over 80 characters.
The current amount of whitespace is a compromise, but there is no need
to change it.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=(
1 file changed, 2 insertions(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
com>
---
drivers/staging/comedi/drivers/s626.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
/s626.c | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
Just a minor niggle: there are a couple of unconverted
'int16_t' left behind by this patch, but those could be fixed in a
subsequent patch.
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
: there are a couple of unconverted
'int16_t' left behind by this patch, but those could be fixed in a
subsequent patch.
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
value.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/comedi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 9547324..ad5297f 100644
--- a/drivers/staging/comedi/comedi.h
+
value.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 9547324..ad5297f 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/co
Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging:
comedi: Prefer using the BIT macro"), but I replaced the use of the BIT
macro with hexadecimal constants instead of the original left bit-shift
expressions. We shouldn't use the BIT macro in "comedi.h" as it is
intended to be
Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging:
comedi: Prefer using the BIT macro"), but I replaced the use of the BIT
macro with hexadecimal constants instead of the original left bit-shift
expressions. We shouldn't use the BIT macro in "comedi.h" as it is
intended to be
e
same value. The `BIT` macro replaced expressions of the form `(1 << N)`
in this file originally, but reverting back to that form would encourage
patches changing them back to use the `BIT` macro.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/comedi.h | 10
e
same value. The `BIT` macro replaced expressions of the form `(1 << N)`
in this file originally, but reverting back to that form would encourage
patches changing them back to use the `BIT` macro.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi.h | 10 +-
1 file changed, 5
ruct mite_struct *mite,
struct mite_dma_descriptor_ring *ring,
unsigned min_channel, unsigned max_channel)
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
ruct *mite,
struct mite_dma_descriptor_ring *ring,
unsigned min_channel, unsigned max_channel)
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
On 23/02/16 12:38, Philippe Loctaux wrote:
On Tue, Feb 23, 2016 at 11:07:15AM +, Ian Abbott wrote:
Even better: just remove the macro, as it isn't used.
How can I do that? I'm asking that because my C knowledge
isn't very good :P
Are you sure you should be writing kernel patches
On 23/02/16 12:38, Philippe Loctaux wrote:
On Tue, Feb 23, 2016 at 11:07:15AM +, Ian Abbott wrote:
Even better: just remove the macro, as it isn't used.
How can I do that? I'm asking that because my C knowledge
isn't very good :P
Are you sure you should be writing kernel patches
ite.h"
-#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK)))
+#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK)))
It'd be nice to remove superfluous parentheses here too
+#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)
Even better: just remove the macro, as it isn't used.
--
-=( Ian Abbott @ MEV Ltd.E-m
ite.h"
-#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK)))
+#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK)))
It'd be nice to remove superfluous parentheses here too
+#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)
Even better: just remove the macro, as it isn't used.
--
-=( Ian Abbott @ MEV Ltd.
rivers/contec_pci_dio.c | 47 +
1 file changed, 24 insertions(+), 23 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
+
1 file changed, 24 insertions(+), 23 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
On 19/02/16 16:13, Ian Abbott wrote:
...stuff...
Sorry, I forgot to tag that email as "[PATCH 0/8]".
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
On 19/02/16 16:13, Ian Abbott wrote:
...stuff...
Sorry, I forgot to tag that email as "[PATCH 0/8]".
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
m
limiting how much can be freed in the second step. Change it to ignore
how much it managed to allocate in the first step and just use the
amount that was actually freed in the second step, which is the amount
the current buffer position was actually moved by this ioctl call.
Signed-off-by
m
limiting how much can be freed in the second step. Change it to ignore
how much it managed to allocate in the first step and just use the
amount that was actually freed in the second step, which is the amount
the current buffer position was actually moved by this ioctl call.
Signed-off-b
These patches change the behavior of the `COMEDI_BUFINFO` ioctl, which
is used to manage buffer positions for a previously set up asynchronous
acquisition command. It is used instead of the read and write file
operations when the buffer has been mmapped.
Patches 1 to 4 are fairly innocuous.
lue to 0 before copying the values back to the user.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/comedi_fops.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/
These patches change the behavior of the `COMEDI_BUFINFO` ioctl, which
is used to manage buffer positions for a previously set up asynchronous
acquisition command. It is used instead of the read and write file
operations when the buffer has been mmapped.
Patches 1 to 4 are fairly innocuous.
lue to 0 before copying the values back to the user.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_fops.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.
t successfully written to 0 in that case.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/comedi_fops.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index e625ef2..b7c9270 100644
--
601 - 700 of 2849 matches
Mail list logo
