[RFC PATCH 2/5] kmod - rename call_usermodehelper() flags parameter

2015-01-14 Thread Ian Kent
The wait parameter of call_usermodehelper() is not quite a parameter that describes the wait behaviour alone and will later be used to request exec within a namespace. So change its name to flags. Signed-off-by: Ian Kent ik...@redhat.com Cc: Benjamin Coddington bcodd...@redhat.com Cc: Al Viro v

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Ian Kent
On Wed, 2014-12-03 at 10:49 -0600, Eric W. Biederman wrote: > Ian Kent writes: > > > On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: > >> n Tue, 25 Nov 2014, Eric W. Biederman wrote: > >> Hi, > >> > >> > Ian Kent writes: > &

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Ian Kent
On Wed, 2014-12-03 at 10:49 -0600, Eric W. Biederman wrote: > > >> > Those are the general parameters. > >> > >> It does seem very expensive to keep a thread around for every mount; I'm > >> still trying to find a way around it.. > > > > Yeah, that's not such a good idea. > > > > Several hundred

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Ian Kent
On Wed, 2014-12-03 at 10:49 -0600, Eric W. Biederman wrote: Those are the general parameters. It does seem very expensive to keep a thread around for every mount; I'm still trying to find a way around it.. Yeah, that's not such a good idea. Several hundred mounts is going to

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-03 Thread Ian Kent
On Wed, 2014-12-03 at 10:49 -0600, Eric W. Biederman wrote: Ian Kent ik...@redhat.com writes: On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: n Tue, 25 Nov 2014, Eric W. Biederman wrote: Hi, Ian Kent ik...@redhat.com writes: On Tue, 2014-11-25 at 17:19 -0600

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-02 Thread Ian Kent
On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: > n Tue, 25 Nov 2014, Eric W. Biederman wrote: > Hi, > > > Ian Kent writes: > > > > > On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: > > >> Ian Kent writes: > > >&

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-12-02 Thread Ian Kent
On Mon, 2014-12-01 at 16:56 -0500, Benjamin Coddington wrote: n Tue, 25 Nov 2014, Eric W. Biederman wrote: Hi, Ian Kent ik...@redhat.com writes: On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: Ian Kent ik...@redhat.com writes: On Tue, 2014-11-25 at 16:23 -0600

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-27 Thread Ian Kent
On Tue, 2014-11-25 at 17:27 -0600, Eric W. Biederman wrote: > > > How does one correctly set the namespace in user space since each of > > the /proc//ns/ will use a slightly different > > proc_ns_operations install function? > > > > Are we saying that, for example, if open(/proc//ns/pid)/setns()

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-27 Thread Ian Kent
On Tue, 2014-11-25 at 17:27 -0600, Eric W. Biederman wrote: How does one correctly set the namespace in user space since each of the /proc/pid/ns/namespace will use a slightly different proc_ns_operations install function? Are we saying that, for example, if

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Wed, 2014-11-26 at 07:50 +0800, Ian Kent wrote: > > > > If we are going to set this stuff up in the kernel we need a reference > > process that we can create children of because what is possible with > > respect to containers keeps changing, and it is extremely error

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: > Ian Kent writes: > > > On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biederman wrote: > >> Oleg Nesterov writes: > >> > >> > On 11/25, Oleg Nesterov wrote: > >> >> > >>

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
> > Yes. > > And I have another concern... this is mostly a feeling, I can be > easily wrong but: > > > On 11/25, Ian Kent wrote: > > > > > > +static int umh_set_ns(struct subprocess_info *info, struct cred *new) > > > +{ > > > + struct nsprox

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
like this approach... > >> probably I am biased. > > > > Yes. > > > > And I have another concern... this is mostly a feeling, I can be > > easily wrong but: > > > >> On 11/25, Ian Kent wrote: > >> > > >> > +s

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 22:52 +0100, Oleg Nesterov wrote: > Let me first apologize, I didn't actually read this series yet. > > But I have to admit that so far I do not like this approach... > probably I am biased. Oleg, thanks for your comments. > > On 11/

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 22:52 +0100, Oleg Nesterov wrote: Let me first apologize, I didn't actually read this series yet. But I have to admit that so far I do not like this approach... probably I am biased. Oleg, thanks for your comments. On 11/25, Ian Kent wrote

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
. Yes. And I have another concern... this is mostly a feeling, I can be easily wrong but: On 11/25, Ian Kent wrote: +static int umh_set_ns(struct subprocess_info *info, struct cred *new) +{ +struct nsproxy *ns = info-data; + +mntns_setfs(ns-mnt_ns

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
... this is mostly a feeling, I can be easily wrong but: On 11/25, Ian Kent wrote: +static int umh_set_ns(struct subprocess_info *info, struct cred *new) +{ + struct nsproxy *ns = info-data; + + mntns_setfs(ns-mnt_ns); Firstly, it is not clear to me if we should use the caller's -mnt_ns

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Tue, 2014-11-25 at 17:19 -0600, Eric W. Biederman wrote: Ian Kent ik...@redhat.com writes: On Tue, 2014-11-25 at 16:23 -0600, Eric W. Biederman wrote: Oleg Nesterov o...@redhat.com writes: On 11/25, Oleg Nesterov wrote: Let me first apologize, I didn't actually read

Re: [RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-25 Thread Ian Kent
On Wed, 2014-11-26 at 07:50 +0800, Ian Kent wrote: If we are going to set this stuff up in the kernel we need a reference process that we can create children of because what is possible with respect to containers keeps changing, and it is extremely error prone to figure out what all

[RFC PATCH 2/4] nsproxy - make create_new_namespaces() non-static

2014-11-24 Thread Ian Kent
create_new_namespaces() will be needed by call_usermodehelper_ns() and call_usermodehelper_keys() for namespace restricted execution. Signed-off-by: Ian Kent Signed-off-by: Benjamin Coddington Cc: Al Viro Cc: J. Bruce Fields Cc: David Howells Cc: Trond Myklebust Cc: Stanislav Kinsbursky Cc

[RFC PATCH 4/4] KEYS: exec request-key within the requesting task's namespace

2014-11-24 Thread Ian Kent
From: Benjamin Coddington Copy the current task's namespaces into the request-key userspace helper to restrict contained processes from executing key instantiation processes outside their containers. Signed-off-by: Benjamin Coddington Signed-off-by: Ian Kent Cc: Al Viro Cc: J. Bruce Fields

[RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-24 Thread Ian Kent
erver need the ability to execute a binary within their container. To do this create a new nsproxy within the callers' context so it can be used for setup prior to calling do_execve() from the user mode helper thread runner. Signed-off-by: Ian Kent Signed-off-by: Benjamin Coddington Cc: Al Viro Cc

[RFC PATCH 1/4] vfs - fs/namespaces.c: break out mntns_setfs() from mntns_install()

2014-11-24 Thread Ian Kent
-off-by: Benjamin Coddington Signed-off-by: Ian Kent Cc: Al Viro Cc: J. Bruce Fields Cc: David Howells Cc: Trond Myklebust Cc: Stanislav Kinsbursky Cc: Oleg Nesterov Cc: Eric W. Biederman --- fs/namespace.c| 41 + include/linux/mount.h

[RFC PATCH 0/4] Namespace contrained helper execution

2014-11-24 Thread Ian Kent
namespace environment then switch to it and setup fs_struct for path walking prior to the user mode helper thread runner calling do_execve(). Please review and comment on the patch series. Ian --- Benjamin Coddington (1): KEYS: exec request-key within the requesting task's namespace Ian Kent

[RFC PATCH 0/4] Namespace contrained helper execution

2014-11-24 Thread Ian Kent
namespace environment then switch to it and setup fs_struct for path walking prior to the user mode helper thread runner calling do_execve(). Please review and comment on the patch series. Ian --- Benjamin Coddington (1): KEYS: exec request-key within the requesting task's namespace Ian Kent

[RFC PATCH 4/4] KEYS: exec request-key within the requesting task's namespace

2014-11-24 Thread Ian Kent
From: Benjamin Coddington bcodd...@redhat.com Copy the current task's namespaces into the request-key userspace helper to restrict contained processes from executing key instantiation processes outside their containers. Signed-off-by: Benjamin Coddington bcodd...@redhat.com Signed-off-by: Ian

[RFC PATCH 3/4] kmod - add call_usermodehelper_ns() helper

2014-11-24 Thread Ian Kent
the ability to execute a binary within their container. To do this create a new nsproxy within the callers' context so it can be used for setup prior to calling do_execve() from the user mode helper thread runner. Signed-off-by: Ian Kent ik...@redhat.com Signed-off-by: Benjamin Coddington bcodd

[RFC PATCH 1/4] vfs - fs/namespaces.c: break out mntns_setfs() from mntns_install()

2014-11-24 Thread Ian Kent
-off-by: Benjamin Coddington bcodd...@redhat.com Signed-off-by: Ian Kent ik...@redhat.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: J. Bruce Fields bfie...@fieldses.org Cc: David Howells dhowe...@redhat.com Cc: Trond Myklebust trond.mykleb...@primarydata.com Cc: Stanislav Kinsbursky skinsbur

[RFC PATCH 2/4] nsproxy - make create_new_namespaces() non-static

2014-11-24 Thread Ian Kent
create_new_namespaces() will be needed by call_usermodehelper_ns() and call_usermodehelper_keys() for namespace restricted execution. Signed-off-by: Ian Kent ik...@redhat.com Signed-off-by: Benjamin Coddington bcodd...@redhat.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: J. Bruce Fields bfie

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-12 Thread Ian Kent
On Thu, 2014-11-13 at 08:10 +0800, Ian Kent wrote: > > > > The tree which these patches were based on seem to have more than a > > plain rename. For example I get > > Right, looks like something has gone missing along the way. Ahh .. I get it now. > The tree the

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-12 Thread Ian Kent
On Wed, 2014-11-12 at 15:07 -0800, Andrew Morton wrote: > On Tue, 11 Nov 2014 14:01:52 +0800 Ian Kent wrote: > > > I guess I could make a kernel.org tree but, apart from this recent > > rename autofs4 -> autofs, the number of autofs changes hasn't warranted > >

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-12 Thread Ian Kent
On Wed, 2014-11-12 at 15:07 -0800, Andrew Morton wrote: On Tue, 11 Nov 2014 14:01:52 +0800 Ian Kent ra...@themaw.net wrote: I guess I could make a kernel.org tree but, apart from this recent rename autofs4 - autofs, the number of autofs changes hasn't warranted maintaining a separate tree

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-12 Thread Ian Kent
On Thu, 2014-11-13 at 08:10 +0800, Ian Kent wrote: The tree which these patches were based on seem to have more than a plain rename. For example I get Right, looks like something has gone missing along the way. Ahh .. I get it now. The tree the patches are against is just a local

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
On Mon, 2014-11-10 at 21:49 -0800, Joe Perches wrote: > On Tue, 2014-11-11 at 13:37 +0800, Ian Kent wrote: > > On Mon, 2014-11-10 at 19:25 -0800, Joe Perches wrote: > > > On Tue, 2014-11-11 at 09:29 +0800, Ian Kent wrote: > > > > Fix some inconsistencies

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
On Mon, 2014-11-10 at 21:49 -0800, Joe Perches wrote: > On Tue, 2014-11-11 at 13:37 +0800, Ian Kent wrote: > > On Mon, 2014-11-10 at 19:25 -0800, Joe Perches wrote: > > > On Tue, 2014-11-11 at 09:29 +0800, Ian Kent wrote: > > > > Fix some inconsistencies

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
On Mon, 2014-11-10 at 19:25 -0800, Joe Perches wrote: > On Tue, 2014-11-11 at 09:29 +0800, Ian Kent wrote: > > Fix some inconsistencies in log print output and ensure that > > the module name is included in all log prints. > > > > Signed-off-by: Ian Kent > >

[PATCH 2/3] autofs - change log prints to not insert newline

2014-11-10 Thread Ian Kent
Common kernel coding practice is to include the newline of log prints within the log text rather than hidden away in a macro. To avoid introducing inconsistencies as changes are made change the log macros to not include the newline. Signed-off-by: Ian Kent Cc: Joe Perches --- fs/autofs

[PATCH 3/3] autofs - use pr_xxx() calls directly for logging

2014-11-10 Thread Ian Kent
From: Ian Kent --- fs/autofs/autofs_i.h | 15 --- fs/autofs/dev-ioctl.c | 26 +- fs/autofs/expire.c| 42 +- fs/autofs/inode.c | 17 - fs/autofs/root.c | 44

[PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
Fix some inconsistencies in log print output and ensure that the module name is included in all log prints. Signed-off-by: Ian Kent Cc: Joe Perches --- fs/autofs/autofs_i.h |6 +++--- fs/autofs/dev-ioctl.c |2 +- fs/autofs/inode.c | 10 +- fs/autofs/waitq.c |4

[PATCH 3/3] autofs - use pr_xxx() calls directly for logging

2014-11-10 Thread Ian Kent
From: Ian Kent ik...@redhat.com --- fs/autofs/autofs_i.h | 15 --- fs/autofs/dev-ioctl.c | 26 +- fs/autofs/expire.c| 42 +- fs/autofs/inode.c | 17 - fs/autofs/root.c | 44

[PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
Fix some inconsistencies in log print output and ensure that the module name is included in all log prints. Signed-off-by: Ian Kent ra...@themaw.net Cc: Joe Perches j...@perches.com --- fs/autofs/autofs_i.h |6 +++--- fs/autofs/dev-ioctl.c |2 +- fs/autofs/inode.c | 10

[PATCH 2/3] autofs - change log prints to not insert newline

2014-11-10 Thread Ian Kent
Common kernel coding practice is to include the newline of log prints within the log text rather than hidden away in a macro. To avoid introducing inconsistencies as changes are made change the log macros to not include the newline. Signed-off-by: Ian Kent ra...@themaw.net Cc: Joe Perches j

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
On Mon, 2014-11-10 at 19:25 -0800, Joe Perches wrote: On Tue, 2014-11-11 at 09:29 +0800, Ian Kent wrote: Fix some inconsistencies in log print output and ensure that the module name is included in all log prints. Signed-off-by: Ian Kent ra...@themaw.net Cc: Joe Perches j...@perches.com

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
On Mon, 2014-11-10 at 21:49 -0800, Joe Perches wrote: On Tue, 2014-11-11 at 13:37 +0800, Ian Kent wrote: On Mon, 2014-11-10 at 19:25 -0800, Joe Perches wrote: On Tue, 2014-11-11 at 09:29 +0800, Ian Kent wrote: Fix some inconsistencies in log print output and ensure that the module

Re: [PATCH 1/3] autofs - fix log print messages

2014-11-10 Thread Ian Kent
On Mon, 2014-11-10 at 21:49 -0800, Joe Perches wrote: On Tue, 2014-11-11 at 13:37 +0800, Ian Kent wrote: On Mon, 2014-11-10 at 19:25 -0800, Joe Perches wrote: On Tue, 2014-11-11 at 09:29 +0800, Ian Kent wrote: Fix some inconsistencies in log print output and ensure that the module

Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-05 Thread Ian Kent
On Wed, 2014-11-05 at 15:20 -0800, Joe Perches wrote: > > > But idea of using pr_xxx() and pr_fmt() (actually that's too open to > > name clashes so it would need to be named something like autofs_pr_fmt() > > anyway) looks like it results in less readable code so I'd really prefer > > not to do

Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-05 Thread Ian Kent
On Mon, 2014-11-03 at 06:33 -0800, Joe Perches wrote: > > That's fine. I left out the trailing semicolon/space. > The pr_fmt could be something like: > #define pr_fmt(fmt) KBUILD_MODNAME ":%d:%s: " fmt, current->pid, __func__ > or add a "pid:" descriptor prefix if you like too: > #define

Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-05 Thread Ian Kent
On Mon, 2014-11-03 at 06:33 -0800, Joe Perches wrote: That's fine. I left out the trailing semicolon/space. The pr_fmt could be something like: #define pr_fmt(fmt) KBUILD_MODNAME :%d:%s: fmt, current-pid, __func__ or add a pid: descriptor prefix if you like too: #define pr_fmt(fmt)

Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-05 Thread Ian Kent
On Wed, 2014-11-05 at 15:20 -0800, Joe Perches wrote: But idea of using pr_xxx() and pr_fmt() (actually that's too open to name clashes so it would need to be named something like autofs_pr_fmt() anyway) looks like it results in less readable code so I'd really prefer not to do that.

Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-03 Thread Ian Kent
On Mon, 2014-11-03 at 00:25 -0800, Joe Perches wrote: > On Mon, 2014-11-03 at 16:12 +0800, Ian Kent wrote: > > Use the AUTOFS_*() print defines instead of raw printks. > > Please check the output of these conversions. > > For instance: > > > diff --git a/fs/autofs

[PATCH 03/13] autofs4 - use pr print in AUTOFS prints

2014-11-03 Thread Ian Kent
Use the pr_*() print in AUTOFS_*() defines instead of printks. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index 0a1fcdc..b33b939 100644 --- a/fs/autofs4/autofs_i.h

[PATCH 07/13] autofs - merge auto_fs.h and auto_fs4.h

2014-11-03 Thread Ian Kent
The autofs module has long since been removed so there's no need to have two separate include files for autofs. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h |2 - fs/compat_ioctl.c |1 include/uapi/linux/auto_fs.h | 147

[PATCH 11/13] autofs - update fs/autofs4/Kconfig

2014-11-03 Thread Ian Kent
Update Kconfig and add a depricated warning. Signed-off-by: Ian Kent --- fs/autofs4/Kconfig | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 1204d63..26dbb00 100644 --- a/fs/autofs4/Kconfig

[PATCH 09/13] autofs - copy autofs4 to autofs

2014-11-03 Thread Ian Kent
Copy source files from the autofs4 directory to the autofs directory. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h | 283 +++ fs/autofs/dev-ioctl.c | 763 fs/autofs/expire.c| 618 fs/autofs/init.c

[PATCH 13/13] autofs - delete fs/autofs4 source files

2014-11-03 Thread Ian Kent
Delete the now unused autofs4 module files. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h | 283 -- fs/autofs4/dev-ioctl.c | 764 --- fs/autofs4/expire.c| 619 fs/autofs4/init.c | 49 --- fs

[PATCH 06/13] autofs4 - move linux/auto_dev-ioctl.h to uapi/linux

2014-11-03 Thread Ian Kent
Since linux/auto_dev-ioctl.h wasn't included in include/linux/Kbuild (although I should have added it) it wasn't moved to uapi/linux as part of the uapi series. Signed-off-by: Ian Kent --- include/linux/auto_dev-ioctl.h | 223 --- include/uapi/linux

[PATCH 10/13] autofs - create autofs Kconfig and Makefile

2014-11-03 Thread Ian Kent
Create Makefile and Kconfig for autofs module. Signed-off-by: Ian Kent --- fs/Kconfig |1 + fs/Makefile|1 + fs/autofs/Kconfig | 19 +++ fs/autofs/Makefile |7 +++ 4 files changed, 28 insertions(+) create mode 100644 fs/autofs/Kconfig create

[PATCH 05/13] autofs4 - fix string.h include in auto_dev-ioctl.h

2014-11-03 Thread Ian Kent
Since including linux/string.h will now do the right thing remove the conditional check. Signed-off-by: Ian Kent --- include/linux/auto_dev-ioctl.h |5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/auto_dev-ioctl.h b/include/linux/auto_dev-ioctl.h index 6427816..7caaf29

[PATCH 12/13] autofs - update fs/autofs4/Makefile

2014-11-03 Thread Ian Kent
Update Makefile to build from source in fs/autofs instead of fs/autofs4. Signed-off-by: Ian Kent --- fs/autofs4/Makefile |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/Makefile b/fs/autofs4/Makefile index a811c1f..417dd72 100644 --- a/fs/autofs4/Makefile

[PATCH 08/13] autofs - use autofs instead of autofs4 everywhere

2014-11-03 Thread Ian Kent
Update naming within autofs source to be consistent by changing occurrences of autofs4 to autofs. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h | 88 fs/autofs4/dev-ioctl.c | 18 ++- fs/autofs4/expire.c| 132 fs/autofs4/init.c | 12

[PATCH 02/13] autofs4 - fix some white space errors

2014-11-03 Thread Ian Kent
Fix some white space format errors. Signed-off-by: Ian Kent --- fs/autofs4/inode.c|2 +- fs/autofs4/root.c |8 fs/autofs4/waitq.c|2 +- include/uapi/linux/auto_fs.h |2 +- include/uapi/linux/auto_fs4.h |2 +- 5 files changed, 8

[PATCH 01/13] autofs4 - coding style fixes

2014-11-03 Thread Ian Kent
Try and make the coding style completely consistent throughtout the autofs module and inline with kernel coding style recommendations. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h | 42 +++-- fs/autofs4/dev-ioctl.c | 24 fs/autofs4/expire.c

[PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-03 Thread Ian Kent
Use the AUTOFS_*() print defines instead of raw printks. Signed-off-by: Ian Kent --- fs/autofs4/inode.c | 13 +++-- fs/autofs4/waitq.c |2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index 80389af..7849591 100644

[PATCH 02/13] autofs4 - fix some white space errors

2014-11-03 Thread Ian Kent
Fix some white space format errors. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/inode.c|2 +- fs/autofs4/root.c |8 fs/autofs4/waitq.c|2 +- include/uapi/linux/auto_fs.h |2 +- include/uapi/linux/auto_fs4.h |2 +- 5

[PATCH 01/13] autofs4 - coding style fixes

2014-11-03 Thread Ian Kent
Try and make the coding style completely consistent throughtout the autofs module and inline with kernel coding style recommendations. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/autofs_i.h | 42 +++-- fs/autofs4/dev-ioctl.c | 24 fs

[PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-03 Thread Ian Kent
Use the AUTOFS_*() print defines instead of raw printks. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/inode.c | 13 +++-- fs/autofs4/waitq.c |2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index 80389af

[PATCH 05/13] autofs4 - fix string.h include in auto_dev-ioctl.h

2014-11-03 Thread Ian Kent
Since including linux/string.h will now do the right thing remove the conditional check. Signed-off-by: Ian Kent ra...@themaw.net --- include/linux/auto_dev-ioctl.h |5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/auto_dev-ioctl.h b/include/linux/auto_dev-ioctl.h index

[PATCH 12/13] autofs - update fs/autofs4/Makefile

2014-11-03 Thread Ian Kent
Update Makefile to build from source in fs/autofs instead of fs/autofs4. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/Makefile |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/Makefile b/fs/autofs4/Makefile index a811c1f..417dd72 100644 --- a/fs

[PATCH 08/13] autofs - use autofs instead of autofs4 everywhere

2014-11-03 Thread Ian Kent
Update naming within autofs source to be consistent by changing occurrences of autofs4 to autofs. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/autofs_i.h | 88 fs/autofs4/dev-ioctl.c | 18 ++- fs/autofs4/expire.c| 132 fs/autofs4

[PATCH 13/13] autofs - delete fs/autofs4 source files

2014-11-03 Thread Ian Kent
Delete the now unused autofs4 module files. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/autofs_i.h | 283 -- fs/autofs4/dev-ioctl.c | 764 --- fs/autofs4/expire.c| 619 fs/autofs4/init.c

[PATCH 06/13] autofs4 - move linux/auto_dev-ioctl.h to uapi/linux

2014-11-03 Thread Ian Kent
Since linux/auto_dev-ioctl.h wasn't included in include/linux/Kbuild (although I should have added it) it wasn't moved to uapi/linux as part of the uapi series. Signed-off-by: Ian Kent ra...@themaw.net --- include/linux/auto_dev-ioctl.h | 223 --- include

[PATCH 10/13] autofs - create autofs Kconfig and Makefile

2014-11-03 Thread Ian Kent
Create Makefile and Kconfig for autofs module. Signed-off-by: Ian Kent ra...@themaw.net --- fs/Kconfig |1 + fs/Makefile|1 + fs/autofs/Kconfig | 19 +++ fs/autofs/Makefile |7 +++ 4 files changed, 28 insertions(+) create mode 100644 fs/autofs

[PATCH 09/13] autofs - copy autofs4 to autofs

2014-11-03 Thread Ian Kent
Copy source files from the autofs4 directory to the autofs directory. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs/autofs_i.h | 283 +++ fs/autofs/dev-ioctl.c | 763 fs/autofs/expire.c| 618

[PATCH 07/13] autofs - merge auto_fs.h and auto_fs4.h

2014-11-03 Thread Ian Kent
The autofs module has long since been removed so there's no need to have two separate include files for autofs. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/autofs_i.h |2 - fs/compat_ioctl.c |1 include/uapi/linux/auto_fs.h | 147

[PATCH 11/13] autofs - update fs/autofs4/Kconfig

2014-11-03 Thread Ian Kent
Update Kconfig and add a depricated warning. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/Kconfig | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 1204d63..26dbb00 100644 --- a/fs

[PATCH 03/13] autofs4 - use pr print in AUTOFS prints

2014-11-03 Thread Ian Kent
Use the pr_*() print in AUTOFS_*() defines instead of printks. Signed-off-by: Ian Kent ra...@themaw.net --- fs/autofs4/autofs_i.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index 0a1fcdc..b33b939 100644 --- a/fs

Re: [PATCH 04/13] autofs4 - change printks AUTOFS defined prints

2014-11-03 Thread Ian Kent
On Mon, 2014-11-03 at 00:25 -0800, Joe Perches wrote: On Mon, 2014-11-03 at 16:12 +0800, Ian Kent wrote: Use the AUTOFS_*() print defines instead of raw printks. Please check the output of these conversions. For instance: diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c

[PATCH] autofs - remove obsolete d_invalidate() from expire

2014-09-09 Thread Ian Kent
accumulating following failed mounts I'll revisit the issue and possibly add a shrink_dcache_parent() call if needed. Signed-off-by: Ian Kent Cc: Al Viro Cc: Eric W. Biederman --- fs/autofs4/expire.c |6 -- 1 file changed, 6 deletions(-) diff --git a/fs/autofs4/expire.c b/fs/autofs4

[PATCH] autofs - remove obsolete d_invalidate() from expire

2014-09-09 Thread Ian Kent
accumulating following failed mounts I'll revisit the issue and possibly add a shrink_dcache_parent() call if needed. Signed-off-by: Ian Kent ra...@themaw.net Cc: Al Viro v...@zeniv.linux.org.uk Cc: Eric W. Biederman ebied...@xmission.com --- fs/autofs4/expire.c |6 -- 1 file changed, 6

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-20 Thread Ian Kent
On Wed, 2014-08-20 at 11:42 +0800, Ian Kent wrote: > Great minds think alike. > I have basically the exact same patch and I'm testing now. > It probably should be folded into "autofs4: avoid taking fs_lock during > rcu-walk". > > It takes ages though, the test ha

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-20 Thread Ian Kent
On Wed, 2014-08-20 at 11:42 +0800, Ian Kent wrote: Great minds think alike. I have basically the exact same patch and I'm testing now. It probably should be folded into autofs4: avoid taking fs_lock during rcu-walk. It takes ages though, the test has two configurations to test and each one

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Wed, 2014-08-20 at 11:42 +0800, Ian Kent wrote: > > > > From 201f75bc25906e8f64e28b37f1bb478958bf2987 Mon Sep 17 00:00:00 2001 > > From: NeilBrown > > Date: Wed, 20 Aug 2014 12:40:06 +1000 > > Subject: [PATCH] autofs4: make "autofs4_can_expire" ide

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Wed, 2014-08-20 at 13:13 +1000, NeilBrown wrote: > On Tue, 19 Aug 2014 20:36:55 +0800 Ian Kent wrote: > > > On Tue, 2014-08-19 at 21:16 +1000, NeilBrown wrote: > > > On Tue, 19 Aug 2014 18:02:27 +0800 Ian Kent wrote: > > > > > > > On Mon,

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Tue, 2014-08-19 at 21:16 +1000, NeilBrown wrote: > On Tue, 19 Aug 2014 18:02:27 +0800 Ian Kent wrote: > > > On Mon, 2014-08-18 at 16:25 +0800, Ian Kent wrote: > > > On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: > > > > Hi Ian, > > >

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Tue, 2014-08-19 at 21:16 +1000, NeilBrown wrote: > On Tue, 19 Aug 2014 18:02:27 +0800 Ian Kent wrote: > > > On Mon, 2014-08-18 at 16:25 +0800, Ian Kent wrote: > > > On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: > > > > Hi Ian, > > >

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Mon, 2014-08-18 at 16:25 +0800, Ian Kent wrote: > On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: > > Hi Ian, > > Have you had a chance to run your tests in these patches yet? > > I've done what testing I can think of and cannot fault them. > > I haven't, I'v

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Wed, 2014-08-20 at 13:13 +1000, NeilBrown wrote: On Tue, 19 Aug 2014 20:36:55 +0800 Ian Kent ra...@themaw.net wrote: On Tue, 2014-08-19 at 21:16 +1000, NeilBrown wrote: On Tue, 19 Aug 2014 18:02:27 +0800 Ian Kent ra...@themaw.net wrote: On Mon, 2014-08-18 at 16:25 +0800, Ian

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Wed, 2014-08-20 at 11:42 +0800, Ian Kent wrote: From 201f75bc25906e8f64e28b37f1bb478958bf2987 Mon Sep 17 00:00:00 2001 From: NeilBrown ne...@suse.de Date: Wed, 20 Aug 2014 12:40:06 +1000 Subject: [PATCH] autofs4: make autofs4_can_expire idempotent. Have a test function change

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Mon, 2014-08-18 at 16:25 +0800, Ian Kent wrote: On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: Hi Ian, Have you had a chance to run your tests in these patches yet? I've done what testing I can think of and cannot fault them. I haven't, I've been plagued with illness so I'm

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Tue, 2014-08-19 at 21:16 +1000, NeilBrown wrote: On Tue, 19 Aug 2014 18:02:27 +0800 Ian Kent ra...@themaw.net wrote: On Mon, 2014-08-18 at 16:25 +0800, Ian Kent wrote: On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: Hi Ian, Have you had a chance to run your tests

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-19 Thread Ian Kent
On Tue, 2014-08-19 at 21:16 +1000, NeilBrown wrote: On Tue, 19 Aug 2014 18:02:27 +0800 Ian Kent ra...@themaw.net wrote: On Mon, 2014-08-18 at 16:25 +0800, Ian Kent wrote: On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: Hi Ian, Have you had a chance to run your tests

Re: [PATCH 5/5] autofs: the documentation I wanted to read

2014-08-18 Thread Ian Kent
some places. > > The document assumes the functionality added by the RCU-walk patches > that I posted recently. > > It is formatted using "markdown" and works best with Markdown.pl > (markdown_py doesn't like some constructs). > > > Copy-edited-by: Randy Dunlap

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-18 Thread Ian Kent
On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: > Hi Ian, > Have you had a chance to run your tests in these patches yet? > I've done what testing I can think of and cannot fault them. I haven't, I've been plagued with illness so I'm not getting nearly enough done. I'll try to put a kernel

Re: [PATCH 0/5] RCU-walk support for autofs

2014-08-18 Thread Ian Kent
On Mon, 2014-08-18 at 16:33 +1000, NeilBrown wrote: Hi Ian, Have you had a chance to run your tests in these patches yet? I've done what testing I can think of and cannot fault them. I haven't, I've been plagued with illness so I'm not getting nearly enough done. I'll try to put a kernel

Re: [PATCH 5/5] autofs: the documentation I wanted to read

2014-08-18 Thread Ian Kent
-by: Ian Kent ra...@themaw.net --- Documentation/filesystems/autofs4.txt | 520 + 1 file changed, 520 insertions(+) create mode 100644 Documentation/filesystems/autofs4.txt diff --git a/Documentation/filesystems/autofs4.txt b/Documentation/filesystems

Re: [PATCH/RFC] autofs: the documentation I wanted to read

2014-07-31 Thread Ian Kent
in some places. > > The document assumes the functionality added by the RCU-walk patches > that I posted recently. > > It is formatted using "markdown" and works best with Markdown.pl > (markdown_py doesn't like some constructs). > > > Signed-off-by: NeilBrow

Re: [PATCH/RFC] autofs: the documentation I wanted to read

2014-07-31 Thread Ian Kent
. The document assumes the functionality added by the RCU-walk patches that I posted recently. It is formatted using markdown and works best with Markdown.pl (markdown_py doesn't like some constructs). Signed-off-by: NeilBrown ne...@suse.de Acked-by: Ian Kent ra...@themaw.net There are a couple

Re: [PATCH 3/6] autofs4: allow RCU-walk to walk through autofs4.

2014-07-29 Thread Ian Kent
On Tue, 2014-07-29 at 11:51 +1000, NeilBrown wrote: > On Thu, 17 Jul 2014 18:17:32 +0800 Ian Kent wrote: > > > > > On Thu, 2014-07-17 at 18:04 +1000, NeilBrown wrote: > > > If there some documentation about the interactions between the automountd > > > and &

Re: [PATCH 3/6] autofs4: allow RCU-walk to walk through autofs4.

2014-07-29 Thread Ian Kent
On Tue, 2014-07-29 at 11:51 +1000, NeilBrown wrote: On Thu, 17 Jul 2014 18:17:32 +0800 Ian Kent ra...@themaw.net wrote: On Thu, 2014-07-17 at 18:04 +1000, NeilBrown wrote: If there some documentation about the interactions between the automountd and the kernel? Not really

Re: [PATCH v4] fs: umount on symlink leaks mnt count

2014-07-23 Thread Ian Kent
ast() gets an extra refcount on path->mnt > > Signed-off-by: Vasily Averin Acked-by: Ian Kent I was working on this too. I prefer this patch over my own. Haven't tested it yet but it is very similar to the patch I was working with which had seen some basic testing. > --- > fs/namei.c

<    4   5   6   7   8   9   10   11   12   13   >