Re: [patch] net/DCCP: fix link error with !CONFIG_SYSCTL

2007-10-15 Thread Ian McDonald
x] Error 1 > > found via 'make randconfig' build testing. > > Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Ingo - this should go via [EMAIL PROTECTED] or [EMAIL PROTECTED] so it gets picked up by a maintainer. Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> - To unsubscr

Re: [patch] net/DCCP: fix link error with !CONFIG_SYSCTL

2007-10-15 Thread Ian McDonald
-by: Ingo Molnar [EMAIL PROTECTED] Ingo - this should go via [EMAIL PROTECTED] or [EMAIL PROTECTED] so it gets picked up by a maintainer. Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

Re: [PATCH] [148/2many] MAINTAINERS - DCCP PROTOCOL

2007-08-13 Thread Ian McDonald
as part of DCCP subsystem: F: include/linux/tfrc.h Once this is done, and series goes in then: Acked-by: Ian McDonald <[EMAIL PROTECTED]> -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line "un

Re: [PATCH] [148/2many] MAINTAINERS - DCCP PROTOCOL

2007-08-13 Thread Ian McDonald
, and series goes in then: Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()

2007-07-26 Thread Ian McDonald
easily enough by adding a kfree(opt); before the return statement. The patch also changes the layout of the 'switch' to be more in line with CodingStyle. Patch has been compile tested. Please consider merging. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Signed-off-by: Ian McDo

Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()

2007-07-26 Thread Ian McDonald
enough by adding a kfree(opt); before the return statement. The patch also changes the layout of the 'switch' to be more in line with CodingStyle. Patch has been compile tested. Please consider merging. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED

Re: [2.6 patch] the overdue eepro100 removal

2007-07-09 Thread Ian McDonald
On 7/10/07, Bill Davidsen <[EMAIL PROTECTED]> wrote: If there were any benefit to removing a working driver I would at least be able to see it as a resources issue, but as far as I can see you just seem to have a personal preference for the e100 driver and want to force others to use it because

Re: [2.6 patch] the overdue eepro100 removal

2007-07-09 Thread Ian McDonald
On 7/10/07, Bill Davidsen [EMAIL PROTECTED] wrote: If there were any benefit to removing a working driver I would at least be able to see it as a resources issue, but as far as I can see you just seem to have a personal preference for the e100 driver and want to force others to use it because

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
On 6/21/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: And yes, sometimes debugging *does* change what it debugs. In timing, if nothing else, but also in the kinds of things you can do. Totally agree. For example, we don't allow slab redzoning on data structures that have alignment

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
On 6/21/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: Well, for 2.6.22, Kprobes will just be disabled if you use DEBUG_RODATA. And yes, that patch already got merged. However, the patch to *allow* Kprobes with DEBUG_RODATA is not, and will not be. It's not a regression, and quite frankly, I

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
On 6/21/07, Chuck Ebbert <[EMAIL PROTECTED]> wrote: >> Subject: CONFIG_DEBUG_RODATA prevents kprobes from working on >> 2.6.22-rc2 >> References : http://lkml.org/lkml/2007/5/23/202 >> Submitter : William Cohen <[EMAIL PROTECTED]> >> I

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
Andrew, Can this one be merged so that it makes it into 2.6.22? Subject: CONFIG_DEBUG_RODATA prevents kprobes from working on 2.6.22-rc2 References : http://lkml.org/lkml/2007/5/23/202 Submitter : William Cohen <[EMAIL PROTECTED]> Ian McDonald <[EMAIL PROTECTED]

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
Andrew, Can this one be merged so that it makes it into 2.6.22? Subject: CONFIG_DEBUG_RODATA prevents kprobes from working on 2.6.22-rc2 References : http://lkml.org/lkml/2007/5/23/202 Submitter : William Cohen [EMAIL PROTECTED] Ian McDonald [EMAIL PROTECTED] Handled-By : S

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
On 6/21/07, Chuck Ebbert [EMAIL PROTECTED] wrote: Subject: CONFIG_DEBUG_RODATA prevents kprobes from working on 2.6.22-rc2 References : http://lkml.org/lkml/2007/5/23/202 Submitter : William Cohen [EMAIL PROTECTED] Ian McDonald [EMAIL PROTECTED] Handled-By : S. P

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
On 6/21/07, Linus Torvalds [EMAIL PROTECTED] wrote: Well, for 2.6.22, Kprobes will just be disabled if you use DEBUG_RODATA. And yes, that patch already got merged. However, the patch to *allow* Kprobes with DEBUG_RODATA is not, and will not be. It's not a regression, and quite frankly, I don't

Re: [1/2] 2.6.22-rc5: known regressions with patches

2007-06-20 Thread Ian McDonald
On 6/21/07, Linus Torvalds [EMAIL PROTECTED] wrote: And yes, sometimes debugging *does* change what it debugs. In timing, if nothing else, but also in the kinds of things you can do. Totally agree. For example, we don't allow slab redzoning on data structures that have alignment restrictions

Re: [PATCH] Kprobes i386 fix for mark ro data

2007-06-10 Thread Ian McDonald
On 6/7/07, S. P. Prasanna <[EMAIL PROTECTED]> wrote: > >It faulted when it tried to write the breakpoint instruction into the > >running kernel's executable code. Apparently the kernel code is now marked > >read-only? > > > > > Yes it would appear to be the case as user has CONFIG_DEBUG_RODATA >

Re: [PATCH] Kprobes i386 fix for mark ro data

2007-06-10 Thread Ian McDonald
On 6/7/07, S. P. Prasanna [EMAIL PROTECTED] wrote: It faulted when it tried to write the breakpoint instruction into the running kernel's executable code. Apparently the kernel code is now marked read-only? Yes it would appear to be the case as user has CONFIG_DEBUG_RODATA set. Patrick

Re: [BUG] Fwd: segfault : modprobe dccp_probe/tcp_probe

2007-06-06 Thread Ian McDonald
On 6/7/07, Chuck Ebbert <[EMAIL PROTECTED]> wrote: On 06/06/2007 04:47 PM, Ian McDonald wrote: > Hi there, > > We've seen a report of a problem with dccp_probe as shown below. The > user has also verified that it occurs in tcp_probe as well. This is on > Dave Miller's tr

Re: [BUG] Fwd: segfault : modprobe dccp_probe/tcp_probe

2007-06-06 Thread Ian McDonald
On 6/7/07, Chuck Ebbert [EMAIL PROTECTED] wrote: On 06/06/2007 04:47 PM, Ian McDonald wrote: Hi there, We've seen a report of a problem with dccp_probe as shown below. The user has also verified that it occurs in tcp_probe as well. This is on Dave Miller's tree but that currently tracks

Re: {Spam?} Re: {Spam?} [PATCH] NET: Remove obsolete traffic shaper code.

2007-04-14 Thread Ian McDonald
On 4/15/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: in fact, according to this: http://lkml.org/lkml/2006/1/13/139 that notice was put in the feature removal file well over a year ago, during 2.6.15. so that would seem to be more than adequate time for everyone to prepare for it. but it

Re: {Spam?} [PATCH] NET: Remove obsolete traffic shaper code.

2007-04-14 Thread Ian McDonald
On 4/15/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: Remove the obsolete code for the traffic shaper. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Apart from the merits of removing this which I can't comment on, I thought the usual procedure was to place a removal in

Re: {Spam?} [PATCH] NET: Remove obsolete traffic shaper code.

2007-04-14 Thread Ian McDonald
On 4/15/07, Robert P. J. Day [EMAIL PROTECTED] wrote: Remove the obsolete code for the traffic shaper. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Apart from the merits of removing this which I can't comment on, I thought the usual procedure was to place a removal in

Re: {Spam?} Re: {Spam?} [PATCH] NET: Remove obsolete traffic shaper code.

2007-04-14 Thread Ian McDonald
On 4/15/07, Robert P. J. Day [EMAIL PROTECTED] wrote: in fact, according to this: http://lkml.org/lkml/2006/1/13/139 that notice was put in the feature removal file well over a year ago, during 2.6.15. so that would seem to be more than adequate time for everyone to prepare for it. but it

Slab corruption - file_free_rcu ?

2007-03-12 Thread Ian McDonald
Folks, I'm getting this sort of message in my logs on occasion and my system dies on me some time later. Mar 13 08:52:02 localhost kernel: [ 343.931624] Slab corruption: start=d2756f04, len=208 Mar 13 08:52:02 localhost kernel: [ 343.932366] Redzone: 0x5a2cf071/0x5a2cf071. Mar 13 08:52:02

Slab corruption - file_free_rcu ?

2007-03-12 Thread Ian McDonald
Folks, I'm getting this sort of message in my logs on occasion and my system dies on me some time later. Mar 13 08:52:02 localhost kernel: [ 343.931624] Slab corruption: start=d2756f04, len=208 Mar 13 08:52:02 localhost kernel: [ 343.932366] Redzone: 0x5a2cf071/0x5a2cf071. Mar 13 08:52:02

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Ian McDonald
On 3/5/07, Matt Mackall <[EMAIL PROTECTED]> wrote: > This is due to the recent sysfs restructuring I think. IIRC the fix is > to upgrade hal to a current git version. If that's the cause, the fix is to back out whatever was done to break userspace. Breaking userspace is not ok. Upgrading from

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Ian McDonald
On 3/5/07, Matt Mackall [EMAIL PROTECTED] wrote: This is due to the recent sysfs restructuring I think. IIRC the fix is to upgrade hal to a current git version. If that's the cause, the fix is to back out whatever was done to break userspace. Breaking userspace is not ok. Upgrading from 2.6.x

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Ian McDonald
On 2/21/07, bert hubert <[EMAIL PROTECTED]> wrote: I'm trying to figure out which processes have the most impact, I had already killed anything non-essential. But that still leaves 140 pids. Bert That sounds way too many pids. I run a script to shut down processes when I do testing as

Re: [PATCH] pci: allow multiple calls to pcim_pin_device()

2007-02-20 Thread Ian McDonald
ed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- It was an actual bug in pcim_pin_device() implementation. Thanks for spotting this. :-) Ian McDonald, please verify your warning goes away with this patch. Yes it does. Thanks for sorting. Greg, please forward this patch upstream once Ian acks

Re: [PATCH] pci: allow multiple calls to pcim_pin_device()

2007-02-20 Thread Ian McDonald
-by: Tejun Heo [EMAIL PROTECTED] --- It was an actual bug in pcim_pin_device() implementation. Thanks for spotting this. :-) Ian McDonald, please verify your warning goes away with this patch. Yes it does. Thanks for sorting. Greg, please forward this patch upstream once Ian acks it. Acked

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Ian McDonald
On 2/21/07, bert hubert [EMAIL PROTECTED] wrote: I'm trying to figure out which processes have the most impact, I had already killed anything non-essential. But that still leaves 140 pids. Bert That sounds way too many pids. I run a script to shut down processes when I do testing as

Re: [BUG/WARN] Error initialising drivers in PCI

2007-02-18 Thread Ian McDonald
On 2/19/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: Ian, you have an PATA controller so there is no need to use ata_piix. Just disabling ata_piix should workaround the issue. OK. I have done this and the message goes away in boot logs. As you say I don't need the old drivers

[BUG/WARN] Error initialising drivers in PCI

2007-02-18 Thread Ian McDonald
I'm getting this in my logs when starting up after going from a 2.6.20rc5 kernel (which didn't do this) to Linus' latest tree as of 36 hours ago: Feb 18 14:52:32 localhost kernel: [ 16.392136] Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 Feb 18 14:52:32 localhost kernel: [

[BUG/WARN] Error initialising drivers in PCI

2007-02-18 Thread Ian McDonald
I'm getting this in my logs when starting up after going from a 2.6.20rc5 kernel (which didn't do this) to Linus' latest tree as of 36 hours ago: Feb 18 14:52:32 localhost kernel: [ 16.392136] Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 Feb 18 14:52:32 localhost kernel: [

Re: [BUG/WARN] Error initialising drivers in PCI

2007-02-18 Thread Ian McDonald
On 2/19/07, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Ian, you have an PATA controller so there is no need to use ata_piix. Just disabling ata_piix should workaround the issue. OK. I have done this and the message goes away in boot logs. As you say I don't need the old drivers

[BUG] CIFS won't link

2006-12-22 Thread Ian McDonald
In commit fba2591bf4e418b6c3f9f8794c9dd8fe40ae7bd9 test_clear_page_dirty was removed a couple of days ago. Now when I try and build I get this: WARNING: "test_clear_page_dirty" [fs/cifs/cifs.ko] undefined! This is caused by line 1248 of fs/cifs/file.c if

[BUG] CIFS won't link

2006-12-22 Thread Ian McDonald
In commit fba2591bf4e418b6c3f9f8794c9dd8fe40ae7bd9 test_clear_page_dirty was removed a couple of days ago. Now when I try and build I get this: WARNING: test_clear_page_dirty [fs/cifs/cifs.ko] undefined! This is caused by line 1248 of fs/cifs/file.c if