Re: [PATCH -next 1/5] net: ceph: Fix a typo in osdmap.c

2021-03-25 Thread Ilya Dryomov
On Thu, Mar 25, 2021 at 7:37 AM Lu Wei wrote: > > Modify "inital" to "initial" in net/ceph/osdmap.c. > > Reported-by: Hulk Robot > Signed-off-by: Lu Wei > --- > net/ceph/osdmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c > ind

Re: [PATCH RESEND][next] ceph: Fix fall-through warnings for Clang

2021-03-05 Thread Ilya Dryomov
On Fri, Mar 5, 2021 at 10:59 AM Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break and a goto statements instead > of just letting the code fall through to the next case. > > Link: https://github.com/KSP

Re: net/ceph/messenger_v1.c:1204:5: warning: stack frame size of 2944 bytes in function 'ceph_con_v1_try_read'

2021-03-01 Thread Ilya Dryomov
On Mon, Mar 1, 2021 at 9:36 AM kernel test robot wrote: > > Hi Ilya, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8 > commit: 2f713615ddd9d805b6c5e79c52e0e11af99d2

[GIT PULL] Ceph updates for 5.12-rc1

2021-02-22 Thread Ilya Dryomov
and deal with capsnaps better and a mount option cleanup. Ilya Dryomov (2): libceph: deprecate [no]cephx_require_signatures options libceph: remove osdtimeout option entirely Jeff Layton (3): ceph: fix flush_snap

Re: [PATCH] ceph: Fix an Oops in error handling

2021-02-02 Thread Ilya Dryomov
On Tue, Feb 2, 2021 at 6:47 AM Dan Carpenter wrote: > > The "req" pointer is an error pointer and not NULL so this check needs > to be fixed. > > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") > Signed-off-by: Dan Carpenter > --- > fs/ceph/addr.c | 2 +- > 1 file changed,

Re: [PATCH] ceph: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-02 Thread Ilya Dryomov
On Mon, Feb 1, 2021 at 8:52 AM Jiapeng Chong wrote: > > Fix the following coccicheck warning: > > ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > fs/ceph/debugfs.c |

Re: [PATCH 0/6] ceph: convert to new netfs read helpers

2021-01-28 Thread Ilya Dryomov
On Thu, Jan 28, 2021 at 1:52 PM Jeff Layton wrote: > > On Wed, 2021-01-27 at 23:50 +0100, Ilya Dryomov wrote: > > On Tue, Jan 26, 2021 at 2:41 PM Jeff Layton wrote: > > > > > > This patchset converts ceph to use the new netfs readpage, write_begin, > > > a

Re: [PATCH 0/6] ceph: convert to new netfs read helpers

2021-01-27 Thread Ilya Dryomov
On Tue, Jan 26, 2021 at 2:41 PM Jeff Layton wrote: > > This patchset converts ceph to use the new netfs readpage, write_begin, > and readahead helpers to handle buffered reads. This is a substantial > reduction in code in ceph, but shouldn't really affect functionality in > any way. > > Ilya, if y

[GIT PULL] Ceph fixes for 5.11-rc5

2021-01-22 Thread Ilya Dryomov
f code was moved in this cycle. ---- Ilya Dryomov (3): libceph: zero out session key and connection secret libceph, ceph: disambiguate ceph_connection_operations handlers libceph: fix "Boolean result is used in bi

Re: [kbuild] net/ceph/messenger_v1.c:1099:23: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses.

2021-01-20 Thread Ilya Dryomov
On Wed, Jan 20, 2021 at 1:43 PM Dan Carpenter wrote: > > On Wed, Jan 20, 2021 at 12:01:59PM +0100, Ilya Dryomov wrote: > > On Tue, Jan 19, 2021 at 8:46 PM Dan Carpenter > > wrote: > > > > > > tree: > > > https://git.kernel.org/pub/scm/linux/

Re: [kbuild] net/ceph/messenger_v1.c:1099:23: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses.

2021-01-20 Thread Ilya Dryomov
net/ceph/messenger_v1.c:1099:23: warning: Boolean result is used in > >> bitwise operation. Clarify expression with parentheses. [clarifyCondition] > BUG_ON(!con->in_msg ^ skip); > ^ > > vim +1099 net/ceph/messenger_v1.c > > 2f

[GIT PULL] Ceph fixes for 5.11-rc2

2020-12-30 Thread Ilya Dryomov
. Ilya Dryomov (4): ceph: reencode gid_list when reconnecting libceph: fix auth_signature buffer allocation in secure mode libceph: align session_key and con_secret to 16 bytes libceph: add __maybe_unused to DEFINE_MSGR2_FEATURE fs

[GIT PULL] Ceph updates for 5.11-rc1

2020-12-17 Thread Ilya Dryomov
-realm renames. Colin Ian King (1): ceph: remove redundant assignment to variable i Ilya Dryomov (34): libceph: include middle_len in process_message() dout libceph: lower exponential backoff delay libceph: don&#

[GIT PULL] Ceph fix for 5.10-rc3

2020-11-06 Thread Ilya Dryomov
Hi Linus, The following changes since commit 3cea11cd5e3b00d91caf0b4730194039b45c5891: Linux 5.10-rc2 (2020-11-01 14:43:51 -0800) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.10-rc3 for you to fetch changes up to 62575e270f661aba64778cbc5f

Re: [PATCH v2 31/39] docs: ABI: cleanup several ABI documents

2020-10-30 Thread Ilya Dryomov
for sysfs-bus-papr-pmem > Signed-off-by: Mauro Carvalho Chehab > > [...] > > Documentation/ABI/testing/sysfs-bus-rbd | 37 ++- Acked-by: Ilya Dryomov # for rbd Thanks, Ilya

[GIT PULL] Ceph updates for 5.10-rc1

2020-10-21 Thread Ilya Dryomov
and others. ---- Ilya Dryomov (9): libceph: multiple workspaces for CRUSH computations libceph, rbd, ceph: "blacklist" -> "blocklist" libceph: switch to the new "osd blocklist add" command ceph: add a note exp

[GIT PULL] Ceph fix for 5.9-rc5

2020-09-11 Thread Ilya Dryomov
. Ilya Dryomov (1): rbd: require global CAP_SYS_ADMIN for mapping and unmapping drivers/block/rbd.c | 12 1 file changed, 12 insertions(+)

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Ilya Dryomov
0/isp1760-hcd.c | 2 +- > drivers/usb/musb/cppi_dma.c | 2 +- > drivers/usb/phy/phy-fsl-usb.c | 2 +- > drivers/video/fbdev/stifb.c | 2 +- > fs/afs/yfsclient.c| 8 > fs/ceph/dir.c | 2 +- For ceph: Acked-by: Ilya Dryomov Thanks, Ilya

Re: [PATCH AUTOSEL 5.8 25/42] ceph: fix inode number handling on arches with 32-bit ino_t

2020-08-31 Thread Ilya Dryomov
yomov: changelog tweak ] > > URL: https://tracker.ceph.com/issues/46828 > Reported-by: Ulrich Weigand > Reported-and-Tested-by: Tuan Hoang1 > Signed-off-by: Jeff Layton > Reviewed-by: "Yan, Zheng" > Signed-off-by: Ilya Dryomov > Signed-off-by: Sash

[GIT PULL] Ceph fixes for 5.9-rc3

2020-08-28 Thread Ilya Dryomov
avoid potential data integrity issues when CephFS is re-exported via NFS or CIFS and a fix for the bulk of W=1 compilation warnings. Ilya Dryomov (1): libceph: add __maybe_unused to DEFINE_CEPH_FEATURE Jeff Layton (2): ceph

Re: [PATCH] rbd: Convert to use the preferred fallthrough macro

2020-08-19 Thread Ilya Dryomov
On Wed, Aug 19, 2020 at 3:03 PM Jens Axboe wrote: > > On 8/19/20 1:53 AM, Miaohe Lin wrote: > > Convert the uses of fallthrough comments to fallthrough macro. > > Applied, thanks. Hi Jens, This has already been folded into another patch in ceph-client.git. Please drop it. Thanks,

Re: [PATCH] ceph: Convert to use the preferred fallthrough macro

2020-08-19 Thread Ilya Dryomov
On Wed, Aug 19, 2020 at 10:53 AM Miaohe Lin wrote: > > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Hongxiang Lou > Signed-off-by: Miaohe Lin > --- > fs/ceph/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/file.c b/fs/

Re: [RFC PATCH] ceph: Delete features that are not used in the kernel

2020-08-19 Thread Ilya Dryomov
On Wed, Aug 19, 2020 at 9:57 AM Leon Romanovsky wrote: > > From: Leon Romanovsky > > The ceph_features.h has declaration of features that are not in-use > in kernel code. This causes to seeing such compilation warnings in > almost every kernel compilation. > > ./include/linux/ceph/ceph_features.h

Re: [PATCH] libceph: Convert to use the preferred fallthrough macro

2020-08-19 Thread Ilya Dryomov
On Tue, Aug 18, 2020 at 9:56 PM Jeff Layton wrote: > > On Tue, 2020-08-18 at 08:26 -0400, Miaohe Lin wrote: > > Convert the uses of fallthrough comments to fallthrough macro. > > > > Signed-off-by: Miaohe Lin > > --- > > net/ceph/ceph_hash.c| 20 ++-- > > net/ceph/crush/mappe

Re: [PATCH V2 6/6] ceph_debug: Remove now unused dout macro definitions

2020-08-17 Thread Ilya Dryomov
On Mon, Aug 17, 2020 at 3:34 AM Joe Perches wrote: > > All the uses have be converted to pr_debug, so remove these. > > Signed-off-by: Joe Perches > --- > include/linux/ceph/ceph_debug.h | 30 -- > 1 file changed, 30 deletions(-) > > diff --git a/include/linux/ceph/ce

[GIT PULL] Ceph updates for 5.9-rc1

2020-08-12 Thread Ilya Dryomov
. Alexander A. Klimov (1): libceph: replace HTTP links with HTTPS ones Colin Ian King (1): ceph: remove redundant initialization of variable mds Ilya Dryomov (2): libceph: use target_copy() in send_linger() libceph: dump class and method names on method calls Jeff Layton

Re: [PATCH] Replace HTTP links with HTTPS ones: CEPH COMMON CODE (LIBCEPH)

2020-07-08 Thread Ilya Dryomov
On Wed, Jul 8, 2020 at 8:53 AM Alexander A. Klimov wrote: > > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contai

Re: [PATCH] fs: ceph: Remove unnecessary cast in kfree()

2020-07-08 Thread Ilya Dryomov
On Wed, Jul 8, 2020 at 9:27 AM Xu Wang wrote: > > Remove unnecassary casts in the argument to kfree. > > Signed-off-by: Xu Wang > --- > fs/ceph/xattr.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c > index 71ee34d160c3..3a

[GIT PULL] Ceph fixes for 5.8-rc2

2020-06-19 Thread Ilya Dryomov
ixups. Ilya Dryomov (3): libceph: move away from global osd_req_flags libceph: don't omit recovery_deletes in target_copy() libceph: don't omit used_replica in target_copy() drivers/block/rbd.c | 4 +++- include/linux/ceph/libceph.h

[GIT PULL] Ceph updates for 5.8-rc1

2020-06-08 Thread Ilya Dryomov
): libceph, rbd: replace zero-length array with flexible-array Ilya Dryomov (7): libceph: add non-asserting rbtree insertion helper libceph: decode CRUSH device/bucket types and names libceph: crush_location infrastructure libceph: support for balanced and localized reads

[GIT PULL] Ceph fixes for 5.7-rc8

2020-05-29 Thread Ilya Dryomov
Hi Linus, The following changes since commit 9cb1fd0efd195590b828b9b865421ad345a4a145: Linux 5.7-rc7 (2020-05-24 15:32:54 -0700) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.7-rc8 for you to fetch changes up to fb33c114d3ed5bdac230716f5b0a

[PATCH v3] vsprintf: don't obfuscate NULL and error pointers

2020-05-19 Thread Ilya Dryomov
s: 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing invalid pointers") Signed-off-by: Ilya Dryomov Reviewed-by: Petr Mladek Reviewed-by: Sergey Senozhatsky Acked-by: Steven Rostedt (VMware) Acked-by: Linus Torvalds --- lib/test_printf.c | 19 ++- lib/vsprintf.c

Re: linux-next: new contact(s) for the ceph tree?

2020-05-10 Thread Ilya Dryomov
On Sat, May 9, 2020 at 5:47 AM Stephen Rothwell wrote: > > Hi Sage, > > On Sat, 9 May 2020 01:03:14 + (UTC) Sage Weil wrote: > > > > Jeff Layton > > Done. > > On Sat, 9 May 2020, Stephen Rothwell wrote: > > > > > > I noticed commit > > > > > > 3a5ccecd9af7 ("MAINTAINERS: remove myself as c

[GIT PULL] Ceph fixes for 5.7-rc5

2020-05-08 Thread Ilya Dryomov
Hi Linus, The following changes since commit 0e698dfa282211e414076f9dc7e83c1c288314fd: Linux 5.7-rc4 (2020-05-03 14:56:04 -0700) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.7-rc5 for you to fetch changes up to 12ae44a40a1be891bdc6463f8c70

Re: [PATCH] rbd: Replace zero-length array with flexible-array

2020-05-08 Thread Ilya Dryomov
On Thu, May 7, 2020 at 9:15 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: >

Re: [PATCH] libceph: Replace zero-length array with flexible-array

2020-05-08 Thread Ilya Dryomov
On Thu, May 7, 2020 at 8:47 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: >

Re: [PATCH] ceph: demote quotarealm lookup warning to a debug message

2020-05-07 Thread Ilya Dryomov
On Thu, May 7, 2020 at 3:44 PM Jeff Layton wrote: > > On Tue, 2020-05-05 at 13:59 +0100, Luis Henriques wrote: > > A misconfigured cephx can easily result in having the kernel client > > flooding the logs with: > > > > ceph: Can't lookup inode 1 (err: -13) > > > > Change his message to debug lev

[GIT PULL] Ceph fixes for 5.4-rc4

2019-10-18 Thread Ilya Dryomov
Hi Linus, The following changes since commit 4f5cafb5cb8471e54afdc9054d973535614f7675: Linux 5.4-rc3 (2019-10-13 16:37:36 -0700) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.4-rc4 for you to fetch changes up to 25e6be21230d3208d687dad90b6e

Re: [PATCH] function dispatch should return if mds session does not exist

2019-10-14 Thread Ilya Dryomov
On Mon, Oct 14, 2019 at 11:01 AM Yanhu Cao wrote: > > we shouldn't call ceph_msg_put, otherwise libceph will pass > invalid pointer to mm. > > kernel panic - not syncing: fatal exception > [5452201.213885] [ cut here ] > [5452201.213889] kernel BUG at mm/slub.c:3901

[GIT PULL] Ceph updates for 5.4-rc1

2019-09-25 Thread Ilya Dryomov
d strings Erqi Chen (1): ceph: reconnect connection if session hang in opening state Ilya Dryomov (6): ceph: fix indentation in __get_snap_name() libceph: drop unused con parameter of calc_target() rbd: pull rbd_img_request_create() dout out into the callers ceph: inclu

Re: [GIT PULL afs: Development for 5.4

2019-09-19 Thread Ilya Dryomov
On Thu, Sep 19, 2019 at 3:55 PM Matthew Wilcox wrote: > > On Thu, Sep 19, 2019 at 10:49:22AM +0100, David Howells wrote: > > David Howells wrote: > > > > > > However, I was close to unpulling it again. It has a merge commit with > > > > this merge message: > > > > > > > > Merge remote-trackin

Re: [PATCH v2] ceph: allow object copies across different filesystems in the same cluster

2019-09-09 Thread Ilya Dryomov
On Mon, Sep 9, 2019 at 12:29 PM Luis Henriques wrote: > > OSDs are able to perform object copies across different pools. Thus, > there's no need to prevent copy_file_range from doing remote copies if the > source and destination superblocks are different. Only return -EXDEV if > they have differ

Re: [PATCH] ceph: Move static keyword to the front of declarations

2019-09-02 Thread Ilya Dryomov
On Sat, Aug 31, 2019 at 11:57 PM Krzysztof Wilczynski wrote: > > Move the static keyword to the front of declarations of > snap_handle_length, handle_length and connected_handle_length, > and resolve the following compiler warnings that can be seen > when building with warnings enabled (W=1): > >

Re: bug report: libceph: follow redirect replies from osds

2019-08-30 Thread Ilya Dryomov
On Fri, Aug 30, 2019 at 4:05 PM Colin Ian King wrote: > > Hi, > > Static analysis with Coverity has picked up an issue with commit: > > commit 205ee1187a671c3b067d7f1e974903b44036f270 > Author: Ilya Dryomov > Date: Mon Jan 27 17:40:20 2014 +0200 > > libceph

[GIT PULL] Ceph fixes for 5.3-rc7

2019-08-30 Thread Ilya Dryomov
. Ilya Dryomov (1): rbd: restore zeroing past the overlap when reading from parent Jia-Ju Bai (1): libceph: don't call crypto_free_sync_skcipher() on a NULL tfm drivers/block/rbd.c | 11 +++ net/ceph/crypto.c | 6 -- 2 files changed, 15 insertions(

Re: [PATCH AUTOSEL 5.2 66/76] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()

2019-08-30 Thread Ilya Dryomov
On Thu, Aug 29, 2019 at 11:16 PM Sasha Levin wrote: > > On Thu, Aug 29, 2019 at 10:51:04PM +0200, Ilya Dryomov wrote: > >On Thu, Aug 29, 2019 at 8:15 PM Sasha Levin wrote: > >> > >> From: Luis Henriques > >> > >> [ Upstream commit 86968ef21596

Re: [PATCH AUTOSEL 5.2 66/76] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()

2019-08-29 Thread Ilya Dryomov
0 >? rcu_read_lock_sched_held+0x74/0x80 >? rcu_sync_lockdep_assert+0x2e/0x60 >? __sb_start_write+0x142/0x1a0 >? mnt_want_write+0x20/0x50 >path_setxattr+0xba/0xd0 >__x64_sys_lsetxattr+0x24/0x30 >do_syscall_64+0x50/0x1c0 >entry_SYSCALL_64_after_hwframe+0x49

[GIT PULL] Ceph fixes for 5.3-rc6

2019-08-23 Thread Ilya Dryomov
Luis fixing instances of vfree() under spinlock. Erqi Chen (1): ceph: clear page dirty before invalidate page Ilya Dryomov (1): libceph: fix PG split vs OSD (re)connect race Jeff Layton (1): ceph: don't try

Re: [PATCH] net/ceph replace ceph_kvmalloc with kvmalloc

2019-08-12 Thread Ilya Dryomov
On Mon, Aug 12, 2019 at 11:42 AM Marc Koderer wrote: > > There is nearly no difference between both implemenations. > ceph_kvmalloc existed before kvmalloc which makes me think it's > a leftover. > > Signed-off-by: Marc Koderer > --- > net/ceph/buffer.c | 3 +-- > net/ceph/ceph_common.c |

Re: [PATCH] net: ceph: Fix a possible null-pointer dereference in ceph_crypto_key_destroy()

2019-07-30 Thread Ilya Dryomov
On Wed, Jul 24, 2019 at 11:43 AM Jia-Ju Bai wrote: > > In set_secret(), key->tfm is assigned to NULL on line 55, and then > ceph_crypto_key_destroy(key) is executed. > > ceph_crypto_key_destroy(key) > crypto_free_sync_skcipher(key->tfm) > crypto_skcipher_tfm(tfm) > return &

Re: fs/ceph/export.c:459:3-12: code aligned with following code on line 461 (fwd)

2019-07-29 Thread Ilya Dryomov
t > To: kbu...@01.org > Cc: Julia Lawall > Subject: fs/ceph/export.c:459:3-12: code aligned with following code on line > 461 > > CC: kbuild-...@01.org > CC: linux-kernel@vger.kernel.org > TO: "Yan, Zheng" > CC: Ilya Dryomov > > tree: https://git.k

Re: [PATCH 0/4] Sleeping functions in invalid context bug fixes

2019-07-23 Thread Ilya Dryomov
On Fri, Jul 19, 2019 at 5:20 PM Jeff Layton wrote: > > On Fri, 2019-07-19 at 15:32 +0100, Luis Henriques wrote: > > Hi, > > > > I'm sending three "sleeping function called from invalid context" bug > > fixes that I had on my TODO for a while. All of them are ceph_buffer_put > > related, and all t

[GIT PULL] Ceph updates for 5.3-rc1

2019-07-17 Thread Ilya Dryomov
" vxattr value Hariprasad Kelam (1): ceph: fix warning PTR_ERR_OR_ZERO can be used Ilya Dryomov (21): rbd: get rid of obj_req->xferred, obj_req->result and img_req->xferred rbd: replace obj_req->tried_parent with obj_req->read_state rbd: get rid of RBD_OBJ_WR

Re: linux-next: build failure after merge of the tip tree

2019-07-10 Thread Ilya Dryomov
On Wed, Jul 10, 2019 at 2:01 AM Stephen Rothwell wrote: > > Hi all, > > On Tue, 9 Jul 2019 16:54:59 +1000 Stephen Rothwell > wrote: > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > drivers/block/rbd.c: In function 'wake_lock_waiters

[GIT PULL] Ceph fix for 5.2-rc7

2019-06-28 Thread Ilya Dryomov
Hi Linus, The following changes since commit 4b972a01a7da614b4796475f933094751a295a2f: Linux 5.2-rc6 (2019-06-22 16:01:36 -0700) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.2-rc7 for you to fetch changes up to d6b8bd679c9c8856fa04b8049076

Re: [PATCH v4 3/3] ceph: don't NULL terminate virtual xattrs

2019-06-25 Thread Ilya Dryomov
On Mon, Jun 24, 2019 at 6:27 PM Jeff Layton wrote: > > The convention with xattrs is to not store the termination with string > data, given that it returns the length. This is how setfattr/getfattr > operate. > > Most of ceph's virtual xattr routines use snprintf to plop the string > directly into

Re: [PATCH v3 1/2] ceph: fix buffer length handling in virtual xattrs

2019-06-24 Thread Ilya Dryomov
On Mon, Jun 24, 2019 at 12:26 PM Jeff Layton wrote: > > On Mon, 2019-06-24 at 12:00 +0200, Ilya Dryomov wrote: > > On Fri, Jun 21, 2019 at 4:18 PM Jeff Layton wrote: > > > The convention with xattrs is to not store the termination with string > > > data, given that

Re: [PATCH v3 1/2] ceph: fix buffer length handling in virtual xattrs

2019-06-24 Thread Ilya Dryomov
On Fri, Jun 21, 2019 at 4:18 PM Jeff Layton wrote: > > The convention with xattrs is to not store the termination with string > data, given that it returns the length. This is how setfattr/getfattr > operate. > > Most of ceph's virtual xattr routines use snprintf to plop the string > directly into

[GIT PULL] Ceph fixes for 5.2-rc4

2019-06-08 Thread Ilya Dryomov
Hi Linus, The following changes since commit f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a: Linux 5.2-rc3 (2019-06-02 13:55:33 -0700) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.2-rc4 for you to fetch changes up to 7b2f936fc8282ab56d4d21247f2f

[GIT PULL] Ceph updates for 5.2-rc1

2019-05-16 Thread Ilya Dryomov
. Arnd Bergmann (3): rbd: avoid clang -Wuninitialized warning rbd: convert all rbd_assert(0) to BUG() libceph: fix clang warning for CEPH_DEFINE_OID_ONSTACK Ilya Dryomov (2): rbd: client_mutex is never nested rbd: don't asse

[GIT PULL] Ceph fixes for 5.1-rc7

2019-04-25 Thread Ilya Dryomov
Hi Linus, The following changes since commit 085b7755808aa11f78ab9377257e1dad2e6fa4bb: Linux 5.1-rc6 (2019-04-21 10:45:57 -0700) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.1-rc7 for you to fetch changes up to 37659182bff1eeaaeadcfc8f853c

[GIT PULL] Ceph fixes for 5.1-rc3

2019-03-29 Thread Ilya Dryomov
. Al Viro (1): ceph: fix use-after-free on symlink traversal Ilya Dryomov (1): libceph: fix breakage caused by multipage bvecs fs/ceph/inode.c | 2 +- net/ceph/messenger.c | 8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-)

Re: [PATCH] [v2] ceph: fix clang warning for CEPH_DEFINE_OID_ONSTACK

2019-03-27 Thread Ilya Dryomov
On Mon, Mar 25, 2019 at 1:51 PM Arnd Bergmann wrote: > > clang complains about assigning a variable to itself during the > declaration: > > fs/ceph/ioctl.c:187:26: error: variable 'oid' is uninitialized when used > within its own initialization [-Werror,-Wuninitialized] > CEPH_DEFINE_OID_

[PATCH] dm table: propagate BDI_CAP_STABLE_WRITES

2019-03-26 Thread Ilya Dryomov
f any underlying device has it set. Signed-off-by: Ilya Dryomov --- drivers/md/dm-table.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index ba9481f1bf3c..cde3b49b2a91 100644 --- a/drivers/md/dm-table.c

Re: ceph: fix use-after-free on symlink traversal

2019-03-26 Thread Ilya Dryomov
On Tue, Mar 26, 2019 at 2:39 AM Al Viro wrote: > > free the symlink body after the same RCU delay we have for freeing the > struct inode itself, so that traversal during RCU pathwalk wouldn't step > into freed memory. > > Signed-off-by: Al Viro > --- > diff --git a/fs/ceph/inode.c b/fs/ceph/inode

Re: [PATCH] rbd: avoid clang -Wuninitialized warning

2019-03-25 Thread Ilya Dryomov
On Fri, Mar 22, 2019 at 5:55 PM Arnd Bergmann wrote: > > On Fri, Mar 22, 2019 at 5:33 PM Ilya Dryomov wrote: > > > > On Fri, Mar 22, 2019 at 3:36 PM Arnd Bergmann wrote: > > > > > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > > > index

[GIT PULL] Ceph fixes for 5.1-rc2

2019-03-22 Thread Ilya Dryomov
. Ilya Dryomov (3): rbd: set io_min, io_opt and discard_granularity to alloc_size libceph: wait for latest osdmap in ceph_monc_blacklist_add() rbd: drop wait_for_latest_osdmap() drivers/block/rbd.c | 28 ++-- include/linux/ceph/libceph.h | 2 ++ net

Re: [PATCH] ceph: fix clang warning for CEPH_DEFINE_OID_ONSTACK

2019-03-22 Thread Ilya Dryomov
On Fri, Mar 22, 2019 at 3:08 PM Arnd Bergmann wrote: > > clang complains about assigning a variable to itself during the > declaration: > > fs/ceph/ioctl.c:187:26: error: variable 'oid' is uninitialized when used > within its own initialization [-Werror,-Wuninitialized] > CEPH_DEFINE_OID_

[GIT PULL] Ceph updates for 5.1-rc1

2019-03-12 Thread Ilya Dryomov
bute (Zheng Yan) Gustavo A. R. Silva (1): libceph: use struct_size() for kmalloc() in crush_decode() Ilya Dryomov (11): rbd: get rid of obj_req->obj_request_count rbd: handle DISCARD and WRITE_ZEROES separately rbd: round off and ignore discards that are t

[GIT PULL] Ceph fixes for 5.0-rc8

2019-02-21 Thread Ilya Dryomov
04242ff3ac0abbaa4362f97781dac268e6c3541a: ceph: avoid repeatedly adding inode to mdsc->snap_flush_list (2019-02-18 18:08:29 +0100) Two bug fixes for old issues, both marked for stable. ---- I

[GIT PULL] Ceph fixes for 5.0-rc4

2019-01-24 Thread Ilya Dryomov
. Ilya Dryomov (1): libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive() Thomas Gleixner (1): ceph: quota: cleanup license mess Yan, Zheng (1): ceph: clear inode pointer when snap realm gets dropped by its inode fs/ceph

Re: [patch 6/9] ceph: quota: Cleanup license mess

2019-01-18 Thread Ilya Dryomov
X id is correct and the boiler plate was randomly > copied into that patch. > > Remove the boiler plate as it is wrong and even if correct it is redundant. > > Fixes: fb18a57568c2 ("ceph: quota: add initial infrastructure to support > cephfs quotas") > Signed-off-by:

Re: [PATCH net-next] libceph, ceph: use struct_size() in kmalloc()

2019-01-17 Thread Ilya Dryomov
On Tue, Jan 15, 2019 at 8:41 PM Gustavo A. R. Silva wrote: > > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { >

Re: [PATCH] libceph: protect pending flags in ceph_con_keepalive()

2019-01-15 Thread Ilya Dryomov
On Tue, Jan 15, 2019 at 7:56 AM Myungho Jung wrote: > > On Mon, Jan 14, 2019 at 09:37:25PM +0100, Ilya Dryomov wrote: > > On Thu, Jan 3, 2019 at 4:50 AM Myungho Jung wrote: > > > I reproduced on vm using syzkaller utils and verified the fix by syzbot. > > > >

Re: [PATCH] libceph: protect pending flags in ceph_con_keepalive()

2019-01-14 Thread Ilya Dryomov
On Thu, Jan 3, 2019 at 4:50 AM Myungho Jung wrote: > I reproduced on vm using syzkaller utils and verified the fix by syzbot. Hi Myungho, I think this might be a better fix: diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index d5718284db57..c5f5313e3537 100644 --- a/net/ceph/messenger

[GIT PULL] Ceph updates for 5.0-rc2

2019-01-11 Thread Ilya Dryomov
rked for stable. Dongsheng Yang (1): libceph: allow setting abort_on_full for rbd Ilya Dryomov (1): rbd: don't return 0 on unmap if RBD_DEV_FLAG_REMOVING is set Souptick Joarder (1): ceph: use vmf_error() in ceph_filemap_fault()

Re: [PATCH] fs/ceph/addr.c: Convert to use vmf_error()

2019-01-05 Thread Ilya Dryomov
On Fri, Jan 4, 2019 at 8:26 PM Souptick Joarder wrote: > > This code is converted to use vmf_error(). > > Signed-off-by: Souptick Joarder > --- > fs/ceph/addr.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 8eade7a..fa2a85d 1

[GIT PULL] Ceph updates for 4.21-rc1

2019-01-03 Thread Ilya Dryomov
Zheng. Chengguang Xu (1): ceph: remove redundant assignment Ilya Dryomov (4): libceph: drop last_piece logic from write_partial_message_data() libceph: use sock_no_sendpage() as a fallback in ceph_tcp_sendpage() libceph

Re: [PATCH] libceph: protect pending flags in ceph_con_keepalive()

2019-01-02 Thread Ilya Dryomov
On Thu, Dec 27, 2018 at 8:08 PM Myungho Jung wrote: > > con_flag_test_and_set() sets CON_FLAG_KEEPALIVE_PENDING and > CON_FLAG_WRITE_PENDING flags without protection in ceph_con_keepalive(). > It triggers WARN_ON() in clear_standby() if the flags are set after > con_fault() changes connection stat

Re: [PATCH 06/10] block: rbd: convert to use BUS_ATTR_WO and RO

2018-12-21 Thread Ilya Dryomov
On Fri, Dec 21, 2018 at 8:55 AM Greg Kroah-Hartman wrote: > > We are trying to get rid of BUS_ATTR() and the usage of that in rbd.c > can be trivially converted to use BUS_ATTR_WO and RO, so use those > macros instead. > > Cc: Ilya Dryomov > Cc: Sage Weil > Cc: Alex

[GIT PULL] Ceph fix for 4.20-rc7

2018-12-14 Thread Ilya Dryomov
Hi Linus, The following changes since commit 40e020c129cfc991e8ab4736d2665351ffd1468d: Linux 4.20-rc6 (2018-12-09 15:31:00 -0800) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.20-rc7 for you to fetch changes up to 6f9718fe41c3a47e4362bddf14

Re: [PATCH] ceph: make 'nocopyfrom' a default mount option

2018-12-10 Thread Ilya Dryomov
On Mon, Dec 10, 2018 at 11:23 AM Luis Henriques wrote: > > Since we found a problem with the 'copy-from' operation after objects have > been truncated, offloading object copies to OSDs should be discouraged > until the issue is fixed. > > Thus, this patch adds the 'nocopyfrom' mount option to the

Re: [PATCH 4.14 018/146] libceph: implement CEPHX_V2 calculation mode

2018-12-04 Thread Ilya Dryomov
(both AES cipher blocks) > instead of using just the first half of the first block, leaving out > data_crc entirely. > > This addresses CVE-2018-1129. > > Link: http://tracker.ceph.com/issues/24837 > Signed-off-by: Ilya Dryomov > Reviewed-by: Sage Weil > Signed-

[GIT PULL] Ceph fix for 4.20-rc4

2018-11-23 Thread Ilya Dryomov
7e241f647dc7087a0401418a187f3f5b527cc690: libceph: fall back to sendmsg for slab pages (2018-11-19 17:59:47 +0100) A messenger fix, marked for stable. Ilya Dryomov (1): libceph: fall

[GIT PULL] Ceph fixes for 4.20-rc2

2018-11-09 Thread Ilya Dryomov
. Ilya Dryomov (1): libceph: assume argonaut on the server side Luis Henriques (2): ceph: add destination file data sync before doing any remote copy ceph: quota: fix null pointer dereference in quota check fs/ceph/file.c | 11 +-- fs/ceph

[GIT PULL] Ceph updates for 4.20-rc1

2018-10-31 Thread Ilya Dryomov
hold timeout only for requeued inode rbd: add __init/__exit annotations ceph: check snap first in ceph_set_acl() Ilya Dryomov (12): libceph: bump CEPH_MSG_MAX_DATA_LEN libceph: osd_req_op_cls_init() doesn't need to take opcode libceph: introduce ceph_pagelist_

Re: [PATCH] ceph: only allow punch hole mode in fallocate

2018-10-10 Thread Ilya Dryomov
On Wed, Oct 10, 2018 at 1:19 PM Luis Henriques wrote: > > Ilya Dryomov writes: > > > On Wed, Oct 10, 2018 at 6:21 AM Yan, Zheng wrote: > >> > >> On Wed, Oct 10, 2018 at 1:54 AM Luis Henriques wrote: > > > > >> Applied, thanks > > &g

Re: [PATCH] ceph: only allow punch hole mode in fallocate

2018-10-10 Thread Ilya Dryomov
On Wed, Oct 10, 2018 at 6:21 AM Yan, Zheng wrote: > > On Wed, Oct 10, 2018 at 1:54 AM Luis Henriques wrote: > > > > Current implementation of cephfs fallocate isn't correct as it doesn't > > really reserve the space in the cluster, which means that a subsequent > > call to a write may actually fa

Re: [PATCH] ceph: use an enum instead of 'static const' to define constants

2018-10-08 Thread Ilya Dryomov
On Mon, Oct 8, 2018 at 5:37 PM Arnd Bergmann wrote: > > On Mon, Oct 8, 2018 at 4:23 PM Ilya Dryomov wrote: > > On Fri, Oct 5, 2018 at 6:18 PM Arnd Bergmann wrote: > > > @@ -71,7 +71,7 @@ > > > * This ensures that no two versions who have different meanings for &

Re: [PATCH] ceph: use an enum instead of 'static const' to define constants

2018-10-08 Thread Ilya Dryomov
On Fri, Oct 5, 2018 at 6:18 PM Arnd Bergmann wrote: > > Building with W=1 produces lots of warnings for files including > ceph_features.h: > > include/linux/ceph/ceph_features.h:15:24: error: 'CEPH_FEATUREMASK_SERVER_M' > defined but not used [-Werror=unused-const-variable=] > > The normal way to

[GIT PULL] Ceph updates for 4.19-rc3

2018-09-07 Thread Ilya Dryomov
hing unexpected. -------- Ilya Dryomov (3): ceph: avoid a use-after-free in ceph_destroy_options() rbd: factor out get_parent_info() rbd: support cloning across namespaces drivers/block/rbd.c | 235 +++- fs/ceph/super.c | 1

[GIT PULL] Ceph updates for 4.19-rc1

2018-08-20 Thread Ilya Dryomov
file size limit ceph: change to void return type for __do_request() ceph: refactor ceph_unreserve_caps() ceph: refactor error handling code in ceph_reserve_caps() Ilya Dryomov (14): libceph: make ceph_osdc_notify{,_ack}() payload_len u32 libceph: change ceph_pageli

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Ilya Dryomov
On Tue, Aug 14, 2018 at 4:41 PM Stefan Agner wrote: > > Hi, > > Using Linux 4.18 on a i.MX 6Q I see the following warning during > boot-up: > > [ 23.928916] [ cut here ] > [ 23.933795] WARNING: CPU: 1 PID: 527 at block/blk-core.c:2161 > generic_make_request_checks+0x868

[GIT PULL] Ceph fix for 4.18-rc3

2018-06-29 Thread Ilya Dryomov
Hi Linus, The following changes since commit 7daf201d7fe8334e2d2364d4e8ed3394ec9af819: Linux 4.18-rc2 (2018-06-24 20:54:29 +0800) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.18-rc3 for you to fetch changes up to 8b8f53af1ed9df88a4c0fbfdf3

[GIT PULL] Ceph updates for 4.18-rc1

2018-06-14 Thread Ilya Dryomov
work after watch is unregistered Ilya Dryomov (13): libceph: get rid of more_kvec in try_write() libceph: use MSG_TRUNC for discarding received bytes ceph: show wsize only if non-default libceph: introduce ceph_osdc_abort_requests() libceph: no need to call flush_wo

[GIT PULL] Ceph fixes for 4.17-rc5

2018-05-11 Thread Ilya Dryomov
(). Ilya Dryomov (3): ceph: fix rsize/wsize capping in ceph_direct_read_write() libceph: add osd_req_op_extent_osd_data_bvecs() ceph: fix iov_iter issues in ceph_direct_read_write() drivers/block/rbd.c | 4

[PATCH 2/2] iov_iter: fix memory leak in pipe_get_pages_alloc()

2018-05-02 Thread Ilya Dryomov
Make n signed to avoid leaking the pages array if __pipe_get_pages() fails. Signed-off-by: Ilya Dryomov --- lib/iov_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 4d5bf40d399d..fdae394172fa 100644 --- a/lib/iov_iter.c +++ b/lib

[PATCH 1/2] iov_iter: fix return type of __pipe_get_pages()

2018-05-02 Thread Ilya Dryomov
It returns -EFAULT and happens to be a helper for pipe_get_pages() whose return type is ssize_t. Signed-off-by: Ilya Dryomov --- lib/iov_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 970212670b6a..4d5bf40d399d 100644 --- a/lib

[GIT PULL] Ceph fixes for 4.17-rc3

2018-04-27 Thread Ilya Dryomov
ble. ---- Ilya Dryomov (3): libceph: un-backoff on tick when we have a authenticated session libceph: reschedule a tick in finish_hunting() libceph: validate con->state at the top of try_write() Yan, Zheng (1): ceph: check if mds create sna

Re: [4.4,50/97] ext4: add validity checks for bitmap block numbers -- regression?

2018-04-23 Thread Ilya Dryomov
Hi Greg, Commit 7dac4a1726a9 ("ext4: add validity checks for bitmap block numbers") seems to be the cause of the regression reported here: https://marc.info/?l=linux-ext4&m=152416385122029&w=2 ext4 folks are probably busy at LSF, so no reply yet. Should this commit be held until we get word f

  1   2   3   4   >