[GIT PULL] Ceph fixes for 4.17-rc2

2018-04-18 Thread Ilya Dryomov
access in CephFS, marked for stable. Arnd Bergmann (1): rbd: avoid Wreturn-type warnings Dongsheng Yang (1): rbd: support timeout in rbd_wait_state_locked() Ilya Dryomov (3): rbd: refactor rbd_wait_state_locked

[GIT PULL] Ceph updates for 4.17-rc1

2018-04-10 Thread Ilya Dryomov
ation" -> "reregistration" Ilya Dryomov (34): rbd: set max_segment_size to UINT_MAX libceph: eliminate overflows in ceph_calc_file_object_mapping() libceph, ceph: change ceph_calc_file_object_mapping() signature rbd: start enums at 1 instead of 0 lib

Re: [PATCH] [v2] rbd: avoid Wreturn-type warnings

2018-04-04 Thread Ilya Dryomov
On Wed, Apr 4, 2018 at 2:53 PM, Arnd Bergmann wrote: > A new set of warnings appeared in next-20180403 in some configurations > when gcc cannot see that rbd_assert(0) leads to an unreachable code > path: > > drivers/block/rbd.c: In function 'rbd_img_is_write': > drivers/block/rbd.c:1397:1: error:

Re: [PATCH] rbd: add missing return statements

2018-04-04 Thread Ilya Dryomov
On Wed, Apr 4, 2018 at 11:49 AM, Arnd Bergmann wrote: > A new set of warnings appeared in next-20180403 in some configurations > when gcc cannot see that rbd_assert(0) leads to an unreachable code > path: > > drivers/block/rbd.c: In function 'rbd_img_is_write': > drivers/block/rbd.c:1397:1: error:

Re: [PATCH] rbd: remove VLA usage

2018-03-30 Thread Ilya Dryomov
On Fri, Mar 30, 2018 at 9:17 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove the use of stack VLA. > > In this particular case, variable buf_size is replaced with a constant > expression that can be computed at preprocessing time. This avoids two > VLA warnings. Also, as

[GIT PULL] Ceph fix for 4.16-rc8

2018-03-30 Thread Ilya Dryomov
Hi Linus, The following changes since commit 3eb2ce825ea1ad89d20f7a3b5780df850e4be274: Linux 4.16-rc7 (2018-03-25 12:44:30 -1000) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.16-rc8 for you to fetch changes up to 85784f9395987a422fa04263e7

Re: Re: Re: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

2018-03-27 Thread Ilya Dryomov
On Tue, Mar 27, 2018 at 11:44 AM, KAMEI Hitoshi wrote: > Hi Ilya, > > Thank you for reviewing. > I merged two patches into one patch and pushed the new patch to GitHub. > And I opened the PR. Could you check the PR? > > And I forgot to mention in previous email that I modified your patch to > appl

Re: Re: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

2018-03-26 Thread Ilya Dryomov
On Mon, Mar 26, 2018 at 2:31 PM, 亀井仁志 / KAMEI,HITOSHI wrote: > Hi Ilya, > > I think your patch fully completes our purpose and I confirmed > that the kernel with the patch could work well by testing in my environment. > > I added the notrim option to rbd map command in accordance with > your kerne

Re: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

2018-03-23 Thread Ilya Dryomov
On Fri, Mar 23, 2018 at 10:31 AM, Ilya Dryomov wrote: > On Thu, Mar 22, 2018 at 12:57 PM, 亀井仁志 / KAMEI,HITOSHI > wrote: >> Hi Yang, >> >>> I am not sure is this the best way for this case, what about adding an >>> option in "rbd map -o thick rbd/test&

Re: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit

2018-03-23 Thread Ilya Dryomov
On Thu, Mar 22, 2018 at 12:57 PM, 亀井仁志 / KAMEI,HITOSHI wrote: > Hi Yang, > >> I am not sure is this the best way for this case, what about adding an >> option in "rbd map -o thick rbd/test"? > > I will add such option to the rbd map command to manipulate image settings. > So, the end-user > do n

Re: [PATCH v3] rbd: Remove VLA usage

2018-03-20 Thread Ilya Dryomov
On Sat, Mar 17, 2018 at 5:44 PM, Kyle Spiers wrote: > > As part of the effort to remove VLAs from the kernel[1], this moves > the literal values into the stack array calculation instead of using a > variable for the sizing. The resulting size can be found from > sizeof(buf). > > [1] https://lkml.o

Re: [PATCH] rbd: fix spelling mistake: "reregisteration" -> "re-registration"

2018-03-20 Thread Ilya Dryomov
On Tue, Mar 20, 2018 at 11:39 AM, Colin Ian King wrote: > On 20/03/18 10:35, Dongsheng Yang wrote: >> Hi Colin, >> >> On 03/19/2018 09:33 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> Trivial fix to spelling mistake in rdb_warn message text >>> >>> Signed-off-by: Colin Ian King >>> ---

Re: [PATCH 0/2] rbd: thick-provision image support

2018-03-20 Thread Ilya Dryomov
On Mon, Mar 19, 2018 at 1:00 PM, KAMEI Hitoshi wrote: > This patch series adds the thick-provision image support to > /drivers/block/rbd.c relating to https://github.com/ceph/ceph/pull/18317. > The rbd will not issue the discard operation to thick-provision > images, if applied. > > The rbd should

Re: [PATCH v2] rbd: Remove VLA usage

2018-03-16 Thread Ilya Dryomov
On Fri, Mar 16, 2018 at 5:32 AM, Kyle Spiers wrote: > As part of the effort to remove VLAs from the kernel[1], this moves > the literal values into the stack array calculation instead of using a > variable for the sizing. The resulting size can be found from > sizeof(buf). > > [1] https://lkml.org

Re: [PATCH] rbd: Remove VLA stack usage

2018-03-12 Thread Ilya Dryomov
On Mon, Mar 12, 2018 at 6:06 AM, Tobin C. Harding wrote: > On Sun, Mar 11, 2018 at 10:02:04PM -0700, Eric Biggers wrote: >> On Mon, Mar 12, 2018 at 03:49:40PM +1100, Tobin C. Harding wrote: >> > The kernel would like to have all stack VLA usage removed[1]. >> >> Can you please stop writing this?

Re: [PATCH] rbd: Remove VLA usage

2018-03-12 Thread Ilya Dryomov
On Sat, Mar 10, 2018 at 6:14 AM, Kyle Spiers wrote: > From 4198ebe2e8058ff676d8e2f993d8806d6ca29c11 Mon Sep 17 00:00:00 2001 > From: Kyle Spiers > Date: Fri, 9 Mar 2018 12:34:15 -0800 > Subject: [PATCH] rbd: Remove VLA usage > > As part of the effort to remove VLAs from the kernel[1], this moves

[GIT PULL] Ceph fixes for 4.16-rc4

2018-03-02 Thread Ilya Dryomov
Hi Linus, The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb: Linux 4.16-rc3 (2018-02-25 18:50:41 -0800) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.16-rc4 for you to fetch changes up to 1c789249578895bb14ab62b432

Re: [PATCH v2] block: rbd: update sysfs interface

2018-02-26 Thread Ilya Dryomov
On Fri, Feb 23, 2018 at 11:19 AM, Aishwarya Pant wrote: > The existing sysfs interface has been updated to be in the same format > as described in Documentation/ABI/README. This will be useful for > scripting and tracking changes in the ABI. Attributes have been grouped > by functionality and/or t

Re: [PATCH] block: rbd: update sysfs interface

2018-02-21 Thread Ilya Dryomov
On Tue, Feb 20, 2018 at 10:08 AM, Aishwarya Pant wrote: > The existing sysfs interface has been updated to be in the same format > as described in Documentation/ABI/README. This will be useful for > scripting and tracking changes in the ABI. Attributes have been grouped > by functionality and/or t

[GIT PULL] Ceph updates for 4.16-rc1

2018-02-08 Thread Ilya Dryomov
lue ceph: improving efficiency of syncfs Ilya Dryomov (4): rbd: obj_request->completion is unused rbd: use kmem_cache_zalloc() in rbd_img_request_create() rbd: don't NULL out ->obj_request in rbd_img_obj_parent_read_full() rbd: whitelist RBD_FEATURE_OPERATIONS fe

Re: [PATCH] libceph: use 64-bit arithmetic instead of 32-bit

2018-01-31 Thread Ilya Dryomov
On Wed, Jan 31, 2018 at 6:29 AM, Gustavo A. R. Silva wrote: > Cast objsetno to u64 in order to give the compiler complete > information about the proper arithmetic to use. Notice > that this variable is used in a context that expects an > expression of type u64 (64 bits, unsigned). > > The express

[GIT PULL] Ceph fixes for 4.15-rc8

2018-01-11 Thread Ilya Dryomov
Margaine (1): rbd: reacquire lock should update lock owner client id Ilya Dryomov (1): rbd: set max_segments to USHRT_MAX drivers/block/rbd.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-)

[GIT PULL] Ceph fix for 4.15-rc4

2017-12-15 Thread Ilya Dryomov
Hi Linus, The following changes since commit ae64f9bd1d3621b5e60d7363bc20afb46aede215: Linux 4.15-rc2 (2017-12-03 11:01:47 -0500) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.15-rc4 for you to fetch changes up to 040d786032bf59002d374b86d7

Re: [PATCH] fs/ceph: delete unused ceph_file_layout_is_valid function

2017-12-12 Thread Ilya Dryomov
On Tue, Dec 12, 2017 at 2:56 AM, Yaowei Bai wrote: > There's no users of ceph_file_layout_is_valid, remove it. It'll get a user in the next kernel release -- we'll remove ad-hoc checks from ceph_calc_file_object_mapping() which is executed on every mapping and call ceph_file_layout_is_valid() onc

[GIT PULL] Ceph updates for 4.15-rc1

2017-11-20 Thread Ilya Dryomov
discard_alignment to zero Eric Biggers (1): libceph: don't WARN() if user tries to add invalid key Gustavo A. R. Silva (1): ceph: mark expected switch fall-throughs Ilya Dryomov (4): ceph: -EINVAL on decoding failure in ceph_mdsc_handle_fsmap() rbd: fix and simplify rbd_ioctl_s

[GIT PULL] Ceph fix for 4.14-rc9

2017-11-10 Thread Ilya Dryomov
1e37f2f84680fa7f8394fd444b6928e334495ccc: rbd: use GFP_NOIO for parent stat and data requests (2017-11-09 09:32:53 +0100) Memory allocation flags fix, marked for stable. Ilya Dryomov (1

Re: KGDB/KDB treats WARN*() as Oops on x86 since 4.12

2017-11-09 Thread Ilya Dryomov
On Fri, Oct 13, 2017 at 4:59 PM, Daniel Thompson wrote: > On 09/10/17 13:24, Ilya Dryomov wrote: >> >> Hi Jason, >> >> Starting with 4.12, WARN*() is implemented with ud0, generating an >> Invalid Opcode exception. KGDB/KDB gets entered as if it were an Oops,

[GIT PULL] Ceph fix for 4.14-rc7

2017-10-26 Thread Ilya Dryomov
Hi Linus, The following changes since commit bb176f67090ca54869fc1262c913aa69d2ede070: Linux 4.14-rc6 (2017-10-23 06:49:47 -0400) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.14-rc7 for you to fetch changes up to 6c2838fbdedb9b72a81c931d49

Re: [PATCH] ceph: remove unused and redundant variable dropping

2017-10-18 Thread Ilya Dryomov
On Wed, Oct 18, 2017 at 1:34 PM, Colin King wrote: > From: Colin Ian King > > Variable dropping is set but never read and hence is redundant > and can be removed. Cleans up clang warning: > > fs/ceph/caps.c:1170:2: warning: Value stored to 'dropping' is never read > > Signed-off-by: Colin Ian Kin

Re: [PATCH] net: ceph: mark expected switch fall-throughs

2017-10-16 Thread Ilya Dryomov
On Sun, Oct 15, 2017 at 7:55 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > net/ceph/ceph_hash.c | 12 +++- > net/ceph/messenger.c | 1 + > n

Re: [PATCH] ceph: Delete unused variable in mds_client

2017-10-16 Thread Ilya Dryomov
l intent was to return -EINVAL if decoding fails (like we do in many other places) and -ENOENT if there is no filesystem with that name. This is user-visible: it's propagated all the way up and reported by mount(8). I'd rather we do something like this: commit 2b330133e10e7

Re: false positive lockdep splat with loop device

2017-10-10 Thread Ilya Dryomov
On Tue, Oct 10, 2017 at 11:16 AM, Ilya Dryomov wrote: > On Thu, Oct 5, 2017 at 6:33 PM, Christoph Hellwig wrote: >> Does the patch below fix the warning for you? >> >> -- >> From 28aae7104425433d39e6142adcd5b88dc5b0ad5f Mon Sep 17 00:00:00 2001 >> From: Chris

Re: false positive lockdep splat with loop device

2017-10-10 Thread Ilya Dryomov
On Thu, Oct 5, 2017 at 6:33 PM, Christoph Hellwig wrote: > Does the patch below fix the warning for you? > > -- > From 28aae7104425433d39e6142adcd5b88dc5b0ad5f Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Thu, 5 Oct 2017 18:31:02 +0200 > Subject: block: use DECLARE_COMPLETION_ONSTAC

KGDB/KDB treats WARN*() as Oops on x86 since 4.12

2017-10-09 Thread Ilya Dryomov
Hi Jason, Starting with 4.12, WARN*() is implemented with ud0, generating an Invalid Opcode exception. KGDB/KDB gets entered as if it were an Oops, making KGDB/KDB rather hard to use, particularly on testing kernels. Alexander posted a fix a while back, but Peter seems to be waiting for your ack

[GIT PULL] Ceph fixes for 4.14-rc4

2017-10-06 Thread Ilya Dryomov
Hi Linus, The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff: Linux 4.14-rc3 (2017-10-01 14:54:54 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.14-rc4 for you to fetch changes up to 38f340ccdf9ed5f1350505b46c

[GIT PULL] Ceph fixes for 4.14-rc2

2017-09-22 Thread Ilya Dryomov
create_session_open_msg(). Ilya Dryomov (1): libceph: don't allow bidirectional swap of pg-upmap-items Yan, Zheng (1): ceph: avoid panic in create_session_open_msg() if utsname() returns NULL fs/ceph/mds_client.c

[GIT PULL] Ceph updates for 4.14-rc1

2017-09-12 Thread Ilya Dryomov
Hi Linus, The following changes since commit 569dbb88e80deb68974ef6fdd6a13edb9d686261: Linux 4.13 (2017-09-03 13:56:17 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.14-rc1 for you to fetch changes up to 15b51bd6badbb373c723aa019cf530

[GIT PULL] Ceph fix for 4.13-rc8

2017-09-01 Thread Ilya Dryomov
Hi Linus, The following changes since commit cc4a41fe5541a73019a864883297bd5043aa6d98: Linux 4.13-rc7 (2017-08-27 17:20:40 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.13-rc8 for you to fetch changes up to dd2bc473482eedc60c29cf00ad

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-18 Thread Ilya Dryomov
On Thu, Aug 17, 2017 at 8:40 PM, Luis Henriques wrote: > Ilya Dryomov writes: > >> On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: >>> Luis Henriques writes: >>> >>>> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >>

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-17 Thread Ilya Dryomov
On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: > Luis Henriques writes: > >> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >> ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for >> SEEK_DATA and 0 for SEEK_HOLE. > > Ping > > This patch should ma

[GIT PULL] Ceph fixes for 4.13-rc4

2017-08-04 Thread Ilya Dryomov
tic changes in v12.1.2. ---- Ilya Dryomov (6): libceph: make encode_request_*() work with r_mempool requests libceph: don't call ->reencode_message() more than once per message libceph: fallback for when there i

Re: linux-next: Signed-off-by misspelt for commit in the ceph tree

2017-07-28 Thread Ilya Dryomov
On Fri, Jul 28, 2017 at 1:28 AM, Stephen Rothwell wrote: > Hi Sage, > > Commit > > aaebc1ce8663 ("libceph: fallback for when there isn't a pool-specific > choose_arg") > > has Signed-off-by misspelt. Hah, I wonder how that happened. Fixed now, thanks Stephen! Ilya

Re: [PATCH] rbd: add timeout function to rbd driver

2017-07-27 Thread Ilya Dryomov
On Thu, Jul 27, 2017 at 12:32 PM, wrote: > From: Xiongwei Jiang > > when an application is writing or reading on rbd device, if some or all > OSDs crash, the application will hang and can't be killed because it is > in D state. Even though OSDs comes up later, the application may still > keeps i

[GIT PULL] Ceph fixes for 4.13-rc2

2017-07-19 Thread Ilya Dryomov
. Arnd Bergmann (1): libceph: fix old style declaration warnings Dan Carpenter (2): libceph: NULL deref on osdmap_apply_incremental() error path libceph: potential NULL dereference in ceph_msg_data_create() Ilya Dryomov (3): libceph: set

Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock

2017-07-17 Thread Ilya Dryomov
On Fri, Jul 14, 2017 at 1:25 PM, Kefeng Wang wrote: > > > On 2017/7/14 18:06, Ilya Dryomov wrote: >> On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang >> wrote: >>> drivers/block/rbd.c: In function 'rbd_acquire_lock': >>> drivers/block/rbd.c:3602:4

Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock

2017-07-14 Thread Ilya Dryomov
On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang wrote: > drivers/block/rbd.c: In function 'rbd_acquire_lock': > drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this > function [-Werror=maybe-uninitialized] > > Silence the warning, found it when built old kernel(3.10) with > OB

[GIT PULL] Ceph updates for 4.13-rc1

2017-07-11 Thread Ilya Dryomov
from Zheng. ---- Ilya Dryomov (33): libceph: remove ceph_sanitize_features() workaround libceph: new features macros libceph: handle non-empty dest in ceph_{oloc,oid}_copy() libceph: advertise support for OSD_POOLRESEND libceph: support SERVER_JEWEL feature bits lib

Re: [PATCH] libceph: fix old style declaration warnings

2017-07-10 Thread Ilya Dryomov
On Mon, Jul 10, 2017 at 1:17 PM, Arnd Bergmann wrote: > The new macros don't follow the usual style for declarations, > which we get a warning for with 'make W=1': > > In file included from fs/ceph/mds_client.c:16:0: > include/linux/ceph/ceph_features.h:74:1: error: 'static' is not at beginning >

[GIT PULL] Ceph fixes for 4.12-rc6

2017-06-17 Thread Ilya Dryomov
Hi Linus, The following changes since commit 32c1431eea4881a6b17bd7c639315010aeefa452: Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.12-rc6 for you to fetch changes up to 4ca2fea6f8277ab381bd08b996

[GIT PULL] Ceph fix for 4.12-rc4

2017-06-02 Thread Ilya Dryomov
. Ilya Dryomov (1): rbd: implement REQ_OP_WRITE_ZEROES drivers/block/rbd.c | 2 ++ 1 file changed, 2 insertions(+)

[GIT PULL] Ceph fixes for 4.12-rc3

2017-05-26 Thread Ilya Dryomov
ocate fix. Dan Carpenter (1): libceph: NULL deref on crush_decode() error path Ilya Dryomov (5): libceph: use kbasename() and kill ceph_file_part() libceph: make ceph_msg_data_advance() return void libceph:

[GIT PULL] Ceph updates for 4.12-rc1

2017-05-10 Thread Ilya Dryomov
refcount_t libceph: convert ceph_pagelist.refcnt from atomic_t to refcount_t Ilya Dryomov (11): libceph, ceph: always advertise all supported features libceph: supported_features module parameter rbd: move rbd_dev_destroy() call out of rbd_dev_image_release()

Re: linux-next: incomplete commits in the ceph tree

2017-05-04 Thread Ilya Dryomov
On Wed, May 3, 2017 at 11:48 PM, Stephen Rothwell wrote: > Hi Sage, > > I noticed several new commits in the ceph tree today that have no > Singn-off-by from their committer (Ilya). :-( I've just fixed that, thanks for the heads up! Ilya

[GIT PULL] Ceph fix for 4.11-rc9

2017-04-27 Thread Ilya Dryomov
Hi Linus, The following changes since commit 5a7ad1146caa895ad718a534399e38bd2ba721b7: Linux 4.11-rc8 (2017-04-23 16:53:00 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.11-rc9 for you to fetch changes up to 8179a101eb5f4ef0ac9a915fce

Re: [PATCH 0/2] fs, ceph filesystem refcount conversions

2017-04-20 Thread Ilya Dryomov
On Thu, Apr 20, 2017 at 9:40 AM, Reshetova, Elena wrote: > >> On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova >> wrote: >> > Now when new refcount_t type and API are finally merged >> > (see include/linux/refcount.h), the following >> > patches convert various refcounters in the ceph filesystem

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Ilya Dryomov
On Thu, Mar 30, 2017 at 6:12 PM, Michal Hocko wrote: > On Thu 30-03-17 17:06:51, Ilya Dryomov wrote: > [...] >> > But if the allocation is stuck then the holder of the lock cannot make >> > a forward progress and it is effectivelly deadlocked because other IO >>

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Ilya Dryomov
On Thu, Mar 30, 2017 at 4:36 PM, Michal Hocko wrote: > On Thu 30-03-17 15:48:42, Ilya Dryomov wrote: >> On Thu, Mar 30, 2017 at 1:21 PM, Michal Hocko wrote: > [...] >> > familiar with Ceph at all but does any of its (slab) shrinkers generate >> > IO to recurse bac

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Ilya Dryomov
On Thu, Mar 30, 2017 at 8:25 AM, Michal Hocko wrote: > On Wed 29-03-17 16:25:18, Ilya Dryomov wrote: >> On Wed, Mar 29, 2017 at 1:16 PM, Michal Hocko wrote: >> > On Wed 29-03-17 13:10:01, Ilya Dryomov wrote: >> >> On Wed, Mar 29, 2017 at 12:55 PM, Michal Hocko wro

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Ilya Dryomov
On Thu, Mar 30, 2017 at 1:21 PM, Michal Hocko wrote: > On Thu 30-03-17 12:02:03, Ilya Dryomov wrote: >> On Thu, Mar 30, 2017 at 8:25 AM, Michal Hocko wrote: >> > On Wed 29-03-17 16:25:18, Ilya Dryomov wrote: > [...] >> >> We got rid of osdc->request_mutex

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Ilya Dryomov
On Thu, Mar 30, 2017 at 8:25 AM, Michal Hocko wrote: > On Wed 29-03-17 16:25:18, Ilya Dryomov wrote: >> On Wed, Mar 29, 2017 at 1:16 PM, Michal Hocko wrote: >> > On Wed 29-03-17 13:10:01, Ilya Dryomov wrote: >> >> On Wed, Mar 29, 2017 at 12:55 PM, Michal Hocko wro

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-29 Thread Ilya Dryomov
On Wed, Mar 29, 2017 at 1:49 PM, Brian Foster wrote: > On Wed, Mar 29, 2017 at 01:18:34PM +0200, Michal Hocko wrote: >> On Wed 29-03-17 13:14:42, Ilya Dryomov wrote: >> > On Wed, Mar 29, 2017 at 1:05 PM, Brian Foster wrote: >> > > On Wed, Mar 29, 2017 at 12:41:

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-29 Thread Ilya Dryomov
On Wed, Mar 29, 2017 at 1:16 PM, Michal Hocko wrote: > On Wed 29-03-17 13:10:01, Ilya Dryomov wrote: >> On Wed, Mar 29, 2017 at 12:55 PM, Michal Hocko wrote: >> > On Wed 29-03-17 12:41:26, Michal Hocko wrote: >> > [...] >> >> > ceph_con_workfn >> &

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-29 Thread Ilya Dryomov
On Wed, Mar 29, 2017 at 1:05 PM, Brian Foster wrote: > On Wed, Mar 29, 2017 at 12:41:26PM +0200, Michal Hocko wrote: >> [CC xfs guys] >> >> On Wed 29-03-17 11:21:44, Ilya Dryomov wrote: >> [...] >> > This is a set of stack traces from http://tracker.ceph.

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-29 Thread Ilya Dryomov
On Wed, Mar 29, 2017 at 12:55 PM, Michal Hocko wrote: > On Wed 29-03-17 12:41:26, Michal Hocko wrote: > [...] >> > ceph_con_workfn >> > mutex_lock(&con->mutex) # ceph_connection::mutex >> > try_write >> > ceph_tcp_connect >> > sock_create_kern >> > GFP_KERNEL allocation >> >

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-29 Thread Ilya Dryomov
On Tue, Mar 28, 2017 at 3:30 PM, Michal Hocko wrote: > On Tue 28-03-17 15:23:58, Ilya Dryomov wrote: >> On Tue, Mar 28, 2017 at 2:43 PM, Michal Hocko wrote: >> > On Tue 28-03-17 14:30:45, Greg KH wrote: >> >> 4.4-stable review patch. If anyone has any objecti

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-28 Thread Ilya Dryomov
On Tue, Mar 28, 2017 at 2:43 PM, Michal Hocko wrote: > On Tue 28-03-17 14:30:45, Greg KH wrote: >> 4.4-stable review patch. If anyone has any objections, please let me know. > > I haven't seen the original patch but the changelog makes me worried. > How exactly this is a problem? Where do we lock

[GIT PULL] Ceph fix for 4.11-rc4

2017-03-24 Thread Ilya Dryomov
. Ilya Dryomov (1): libceph: force GFP_NOIO for socket allocations net/ceph/messenger.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [PATCH 06/23] net, ceph: convert ceph_pagelist.refcnt from atomic_t to refcount_t

2017-03-24 Thread Ilya Dryomov
On Fri, Mar 17, 2017 at 1:10 PM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed

Re: [PATCH 05/23] net, ceph: convert ceph_osd.o_ref from atomic_t to refcount_t

2017-03-24 Thread Ilya Dryomov
On Fri, Mar 17, 2017 at 1:10 PM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed

Re: [PATCH 04/23] net, ceph: convert ceph_snap_context.nref from atomic_t to refcount_t

2017-03-24 Thread Ilya Dryomov
On Fri, Mar 17, 2017 at 1:10 PM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed

[GIT PULL] Ceph fixes for 4.11-rc2

2017-03-10 Thread Ilya Dryomov
CRUSH changes and two usability enhancements: osd_request_timeout option and supported_features bus attribute. Ilya Dryomov (4): libceph: fix crush_decode() for older maps libceph: don't set weight to IN when OSD is dest

Re: [PATCH 0/2] fs, ceph filesystem refcount conversions

2017-03-03 Thread Ilya Dryomov
On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova wrote: > Now when new refcount_t type and API are finally merged > (see include/linux/refcount.h), the following > patches convert various refcounters in the ceph filesystem from atomic_t > to refcount_t. By doing this we prevent intentional or acci

[GIT PULL] Ceph updates for 4.11-rc1

2017-02-28 Thread Ilya Dryomov
Goyal (1): rbd: constify device_type structure Colin Ian King (1): ceph: fix spelling mistake: "enabing" -> "enabling" Dan Carpenter (1): ceph: tidy some white space in get_nonsnap_parent() Ilya Dryomov (26): libceph: include linux/sched.h into cryp

Re: [PATCH] rbd: constify device_type structure

2017-02-13 Thread Ilya Dryomov
On Sat, Feb 11, 2017 at 7:44 AM, Bhumika Goyal wrote: > Declare device_type structure as const as it is only stored in the > type field of a device structure. This field is of type const, so add > const to the declaration of device_type structure. > > File size before: >textdata bss

Re: [PATCH 1/2] libceph: Remove unneeded stddef.h include

2017-02-06 Thread Ilya Dryomov
On Sun, Feb 5, 2017 at 8:07 AM, Stafford Horne wrote: > This was causing a build failure for openrisc when using musl and > gcc 5.4.0 since the file is not available in the toolchain. > > It doesnt seem this is needed and removing it does not cause any build > warnings for me. > > Signed-off-by: S

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

2017-01-25 Thread Ilya Dryomov
On Wed, Jan 25, 2017 at 2:09 PM, Michal Hocko wrote: > On Wed 25-01-17 12:15:59, Vlastimil Babka wrote: >> On 01/24/2017 04:00 PM, Michal Hocko wrote: >> > > > Well, I am not opposed to kvmalloc_array but I would argue that this >> > > > conversion cannot introduce new overflow issues. The code wo

[GIT PULL] Ceph fixes for 4.10-rc5

2017-01-20 Thread Ilya Dryomov
window's patches. Ilya Dryomov (1): libceph: make sure ceph_aes_crypt() IV is aligned Jeff Layton (3): ceph: fix endianness of getattr mask in ceph_d_revalidate ceph: fix endianness bug in frag_tree_split_cmp

Re: [PATCH] ceph: use BUG() instead of BUG_ON(1)

2017-01-16 Thread Ilya Dryomov
On Mon, Jan 16, 2017 at 12:06 PM, Arnd Bergmann wrote: > I ran into this compile warning, which is the result of BUG_ON(1) > not always leading to the compiler treating the code path as > unreachable: > > include/linux/ceph/osdmap.h: In function 'ceph_can_shift_osds': > include/linux/ceph/osdmap.h

[GIT PULL] Ceph fixes for 4.10-rc4

2017-01-13 Thread Ilya Dryomov
Hi Linus, The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: Linux 4.10-rc3 (2017-01-08 14:18:17 -0800) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.10-rc4 for you to fetch changes up to 84fcc2d2bd6cbf621e49e1d0f7

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

2017-01-12 Thread Ilya Dryomov
> Cc: Yishai Hadas > Cc: Dan Williams > Cc: Oleg Drokin > Cc: Andreas Dilger > Cc: Boris Ostrovsky > Cc: David Sterba > Cc: "Yan, Zheng" > Cc: Ilya Dryomov > Cc: Alexander Viro > Cc: Alexei Starovoitov > Cc: Eric Dumazet >

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 12:53 PM, Al Viro wrote: > On Thu, Jan 12, 2017 at 12:46:42PM +0100, Ilya Dryomov wrote: >> On Thu, Jan 12, 2017 at 12:37 PM, Al Viro wrote: >> > On Thu, Jan 12, 2017 at 12:13:31PM +0100, Ilya Dryomov wrote: >> > >> >> It would be

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 12:37 PM, Al Viro wrote: > On Thu, Jan 12, 2017 at 12:13:31PM +0100, Ilya Dryomov wrote: > >> It would be a significant and wide-reaching change, but I've been >> meaning to look into switching to iov_iter for a couple of releases >> now. T

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 12:27 PM, Jeff Layton wrote: > On Thu, 2017-01-12 at 07:59 +, Al Viro wrote: >> On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: >> > >> > v2: fix bug in offset handling in iov_iter_pvec_size >> > >> > xfstest generic/095 triggers soft lockups in kcephfs. Ba

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 8:59 AM, Al Viro wrote: > On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: >> v2: fix bug in offset handling in iov_iter_pvec_size >> >> xfstest generic/095 triggers soft lockups in kcephfs. Basically it uses >> fio to drive some I/O via vmsplice ane splice. Cep

[GIT PULL] Ceph updates for 4.10-rc1

2016-12-16 Thread Ilya Dryomov
throughout. ---- Ilya Dryomov (18): libceph: ceph_x_encrypt_buflen() takes in_len libceph: old_key in process_one_ticket() is redundant libceph: introduce ceph_x_encrypt_offset() libceph: introduce ceph_crypt() for in-place en/decryption libceph: rename

[GIT PULL] Ceph fix for 4.9-rc9

2016-12-09 Thread Ilya Dryomov
Hi Linus, The following changes since commit 3e5de27e940d00d8d504dfb96625fb654f641509: Linux 4.9-rc8 (2016-12-04 12:50:51 -0800) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.9-rc9 for you to fetch changes up to c3f4688a08fd86f1bf8e055724c8

Re: drivers/block/rbd.c:838: bad if expression ?

2016-11-15 Thread Ilya Dryomov
On Tue, Nov 15, 2016 at 11:38 AM, David Binderman wrote: > Hello there, > > drivers/block/rbd.c:838:34: warning: logical ‘and’ of mutually exclusive > tests is always false [-Wlogical-op] > > Source code is > >} else if (token > Opt_last_int && token < Opt_last_string) { > > but > > enum { >

Re: [git pull] vfs.git

2016-11-11 Thread Ilya Dryomov
On Fri, Nov 11, 2016 at 6:25 PM, Linus Torvalds wrote: > On Thu, Nov 10, 2016 at 10:05 PM, Al Viro wrote: >> Christoph's and Jan's aio fixes, fixup for generic_file_splice_read >> (removal of pointless detritus that actually breaks it when used for gfs2 >> ->splice_read()) and fixup for g

[GIT PULL] Ceph fixes for 4.9-rc5

2016-11-11 Thread Ilya Dryomov
witch to the less efficient default_file_splice_read() for now; the proper fix is being held for 4.10. We also have a fix for a 4.8 regression and a trival libceph fixup. ---- Ilya Dryomov (1): libceph: initialize last_linger_id with

Re: crash in invalidate_mapping_pages codepath during fadvise

2016-11-08 Thread Ilya Dryomov
On Tue, Nov 8, 2016 at 3:21 PM, Jeff Layton wrote: > We hit the following panic while running some (userland) ceph testing: > > [ 3643.590247] [ cut here ] > [ 3643.594883] kernel BUG at > /srv/autobuild-ceph/gitbuilder.git/build/include/linux/swap.h:276! > [ 3643.603346]

Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write()

2016-11-08 Thread Ilya Dryomov
On Tue, Nov 8, 2016 at 10:16 AM, Zhi Zhang wrote: > Fix printing wrong return variable for invalidate_inode_pages2_range > in ceph_direct_read_write(). > > Signed-off-by: Zhi Zhang > --- > fs/ceph/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/file.c b/fs

[GIT PULL] Ceph fixes for 4.9-rc2

2016-10-20 Thread Ilya Dryomov
frags race was introduced in 4.9-rc1. Geert Uytterhoeven (1): ceph: fix uninitialized dentry pointer in ceph_real_mount() Ilya Dryomov (2): rbd: don't wait for the lock forever if blacklisted rbd: don

Re: [PATCH 11/28] block: rdb: false-postive gcc-4.9 -Wmaybe-uninitialized

2016-10-18 Thread Ilya Dryomov
On Tue, Oct 18, 2016 at 12:10 AM, Arnd Bergmann wrote: > When building with gcc-4.9 -Wmaybe-uninitialized, we get a bogus > warning in rbd_watch_cb, as the variable is not used at all > in the one case in which it is not initialized first: > > drivers/block/rbd.c: In function ‘rbd_watch_cb’: > dri

Re: [PATCHv2] ceph: Fix error handling in ceph_read_iter

2016-10-10 Thread Ilya Dryomov
On Mon, Oct 10, 2016 at 3:13 PM, Nikolay Borisov wrote: > > > On 10/10/2016 04:11 PM, Yan, Zheng wrote: >> >>> On 10 Oct 2016, at 20:56, Nikolay Borisov wrote: >>> >>> In case __ceph_do_getattr returns an error and the retry_op in >>> ceph_read_iter is not READ_INLINE, then it's possible to invok

[GIT PULL] Ceph updates for 4.9-rc1

2016-10-08 Thread Ilya Dryomov
elper libceph: support for advisory locking on RADOS objects libceph: support for lock.lock_info libceph: support for blacklisting clients Ilya Dryomov (21): libceph: rename ceph_entity_name_encode() -> ceph_auth_entity_name_encode() libceph: rename ceph_c

"CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk())

2016-09-19 Thread Ilya Dryomov
On Mon, Sep 19, 2016 at 11:37 AM, Jean Delvare wrote: > Hi Ilya, > > Sorry for the late answer. > > On Tue, 13 Sep 2016 20:31:57 +0200, Ilya Dryomov wrote: >> Sorry, navigating lkml.org archive is a pain, and I was expecting to >> see patch. Your points >>

Re: [PATCH 01/47] block-rbd: Use kmalloc_array() in rbd_header_from_disk()

2016-09-14 Thread Ilya Dryomov
On Mon, Sep 12, 2016 at 8:42 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 11 Sep 2016 12:21:25 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

2016-09-13 Thread Ilya Dryomov
On Tue, Sep 13, 2016 at 6:50 PM, Jean Delvare wrote: > On Tue, 13 Sep 2016 17:30:33 +0200, Ilya Dryomov wrote: >> On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: >> > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: >> >> Jon, could you please yank 865a1

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

2016-09-13 Thread Ilya Dryomov
On Tue, Sep 13, 2016 at 4:36 PM, Jean Delvare wrote: > Hi Ilya, > > Thanks for adding me. > > On Tue, 13 Sep 2016 11:16:13 +0200, Ilya Dryomov wrote: >> On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring >> wrote: >> >>> @@ -1064,7 +1064,7 @@ static

Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()

2016-09-13 Thread Ilya Dryomov
On Tue, Sep 13, 2016 at 10:12 AM, SF Markus Elfring wrote: >>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device >>> *rbd_dev, >>> header->snap_sizes = snap_sizes; >>> >>> return 0; >>> -out_2big: >>> + out_2big: >>> ret = -EIO; >>> kfree(snap

<    1   2   3   4   >