On Mon, Sep 12, 2016 at 9:14 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Mon, 12 Sep 2016 19:44:30 +0200
>
> Adjust a jump target so that a duplicate check can then be avoided
> at the end.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/block/rbd.c | 6 +++---
> 1 file change
On Mon, Sep 12, 2016 at 9:00 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Mon, 12 Sep 2016 18:12:39 +0200
>
> Adjust jump labels according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/block/rbd.c | 9 -
> 1 file changed,
On Mon, Sep 12, 2016 at 8:47 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Sun, 11 Sep 2016 15:20:48 +0200
>
> Adjust jump labels according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/block/rbd.c | 24
>
On Mon, Sep 12, 2016 at 8:45 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Sun, 11 Sep 2016 14:48:41 +0200
>
> * Pass the sizes for memory allocations to the corresponding functions
> directly without storing the calculated values in an
> intermediate variable.
>
> * Delete the
On Mon, Sep 12, 2016 at 8:44 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Sun, 11 Sep 2016 13:37:34 +0200
>
> Add a space character before a single jump label in this function
> according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring
> ---
> driv
On Mon, Sep 12, 2016 at 8:43 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Sun, 11 Sep 2016 13:18:57 +0200
>
> The functions "ceph_put_snap_context" and "kfree" were called in a few
> cases by the function "rbd_header_from_disk" during error handling
> even if the passed variables c
Hi Linus,
The following changes since commit c6935931c1894ff857616ff8549b61236a19148f:
Linux 4.8-rc5 (2016-09-04 14:31:46 -0700)
are available in the git repository at:
https://github.com/ceph/ceph-client.git tags/ceph-for-4.8-rc6
for you to fetch changes up to 0f5aa88a7bb28b73253fb42b3df8
.
Ilya Dryomov (3):
rbd: destroy header_oloc in rbd_dev_release()
rbd: nuke the 32-bit pool id check
ceph: initialize pathbase in the !dentry case in encode_caps_cb()
Wei Yongjun (3):
libceph: fix return value check in
n Ian King (1):
ceph: fix spelling mistake: "resgister" -> "register"
Ilya Dryomov (3):
libceph: fix some missing includes
libceph: add an ONSTACK initializer for oids
libceph: add start en/decoding block helpers
Jeff Layton (4):
ceph: remov
A fix for a long-standing bug in the incremental osdmap handling code
that caused misdirected requests, tagged for stable.
----
Ilya Dryomov (1):
libceph: apply new_state before new_up_client on incrementals
net/ceph/osdm
On Mon, Jun 13, 2016 at 3:04 PM, Arnd Bergmann wrote:
> The genksyms helper in the kernel cannot parse a type definition
> like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS
> helper, causing the following EXPORT_SYMBOL() statement to be ignored
> when computing the crcs, and t
On Fri, May 6, 2016 at 9:24 AM, Yan, Zheng wrote:
>
>> On May 6, 2016, at 15:14, Zhang Zhuoyu
>> wrote:
>>
>> Hi, Yan, Viro
>>
>> Any other comments on this updated version?
>
> I have no comment for the cephfs part.
>
> Ilya, do you like the libceph part?
I'd leave off rados.h hunk - it's sha
On Wed, Mar 30, 2016 at 4:40 AM, NeilBrown wrote:
> On Wed, Mar 30 2016, Yan, Zheng wrote:
>
>> On Wed, Mar 30, 2016 at 8:24 AM, NeilBrown wrote:
>>> On Fri, Mar 25 2016, Ilya Dryomov wrote:
>>>
>>>> On Fri, Mar 25, 2016 at 5:02 AM, NeilBrown wrote:
On Sat, Mar 26, 2016 at 11:00 PM, Linus Torvalds
wrote:
> On Sat, Mar 26, 2016 at 2:46 PM, Ilya Dryomov wrote:
>>
>> FWIW, it matches -next content-wise. SHAs don't match because of an
>> extra Signed-off-by in an unrelated commit, outside of fs/ceph.
>
> That&#
On Sat, Mar 26, 2016 at 10:33 PM, Linus Torvalds
wrote:
> On Sat, Mar 26, 2016 at 2:19 PM, Ilya Dryomov wrote:
>>
>> This really is a result of a miscommunication between us and Al.
>> Lesson learned. Please reconsider and pull.
>
> No.
>
> If you guys rebase
On Sat, Mar 26, 2016 at 7:30 PM, Linus Torvalds
wrote:
> On Fri, Mar 25, 2016 at 6:39 PM, Sage Weil wrote:
>>
>> This series is based on a recent merge of Al's tree to avoid conflicts
>> with his splice_dentry changes.
>
> Once again, and with feeling: please PLEASE stop doing these idiotic thing
On Fri, Mar 25, 2016 at 5:02 AM, NeilBrown wrote:
> On Sun, Mar 06 2016, Sage Weil wrote:
>
>> Hi Linus,
>>
>> Please pull the following Ceph patch from
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git
>> for-linus
>>
>> This is a final commit we missed to align the prot
On Sun, Mar 13, 2016 at 8:18 AM, Geliang Tang wrote:
> Use KMEM_CACHE() instead of kmem_cache_create() to simplify the code.
>
> Signed-off-by: Geliang Tang
> ---
> net/ceph/messenger.c | 10 ++
> net/ceph/osd_client.c | 5 +
> 2 files changed, 3 insertions(+), 12 deletions(-)
>
>
On Sun, Mar 13, 2016 at 8:26 AM, Geliang Tang wrote:
> Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO.
>
> Signed-off-by: Geliang Tang
> ---
> fs/ceph/dir.c | 2 +-
> fs/ceph/file.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ceph/dir
On Sun, Mar 13, 2016 at 8:17 AM, Geliang Tang wrote:
> Use KMEM_CACHE() instead of kmem_cache_create() to simplify the code.
>
> Signed-off-by: Geliang Tang
> ---
> drivers/block/rbd.c | 10 ++
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drive
On Thu, Feb 4, 2016 at 9:30 AM, Arnd Bergmann wrote:
> On Thursday 04 February 2016 10:00:19 Yan, Zheng wrote:
>> > On Feb 4, 2016, at 05:27, Arnd Bergmann wrote:
>> {
>> struct ceph_timespec ts;
>> ceph_encode_timespec(&ts, &req->r_stamp);
>> ceph_encode_copy(&p, &t
On Tue, Jan 26, 2016 at 3:51 PM, Yan, Zheng wrote:
>
>> On Jan 26, 2016, at 22:02, Ilya Dryomov wrote:
>>
>> On Tue, Jan 26, 2016 at 12:54 PM, Yan, Zheng wrote:
>>>
>>>> On Jan 26, 2016, at 19:40, Ilya Dryomov wrote:
>>>>
&g
On Tue, Jan 26, 2016 at 12:54 PM, Yan, Zheng wrote:
>
>> On Jan 26, 2016, at 19:40, Ilya Dryomov wrote:
>>
>> On Tue, Jan 26, 2016 at 12:16 PM, Yan, Zheng wrote:
>>>
>>>> On Jan 26, 2016, at 18:30, Ilya Dryomov wrote:
>>>>
>>&g
On Tue, Jan 26, 2016 at 12:16 PM, Yan, Zheng wrote:
>
>> On Jan 26, 2016, at 18:30, Ilya Dryomov wrote:
>>
>> On Tue, Jan 26, 2016 at 10:24 AM, Dan Carpenter
>> wrote:
>>> ceph_osdc_alloc_request() returns NULL on error, it never returns error
>>>
On Tue, Jan 26, 2016 at 11:54 AM, Herbert Xu
wrote:
> On Mon, Jan 25, 2016 at 05:18:47PM +0100, Ilya Dryomov wrote:
>>
>> Could you get rid of ivsize instead of assigning to it - see the
>> attached diff?
>
> How about an incremental patch like this? Thanks!
>
&
On Tue, Jan 26, 2016 at 10:24 AM, Dan Carpenter
wrote:
> ceph_osdc_alloc_request() returns NULL on error, it never returns error
> pointers.
>
> Fixes: 5be0389dac66 ('ceph: re-send AIO write request when getting -EOLDSNAP
> error')
> Signed-off-by: Dan Carpenter
>
> diff --git a/fs/ceph/file.c b
deletions(-)
Could you get rid of ivsize instead of assigning to it - see the
attached diff?
Otherwise:
Acked-by: Ilya Dryomov
Thanks,
Ilya
diff --git a/net/ceph/crypto.c b/net/ceph/crypto.c
index 42e8649c6e79..db2847ac5f12 100644
--- a/net/ceph/crypto.c
+++ b/net/ceph/crypto.c
@
On Thu, Nov 26, 2015 at 8:54 AM, SF Markus Elfring
wrote:
>>> I interpreted the eventual passing of a null pointer to the
>>> rbd_dev_destroy()
>>> function as an indication for further source code adjustments.
>>
>> If all error paths could be adjusted so that NULL pointers are never passed
>>
On Wed, Nov 25, 2015 at 12:55 PM, Dan Carpenter
wrote:
> On Tue, Nov 24, 2015 at 09:21:06PM +0100, Ilya Dryomov wrote:
>> >> Cleanup here is (and should be) done in reverse order.
>> >
>
> Yes. This is true.
>
>> > I have got an other impr
On Tue, Nov 24, 2015 at 9:34 PM, SF Markus Elfring
wrote:
>> Well, there isn't any _literal_ linking (e.g. adding to a link list,
>> etc) in this case. We just bump some refs and do probe to fill in the
>> newly allocated parent.
>
> Thanks for your clarification.
>
>
>> The actual linking (rbd_d
On Tue, Nov 24, 2015 at 8:23 PM, SF Markus Elfring
wrote:
>>> @@ -5157,14 +5157,14 @@ static int rbd_dev_probe_parent(struct rbd_device
>>> *rbd_dev, int depth)
>>> if (++depth > RBD_MAX_PARENT_CHAIN_LEN) {
>>> pr_info("parent chain is too long (%d)\n", depth);
>>>
On Mon, Nov 23, 2015 at 8:46 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Mon, 23 Nov 2015 20:22:41 +0100
>
> The rbd_dev_destroy() function was called in two cases by the
> rbd_dev_probe_parent() function during error handling even if
> the passed variable contained a null pointer
On Mon, Nov 23, 2015 at 8:44 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Mon, 23 Nov 2015 20:16:45 +0100
>
> The rbd_dev_destroy() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected b
On Thu, Nov 19, 2015 at 10:18 PM, Tejun Heo wrote:
> Hello, Ilya.
>
> On Thu, Nov 19, 2015 at 09:56:21PM +0100, Ilya Dryomov wrote:
>> > Yes, that's where *I* think we should be headed. Stuff in lower
>> > layers should stick around while upper layer thi
On Wed, Nov 18, 2015 at 4:48 PM, Ilya Dryomov wrote:
> On Wed, Nov 18, 2015 at 4:30 PM, Tejun Heo wrote:
>> Hello, Ilya.
>>
>> On Wed, Nov 18, 2015 at 04:12:07PM +0100, Ilya Dryomov wrote:
>>> > It's stinky that the bdi is going away while the inode is stil
On Wed, Nov 18, 2015 at 4:30 PM, Tejun Heo wrote:
> Hello, Ilya.
>
> On Wed, Nov 18, 2015 at 04:12:07PM +0100, Ilya Dryomov wrote:
>> > It's stinky that the bdi is going away while the inode is still there.
>> > Yeah, blkdev inodes are special and created early bu
On Tue, Nov 17, 2015 at 9:56 PM, Tejun Heo wrote:
> Hello, Ilya.
>
> On Mon, Nov 16, 2015 at 09:59:18PM +0100, Ilya Dryomov wrote:
> ...
>> Looking at __blkdev_put(), the issue becomes clear: we are taking
>> precautions to flush before calling out to ->release() becaus
On Wed, Nov 18, 2015 at 1:13 PM, Sergey Senozhatsky
wrote:
> Cosmetic.
>
> Do not define list_entry_next() and use list_next_entry()
> from list.h.
>
> Signed-off-by: Sergey Senozhatsky
> ---
> net/ceph/messenger.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/
On Mon, Nov 16, 2015 at 2:46 PM, Geliang Tang wrote:
> list_next_entry has been defined in list.h, so I replace list_entry_next
> with it.
>
> Signed-off-by: Geliang Tang
> ---
> net/ceph/messenger.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/net/ceph/messeng
Hello,
Last week, while running an rbd test which does a lot of maps and
unmaps (read losetup / losetup -d) with slab debugging enabled, I hit
the attached splat. That 6a byte corresponds to the atomic_long_t
count of the percpu_ref refcnt in request_queue::backing_dev_info::wb,
pointing to a per
On Mon, Nov 9, 2015 at 11:15 AM, Yan, Zheng wrote:
>
>> On Nov 9, 2015, at 11:11, Nicholas Krause wrote:
>>
>> This fixes error handling in the function down_reply in order to
>> properly check and jump to the goto label, out_err for this
>> particular function if a error code is returned by any
On Fri, Oct 2, 2015 at 9:48 PM, Nicholas Krause wrote:
> This removes unused goto labels in decode crush map functions related
> to error paths due to them never being used on any error path for these
> particular functions in the file, osdmap.c.
>
> Signed-off-by: Nicholas Krause
> ---
> net/ce
On Sun, Sep 13, 2015 at 3:15 PM, Julia Lawall wrote:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@ expression x; @@
> -if (x != NULL) {
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> x =
On Thu, Sep 10, 2015 at 10:57 AM, kbuild test robot
wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master
> head: 22dc312d56ba077db27a9798b340e7d161f1df05
> commit: 5f1c79a71766ba656762636936edf708089bdb14 [12335/12685] libceph: check
> data_len in ->all
v/scsi/logging_level
# cat /proc/sys/dev/scsi/logging_level
-18446744071562067968
Cast to unsigned long before negation - that way we first sign-extend
and then negate an unsigned, which is well defined. With this:
# cat /proc/sys/dev/scsi/logging_level
-2147483648
Signed-off-by: Ilya D
On Sat, Jul 11, 2015 at 10:35 AM, Robert Xiao wrote:
> On LP64 systems, reading a sysctl file containing an INT_MIN (-2147483648)
> could incorrectly show -18446744071562067968 due to an incorrect conversion
> in do_proc_dointvec_conv. This patch fixes the edge case by converting to
> unsigned int
On Fri, Jun 26, 2015 at 4:17 AM, Stephen Rothwell wrote:
> Hi Al,
>
> Today's linux-next merge of the vfs tree got a conflict in:
>
> fs/ceph/dir.c
>
> between commit:
>
> fdd4e15838e5 ("ceph: rework dcache readdir")
>
> from the ceph tree and commit:
>
> dc3f4198eac1 ("make simple_positive(
On Wed, Jun 17, 2015 at 6:04 AM, juncheng bai
wrote:
> Hi.
> Yeah, you are right, use the default max_segments, the request size can
> be the object size, because the bi_phys_segments of bio could be recount,
> there's just a possibility.
>
> I want to fully understand the bi_phys_segments, hope y
On Tue, Jun 16, 2015 at 8:22 PM, nick wrote:
>
>
> On 2015-06-16 01:16 PM, Ilya Dryomov wrote:
>> On Tue, Jun 16, 2015 at 8:07 PM, nick wrote:
>>>
>>>
>>> On 2015-06-16 12:47 PM, Ilya Dryomov wrote:
>>>> On Tue, Jun 16, 2015 at 7:18 PM,
On Tue, Jun 16, 2015 at 8:07 PM, nick wrote:
>
>
> On 2015-06-16 12:47 PM, Ilya Dryomov wrote:
>> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote:
>>> Ilya,
>>> That's fine I do have a unrelated question through. I have over 90 patches
>>> lying aroun
On Tue, Jun 16, 2015 at 7:57 PM, nick wrote:
>
>
> On 2015-06-16 12:47 PM, Ilya Dryomov wrote:
>> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote:
>>> Ilya,
>>> That's fine I do have a unrelated question through. I have over 90 patches
>>> lying aroun
On Tue, Jun 16, 2015 at 7:18 PM, nick wrote:
> Ilya,
> That's fine I do have a unrelated question through. I have over 90 patches
> lying around in terms of cleanups/
> fixes and need help getting them merged. Should I just resend them or wait
> until the end of this merge window.
Are all of th
On Tue, Jun 9, 2015 at 11:00 AM, Ilya Dryomov wrote:
> On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote:
>> This makes the function, crush_ln static now due to having
>> only one caller in its own definition and declaration file
>> of mapper.c
>>
>&g
On Tue, Jun 16, 2015 at 5:14 PM, juncheng bai
wrote:
>
>
> On 2015/6/16 21:30, Ilya Dryomov wrote:
>>
>> On Tue, Jun 16, 2015 at 2:57 PM, juncheng bai
>> wrote:
>>>
>>>
>>>
>>> On 2015/6/16 16:37, Ilya Dryomov wrote:
>>&
On Tue, Jun 16, 2015 at 2:57 PM, juncheng bai
wrote:
>
>
> On 2015/6/16 16:37, Ilya Dryomov wrote:
>>
>> On Tue, Jun 16, 2015 at 6:28 AM, juncheng bai
>> wrote:
>>>
>>>
>>>
>>> On 2015/6/15 22:27, Ilya Dryomov wrote:
>>&
On Tue, Jun 16, 2015 at 6:28 AM, juncheng bai
wrote:
>
>
> On 2015/6/15 22:27, Ilya Dryomov wrote:
>>
>> On Mon, Jun 15, 2015 at 4:23 PM, juncheng bai
>> wrote:
>>>
>>>
>>>
>>> On 2015/6/15 21:03, Ilya Dryomov wrote:
>>&
On Mon, Jun 15, 2015 at 4:23 PM, juncheng bai
wrote:
>
>
> On 2015/6/15 21:03, Ilya Dryomov wrote:
>>
>> On Mon, Jun 15, 2015 at 2:18 PM, juncheng bai
>> wrote:
>>>
>>> From 6213215bd19926d1063d4e01a248107dab8a899b Mon Sep 17 00:00:00 2001
>>
On Mon, Jun 15, 2015 at 2:18 PM, juncheng bai
wrote:
> From 6213215bd19926d1063d4e01a248107dab8a899b Mon Sep 17 00:00:00 2001
> From: juncheng bai
> Date: Mon, 15 Jun 2015 18:34:00 +0800
> Subject: [PATCH] storage:rbd: make the size of request is equal to the
> size of the object
>
> ensures tha
On Sun, Jun 14, 2015 at 12:05 PM, Fabian Frederick wrote:
>
>
>> On 08 June 2015 at 09:49 Ilya Dryomov wrote:
>>
>>
>> On Fri, Jun 5, 2015 at 10:12 PM, Fabian Frederick wrote:
>> > ceph used -1 for the last match_table_t option.
>> > Use Opt_e
On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote:
> This makes the function, crush_ln static now due to having
> only one caller in its own definition and declaration file
> of mapper.c
>
> Signed-off-by: Nicholas Krause
> ---
> net/ceph/crush/mapper.c | 2 +-
> 1 file changed, 1 insertion(
On Fri, Jun 5, 2015 at 10:12 PM, Fabian Frederick wrote:
> ceph used -1 for the last match_table_t option.
> Use Opt_err enum like other FS
>
> match_token() is based on the pattern (NULL)
> so behavior should remain the same.
>
> Signed-off-by: Fabian Frederick
> ---
> This is untested. If this
On Mon, Jun 1, 2015 at 5:36 PM, Geliang Tang wrote:
> Use kvfree() instead of open-coding it.
>
> Signed-off-by: Geliang Tang
> ---
> net/ceph/pagevec.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c
> index 096d914..d4f5f22 1
On Mon, May 25, 2015 at 6:08 PM, Christoph Hellwig wrote:
> On Mon, May 25, 2015 at 06:02:30PM +0300, Ilya Dryomov wrote:
>> I'm not Alex, but yeah, we have all the clone/split machinery and so we
>> can handle a spanning case just fine. I think rbd_merge_bvec() exists
>
On Mon, May 25, 2015 at 5:04 PM, Christoph Hellwig wrote:
> On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote:
>> From: Kent Overstreet
>>
>> As generic_make_request() is now able to handle arbitrarily sized bios,
>> it's no longer necessary for each individual block driver to define its
>
On Tue, Apr 21, 2015 at 7:21 PM, Sage Weil wrote:
> On Tue, 21 Apr 2015, Guenter Roeck wrote:
>> On Tue, Apr 21, 2015 at 08:10:44AM -0700, Jim Davis wrote:
>> > Building with the attached random configuration file,
>> >
>> > ERROR: "__divdi3" [net/ceph/libceph.ko] undefined!
>>
>> Commit 7321f19d
On Mon, Mar 23, 2015 at 11:35 PM, Joe Perches wrote:
> To avoid possible interleaving, add missing '\n' to formats.
Applied.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordo
On Sat, Jan 3, 2015 at 8:02 PM, Fabian Frederick wrote:
> Fixes the following 32-bit compilation warning:
> fs/ceph/addr.c:1419:2: warning: format '%lu' expects argument of type
> 'long unsigned int', but argument 5 has type 'size_t' [-Wformat=]
>
> Signed-off-by: Fabian Frederick
> ---
> fs/cep
On Thu, Jan 1, 2015 at 7:58 PM, Rickard Strandqvist
wrote:
> Remove the function copy_token() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/block/rbd.c | 30
On Sat, Dec 20, 2014 at 3:34 PM, Rickard Strandqvist
wrote:
> Remove the function ceph_pool_op_name() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
It's part of pool op infrastructure and I'd rather we use it in
monc_show() tha
On Sun, Dec 21, 2014 at 1:36 AM, Rickard Strandqvist
wrote:
> Remove the function ceph_armor() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
It's ceph_unarmor()'s counterpart - so same as for "[PATCH] net: ceph:
crypto.c: Remov
On Sat, Dec 20, 2014 at 7:52 PM, Rickard Strandqvist
wrote:
> Removes some functions that are not used anywhere:
> ceph_encrypt() ceph_decrypt() ceph_crypto_key_encode()
>
> This was partially found by using a static code analysis program called
> cppcheck.
I'd like to keep this stuff even if it
On Sun, Dec 21, 2014 at 1:56 PM, Geert Uytterhoeven
wrote:
> On 32-bit, where size_t is unsigned int:
>
> fs/ceph/addr.c: In function ‘ceph_fill_inline_data’:
> fs/ceph/addr.c:1419: warning: format ‘%lu’ expects type ‘long unsigned int’,
> but argument 10 has type ‘size_t’
>
> Signed-off-by: Geer
On Mon, Dec 1, 2014 at 1:23 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Mon, 1 Dec 2014 11:18:21 +0100
>
> The ceph_put_snap_context() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detect
On Mon, Nov 3, 2014 at 4:27 PM, SF Markus Elfring
wrote:
>> dput() also checks for NULL argument, but the check is wrapped into
>> unlikely(), which is why I presume it wasn't picked up. It would be
>> great if you could improve your coccinelle script to handle
>> {un,}likely() as well.
>
> Thank
On Sun, Nov 2, 2014 at 5:20 PM, SF Markus Elfring
wrote:
> The functions ceph_put_snap_context() and iput() test whether their argument
> is NULL and then return immediately. Thus the test around the call
> is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off
On Sat, Oct 25, 2014 at 1:12 PM, Fabian Frederick wrote:
>
>
>> On 23 October 2014 at 18:25 Ilya Dryomov wrote:
>>
>>
>> On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick wrote:
>> > osdmap_epoch is redundant with reassert_epoch and unused.
&g
On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick wrote:
> osdmap_epoch is redundant with reassert_epoch and unused.
>
> Signed-off-by: Fabian Frederick
> ---
> net/ceph/osd_client.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index f
On Fri, Oct 10, 2014 at 4:41 AM, Dan Mick wrote:
>
>
> On 10/09/2014 02:16 PM, Fabian Frederick wrote:
>> Fix some coccinelle warnings:
>> fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1
>
>
>> - bool wake = 0;
>> + bool wake = false;
>
> FWIW, that message is backwards: it sh
On Fri, Oct 10, 2014 at 1:16 AM, Fabian Frederick wrote:
> Fix some coccinelle warnings:
> fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1
> fs/ceph/caps.c:2401:6-15: WARNING: Assignment of bool to 0/1
> fs/ceph/caps.c:2402:6-17: WARNING: Assignment of bool to 0/1
> fs/ceph/caps.c:240
On Wed, Oct 1, 2014 at 12:07 AM, Fabian Frederick wrote:
> ceph_release_page_vector was defined twice in libceph.h
>
> Signed-off-by: Fabian Frederick
> ---
> include/linux/ceph/libceph.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/li
On Wed, Sep 10, 2014 at 4:30 PM, Ilya Dryomov wrote:
> On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches wrote:
>> Use the more common pr_warn.
>>
>> Other miscellanea:
>>
>> o Coalesce formats
>> o Realign arguments
>>
>> Signed-off-by:
On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches wrote:
> Use the more common pr_warn.
>
> Other miscellanea:
>
> o Coalesce formats
> o Realign arguments
>
> Signed-off-by: Joe Perches
> ---
> net/ceph/ceph_common.c | 15 +--
> net/ceph/messenger.c | 19 ++-
> net/ceph
On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches wrote:
> Use the more common pr_warn.
>
> Other miscellanea:
>
> o Coalesce formats
> o Realign arguments
>
> Signed-off-by: Joe Perches
> ---
> net/ceph/ceph_common.c | 15 +--
> net/ceph/messenger.c | 19 ++-
> net/ceph
On Tue, Aug 5, 2014 at 5:06 PM, Peter Zijlstra wrote:
> On Tue, Aug 05, 2014 at 12:33:16PM +0400, Ilya Dryomov wrote:
>> On Mon, Aug 4, 2014 at 2:30 PM, Peter Zijlstra wrote:
>> > Hi,
>> >
>> > Ilya recently tripped over a nested sleep which made Ingo suggest
On Mon, Aug 4, 2014 at 2:30 PM, Peter Zijlstra wrote:
> Hi,
>
> Ilya recently tripped over a nested sleep which made Ingo suggest we should
> have debug checks for that. So I did some, see patch 7. Of course that
> triggered a whole bunch of fail the instant I tried to boot my machine.
>
> With th
On Fri, Aug 1, 2014 at 5:27 PM, Peter Zijlstra wrote:
> On Fri, Aug 01, 2014 at 04:56:27PM +0400, Ilya Dryomov wrote:
>> I'm going to fix up rbd_request_fn(), but I want to make sure
>> I understand this in full.
>>
>> - Previously the danger of calling b
On Thu, Jul 31, 2014 at 6:39 PM, Peter Zijlstra wrote:
> On Thu, Jul 31, 2014 at 04:30:52PM +0200, Mike Galbraith wrote:
>> On Thu, 2014-07-31 at 15:13 +0200, Peter Zijlstra wrote:
>>
>> > Smells like maybe current->state != TASK_RUNNING
>>
>> Bingo
>>
>> [ 1200.851004] kjournald D 0
On Thu, Jul 31, 2014 at 6:30 PM, Mike Galbraith
wrote:
> On Thu, 2014-07-31 at 15:13 +0200, Peter Zijlstra wrote:
>
>> Smells like maybe current->state != TASK_RUNNING
It just triggered for me too, took longer than usual. Sorry for the
churn Peter, this was really confusing. Onto finding the re
On Thu, Jul 31, 2014 at 5:13 PM, Peter Zijlstra wrote:
> On Thu, Jul 31, 2014 at 04:37:29PM +0400, Ilya Dryomov wrote:
>
>> This didn't make sense to me at first too, and I'll be happy to be
>> proven wrong, but we can reproduce this with rbd very reliably under
>&g
On Thu, Jul 31, 2014 at 3:57 PM, Peter Zijlstra wrote:
> On Thu, Jul 31, 2014 at 02:16:37PM +0400, Ilya Dryomov wrote:
>> This reverts commit 34c6bc2c919a55e5ad4e698510a2f35ee13ab900.
>>
>> This commit can lead to deadlocks by way of what at a high level
>> appears to
TEX_SPIN_ON_OWNER and made everything disappear,
which is why it hasn't been looked into until now. Revert makes the
problem go away, confirmed by our users.
Cc: Peter Zijlstra
Cc: sta...@vger.kernel.org # 3.15
Signed-off-by: Ilya Dryomov
---
kernel/locking/mutex.c |7 ---
1 fil
On Thu, Jul 24, 2014 at 10:20 PM, Toralf Förster wrote:
> Inspired by this "typo" fix
> http://article.gmane.org/gmane.linux.kernel/1754640
> I grep'ed the current git tree of linus for similar issues.
>
> For these 4 places I'm wondering where the appropriate struct definition is
> located :
>
>
On Thu, Jul 24, 2014 at 1:47 AM, Himangi Saraogi wrote:
> Free memory allocated using kmem_cache_zalloc using kmem_cache_free
> rather than kfree. The helper rbd_segment_name_free does the job here.
> Its position is shifted above the calling function.
>
> The Coccinelle semantic patch that detect
On Wed, Jul 23, 2014 at 6:41 PM, Himangi Saraogi wrote:
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
>
> A simplified version of the Coccinelle semantic patch that perfo
On Tue, Jul 22, 2014 at 10:11 PM, Himangi Saraogi wrote:
> Free memory allocated using kmem_cache_zalloc using kmem_cache_free
> rather than kfree.
>
> The Coccinelle semantic patch that makes this change is as follows:
>
> //
> @@
> expression x,E,c;
> @@
>
> x = \(kmem_cache_alloc\|kmem_cache_
> Dne 18.6.2014 09:52, Ilya Dryomov napsal(a):
>> On Tue, Jun 17, 2014 at 6:47 AM, Alexei Starovoitov
>> wrote:
>>> On Mon, Jun 16, 2014 at 7:18 AM, Michal Marek wrote:
>>>> When $srctree or $objtree are relative paths, we cannot change directory
>>>
subshell to fix this.
>>
>> Reported-by: Ilya Dryomov
>> Signed-off-by: Michal Marek
>> ---
>> scripts/package/builddeb | 10 +-
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> this patch didn't help to fix the broken deb-pkg for me:
Alexe
Hi Michal,
Your relative path changes in the first kbuild pull request for 3.16
broke make O=... deb-pkg.
/home/ubuntu/foo/linux-a/scripts/package/builddeb: line 291:
./debian/hdrsrcfiles: No such file or directory
290 # Build header package
291 (cd $srctree; find . -name Makefile\* -o -name Kc
On Wed, May 7, 2014 at 8:16 AM, tuxoko wrote:
>
>
> On 西元2014年05月07日 00:34, Ilya Dryomov wrote:
>> On Tue, May 6, 2014 at 8:31 PM, Sage Weil wrote:
>>> On Tue, 6 May 2014, Ilya Dryomov wrote:
>>>>
>>>> Looks good to me. Have you tested it with pre
On Tue, May 6, 2014 at 8:31 PM, Sage Weil wrote:
> On Tue, 6 May 2014, Ilya Dryomov wrote:
>> On Wed, Apr 23, 2014 at 8:35 AM, Chunwei Chen wrote:
>> > It has been reported that using ZFSonLinux on rbd will result in memory
>> > corruption. The bug report can be
201 - 300 of 307 matches
Mail list logo
