Re: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc

2013-11-11 Thread Ionut Nicu
Hi, On 08.11.2013 16:06, ext Pantelis Antoniou wrote: > Add a runtime interface to /proc to enable generic device tree overlay > usage. > > + > + /* start at 256K at first */ > + if (od->alloc == 0) > + od->alloc = SZ_256K / 2; > + Same problem as Gue

Re: [PATCH 2/3] OF: Introduce DT overlay support.

2013-11-06 Thread Ionut Nicu
al I2C is just no good platform device citizen and needs >> special casing. >> >> Signed-off-by: Pantelis Antoniou > > Reviewed-by: Alexander Sverdlin > I'm using this patch for a few months without any problems, so: Tested-by: Ionut Nicu >> --- >

Re: [PATCH 1/3] OF: Introduce Device Tree resolve support.

2013-11-06 Thread Ionut Nicu
ified and inserted at the kernel >> live tree. >> >> Signed-off-by: Pantelis Antoniou > > Reviewed-by: Alexander Sverdlin > I'm using this patch for a few months without any problems, so: Tested-by: Ionut Nicu >> --- >> .../de

Re: [PATCH 3/3] DT: proc: Add runtime overlay interface in /proc

2013-11-06 Thread Ionut Nicu
Hi, On 05.11.2013 19:41, ext Pantelis Antoniou wrote: > Add a runtime interface to /proc to enable generic device tree overlay > usage. > > Two new /proc files are added: > > /proc/device-tree-overlay & /proc/device-tree-overlay-status > > /proc/device-tree-overlay accepts a stream of a device

Re: [PATCH 5/5] OF: Introduce utility helper functions

2013-11-06 Thread Ionut Nicu
Hi, First of all, good to see this patch set being submitted again! We're using an older version of your patch set for some time and they're working good for us. On 05.11.2013 18:50, ext Pantelis Antoniou wrote: > Introduce helper functions for working with the live DT tree. > > __of_free_prope

[PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()

2013-10-11 Thread Ionut Nicu
Some gpio chips may have get/set operations that can sleep. gpio_set_value() only works for chips which do not sleep, for the others we will get a kernel warning. Using gpio_set_value_cansleep() will work for both chips that do sleep and those who don't. Signed-off-by: Ionut Nicu --- dr

[PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()

2013-10-11 Thread Ionut Nicu
Some gpio chips may have get/set operations that can sleep. gpio_set_value() only works for chips which do not sleep, for the others we will get a kernel warning. Using gpio_set_value_cansleep() will work for both chips that do sleep and those who don't. Signed-off-by: Ionut Nicu --- dr

[PATCH 2/2] i2c-mux-gpio: use reg value for i2c_add_mux_adapter

2013-10-11 Thread Ionut Nicu
() callback with chan_id set to 0, the i2c-mux-gpio will use it as an index into mux->data.values and it will actually select the bus with reg = <1>. Signed-off-by: Ionut Nicu --- drivers/i2c/muxes/i2c-mux-gpio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 2/2] i2c-mux-gpio: eliminate i2c channel order assumptions

2013-10-11 Thread Ionut Nicu
Hi, On 10.10.2013 12:34, Alexander Sverdlin wrote: > Hi! > > On 10/10/2013 10:39 AM, Ionut Nicu wrote: >> The i2c-mux driver uses the chan_id parameter provided >> in i2c_add_mux_adapter as a parameter to the select >> and deselect callbacks while the i2c-mux-gpio dr

Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep

2013-10-10 Thread Ionut Nicu
On 10.10.2013 10:46, ext Lars-Peter Clausen wrote: > On 10/10/2013 10:39 AM, Ionut Nicu wrote: >> Some gpio chips may have get/set operations that >> can sleep. For this type of chips we must use the >> _cansleep() version of gpio_set_value. >> >> Signed-off-by: I

[PATCH 2/2] i2c-mux-gpio: eliminate i2c channel order assumptions

2013-10-10 Thread Ionut Nicu
the i2c-mux-gpio driver will actually use values[0], hence 1 as the gpio selection value. Signed-off-by: Ionut Nicu --- drivers/i2c/muxes/i2c-mux-gpio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c

[PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep

2013-10-10 Thread Ionut Nicu
Some gpio chips may have get/set operations that can sleep. For this type of chips we must use the _cansleep() version of gpio_set_value. Signed-off-by: Ionut Nicu --- drivers/i2c/muxes/i2c-mux-gpio.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/i2c

[PATCH 1/2] i2c-mux-gpio: use deferred probing

2013-10-09 Thread Ionut Nicu
If the i2c-parent bus driver is not loaded, returning -ENODEV will force people to unload and then reload the module again to get it working. Signed-off-by: Ionut Nicu --- drivers/i2c/muxes/i2c-mux-gpio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c

Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree

2013-10-09 Thread Ionut Nicu
On 09.10.2013 08:14, ext Peter Korsgaard wrote: >>>>>> "WS" == Wolfram Sang writes: > > WS> On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote: >>> If the i2c-parent bus driver is not loaded, returning >>> -EINVAL will force people t

[PATCH 2/2] i2c-mux-gpio: don't ignore of_get_named_gpio errors

2013-10-08 Thread Ionut Nicu
of_get_named_gpio could return -E_PROBE_DEFER or another error code. This error should be passed further instead of being ignored. Signed-off-by: Ionut Nicu --- drivers/i2c/muxes/i2c-mux-gpio.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/muxes

[PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree

2013-10-08 Thread Ionut Nicu
If the i2c-parent bus driver is not loaded, returning -EINVAL will force people to unload and then reload the module again to get it working. Signed-off-by: Ionut Nicu --- drivers/i2c/muxes/i2c-mux-gpio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c

Re: [PATCH] i2c-mux-gpio: use deferred probing with the device tree

2013-10-08 Thread Ionut Nicu
On 08.10.2013 15:30, ext Peter Korsgaard wrote: >>>>>> "IN" == Ionut Nicu writes: > > IN> If the i2c-parent bus driver is not loaded, returning > IN> -EINVAL will force people to unload and then reload the > IN> module again to get it work

[PATCH] i2c-mux-gpio: use deferred probing with the device tree

2013-10-08 Thread Ionut Nicu
: Ionut Nicu --- drivers/i2c/muxes/i2c-mux-gpio.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index 5d4a99b..6370b47 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-13 Thread Ionut Nicu
Hi Mark, On 09.08.2013 19:16, Ionut Nicu wrote: > On 09.08.2013 13:44, ext Mark Brown wrote: >> On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: >>> As opposed to the other regmap cache implementations, >>> regcache_flat didn't use the cache_present bit

Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Ionut Nicu
On 09.08.2013 13:44, ext Mark Brown wrote: > On Fri, Aug 09, 2013 at 12:09:11PM +0200, Ionut Nicu wrote: >> As opposed to the other regmap cache implementations, >> regcache_flat didn't use the cache_present bitmap for >> figuring out whether a register was cached or

[PATCH 2/3] regmap: fix regcache_reg_present() for empty cache

2013-08-09 Thread Ionut Nicu
In the initial case when no reg_defaults values are provided and no register value was added to the cache yet, the cache_present bitmap is NULL. If this function is invoked for any register it should return false (i.e. the register is not cached) instead of true. Signed-off-by: Ionut Nicu

[PATCH 3/3] regmap: regcache: allow read-only regs to be cached

2013-08-09 Thread Ionut Nicu
the cache. Instead the regmap_writeable() check should be done in _regmap_write() to prevent callers from writing to read-only registers. Signed-off-by: Ionut Nicu --- drivers/base/regmap/regcache.c |3 --- drivers/base/regmap/regmap.c |3 +++ 2 files changed, 3 insertions(+), 3

[PATCH 1/3] regmap: flat: use the cache_present bitmap

2013-08-09 Thread Ionut Nicu
ch as returning value 0 for non-volatile registers without first reading their value from the device and storing it in the cache. Signed-off-by: Ionut Nicu --- drivers/base/regmap/regcache-flat.c | 25 ++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers