Re: [PATCH v2] exec: don't force_sigsegv processes with a pending fatal signal

On Sun, Feb 10, 2019 at 11:05:52AM -0600, Eric W. Biederman wrote: > Ivan Delalande writes: > > A difference I've noticed with your tree (unrelated to my issue here but > > that you may want to look at) is when I run my reproducer under > > strace -f, I'm now

Re: [PATCH v2] exec: don't force_sigsegv processes with a pending fatal signal

On Mon, Feb 11, 2019 at 06:12:53PM +0100, Oleg Nesterov wrote: > sorry, I couldn't look at this patch before. > > On 02/04, Ivan Delalande wrote: > > > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -1660,7 +1660,12 @@ int search_binary_handler(struct linux_bi

Re: [PATCH v2] exec: don't force_sigsegv processes with a pending fatal signal

t; + if (signal_group_exit(signal)) > + goto fatal; > + > for (;;) { > struct k_sigaction *ka; > > @@ -2488,6 +2493,7 @@ bool get_signal(struct ksignal *ksig) > continue; > } > > + fatal: > spin_unlock_irq(&sighand->siglock); > > -- Ivan Delalande Arista Networks

Re: [PATCH v2] exec: don't force_sigsegv processes with a pending fatal signal

On Tue, Feb 05, 2019 at 01:11:19PM -0800, Andrew Morton wrote: > On Mon, 4 Feb 2019 18:53:08 -0800 Ivan Delalande wrote: > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -1660,7 +1660,12 @@ int search_binary_handler(struct linux_binprm *bprm) > >

[PATCH v2] exec: don't force_sigsegv processes with a pending fatal signal

handle suicide on late failure exits in execve() in search_binary_handler()") Reference: https://lkml.org/lkml/2013/2/14/5 Signed-off-by: Ivan Delalande --- fs/exec.c | 7 ++- kernel/signal.c | 6 +++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/fs/exec.c b/fs/exe

[PATCH v2] proc/sysctl: don't return ENOMEM on lookup when a table is unregistering

g Signed-off-by: Ivan Delalande --- fs/proc/proc_sysctl.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 89921a0d2ebb..e9d4fc40d832 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -464,7 +464,7 @

[PATCH] proc/sysctl: don't return ENOMEM on lookup when a table is unregistering

reproduced and this fix tested on v4.9.122 and v4.20-rc6. Fixes: ace0c791e6c3 ("proc/sysctl: Don't grab i_lock under sysctl_lock.") Cc: sta...@vger.kernel.org Signed-off-by: Ivan Delalande --- fs/proc/proc_sysctl.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

Re: [PATCH RESEND] exec: don't force_sigsegv processes with a pending fatal signal

Hi, On Fri, Aug 03, 2018 at 03:39:24PM +0200, Oleg Nesterov wrote: > On 08/02, Dmitry Safonov wrote: > > 2018-07-31 1:56 GMT+01:00 Ivan Delalande : > > > We were seeing unexplained segfaults in coreutils processes and other > > > basic utilities that we tracked down to

[PATCH RESEND] exec: don't force_sigsegv processes with a pending fatal signal

andle suicide on late failure exits in execve() in search_binary_handler()") Reference: https://lkml.org/lkml/2013/2/14/5 Signed-off-by: Ivan Delalande --- fs/exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/exec.c b/fs/exec.c index bdd0eacefdf5..6e8007edbb2d 10064

[PATCH] exec: don't force_sigsegv processes with a pending fatal signal

andle suicide on late failure exits in execve() in search_binary_handler()") Reference: https://lkml.org/lkml/2013/2/14/5 Signed-off-by: Ivan Delalande --- fs/exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/exec.c b/fs/exec.c index 2d4e0075bd24..620d6489b61c 10064

[PATCH] lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN

Function handle_IRQ_event was retired in v2.6.39 and replaced with handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has been broken for a while. Fixes: 33b054b867b8 ("genirq: Remove handle_IRQ_event") Signed-off-by: Travis Brown Signed-off-by: Ivan Delalande --- dr

[PATCH 1/2] tcp: add mode parameter to tcp_proc_register

This will be used to create a proc file that regular users cannot read. Signed-off-by: Ivan Delalande --- include/net/tcp.h | 3 ++- net/ipv4/tcp_ipv4.c | 7 --- net/ipv6/tcp_ipv6.c | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/net/tcp.h b/include/net

[PATCH 2/2] tcp: md5: export all configured signature keys in /proc/net

ts inode number, the address, prefix length and the key itself. Note that IPv4-mapped IPv6 addresses will be printed as a regular IPv4 address in the tcp6md5 file. Signed-off-by: Ani Sinha Signed-off-by: Ken Kofman Signed-off-by: Ivan Delalande --- Documentation/filesystems/proc.txt | 2 +

[PATCH v3 1/2] tcp: md5: add an address prefix for key lookup

This allows the keys used for TCP MD5 signature to be used for whole range of addresses, specified with a prefix length, instead of only one address as it currently is. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h | 6 +++-- net

[PATCH v3 2/2] tcp: md5: add TCP_MD5SIG_EXT socket option to set a key address prefix

tcpm_prefixlen only when the TCP_MD5SIG_FLAG_PREFIX flag is set. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h| 1 + include/uapi/linux/tcp.h | 9 +++-- net/ipv4/tcp.c | 3 ++- net/ipv4/tcp_ipv4.c | 16

Re: [PATCH v2 2/2] tcp: md5: extend the tcp_md5sig struct to specify a key address prefix

On Sat, Jun 10, 2017 at 06:58:11PM -0400, David Miller wrote: > From: Ivan Delalande > Date: Fri, 9 Jun 2017 19:14:49 -0700 > > > Add a flag field and address prefix length at the end of the tcp_md5sig > > structure so users can configure an address prefix length along with

[PATCH v2 2/2] tcp: md5: extend the tcp_md5sig struct to specify a key address prefix

-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/uapi/linux/tcp.h | 8 net/ipv4/tcp_ipv4.c | 15 +++ net/ipv6/tcp_ipv6.c | 24 +--- 3 files changed, 36 insertions(+), 11 deletions(-) diff --git a/include

[PATCH v2 1/2] tcp: md5: add an address prefix for key lookup

This allows the keys used for TCP MD5 signature to be used for whole range of addresses, specified with a prefix length, instead of only one address as it currently is. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h | 6 +++-- net

Re: [PATCH 2/2] tcp: md5: add fields to the tcp_md5sig struct to set a key address prefix

On Tue, Jun 06, 2017 at 09:08:22PM -0700, Eric Dumazet wrote: > On Tue, 2017-06-06 at 17:54 -0700, Ivan Delalande wrote: >> diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h >> index 38a2b07afdff..52ac30aa0652 100644 >> --- a/include/uapi/linux/tcp.h >&g

[PATCH 2/2] tcp: md5: add fields to the tcp_md5sig struct to set a key address prefix

Replace padding in the socket option structure tcp_md5sig with a new flag field and address prefix length so it can be specified when configuring a new key with the TCP_MD5SIG socket option. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/uapi

[PATCH 1/2] tcp: md5: add an address prefix for key lookup

This allows the keys used for TCP MD5 signature to be used for whole range of addresses, specified with a prefix length, instead of only one address as it currently is. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande --- include/net/tcp.h | 6 +++-- net

Re: kernel/printk/printk.c: Invalid access when buffer wraps around?

Hi, On Mon, Jul 25, 2016 at 11:22:24AM +0200, Vincent Brillault wrote: > While working on a kernel module that basically forks > kernel/printk/printk.c to create its own buffer, I believe I have found > a bug in how printk wraps around its buffer: In a very specific case, a > reader, trying to rea

[PATCH] printk: add clear_idx symbol to vmcoreinfo

-by: Ivan Delalande --- kernel/printk/printk.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index c963ba5..8a79917 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -367,16 +367,20 @@ static