Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Fri, Feb 23, 2018 at 12:41:05PM +, James Ettle wrote: > I'm OK with that. (This is the first time I've ventured into kernel space so > I thought it better to at least sketch a solution and let the experts do it > correctly ;) Glad it's passed the review!) OK, thanks!--b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Fri, Feb 23, 2018 at 12:41:05PM +, James Ettle wrote: > I'm OK with that. (This is the first time I've ventured into kernel space so > I thought it better to at least sketch a solution and let the experts do it > correctly ;) Glad it's passed the review!) OK, thanks!--b.

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote: > I only really posted this as a demo of a fix. I was hoping someone who > actually knows what they're doing in the kernel would pick it up and make it > proper. Whoops, sorry, I didn't realize that. But I don't see a problem with

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote: > I only really posted this as a demo of a fix. I was hoping someone who > actually knows what they're doing in the kernel would pick it up and make it > proper. Whoops, sorry, I didn't realize that. But I don't see a problem with

Re: [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static

Thanks, applying.--b. On Wed, Feb 07, 2018 at 10:29:47AM +, Colin King wrote: > From: Colin Ian King > > The variables nlm_ntf_refcnt and nlm_ntf_wq are local to the source and > do not need to be in global scope, so make them static. > > Cleans up sparse

Re: [PATCH] lockd: make nlm_ntf_refcnt and nlm_ntf_wq static

Thanks, applying.--b. On Wed, Feb 07, 2018 at 10:29:47AM +, Colin King wrote: > From: Colin Ian King > > The variables nlm_ntf_refcnt and nlm_ntf_wq are local to the source and > do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > fs/lockd/svc.c:60:10:

[GIT PULL] please pull nfsd changes for 4.16

lockd: convert nlm_rqst.a_count from atomic_t to refcount_t J. Bruce Fields (2): nfsd4: don't set lock stateid's sc_type to CLOSED nfsd: return RESOURCE not GARBAGE_ARGS on too many ops Trond Myklebust (1): nfsd: Detect unhashed stids in nfsd4_verify_open_stid() fs/lockd/clnt

[GIT PULL] please pull nfsd changes for 4.16

lockd: convert nlm_rqst.a_count from atomic_t to refcount_t J. Bruce Fields (2): nfsd4: don't set lock stateid's sc_type to CLOSED nfsd: return RESOURCE not GARBAGE_ARGS on too many ops Trond Myklebust (1): nfsd: Detect unhashed stids in nfsd4_verify_open_stid() fs/lockd/clnt

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Tue, Jan 23, 2018 at 07:47:31PM -0500, Trond Myklebust wrote: > Sorry I forgot about the issues with the server garbage collector, and > I applied these patches to my linux-next a couple of weeks ago. Whoops, OK, so who's taking those patches anyway? > What say we fix the issue with something

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Tue, Jan 23, 2018 at 07:47:31PM -0500, Trond Myklebust wrote: > Sorry I forgot about the issues with the server garbage collector, and > I applied these patches to my linux-next a couple of weeks ago. Whoops, OK, so who's taking those patches anyway? > What say we fix the issue with something

Re: [PATCH AUTOSEL for 4.4 19/35] nfsd: Ensure we don't recognise lock stateids after freeing them

e "existing lock" > path, and also by a second call to nfsd4_free_lock_stateid() itself, we can > change the type to NFS4_CLOSED_STID under the stp->st_mutex. > > Signed-off-by: Trond Myklebust <trond.mykleb...@primarydata.com> > Signed-off-by: J. Bruce Fields

Re: [PATCH AUTOSEL for 4.4 19/35] nfsd: Ensure we don't recognise lock stateids after freeing them

and also by a second call to nfsd4_free_lock_stateid() itself, we can > change the type to NFS4_CLOSED_STID under the stp->st_mutex. > > Signed-off-by: Trond Myklebust > Signed-off-by: J. Bruce Fields > Signed-off-by: Sasha Levin > --- > fs/nfsd/nfs4state.c | 19 --

Re: [PATCH AUTOSEL for 4.9 26/55] nfsd: Ensure we don't recognise lock stateids after freeing them

> > To ensure the stateid invalidation is also recognised by the "existing lock" > path, and also by a second call to nfsd4_free_lock_stateid() itself, we can > change the type to NFS4_CLOSED_STID under the stp->st_mutex. > > Signed-off-by: Trond Myklebust &

Re: [PATCH AUTOSEL for 4.9 26/55] nfsd: Ensure we don't recognise lock stateids after freeing them

stateid invalidation is also recognised by the "existing lock" > path, and also by a second call to nfsd4_free_lock_stateid() itself, we can > change the type to NFS4_CLOSED_STID under the stp->st_mutex. > > Signed-off-by: Trond Myklebust > Signed-off-by: J. Bruce Fie

Re: [PATCH AUTOSEL for 4.14 057/100] nfsd: Ensure we don't recognise lock stateids after freeing them

k" path. > > To ensure the stateid invalidation is also recognised by the "existing lock" > path, and also by a second call to nfsd4_free_lock_stateid() itself, we can > change the type to NFS4_CLOSED_STID under the stp->st_mutex. > > Signed-off-by: Trond Mykle

Re: [PATCH AUTOSEL for 4.14 057/100] nfsd: Ensure we don't recognise lock stateids after freeing them

stateid invalidation is also recognised by the "existing lock" > path, and also by a second call to nfsd4_free_lock_stateid() itself, we can > change the type to NFS4_CLOSED_STID under the stp->st_mutex. > > Signed-off-by: Trond Myklebust > Signed-off-by: J. Bruce Fie

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Wed, Dec 27, 2017 at 12:10:15PM +, Reshetova, Elena wrote: > > On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > > > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > > > > > On Wed, Nov 29, 2017 at

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Wed, Dec 27, 2017 at 12:10:15PM +, Reshetova, Elena wrote: > > On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > > > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > > > > > On Wed, Nov 29, 2017 at

Re: [PATCH] [v2] NFSD: hide unused svcxdr_dupstr()

Thanks, applied.--b. On Mon, Jan 22, 2018 at 10:09:12PM +0100, Arnd Bergmann wrote: > There is now only one caller left for svcxdr_dupstr() and this is inside > of an #ifdef, so we can get a warning when the option is disabled: > > fs/nfsd/nfs4xdr.c:241:1: error: 'svcxdr_dupstr' defined but not

Re: [PATCH] [v2] NFSD: hide unused svcxdr_dupstr()

Thanks, applied.--b. On Mon, Jan 22, 2018 at 10:09:12PM +0100, Arnd Bergmann wrote: > There is now only one caller left for svcxdr_dupstr() and this is inside > of an #ifdef, so we can get a warning when the option is disabled: > > fs/nfsd/nfs4xdr.c:241:1: error: 'svcxdr_dupstr' defined but not

Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

On Fri, Jan 19, 2018 at 10:58:27PM +0100, Rasmus Villemoes wrote: > On 2018-01-19 15:54, Arnd Bergmann wrote: > > There is now only one caller left for svcxdr_dupstr() and this is inside > > of an #ifdef, so we can get a warning when the option is disabled: > > > > fs/nfsd/nfs4xdr.c:241:1: error:

Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

On Fri, Jan 19, 2018 at 10:58:27PM +0100, Rasmus Villemoes wrote: > On 2018-01-19 15:54, Arnd Bergmann wrote: > > There is now only one caller left for svcxdr_dupstr() and this is inside > > of an #ifdef, so we can get a warning when the option is disabled: > > > > fs/nfsd/nfs4xdr.c:241:1: error:

Re: [PATCH v5 02/19] fs: don't take the i_lock in inode_inc_iversion

On Fri, Jan 19, 2018 at 09:36:34AM -0500, Jeff Layton wrote: > Shrug...we have that problem with the spinlock in place too. The bottom > line is that reads of this value are not serialized with the increment > at all. OK, so this wouldn't even be a new bug. > I'm not 100% thrilled with this

Re: [PATCH v5 02/19] fs: don't take the i_lock in inode_inc_iversion

On Fri, Jan 19, 2018 at 09:36:34AM -0500, Jeff Layton wrote: > Shrug...we have that problem with the spinlock in place too. The bottom > line is that reads of this value are not serialized with the increment > at all. OK, so this wouldn't even be a new bug. > I'm not 100% thrilled with this

Re: [PATCH v5 02/19] fs: don't take the i_lock in inode_inc_iversion

On Tue, Jan 09, 2018 at 09:10:42AM -0500, Jeff Layton wrote: > From: Jeff Layton > > The rationale for taking the i_lock when incrementing this value is > lost in antiquity. The readers of the field don't take it (at least > not universally), so my assumption is that it was

Re: [PATCH v5 02/19] fs: don't take the i_lock in inode_inc_iversion

On Tue, Jan 09, 2018 at 09:10:42AM -0500, Jeff Layton wrote: > From: Jeff Layton > > The rationale for taking the i_lock when incrementing this value is > lost in antiquity. The readers of the field don't take it (at least > not universally), so my assumption is that it was only done here to >

Re: [PATCH v5 01/19] fs: new API for handling inode->i_version

On Tue, Jan 09, 2018 at 09:10:41AM -0500, Jeff Layton wrote: > --- /dev/null > +++ b/include/linux/iversion.h > @@ -0,0 +1,236 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_IVERSION_H > +#define _LINUX_IVERSION_H > + > +#include > + > +/* > + * The change attribute (i_version) is

Re: [PATCH v5 01/19] fs: new API for handling inode->i_version

On Tue, Jan 09, 2018 at 09:10:41AM -0500, Jeff Layton wrote: > --- /dev/null > +++ b/include/linux/iversion.h > @@ -0,0 +1,236 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_IVERSION_H > +#define _LINUX_IVERSION_H > + > +#include > + > +/* > + * The change attribute (i_version) is

Re: [PATCH 1/2] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n

Looks right to me. Reviewed-by: J. Bruce Fields <bfie...@redhat.com> --b. On Mon, Jan 15, 2018 at 06:30:46PM +0100, Max Kellermann wrote: > Make IS_POSIXACL() return false if POSIX ACL support is disabled and > ignore SB_POSIXACL/MS_POSIXACL. > > Never skip applying th

Re: [PATCH 1/2] linux/fs.h: fix umask on NFS with CONFIG_FS_POSIX_ACL=n

Looks right to me. Reviewed-by: J. Bruce Fields --b. On Mon, Jan 15, 2018 at 06:30:46PM +0100, Max Kellermann wrote: > Make IS_POSIXACL() return false if POSIX ACL support is disabled and > ignore SB_POSIXACL/MS_POSIXACL. > > Never skip applying the umask in namei.c and never both

Re: About the try to remove cross-release feature entirely by Ingo

On Fri, Jan 05, 2018 at 11:49:41AM -0500, bfields wrote: > On Mon, Jan 01, 2018 at 02:18:55AM -0800, Matthew Wilcox wrote: > > On Sat, Dec 30, 2017 at 06:00:57PM -0500, Theodore Ts'o wrote: > > > On Sat, Dec 30, 2017 at 05:40:28PM -0500, Theodore Ts'o wrote: > > > > On Sat, Dec 30, 2017 at

Re: About the try to remove cross-release feature entirely by Ingo

On Fri, Jan 05, 2018 at 11:49:41AM -0500, bfields wrote: > On Mon, Jan 01, 2018 at 02:18:55AM -0800, Matthew Wilcox wrote: > > On Sat, Dec 30, 2017 at 06:00:57PM -0500, Theodore Ts'o wrote: > > > On Sat, Dec 30, 2017 at 05:40:28PM -0500, Theodore Ts'o wrote: > > > > On Sat, Dec 30, 2017 at

Re: About the try to remove cross-release feature entirely by Ingo

On Mon, Jan 01, 2018 at 02:18:55AM -0800, Matthew Wilcox wrote: > On Sat, Dec 30, 2017 at 06:00:57PM -0500, Theodore Ts'o wrote: > > On Sat, Dec 30, 2017 at 05:40:28PM -0500, Theodore Ts'o wrote: > > > On Sat, Dec 30, 2017 at 12:44:17PM -0800, Matthew Wilcox wrote: > > > > > > > > I'm not sure I

Re: About the try to remove cross-release feature entirely by Ingo

On Mon, Jan 01, 2018 at 02:18:55AM -0800, Matthew Wilcox wrote: > On Sat, Dec 30, 2017 at 06:00:57PM -0500, Theodore Ts'o wrote: > > On Sat, Dec 30, 2017 at 05:40:28PM -0500, Theodore Ts'o wrote: > > > On Sat, Dec 30, 2017 at 12:44:17PM -0800, Matthew Wilcox wrote: > > > > > > > > I'm not sure I

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > atomic_t variables are currently used to implement

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Fri, Dec 22, 2017 at 09:25:53AM -0500, J. Bruce Fields wrote: > On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > > atomic_t variables are currently used to implement

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > atomic_t variables are currently used to implement reference > > counters with the following properties: > > - counter is initialized to 1 using atomic_set()

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote: > > On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > > atomic_t variables are currently used to implement reference > > counters with the following properties: > > - counter is initialized to 1 using atomic_set()

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter

Re: [PATCH 1/4] lockd: convert nlm_host.h_count from atomic_t to refcount_t

On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: > On Mon, Dec 04 2017, Thiago Rafael Becker wrote: > > > On Mon, 4 Dec 2017, NeilBrown wrote: > > > >> I think you need to add groups_sort() in a few more places. > >> Almost anywhere that calls groups_alloc() should be considered. > >>

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote: > On Mon, Dec 04 2017, Thiago Rafael Becker wrote: > > > On Mon, 4 Dec 2017, NeilBrown wrote: > > > >> I think you need to add groups_sort() in a few more places. > >> Almost anywhere that calls groups_alloc() should be considered. > >>

Re: [PATCH v3 19/19] fs: handle inode->i_version more efficiently

On Mon, Dec 18, 2017 at 12:22:20PM -0500, Jeff Layton wrote: > On Mon, 2017-12-18 at 17:34 +0100, Jan Kara wrote: > > On Mon 18-12-17 10:11:56, Jeff Layton wrote: > > > static inline bool > > > inode_maybe_inc_iversion(struct inode *inode, bool force) > > > { > > > - atomic64_t *ivp =

Re: [PATCH v3 19/19] fs: handle inode->i_version more efficiently

On Mon, Dec 18, 2017 at 12:22:20PM -0500, Jeff Layton wrote: > On Mon, 2017-12-18 at 17:34 +0100, Jan Kara wrote: > > On Mon 18-12-17 10:11:56, Jeff Layton wrote: > > > static inline bool > > > inode_maybe_inc_iversion(struct inode *inode, bool force) > > > { > > > - atomic64_t *ivp =

Re: NFS: 82ms wakeup latency 4.14-rc4

On Mon, Dec 18, 2017 at 06:17:36PM +0100, Mike Galbraith wrote: > On Mon, 2017-12-18 at 18:00 +0100, Mike Galbraith wrote: > > On Mon, 2017-12-18 at 11:35 -0500, J. Bruce Fields wrote: > > > > > > Like I say, I don't really understand the issues here, so it's

Re: NFS: 82ms wakeup latency 4.14-rc4

On Mon, Dec 18, 2017 at 06:17:36PM +0100, Mike Galbraith wrote: > On Mon, 2017-12-18 at 18:00 +0100, Mike Galbraith wrote: > > On Mon, 2017-12-18 at 11:35 -0500, J. Bruce Fields wrote: > > > > > > Like I say, I don't really understand the issues here, so it's

Re: NFS: 82ms wakeup latency 4.14-rc4

On Mon, Dec 18, 2017 at 04:31:52PM +0100, Mike Galbraith wrote: > On Mon, 2017-12-18 at 16:17 +0100, Mike Galbraith wrote: > > > > > > kworker/-74210.N.. 82893us : nfs_release_request > > <-nfs_commit_release_pages > > kworker/-74210.N.. 82893us : nfs_unlock_and_release_request > >

Re: NFS: 82ms wakeup latency 4.14-rc4

On Mon, Dec 18, 2017 at 04:31:52PM +0100, Mike Galbraith wrote: > On Mon, 2017-12-18 at 16:17 +0100, Mike Galbraith wrote: > > > > > > kworker/-74210.N.. 82893us : nfs_release_request > > <-nfs_commit_release_pages > > kworker/-74210.N.. 82893us : nfs_unlock_and_release_request > >

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

On Fri, Dec 15, 2017 at 10:15:29AM -0500, Jeff Layton wrote: > On Thu, 2017-12-14 at 10:14 -0500, J. Bruce Fields wrote: > > On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > > > There is some clear peformance impact when you are running frequent > > &g

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

On Fri, Dec 15, 2017 at 10:15:29AM -0500, Jeff Layton wrote: > On Thu, 2017-12-14 at 10:14 -0500, J. Bruce Fields wrote: > > On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > > > There is some clear peformance impact when you are running frequent > > &g

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > > > On Wed, 2017-

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote: > On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote: > > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote: > > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote: > > > > On Wed, 2017-

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

This is great, thanks. On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > With this, we reduce inode metadata updates across all 3 filesystems > down to roughly the frequency of the timestamp granularity, particularly > when it's not being queried (the vastly common case). > > The

Re: [PATCH 00/19] fs: rework and optimize i_version handling in filesystems

This is great, thanks. On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote: > With this, we reduce inode metadata updates across all 3 filesystems > down to roughly the frequency of the timestamp granularity, particularly > when it's not being queried (the vastly common case). > > The

Re: [PATCH v5] kernel: make groups_sort calling a responsibility group_info allocators

ACK. (Assuming somebody else takes it--Andrew? Al? Or I can take it through the nfsd tree. I'm not sure who owns the stuff under kernel/.) --b. On Mon, Dec 11, 2017 at 01:14:20PM -0200, Thiago Rafael Becker wrote: > In testing, we found that nfsd threads may call set_groups in parallel for >

Re: [PATCH v5] kernel: make groups_sort calling a responsibility group_info allocators

ACK. (Assuming somebody else takes it--Andrew? Al? Or I can take it through the nfsd tree. I'm not sure who owns the stuff under kernel/.) --b. On Mon, Dec 11, 2017 at 01:14:20PM -0200, Thiago Rafael Becker wrote: > In testing, we found that nfsd threads may call set_groups in parallel for >

Re: [PATCH 4/4] fhandle: Improve error responses in name_to_handle_at()

On Mon, Dec 11, 2017 at 05:04:05PM +1100, NeilBrown wrote: > 1/ Always return the mnt_id, even if some other error occurs. >It can be useful without the file handle. >An application can initialise the memory to, e.g. -1 >and if there is some other value after name_to_handle_at() >

Re: [PATCH 4/4] fhandle: Improve error responses in name_to_handle_at()

On Mon, Dec 11, 2017 at 05:04:05PM +1100, NeilBrown wrote: > 1/ Always return the mnt_id, even if some other error occurs. >It can be useful without the file handle. >An application can initialise the memory to, e.g. -1 >and if there is some other value after name_to_handle_at() >

Re: [PATCH 0/3 v3] Move groups_sort outisde of set_groups

ACK to these patches from me. I'm not sure who should pick them up --b. On Tue, Dec 05, 2017 at 12:05:09PM -0200, Thiago Rafael Becker wrote: > In cases where group_info is cached (e.g. sunrpc), multiplpe > threads may call set_groups with a freshly created group_info > cache (e.g. nfsd),

Re: [PATCH 0/3 v3] Move groups_sort outisde of set_groups

ACK to these patches from me. I'm not sure who should pick them up --b. On Tue, Dec 05, 2017 at 12:05:09PM -0200, Thiago Rafael Becker wrote: > In cases where group_info is cached (e.g. sunrpc), multiplpe > threads may call set_groups with a freshly created group_info > cache (e.g. nfsd),

Re: [PATCH] NFS: allow name_to_handle_at() to work for Amazon EFS.

On Fri, Dec 01, 2017 at 07:56:38AM +1100, NeilBrown wrote: > > Amazon EFS provides an NFSv4.1 filesystem which appears to use > (close to) full length (128 byte) file handles. I wonder why? Anyway, it seems unfortunate that systemd should need to worry about filehandle sizes at all, given that

Re: [PATCH] NFS: allow name_to_handle_at() to work for Amazon EFS.

On Fri, Dec 01, 2017 at 07:56:38AM +1100, NeilBrown wrote: > > Amazon EFS provides an NFSv4.1 filesystem which appears to use > (close to) full length (128 byte) file handles. I wonder why? Anyway, it seems unfortunate that systemd should need to worry about filehandle sizes at all, given that

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

On Mon, Dec 04, 2017 at 01:39:37PM -0200, Thiago Rafael Becker wrote: > > > On Mon, 4 Dec 2017, NeilBrown wrote: > > >I think you need to add groups_sort() in a few more places. > >Almost anywhere that calls groups_alloc() should be considered. > >net/sunrpc/svcauth_unix.c,

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

On Mon, Dec 04, 2017 at 01:39:37PM -0200, Thiago Rafael Becker wrote: > > > On Mon, 4 Dec 2017, NeilBrown wrote: > > >I think you need to add groups_sort() in a few more places. > >Almost anywhere that calls groups_alloc() should be considered. > >net/sunrpc/svcauth_unix.c,

Re: [PATCH 0/4] lockd refcount conversions

Thanks, applying all four for 4.16.--b. On Wed, Nov 29, 2017 at 01:15:42PM +0200, Elena Reshetova wrote: > This series, for lockd component, replaces atomic_t reference > counters with the new refcount_t type and API (see include/linux/refcount.h). > By doing this we prevent intentional or

Re: [PATCH 0/4] lockd refcount conversions

Thanks, applying all four for 4.16.--b. On Wed, Nov 29, 2017 at 01:15:42PM +0200, Elena Reshetova wrote: > This series, for lockd component, replaces atomic_t reference > counters with the new refcount_t type and API (see include/linux/refcount.h). > By doing this we prevent intentional or

[GIT PULL] nfsd fixes for 4.15

Please pull nfsd fixes for 4.15 from: git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.15-1 I screwed up my merge window pull request; I only sent half of what I meant to. There were no new features, just bugfixes of various importance and some very minor cleanup, so I think it's all still

[GIT PULL] nfsd fixes for 4.15

Please pull nfsd fixes for 4.15 from: git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.15-1 I screwed up my merge window pull request; I only sent half of what I meant to. There were no new features, just bugfixes of various importance and some very minor cleanup, so I think it's all still

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Tue, Nov 28, 2017 at 09:52:56AM +1100, Stephen Rothwell wrote: > Hi Bruce, > > Commit > > 64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from > nfs4_laundromat") > > is missing a Signed-off-by from its author. Previously:

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Tue, Nov 28, 2017 at 09:52:56AM +1100, Stephen Rothwell wrote: > Hi Bruce, > > Commit > > 64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from > nfs4_laundromat") > > is missing a Signed-off-by from its author. Previously:

[PULL REQUEST] nfsd changes for 4.15

atomic_t to refcount_t J. Bruce Fields (6): nfsd: remove unnecessary nofilehandle checks nfsd: increase DRC cache limit nfsd: give out fewer session slots as limit approaches nfsd4: fix cached replies to solo SEQUENCE compounds nfsd4: catch some false session retries

[PULL REQUEST] nfsd changes for 4.15

atomic_t to refcount_t J. Bruce Fields (6): nfsd: remove unnecessary nofilehandle checks nfsd: increase DRC cache limit nfsd: give out fewer session slots as limit approaches nfsd4: fix cached replies to solo SEQUENCE compounds nfsd4: catch some false session retries

Re: [PATCH v3] fs/fcntl: restore checking against COMPAT_LOFF_T_MAX for F_GETLK64

On Tue, Nov 14, 2017 at 07:48:18PM +0300, Vitaly Lipatov wrote: > for fcntl64 with F_GETLK64 we need use checking against COMPAT_LOFF_T_MAX. > > Fixes: 94073ad77fff2 "fs/locks: don't mess with the address limit in > compat_fcntl64" > > Signed-off-by: Vitaly Lipatov > --- >

Re: [PATCH v3] fs/fcntl: restore checking against COMPAT_LOFF_T_MAX for F_GETLK64

On Tue, Nov 14, 2017 at 07:48:18PM +0300, Vitaly Lipatov wrote: > for fcntl64 with F_GETLK64 we need use checking against COMPAT_LOFF_T_MAX. > > Fixes: 94073ad77fff2 "fs/locks: don't mess with the address limit in > compat_fcntl64" > > Signed-off-by: Vitaly Lipatov > --- > fs/fcntl.c | 14

Re: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11

On Fri, Nov 10, 2017 at 03:26:27PM -0800, Patrick McLean wrote: > > > On 2017-11-10 10:42 AM, Linus Torvalds wrote: > > On Thu, Nov 9, 2017 at 5:58 PM, Patrick McLean wrote: > >> > >> Something must have changed since 4.13.8 to trigger this though. > > > > Arnd pointed to

Re: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11

On Fri, Nov 10, 2017 at 03:26:27PM -0800, Patrick McLean wrote: > > > On 2017-11-10 10:42 AM, Linus Torvalds wrote: > > On Thu, Nov 9, 2017 at 5:58 PM, Patrick McLean wrote: > >> > >> Something must have changed since 4.13.8 to trigger this though. > > > > Arnd pointed to some commits that

Re: [PATCH 0/4] make function arg and structures as const

On Fri, Nov 10, 2017 at 10:09:46AM -0500, Anna Schumaker wrote: > > > On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: > >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: > >>> Make t

Re: [PATCH 0/4] make function arg and structures as const

On Fri, Nov 10, 2017 at 10:09:46AM -0500, Anna Schumaker wrote: > > > On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: > >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: > >>> Make t

Re: [PATCH 0/4] make function arg and structures as const

On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: > On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: > > Make the function argument as const. After thing change, make > > the cache_detail structures as const. > > > > Bhumika Goyal (4): > > sunrpc: make the function arg as

Re: [PATCH 0/4] make function arg and structures as const

On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: > On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: > > Make the function argument as const. After thing change, make > > the cache_detail structures as const. > > > > Bhumika Goyal (4): > > sunrpc: make the function arg as

Re: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11

On Wed, Nov 08, 2017 at 06:40:22PM -0800, Linus Torvalds wrote: > Anyway, that cmovne noise makes it a bit hard to see the actual part > that matters (and that traps) but I'm almost certain that it's the > "mnt->mnt_sb->s_flags" loading that is part of calculate_f_flags() > when it then does > >

Re: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11

On Wed, Nov 08, 2017 at 06:40:22PM -0800, Linus Torvalds wrote: > Anyway, that cmovne noise makes it a bit hard to see the actual part > that matters (and that traps) but I'm almost certain that it's the > "mnt->mnt_sb->s_flags" loading that is part of calculate_f_flags() > when it then does > >

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Fri, Nov 10, 2017 at 06:51:35AM +1100, Stephen Rothwell wrote: > Hi, > > Commit > > 988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from > nfs4_laundromat") > > is missing a Signed-off-by from its author. It fixes a typo in two lines in pretty much the only way possible, so

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Fri, Nov 10, 2017 at 06:51:35AM +1100, Stephen Rothwell wrote: > Hi, > > Commit > > 988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from > nfs4_laundromat") > > is missing a Signed-off-by from its author. It fixes a typo in two lines in pretty much the only way possible, so

Re: [PATCH] nlm_shutdown_hosts_net() cleanup

On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote: > nlm_complain_hosts() walk through nlm_server_hosts hlist that should be > protected by nlm_host_mutex. I haven't looked at the NLM locking in ages. Do we know who else might actually be accessing this list concurrently? --b. > >

Re: [PATCH] nlm_shutdown_hosts_net() cleanup

On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote: > nlm_complain_hosts() walk through nlm_server_hosts hlist that should be > protected by nlm_host_mutex. I haven't looked at the NLM locking in ages. Do we know who else might actually be accessing this list concurrently? --b. > >

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

On Tue, Oct 24, 2017 at 02:18:52PM -0400, Jeff Layton wrote: > On Tue, 2017-10-24 at 13:53 -0400, J. Bruce Fields wrote: > > On Tue, Oct 24, 2017 at 01:26:49PM -0400, Weston Andros Adamson wrote: > > > Is there a reason to BUG() in these places? Couldn't we WARN_ON_ONCE and >

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

On Tue, Oct 24, 2017 at 02:18:52PM -0400, Jeff Layton wrote: > On Tue, 2017-10-24 at 13:53 -0400, J. Bruce Fields wrote: > > On Tue, Oct 24, 2017 at 01:26:49PM -0400, Weston Andros Adamson wrote: > > > Is there a reason to BUG() in these places? Couldn't we WARN_ON_ONCE and >

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

Except for that read_u32... return, I wonder if we're missing a check there.) --b. > > -dros > > > On Oct 23, 2017, at 4:31 PM, J. Bruce Fields <bfie...@fieldses.org> wrote: > > > > In the past we've avoided BUG_ON(X) where X might have side effects, on > >

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

Except for that read_u32... return, I wonder if we're missing a check there.) --b. > > -dros > > > On Oct 23, 2017, at 4:31 PM, J. Bruce Fields wrote: > > > > In the past we've avoided BUG_ON(X) where X might have side effects, on > > the theory that it should ac

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

In the past we've avoided BUG_ON(X) where X might have side effects, on the theory that it should actually be OK just to compile out BUG_ON()s. Has that changed? In any case, I don't find that this improves readability; dropping. --b. On Mon, Oct 23, 2017 at 01:16:35PM -0500, Gustavo A. R.

Re: [PATCH] net: sunrpc: svcauth_gss: use BUG_ON instead of if condition followed by BUG

In the past we've avoided BUG_ON(X) where X might have side effects, on the theory that it should actually be OK just to compile out BUG_ON()s. Has that changed? In any case, I don't find that this improves readability; dropping. --b. On Mon, Oct 23, 2017 at 01:16:35PM -0500, Gustavo A. R.

Re: [PATCH] nfds: avoid gettimeofday for nfssvc_boot time

On Thu, Oct 19, 2017 at 01:04:35PM +0200, Arnd Bergmann wrote: > On Thu, Oct 19, 2017 at 12:54 PM, Jeff Layton wrote: > > > > I wonder if we'd be better off just using nfssvc_boot.tv_sec as the > > verifier? I don't see us ever calling that ktime_get_real_ts64 more than > >

Re: [PATCH] nfds: avoid gettimeofday for nfssvc_boot time

On Thu, Oct 19, 2017 at 01:04:35PM +0200, Arnd Bergmann wrote: > On Thu, Oct 19, 2017 at 12:54 PM, Jeff Layton wrote: > > > > I wonder if we'd be better off just using nfssvc_boot.tv_sec as the > > verifier? I don't see us ever calling that ktime_get_real_ts64 more than > > once per second for

Re: [PATCH 00/11] nfs refcount conversions

On Fri, Oct 20, 2017 at 12:53:27PM +0300, Elena Reshetova wrote: > This series, for nfs components, replaces atomic_t reference > counters with the new refcount_t type and API (see include/linux/refcount.h). > By doing this we prevent intentional or accidental > underflows or overflows that can

Re: [PATCH 00/11] nfs refcount conversions

On Fri, Oct 20, 2017 at 12:53:27PM +0300, Elena Reshetova wrote: > This series, for nfs components, replaces atomic_t reference > counters with the new refcount_t type and API (see include/linux/refcount.h). > By doing this we prevent intentional or accidental > underflows or overflows that can

Re: [PATCH v2] lockd: double unregister of inetaddr notifiers

Thanks, applying for 3.15 with a stable cc. --b. On Fri, Oct 20, 2017 at 01:03:37PM -0400, Jeff Layton wrote: > On Fri, 2017-10-20 at 17:33 +0300, Vasily Averin wrote: > > v2: reported to stable@ because it fixes backported patch. > > > > lockd_up() can call lockd_unregister_notifiers twice: >

Re: [PATCH v2] lockd: double unregister of inetaddr notifiers

Thanks, applying for 3.15 with a stable cc. --b. On Fri, Oct 20, 2017 at 01:03:37PM -0400, Jeff Layton wrote: > On Fri, 2017-10-20 at 17:33 +0300, Vasily Averin wrote: > > v2: reported to stable@ because it fixes backported patch. > > > > lockd_up() can call lockd_unregister_notifiers twice: >

Re: [PATCH] sunrcp: make function _svc_create_xprt static

Thanks, applied for 4.15.--b. On Mon, Oct 16, 2017 at 02:40:21PM +0100, Colin King wrote: > From: Colin Ian King > > The function _svc_create_xprt is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: >

Re: [PATCH] sunrcp: make function _svc_create_xprt static

Thanks, applied for 4.15.--b. On Mon, Oct 16, 2017 at 02:40:21PM +0100, Colin King wrote: > From: Colin Ian King > > The function _svc_create_xprt is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol '_svc_create_xprt' was

<    1   2   3   4   5   6   7   8   9   10   >