Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-18 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:17PM +0200, Andreas Gruenbacher wrote: > The trailing everyone@ allow ace can grant permissions to all file > classes including the owner and group class. Before we can apply the > other mask to this entry to turn it into an "other class" entry, we need > to ensure

Re: [RFC v7 22/41] richacl: Propagate everyone@ permissions to other aces

2015-09-18 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:17PM +0200, Andreas Gruenbacher wrote: > The trailing everyone@ allow ace can grant permissions to all file > classes including the owner and group class. Before we can apply the > other mask to this entry to turn it into an "other class" entry, we need > to ensure

Re: [RFC v7 13/41] richacl: Check if an acl is equivalent to a file mode

2015-09-17 Thread J. Bruce Fields
) I think the choices you've made probably make the most sense, they just wouldn't have been obvious to me. Anyway, so, OK by me: Reviewed-by: J. Bruce Fields --b. > > --b. > > > > > Signed-off-by: Andreas Gruenbacher > > --- > > fs/richacl_base.c

Re: [RFC v7 13/41] richacl: Check if an acl is equivalent to a file mode

2015-09-17 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:08PM +0200, Andreas Gruenbacher wrote: > ACLs are considered equivalent to file modes if they only consist of > owner@, group@, and everyone@ entries, the owner@ permissions do not > depend on whether the owner is a member in the owning group, and no > inheritance

Re: [RFC v7 13/41] richacl: Check if an acl is equivalent to a file mode

2015-09-17 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:08PM +0200, Andreas Gruenbacher wrote: > ACLs are considered equivalent to file modes if they only consist of > owner@, group@, and everyone@ entries, the owner@ permissions do not > depend on whether the owner is a member in the owning group, and no > inheritance

Re: [RFC v7 10/41] richacl: Permission check algorithm

2015-09-17 Thread J. Bruce Fields
On Sat, Sep 12, 2015 at 12:12:16AM +0200, Andreas Grünbacher wrote: > 2015-09-11 23:16 GMT+02:00 J. Bruce Fields : > > On Sat, Sep 05, 2015 at 12:27:05PM +0200, Andreas Gruenbacher wrote: > >> + /* > >> + * Apply the group file mask

Re: [RFC v7 13/41] richacl: Check if an acl is equivalent to a file mode

2015-09-17 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:08PM +0200, Andreas Gruenbacher wrote: > ACLs are considered equivalent to file modes if they only consist of > owner@, group@, and everyone@ entries, the owner@ permissions do not > depend on whether the owner is a member in the owning group, and no > inheritance

Re: [RFC v7 13/41] richacl: Check if an acl is equivalent to a file mode

2015-09-17 Thread J. Bruce Fields
On Sat, Sep 05, 2015 at 12:27:08PM +0200, Andreas Gruenbacher wrote: > ACLs are considered equivalent to file modes if they only consist of > owner@, group@, and everyone@ entries, the owner@ permissions do not > depend on whether the owner is a member in the owning group, and no > inheritance

Re: [RFC v7 10/41] richacl: Permission check algorithm

2015-09-17 Thread J. Bruce Fields
On Sat, Sep 12, 2015 at 12:12:16AM +0200, Andreas Grünbacher wrote: > 2015-09-11 23:16 GMT+02:00 J. Bruce Fields <bfie...@fieldses.org>: > > On Sat, Sep 05, 2015 at 12:27:05PM +0200, Andreas Gruenbacher wrote: > >> + /* > >> + * Apply the

Re: [RFC v7 13/41] richacl: Check if an acl is equivalent to a file mode

2015-09-17 Thread J. Bruce Fields
) I think the choices you've made probably make the most sense, they just wouldn't have been obvious to me. Anyway, so, OK by me: Reviewed-by: J. Bruce Fields <bfie...@redhat.com> --b. > > --b. > > > > > Signed-off-by:

Re: [PATCH 14/39] SUNRPC: drop null test before destroy functions

2015-09-14 Thread J. Bruce Fields
ACK, but assuming Trond takes this one.--b. On Sun, Sep 13, 2015 at 02:15:07PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) >

Re: [PATCH 22/39] nfsd: drop null test before destroy functions

2015-09-14 Thread J. Bruce Fields
Thanks, applying.--b. On Sun, Sep 13, 2015 at 02:15:15PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { >

Re: [PATCH 0/4] fs: allow userland tasks to use delayed_fput infrastructure

2015-09-14 Thread J. Bruce Fields
On Mon, Sep 14, 2015 at 09:45:51AM -0400, Jeff Layton wrote: > I'm breaking this piece out of the open file cache work for nfsd to see > if we can get this piece settled before I re-post the whole set. If this > looks like a reasonable approach we can sort out how it should be merged > (either by

Re: [PATCH 0/4] fs: allow userland tasks to use delayed_fput infrastructure

2015-09-14 Thread J. Bruce Fields
On Mon, Sep 14, 2015 at 09:45:51AM -0400, Jeff Layton wrote: > I'm breaking this piece out of the open file cache work for nfsd to see > if we can get this piece settled before I re-post the whole set. If this > looks like a reasonable approach we can sort out how it should be merged > (either by

Re: [PATCH 14/39] SUNRPC: drop null test before destroy functions

2015-09-14 Thread J. Bruce Fields
ACK, but assuming Trond takes this one.--b. On Sun, Sep 13, 2015 at 02:15:07PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) >

Re: [PATCH 22/39] nfsd: drop null test before destroy functions

2015-09-14 Thread J. Bruce Fields
Thanks, applying.--b. On Sun, Sep 13, 2015 at 02:15:15PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { >

Re: [PATCH] nfsd: add a new EXPORT_OP_NOWCC flag to struct export_operations

2015-09-11 Thread J. Bruce Fields
On Fri, Sep 11, 2015 at 06:20:30AM -0400, Jeff Layton wrote: > With NFSv3 nfsd will always attempt to send along WCC data to the > client. This generally involves saving off the in-core inode information > prior to doing the operation on the given filehandle, and then issuing a > vfs_getattr to it

Re: [RFC v7 10/41] richacl: Permission check algorithm

2015-09-11 Thread J. Bruce Fields
gt; includes the requested permissions. > > Signed-off-by: Andreas Gruenbacher > Acked-by: "J. Bruce Fields" > --- > fs/Makefile | 2 +- > fs/richacl_inode.c | 147 > > include/linux/richacl.h |

Re: [RFC v7 09/41] richacl: Update the file masks in chmod()

2015-09-11 Thread J. Bruce Fields
permissions to the file masks which go > beyond what the file permission bits can grant (like the > RICHACE_WRITE_ACL permission). The POSIX.1 standard calls this an > alternate file access control mechanism. A subsequent chmod() would > ensure that those permissions are disabled again. &

Re: [PATCH] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

2015-09-11 Thread J. Bruce Fields
delete access to a file itelf. > > The MAY_DELETE_SELF permission overrides the sticky directory check. > Reviewed-by: J. Bruce Fields > Signed-off-by: Andreas Gruenbacher > --- > fs/namei.c | 21 - > include/linux/fs.h | 2 ++ > 2 files changed,

Re: [RFC v7 09/41] richacl: Update the file masks in chmod()

2015-09-11 Thread J. Bruce Fields
permissions to the file masks which go > beyond what the file permission bits can grant (like the > RICHACE_WRITE_ACL permission). The POSIX.1 standard calls this an > alternate file access control mechanism. A subsequent chmod() would > ensure that those permissions are disabled aga

Re: [PATCH] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

2015-09-11 Thread J. Bruce Fields
delete access to a file itelf. > > The MAY_DELETE_SELF permission overrides the sticky directory check. > Reviewed-by: J. Bruce Fields <bfie...@redhat.com> > Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> > --- > fs/namei.c | 21 - >

Re: [RFC v7 10/41] richacl: Permission check algorithm

2015-09-11 Thread J. Bruce Fields
gt; includes the requested permissions. > > Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> > Acked-by: "J. Bruce Fields" <bfie...@fieldses.org> > --- > fs/Makefile | 2 +- > fs/richacl_inode.c | 147 > ++

Re: [PATCH] nfsd: add a new EXPORT_OP_NOWCC flag to struct export_operations

2015-09-11 Thread J. Bruce Fields
On Fri, Sep 11, 2015 at 06:20:30AM -0400, Jeff Layton wrote: > With NFSv3 nfsd will always attempt to send along WCC data to the > client. This generally involves saving off the in-core inode information > prior to doing the operation on the given filehandle, and then issuing a > vfs_getattr to it

[GIT PULL] nfsd changes for 4.3

2015-09-04 Thread J. Bruce Fields
crdma: Fix send_reply() scatter/gather set-up svcrdma: Clean up svc_rdma_get_reply_array() svcrdma: Remove svc_rdma_fastreg() svcrdma: Change maximum server payload back to RPCSVC_MAXPAYLOAD J. Bruce Fields (5): Revert "Documentation: NFS/RDMA: Document separate

[GIT PULL] nfsd changes for 4.3

2015-09-04 Thread J. Bruce Fields
crdma: Fix send_reply() scatter/gather set-up svcrdma: Clean up svc_rdma_get_reply_array() svcrdma: Remove svc_rdma_fastreg() svcrdma: Change maximum server payload back to RPCSVC_MAXPAYLOAD J. Bruce Fields (5): Revert "Documentation: NFS/RDMA: Document separate

Re: [RFC v6 08/40] richacl: Compute maximum file masks from an acl

2015-09-02 Thread J. Bruce Fields
extended attribute already includes the file masks. > > > > Setting an acl also sets the file mode permission bits: they are > > determined by the file masks; see richacl_masks_to_mode(). > > > > Signed-off-by: Andreas Gruenbac

Re: [RFC v6 08/40] richacl: Compute maximum file masks from an acl

2015-09-02 Thread J. Bruce Fields
the file mode permission bits: they are > determined by the file masks; see richacl_masks_to_mode(). > > Signed-off-by: Andreas Gruenbacher > Reviewed-by: J. Bruce Fields > --- > fs/richacl_base.c | 156 > > include/linux/richacl.h |

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Wed, Sep 02, 2015 at 09:06:32PM +0200, Andreas Gruenbacher wrote: > 2015-09-02 20:53 GMT+02:00 J. Bruce Fields : > >> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, > >> struct inode *inode, int mask) > >> * this, letting us set arbitr

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:00PM +0200, Andreas Gruenbacher wrote: > Richacls distinguish between creating non-directories and directories. To > support that, add an isdir parameter to may_create(). When checking > inode_permission() for create permission, pass in an additional > MAY_CREATE_FILE

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:00PM +0200, Andreas Gruenbacher wrote: > Richacls distinguish between creating non-directories and directories. To > support that, add an isdir parameter to may_create(). When checking > inode_permission() for create permission, pass in an additional > MAY_CREATE_FILE

Re: [RFC v6 08/40] richacl: Compute maximum file masks from an acl

2015-09-02 Thread J. Bruce Fields
extended attribute already includes the file masks. > > > > Setting an acl also sets the file mode permission bits: they are > > determined by the file masks; see richacl_masks_to_mode(). > > > > Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> > >

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Wed, Sep 02, 2015 at 09:06:32PM +0200, Andreas Gruenbacher wrote: > 2015-09-02 20:53 GMT+02:00 J. Bruce Fields <bfie...@fieldses.org>: > >> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, > >> struct inode *inode, int mask) > >>

Re: [RFC v6 08/40] richacl: Compute maximum file masks from an acl

2015-09-02 Thread J. Bruce Fields
the file mode permission bits: they are > determined by the file masks; see richacl_masks_to_mode(). > > Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> > Reviewed-by: J. Bruce Fields <bfie...@redhat.com> > --- > fs/richacl_base.c | 156 > +

Re: [RFC v6 09/40] richacl: Update the file masks in chmod()

2015-09-01 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:07PM +0200, Andreas Gruenbacher wrote: > Doing a chmod() sets the file mode, which includes the file permission > bits. When a file has a richacl, the permissions that the richacl > grants need to be limited to what the new file permission bits allow. > > This is

Re: [RFC v6 09/40] richacl: Update the file masks in chmod()

2015-09-01 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:07PM +0200, Andreas Gruenbacher wrote: > Doing a chmod() sets the file mode, which includes the file permission > bits. When a file has a richacl, the permissions that the richacl > grants need to be limited to what the new file permission bits allow. > > This is

Re: [RFC v6 10/40] richacl: Permission check algorithm

2015-08-31 Thread J. Bruce Fields
On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote: > 2015-08-28 23:49 GMT+02:00 J. Bruce Fields : > > On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote: > >> + /* > >> + * We don't care which class the

Re: [RFC v6 10/40] richacl: Permission check algorithm

2015-08-31 Thread J. Bruce Fields
On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote: > 2015-08-28 23:49 GMT+02:00 J. Bruce Fields <bfie...@fieldses.org>: > > On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote: > >> + /* > >> + * We d

Re: [RFC v6 03/40] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

2015-08-28 Thread J. Bruce Fields
On Fri, Aug 28, 2015 at 02:36:15PM -0700, Andy Lutomirski wrote: > On Tue, Aug 4, 2015 at 4:53 AM, Andreas Gruenbacher > wrote: > > Normally, deleting a file requires write and execute access to the parent > > directory. With Richacls, a process with MAY_DELETE_SELF access to a file > > may

Re: [RFC v6 10/40] richacl: Permission check algorithm

2015-08-28 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote: > A richacl roughly grants a requested access if the NFSv4 acl in the > richacl grants the requested permissions according to the NFSv4 > permission check algorithm and the file mask that applies to the process > includes the

Re: [RFC v6 03/40] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

2015-08-28 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:01PM +0200, Andreas Gruenbacher wrote: > Normally, deleting a file requires write and execute access to the parent > directory. With Richacls, a process with MAY_DELETE_SELF access to a file > may delete the file even without write access to the parent directory. >

Re: [RFC v6 01/40] vfs: Add IS_ACL() and IS_RICHACL() tests

2015-08-28 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:52:59PM +0200, Andreas Gruenbacher wrote: > The vfs does not apply the umask for file systems that support acls. The > test used for this used to be called IS_POSIXACL(). Switch to a new > IS_ACL() test to check for either posix acls or richacls instead. Add a new >

Re: [RFC v6 10/40] richacl: Permission check algorithm

2015-08-28 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote: A richacl roughly grants a requested access if the NFSv4 acl in the richacl grants the requested permissions according to the NFSv4 permission check algorithm and the file mask that applies to the process includes the

Re: [RFC v6 03/40] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

2015-08-28 Thread J. Bruce Fields
On Fri, Aug 28, 2015 at 02:36:15PM -0700, Andy Lutomirski wrote: On Tue, Aug 4, 2015 at 4:53 AM, Andreas Gruenbacher andreas.gruenbac...@gmail.com wrote: Normally, deleting a file requires write and execute access to the parent directory. With Richacls, a process with MAY_DELETE_SELF access

Re: [RFC v6 01/40] vfs: Add IS_ACL() and IS_RICHACL() tests

2015-08-28 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:52:59PM +0200, Andreas Gruenbacher wrote: The vfs does not apply the umask for file systems that support acls. The test used for this used to be called IS_POSIXACL(). Switch to a new IS_ACL() test to check for either posix acls or richacls instead. Add a new

Re: [RFC v6 03/40] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

2015-08-28 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:01PM +0200, Andreas Gruenbacher wrote: Normally, deleting a file requires write and execute access to the parent directory. With Richacls, a process with MAY_DELETE_SELF access to a file may delete the file even without write access to the parent directory. To

Re: [PATCH V3] net: sunrpc: fix tracepoint Warning: unknown op '->'

2015-08-27 Thread J. Bruce Fields
Thanks, applying, with: Cc: sta...@vger.kernel.org Fixes: 83a712e0afef "sunrpc: add some tracepoints around ..." (let me know if that's not right.) --b. On Thu, Aug 27, 2015 at 10:01:33AM +0530, Pratyush Anand wrote: > `perf stat -e sunrpc:svc_xprt_do_enqueue true` results in

Re: [PATCH V3] net: sunrpc: fix tracepoint Warning: unknown op '-'

2015-08-27 Thread J. Bruce Fields
Thanks, applying, with: Cc: sta...@vger.kernel.org Fixes: 83a712e0afef sunrpc: add some tracepoints around ... (let me know if that's not right.) --b. On Thu, Aug 27, 2015 at 10:01:33AM +0530, Pratyush Anand wrote: `perf stat -e sunrpc:svc_xprt_do_enqueue true` results in

Re: [PATCH] nfsd: don't WARN/backtrace for invalid container deployment.

2015-08-26 Thread J. Bruce Fields
e associated backtrace, so people aren't needlessly alarmed. > > Also, lets drop the split printk line, since they are grep unfriendly. OK, applying.--b. > > Cc: "J. Bruce Fields" > Cc: linux-...@vger.kernel.org > Signed-off-by: Paul Gortmaker > > diff --git a/fs/nfs

Re: [PATCH] nfsd: don't WARN/backtrace for invalid container deployment.

2015-08-26 Thread J. Bruce Fields
. Also, lets drop the split printk line, since they are grep unfriendly. OK, applying.--b. Cc: J. Bruce Fields bfie...@fieldses.org Cc: linux-...@vger.kernel.org Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index

Re: [PATCH] nfsd: don't WARN/backtrace for invalid container deployment.

2015-08-25 Thread J. Bruce Fields
en't needlessly alarmed. > > > > Also, lets drop the split printk line, since they are grep unfriendly. > > > > Cc: "J. Bruce Fields" > > Cc: linux-...@vger.kernel.org > > Signed-off-by: Paul Gortmaker > > > > diff --git a/fs/nfsd/nfs4r

Re: [PATCH] nfsd: don't WARN/backtrace for invalid container deployment.

2015-08-25 Thread J. Bruce Fields
or configuration settings in the container. Given that, lets tone it down a bit and get rid of the WARN severity, and the associated backtrace, so people aren't needlessly alarmed. Also, lets drop the split printk line, since they are grep unfriendly. Cc: J. Bruce Fields bfie

[PATCH] nfsd: Add Jeff Layton as co-maintainer

2015-08-24 Thread J. Bruce Fields
From: "J. Bruce Fields" Jeff has been doing a lot of development (including much of the state-locking rewrite just as one example) plus lots of review and other miscellaneous nfsd work, so let's acknowledge the status quo. I'll continue to be the one to send regular pull request

[PATCH] nfsd: Add Jeff Layton as co-maintainer

2015-08-24 Thread J. Bruce Fields
From: J. Bruce Fields bfie...@redhat.com Jeff has been doing a lot of development (including much of the state-locking rewrite just as one example) plus lots of review and other miscellaneous nfsd work, so let's acknowledge the status quo. I'll continue to be the one to send regular pull

Re: [GIT PULL] nfsd bugfixes for 4.2

2015-08-05 Thread J. Bruce Fields
On Wed, Aug 05, 2015 at 11:01:53AM +0200, Linus Torvalds wrote: > On Tue, Aug 4, 2015 at 11:09 PM, J. Bruce Fields wrote: > > Please pull a few nfsd bugfixes for 4.2 from: > > Pulled. However, I wonder if you could start making signed tag pull > requests. I don't know

Re: [GIT PULL] nfsd bugfixes for 4.2

2015-08-05 Thread J. Bruce Fields
On Wed, Aug 05, 2015 at 11:01:53AM +0200, Linus Torvalds wrote: On Tue, Aug 4, 2015 at 11:09 PM, J. Bruce Fields bfie...@fieldses.org wrote: Please pull a few nfsd bugfixes for 4.2 from: Pulled. However, I wonder if you could start making signed tag pull requests. I don't know how linux

[GIT PULL] nfsd bugfixes for 4.2

2015-08-04 Thread J. Bruce Fields
Please pull a few nfsd bugfixes for 4.2 from: git://linux-nfs.org/~bfields/linux.git for-4.2 --b. Jeff Layton (1): nfsd: do nfs4_check_fh in nfs4_check_file instead of nfs4_check_olstateid Kinglong Mee (2): nfsd:

[GIT PULL] nfsd bugfixes for 4.2

2015-08-04 Thread J. Bruce Fields
Please pull a few nfsd bugfixes for 4.2 from: git://linux-nfs.org/~bfields/linux.git for-4.2 --b. Jeff Layton (1): nfsd: do nfs4_check_fh in nfs4_check_file instead of nfs4_check_olstateid Kinglong Mee (2): nfsd:

Re: v4.2-rc dcache regression, probably 75a6f82a0d10

2015-07-31 Thread J. Bruce Fields
On Fri, Jul 31, 2015 at 10:46:51AM -0700, Hugh Dickins wrote: > I think there's something not quite right with the fs/dcache.c > commit 75a6f82a0d10 ("freeing unlinked file indefinitely delayed"). > > When running my old tmpfs swapping load (two repetitive make -j20 > kernel builds, one on tmpfs,

Re: v4.2-rc dcache regression, probably 75a6f82a0d10

2015-07-31 Thread J. Bruce Fields
On Fri, Jul 31, 2015 at 10:46:51AM -0700, Hugh Dickins wrote: I think there's something not quite right with the fs/dcache.c commit 75a6f82a0d10 (freeing unlinked file indefinitely delayed). When running my old tmpfs swapping load (two repetitive make -j20 kernel builds, one on tmpfs, one on

Re: linux-next: manual merge of the nfsd tree with Linus' tree

2015-07-29 Thread J. Bruce Fields
On Wed, Jul 29, 2015 at 09:35:11PM -0400, Trond Myklebust wrote: > Hi Stephen, > > On Wed, Jul 29, 2015 at 9:23 PM, Stephen Rothwell > wrote: > > Hi all, > > > > Today's linux-next merge of the nfsd tree got a conflict in: > > > > fs/nfs/nfs42proc.c > > > > between commit: > > > >

Re: linux-next: manual merge of the nfsd tree with Linus' tree

2015-07-29 Thread J. Bruce Fields
On Wed, Jul 29, 2015 at 09:35:11PM -0400, Trond Myklebust wrote: Hi Stephen, On Wed, Jul 29, 2015 at 9:23 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi all, Today's linux-next merge of the nfsd tree got a conflict in: fs/nfs/nfs42proc.c between commit:

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-23 Thread J. Bruce Fields
On Thu, Jul 23, 2015 at 11:51:35AM +1000, Dave Chinner wrote: > On Wed, Jul 22, 2015 at 01:41:00PM -0400, J. Bruce Fields wrote: > > On Wed, Jul 22, 2015 at 12:52:58PM -0400, Austin S Hemmelgarn wrote: > > > On 2015-07-22 10:09, J. Bruce Fields wrote: > > > >On W

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-23 Thread J. Bruce Fields
On Thu, Jul 23, 2015 at 11:51:35AM +1000, Dave Chinner wrote: On Wed, Jul 22, 2015 at 01:41:00PM -0400, J. Bruce Fields wrote: On Wed, Jul 22, 2015 at 12:52:58PM -0400, Austin S Hemmelgarn wrote: On 2015-07-22 10:09, J. Bruce Fields wrote: On Wed, Jul 22, 2015 at 05:56:40PM +1000, Dave

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-22 Thread J. Bruce Fields
On Wed, Jul 22, 2015 at 12:52:58PM -0400, Austin S Hemmelgarn wrote: > On 2015-07-22 10:09, J. Bruce Fields wrote: > >On Wed, Jul 22, 2015 at 05:56:40PM +1000, Dave Chinner wrote: > >>On Tue, Jul 21, 2015 at 01:37:21PM -0400, J. Bruce Fields wrote: > >>>On Fri, Ju

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-22 Thread J. Bruce Fields
On Wed, Jul 22, 2015 at 05:56:40PM +1000, Dave Chinner wrote: > On Tue, Jul 21, 2015 at 01:37:21PM -0400, J. Bruce Fields wrote: > > On Fri, Jul 17, 2015 at 12:47:35PM +1000, Dave Chinner wrote: > > > On Thu, Jul 16, 2015 at 07:42:03PM -0500, Eric W. Biederman wrote: > >

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-22 Thread J. Bruce Fields
On Wed, Jul 22, 2015 at 12:52:58PM -0400, Austin S Hemmelgarn wrote: On 2015-07-22 10:09, J. Bruce Fields wrote: On Wed, Jul 22, 2015 at 05:56:40PM +1000, Dave Chinner wrote: On Tue, Jul 21, 2015 at 01:37:21PM -0400, J. Bruce Fields wrote: On Fri, Jul 17, 2015 at 12:47:35PM +1000, Dave Chinner

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-22 Thread J. Bruce Fields
On Wed, Jul 22, 2015 at 05:56:40PM +1000, Dave Chinner wrote: On Tue, Jul 21, 2015 at 01:37:21PM -0400, J. Bruce Fields wrote: On Fri, Jul 17, 2015 at 12:47:35PM +1000, Dave Chinner wrote: On Thu, Jul 16, 2015 at 07:42:03PM -0500, Eric W. Biederman wrote: Dave Chinner da...@fromorbit.com

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-21 Thread J. Bruce Fields
On Fri, Jul 17, 2015 at 12:47:35PM +1000, Dave Chinner wrote: > On Thu, Jul 16, 2015 at 07:42:03PM -0500, Eric W. Biederman wrote: > > Dave Chinner writes: > > > > > On Wed, Jul 15, 2015 at 11:47:08PM -0500, Eric W. Biederman wrote: > > >> Casey Schaufler writes: > > >> > On 7/15/2015 6:08 PM,

Re: [PATCH 0/7] Initial support for user namespace owned mounts

2015-07-21 Thread J. Bruce Fields
On Fri, Jul 17, 2015 at 12:47:35PM +1000, Dave Chinner wrote: On Thu, Jul 16, 2015 at 07:42:03PM -0500, Eric W. Biederman wrote: Dave Chinner da...@fromorbit.com writes: On Wed, Jul 15, 2015 at 11:47:08PM -0500, Eric W. Biederman wrote: Casey Schaufler ca...@schaufler-ca.com writes:

Re: [GIT PULL] please pull file-locking related changes for v4.2

2015-07-13 Thread J. Bruce Fields
On Mon, Jul 13, 2015 at 06:45:32AM -0400, Jeff Layton wrote: > The following changes since commit b9243b5a5d2da4eb0a54950f4e2d6272863b48be: > > Merge branch 'parisc-4.2-1' of > git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux (2015-07-10 > 16:54:37 -0700) > > are available

Re: [GIT PULL] please pull file-locking related changes for v4.2

2015-07-13 Thread J. Bruce Fields
On Mon, Jul 13, 2015 at 06:45:32AM -0400, Jeff Layton wrote: The following changes since commit b9243b5a5d2da4eb0a54950f4e2d6272863b48be: Merge branch 'parisc-4.2-1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux (2015-07-10 16:54:37 -0700) are available in the

Re: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one

2015-07-08 Thread J. Bruce Fields
On Mon, Jul 06, 2015 at 11:30:26AM -0400, Chuck Lever wrote: > Hi Valentin- > > > On Jul 6, 2015, at 3:36 AM, Valentin Rothberg > wrote: > > > On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg > > wrote: > >> Hi Chuck, > >> > >> your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and

Re: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one

2015-07-08 Thread J. Bruce Fields
On Mon, Jul 06, 2015 at 11:30:26AM -0400, Chuck Lever wrote: Hi Valentin- On Jul 6, 2015, at 3:36 AM, Valentin Rothberg valentinrothb...@gmail.com wrote: On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg valentinrothb...@gmail.com wrote: Hi Chuck, your commit ffe1f0df5862

Re: [RFC] freeing unliked file indefinitely delayed

2015-07-07 Thread J. Bruce Fields
On Wed, Jul 08, 2015 at 02:42:38AM +0100, Al Viro wrote: > Normally opening a file, unlinking it and then closing will have > the inode freed upon close() (provided that it's not otherwise busy and > has no remaining links, of course). However, there's one case where that > does *not*

Re: [RFC] freeing unliked file indefinitely delayed

2015-07-07 Thread J. Bruce Fields
On Wed, Jul 08, 2015 at 02:42:38AM +0100, Al Viro wrote: Normally opening a file, unlinking it and then closing will have the inode freed upon close() (provided that it's not otherwise busy and has no remaining links, of course). However, there's one case where that does *not* happen.

[GIT PULL] nfsd changes for 4.2

2015-06-26 Thread J. Bruce Fields
Please pull nfsd changes from git://linux-nfs.org/~bfields/linux.git for-4.2 A relatively quiet cycle, with a mix of cleanup and smaller bugfixes. --b. Andreas Gruenbacher (4): nfsd: Disable NFSv2 timestamp workaround for

[GIT PULL] nfsd changes for 4.2

2015-06-26 Thread J. Bruce Fields
Please pull nfsd changes from git://linux-nfs.org/~bfields/linux.git for-4.2 A relatively quiet cycle, with a mix of cleanup and smaller bugfixes. --b. Andreas Gruenbacher (4): nfsd: Disable NFSv2 timestamp workaround for

Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

2015-06-19 Thread J. Bruce Fields
Thanks, applying.--b. On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote: > Don't opencode sg_init_one() > > Signed-off-by: Fabian Frederick > --- > net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git

Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

2015-06-19 Thread J. Bruce Fields
Thanks, applying.--b. On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote: Don't opencode sg_init_one() Signed-off-by: Fabian Frederick f...@skynet.be --- net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 1/1 linux-next] nfsd: use swap() in sort_pacl_range()

2015-06-16 Thread J. Bruce Fields
Applying, thanks.--b. On Fri, Jun 12, 2015 at 06:58:57PM +0200, Fabian Frederick wrote: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick > --- > fs/nfsd/nfs4acl.c | 6 ++ > 1 file changed, 2 insertions(+), 4

Re: [PATCH 1/1 linux-next] nfsd: use swap() in sort_pacl_range()

2015-06-16 Thread J. Bruce Fields
Applying, thanks.--b. On Fri, Jun 12, 2015 at 06:58:57PM +0200, Fabian Frederick wrote: Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/nfsd/nfs4acl.c | 6 ++ 1 file changed, 2

Re: linux-next: unsigned patch on the top of the nfsd tree

2015-06-04 Thread J. Bruce Fields
On Thu, Jun 04, 2015 at 07:58:36AM +1000, Stephen Rothwell wrote: > I noticed that it appears that you have leaked an unsigned debugging > patch at the top of the nsfd tree today ... Whoops--thanks for catching that. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: linux-next: unsigned patch on the top of the nfsd tree

2015-06-04 Thread J. Bruce Fields
On Thu, Jun 04, 2015 at 07:58:36AM +1000, Stephen Rothwell wrote: I noticed that it appears that you have leaked an unsigned debugging patch at the top of the nsfd tree today ... Whoops--thanks for catching that. --b. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [RFC v3 43/45] uapi/nfs: Add NFSv4.1 ACL definitions

2015-05-29 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:40PM +0200, Andreas Gruenbacher wrote: > Add the ACL related protocol definitions which were added in the NFSv4.1 > specifiction. No harm in taking this now, I guess, I'll queue this one up for 4.2. --b. > > Signed-off-by: Andreas Gruenbacher > --- >

Re: [RFC v3 43/45] uapi/nfs: Add NFSv4.1 ACL definitions

2015-05-29 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:40PM +0200, Andreas Gruenbacher wrote: Add the ACL related protocol definitions which were added in the NFSv4.1 specifiction. No harm in taking this now, I guess, I'll queue this one up for 4.2. --b. Signed-off-by: Andreas Gruenbacher agrue...@redhat.com ---

Re: [RFC v3 36/45] NFSv4: Fix GETATTR bitmap verification

2015-05-28 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote: > The NFSv4 client sends the server GETATTR requests with different sets of > requested attributes depending on the situation. The requested set of > attributes is encoded in a bitmap; the server replies with the set of >

Re: [RFC v3 33/45] nfsd: Keep list of acls to dispose of in compoundargs

2015-05-28 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:30PM +0200, Andreas Gruenbacher wrote: > We will decode acls in requests into richacls; those need to be richacl_put() > at the end of the request instead of kfree()d; this allows the vfs to cache > them whenever possible. > > NOTE: If we allow only a single acl per

Re: [RFC v3 30/45] richacl: Create richacl from mode values

2015-05-28 Thread J. Bruce Fields
On Thu, May 28, 2015 at 03:24:13PM -0400, bfields wrote: > On Fri, Apr 24, 2015 at 01:04:27PM +0200, Andreas Gruenbacher wrote: > > Create a richacl that corresponds to given file mode permission bits. > > > > Signed-off-by: Andreas Gruenbacher > > --- > > fs/richacl_compat.c | 38

Re: [RFC v3 30/45] richacl: Create richacl from mode values

2015-05-28 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:27PM +0200, Andreas Gruenbacher wrote: > Create a richacl that corresponds to given file mode permission bits. > > Signed-off-by: Andreas Gruenbacher > --- > fs/richacl_compat.c | 38 ++ > include/linux/richacl.h | 1 + > 2

Re: [RFC v3 36/45] NFSv4: Fix GETATTR bitmap verification

2015-05-28 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote: The NFSv4 client sends the server GETATTR requests with different sets of requested attributes depending on the situation. The requested set of attributes is encoded in a bitmap; the server replies with the set of attributes

Re: [RFC v3 30/45] richacl: Create richacl from mode values

2015-05-28 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:27PM +0200, Andreas Gruenbacher wrote: Create a richacl that corresponds to given file mode permission bits. Signed-off-by: Andreas Gruenbacher agr...@kernel.org --- fs/richacl_compat.c | 38 ++ include/linux/richacl.h |

Re: [RFC v3 30/45] richacl: Create richacl from mode values

2015-05-28 Thread J. Bruce Fields
On Thu, May 28, 2015 at 03:24:13PM -0400, bfields wrote: On Fri, Apr 24, 2015 at 01:04:27PM +0200, Andreas Gruenbacher wrote: Create a richacl that corresponds to given file mode permission bits. Signed-off-by: Andreas Gruenbacher agr...@kernel.org --- fs/richacl_compat.c | 38

Re: [RFC v3 33/45] nfsd: Keep list of acls to dispose of in compoundargs

2015-05-28 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:30PM +0200, Andreas Gruenbacher wrote: We will decode acls in requests into richacls; those need to be richacl_put() at the end of the request instead of kfree()d; this allows the vfs to cache them whenever possible. NOTE: If we allow only a single acl per

Re: [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-05-27 Thread J. Bruce Fields
On Wed, May 27, 2015 at 11:24:49AM +0200, Andreas Grünbacher wrote: > Bruce, > > 2015-05-15 22:51 GMT+02:00 J. Bruce Fields : > > On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote: > > This comment is a little confusing: > > > >> + * This

Re: [RFC v3 14/45] richacl: Permission check algorithm

2015-05-27 Thread J. Bruce Fields
On Wed, May 27, 2015 at 01:25:18PM +0200, Andreas Grünbacher wrote: > 2015-05-22 23:08 GMT+02:00 J. Bruce Fields : > > On Fri, Apr 24, 2015 at 01:04:11PM +0200, Andreas Gruenbacher wrote: > >> A richacl grants a requested access if the NFSv4 acl in the richacl > >> grant

Re: [RFC v3 14/45] richacl: Permission check algorithm

2015-05-27 Thread J. Bruce Fields
On Wed, May 27, 2015 at 01:25:18PM +0200, Andreas Grünbacher wrote: 2015-05-22 23:08 GMT+02:00 J. Bruce Fields bfie...@fieldses.org: On Fri, Apr 24, 2015 at 01:04:11PM +0200, Andreas Gruenbacher wrote: A richacl grants a requested access if the NFSv4 acl in the richacl grants the requested

Re: [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-05-27 Thread J. Bruce Fields
On Wed, May 27, 2015 at 11:24:49AM +0200, Andreas Grünbacher wrote: Bruce, 2015-05-15 22:51 GMT+02:00 J. Bruce Fields bfie...@fieldses.org: On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote: This comment is a little confusing: + * This function does not consider

Re: [RFC v3 29/45] richacl: Apply the file masks to a richacl

2015-05-26 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:26PM +0200, Andreas Gruenbacher wrote: > Put all the pieces of the acl transformation puzzle together for > computing a richacl which has the file masks "applied" so that the > standard nfsv4 access check algorithm can be used on the richacl. > > Signed-off-by:

Re: [RFC v3 29/45] richacl: Apply the file masks to a richacl

2015-05-26 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:26PM +0200, Andreas Gruenbacher wrote: Put all the pieces of the acl transformation puzzle together for computing a richacl which has the file masks applied so that the standard nfsv4 access check algorithm can be used on the richacl. Signed-off-by: Andreas

<    5   6   7   8   9   10   11   12   13   14   >