Re: [PATCH] x86/mce/AMD: Allow any CPU to initialize smca_banks array

This patch works for me, thanks! Jack On Thu, Jun 29, 2017 at 1:08 PM, Yazen Ghannam wrote: > From: Yazen Ghannam > > Current SMCA implementations have the same banks on each CPU with the > non-core banks only visible to a "master thread" on each

Re: [PATCH] x86/mce/AMD: Allow any CPU to initialize smca_banks array

This patch works for me, thanks! Jack On Thu, Jun 29, 2017 at 1:08 PM, Yazen Ghannam wrote: > From: Yazen Ghannam > > Current SMCA implementations have the same banks on each CPU with the > non-core banks only visible to a "master thread" on each Die. Practically, > this means the smca_banks

Re: [PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

On Wed, Jun 28, 2017 at 1:58 PM, Ghannam, Yazen wrote: >> With my patch applied, I see entries like l3_cache under hardware thread 0's >> directory (it's shifted to CPU 1, so machinecheck1). >> Without my patch, only machinecheck0 has anything interesting in it >>

Re: [PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

On Wed, Jun 28, 2017 at 1:58 PM, Ghannam, Yazen wrote: >> With my patch applied, I see entries like l3_cache under hardware thread 0's >> directory (it's shifted to CPU 1, so machinecheck1). >> Without my patch, only machinecheck0 has anything interesting in it >> (insn_fetch, l2_cache etc.)

Re: [PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

On Wed, Jun 28, 2017 at 1:00 PM, Ghannam, Yazen <yazen.ghan...@amd.com> wrote: >> -Original Message- >> From: themo...@gmail.com [mailto:themo...@gmail.com] On Behalf Of >> Jack Miller >> Sent: Wednesday, June 28, 2017 1:44 PM >> To: Borislav Petkov

Re: [PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

On Wed, Jun 28, 2017 at 1:00 PM, Ghannam, Yazen wrote: >> -Original Message- >> From: themo...@gmail.com [mailto:themo...@gmail.com] On Behalf Of >> Jack Miller >> Sent: Wednesday, June 28, 2017 1:44 PM >> To: Borislav Petkov >> Cc: Jack Miller

Re: [PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

On Wed, Jun 28, 2017 at 4:22 AM, Borislav Petkov <b...@suse.de> wrote: > On Tue, Jun 27, 2017 at 07:06:30PM -0500, Jack Miller wrote: >> After a call to firmware SwitchBSP(), > > What is that and who does that? SwitchBSP() is part of the UEFI MPServices Protocol which I be

Re: [PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

On Wed, Jun 28, 2017 at 4:22 AM, Borislav Petkov wrote: > On Tue, Jun 27, 2017 at 07:06:30PM -0500, Jack Miller wrote: >> After a call to firmware SwitchBSP(), > > What is that and who does that? SwitchBSP() is part of the UEFI MPServices Protocol which I believe

[PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

0's APIC ID != 0, but the other topology/CPUID based functions don't seem to easily differentiate CPU 0 and thread 0 or possibly aren't inited at this point. Suggestions for a better mechanism welcome. Signed-off-by: Jack Miller <j...@codezen.org> --- arch/x86/kernel/cpu/mcheck/mce_amd

[PATCH] x86/mce/AMD: Fix partial SMCA bank init when CPU 0 != thread 0

0's APIC ID != 0, but the other topology/CPUID based functions don't seem to easily differentiate CPU 0 and thread 0 or possibly aren't inited at this point. Suggestions for a better mechanism welcome. Signed-off-by: Jack Miller --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 4 ++-- 1 file changed

Re: [RESEND] shm: shm exit scalability fixes

On Tue, Jun 17, 2014 at 10:48:32AM -0700, Davidlohr Bueso wrote: > On Tue, 2014-06-17 at 12:27 -0500, Jack Miller wrote: > > [ RESEND note: Adding relevant CCs, fixed a couple of typos in commit > > message, > > patches unchanged. Original intro follows. ] > > >

[PATCH 3/3] shm: Remove unneeded extern for function

A small cleanup while changing adjacent code. Extern is not needed for functions and only one declaration had it so remove it from the odd line. Signed-off-by: Milton Miller Signed-off-by: Jack Miller --- include/linux/shm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/3] shm: Allow exit_shm in parallel if only marking orphans

-off-by: Jack Miller --- ipc/shm.c | 67 +-- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index 9790a0e..0dde176 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -269,32 +269,6 @@ static void shm_close

[PATCH 1/3] shm: Make exit_shm work proportional to task activity

een the semaphore code and the task struct. Converting the list_del to list_del_init for the unshare cases would remove the exit followed by init, but I left it blow up if not inited. Signed-off-by: Milton Miller Signed-off-by: Jack Miller --- include/linux/sched.h | 2 ++ include/linux/sh

[RESEND] shm: shm exit scalability fixes

[ RESEND note: Adding relevant CCs, fixed a couple of typos in commit message, patches unchanged. Original intro follows. ] All - This is small set of patches our team has had kicking around for a few versions internally that fixes tasks getting hung on shm_exit when there are many threads

[RESEND] shm: shm exit scalability fixes

[ RESEND note: Adding relevant CCs, fixed a couple of typos in commit message, patches unchanged. Original intro follows. ] All - This is small set of patches our team has had kicking around for a few versions internally that fixes tasks getting hung on shm_exit when there are many threads

[PATCH 1/3] shm: Make exit_shm work proportional to task activity

the semaphore code and the task struct. Converting the list_del to list_del_init for the unshare cases would remove the exit followed by init, but I left it blow up if not inited. Signed-off-by: Milton Miller milt...@bga.com Signed-off-by: Jack Miller mille...@us.ibm.com --- include/linux/sched.h

[PATCH 2/3] shm: Allow exit_shm in parallel if only marking orphans

...@bga.com Signed-off-by: Jack Miller mille...@us.ibm.com --- ipc/shm.c | 67 +-- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index 9790a0e..0dde176 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -269,32

[PATCH 3/3] shm: Remove unneeded extern for function

A small cleanup while changing adjacent code. Extern is not needed for functions and only one declaration had it so remove it from the odd line. Signed-off-by: Milton Miller milt...@bga.com Signed-off-by: Jack Miller mille...@us.ibm.com --- include/linux/shm.h | 2 +- 1 file changed, 1

Re: [RESEND] shm: shm exit scalability fixes

On Tue, Jun 17, 2014 at 10:48:32AM -0700, Davidlohr Bueso wrote: On Tue, 2014-06-17 at 12:27 -0500, Jack Miller wrote: [ RESEND note: Adding relevant CCs, fixed a couple of typos in commit message, patches unchanged. Original intro follows. ] All - This is small set of patches

shm: shm_exit scalability fixes

All - This is small set of patches our team has had kicking around for a few versions internally that fixes tasks getting hung on shm_exit when there are many threads hammering it at once. Anton wrote a simple test to cause the issue: http://ozlabs.org/~anton/junkcode/bust_shm_exit.c Before

[PATCH 3/3] shm: Remove unneeded extern for function

A small cleanup while changing adjacent code. Extern is not needed for functions and only one declaration had it so remove it from the odd line. Signed-off-by: Milton Miller Signed-off-by: Jack Miller --- include/linux/shm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/3] shm: Allow exit_shm in parallel if only marking orphans

-by: Jack Miller --- ipc/shm.c | 67 +-- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index 9790a0e..0dde176 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -269,32 +269,6 @@ static void shm_close(struct

[PATCH 1/3] shm: Make exit_shm work proportional to task activity

een the semaphore code and the task struct. Converting the list_del to list_del_init for the unshare cases would remove the exit followed by init, but I left it blow up if not inited. Signed-off-by: Milton Miller Signed-off-by: Jack Miller --- include/linux/sched.h | 2 ++ include/linux/sh

[PATCH 2/3] shm: Allow exit_shm in parallel if only marking orphans

Signed-off-by: Jack Miller mille...@us.ibm.com --- ipc/shm.c | 67 +-- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index 9790a0e..0dde176 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -269,32 +269,6

[PATCH 1/3] shm: Make exit_shm work proportional to task activity

the semaphore code and the task struct. Converting the list_del to list_del_init for the unshare cases would remove the exit followed by init, but I left it blow up if not inited. Signed-off-by: Milton Miller milt...@bga.com Signed-off-by: Jack Miller mille...@us.ibm.com --- include/linux/sched.h

[PATCH 3/3] shm: Remove unneeded extern for function

A small cleanup while changing adjacent code. Extern is not needed for functions and only one declaration had it so remove it from the odd line. Signed-off-by: Milton Miller milt...@bga.com Signed-off-by: Jack Miller mille...@us.ibm.com --- include/linux/shm.h | 2 +- 1 file changed, 1

shm: shm_exit scalability fixes

All - This is small set of patches our team has had kicking around for a few versions internally that fixes tasks getting hung on shm_exit when there are many threads hammering it at once. Anton wrote a simple test to cause the issue: http://ozlabs.org/~anton/junkcode/bust_shm_exit.c Before