)
if (ufshcd_any_tag_in_use() == 1)
return;
ufshcd_tmc_handler(hba);
blk_mq_tagset_busy_iter();
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs
From: Jaegeuk Kim
In order to conduct FFU or RPMB operations, UFS needs to clear UAC. This patch
clears it explicitly, so that we could get no failure given early execution.
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 70 +++
drivers/scsi/ufs
Change log from v2:
- use active_req-- instead of __ufshcd_release to avoid UFS timeout
Change log from v1:
- remove clkgating_enable check in __ufshcd_release
- use __uhfshcd_release instead of active_req.
From: Jaegeuk Kim
Must have WQ_MEM_RECLAIM
``WQ_MEM_RECLAIM``
All wq which might be used in the memory reclaim paths **MUST**
have this flag set. The wq is guaranteed to have at least one
execution context regardless of memory pressure.
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs
From: Jaegeuk Kim
When giving a stress test which enables/disables clkgating, we hit device
timeout sometimes. This patch avoids subtle racy condition to address it.
If we use __ufshcd_release(), I've seen that gate_work can be called in parallel
with ungate_work, which results in UFS timeout
On 10/21, Can Guo wrote:
> On 2020-10-21 12:52, jaeg...@kernel.org wrote:
> > On 10/21, Can Guo wrote:
> > > On 2020-10-21 03:52, Jaegeuk Kim wrote:
> > > > The below call stack prevents clk_gating at every IO completion.
> > > > We can remove the
)
if (ufshcd_any_tag_in_use() == 1)
return;
ufshcd_tmc_handler(hba);
blk_mq_tagset_busy_iter();
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Jaegeuk Kim
When giving a stress test which enables/disables clkgating, we hit device
timeout sometimes. This patch avoids subtle racy condition to address it.
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 12 ++--
1
From: Jaegeuk Kim
In order to conduct FFU or RPMB operations, UFS needs to clear UAC. This patch
clears it explicitly, so that we could get no failure given early execution.
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 70
From: Jaegeuk Kim
Must have WQ_MEM_RECLAIM
``WQ_MEM_RECLAIM``
All wq which might be used in the memory reclaim paths **MUST**
have this flag set. The wq is guaranteed to have at least one
execution context regardless of memory pressure.
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Change log from v1:
- remove clkgating_enable check in __ufshcd_release
- use __uhfshcd_release instead of active_req.
From: Jaegeuk Kim
This adds user-friendly tracepoints with group id.
Cc: Alim Akhtar
Cc: Avri Altman
Reviewed-by: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 6 --
include/trace/events/ufs.h | 21 +
2 files changed, 21 insertions(+), 6
)
if (ufshcd_any_tag_in_use() == 1)
return;
ufshcd_tmc_handler(hba);
blk_mq_tagset_busy_iter();
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
In 32bit system, 64-bits key breaks memory alignment.
This fixes the commit "f2fs: support 64-bits key in f2fs rb-tree node entry".
Reported-by: Nicolas Chauvet
Signed-off-by: Chao Yu
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletio
From: Jaegeuk Kim
In order to conduct FFU or RPMB operations, UFS needs to clear UAC. This patch
clears it explicitly, so that we could get no failure given early execution.
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 70
From: Jaegeuk Kim
This adds user-friendly tracepoints with group id.
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 6 --
include/trace/events/ufs.h | 21 +
2 files changed, 21 insertions(+), 6 deletions
From: Jaegeuk Kim
Must have WQ_MEM_RECLAIM
``WQ_MEM_RECLAIM``
All wq which might be used in the memory reclaim paths **MUST**
have this flag set. The wq is guaranteed to have at least one
execution context regardless of memory pressure.
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
From: Jaegeuk Kim
When giving a stress test which enables/disables clkgating, we hit device
timeout sometimes. This patch avoids subtle racy condition to address it.
Cc: Alim Akhtar
Cc: Avri Altman
Cc: Can Guo
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 12 ++--
1
Otherwise, f2fs can break the the consistency.
(e.g., BUG_ON in f2fs_get_sum_page)
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c | 9 +++--
fs/f2fs/f2fs.h | 2 --
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index
On 09/29, Chao Yu wrote:
> On 2020/9/29 17:15, Chao Yu wrote:
> > On 2020/9/29 16:47, Jaegeuk Kim wrote:
> > > On 09/29, Chao Yu wrote:
> > > > On 2020/9/29 16:23, Jaegeuk Kim wrote:
> > > > > I found a bug related to the number of page pointer allocat
On 09/29, Jaegeuk Kim wrote:
> On 09/29, Chao Yu wrote:
> > On 2020/9/29 16:23, Jaegeuk Kim wrote:
> > > I found a bug related to the number of page pointer allocation related to
> > > nr_cpages.
> >
> > Jaegeuk,
> >
> > If I didn't miss anythin
On 09/29, Chao Yu wrote:
> On 2020/9/29 16:23, Jaegeuk Kim wrote:
> > I found a bug related to the number of page pointer allocation related to
> > nr_cpages.
>
> Jaegeuk,
>
> If I didn't miss anything, you mean that nr_cpages could be larger
> than nr_rpages, ri
I found a bug related to the number of page pointer allocation related to
nr_cpages.
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index f086ac43ca825..3a18666725fef 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -20,22 +20,20 @@
static struct kmem_cache *cic_entry_slab;
On 09/26, Chao Yu wrote:
> On 2020-9-26 7:26, Jaegeuk Kim wrote:
> > On 09/25, Jaegeuk Kim wrote:
> > > This patch adds some missing contexts related to f2fs-tools in f2fs
> > > documentation.
> > >
> > > Signed-off-by: Jaegeuk Kim
> > &
I missed the f2fs mailing list by gitconfig. :)
On 09/23, Jaegeuk Kim wrote:
> This fixes the below mem leak.
>
> [ 130.157600]
> =
> [ 130.159662] BUG f2fs_page_array_entry-252:16 (Tainted
On 09/25, Jaegeuk Kim wrote:
> This patch adds some missing contexts related to f2fs-tools in f2fs
> documentation.
>
> Signed-off-by: Jaegeuk Kim
> ---
> Documentation/filesystems/f2fs.rst | 46 --
> 1 file changed, 44 insertions(+), 2 deletio
This patch adds some missing contexts related to f2fs-tools in f2fs
documentation.
Signed-off-by: Jaegeuk Kim
---
Documentation/filesystems/f2fs.rst | 46 --
1 file changed, 44 insertions(+), 2 deletions(-)
diff --git a/Documentation/filesystems/f2fs.rst
b
On 09/18, Chao Yu wrote:
> Compressed inode and normal inode has different layout, so we should
> disallow enabling compress on non-empty file to avoid race condition
> during inode .i_addr array parsing and updating.
>
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/file.c | 2 ++
> 1 file changed, 2
7/0xe0
[ 130.237898] __x64_sys_write+0x1a/0x20
[ 130.239309] do_syscall_64+0x38/0x90
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/compress.c | 2 +-
fs/f2fs/data.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 10a9f39
On 09/22, Eric Biggers wrote:
> On Tue, Sep 22, 2020 at 03:48:02AM -0700, Daniel Rosenberg wrote:
> > These patches are on top of the f2fs dev branch
> >
> > F2FS currently supports casefolding and encryption, but not at
> > the same time. These patches aim to rectify that. In a later follow up,
On 09/17, Can Guo wrote:
> On 2020-09-17 00:05, Jaegeuk Kim wrote:
> > On 09/16, Bean Huo wrote:
> > > On Tue, 2020-09-15 at 13:45 -0700, Jaegeuk Kim wrote:
> > > > Cc: Avri Altman
> > > > Signed-off-by: Jaegeuk Kim
> > > > ---
> >
Please ignore this patch.
Thanks.
On 09/15, Jaegeuk Kim wrote:
> From: Jaegeuk Kim
>
> When testing infinite test to read sysfs entries of UFS, I got a UFS timeout
> with the following kernel message.
>
> query: dev_cmd_send: seq_no=78082 tag=31, idn=2
> query: ufshcd_wait
On 09/16, Bean Huo wrote:
> On Tue, 2020-09-15 at 13:45 -0700, Jaegeuk Kim wrote:
> > Cc: Avri Altman
> > Signed-off-by: Jaegeuk Kim
> > ---
> > drivers/scsi/ufs/ufshcd.c | 8
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a
From: Jaegeuk Kim
In order to conduct FFU or RPMB operations, UFS needs to clear UAC. This patch
clears it explicitly, so that we could get no failure given early execution.
Cc: Alim Akhtar
Cc: Avri Altman
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 41
From: Jaegeuk Kim
Must have WQ_MEM_RECLAIM
``WQ_MEM_RECLAIM``
All wq which might be used in the memory reclaim paths **MUST**
have this flag set. The wq is guaranteed to have at least one
execution context regardless of memory pressure.
Cc: Alim Akhtar
Cc: Avri Altman
Signed-off
From: Jaegeuk Kim
When testing infinite test to read sysfs entries of UFS, I got a UFS timeout
with the following kernel message.
query: dev_cmd_send: seq_no=78082 tag=31, idn=2
query: ufshcd_wait_for_dev_cmd: dev_cmd request timedout, tag 31
query: __ufshcd_query_descriptor: opcode 0x01
From: Jaegeuk Kim
This patch shows ufs part info in kernel messages for debugging purpose.
It's useful when we only have the last kernel message.
Cc: Alim Akhtar
Cc: Avri Altman
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 8
1 file changed, 8 insertions(+)
diff
From: Jaegeuk Kim
When giving a stress test which enables/disables clkgating, we hit device
timeout sometimes. This patch avoids subtle racy condition to address it.
Cc: Alim Akhtar
Cc: Avri Altman
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 12 ++--
1 file changed, 6
From: Jaegeuk Kim
This adds user-friendly tracepoints with group id.
Cc: Alim Akhtar
Cc: Avri Altman
Signed-off-by: Jaegeuk Kim
---
drivers/scsi/ufs/ufshcd.c | 6 --
include/trace/events/ufs.h | 21 +
2 files changed, 21 insertions(+), 6 deletions(-)
diff --git
Hi Linus,
Could you please consider this pull reqeuest having some critical bug fixes?
Thanks,
The following changes since commit 34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8:
Merge tag 'linux-kselftest-5.9-rc5' of
git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest (2020-09-08
On 09/09, Chao Yu wrote:
> On 2020/9/9 10:36, Daeho Jeong wrote:
> > From: Daeho Jeong
> >
> > Made f2fs_vmap() wrapper to handle vm_map_ram() stuff.
> >
> > Signed-off-by: Daeho Jeong
>
> LGTM,
>
> I think it should be merged into original patch. :)
>
> Maybe Jaeguek could help to do that.
On 09/03, Daeho Jeong wrote:
> From: Daeho Jeong
>
> writepages() can be concurrently invoked for the same file by different
> threads such as a thread fsyncing the file and a kworker kernel thread.
> So, changing i_compr_blocks without protection is racy and we need to
> protect it by changing
f F2fs to F2FS for consistency.
> >
> > Signed-off-by: Randy Dunlap
> > Cc: Jaegeuk Kim
> > Cc: Chao Yu
> > Cc: linux-f2fs-de...@lists.sourceforge.net
> > ---
> > Documentation/filesystems/f2fs.rst | 53 +++
> > 1 file change
Hi Chao,
Applied. Thanks.
On 08/31, Chao Yu wrote:
> Hi Jaegeuk,
>
> I've changed code a bit to fix some bugs, including:
> - gc_idle = 3 (GC_IDLE_AT) description
> - disallow set gc_idle to 3 if atgc is off
> - keep compatibility with checkpoint disabling
>
> Could you please check and merge
Hi Chao,
I modified directly like below which makes fsck complain wrong free segment
number.
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 60d6b0795231a..a0d7a7e04bc70 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2728,9 +2728,6 @@ static void
On 08/24, Eric Biggers wrote:
> On Mon, Jul 27, 2020 at 09:45:08AM -0700, Eric Biggers wrote:
> > On Mon, Jul 20, 2020 at 10:09:51AM -0700, Eric Biggers wrote:
> > > On Wed, Jul 08, 2020 at 02:12:33AM -0700, Daniel Rosenberg wrote:
> > > > This lays the ground work for enabling casefolding and
ack Qiu (4):
f2fs: get the right gc victim section when section has several segments
f2fs: space related cleanup
f2fs: correct comment of f2fs_exist_written_data
f2fs: use macro instead of f2fs verity version
Jaegeuk Kim (5):
f2fs: avoid checkpatch error
f2fs: av
On 08/04, Chao Yu wrote:
> On 2020/8/4 10:44, Jaegeuk Kim wrote:
> > On 08/04, Chao Yu wrote:
> > > On 2020/7/25 16:42, Chao Yu wrote:
> > > > On 2020/7/16 9:24, Chao Yu wrote:
> > > > > On 2020/7/16 3:07, Jaegeuk Kim wrote:
> > > > >
On 08/04, Chao Yu wrote:
> On 2020/7/29 15:02, Jaegeuk Kim wrote:
> > f2fs_write_data_pages(quota_mapping)
> > __f2fs_write_data_pages f2fs_write_checkpoint
> >* blk_start_plug();
> >* add bio in write_io[DATA]
> >
On 08/04, Chao Yu wrote:
> On 2020/7/25 16:42, Chao Yu wrote:
> > On 2020/7/16 9:24, Chao Yu wrote:
> > > On 2020/7/16 3:07, Jaegeuk Kim wrote:
> > > > On 07/15, Chao Yu wrote:
> > > > > On 2020/7/7 11:51, Jaegeuk Kim wrote:
> > > > >
On 08/04, Chao Yu wrote:
> On 2020/8/4 9:04, Jaegeuk Kim wrote:
> > On 08/04, Chao Yu wrote:
> > > On 2020/8/4 1:28, Jaegeuk Kim wrote:
> > > > It doesn't need to wait for checkpoint being completed triggered by
> > > > end_io.
> > &g
On 08/04, Chao Yu wrote:
> On 2020/8/4 1:28, Jaegeuk Kim wrote:
> > It doesn't need to wait for checkpoint being completed triggered by end_io.
> >
> > [ 20.157753] [ cut here ]
> > [ 20.158393] do not call blocking ops when
d+0x11/0x20
[ 20.178975] ? finish_wait+0x260/0x260
[ 20.179488] ? percpu_counter_set+0x147/0x230
[ 20.180049] do_checkpoint+0x1757/0x2a50
[ 20.180558] f2fs_write_checkpoint+0x840/0xaf0
[ 20.181126] f2fs_sync_fs+0x287/0x4a0
Reported-by: Eric Biggers
Signed-off-by: Jaegeuk Kim
---
f
On 07/29, Chao Yu wrote:
> On 2020-7-29 15:02, Jaegeuk Kim wrote:
> > f2fs_write_data_pages(quota_mapping)
> > __f2fs_write_data_pages f2fs_write_checkpoint
> > * blk_start_plug();
> > * add bio in write_io[DATA]
> >
_write(node_write)
- f2fs_wait_on_all_pages(F2FS_WB_CP_DATA);
Signed-off-by: Daeho Jeong
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 8c782d3
On 07/07, Chao Yu wrote:
> Don't let f2fs inner GC ruins original aging degree of segment.
>
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/data.c| 2 +-
> fs/f2fs/f2fs.h| 5 +++--
> fs/f2fs/gc.c | 4 ++--
> fs/f2fs/segment.c | 55 ---
> 4
On 07/07, Chao Yu wrote:
> Previous implementation of aligned pinfile allocation will:
> - allocate new segment on cold data log no matter whether last used
> segment is partially used or not, it makes IOs more random;
> - force concurrent cold data/GCed IO going into warm data area, it
> can make
On 07/22, Greg KH wrote:
> On Wed, Jul 22, 2020 at 09:43:56AM -0700, Jaegeuk Kim wrote:
> > On 07/19, Greg KH wrote:
> > > On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrote:
> > > > From: Daeho Jeong
> > > >
> > > > Added
On 07/19, Greg KH wrote:
> On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrote:
> > From: Daeho Jeong
> >
> > Added a symbolic link directory pointing to its device name
> > directory using the volume name of the partition in sysfs.
> > (i.e., /sys/fs/f2fs/vol_#x -> /sys/fs/f2fs/sda1)
>
On 07/16, Chao Yu wrote:
> On 2020/7/16 3:10, Jaegeuk Kim wrote:
> > On 07/14, Chao Yu wrote:
> >> On 2020/7/14 1:59, Jaegeuk Kim wrote:
> >>> On 07/10, Chao Yu wrote:
> >>>> On 2020/7/10 11:50, Jaegeuk Kim wrote:
> >>>>> On 07/10
On 07/14, Chao Yu wrote:
> On 2020/7/14 1:59, Jaegeuk Kim wrote:
> > On 07/10, Chao Yu wrote:
> >> On 2020/7/10 11:50, Jaegeuk Kim wrote:
> >>> On 07/10, Chao Yu wrote:
> >>>> On 2020/7/10 11:26, Jaegeuk Kim wrote:
> >>>>> On 07/1
On 07/15, Chao Yu wrote:
> On 2020/7/7 11:51, Jaegeuk Kim wrote:
> > On 07/07, Chao Yu wrote:
> >> On 2020/7/7 11:21, Jaegeuk Kim wrote:
> >>> Hi Chao,
> >>>
> >>> Do you have any brief design doc to present the idea?
> >>
> >>
On 07/13, Nathan Royce wrote:
> On Mon, Jul 13, 2020 at 7:03 PM Jaegeuk Kim wrote:
> >
> > Hi Nathan,
> >
> > Could you try to say "N" here to move forward to fix the corrupted metadata?
> >
> > Thanks,
> *
> Do you want to restore los
Hi Nathan,
On 07/13, Nathan Royce wrote:
> I won't re-format unless I hear something within a few days in case
> you want me to try something.
>
> Preface: There was a notable power outage a couple of nights ago.
> When the power returned, everything seemed fine. No issues during
> bootup or
Hi Daeho,
Please take a look at this.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev=35245180459aebf6d70fde88a538f0400a794aa6
Thanks,
On 07/13, Daeho Jeong wrote:
> From: Daeho Jeong
>
> Changed the way of handling range.len of F2FS_IOC_SEC_TRIM_FILE.
> 1.
On 07/10, Chao Yu wrote:
> On 2020/7/10 11:50, Jaegeuk Kim wrote:
> > On 07/10, Chao Yu wrote:
> >> On 2020/7/10 11:26, Jaegeuk Kim wrote:
> >>> On 07/10, Chao Yu wrote:
> >>>> On 2020/7/10 3:05, Jaegeuk Kim wrote:
> >>>>> On 07/0
On 07/10, Chao Yu wrote:
> On 2020/7/10 11:50, Jaegeuk Kim wrote:
> > On 07/10, Chao Yu wrote:
> >> On 2020/7/10 11:26, Jaegeuk Kim wrote:
> >>> On 07/10, Chao Yu wrote:
> >>>> On 2020/7/10 3:05, Jaegeuk Kim wrote:
> >>>>> On 07/0
On 07/10, Chao Yu wrote:
> On 2020/7/10 11:52, Jaegeuk Kim wrote:
> > On 07/10, Chao Yu wrote:
> >> On 2020/7/10 11:31, Jaegeuk Kim wrote:
> >>> On 07/10, Chao Yu wrote:
> >>>> On 2020/7/10 11:02, Jaegeuk Kim wrote:
> >>>&
On 07/10, Chao Yu wrote:
> On 2020/7/10 11:31, Jaegeuk Kim wrote:
> > On 07/10, Chao Yu wrote:
> >> On 2020/7/10 11:02, Jaegeuk Kim wrote:
> >>> On 07/10, Daeho Jeong wrote:
> >>>> From: Daeho Jeong
> >>>>
> >>>> Changed t
On 07/10, Chao Yu wrote:
> On 2020/7/10 11:26, Jaegeuk Kim wrote:
> > On 07/10, Chao Yu wrote:
> >> On 2020/7/10 3:05, Jaegeuk Kim wrote:
> >>> On 07/09, Chao Yu wrote:
> >>>> On 2020/7/9 13:30, Jaegeuk Kim wrote:
> >>>>&
On 07/10, Chao Yu wrote:
> On 2020/7/10 11:02, Jaegeuk Kim wrote:
> > On 07/10, Daeho Jeong wrote:
> >> From: Daeho Jeong
> >>
> >> Changed the way of handling range.len of F2FS_IOC_SEC_TRIM_FILE.
> >> 1. Added -1 value support for range.len to
On 07/09, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 08:20:35PM -0700, Jaegeuk Kim wrote:
> > On 07/10, Daeho Jeong wrote:
> > > 1. The valid data will be within i_size.
> > > 2. All the trim operations will be done in a unit of block, even if
> > > i_s
On 07/10, Chao Yu wrote:
> On 2020/7/10 3:05, Jaegeuk Kim wrote:
> > On 07/09, Chao Yu wrote:
> >> On 2020/7/9 13:30, Jaegeuk Kim wrote:
> >>> It doesn't need to bypass flushing quota data in background.
> >>
> >> The condition is used to flush quot
Yes. Basically, I believe we can have some data beyond i_size like fsverity.
>
> 2020년 7월 10일 (금) 오후 12:02, Jaegeuk Kim 님이 작성:
> >
> > On 07/10, Daeho Jeong wrote:
> > > From: Daeho Jeong
> > >
> > > Changed the way of handling range.len of F2FS_IOC_S
On 07/10, Daeho Jeong wrote:
> From: Daeho Jeong
>
> Changed the way of handling range.len of F2FS_IOC_SEC_TRIM_FILE.
> 1. Added -1 value support for range.len to signify the end of file.
> 2. If the end of the range passes over the end of file, it means until
> the end of file.
> 3.
On 07/09, Chao Yu wrote:
> On 2020/7/9 13:30, Jaegeuk Kim wrote:
> > It doesn't need to bypass flushing quota data in background.
>
> The condition is used to flush quota data in batch to avoid random
> small-sized udpate, did you hit any problem here?
I suspect this causes fa
On 07/09, Chao Yu wrote:
> On 2020/7/9 9:57, Daeho Jeong wrote:
> > From: Daeho Jeong
> >
> > When end_addr comes to zero, it'll trigger different behaviour.
> > To prevent this, we need to ignore the case of that range.len is
> > zero in the function.
> >
> > Signed-off-by: Daeho Jeong
> >
It doesn't need to bypass flushing quota data in background.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 44645f4f914b6..72e8b50e588c1 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
tely apply to both.
>
> Signed-off-by: Daniel Rosenberg
> Reviewed-by: Eric Biggers
Acked-by: Jaegeuk Kim
> ---
> fs/f2fs/dir.c | 84 +
> fs/f2fs/f2fs.h | 4 --
> fs/f2fs/super.c | 10 ++---
> fs/f2fs/s
On 07/07, Chao Yu wrote:
> On 2020/7/7 11:21, Jaegeuk Kim wrote:
> > Hi Chao,
> >
> > Do you have any brief design doc to present the idea?
>
> Hi Jaegeuk,
>
> You mean this whole patchset, right?
>
> I can add a brief design description in patch 0/
Hi Chao,
Do you have any brief design doc to present the idea?
Thanks,
On 06/30, Chao Yu wrote:
> Previous implementation of aligned pinfile allocation will:
> - allocate new segment on cold data log no matter whether last used
> segment is partially used or not, it makes IOs more random;
> -
On 06/30, Chao Yu wrote:
> Previously, once we update one block in segment, we will update mtime of
> segment to last time, making aged segment becoming freshest, result in
> that GC with cost benefit algorithm missing such segment, So this patch
> changes to record mtime as average block updating
On 07/01, Wei Yongjun wrote:
> From: Hulk Robot
>
> From: Hulk Robot
>
> Fix sparse build warning:
>
> fs/f2fs/segment.c:2736:6: warning:
> symbol '__allocate_new_segment' was not declared. Should it be static?
It was fixed.
On 07/01, Chao Yu wrote:
> On 2020/7/1 9:59, Chao Yu wrote:
> > On 2020/7/1 4:56, Jaegeuk Kim wrote:
> >> On 06/30, Nathan Chancellor wrote:
> >>> On Mon, Jun 29, 2020 at 01:27:20PM -0700, Jaegeuk Kim wrote:
> >>>> If two readahead threads having same
>From 3634864095bd1aafbb60ff49dac7d13ce157b658 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Mon, 22 Jun 2020 23:01:05 -0700
Subject: [PATCH] f2fs: avoid readahead race condition
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
If two readah
On 07/01, Chao Yu wrote:
> Jaegeuk, could you please help to change __allocate_new_segment() to static
> in your tree?
Sure. :)
>
> On 2020/6/30 4:19, Jaegeuk Kim wrote:
> > On 06/22, Chao Yu wrote:
> >> to two independent functions:
> >> - f2fs_allocate_new_
On 06/30, Nathan Chancellor wrote:
> On Mon, Jun 29, 2020 at 01:27:20PM -0700, Jaegeuk Kim wrote:
> > If two readahead threads having same offset enter in readpages, every read
> > IOs are split and issued to the disk which giving lower bandwidth.
> >
> > This pat
On 06/29, Eric Biggers wrote:
> On Mon, Jun 29, 2020 at 08:03:23AM -0700, Jaegeuk Kim wrote:
> > If two readahead threads having same offset enter in readpages, every read
> > IOs are split and issued to the disk which giving lower bandwidth.
> >
> > This patch tries t
If two readahead threads having same offset enter in readpages, every read
IOs are split and issued to the disk which giving lower bandwidth.
This patch tries to avoid redundant readahead calls.
Signed-off-by: Jaegeuk Kim
---
v2:
- add missing code to bypass read
fs/f2fs/data.c | 18
If two readahead threads having same offset enter in readpages, every read
IOs are split and issued to the disk which giving lower bandwidth.
This patch tries to avoid redundant readahead calls.
Signed-off-by: Jaegeuk Kim
---
v3:
- use READ|WRITE_ONCE
v2:
- add missing code to bypass read
On 06/22, Chao Yu wrote:
> to two independent functions:
> - f2fs_allocate_new_segment() for specified type segment allocation
> - f2fs_allocate_new_segments() for all data type segments allocation
>
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/f2fs.h | 3 ++-
> fs/f2fs/file.c | 2 +-
>
On 06/18, Chao Yu wrote:
> - Add to account and show per-log dirty_seg, full_seg and valid_blocks
> in debugfs.
> - reformat printed info.
>
> TYPEsegnosecno zoneno dirty_seg full_seg valid_blk
> - COLD data: 1523 1523 1523 1 0
On 06/22, Chao Yu wrote:
> On 2020/6/22 0:38, Jaegeuk Kim wrote:
> > On 06/20, Chao Yu wrote:
> >> On 2020/6/20 6:47, Jaegeuk Kim wrote:
> >>> On 06/19, Chao Yu wrote:
> >>>> On 2020/6/19 13:49, Jaegeuk Kim wrote:
> >>>>> On 06/19, Cha
If two readahead threads having same offset enter in readpages, every read
IOs are split and issued to the disk which giving lower bandwidth.
This patch tries to avoid redundant readahead calls.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 15 +++
fs/f2fs/f2fs.h | 1 +
fs
On 06/20, Chao Yu wrote:
> On 2020/6/20 6:47, Jaegeuk Kim wrote:
> > On 06/19, Chao Yu wrote:
> >> On 2020/6/19 13:49, Jaegeuk Kim wrote:
> >>> On 06/19, Chao Yu wrote:
> >>>> Hi Jaegeuk,
> >>>>
> >>>> On 2020/6/19 7:59,
On 06/19, Chao Yu wrote:
> On 2020/6/19 13:49, Jaegeuk Kim wrote:
> > On 06/19, Chao Yu wrote:
> >> Hi Jaegeuk,
> >>
> >> On 2020/6/19 7:59, Jaegeuk Kim wrote:
> >>> Hi Chao,
> >>>
> >>> On 06/18, Chao Yu wrote:
> >>&
On 06/18, Chao Yu wrote:
> - to avoid race between checkpoint and quota file writeback, it
> just needs to hold read lock of node_write in writeback path.
> - node_write lock has covered all LFS data write paths, it's not
> necessary, we only need to hold node_write lock at write path of
> quota
On 06/19, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2020/6/19 7:59, Jaegeuk Kim wrote:
> > Hi Chao,
> >
> > On 06/18, Chao Yu wrote:
> >> to make page content stable for special device like raid.
> >
> > Could you elaborate the problem a bit?
On 06/19, Chao Yu wrote:
> There is one reserved special compression extension: '*', which
> could be set via 'compress_extension="*"' mount option to enable
> compression for all files.
Thank you for the patch. :)
>
> Signed-off-by: Chao Yu
> ---
> Documentation/filesystems/f2fs.rst | 2 ++
>
Hi Chao,
On 06/18, Chao Yu wrote:
> to make page content stable for special device like raid.
Could you elaborate the problem a bit?
>
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/dir.c | 2 ++
> fs/f2fs/extent_cache.c | 18 +-
> fs/f2fs/f2fs.h | 2 +-
>
201 - 300 of 4753 matches
Mail list logo
