[PATCH 11/25] tty: synclinkmp: Change return type to void

Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/synclinkmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/synclinkmp.c b/drivers

[PATCH 11/25] tty: synclinkmp: Change return type to void

Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/synclinkmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/synclinkmp.c b/drivers

[PATCH 12/25] tty: vt: Change return type to void

Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/vt/vt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt

[PATCH 06/25] tty: hvc: hvcs: Change return type to void

Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/hvc/hvcs.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/tty/hvc/hvcs.c b

[PATCH 12/25] tty: vt: Change return type to void

Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/vt/vt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt

[PATCH 06/25] tty: hvc: hvcs: Change return type to void

Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/hvc/hvcs.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/tty/hvc/hvcs.c b

Re: [PATCH] gitignore: add *.gcda files

2018-01-17 22:07 GMT+09:00 Peter Oberparleiter <ober...@linux.vnet.ibm.com>: > On 09.01.2018 06:17, Jaejoong Kim wrote: >> 2017-12-20 16:09 GMT+09:00 Jaejoong Kim <climbbb@gmail.com>: >>> Ignore the *.gcda files generated by gcov >>> >>> Si

Re: [PATCH] gitignore: add *.gcda files

2018-01-17 22:07 GMT+09:00 Peter Oberparleiter : > On 09.01.2018 06:17, Jaejoong Kim wrote: >> 2017-12-20 16:09 GMT+09:00 Jaejoong Kim : >>> Ignore the *.gcda files generated by gcov >>> >>> Signed-off-by: Jaejoong Kim >>> --- >>> .gitignore

Re: [PATCH] gitignore: add *.gcda files

Hi, Peter Could you check this patch? Thanks, Jaejoong 2017-12-20 16:09 GMT+09:00 Jaejoong Kim <climbbb@gmail.com>: > Ignore the *.gcda files generated by gcov > > Signed-off-by: Jaejoong Kim <climbbb@gmail.com> > --- > .gitignore | 1 + > 1 file changed,

Re: [PATCH] gitignore: add *.gcda files

Hi, Peter Could you check this patch? Thanks, Jaejoong 2017-12-20 16:09 GMT+09:00 Jaejoong Kim : > Ignore the *.gcda files generated by gcov > > Signed-off-by: Jaejoong Kim > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.g

[PATCH] gitignore: add *.gcda files

Ignore the *.gcda files generated by gcov Signed-off-by: Jaejoong Kim <climbbb@gmail.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 0c39aa2..580ef7c 100644 --- a/.gitignore +++ b/.gitignore @@ -39,6 +39,7 @@ Module.symvers *.dwo

[PATCH] gitignore: add *.gcda files

Ignore the *.gcda files generated by gcov Signed-off-by: Jaejoong Kim --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 0c39aa2..580ef7c 100644 --- a/.gitignore +++ b/.gitignore @@ -39,6 +39,7 @@ Module.symvers *.dwo *.su *.c.[012]*.* +*.gcda

Re: [PATCH] media: av7110: switch to useing timer_setup()

Hi, [PATCH] media: av7110: switch to useing timer_setup() ^^^ typo error. 2017-10-25 9:40 GMT+09:00 Dmitry Torokhov : > In preparation for unconditionally passing the struct timer_list pointer to > all timer

Re: [PATCH] media: av7110: switch to useing timer_setup()

Hi, [PATCH] media: av7110: switch to useing timer_setup() ^^^ typo error. 2017-10-25 9:40 GMT+09:00 Dmitry Torokhov : > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using

Re: [PATCH v2] HID: usbhid: fix out-of-bounds bug

Hi, To. Jiri, Alan, Could you please review this patch? To. Andey, Could you please test with this patch for KASAN OOB error? Thanks, jaejoong 2017-09-28 19:16 GMT+09:00 Jaejoong Kim <climbbb@gmail.com>: > The hid descriptor identifies the length and type of subordinate >

Re: [PATCH v2] HID: usbhid: fix out-of-bounds bug

Hi, To. Jiri, Alan, Could you please review this patch? To. Andey, Could you please test with this patch for KASAN OOB error? Thanks, jaejoong 2017-09-28 19:16 GMT+09:00 Jaejoong Kim : > The hid descriptor identifies the length and type of subordinate > descriptors for a

Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

Hi 2017-10-04 18:01 GMT+09:00 Johan Hovold : > A clean-up patch removing removing two redundant NULL-checks from the ^^ The word 'removing' was written twice. :) > console disconnect handler inadvertently also removed a third

Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect

Hi 2017-10-04 18:01 GMT+09:00 Johan Hovold : > A clean-up patch removing removing two redundant NULL-checks from the ^^ The word 'removing' was written twice. :) > console disconnect handler inadvertently also removed a third check. > This could

[PATCH v2] HID: usbhid: fix out-of-bounds bug

d.c:231 ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431 Reported-by: Andrey Konovalov <andreyk...@google.com> Signed-off-by: Jaejoong Kim <climbbb@gmail.com> --- Changes in v2: - write a new commit message because orginal version is wrong approach - add check hid descri

[PATCH v2] HID: usbhid: fix out-of-bounds bug

d.c:231 ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431 Reported-by: Andrey Konovalov Signed-off-by: Jaejoong Kim --- Changes in v2: - write a new commit message because orginal version is wrong approach - add check hid descriptor size - get proper value for bNumDescriptors as sugges

Re: [PATCH] HID: usbhid: fix out-of-bounds bug

2017-09-27 23:29 GMT+09:00 Alan Stern : > On Wed, 27 Sep 2017, Michel Hermier wrote: > >> Le 27 sept. 2017 07:42, "Alan Stern" a écrit : > >> > - for (n = 0; n < hdesc->bNumDescriptors; n++) >> > + num_descriptors = min_t(int,

Re: [PATCH] HID: usbhid: fix out-of-bounds bug

2017-09-27 23:29 GMT+09:00 Alan Stern : > On Wed, 27 Sep 2017, Michel Hermier wrote: > >> Le 27 sept. 2017 07:42, "Alan Stern" a écrit : > >> > - for (n = 0; n < hdesc->bNumDescriptors; n++) >> > + num_descriptors = min_t(int, hdesc->bNumDescriptors, >> > +

Re: [PATCH] HID: usbhid: fix out-of-bounds bug

Hi, Alan, Thanks for the review. 2017-09-26 23:18 GMT+09:00 Alan Stern <st...@rowland.harvard.edu>: > On Tue, 26 Sep 2017, Jaejoong Kim wrote: > >> The starting address of the hid descriptor is obtained via >> usb_get_extra_descriptor(). If the hid descr

Re: [PATCH] HID: usbhid: fix out-of-bounds bug

Hi, Alan, Thanks for the review. 2017-09-26 23:18 GMT+09:00 Alan Stern : > On Tue, 26 Sep 2017, Jaejoong Kim wrote: > >> The starting address of the hid descriptor is obtained via >> usb_get_extra_descriptor(). If the hid descriptor has the wrong size, it >> is poss

[PATCH] HID: usbhid: fix out-of-bounds bug

ko <gli...@google.com> Signed-off-by: Jaejoong Kim <climbbb@gmail.com> --- drivers/hid/usbhid/hid-core.c | 39 +++ include/linux/hid.h | 2 ++ 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/drivers/hid/usbhid/hid-core.

[PATCH] HID: usbhid: fix out-of-bounds bug

Potapenko Signed-off-by: Jaejoong Kim --- drivers/hid/usbhid/hid-core.c | 39 +++ include/linux/hid.h | 2 ++ 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 089bad8..7bad173

Re: usb/hid: slab-out-of-bounds read in usbhid_parse

Hi Alan 2017-09-21 0:50 GMT+09:00 Alan Stern : > On Wed, 20 Sep 2017, Kim Jaejoong wrote: > >> To. usb & input guys. >> >> While dig this report, i was wondering about bNumDescriptors in HID >> descriptor. >> HID document from usb.org said, 'this number must be at

Re: usb/hid: slab-out-of-bounds read in usbhid_parse

Hi Alan 2017-09-21 0:50 GMT+09:00 Alan Stern : > On Wed, 20 Sep 2017, Kim Jaejoong wrote: > >> To. usb & input guys. >> >> While dig this report, i was wondering about bNumDescriptors in HID >> descriptor. >> HID document from usb.org said, 'this number must be at least one (1) >> as a Report

[PATCH v2 2/2] HID: hiddev: reallocate hiddev's minor number

is always zero. To proper display hiddev's minor number, we need to store the minor number asked from usb core and do some refactoring work (move from hiddev.c to hiddev.h) to access hiddev in hid-core. Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Signed-off-by: Jaejoo

[PATCH v2 2/2] HID: hiddev: reallocate hiddev's minor number

is always zero. To proper display hiddev's minor number, we need to store the minor number asked from usb core and do some refactoring work (move from hiddev.c to hiddev.h) to access hiddev in hid-core. Reviewed-by: Benjamin Tissoires Signed-off-by: Jaejoong Kim --- Chanes in v2: - rollback struct

[PATCH v2 0/2] HID: hiddev: move hiddev's minor number and refactoring

Jaejoong Kim (2): HID: cp2112: use proper hidraw name with minor number HID: hiddev: reallocate hiddev's minor number drivers/hid/hid-core.c | 2 +- drivers/hid/hid-cp2112.c| 4 +++- drivers/hid/usbhid/hiddev.c | 15 --- include/linux/hid.h | 1 - include/linux

[PATCH v2 0/2] HID: hiddev: move hiddev's minor number and refactoring

Jaejoong Kim (2): HID: cp2112: use proper hidraw name with minor number HID: hiddev: reallocate hiddev's minor number drivers/hid/hid-core.c | 2 +- drivers/hid/hid-cp2112.c| 4 +++- drivers/hid/usbhid/hiddev.c | 15 --- include/linux/hid.h | 1 - include/linux

[PATCH v2 1/2] HID: cp2112: use proper hidraw name with minor number

The cp2112 driver is working on hidraw not hiddev. So we need to use proper hidraw name with hidraw's minor number. Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Signed-off-by: Jaejoong Kim <climbbb@gmail.com> --- Changes in v2: - tie in a series --- drivers/hi

[PATCH v2 1/2] HID: cp2112: use proper hidraw name with minor number

The cp2112 driver is working on hidraw not hiddev. So we need to use proper hidraw name with hidraw's minor number. Reviewed-by: Benjamin Tissoires Signed-off-by: Jaejoong Kim --- Changes in v2: - tie in a series --- drivers/hid/hid-cp2112.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 0/2] HID: hiddev: move hiddev's minor number and refactoring

hidraw if it neeeded. So, I move the minor number from hid_device to hiddev and do some refactoring to access struct hiddev in hid-core Jaejoong Kim (2): HID: hiddev: move hiddev's minor number from struct hid_device to hiddev HID: hiddev: store hiddev's minor number when hiddev is connected

[PATCH 0/2] HID: hiddev: move hiddev's minor number and refactoring

hidraw if it neeeded. So, I move the minor number from hid_device to hiddev and do some refactoring to access struct hiddev in hid-core Jaejoong Kim (2): HID: hiddev: move hiddev's minor number from struct hid_device to hiddev HID: hiddev: store hiddev's minor number when hiddev is connected

[PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

We need to store the minor number each drivers. In case of hidraw, it's minor number stores in struct hidraw. But hiddev's minor is located in struct hid_device. So reallocates for hiddev's minor number. Signed-off-by: Jaejoong Kim <climbbb@gmail.com> --- drivers/hid/usbhid/hiddev

[PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

We need to store the minor number each drivers. In case of hidraw, it's minor number stores in struct hidraw. But hiddev's minor is located in struct hid_device. So reallocates for hiddev's minor number. Signed-off-by: Jaejoong Kim --- drivers/hid/usbhid/hiddev.c | 1 + include/linux/hid.h

[PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected

-core. Signed-off-by: Jaejoong Kim <climbbb@gmail.com> --- drivers/hid/hid-core.c | 2 +- drivers/hid/usbhid/hiddev.c | 26 +++--- include/linux/hiddev.h | 24 3 files changed, 28 insertions(+), 24 deletions(-) diff --git a/drivers/h

[PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected

-core. Signed-off-by: Jaejoong Kim --- drivers/hid/hid-core.c | 2 +- drivers/hid/usbhid/hiddev.c | 26 +++--- include/linux/hiddev.h | 24 3 files changed, 28 insertions(+), 24 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid