Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 21:41:06 +0300 Radu Pirea (NXP OSS) wrote: > Add driver for tja1103 driver and for future NXP C45 PHYs. > > Signed-off-by: Radu Pirea (NXP OSS) drivers/net/phy/nxp-c45: struct mdio_device_id is 8 bytes. The last of 1 is: 0x10 0xb0 0x1b 0x00 0xf0 0xff 0xff 0xff FATAL: modpos

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > Co-developed-by: Jesper Dangaard Brouer > > > Co-developed-by: Matteo Croce

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > Co-developed-by: Jesper Dangaard Brouer > Co-developed-by: Matteo Croce > Signed-off-by: Ilias Apalodimas Checkpatch says we need sign-offs from all authors. Especially you since you're posting.

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote: > From: Matteo Croce > > use the new helper macro skb_for_each_frag() which allows to iterate > through all the SKB fragments. > > The patch was created with Coccinelle, this was the semantic patch: Bunch of set but not used warnings here.

Re: [PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 17:07:08 +0800 Joakim Zhang wrote: > This patch set adds new properties for of_get_mac_address from nvmem. Apart from addressing Rob's (and potentially other comments to come) please also make sure to rebase before posting. This series doesn't seem to apply to net-next.

Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 20:01:14 +0300 Vadym Kochan wrote: > On Fri, Apr 09, 2021 at 09:51:13AM -0700, Samudrala, Sridhar wrote: > > On 4/9/2021 9:22 AM, Oleksandr Mazur wrote: > > > I'd like to discuss a possibility of handling devlink port parameters > > > with devlink port pointer supplied. > > >

Re: [RFC net-next 1/1] seg6: add counters support for SRv6 Behaviors

2021-04-07 Thread Jakub Kicinski
On Wed, 7 Apr 2021 20:03:32 +0200 Andrea Mayer wrote: > This patch provides counters for SRv6 Behaviors as defined in [1], section > 6. For each SRv6 Behavior instance, the counters defined in [1] are: > > - the total number of packets that have been correctly processed; > - the total amount of

Re: [igb] netconsole triggers warning in netpoll_poll_dev

2021-04-07 Thread Jakub Kicinski
On Wed, 7 Apr 2021 09:25:28 -0700 Alexander Duyck wrote: > On Wed, Apr 7, 2021 at 8:37 AM Jakub Kicinski wrote: > > > > On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote: > > > Thanks for the effort, but reportedly [1] it made no difference, > > > unf

Re: [igb] netconsole triggers warning in netpoll_poll_dev

2021-04-07 Thread Jakub Kicinski
On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote: > Thanks for the effort, but reportedly [1] it made no difference, > unfortunately. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=212573#c8 The only other option I see is that somehow the NAPI has no rings. diff --git a/drivers/n

Re: [PATCH net v1 1/1] ethtool: fix incorrect datatype in set_eee ops

2021-04-06 Thread Jakub Kicinski
uest") > Cc: # 5.10.x > Cc: Michal Kubecek > Signed-off-by: Wong Vee Khee Reviewed-by: Jakub Kicinski

Re: [igb] netconsole triggers warning in netpoll_poll_dev

2021-04-06 Thread Jakub Kicinski
On Tue, 6 Apr 2021 14:36:19 +0200 Oleksandr Natalenko wrote: > Hello. > > I've raised this here [1] first, but was suggested to engage igb devs, > so here we are. > > I'm experiencing the following woes while using netconsole regularly: > > ``` > [22038.710800] [ cut here ]--

Re: [PATCH net-next] netdevsim: remove unneeded semicolon

2021-04-06 Thread Jakub Kicinski
On Tue, 6 Apr 2021 11:18:13 +0800 Qiheng Lin wrote: > Eliminate the following coccicheck warning: > drivers/net/netdevsim/fib.c:569:2-3: Unneeded semicolon > > Signed-off-by: Qiheng Lin Acked-by: Jakub Kicinski

Re: [PATCH net-next v3 5/6] net: stmmac: Add support for XDP_TX action

2021-03-31 Thread Jakub Kicinski
ic packet generated using pktgen script > 'pktgen_sample03_burst_single_flow.sh'. > > v3: Added 'nq->trans_start = jiffies' to avoid TX time-out as we are > sharing TX queue between slow path and XDP. Thanks to Jakub Kicinski > for p

Re: [PATCH net-next v2 5/6] net: stmmac: Add support for XDP_TX action

2021-03-30 Thread Jakub Kicinski
On Tue, 30 Mar 2021 10:49:48 +0800 Ong Boon Leong wrote: > + __netif_tx_lock(nq, cpu); > + res = stmmac_xdp_xmit_xdpf(priv, queue, xdpf); > + if (res == STMMAC_XDP_TX) { > + stmmac_flush_tx_descriptors(priv, queue); > + stmmac_tx_timer_arm(priv, queue); > + }

Re: [PATCH net-next v2 4/6] net: stmmac: Add initial XDP support

2021-03-30 Thread Jakub Kicinski
On Tue, 30 Mar 2021 10:49:47 +0800 Ong Boon Leong wrote: > + if (!skb) { > + dma_sync_single_for_cpu(priv->device, buf->addr, > + buf1_len, dma_dir); > + > + xdp.data = page_address(buf->page) + buf->pag

Re: [PATCH] ethernet/netronome/nfp: Fix a use after free in nfp_bpf_ctrl_msg_rx

2021-03-29 Thread Jakub Kicinski
was freed. > > Fixes: bcf0cafab44fd ("nfp: split out common control message handling code") > Signed-off-by: Lv Yunlong Reviewed-by: Jakub Kicinski

Re: [PATCH 2/2] gpiolib: Allow drivers to return EOPNOTSUPP from config

2021-03-29 Thread Jakub Kicinski
> > can avoid one of the checkpatch complaints. > > > > > > Internally we are fine to use the ENOTSUPP. > > > Checkpatch false positives there. > > > > > > I doubt we need this change. Rather checkpatch should rephrase this to > > > point

Re: [PATCH net-next v2 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support

2021-03-17 Thread Jakub Kicinski
et per-queue coalesce setting:- > $ ethtool --per-queue queue_mask --coalesce \ > [rx-usecs N] [rx-frames M] [tx-usecs P] [tx-frames Q] > > Signed-off-by: Ong Boon Leong Acked-by: Jakub Kicinski > + if (queue < tx_cnt) { > + ec->tx_coalesce_usecs = p

Re: [net PATCH 4/9] octeontx2-af: Remove TOS field from MKEX TX

2021-03-17 Thread Jakub Kicinski
On Wed, 17 Mar 2021 12:07:12 +0530 sundeep subbaraya wrote: > On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski wrote: > > > > On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote: > > > From: Subbaraya Sundeep > > > > > > TOS overlaps with DMAC fie

Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 05:42:37 -0700 Jarvis Jiang wrote: > drivers/bus/mhi/devices/mhi_netdev.c | 1830 + There's already a drivers/net/mhi/ Please make sure the drivers live in their respective subsystem. Virtio drivers don't sit under drivers/virtio, and most certainly not u

Re: [RESEND v1 net-next 4/5] stmmac: intel: add support for multi-vector msi and msi-x

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 20:18:22 +0800 Voon Weifeng wrote: > From: Ong Boon Leong > > Intel mgbe controller supports multi-vector interrupts: > msi_rx_vec0,2,4,6,8,10,12,14 > msi_tx_vec1,3,5,7,9,11,13,15 > msi_sfty_ue_vec 26 > msi_sfty_ce_vec 27 > msi_lpi_vec 28 > msi_mac_vec

Re: [RESEND v1 net-next 3/5] net: stmmac: introduce MSI Interrupt routines for mac, safety, RX & TX

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 20:18:21 +0800 Voon Weifeng wrote: > From: Ong Boon Leong > > Now we introduce MSI interrupt service routines and hook these routines > up if stmmac_open() sees valid irq line being requested:- > > stmmac_mac_interrupt():- MAC (dev->irq), WOL (wol_irq), LPI (lpi_irq) > st

Re: [RESEND v1 net-next 2/5] net: stmmac: make stmmac_interrupt() function more friendly to MSI

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 20:18:20 +0800 Voon Weifeng wrote: > + if (unlikely(!dev)) { > + netdev_err(priv->dev, "%s: invalid dev pointer\n", __func__); > + return IRQ_NONE; > + } Where did this check come from? Please avoid defensive programming in the kernel unless you

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-16 Thread Jakub Kicinski
On Mon, 15 Mar 2021 23:28:08 -0700 Arjun Roy wrote: > On Mon, Mar 15, 2021 at 11:22 PM Arjun Roy wrote: > > > > On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt wrote: > > > > > > On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy wrote: > [...] > > > [...] > [...] > [...] > > > > > > It is du

Re: [PATCH] net: ipv4: route.c: simplify procfs code

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 10:57:36 +0800 Yejune Deng wrote: > proc_creat_seq() that directly take a struct seq_operations, > and deal with network namespaces in ->open. > > Signed-off-by: Yejune Deng Looks equivalent to me: Reviewed-by: Jakub Kicinski

Re: [net PATCH 3/9] octeontx2-af: Do not allocate memory for devlink private

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 23:33:40 +0530 sundeep subbaraya wrote: > On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski wrote: > > > > On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote: > > > From: Subbaraya Sundeep > > > > > > Memory for driver p

Re: [net PATCH 4/9] octeontx2-af: Remove TOS field from MKEX TX

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote: > From: Subbaraya Sundeep > > TOS overlaps with DMAC field in mcam search key and hence installing > rules for TX side are failing. Hence remove TOS field from TX profile. Could you clarify what "installing rules is failing" means? Retur

Re: [net PATCH 3/9] octeontx2-af: Do not allocate memory for devlink private

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote: > From: Subbaraya Sundeep > > Memory for driver private structure rvu_devlink is > also allocated during devlink_alloc. Hence use > the allocated memory by devlink_alloc and access it > by devlink_priv call. > > Fixes: fae06da4("octeontx

Re: [net PATCH 1/9] octeontx2-pf: Do not modify number of rules

2021-03-16 Thread Jakub Kicinski
On Tue, 16 Mar 2021 14:57:05 +0530 Hariprasad Kelam wrote: > From: Subbaraya Sundeep > > In the ETHTOOL_GRXCLSRLALL ioctl ethtool uses > below structure to read number of rules from the driver. > > struct ethtool_rxnfc { > __u32 cmd; > __u32

Re: [PATCH net-next 1/2] net: stmmac: EST interrupts handling and error reporting

2021-03-15 Thread Jakub Kicinski
On Tue, 16 Mar 2021 06:14:08 +0800 mohammad.athari.ism...@intel.com wrote: > From: Voon Weifeng > > Enabled EST related interrupts as below: > 1) Constant Gate Control Error (CGCE) > 2) Head-of-Line Blocking due to Scheduling (HLBS) > 3) Head-of-Line Blocking due to Frame Size (HLBF). > 4) Base T

Re: [PATCH net-next 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support

2021-03-15 Thread Jakub Kicinski
On Mon, 15 Mar 2021 14:44:48 +0800 Ong Boon Leong wrote: > Extending the driver to support per-queue RX and TX coalesce settings in > order to support below commands: > > To show per-queue coalesce setting:- > $ ethtool --per-queue queue_mask --show-coalesce > > To set per-queue coalesce setti

Re: [PATCH v2 net-next] net: dsa: b53: mmap: Add device tree support

2021-03-15 Thread Jakub Kicinski
On Mon, 15 Mar 2021 16:11:40 +0100 Álvaro Fernández Rojas wrote: > Add device tree support to b53_mmap.c while keeping platform devices support. > > Signed-off-by: Álvaro Fernández Rojas > --- > v2: add change suggested by Florian Fainelli (less "OF-centric") and replace > brcm,ports property

Re: [PATCH v3 net-next 4/6] linux/etherdevice.h: misc trailing whitespace cleanup

2021-03-15 Thread Jakub Kicinski
On Mon, 15 Mar 2021 09:38:57 + Alexander Lobakin wrote: > From: Vladimir Oltean > Date: Sun, 14 Mar 2021 23:04:53 +0200 > > > On Sun, Mar 14, 2021 at 11:11:32AM +, Alexander Lobakin wrote: > > > Caught by the text editor. Fix it separately from the actual changes. > > > > > > Signed-off

Re: [RFC v2] net: sched: implement TCQ_F_CAN_BYPASS for lockless qdisc

2021-03-15 Thread Jakub Kicinski
On Mon, 15 Mar 2021 11:10:18 +0800 Yunsheng Lin wrote: > @@ -606,6 +623,11 @@ static const u8 prio2band[TC_PRIO_MAX + 1] = { > */ > struct pfifo_fast_priv { > struct skb_array q[PFIFO_FAST_BANDS]; > + > + /* protect against data race between enqueue/dequeue and > + * qdisc->empty

Re: [PATCH] Net: gtp: Fixed missing blank line after declaration

2021-03-15 Thread Jakub Kicinski
On Sat, 13 Mar 2021 22:21:28 +0530 Chinmayi Shetty wrote: > Signed-off-by: Chinmayi Shetty > --- > drivers/net/gtp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c > index efe5247d8c42..79998f4394e5 100644 > --- a/drivers/net/gtp.c

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-15 Thread Jakub Kicinski
ger to collaborate on the fairly simple > integration. Nacked-by: Jakub Kicinski Please move on.

Re: [PATCH v15 0/4] Adding the Sparx5 Serdes driver

2021-03-15 Thread Jakub Kicinski
On Mon, 15 Mar 2021 16:04:24 +0100 Steen Hegelund wrote: > Hi Kishon, Vinod, Andrew, Jacub, and David, > > I just wanted to know if you think that the Generic PHY subsystem might > not be the right place for this Ethernet SerDes PHY driver after all. > > Originally I chose this subsystem for his

Re: [PATCH net] net: lapbether: Prevent racing when checking whether the netif is running

2021-03-11 Thread Jakub Kicinski
On Thu, 11 Mar 2021 16:28:47 -0800 Xie He wrote: > On Thu, Mar 11, 2021 at 4:10 PM Jakub Kicinski wrote: > > > > And the "noqueue" queue is there because it's on top of hdlc_fr.c > > somehow or some out of tree driver? Or do you install it manually? &g

Re: [PATCH net] net: lapbether: Prevent racing when checking whether the netif is running

2021-03-11 Thread Jakub Kicinski
On Thu, 11 Mar 2021 15:13:01 -0800 Xie He wrote: > On Thu, Mar 11, 2021 at 2:52 PM Jakub Kicinski wrote: > > > > Normally driver's ndo_stop() calls netif_tx_disable() which takes TX > > locks, so unless your driver is lockless (LLTX) there should be no xmit > > c

Re: [PATCH net] net: lapbether: Prevent racing when checking whether the netif is running

2021-03-11 Thread Jakub Kicinski
On Thu, 11 Mar 2021 13:12:25 -0800 Xie He wrote: > On Thu, Mar 11, 2021 at 12:43 PM Jakub Kicinski wrote: > > > > Is this a theoretical issues or do you see a path where it triggers? > > > > Who are the callers sending frames to a device which went down? > &g

Re: [PATCH net] net: lapbether: Prevent racing when checking whether the netif is running

2021-03-11 Thread Jakub Kicinski
On Wed, 10 Mar 2021 23:23:09 -0800 Xie He wrote: > There are two "netif_running" checks in this driver. One is in > "lapbeth_xmit" and the other is in "lapbeth_rcv". They serve to make > sure that the LAPB APIs called in these functions are called before > "lapb_unregister" is called by the "ndo_st

Re: [PATCH v2] netdevsim: fib: Remove redundant code

2021-03-11 Thread Jakub Kicinski
On Thu, 11 Mar 2021 15:11:01 +0800 Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/net/netdevsim/fib.c:874:5-8: Unneeded variable: "err". Return > "0" on line 889. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Reviewed-by: Jakub Kicinski

Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-11 Thread Jakub Kicinski
On Thu, 11 Mar 2021 18:43:27 +0200 stef...@marvell.com wrote: > According to Armada SoC architecture and design, all the PPv2 ports > which are populated on the same communication processor silicon die > (CP11x) share the same Classifier and Parser engines. > > Armada is an embedded platform and t

Re: [PATCH net-next] net: phy: Expose phydev::dev_flags through sysfs

2021-03-10 Thread Jakub Kicinski
On Wed, 10 Mar 2021 14:12:43 -0800 Florian Fainelli wrote: > phydev::dev_flags contains a bitmask of configuration bits requested by > the consumer of a PHY device (Ethernet MAC or switch) towards the PHY > driver. Since these flags are often used for requesting LED or other > type of configuration

Re: [PATCH v2] bus: mhi: Add Qcom WWAN control driver

2021-03-08 Thread Jakub Kicinski
On Mon, 8 Mar 2021 21:59:27 +0100 Loic Poulain wrote: > --- > v2: update copyright (2021) Please look again at my reply to your v1.

Re: [PATCH 2/2] net: mdio: Add BCM6368 MDIO mux bus controller

2021-03-08 Thread Jakub Kicinski
On Mon, 8 Mar 2021 19:41:02 +0100 Álvaro Fernández Rojas wrote: > This controller is present on BCM6318, BCM6328, BCM6362, BCM6368 and BCM63268 > SoCs. > > Signed-off-by: Álvaro Fernández Rojas make[2]: *** Deleting file 'Module.symvers' ERROR: modpost: missing MODULE_LICENSE() in drivers/net/m

Re: [PATCH] bus: mhi: Add Qcom WWAN control driver

2021-03-08 Thread Jakub Kicinski
On Mon, 8 Mar 2021 19:40:51 +0100 Loic Poulain wrote: > The MHI WWWAN control driver allows MHI Qcom based modems to expose > different modem control protocols to userspace, so that userspace > modem tools or daemon (e.g. ModemManager) can control WWAN config > and state (APN config, SMS, provider

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-05 Thread Jakub Kicinski
On Fri, 5 Mar 2021 11:07:08 -0800 Don Bollinger wrote: > Acknowledging your objections, I nonetheless request that optoe be accepted > into upstream as an eeprom driver in drivers/misc/eeprom. It is a > legitimate driver, with a legitimate user community, which deserves the > benefits of being man

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-03-03 Thread Jakub Kicinski
On Tue, 02 Mar 2021 08:04:20 +0100 Martin Schiller wrote: > On 2021-03-01 09:56, Xie He wrote: > > On Sun, Feb 28, 2021 at 10:56 PM Martin Schiller wrote: > >> I mean the change from only one hdlc interface to both hdlc and > >> hdlc_x25. > >> > >> I can't estimate how many users are out there

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-03-03 Thread Jakub Kicinski
On Tue, 2 Mar 2021 12:55:47 +0100 Dmitry Vyukov wrote: > On Tue, Mar 2, 2021 at 10:06 AM Hillf Danton wrote: > > On Mar 2, 2021 at 16:40 Dmitry Vyukov wrote: > > >I hoped this would get at least into 5.12. syzbot can't start testing > > >arm32 because of this. FWIW the submission never got in

Re: [PATCH 01/11] pragma once: delete include/linux/atm_suni.h

2021-02-28 Thread Jakub Kicinski
On Sun, 28 Feb 2021 19:58:17 +0300 Alexey Dobriyan wrote: > From c17ac63e1334c742686cd411736699c1d34d45a7 Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan > Date: Wed, 10 Feb 2021 21:07:45 +0300 > Subject: [PATCH 01/11] pragma once: delete include/linux/atm_suni.h > > This file has been empty sin

Re: [PATCH v3] net/core/skbuff: fix passing wrong size to __alloc_skb

2021-02-28 Thread Jakub Kicinski
On Sun, 28 Feb 2021 18:14:46 + Alexander Lobakin wrote: > > [1] WARNING in __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5014 > > Call Trace: > > __alloc_pages include/linux/gfp.h:511 [inline] > > __alloc_pages_node include/linux/gfp.h:524 [inline] > > alloc_pages_node include/linux/gfp

Re: [PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 15:44:42 +0800 Huazhong Tan wrote: > From: Guangbin Huang > > If phy uses generic driver and autoneg is on, enter command > "ethtool -s eth0 speed 50" will not change phy speed actually, but > command "ethtool eth0" shows speed is 50Mb/s because phydev->speed > has been set to

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-26 Thread Jakub Kicinski
On Fri, 26 Feb 2021 07:23:31 -0800 Richard Cochran wrote: > On Thu, Feb 25, 2021 at 10:15:16PM +0100, Heiko Thiery wrote: > > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > > This is only the case when the interface is down. This can be reproduced > > by reading with 'phc

Re: [PATCH] net: phy: make mdio_bus_phy_suspend/resume as __maybe_unused

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 23:53:20 +0100 Andrew Lunn wrote: > On Thu, Feb 25, 2021 at 03:57:27PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_PM_SLEEP is disabled, the compiler warns about unused > > functions: > > > > drivers/net/phy/phy_device.c:273:12: error: unused funct

Re: [PATCH 1/3] net: mscc: ocelot: select NET_DEVLINK

2021-02-26 Thread Jakub Kicinski
On Thu, 25 Feb 2021 15:38:31 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Without this option, the driver fails to link: > > ld.lld: error: undefined symbol: devlink_sb_register > [...] > > Fixes: f59fd9cab730 ("net: mscc: ocelot: configure watermarks using > devlink-sb") > Signed-o

Re: [PATCH] mt7601u: fix always true expression

2021-02-25 Thread Jakub Kicinski
) > Fixes: c869f77d6abb ("add mt7601u driver") > Signed-off-by: Colin Ian King Acked-by: Jakub Kicinski Thanks for the fix!

[GIT PULL] Networking for 5.12-rc1

2021-02-25 Thread Jakub Kicinski
a_eth: fix the access method for the dpaa_napi_portal Signed-off-by: Jakub Kicinski Antonio Quartulli (1): wireguard: avoid double unlikely() notation when using IS_ERR() Brett Creeley (2): ice: Set trusted VF as defaul

Re: [PATCH net] net: hsr: add support for EntryForgetTime

2021-02-25 Thread Jakub Kicinski
On Wed, 24 Feb 2021 14:55:17 +0100 Andrew Lunn wrote: > On Wed, Feb 24, 2021 at 10:46:49AM +0100, Marco Wenzel wrote: > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a > > node does not send any frame within this time, the sequence number check > > for can be ignored. Thi

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-24 Thread Jakub Kicinski
On Thu, 25 Feb 2021 08:21:01 +0800 Coiby Xu wrote: > On Wed, Feb 24, 2021 at 08:48:41AM -0800, Jakub Kicinski wrote: > >On Wed, 24 Feb 2021 19:41:41 +0800 Coiby Xu wrote: > >> I'm not sure if I understand you correctly. Do you mean we shouldn't > >> disable

Re: [PATCH] net: bridge: Fix jump_label config

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 23:38:03 +0800 Kefeng Wang wrote: > HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move > 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead > of HAVE_JUMP_LABLE. > > Fixes: 971502d77faa ("bridge: netfilter: unroll NF_HOOK helper in bridge > i

Re: [PATCH] ipv6: Honor route mtu if it is within limit of dev mtu

2021-02-24 Thread Jakub Kicinski
On Mon, 22 Feb 2021 22:02:35 +0530 Kaustubh Pandey wrote: > When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised. > > addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route -> > fib6_nh_mtu_change > > As part of handling NETDEV_CHANGEMTU notification we land up on a > conditio

Re: [PATCH net-next v3 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 01:32:50 +0530 Sharath Chandra Vurukala wrote: > +/* MAP CSUM headers */ > +struct rmnet_map_v5_csum_header { > +#if defined(__LITTLE_ENDIAN_BITFIELD) > + u8 next_hdr:1; > + u8 header_type:7; > + u8 hw_reserved:7; > + u8 csum_valid_required:1; > +#elif define

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-24 Thread Jakub Kicinski
On Wed, 24 Feb 2021 19:41:41 +0800 Coiby Xu wrote: > On Tue, Feb 23, 2021 at 12:22:07PM -0800, Jakub Kicinski wrote: > >On Mon, 22 Feb 2021 15:07:01 +0800 Coiby Xu wrote: > >> i40iw consumes huge amounts of memory. For example, on a x86_64 machine, > >> i40iw consumed

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

2021-02-23 Thread Jakub Kicinski
On Tue, 23 Feb 2021 19:26:26 -0500 Alexander Aring wrote: > Hi, > > On Tue, 23 Feb 2021 at 18:48, Jakub Kicinski wrote: > > > > Alex, there seems to be a few more syzbot reports for nl802154 beyond > > what you posted fixes for. Are you looking at these? > >

Re: [PATCHSET] making unix_bind() undo mknod on failure

2021-02-23 Thread Jakub Kicinski
preparation to that > and #8/8 is a minor followup cleanup. Individual patches in followups. Dave is out this week, but this looks good to me. You said "please review" - I'm assuming you'll send these to Linus yourself, so: Acked-by: Jakub Kicinski

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

2021-02-23 Thread Jakub Kicinski
Alex, there seems to be a few more syzbot reports for nl802154 beyond what you posted fixes for. Are you looking at these? On Mon, 22 Feb 2021 00:05:29 -0800 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:3af409ca net: enetc: fix destroyed phylink dereference

Re: [PATCH net-next v2] net: dsa: mt7530: support MDB operations

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 18:07:17 +0800 DENG Qingfang wrote: > Support port MDB add to/delete from MT7530 ARL. > > As the hardware can manage multicast forwarding itself, trapping > multicast traffic to the CPU is no longer required. > > Signed-off-by: DENG Qingfang # Form letter - net-next is close

Re: [PATCH] ibmveth: Switch to using the new API kobj_to_dev()

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 16:02:21 +0800 Yang Li wrote: > fixed the following coccicheck: > ./drivers/net/ethernet/ibm/ibmveth.c:1805:51-52: WARNING opportunity for > kobj_to_dev() > > Reported-by: Abaci Robot > Signed-off-by: Yang Li # Form letter - net-next is closed We have already sent the netwo

Re: [PATCH net] atl1c: switch to napi_gro_receive

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 09:40:45 +0800 Sieng Piaw Liew wrote: > Changing to napi_gro_receive() improves efficiency significantly. Tested > on Intel Core2-based motherboards and iperf3. > > Signed-off-by: Sieng Piaw Liew net-next is currently closed (see the note below). Would you mind resending this

Re: [PATCH v4 net-next] net: socket: use BIT() for MSG_*

2021-02-23 Thread Jakub Kicinski
On Wed, 17 Feb 2021 14:54:27 +0800 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Signed-off-by: Menglong Dong # Form letter - net-next is closed We have already sent th

Re: [PATCH net v2 0/2] net: dsa: Learning fixes for b53/bcm_sf2

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 14:30:08 -0800 Florian Fainelli wrote: > This patch series contains a couple of fixes for the b53/bcm_sf2 drivers > with respect to configuring learning. > > The first patch is wiring-up the necessary dsa_switch_ops operations in > order to support the offloading of bridge flag

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 15:07:01 +0800 Coiby Xu wrote: > i40iw consumes huge amounts of memory. For example, on a x86_64 machine, > i40iw consumed 1.5GB for Intel Corporation Ethernet Connection X722 for > for 1GbE while "craskernel=auto" only reserved 160M. With the module > parameter "resource_profil

Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-23 Thread Jakub Kicinski
On Sun, 21 Feb 2021 21:05:50 -0800 Florian Fainelli wrote: > On 2/21/2021 17:35, Sieng Piaw Liew wrote: > > In ndo_stop functions, netdev_completed_queue() is called during forced > > tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if > > there is any tx skb left. > > > > Thi

Re: [PATCH v2] netdevsim: fib: remove unneeded semicolon

2021-02-23 Thread Jakub Kicinski
On Tue, 23 Feb 2021 10:28:46 +0800 Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong # Form letter - net-next is closed We have already sent the networking pu

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-22 Thread Jakub Kicinski
On Sat, 20 Feb 2021 07:56:55 +0100 Heiko Thiery wrote: > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > This is only the case when the interface is down. This can be reproduced > by reading with 'phc_ctrl eth0 get'. > > Like described in the change in 91c0d987a9788dcc5fe

Re: [PATCH net-next 2/2] net: ipv6: don't generate link local address on PUREIP device

2021-02-22 Thread Jakub Kicinski
On Tue, 23 Feb 2021 10:03:11 +0800 rocco.yue wrote: > On Thu, 2021-02-04 at 14:06 +0800, rocco.yue wrote: > > On Fri, 2021-01-29 at 19:07 -0800, Jakub Kicinski wrote: > > > On Thu, 28 Jan 2021 13:58:09 +0800 Rocco Yue wrote: > [...] > > > > > > Th

Re: [PATCH net v3] net: introduce CAN specific pointer in the struct net_device

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 16:02:51 +0100 Oleksij Rempel wrote: > Since 20dd3850bcf8 ("can: Speed up CAN frame receiption by using > ml_priv") the CAN framework uses per device specific data in the AF_CAN > protocol. For this purpose the struct net_device->ml_priv is used. Later > the ml_priv usage in CAN

Re: [PATCH 03/20] devlink: Manual replacement of the deprecated strlcpy() with return values

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 16:12:14 +0100 Romain Perier wrote: > diff --git a/net/core/devlink.c b/net/core/devlink.c > index 737b61c2976e..7eb445460c92 100644 > --- a/net/core/devlink.c > +++ b/net/core/devlink.c > @@ -9461,10 +9461,10 @@ EXPORT_SYMBOL_GPL(devlink_port_param_value_changed); > void devli

Re: [PATCH] net: tap: remove redundant assignments

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 22:57:48 +0800 Tang Bin wrote: > In the function tap_get_user, the assignment of 'err' at both places > is redundant, so remove one. > > Signed-off-by: Tang Bin > --- > drivers/net/tap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/

Re: [PATCH] ethernet/microchip:remove unneeded variable: "ret"

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 10:58:18 +0800 dingsen...@163.com wrote: > From: dingsenjie > > remove unneeded variable: "ret". > > Signed-off-by: dingsenjie # Form letter - net-next is closed We have already sent the networking pull request for 5.12 and therefore net-next is closed for new drivers, fea

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: > >> This will not be sufficient for my usecase: To stay compatible with older > >> versions of fastd, I can't set the T flag in the first packet of the > >> handshake, as it won't be known whether the peer has a new enough fastd > >> vers

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-19 Thread Jakub Kicinski
On Thu, 18 Feb 2021 12:23:28 -0800 Xie He wrote: > On Thu, Feb 18, 2021 at 12:06 PM Xie He wrote: > > > > On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky wrote: > > > > > > This is how we write code, we use defines instead of constant numbers, > > > comments to describe tricky parts and assign

Re: [PATCH net] r8152: move r8153_mac_clk_spd

2021-02-19 Thread Jakub Kicinski
On Fri, 19 Feb 2021 17:38:03 +0800 Hayes Wang wrote: > Move calling r8153_mac_clk_spd() from r8153_first_init() to rtl8153_up(), > and from r8153_enter_oob() to rtl8153_down(). > > r8153_mac_clk_spd() is used for RTL8153A. However, RTL8153B use > r8153_first_init() and r8153_enter_oob(), too. Ther

Re: [PATCH v7 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-18 Thread Jakub Kicinski
On Wed, 17 Feb 2021 22:08:55 -0800 John Fastabend wrote: > > Performance Testing > > > > The test environment is Aliyun ECS server. > > Test cmd: > > ``` > > xdpsock -i eth0 -t -S -s > > ``` > > > > Test result data: > > > > size64 512 10241500 >

Re: [net-next PATCH v6 02/15] net: phy: Introduce fwnode_mdio_find_device()

2021-02-18 Thread Jakub Kicinski
On Thu, 18 Feb 2021 10:56:41 +0530 Calvin Johnson wrote: > +/** > + * fwnode_mdio_find_device - Given a fwnode, find the mdio_device > + * @np: pointer to the mdio_device's fwnode > + * > + * If successful, returns a pointer to the mdio_device with the embedded > + * struct device refcount incremen

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Jakub Kicinski
On Wed, 17 Feb 2021 22:30:14 +0100 Arnd Bergmann wrote: > On Wed, Feb 17, 2021 at 9:20 PM Min Li wrote: > > I attached the G.8273.2 document, where chapter 6 is about supporting > > physical layer > > frequency. And combo mode is Renesas way to support this requirement. Other > > companies > > m

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-17 Thread Jakub Kicinski
On Tue, 16 Feb 2021 08:20:46 + Lee Jones wrote: > On Mon, 15 Feb 2021, Jakub Kicinski wrote: > > On Mon, 15 Feb 2021 08:49:52 + Lee Jones wrote: > > > Yes, please share. > > > > https://github.com/kuba-moo/nipa > > Thanks for this. > >

Re: [PATCH v2 net-next 1/3] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-17 Thread Jakub Kicinski
On Tue, 16 Feb 2021 13:12:29 -0500 Vincent Cheng wrote: > >> +} > >> + > >> +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm) > >> +{ > >> + const char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL > >> state %d"; > >> + u8 i = LOCK_TIMEOUT_MS / LOCK_POLL_INTERVAL_MS; > >

Re: [PATCH v2 net-next 1/3] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-15 Thread Jakub Kicinski
On Sat, 13 Feb 2021 00:06:04 -0500 vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > Part of the device initialization aligns the rising edge of the output > clock to the internal 1 PPS clock. If the system APLL and DPLL is not > locked, then the alignment will fail and there will be

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-15 Thread Jakub Kicinski
On Mon, 15 Feb 2021 08:49:52 + Lee Jones wrote: > > Jakub can explain how he added these checks. > > Yes, please share. https://github.com/kuba-moo/nipa

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-12 Thread Jakub Kicinski
On Fri, 12 Feb 2021 15:06:41 +0100 Bjarni Jonasson wrote: > At Power-On Reset, transients may cause the LCPLL to lock onto a > clock that is momentarily unstable. This is normally seen in QSGMII > setups where the higher speed 6G SerDes is being used. > This patch adds an initial LCPLL Reset to the

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread Jakub Kicinski
On Fri, 12 Feb 2021 08:01:15 -0600 Alex Elder wrote: > On 2/11/21 8:04 PM, Jakub Kicinski wrote: > > On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: > >> +/* MAP CSUM headers */ > >> +struct rmnet_map_v5_csum_header { > >> + u8 n

Re: [PATCH v1 5/7] net: ipa: Add support for IPA on MSM8998

2021-02-12 Thread Jakub Kicinski
On Thu, 11 Feb 2021 18:50:13 +0100 AngeloGioacchino Del Regno wrote: > MSM8998 features IPA v3.1 (GSI v1.0): add the required configuration > data for it. > > Signed-off-by: AngeloGioacchino Del Regno > This one does not build: drivers/net/ipa/ipa_data-msm8998.c:382:3: error: ‘struct ipa_clock

Re: [PATCH v1 1/7] net: ipa: Add support for IPA v3.1 with GSI v1.0

2021-02-12 Thread Jakub Kicinski
On Thu, 11 Feb 2021 18:50:09 +0100 AngeloGioacchino Del Regno wrote: > In preparation for adding support for the MSM8998 SoC's IPA, > add the necessary bits for IPA version 3.1 featuring GSI 1.0, > found on at least MSM8998. > > Signed-off-by: AngeloGioacchino Del Regno > please check your patc

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-11 Thread Jakub Kicinski
On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: > +/* MAP CSUM headers */ > +struct rmnet_map_v5_csum_header { > + u8 next_hdr:1; > + u8 header_type:7; > + u8 hw_reserved:5; > + u8 priority:1; > + u8 hw_reserved_bit:1; > + u8 csum_valid_required:1; >

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

2021-02-10 Thread Jakub Kicinski
On Wed, 10 Feb 2021 17:06:29 + Hariprasad Kelam wrote: > > On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote: > > > v4: > > > - Corrected indentation issues > > > - Use FEC_OFF if user requests for FEC_AUTO mode > > > - Do not clear fec stats in case of user changes > > > fec

Re: [EXT] Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-10 Thread Jakub Kicinski
On Tue, 9 Feb 2021 20:31:32 + Mickey Rachamim wrote: > On Tuesday, February 9, 2021 7:35 PM Jakub Kicinski wrote: > > Sounds like we have 3 people who don't like FW-heavy designs dominating the > > kernel - this conversation can only go one way. > > Marvell, Plvisio

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Jakub Kicinski
On Wed, 10 Feb 2021 11:55:31 +0530 Manivannan Sadhasivam wrote: > On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > > This may be a stupid suggestion, but would the integration look less a &g

Re: [Patch v4 net-next 0/7] ethtool support for fec and link configuration

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote: > v4: > - Corrected indentation issues > - Use FEC_OFF if user requests for FEC_AUTO mode > - Do not clear fec stats in case of user changes > fec mode > - dont hide fec stats depending on interface mode >

<    1   2   3   4   5   6   7   8   9   10   >