Re: [PATCH v3 5/7] KVM: x86: Participate in bitmap-based PTE aging

2024-04-19 Thread James Houghton
On Fri, Apr 19, 2024 at 2:07 PM David Matlack wrote: > > On 2024-04-19 01:47 PM, James Houghton wrote: > > On Thu, Apr 11, 2024 at 10:28 AM David Matlack wrote: > > > On 2024-04-11 10:08 AM, David Matlack wrote: > > > bool kvm_age_gfn(struct kvm *kv

Re: [PATCH v3 0/7] mm/kvm: Improve parallelism for access bit harvesting

2024-04-19 Thread James Houghton
On Fri, Apr 12, 2024 at 11:41 AM David Matlack wrote: > > On 2024-04-01 11:29 PM, James Houghton wrote: > > This patchset adds a fast path in KVM to test and clear access bits on > > sptes without taking the mmu_lock. It also adds support for using a > > bitmap to (1)

Re: [PATCH v3 5/7] KVM: x86: Participate in bitmap-based PTE aging

2024-04-19 Thread James Houghton
On Fri, Apr 12, 2024 at 1:44 PM David Matlack wrote: > > On 2024-04-01 11:29 PM, James Houghton wrote: > > Only handle the TDP MMU case for now. In other cases, if a bitmap was > > not provided, fallback to the slowpath that takes mmu_lock, or, if a > > bitmap was provided

Re: [PATCH v3 5/7] KVM: x86: Participate in bitmap-based PTE aging

2024-04-19 Thread James Houghton
On Thu, Apr 11, 2024 at 10:28 AM David Matlack wrote: > > On 2024-04-11 10:08 AM, David Matlack wrote: > > On 2024-04-01 11:29 PM, James Houghton wrote: > > > Only handle the TDP MMU case for now. In other cases, if a bitmap was > > > not provided, fallback to the sl

Re: [PATCH v3 3/7] KVM: Add basic bitmap support into kvm_mmu_notifier_test/clear_young

2024-04-19 Thread James Houghton
On Fri, Apr 12, 2024 at 1:28 PM David Matlack wrote: > > On 2024-04-01 11:29 PM, James Houghton wrote: > > Add kvm_arch_prepare_bitmap_age() for architectures to indiciate that > > they support bitmap-based aging in kvm_mmu_notifier_test_clear_young() > > and that they do

Re: [PATCH v3 1/7] mm: Add a bitmap into mmu_notifier_{clear,test}_young

2024-04-19 Thread James Houghton
On Fri, Apr 12, 2024 at 11:45 AM David Matlack wrote: > > On 2024-04-01 11:29 PM, James Houghton wrote: > > The bitmap is provided for secondary MMUs to use if they support it. For > > test_young(), after it returns, the bitmap represents the pages that > > were young in

Re: [PATCH v3 1/7] mm: Add a bitmap into mmu_notifier_{clear,test}_young

2024-04-10 Thread James Houghton
On Tue, Apr 9, 2024 at 12:35 PM David Hildenbrand wrote: > > On 09.04.24 20:31, James Houghton wrote: > > Ah, I didn't see this in my inbox, sorry David! > > No worries :) > > > > > On Thu, Apr 4, 2024 at 11:52 AM David Hildenbrand wrote: > >&g

Re: [PATCH v3 1/7] mm: Add a bitmap into mmu_notifier_{clear,test}_young

2024-04-09 Thread James Houghton
Ah, I didn't see this in my inbox, sorry David! On Thu, Apr 4, 2024 at 11:52 AM David Hildenbrand wrote: > > On 02.04.24 01:29, James Houghton wrote: > > diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h > > index f349e08a9dfe..daaa9db625d3 100644

[PATCH v3 7/7] mm: multi-gen LRU: use mmu_notifier_test_clear_young()

2024-04-01 Thread James Houghton
m: rmap: Don't flush TLB after checking PTE young for page reference" was included so that the comparison is apples to apples. https://lore.kernel.org/r/20220706112041.3831-1-21cn...@gmail.com/ Signed-off-by: Yu Zhao Signed-off-by: James Houghton --- Documentation/admin-g

[PATCH v3 6/7] KVM: arm64: Participate in bitmap-based PTE aging

2024-04-01 Thread James Houghton
ed-in bitmap. When mkold == true, only age the pages that need aging according to the passed-in bitmap. Suggested-by: Yu Zhao Signed-off-by: James Houghton --- arch/arm64/include/asm/kvm_host.h| 5 + arch/arm64/include/asm/kvm_pgtable.h | 4 +++- arch/arm64/kvm/hyp/pgtable.c

[PATCH v3 5/7] KVM: x86: Participate in bitmap-based PTE aging

2024-04-01 Thread James Houghton
Only handle the TDP MMU case for now. In other cases, if a bitmap was not provided, fallback to the slowpath that takes mmu_lock, or, if a bitmap was provided, inform the caller that the bitmap is unreliable. Suggested-by: Yu Zhao Signed-off-by: James Houghton --- arch/x86/include/asm

[PATCH v3 4/7] KVM: x86: Move tdp_mmu_enabled and shadow_accessed_mask

2024-04-01 Thread James Houghton
From: Yu Zhao tdp_mmu_enabled and shadow_accessed_mask are needed to implement kvm_arch_prepare_bitmap_age(). Signed-off-by: Yu Zhao Signed-off-by: James Houghton --- arch/x86/include/asm/kvm_host.h | 6 ++ arch/x86/kvm/mmu.h | 6 -- arch/x86/kvm/mmu/spte.h | 1

[PATCH v3 3/7] KVM: Add basic bitmap support into kvm_mmu_notifier_test/clear_young

2024-04-01 Thread James Houghton
d_age(). Suggested-by: Yu Zhao Signed-off-by: James Houghton --- include/linux/kvm_host.h | 60 ++ virt/kvm/kvm_main.c | 92 +--- 2 files changed, 127 insertions(+), 25 deletions(-) diff --git a/include/linux/kvm_host.h b/include/

[PATCH v3 1/7] mm: Add a bitmap into mmu_notifier_{clear,test}_young

2024-04-01 Thread James Houghton
[1]: https://lore.kernel.org/all/20230609005935.42390-1-yuz...@google.com/ Suggested-by: Yu Zhao Signed-off-by: James Houghton --- include/linux/mmu_notifier.h | 93 +--- include/trace/events/kvm.h | 13 +++-- mm/mmu_notifier.c| 20 +--- virt/kvm/

[PATCH v3 2/7] KVM: Move MMU notifier function declarations

2024-04-01 Thread James Houghton
To allow new MMU-notifier-related functions to use gfn_to_hva_memslot(), move some declarations around. Also move mmu_notifier_to_kvm() for wider use later. Signed-off-by: James Houghton --- include/linux/kvm_host.h | 41 +--- virt/kvm/kvm_main.c | 5

[PATCH v3 0/7] mm/kvm: Improve parallelism for access bit harvesting

2024-04-01 Thread James Houghton
https://lore.kernel.org/kvmarm/20230526234435.662652-1-yuz...@google.com/ [4]: https://lore.kernel.org/all/zitx64bbx5vdj...@google.com/ James Houghton (5): mm: Add a bitmap into mmu_notifier_{clear,test}_young KVM: Move MMU notifier function declarations KVM: Add basic bitmap support into kvm

Re: [PATCH v9 1/4] KEYS: trusted: Add generic trusted keys framework

2021-04-20 Thread James Bottomley
ob up to passed the consumed tokens, so it actually reads datablob="keyhandle=0x8101" However, to do that you'd have to have the updated pointer passed out of your datablob_parse() above. There's also a lost !tpm2 in the check for options->keyhandle, but I suspect Jarkko

Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-19 Thread James Clark
On 16/04/2021 18:16, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 16, 2021 at 09:07:09AM -0600, Mathieu Poirier escreveu: >> Hi James, >> >> On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: >>> Changes since v1: >>> * Improved variable

[GIT PULL] SCSI fixes for 5.12-rc6

2021-04-17 Thread James Bottomley
+++--- 3 files changed, 22 insertions(+), 31 deletions(-) With full diff below. James --- diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 7ad11e42306d..bfd2aaa9b66b 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -3179,9 +3179,10

Re: [PATCH v4 4/6] perf arm-spe: Assign kernel time to synthesized event

2021-04-16 Thread James Clark
On 15/04/2021 18:23, Leo Yan wrote: > On Thu, Apr 15, 2021 at 05:46:31PM +0300, James Clark wrote: >> >> >> On 12/04/2021 12:10, Leo Yan wrote: >>> In current code, it assigns the arch timer counter to the synthesized >>> samples Arm SPE trace, thus th

[PATCH v2 1/2] perf cs-etm: Refactor timestamp variable names

2021-04-16 Thread James Clark
refers to sample kernel timestamps, and the /timestamp/ event modifier refers to CS timestamps, so the term is overloaded. Signed-off-by: James Clark --- .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 tools/perf/util/cs-etm.c | 42 +-- tools/perf

[PATCH v2 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-16 Thread James Clark
tm__process_queues(). Co-developed-by: Al Grant Signed-off-by: Al Grant Signed-off-by: James Clark --- tools/perf/util/cs-etm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 533f6f2f0685..e5c1a1b22a2a 100

[PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-16 Thread James Clark
Changes since v1: * Improved variable name from etm_timestamp -> cs_timestamp * Fixed ordering of Signed-off-by James Clark (2): perf cs-etm: Refactor timestamp variable names perf cs-etm: Set time on synthesised samples to preserve ordering .../perf/util/cs-etm-decoder/cs-etm-decode

Re: [PATCH 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-16 Thread James Clark
On 15/04/2021 22:54, Mathieu Poirier wrote: > On Wed, Apr 14, 2021 at 05:39:19PM +0300, James Clark wrote: >> The following attribute is set when synthesising samples in >> timed decoding mode: >> >> attr.sample_type |= PERF_SAMPLE_TIME; >> >> This res

Re: [PATCH 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-16 Thread James Clark
On 15/04/2021 17:33, Leo Yan wrote: > Hi James, > > On Thu, Apr 15, 2021 at 03:51:46PM +0300, James Clark wrote: > > [...] > >>> For the orignal perf data file with "--per-thread" option, the decoder >>> runs into the condition for "etm-

Re: [PATCH] security: commoncap: clean up kernel-doc comments

2021-04-15 Thread James Morris
was for cap_task_setnice() instead > > Signed-off-by: Randy Dunlap > Cc: Serge Hallyn > Cc: James Morris > Cc: linux-security-mod...@vger.kernel.org Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git fixes-v5.12 -- James Morris

Re: [PATCH v4 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS

2021-04-15 Thread James Clark
On 15/04/2021 17:41, Leo Yan wrote: > Hi James, > > On Thu, Apr 15, 2021 at 05:13:36PM +0300, James Clark wrote: >> On 12/04/2021 12:10, Leo Yan wrote: >>> The enum value 'ARM_SPE_PER_CPU_MMAPS' is never used so remove it. >> >> Hi Leo, >>

Re: [PATCH v4 4/6] perf arm-spe: Assign kernel time to synthesized event

2021-04-15 Thread James Clark
On 12/04/2021 12:10, Leo Yan wrote: > In current code, it assigns the arch timer counter to the synthesized > samples Arm SPE trace, thus the samples don't contain the kernel time > but only contain the raw counter value. > > To fix the issue, this patch converts the timer counter to kernel tim

Re: [PATCH v4 0/6] perf arm-spe: Enable timestamp

2021-04-15 Thread James Clark
0x8]: failed to process type: 9 [Bad address] Error: failed to process sample Do you have any test suggestions other than looking at the raw data? Thanks James On 12/04/2021 12:10, Leo Yan wrote: > This patch set is to enable timestamp for Arm SPE trace. It reads out

Re: [PATCH v4 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS

2021-04-15 Thread James Clark
o process type: 70 [Invalid argument] Error: failed to process sample # To display the perf.data header info, please use --header/--header-only options. # James > > Signed-off-by: Leo Yan > --- > tools/perf/util/arm-spe.h | 1 - > 1 file changed, 1 deleti

Re: [PATCH 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-15 Thread James Clark
On 15/04/2021 15:39, Leo Yan wrote: > On Wed, Apr 14, 2021 at 05:41:46PM +0300, James Clark wrote: >> Hi, >> >> For this change, I also tried removing the setting of PERF_SAMPLE_TIME in >> cs_etm__synth_events(). In theory, this would remove the sorting when &

Re: [PATCH 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-14 Thread James Clark
or maybe just checking the options, although that's not how it's done in cs_etm__is_timeless_decoding() currently). Or, we could force /time/ and /timestamp/ options to always be enabled together in the record stage. Thanks James On 14/04/2021 17:39, James Clark wrote: > The follow

[PATCH 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-14 Thread James Clark
to cs_etm__process_queues(). Signed-off-by: James Clark Co-developed-by: Al Grant Signed-off-by: Al Grant --- tools/perf/util/cs-etm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index c25da2ffa8f3..d0fa9dce47f1 100

[PATCH 1/2] perf cs-etm: Refactor timestamp variable names

2021-04-14 Thread James Clark
refers to sample kernel timestamps, and the /timestamp/ event modifier refers to etm timestamps, so the term is overloaded. Signed-off-by: James Clark --- .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 tools/perf/util/cs-etm.c | 42 +-- tools

Re: [PATCH][next] scsi: aacraid: Replace one-element array with flexible-array member

2021-04-13 Thread James Bottomley
s the macro likely needs a new name. However, perhaps just do array_size(nseg_new - 1, sizeof(*sge)); And lose the comment? James

Re: [PATCH][next] KEYS: trusted: Fix missing null return from kzalloc call

2021-04-12 Thread James Bottomley
should have been a simple cut and paste ... how did that happen? And therefore, how safe is the rest of the extraction into trusted_core.c? James

[GIT PULL] SCSI fixes for 5.12-rc6

2021-04-10 Thread James Bottomley
8001_hwi.c| 8 ++-- drivers/scsi/scsi_transport_srp.c | 2 +- drivers/scsi/ufs/ufshcd.c | 31 +++ drivers/target/iscsi/iscsi_target.c | 3 +- 5 files changed, 65 insertions(+), 57 deletions(-) With full diff below. James --- diff --git a/drivers/scsi/hpsa_cmd.h b/dr

Re: [PATCH v33 00/12] Landlock LSM

2021-04-08 Thread James Morris
I've added this to my tree at: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git landlock_lsm_v33 and merged that into the next-testing branch which is pulled into Linux next. -- James Morris

Re: [RFC v2] KVM: x86: Support KVM VMs sharing SEV context

2021-04-08 Thread James Bottomley
On Thu, 2021-04-08 at 17:41 -0700, Steve Rutherford wrote: > On Thu, Apr 8, 2021 at 2:15 PM James Bottomley > wrote: > > On Thu, 2021-04-08 at 12:48 -0700, Steve Rutherford wrote: > > > On Thu, Apr 8, 2021 at 10:43 AM James Bottomley < > > > j...@linux.ibm.com&g

Re: [RFC v2] KVM: x86: Support KVM VMs sharing SEV context

2021-04-08 Thread James Bottomley
On Thu, 2021-04-08 at 12:48 -0700, Steve Rutherford wrote: > On Thu, Apr 8, 2021 at 10:43 AM James Bottomley > wrote: > > On Fri, 2021-04-02 at 16:20 +0200, Paolo Bonzini wrote: > > > On 02/04/21 13:58, Ashish Kalra wrote: > > > > Hi Nathan, > > > >

Re: [PATCH v33 07/12] landlock: Support filesystem access-control

2021-04-08 Thread James Morris
ption" with "flag" in hook_sb_mount() comment. Good to see these changes. Al: any further comments now on this patch? -- James Morris

Re: [RFC v2] KVM: x86: Support KVM VMs sharing SEV context

2021-04-08 Thread James Bottomley
Google is unwilling to publish the patches, can you at least give some hints about how you did it? Thanks, James

Re: [PATCH v2 01/24] x86/resctrl: Split struct rdt_resource

2021-04-08 Thread James Morse
Hi Reinette, On 07/04/2021 00:42, Reinette Chatre wrote: > On 4/6/2021 10:13 AM, James Morse wrote: >> On 31/03/2021 22:35, Reinette Chatre wrote: >>> On 3/12/2021 9:58 AM, James Morse wrote: >>>> resctrl is the defacto Linux ABI for SoC resource partitioning f

Re: [PATCH v2 02/24] x86/resctrl: Split struct rdt_domain

2021-04-08 Thread James Morse
Hi Reinette, On 31/03/2021 22:36, Reinette Chatre wrote: > On 3/12/2021 9:58 AM, James Morse wrote: >> resctrl is the defacto Linux ABI for SoC resource partitioning features. >> To support it on another architecture, it needs to be abstracted from >> the features provided

Re: [PATCH v2 00/24] x86/resctrl: Merge the CDP resources

2021-04-08 Thread James Morse
Hi Babu, On 06/04/2021 22:37, Babu Moger wrote: > On 4/6/21 12:19 PM, James Morse wrote: >> On 30/03/2021 21:36, Babu Moger wrote: >>> On 3/12/21 11:58 AM, James Morse wrote: >>>> This series re-folds the resctrl code so the CDP resources (L3CODE et al) >>

Re: [PATCH v2 00/24] x86/resctrl: Merge the CDP resources

2021-04-06 Thread James Morse
Hi Babu, On 30/03/2021 21:36, Babu Moger wrote: > On 3/12/21 11:58 AM, James Morse wrote: >> This series re-folds the resctrl code so the CDP resources (L3CODE et al) >> behaviour is all contained in the filesystem parts, with a minimum amount >> of arch specific code. &g

Re: [PATCH v2 01/24] x86/resctrl: Split struct rdt_resource

2021-04-06 Thread James Morse
Hi Reinette, On 31/03/2021 22:35, Reinette Chatre wrote: > On 3/12/2021 9:58 AM, James Morse wrote: >> resctrl is the defacto Linux ABI for SoC resource partitioning features. >> To support it on another architecture, it needs to be abstracted from >> the features provided

Re: [PATCH] integrity/ima: Add declarations to init_once void arguments.

2021-04-05 Thread James Morris
nt = foo; > > + struct integrity_iint_cache *iint = (struct integrity_iint_cache > > *)foo; > > > >memset(iint, 0, sizeof(*iint)); > >iint->ima_file_status = INTEGRITY_UNKNOWN; > -- James Morris

Re: [PATCH 0/4] occ: fsi and hwmon: Fixes for polling un-initialized OCC

2021-04-05 Thread Eddie James
On Tue, 2021-02-09 at 11:12 -0600, Eddie James wrote: > In the event that the OCC is not initialized when the driver sends a > poll > command, the driver may receive an invalid response. This isn't an > error > condition unless there is no valid response before the timeout &g

[GIT PULL] SCSI fixes for 5.12-rc

2021-04-02 Thread James Bottomley
the diffstat: drivers/scsi/scsi_transport_iscsi.c | 14 +- include/scsi/scsi_transport_iscsi.h | 1 + 2 files changed, 14 insertions(+), 1 deletion(-) With full diff below. James --- diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index

Compiling Linux kernel into a build directory

2021-04-02 Thread James Courtier-Dutton
this approach is one can then put the build folder on a ram disk / tmpfs and be able to compile and test much quicker. Kind Regards James

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread James Bottomley
On Thu, 2021-04-01 at 18:50 +0530, Sumit Garg wrote: > On Thu, 1 Apr 2021 at 15:36, Ahmad Fatoum > wrote: > > Hello Richard, > > > > On 31.03.21 21:36, Richard Weinberger wrote: > > > James, > > > > > > - Ursprüngliche Mail - > >

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-31 Thread James Bottomley
On Wed, 2021-03-31 at 20:36 +0200, Richard Weinberger wrote: > James, > > - Ursprüngliche Mail - > > Von: "James Bottomley" > > > On Wed, Mar 17, 2021 at 3:08 PM Ahmad Fatoum < > > > a.fat...@pengutronix.de wrote: > > > >

Re: [PATCH v1 0/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-30 Thread James Bottomley
re not they need to be made so before the patches go upstream. I could possibly see that you might want to be type specific in the create, but once you're simply loading an already created key, the trusted key subsystem should be able to figure what to do on its own. James

[PATCH] net/ncsi: Avoid channel_monitor hrtimer deadlock

2021-03-29 Thread Eddie James
x27;t restart, as the locking is broken somehow. Fixes: 0795fb2021f0 ("net/ncsi: Stop monitor if channel times out or is inactive") Signed-off-by: Milton Miller Signed-off-by: Eddie James --- net/ncsi/ncsi-manage.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions

[PATCH] fsi: scom: Reset the FSI2PIB engine for any error

2021-03-29 Thread Eddie James
The error bits in the FSI2PIB status are only cleared by a reset. So the driver needs to perform a reset after seeing any of the FSI2PIB errors, otherwise subsequent operations will also look like failures. Fixes: 6b293258cded ("fsi: scom: Major overhaul") Signed-off-by: Eddie James --

[GIT PULL] SCSI fixes for 5.12-rc4

2021-03-27 Thread James Bottomley
hanged, 74 insertions(+), 28 deletions(-) With full diff below. James --- diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index 6a92891ac488..bb64e3247a6c 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c @@ -2371,6 +2371,24 @@

Re: [PATCH RESEND WITH CCs v3 4/4] perf tools: determine if LR is the return address

2021-03-26 Thread James Clark
ll of the registers is too much, so we should continue with the change to only record the link register. In my opinion a 5% - 10% increase by enabling LR recording by default wouldn't be noticeable, so it's worth doing. But obviously we'll need other opinions

Re: [PATCH] spi: fsi: Remove multiple sequenced ops for restricted chips

2021-03-25 Thread Eddie James
On Thu, 2021-03-25 at 13:50 +, Mark Brown wrote: > On Wed, Mar 24, 2021 at 05:05:16PM -0500, Eddie James wrote: > > > Updated restricted chips have trouble processing multiple sequenced > > operations. So remove the capability to sequence multiple > > operations an

[PATCH] spi: fsi: Remove multiple sequenced ops for restricted chips

2021-03-24 Thread Eddie James
Updated restricted chips have trouble processing multiple sequenced operations. So remove the capability to sequence multiple operations and reduce the maximum transfer size to 8 bytes. Signed-off-by: Eddie James --- drivers/spi/spi-fsi.c | 27 +++ 1 file changed, 7

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-24 Thread James Bottomley
On Wed, 2021-03-24 at 16:49 -0400, Mimi Zohar wrote: > On Wed, 2021-03-24 at 09:14 -0700, James Bottomley wrote: > > On Tue, 2021-03-23 at 14:07 -0400, Mimi Zohar wrote: > > > On Tue, 2021-03-23 at 17:35 +0100, Ahmad Fatoum wrote: > > > > Hello Horia, > > &

Re: [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

2021-03-24 Thread James Morris
s. > > Add a separate NULL check to tell gcc about it as well. > > Signed-off-by: Arnd Bergmann Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git fixes-v5.12 -- James Morris

Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

2021-03-24 Thread James Morris
t? The code is in the repo and discussions can easily be found by searching for subjects or message IDs. Is anyone else doing this self linking? -- James Morris

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-24 Thread James Bottomley
ost cryptograhpers recommend using a TPM for entropy mixing rather than directly: https://blog.cryptographyengineering.com/category/rngs/ The TPMFail paper also shows that in spite of NIST certification things can go wrong with a TPM: https://tpm.fail/ James

Re: [Ksummit-discuss] RFC: create mailing list "linux-issues" focussed on issues/bugs and regressions

2021-03-23 Thread James Bottomley
blic inbox. I assume the search can be quite wide so we could flag a regression on any list indexed by lore? James

Re: [Ksummit-discuss] RFC: create mailing list "linux-issues" focussed on issues/bugs and regressions

2021-03-22 Thread James Bottomley
report" and the triage team can cc additional lists as appropriate. Then we simply tell everyone to send kernel bugs to this list and ask maintainers to cc it if a bug report shows up on their list? James

[GIT PULL] SCSI fixes for 5.12-rc3

2021-03-20 Thread James Bottomley
ivers/scsi/st.c| 2 +- drivers/scsi/ufs/ufs-mediatek.c | 2 +- 8 files changed, 20 insertions(+), 15 deletions(-) With full diff below. James --- diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index 338e29d3e025..6a92891ac488 100644 --- a/driver

Re: [PATCH RFC 0/3] drivers/char: remove /dev/kmem for good

2021-03-19 Thread James Troup
t merge window, but would really want > distros to confirm that they don't enable it. FWIW, it's been disabled in Ubuntu for over 10 years now: https://wiki.ubuntu.com/Security/Features#A.2Fdev.2Fkmem_disabled -- James

Re: [PATCH v30 00/12] Landlock LSM

2021-03-18 Thread James Morris
nd testing during that time will be helpful. -- James Morris

Re: [PATCH v30 07/12] landlock: Support filesystem access-control

2021-03-18 Thread James Morris
> This commit adds a minimal set of supported filesystem access-control > which doesn't enable to restrict all file-related actions. It would be great to get some more review/acks on this patch, particularly from VFS/FS folk. -- James Morris

[GIT PULL] SCSI fixes for 5.12-rc2

2021-03-12 Thread James Bottomley
/ufs/ufs-qcom.c| 10 +++ drivers/scsi/ufs/ufshcd.c | 41 +--- drivers/scsi/vmw_pvscsi.c | 2 -- drivers/scsi/vmw_pvscsi.h | 2 -- 6 files changed, 60 insertions(+), 59 deletions(-) With full diff below. James --- diff --git a/MAINTAINERS b

[PATCH v2 24/24] x86/resctrl: Merge the CDP resources

2021-03-12 Thread James Morse
iewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * rdt_get_cdp_config() is kept for its comment. --- arch/x86/kernel/cpu/resctrl/core.c | 174 ++--- arch/x86/kernel/cpu/resctrl/internal.h | 4 - arch/x86/kernel/cpu/resctrl/rdtgroup.c

[PATCH v2 23/24] x86/resctrl: Remove rdt_cdp_peer_get()

2021-03-12 Thread James Morse
configuration type if cdp is enabled. Reviewed-by: Jamie Iles Signed-off-by: James Morse Changes since v1: * Expanded commit mesasge. --- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 99 -- 1 file changed, 14 insertions(+), 85 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl

[PATCH v2 22/24] x86/resctrl: Merge the ctrl_val arrays

2021-03-12 Thread James Morse
omplicates allocating and freeing the ctrl_val arrays. Add a helper to allocate the ctrl_val array, that returns the value on the L2 or L3 resource if it already exists. This gets removed once the resources are merged, and there really is only one ctrl_val array. Reviewed-by: Jamie Iles Signed-off

[PATCH v2 21/24] x86/resctrl: Calculate the index from the configuration type

2021-03-12 Thread James Morse
on the staged configuration type. This makes the static mult and offset parameters redundant. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- arch/x86/kernel/cpu/resctrl/core.c| 12 arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 17 +++-- include/linux

[PATCH v2 20/24] x86/resctrl: Apply offset correction when config is staged

2021-03-12 Thread James Morse
changes it has made to the ctrl_val array as this allows the hardware to be updated once for a set of changes. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Removing the patch that moved the closid to the staged config means the min/max and return from

[PATCH v2 19/24] x86/resctrl: Make ctrlval arrays the same size

2021-03-12 Thread James Morse
this is that the caches are reset twice, once for CODE once for DATA. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- arch/x86/kernel/cpu/resctrl/core.c | 10 +- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 9 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 18/24] x86/resctrl: Pass configuration type to resctrl_arch_get_config()

2021-03-12 Thread James Morse
index in the configuration array. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 5 ++-- arch/x86/kernel/cpu/resctrl/monitor.c | 2 +- arch/x86/kernel/cpu/resctrl/rdtgroup.c| 35 +++ include/linux/resctrl.h

[PATCH v2 16/24] x86/resctrl: Add a helper to read/set the CDP configuration

2021-03-12 Thread James Morse
r one resource means it is enable for all resources, as all resources would need to configure both interpretations of the closid value. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Added prototype for resctrl_arch_set_cdp_enabled() * s/Currently/Previ

[PATCH v2 12/24] x86/resctrl: Group staged configuration into a separate struct

2021-03-12 Thread James Morse
n the struct need to be specified per type configuration, and there can be one configuration of each type staged. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Expanded commit message * Removed explicit clearing of have_new_ctrl, * Moved ARRAY_SIZE() trickery to a la

[PATCH v2 17/24] x86/resctrl: Use cdp_enabled in rdt_domain_reconfigure_cdp()

2021-03-12 Thread James Morse
rdt_domain_reconfigure_cdp() infers whether CDP is enabled by checking the alloc_capable and alloc_enabled flags of the data resources. Now that we have an explicit cdp_enabled, use that. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 8

[PATCH v2 13/24] x86/resctrl: Allow different CODE/DATA configurations to be staged

2021-03-12 Thread James Morse
staged_configuration array must be used for each schema. Use the conf_type enum directly as an index. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Renamed max enum value CDP_NUM_TYPES * Whitespace and parenthesis * Missing word in the commit message --- arch/x86

[PATCH v2 14/24] x86/resctrl: Rename update_domains() resctrl_arch_update_domains()

2021-03-12 Thread James Morse
update_domains() merges the staged configuration changes into the arch codes configuration array. Rename to make it clear its part of the arch code interface to resctrl. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * The closid is no longer staged as from resctrl

[PATCH v2 15/24] x86/resctrl: Add a helper to read a closid's configuration

2021-03-12 Thread James Morse
;t take the user-space control format at all. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 16 ++--- arch/x86/kernel/cpu/resctrl/monitor.c | 6 +++- arch/x86/kernel/cpu/resctrl/rdtgroup.c| 43 ++- include/linux/re

[PATCH v2 10/24] x86/resctrl: Swizzle rdt_resource and resctrl_schema in pseudo_lock_region

2021-03-12 Thread James Morse
es Signed-off-by: James Morse --- arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 4 ++-- arch/x86/kernel/cpu/resctrl/internal.h| 6 +++--- arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 8 arch/x86/kernel/cpu/resctrl/rdtgroup.c| 4 ++-- 4 files changed, 11 insertions(+), 11 deletion

[PATCH v2 09/24] x86/resctrl: Pass the schema to resctrl filesystem functions

2021-03-12 Thread James Morse
-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * split from a larger patch --- arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 23 +-- arch/x86/kernel/cpu/resctrl/internal.h| 6 +++--- arch/x86/kernel/cpu/resctrl/rdtgroup.c| 19

[PATCH v2 11/24] x86/resctrl: Move the schemata names into struct resctrl_schema

2021-03-12 Thread James Morse
will generate two names for one resource. The filesystem code should calculate max_name_width for padding the schemata file, move this to live with the code that will generate the names. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1; * Don't hardcode max_name_

[PATCH v2 08/24] x86/resctrl: Add resctrl_arch_get_num_closid()

2021-03-12 Thread James Morse
Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Rewrote commit message * Whitespace fixes * num_closid becomes u32 in all occurences to reduce surprises --- arch/x86/kernel/cpu/resctrl/core.c | 5 + arch/x86/kernel/cpu/resctrl/internal.h | 2 +- arch/x86/kernel/cp

[PATCH v2 06/24] x86/resctrl: Walk the resctrl schema list instead of an arch list

2021-03-12 Thread James Morse
thing' helper. After the filesystem code is moved, rdtgroup_pseudo_locked_in_hierarchy() remains part of the x86 specific hooks to support psuedo lock. This code walks each domain, and still does this after the separate resources are merged. Reviewed-by: Jamie Iles Signed-off-by: James Morse -

[PATCH v2 03/24] x86/resctrl: Add a separate schema list for resctrl

2021-03-12 Thread James Morse
d the name and type of configuration values for resctrl. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Renamed resctrl_all_schema list * Used schemata_list as a prefix to make these easier to search for * Added kerneldoc string * Removed 'pending configuratio

[PATCH v2 07/24] x86/resctrl: Store the effective num_closid in the schema

2021-03-12 Thread James Morse
e are changed to use the schema value instead. schemata_list_create() sets this value, and reaches into the architecture specific structure to get the value. This will eventually be replaced with a helper. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Added missing :

[PATCH v2 05/24] x86/resctrl: Label the resources with their configuration type

2021-03-12 Thread James Morse
to struct resctrl_schema. Copying the value ensures there is no mismatch, but allows the filesystem parts of resctrl to be modified to use the schema. Once the resources are merged, the filesystem code can assign this value based on the schema being created. Reviewed-by: Jamie Iles Signed-off-by: J

[PATCH v2 04/24] x86/resctrl: Pass the schema in info dir's private pointer

2021-03-12 Thread James Morse
oo. This difference means the type of the private pointers varies between control and monitor info dirs. If the flags are RF_MON_INFO, its a struct rdt_resource. If the flags are RF_CTRL_INFO, its a struct resctrl_schema. Nothing in res_common_files[] has both flags. Reviewed-by: Jamie Iles Signed

[PATCH v2 02/24] x86/resctrl: Split struct rdt_domain

2021-03-12 Thread James Morse
into a new header file. resctrl code paths touching a 'hw' struct indicates where an abstraction is needed. Splitting this structure only moves types around, and should not lead to any change in behaviour. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Tabs

[PATCH v2 01/24] x86/resctrl: Split struct rdt_resource

2021-03-12 Thread James Morse
cture only moves types around, and should not lead to any change in behaviour. Splitting rdt_domain up in a similar way happens in the next patch. Reviewed-by: Jamie Iles Signed-off-by: James Morse --- Changes since v1: * Tabs space and other whitespace * Restored for_each_rdt_resource() calls in

[PATCH v2 00/24] x86/resctrl: Merge the CDP resources

2021-03-12 Thread James Morse
947.39194-1-james.mo...@arm.com/ Thanks, James Morse (24): x86/resctrl: Split struct rdt_resource x86/resctrl: Split struct rdt_domain x86/resctrl: Add a separate schema list for resctrl x86/resctrl: Pass the schema in info dir's private pointer x86/resctrl: Label the resources wit

Re: [PATCH 12/24] x86/resctrl: Add closid to the staged config

2021-03-12 Thread James Morse
Hi Reinette, On 17/11/2020 23:46, Reinette Chatre wrote: > On 10/30/2020 9:11 AM, James Morse wrote: >> Once the L2/L2CODE/L2DATA resources are merged, there may be two >> configurations staged for one resource when CDP is enabled. The >> closid should always be pa

Re: [PATCH 11/24] x86/resctrl: Group staged configuration into a separate struct

2021-03-12 Thread James Morse
Hi Reinette, On 17/11/2020 23:28, Reinette Chatre wrote: > On 10/30/2020 9:11 AM, James Morse wrote: >> Arm's MPAM may have surprisingly large bitmaps for its cache >> portions as the architecture allows up to 4K portions. The size >> exposed via resctrl may not be

Re: [PATCH 10/24] x86/resctrl: Move the schema names into struct resctrl_schema

2021-03-12 Thread James Morse
Hi Reinette, On 17/11/2020 23:11, Reinette Chatre wrote: > On 10/30/2020 9:11 AM, James Morse wrote: >> Move the names used for the schemata file out of the resource and >> into struct resctrl_schema. This allows one resource to have two >> different names, based on the ot

Re: [PATCH 08/24] x86/resctrl: Walk the resctrl schema list instead of an arch list

2021-03-12 Thread James Morse
Hi Reinette, On 17/11/2020 22:52, Reinette Chatre wrote: > On 10/30/2020 9:11 AM, James Morse wrote: >> Now that resctrl has its own list of resources it is using, walk that >> list instead of the architectures list. This means resctrl has somewhere >> to keep schema propert

  1   2   3   4   5   6   7   8   9   10   >