Re: [PATCH] soc: mediatek: Fix random hang up issue while kernel init

Hi Daniel, On Thu, 2015-10-01 at 16:07 +0800, Daniel Kurtz wrote: > Hmm... below is my current understanding. > > In the current software architecture, we have split the "venc" > subsystem register space into two parts (two dt nodes), with each node > handled instantiated as its own platform

Re: [PATCH] soc: mediatek: Fix random hang up issue while kernel init

Hi Lucas, On Wed, 2015-09-30 at 11:07 +0200, Lucas Stach wrote: > > If the VENC power domain is disabled, then accesses to the vencsys > > registers just silently fail (i.e., reads probably > > return all 0s). > > If this ever happens it is really unfortunate and needs fixing, too. If > you

Re: [PATCH] soc: mediatek: Fix random hang up issue while kernel init

Hi Daniel, Thanks for your help to explain the patch. On Tue, 2015-09-29 at 18:25 +0800, Daniel Kurtz wrote: > On Sun, Sep 27, 2015 at 7:25 PM, Matthias Brugger > wrote: > >> But then we at least need a corresponding change to the binding > >> documentation. I'll send a new patch with

Re: [PATCH] soc: mediatek: Fix random hang up issue while kernel init

Hi Daniel, Thanks for your help to explain the patch. On Tue, 2015-09-29 at 18:25 +0800, Daniel Kurtz wrote: > On Sun, Sep 27, 2015 at 7:25 PM, Matthias Brugger > wrote: > >> But then we at least need a corresponding change to the binding > >> documentation. I'll send

Re: [PATCH] soc: mediatek: Fix random hang up issue while kernel init

Hi Lucas, On Wed, 2015-09-30 at 11:07 +0200, Lucas Stach wrote: > > If the VENC power domain is disabled, then accesses to the vencsys > > registers just silently fail (i.e., reads probably > > return all 0s). > > If this ever happens it is really unfortunate and needs fixing, too. If > you

Re: [PATCH] soc: mediatek: Fix random hang up issue while kernel init

Hi Daniel, On Thu, 2015-10-01 at 18:08 +0800, Daniel Kurtz wrote: > I see two cases where "a power domain is a consumer of a clock": > (a) the clock is needed to access the power domain control > registers. The clock must actually be in another power domain, since > otherwise you could never

Re: [PATCH] soc: mediatek: Fix random hang up issue while kernel init

Hi Daniel, On Thu, 2015-10-01 at 16:07 +0800, Daniel Kurtz wrote: > Hmm... below is my current understanding. > > In the current software architecture, we have split the "venc" > subsystem register space into two parts (two dt nodes), with each node > handled instantiated as its own platform

[GIT PULL] clk: mediatek: New clocks support and fixes

to cdb2bab78aff97101da767b9643fbd692af4623b: clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS (2015-05-20 15:59:21 +0800) James Liao (8): clk: mediatek: Removed unused dpi_ck clock from MT8173 clk: mediatek: Remove unused code from

[GIT PULL] clk: mediatek: New clocks support and fixes

to cdb2bab78aff97101da767b9643fbd692af4623b: clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS (2015-05-20 15:59:21 +0800) James Liao (8): clk: mediatek: Removed unused dpi_ck clock from MT8173 clk: mediatek: Remove unused code from

[PATCH] soc: mediatek: Fix random hang up issue while kernel init

accessing their registers. This patch keeps venc_sel / venclt_sel clock on when VENC / VENC_LT's power is on, to prevent system hang up while accessing its registeres. Signed-off-by: James Liao --- This patch is based on v4.3-rc2, to fix system hanging up issue while disabling unused clocks

[PATCH] soc: mediatek: Fix random hang up issue while kernel init

accessing their registers. This patch keeps venc_sel / venclt_sel clock on when VENC / VENC_LT's power is on, to prevent system hang up while accessing its registeres. Signed-off-by: James Liao <jamesjj.l...@mediatek.com> --- This patch is based on v4.3-rc2, to fix system hanging up issue

[GIT PULL] clk: mediatek: New clocks support and fixes

/linux.git v4.3-rc2-clk for you to fetch changes up to 74219612bb7e25e64409171acada05d9949228f2: arm64: dts: mt8173: Add subsystem clock controller device nodes (2015-07-09 12:58:14 +0800) James Liao (9): clk: mediatek: Removed

[GIT PULL] clk: mediatek: New clocks support and fixes

/linux.git v4.3-rc2-clk for you to fetch changes up to 74219612bb7e25e64409171acada05d9949228f2: arm64: dts: mt8173: Add subsystem clock controller device nodes (2015-07-09 12:58:14 +0800) James Liao (9): clk: mediatek: Removed

[GIT PULL] clk: mediatek: New clocks support and fixes

/linux.git v4.2-rc2-clk for you to fetch changes up to f4f5326e99f951c8dfed9c3f4d027a3246cb7a8b: clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS (2015-05-20 15:59:21 +0800) James Liao (8): clk: mediatek: Removed unused

[GIT PULL] clk: mediatek: New clocks support and fixes

/linux.git v4.2-rc2-clk for you to fetch changes up to f4f5326e99f951c8dfed9c3f4d027a3246cb7a8b: clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS (2015-05-20 15:59:21 +0800) James Liao (8): clk: mediatek: Removed unused

[PATCH v7 1/9] clk: mediatek: Removed unused dpi_ck clock from MT8173

The dpi_ck clock can be removed because it not actually used in topckgen and subsystems. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 1 - include/dt-bindings/clock/mt8173-clk.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b

[PATCH v7 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks

tree. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c index 361fe32..c251787 100644 --- a/drivers/clk/mediatek/clk-mt8173

[PATCH v7 4/9] clk: mediatek: Add fixed clocks support for Mediatek SoC.

This patch adds fixed clocks support by using CCF fixed-rate clock implementation. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mtk.c | 23 +++ drivers/clk/mediatek/clk-mtk.h | 17 + 2 files changed, 40 insertions(+) diff --git a/drivers/clk

[PATCH v7 0/9] Fixes and new clocks support for Mediatek MT8173

ch/6446341/ [2] https://lkml.org/lkml/2015/8/4/111 James Liao (9): clk: mediatek: Removed unused dpi_ck clock from MT8173 clk: mediatek: Remove unused code from MT8173. clk: mediatek: Add __initdata and __init for data and functions clk: mediatek: Add fixed clocks support for Mediatek

[PATCH v7 6/9] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers

This adds the binding documentation for the mmsys, imgsys, vdecsys, vencsys and vencltsys controllers found on Mediatek SoCs. Signed-off-by: James Liao --- .../bindings/arm/mediatek/mediatek,imgsys.txt | 22 ++ .../bindings/arm/mediatek/mediatek,mmsys.txt | 22

[PATCH v7 7/9] clk: mediatek: Add subsystem clocks of MT8173

Most multimedia subsystem clocks will be accessed by multiple drivers, so it's a better way to manage these clocks in CCF. This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT subsystems. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 267

[PATCH v7 2/9] clk: mediatek: Remove unused code from MT8173.

Remove unused header files from MT8173, and remove unused keywords from function declaration. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 2 -- drivers/clk/mediatek/clk-mtk.h| 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/mediatek

[PATCH v7 8/9] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Add REF2USB_TX clock support into MT8173 APMIXEDSYS. This clock is needed by USB 3.0. Signed-off-by: James Liao --- drivers/clk/mediatek/Makefile | 2 +- drivers/clk/mediatek/clk-apmixed.c | 107 + drivers/clk/mediatek/clk-mt8173.c | 47

[PATCH v7 9/9] arm64: dts: mt8173: Add subsystem clock controller device nodes

This patch adds device nodes providing subsystem clocks on MT8173, includes mmsys, imgsys, vdecsys, vencsys and vencltsys. Signed-off-by: James Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot

[PATCH v7 3/9] clk: mediatek: Add __initdata and __init for data and functions

Add __init for clock registration functions, and add __initdata for mtk_gate_regs initial structures. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-gate.c | 2 +- drivers/clk/mediatek/clk-mt8173.c | 6 +++--- drivers/clk/mediatek/clk-mtk.c| 13 +++-- 3 files changed, 11

[PATCH v7 7/9] clk: mediatek: Add subsystem clocks of MT8173

Most multimedia subsystem clocks will be accessed by multiple drivers, so it's a better way to manage these clocks in CCF. This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT subsystems. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c

[PATCH v7 8/9] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Add REF2USB_TX clock support into MT8173 APMIXEDSYS. This clock is needed by USB 3.0. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/Makefile | 2 +- drivers/clk/mediatek/clk-apmixed.c | 107 + drivers/clk/mediatek/clk

[PATCH v7 9/9] arm64: dts: mt8173: Add subsystem clock controller device nodes

This patch adds device nodes providing subsystem clocks on MT8173, includes mmsys, imgsys, vdecsys, vencsys and vencltsys. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 1 file changed, 37 insertions

[PATCH v7 3/9] clk: mediatek: Add __initdata and __init for data and functions

Add __init for clock registration functions, and add __initdata for mtk_gate_regs initial structures. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-gate.c | 2 +- drivers/clk/mediatek/clk-mt8173.c | 6 +++--- drivers/clk/mediatek/clk-mtk.c| 13

[PATCH v7 2/9] clk: mediatek: Remove unused code from MT8173.

Remove unused header files from MT8173, and remove unused keywords from function declaration. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 2 -- drivers/clk/mediatek/clk-mtk.h| 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v7 6/9] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers

This adds the binding documentation for the mmsys, imgsys, vdecsys, vencsys and vencltsys controllers found on Mediatek SoCs. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- .../bindings/arm/mediatek/mediatek,imgsys.txt | 22 ++ .../bindings/arm/mediatek/mediatek

[PATCH v7 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks

tree. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c index 361fe32..c251787 100644

[PATCH v7 4/9] clk: mediatek: Add fixed clocks support for Mediatek SoC.

This patch adds fixed clocks support by using CCF fixed-rate clock implementation. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mtk.c | 23 +++ drivers/clk/mediatek/clk-mtk.h | 17 + 2 files changed, 40 insertions(+) diff

[PATCH v7 0/9] Fixes and new clocks support for Mediatek MT8173

] https://lkml.org/lkml/2015/8/4/111 James Liao (9): clk: mediatek: Removed unused dpi_ck clock from MT8173 clk: mediatek: Remove unused code from MT8173. clk: mediatek: Add __initdata and __init for data and functions clk: mediatek: Add fixed clocks support for Mediatek SoC. clk

[PATCH v7 1/9] clk: mediatek: Removed unused dpi_ck clock from MT8173

The dpi_ck clock can be removed because it not actually used in topckgen and subsystems. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 1 - include/dt-bindings/clock/mt8173-clk.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/clk

Re: [PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Hi Sascha, On Thu, 2015-08-06 at 12:20 +0200, Sascha Hauer wrote: > On Thu, Aug 06, 2015 at 05:13:21PM +0800, Daniel Kurtz wrote: > > On Thu, Aug 6, 2015 at 5:00 PM, James Liao > > wrote: > > > Hi Sascha, > > > > > > On Thu, 2015-08-06 at 10:53 +0200,

Re: [PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Hi Sascha, On Thu, 2015-08-06 at 10:53 +0200, Sascha Hauer wrote: > On Thu, Aug 06, 2015 at 04:23:51PM +0800, James Liao wrote: > > On Wed, 2015-08-05 at 08:46 +0200, Sascha Hauer wrote: > > > On Tue, Aug 04, 2015 at 04:16:56PM +0800, James Liao wrote: > > > > sta

Re: [PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks

Hi Sascha, On Wed, 2015-08-05 at 08:53 +0200, Sascha Hauer wrote: > On Tue, Aug 04, 2015 at 04:16:54PM +0800, James Liao wrote: > > -static const struct mtk_fixed_factor root_clk_alias[] __initconst = { > > - FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "cl

Re: [PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Hi Sascha, On Wed, 2015-08-05 at 08:46 +0200, Sascha Hauer wrote: > On Tue, Aug 04, 2015 at 04:16:56PM +0800, James Liao wrote: > > static const struct mtk_fixed_clk fixed_clks[] __initconst = { > > FIXED_CLK(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk26m&q

Re: [PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Hi Sascha, On Thu, 2015-08-06 at 12:20 +0200, Sascha Hauer wrote: On Thu, Aug 06, 2015 at 05:13:21PM +0800, Daniel Kurtz wrote: On Thu, Aug 6, 2015 at 5:00 PM, James Liao jamesjj.l...@mediatek.com wrote: Hi Sascha, On Thu, 2015-08-06 at 10:53 +0200, Sascha Hauer wrote: On Thu

Re: [PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Hi Sascha, On Wed, 2015-08-05 at 08:46 +0200, Sascha Hauer wrote: On Tue, Aug 04, 2015 at 04:16:56PM +0800, James Liao wrote: static const struct mtk_fixed_clk fixed_clks[] __initconst = { FIXED_CLK(CLK_TOP_CLKPH_MCK_O, clkph_mck_o, clk26m, 400 * MHZ), FIXED_CLK

Re: [PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks

Hi Sascha, On Wed, 2015-08-05 at 08:53 +0200, Sascha Hauer wrote: On Tue, Aug 04, 2015 at 04:16:54PM +0800, James Liao wrote: -static const struct mtk_fixed_factor root_clk_alias[] __initconst = { - FACTOR(CLK_TOP_CLKPH_MCK_O, clkph_mck_o, clk_null, 1, 1), - FACTOR

Re: [PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Hi Sascha, On Thu, 2015-08-06 at 10:53 +0200, Sascha Hauer wrote: On Thu, Aug 06, 2015 at 04:23:51PM +0800, James Liao wrote: On Wed, 2015-08-05 at 08:46 +0200, Sascha Hauer wrote: On Tue, Aug 04, 2015 at 04:16:56PM +0800, James Liao wrote: static const struct mtk_fixed_clk fixed_clks

[PATCH v6 1/9] clk: mediatek: Removed unused dpi_ck clock from MT8173

The dpi_ck clock can be removed because it not actually used in topckgen and subsystems. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 1 - include/dt-bindings/clock/mt8173-clk.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b

[PATCH v6 3/9] clk: mediatek: Add __initdata and __init for data and functions

Add __init for clock registration functions, and add __initdata for mtk_gate_regs initial structures. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-gate.c | 2 +- drivers/clk/mediatek/clk-mt8173.c | 6 +++--- drivers/clk/mediatek/clk-mtk.c| 13 +++-- 3 files changed, 11

[PATCH v6 4/9] clk: mediatek: Add fixed clocks support for Mediatek SoC.

This patch adds fixed clocks support by using CCF fixed-rate clock implementation. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mtk.c | 23 +++ drivers/clk/mediatek/clk-mtk.h | 17 + 2 files changed, 40 insertions(+) diff --git a/drivers/clk

[PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Most multimedia subsystem clocks will be accessed by multiple drivers, so it's a better way to manage these clocks in CCF. This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT subsystems. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 267

[PATCH v6 9/9] arm64: dts: mt8173: Add subsystem clock controller device nodes

This patch adds device nodes providing subsystem clocks on MT8173, includes mmsys, imgsys, vdecsys, vencsys and vencltsys. Signed-off-by: James Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot

[PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks

tree. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c index 361fe32..f37ace6 100644 --- a/drivers/clk/mediatek/clk-mt8173.c +++ b

[PATCH v6 8/9] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Add REF2USB_TX clock support into MT8173 APMIXEDSYS. This clock is needed by USB 3.0. Signed-off-by: James Liao --- drivers/clk/mediatek/Makefile | 2 +- drivers/clk/mediatek/clk-apmixed.c | 107 + drivers/clk/mediatek/clk-mt8173.c | 47

[PATCH v6 2/9] clk: mediatek: Remove unused code from MT8173.

Remove unused header files from MT8173, and remove unused keywords from function declaration. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 2 -- drivers/clk/mediatek/clk-mtk.h| 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/mediatek

[PATCH v6 6/9] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers

This adds the binding documentation for the mmsys, imgsys, vdecsys, vencsys and vencltsys controllers found on Mediatek SoCs. Signed-off-by: James Liao --- .../bindings/arm/mediatek/mediatek,imgsys.txt | 22 ++ .../bindings/arm/mediatek/mediatek,mmsys.txt | 22

[PATCH v6 0/9] Fixes and new clocks support for Mediatek MT8173

x-mediatek/2015-July/001800.html James Liao (9): clk: mediatek: Removed unused dpi_ck clock from MT8173 clk: mediatek: Remove unused code from MT8173. clk: mediatek: Add __initdata and __init for data and functions clk: mediatek: Add fixed clocks support for Mediatek SoC. clk: mediatek

[PATCH v6 3/9] clk: mediatek: Add __initdata and __init for data and functions

Add __init for clock registration functions, and add __initdata for mtk_gate_regs initial structures. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-gate.c | 2 +- drivers/clk/mediatek/clk-mt8173.c | 6 +++--- drivers/clk/mediatek/clk-mtk.c| 13

[PATCH v6 5/9] clk: mediatek: Fix rate and dependency of MT8173 clocks

tree. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c index 361fe32..f37ace6 100644 --- a/drivers/clk

[PATCH v6 8/9] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Add REF2USB_TX clock support into MT8173 APMIXEDSYS. This clock is needed by USB 3.0. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/Makefile | 2 +- drivers/clk/mediatek/clk-apmixed.c | 107 + drivers/clk/mediatek/clk

[PATCH v6 1/9] clk: mediatek: Removed unused dpi_ck clock from MT8173

The dpi_ck clock can be removed because it not actually used in topckgen and subsystems. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 1 - include/dt-bindings/clock/mt8173-clk.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/clk

[PATCH v6 0/9] Fixes and new clocks support for Mediatek MT8173

/2015-July/001800.html James Liao (9): clk: mediatek: Removed unused dpi_ck clock from MT8173 clk: mediatek: Remove unused code from MT8173. clk: mediatek: Add __initdata and __init for data and functions clk: mediatek: Add fixed clocks support for Mediatek SoC. clk: mediatek: Fix rate

[PATCH v6 6/9] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers

This adds the binding documentation for the mmsys, imgsys, vdecsys, vencsys and vencltsys controllers found on Mediatek SoCs. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- .../bindings/arm/mediatek/mediatek,imgsys.txt | 22 ++ .../bindings/arm/mediatek/mediatek

[PATCH v6 2/9] clk: mediatek: Remove unused code from MT8173.

Remove unused header files from MT8173, and remove unused keywords from function declaration. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 2 -- drivers/clk/mediatek/clk-mtk.h| 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v6 7/9] clk: mediatek: Add subsystem clocks of MT8173

Most multimedia subsystem clocks will be accessed by multiple drivers, so it's a better way to manage these clocks in CCF. This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT subsystems. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c

[PATCH v6 9/9] arm64: dts: mt8173: Add subsystem clock controller device nodes

This patch adds device nodes providing subsystem clocks on MT8173, includes mmsys, imgsys, vdecsys, vencsys and vencltsys. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 1 file changed, 37 insertions

[PATCH v6 4/9] clk: mediatek: Add fixed clocks support for Mediatek SoC.

This patch adds fixed clocks support by using CCF fixed-rate clock implementation. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mtk.c | 23 +++ drivers/clk/mediatek/clk-mtk.h | 17 + 2 files changed, 40 insertions(+) diff

Re: [PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks

Hi Stephen, On Wed, 2015-07-29 at 17:27 -0700, Stephen Boyd wrote: > On 07/29, James Liao wrote: > > From: Sascha Hauer > > > > On the MT8173 the clocks are provided by different units. To enable > > the critical clocks we must be sure that all parent clocks

Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173

Hi Stephen, Could you help to apply this patch into 4.2? Best regards, James On Wed, 2015-07-29 at 09:05 +0200, Heiko Stübner wrote: > Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao: > > The dpi_ck clock can be removed because it not actually used > > in topckgen

[PATCH v5 00/10] Fixes and new clocks support for Mediatek MT8173

and CA15PLL as critical clocks. - Use the same register descriptor for imgsys, vensys and vencltsys. - Generalize apmixedsys special clocks registration. [1] https://patchwork.kernel.org/patch/6446341/ [2] https://lkml.org/lkml/2015/7/23/911 James Liao (9): clk: mediatek: Removed unused dpi_ck clock from

[PATCH v5 04/10] clk: mediatek: Add fixed clocks support for Mediatek SoC.

This patch adds fixed clocks support by using CCF fixed-rate clock implementation. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mtk.c | 23 +++ drivers/clk/mediatek/clk-mtk.h | 17 + 2 files changed, 40 insertions(+) diff --git a/drivers/clk

[PATCH v5 03/10] clk: mediatek: Add __initdata and __init for data and functions

Add __init for clock registration functions, and add __initdata for mtk_gate_regs initial structures. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-gate.c | 2 +- drivers/clk/mediatek/clk-mt8173.c | 6 +++--- drivers/clk/mediatek/clk-mtk.c| 13 +++-- 3 files changed, 11

[PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks

now and only then we enable the critical clocks. Signed-off-by: Sascha Hauer Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk

[PATCH v5 02/10] clk: mediatek: Remove unused code from MT8173.

Remove unused header files from MT8173, and remove unused keywords from function declaration. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 2 -- drivers/clk/mediatek/clk-mtk.h| 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/mediatek

[PATCH v5 10/10] arm64: dts: mt8173: Add subsystem clock controller device nodes

This patch adds device nodes providing subsystem clocks on MT8173, includes mmsys, imgsys, vdecsys, vencsys and vencltsys. Signed-off-by: James Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot

[PATCH v5 07/10] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers

This adds the binding documentation for the mmsys, imgsys, vdecsys, vencsys and vencltsys controllers found on Mediatek SoCs. Signed-off-by: James Liao --- .../bindings/arm/mediatek/mediatek,imgsys.txt | 22 ++ .../bindings/arm/mediatek/mediatek,mmsys.txt | 22

[PATCH v5 05/10] clk: mediatek: Fix rate and dependency of MT8173 clocks

tree. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c index a33a531..412c36d 100644 --- a/drivers/clk/mediatek/clk-mt8173.c +++ b

[PATCH v5 08/10] clk: mediatek: Add subsystem clocks of MT8173

Most multimedia subsystem clocks will be accessed by multiple drivers, so it's a better way to manage these clocks in CCF. This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT subsystems. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 267

[PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173

The dpi_ck clock can be removed because it not actually used in topckgen and subsystems. Signed-off-by: James Liao --- drivers/clk/mediatek/clk-mt8173.c | 1 - include/dt-bindings/clock/mt8173-clk.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b

[PATCH v5 09/10] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Add REF2USB_TX clock support into MT8173 APMIXEDSYS. This clock is needed by USB 3.0. Signed-off-by: James Liao --- drivers/clk/mediatek/Makefile | 2 +- drivers/clk/mediatek/clk-apmixed.c | 107 + drivers/clk/mediatek/clk-mt8173.c | 47

Re: [PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks

Hi Stephen, On Wed, 2015-07-29 at 17:27 -0700, Stephen Boyd wrote: On 07/29, James Liao wrote: From: Sascha Hauer s.ha...@pengutronix.de On the MT8173 the clocks are provided by different units. To enable the critical clocks we must be sure that all parent clocks are already

Re: [PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173

Hi Stephen, Could you help to apply this patch into 4.2? Best regards, James On Wed, 2015-07-29 at 09:05 +0200, Heiko Stübner wrote: Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao: The dpi_ck clock can be removed because it not actually used in topckgen and subsystems

[PATCH v5 08/10] clk: mediatek: Add subsystem clocks of MT8173

Most multimedia subsystem clocks will be accessed by multiple drivers, so it's a better way to manage these clocks in CCF. This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT subsystems. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c

[PATCH v5 09/10] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Add REF2USB_TX clock support into MT8173 APMIXEDSYS. This clock is needed by USB 3.0. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/Makefile | 2 +- drivers/clk/mediatek/clk-apmixed.c | 107 + drivers/clk/mediatek/clk

[PATCH v5 01/10] clk: mediatek: Removed unused dpi_ck clock from MT8173

The dpi_ck clock can be removed because it not actually used in topckgen and subsystems. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 1 - include/dt-bindings/clock/mt8173-clk.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/clk

[PATCH v5 00/10] Fixes and new clocks support for Mediatek MT8173

and CA15PLL as critical clocks. - Use the same register descriptor for imgsys, vensys and vencltsys. - Generalize apmixedsys special clocks registration. [1] https://patchwork.kernel.org/patch/6446341/ [2] https://lkml.org/lkml/2015/7/23/911 James Liao (9): clk: mediatek: Removed unused dpi_ck clock from

[PATCH v5 04/10] clk: mediatek: Add fixed clocks support for Mediatek SoC.

This patch adds fixed clocks support by using CCF fixed-rate clock implementation. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mtk.c | 23 +++ drivers/clk/mediatek/clk-mtk.h | 17 + 2 files changed, 40 insertions(+) diff

[PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of critical clocks

providers are present now and only then we enable the critical clocks. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff

[PATCH v5 03/10] clk: mediatek: Add __initdata and __init for data and functions

Add __init for clock registration functions, and add __initdata for mtk_gate_regs initial structures. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-gate.c | 2 +- drivers/clk/mediatek/clk-mt8173.c | 6 +++--- drivers/clk/mediatek/clk-mtk.c| 13

[PATCH v5 02/10] clk: mediatek: Remove unused code from MT8173.

Remove unused header files from MT8173, and remove unused keywords from function declaration. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 2 -- drivers/clk/mediatek/clk-mtk.h| 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v5 05/10] clk: mediatek: Fix rate and dependency of MT8173 clocks

tree. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- drivers/clk/mediatek/clk-mt8173.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c index a33a531..412c36d 100644 --- a/drivers/clk

[PATCH v5 10/10] arm64: dts: mt8173: Add subsystem clock controller device nodes

This patch adds device nodes providing subsystem clocks on MT8173, includes mmsys, imgsys, vdecsys, vencsys and vencltsys. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 1 file changed, 37 insertions

[PATCH v5 07/10] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers

This adds the binding documentation for the mmsys, imgsys, vdecsys, vencsys and vencltsys controllers found on Mediatek SoCs. Signed-off-by: James Liao jamesjj.l...@mediatek.com --- .../bindings/arm/mediatek/mediatek,imgsys.txt | 22 ++ .../bindings/arm/mediatek/mediatek

Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes

On Mon, 2015-07-27 at 03:21 -0700, Matthias Brugger wrote: > On Monday, July 27, 2015 10:56:22 AM James Liao wrote: > > Hi Daniel, > > > > On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote: > > > > @@ -88,6 +88,13 @@ > > > &g

Re: [PATCH v4 2/7] clk: mediatek: Fix rate and dependency of MT8173 clocks

Hi, On Mon, 2015-07-27 at 09:52 +0200, Heiko Stübner wrote: > Am Montag, 27. Juli 2015, 14:19:41 schrieb Daniel Kurtz: > > On Jul 27, 2015 12:52, "Sascha Hauer" wrote: > > > On Fri, Jul 24, 2015 at 07:10:14PM +0800, Daniel Kurtz wrote: > > > > > /* TOPCKGEN */ > > > > > > > > > > #define

Re: [PATCH v4 1/7] clk: mediatek: Add fixed clocks support for Mediatek SoC.

Hi Daniel, On Fri, 2015-07-24 at 19:33 +0800, Daniel Kurtz wrote: > Hi James, > > On Fri, Jul 24, 2015 at 11:01 AM, James Liao > wrote: > > > > +void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, int num, > > + struct clk_onecel

Re: [PATCH v4 6/7] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Hi Daniel, On Fri, 2015-07-24 at 19:28 +0800, Daniel Kurtz wrote: > On Fri, Jul 24, 2015 at 11:02 AM, James Liao > wrote: > > +struct clk *mtk_clk_register_ref2usb_tx(const char *name, > > + const char *parent_name, void __iomem *reg) >

Re: [PATCH v4 5/7] clk: mediatek: Add subsystem clocks of MT8173

Hi Daniel, On Fri, 2015-07-24 at 19:18 +0800, Daniel Kurtz wrote: > On Fri, Jul 24, 2015 at 11:02 AM, James Liao > wrote: > > +static const struct mtk_gate_regs cg_regs_4_8_0 = { > > All of these regs tables can be __initconst. It will be added in next patch. Be

Re: [PATCH v4 5/7] clk: mediatek: Add subsystem clocks of MT8173

Hi Daniel, On Fri, 2015-07-24 at 19:18 +0800, Daniel Kurtz wrote: On Fri, Jul 24, 2015 at 11:02 AM, James Liao jamesjj.l...@mediatek.com wrote: +static const struct mtk_gate_regs cg_regs_4_8_0 = { All of these regs tables can be __initconst. It will be added in next patch. Best regards

Re: [PATCH v4 1/7] clk: mediatek: Add fixed clocks support for Mediatek SoC.

Hi Daniel, On Fri, 2015-07-24 at 19:33 +0800, Daniel Kurtz wrote: Hi James, On Fri, Jul 24, 2015 at 11:01 AM, James Liao jamesjj.l...@mediatek.com wrote: +void mtk_clk_register_fixed_clks(const struct mtk_fixed_clk *clks, int num, + struct clk_onecell_data *clk_data

Re: [PATCH v4 2/7] clk: mediatek: Fix rate and dependency of MT8173 clocks

Hi, On Mon, 2015-07-27 at 09:52 +0200, Heiko Stübner wrote: Am Montag, 27. Juli 2015, 14:19:41 schrieb Daniel Kurtz: On Jul 27, 2015 12:52, Sascha Hauer s.ha...@pengutronix.de wrote: On Fri, Jul 24, 2015 at 07:10:14PM +0800, Daniel Kurtz wrote: /* TOPCKGEN */ #define

Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes

On Mon, 2015-07-27 at 03:21 -0700, Matthias Brugger wrote: On Monday, July 27, 2015 10:56:22 AM James Liao wrote: Hi Daniel, On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote: @@ -88,6 +88,13 @@ #clock-cells = 0

Re: [PATCH v4 6/7] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS

Hi Daniel, On Fri, 2015-07-24 at 19:28 +0800, Daniel Kurtz wrote: On Fri, Jul 24, 2015 at 11:02 AM, James Liao jamesjj.l...@mediatek.com wrote: +struct clk *mtk_clk_register_ref2usb_tx(const char *name, + const char *parent_name, void __iomem *reg) struct clk

Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes

Hi Daniel, On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote: > > @@ -88,6 +88,13 @@ > > #clock-cells = <0>; > > }; > > > > + cpum_ck: dummy_clk { > > I'm not a big fan of this "dummy_clk". > The 'name' part of the devicetree node is supposed to be generic. >

<    1   2   3   4   5   6   >