fic code has
> to go. The poisioning could be introduced into the infrastructure
> at some later date.
If it's useful, it should be incorporated into core LSM, otherwise that's
a regression for SELinux.
--
James Morris
gt; + return -EACCES;
> + if (task_active_pid_ns(current) != task_active_pid_ns(p))
> + return -EACCES;
> + return 0;
I really don't like the idea of hard-coding namespace security semantics
in an LSM. Also, I'm not sure if these semantics make any sense.
It least make it user configurable.
--
James Morris
gt; + return -EACCES;
> + if (task_active_pid_ns(current) != task_active_pid_ns(p))
> + return -EACCES;
> + return 0;
I really don't like the idea of hard-coding namespace security semantics
in an LSM. Also, I'm not sure if these semantics make any sense.
It least make it user configurable.
--
James Morris
mediated by LSM at a
high level (security_file_ioctl). Some problematic ones are singled out at
that point by LSMs for special handling.
--
James Morris
mediated by LSM at a
high level (security_file_ioctl). Some problematic ones are singled out at
that point by LSMs for special handling.
--
James Morris
> change that needs reverting.
>
> Yes, as that's obviously correct. I think you should wait for your
> patch 2 here until 4.20-rc1, as this isn't a "fix" that is required at
> this point in time.
Ok, I'll queue this for the merge window.
--
James Morris
> change that needs reverting.
>
> Yes, as that's obviously correct. I think you should wait for your
> patch 2 here until 4.20-rc1, as this isn't a "fix" that is required at
> this point in time.
Ok, I'll queue this for the merge window.
--
James Morris
Please pull this revert and update, from David Howells:
"Here's a pair of fixes that need to go upstream asap, please:
(1) Revert an incorrect fix to the keyrings UAPI for a C++ reserved word
used as a struct member name. This change being reverted breaks
existing userspace code and
Please pull this revert and update, from David Howells:
"Here's a pair of fixes that need to go upstream asap, please:
(1) Revert an incorrect fix to the keyrings UAPI for a C++ reserved word
used as a struct member name. This change being reverted breaks
existing userspace code and
On Tue, 11 Sep 2018, Casey Schaufler wrote:
> LSM: Module stacking in support of S.A.R.A and Landlock
Please help prevent RSI and shorten this to SARA.
--
James Morris
On Tue, 11 Sep 2018, Casey Schaufler wrote:
> LSM: Module stacking in support of S.A.R.A and Landlock
Please help prevent RSI and shorten this to SARA.
--
James Morris
this code. In addition, we have test cases for
> it in ELL (embedded linux library).
>
> Tested-by: Marcel Holtmann
> Reviewed-by: Marcel Holtmann
Thanks!
--
James Morris
this code. In addition, we have test cases for
> it in ELL (embedded linux library).
>
> Tested-by: Marcel Holtmann
> Reviewed-by: Marcel Holtmann
Thanks!
--
James Morris
l.org
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing.
Thanks!
--
James Morris
l.org
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing.
Thanks!
--
James Morris
ed out it doesn't really work to have a generic series against 20
> > trees :-/
>
> I know that pain very well!
>
> > I'm submitting them individually to each subsystem.
> > So this one is just for security.
>
> Sounds good.
>
> James, can you take this directly, or would you prefer a pull request from me?
I'll take it with your ack.
--
James Morris
ed out it doesn't really work to have a generic series against 20
> > trees :-/
>
> I know that pain very well!
>
> > I'm submitting them individually to each subsystem.
> > So this one is just for security.
>
> Sounds good.
>
> James, can you take this directly, or would you prefer a pull request from me?
I'll take it with your ack.
--
James Morris
On Wed, 5 Sep 2018, David Howells wrote:
>
> Hi James,
>
> Here's a set of patches that does the following, if you could pull it please:
Thanks, it would be good to see more review / acks, though.
--
James Morris
On Wed, 5 Sep 2018, David Howells wrote:
>
> Hi James,
>
> Here's a set of patches that does the following, if you could pull it please:
Thanks, it would be good to see more review / acks, though.
--
James Morris
On Tue, 4 Sep 2018, Ding Xiang wrote:
> simple_strtoul is obsolete, and use kstrtouint instead
>
> Signed-off-by: Ding Xiang
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing.
--
James Morris
On Tue, 4 Sep 2018, Ding Xiang wrote:
> simple_strtoul is obsolete, and use kstrtouint instead
>
> Signed-off-by: Ding Xiang
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing.
--
James Morris
On Wed, 22 Aug 2018, Christian Brauner wrote:
> bprm_caps_from_vfs_caps() never returned -EINVAL so remove the
> rc == -EINVAL check.
>
> Signed-off-by: Christian Brauner
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
--
James Morris
On Wed, 22 Aug 2018, Christian Brauner wrote:
> bprm_caps_from_vfs_caps() never returned -EINVAL so remove the
> rc == -EINVAL check.
>
> Signed-off-by: Christian Brauner
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
--
James Morris
d-by: Serge Hallyn
Thanks, I'll queue this for post -rc1 next-general.
--
James Morris
d-by: Serge Hallyn
Thanks, I'll queue this for post -rc1 next-general.
--
James Morris
>From Mimi Zohar:
"This pull request adds support for EVM signatures based on larger
digests, contains a new audit record AUDIT_INTEGRITY_POLICY_RULE to
differentiate the IMA policy rules from the IMA-audit messages,
addresses two deadlocks due to either loading or searching for crypto
>From Mimi Zohar:
"This pull request adds support for EVM signatures based on larger
digests, contains a new audit record AUDIT_INTEGRITY_POLICY_RULE to
differentiate the IMA policy rules from the IMA-audit messages,
addresses two deadlocks due to either loading or searching for crypto
0728' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm (2018-07-30
09:30:19 -0700)
----
James Morris (1):
Merge tag 'tpmdd-next-20180728' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm
Jarkko Sakkinen (5):
0728' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm (2018-07-30
09:30:19 -0700)
----
James Morris (1):
Merge tag 'tpmdd-next-20180728' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm
Jarkko Sakkinen (5):
)
James Morris (1):
Merge branch 'smack-for-4.19-a' of
https://github.com/cschaufler/next-smack into next-smack
Piotr Sawicki (3):
Smack: Fix handling of IPv4 traffic received by PF_INET6 sockets
Smack: Check UDP-Lite and DCCP
)
James Morris (1):
Merge branch 'smack-for-4.19-a' of
https://github.com/cschaufler/next-smack into next-smack
Piotr Sawicki (3):
Smack: Fix handling of IPv4 traffic received by PF_INET6 sockets
Smack: Check UDP-Lite and DCCP
On Tue, 14 Aug 2018, David Jacobson wrote:
> This patchset introduces evmtest — a stand alone tool for regression
> testing IMA.
Nice!
I usually run the SELinux testsuite as a general sanity check of LSM
before pushing to Linus, and I'll also run this once it's merged.
--
James Morris
On Tue, 14 Aug 2018, David Jacobson wrote:
> This patchset introduces evmtest — a stand alone tool for regression
> testing IMA.
Nice!
I usually run the SELinux testsuite as a general sanity check of LSM
before pushing to Linus, and I'll also run this once it's merged.
--
James Morris
On Tue, 14 Aug 2018, James Morris wrote:
> I'll followup with updates for Smack and TPM once this is merged.
As well as an update for the Integrity subsystem.
--
James Morris
On Tue, 14 Aug 2018, James Morris wrote:
> I'll followup with updates for Smack and TPM once this is merged.
As well as an update for the Integrity subsystem.
--
James Morris
):
security: export security_kernel_load_data function
Eric Biggers (1):
security: check for kstrdup() failure in lsm_append()
James Morris (1):
Merge tag 'v4.18-rc2' into next-general
Mimi Zohar (8):
security: define new LSM hook named security_kernel_load_data
kexec
):
security: export security_kernel_load_data function
Eric Biggers (1):
security: check for kstrdup() failure in lsm_append()
James Morris (1):
Merge tag 'v4.18-rc2' into next-general
Mimi Zohar (8):
security: define new LSM hook named security_kernel_load_data
kexec
On Wed, 1 Aug 2018, David Howells wrote:
> (2) A hook to snoop source specifications.
What are source specifications?
--
James Morris
On Wed, 1 Aug 2018, David Howells wrote:
> (2) A hook to snoop source specifications.
What are source specifications?
--
James Morris
a policy generally of
the kernel that we only add features to support in-tree code.
--
James Morris
a policy generally of
the kernel that we only add features to support in-tree code.
--
James Morris
On Tue, 31 Jul 2018, Micah Morton wrote:
> +static inline int security_task_fix_setgid(struct cred *new,
> +const struct cred *old,
> +int flags)
> +{
> + return 0;
> +}
> +
This looks whitespace-damaged. Please send patches as plain text.
--
James Morris
On Tue, 31 Jul 2018, Micah Morton wrote:
> +static inline int security_task_fix_setgid(struct cred *new,
> +const struct cred *old,
> +int flags)
> +{
> + return 0;
> +}
> +
This looks whitespace-damaged. Please send patches as plain text.
--
James Morris
* Bug fixes and clean ups.
Thanks, pulled to next-tpm and next-testing.
--
James Morris
* Bug fixes and clean ups.
Thanks, pulled to next-tpm and next-testing.
--
James Morris
rnd Bergmann
Thanks!
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
--
James Morris
rnd Bergmann
Thanks!
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
--
James Morris
anyone does not vote against, I'll send a patch.
>
For Keys? That would would be useful to help reduce the workload on
David.
--
James Morris
anyone does not vote against, I'll send a patch.
>
For Keys? That would would be useful to help reduce the workload on
David.
--
James Morris
t; Nick Desaulniers (1):
> certs/blacklist: fix const confusion
>
>
> certs/blacklist.h |2 +-
> crypto/asymmetric_keys/x509_cert_parser.c |9 +
> security/keys/dh.c|6 --
> 3 files changed, 14 insertions(+), 3 deletions(-)
>
--
James Morris
t; Nick Desaulniers (1):
> certs/blacklist: fix const confusion
>
>
> certs/blacklist.h |2 +-
> crypto/asymmetric_keys/x509_cert_parser.c |9 +
> security/keys/dh.c|6 --
> 3 files changed, 14 insertions(+), 3 deletions(-)
>
--
James Morris
---
> Casey Schaufler (1):
> Smack: Mark inode instant in smack_task_to_inode
>
> security/smack/smack_lsm.c | 1 +
> 1 file changed, 1 insertion(+)
>
--
James Morris
---
> Casey Schaufler (1):
> Smack: Mark inode instant in smack_task_to_inode
>
> security/smack/smack_lsm.c | 1 +
> 1 file changed, 1 insertion(+)
>
--
James Morris
ck
into next-smack (2018-06-05 13:18:58 -0700)
Casey Schaufler (1):
Smack: Fix memory leak in smack_inode_getsecctx
James Morris (1):
Merge branch 'smack-for-4.18' of https://github.com/cschaufler/next-smack
in
ck
into next-smack (2018-06-05 13:18:58 -0700)
Casey Schaufler (1):
Smack: Fix memory leak in smack_inode_getsecctx
James Morris (1):
Merge branch 'smack-for-4.18' of https://github.com/cschaufler/next-smack
in
lling mistake in macro ST33ZP24_TISREGISTER_UKNOWN
James Morris (2):
Merge tag 'tpmdd-next-20180518' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm
Merge tag 'tpmdd-next-20180602' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm
Jerry Snitselaar (1):
lling mistake in macro ST33ZP24_TISREGISTER_UKNOWN
James Morris (2):
Merge tag 'tpmdd-next-20180518' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm
Merge tag 'tpmdd-next-20180602' of
git://git.infradead.org/users/jjs/linux-tpmdd into next-tpm
Jerry Snitselaar (1):
Please pull these updates for the Integrity subsystem.
>From Mimi:
- adds run time support for specifying additional security xattrs
included in the security.evm HMAC/signature
- some code clean up and bug fixes.
---
The following changes since commit
Please pull these updates for the Integrity subsystem.
>From Mimi:
- adds run time support for specifying additional security xattrs
included in the security.evm HMAC/signature
- some code clean up and bug fixes.
---
The following changes since commit
security: add hook for socketpair()
net: hook socketpair() into LSM
selinux: provide socketpair callback
James Morris (2):
Merge tag 'v4.17-rc2' into next-general
Merge tag 'v4.17-rc3' into next-general
Sargun Dhillon (1):
security: remove security_settime
Tom Gu
security: add hook for socketpair()
net: hook socketpair() into LSM
selinux: provide socketpair callback
James Morris (2):
Merge tag 'v4.17-rc2' into next-general
Merge tag 'v4.17-rc3' into next-general
Sargun Dhillon (1):
security: remove security_settime
Tom Gu
mmon_write()
>
> drivers/char/tpm/tpm-dev-common.c | 40
> ++-
> drivers/char/tpm/tpm-dev.h| 2 +-
> 2 files changed, 19 insertions(+), 23 deletions(-)
>
--
James Morris
mmon_write()
>
> drivers/char/tpm/tpm-dev-common.c | 40
> ++-
> drivers/char/tpm/tpm-dev.h| 2 +-
> 2 files changed, 19 insertions(+), 23 deletions(-)
>
--
James Morris
file_read and
> security_kernel_file_post_read have been abused for.
NAK. This abstraction is too semantically weak.
LSM hooks need to map to stronger semantics so we can reason about what
the hook and the policy is supposed to be mediating.
--
James Morris
<jmor...@namei.org>
file_read and
> security_kernel_file_post_read have been abused for.
NAK. This abstraction is too semantically weak.
LSM hooks need to map to stronger semantics so we can reason about what
the hook and the policy is supposed to be mediating.
--
James Morris
jmorris/linux-security.git
next-tpm
and next-testing
--
James Morris
<jmor...@namei.org>
jmorris/linux-security.git
next-tpm
and next-testing
--
James Morris
hen instead
of two if (!file && read_id == X) checks, have:
if (!file) {
switch (read_id) {
}
}
--
James Morris
<jmor...@namei.org>
if (!file && read_id == X) checks, have:
if (!file) {
switch (read_id) {
}
}
--
James Morris
l applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing
Thanks!
--
James Morris
<jmor...@namei.org>
l applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing
Thanks!
--
James Morris
ncrypted-keys/encrypted.c | 63
> ++--
> 1 file changed, 28 insertions(+), 35 deletions(-)
Reviewed-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
ed-keys/encrypted.c | 63
> ++--
> 1 file changed, 28 insertions(+), 35 deletions(-)
Reviewed-by: James Morris
--
James Morris
Chehab <mchehab+sams...@kernel.org>
Acked-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
ab
Acked-by: James Morris
--
James Morris
On Thu, 10 May 2018, James Morris wrote:
> >
> > Reviewed-by: Kees Cook <keesc...@chromium.org>
> >
> > James, are these something you can take into your tree?
>
> Sure!
Although, normally, these would likely come in to mine via David's tree.
Please d
On Thu, 10 May 2018, James Morris wrote:
> >
> > Reviewed-by: Kees Cook
> >
> > James, are these something you can take into your tree?
>
> Sure!
Although, normally, these would likely come in to mine via David's tree.
Please do that unless there's a special case here.
--
James Morris
fails
> > * define a constant for big key IV size so it can be changed along side
> > the algorithm in the code
> >
> > Signed-off-by: Tycho Andersen <ty...@tycho.ws>
> > CC: David Howells <dhowe...@redhat.com>
> > CC: James Morris <jmor...
a constant for big key IV size so it can be changed along side
> > the algorithm in the code
> >
> > Signed-off-by: Tycho Andersen
> > CC: David Howells
> > CC: James Morris
> > CC: "Serge E. Hallyn"
> > CC: Jason A. Done
On Wed, 9 May 2018, Ji-Hun Kim wrote:
> Use kmemdup rather than duplicating its implementation.
>
> Signed-off-by: Ji-Hun Kim <ji_hun@samsung.com>
Reviewed-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
On Wed, 9 May 2018, Ji-Hun Kim wrote:
> Use kmemdup rather than duplicating its implementation.
>
> Signed-off-by: Ji-Hun Kim
Reviewed-by: James Morris
--
James Morris
On Wed, 9 May 2018, Ji-Hun Kim wrote:
> Use kmemdup rather than duplicating its implementation.
>
> Signed-off-by: Ji-Hun Kim <ji_hun@samsung.com>
Reviewed-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
On Wed, 9 May 2018, Ji-Hun Kim wrote:
> Use kmemdup rather than duplicating its implementation.
>
> Signed-off-by: Ji-Hun Kim
Reviewed-by: James Morris
--
James Morris
On Fri, 4 May 2018, David Herrmann wrote:
> Hi
>
> This is v2 of the socketpair(2) LSM hook introduction.
Thanks, all applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
--
James Morris
<jmor...@namei.org>
On Fri, 4 May 2018, David Herrmann wrote:
> Hi
>
> This is v2 of the socketpair(2) LSM hook introduction.
Thanks, all applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
--
James Morris
distributed, the insert-sys-cert script can be used to insert the
> certificate for x86.
Can you provide more explanation of how this is useful and who would use
it?
--
James Morris
<jmor...@namei.org>
distributed, the insert-sys-cert script can be used to insert the
> certificate for x86.
Can you provide more explanation of how this is useful and who would use
it?
--
James Morris
actions_logged sysctl.
>
> Suggested-by: Steve Grubb <sgr...@redhat.com>
> Signed-off-by: Tyler Hicks <tyhi...@canonical.com>
Reviewed-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
actions_logged sysctl.
>
> Suggested-by: Steve Grubb
> Signed-off-by: Tyler Hicks
Reviewed-by: James Morris
--
James Morris
eparator. This patch allows the separator character to be
> configurable to meet both needs.
>
> Signed-off-by: Tyler Hicks <tyhi...@canonical.com>
Reviewed-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
eparator. This patch allows the separator character to be
> configurable to meet both needs.
>
> Signed-off-by: Tyler Hicks
Reviewed-by: James Morris
--
James Morris
itional code paths on whether or not the
> 'write' parameter evaluates to true.
>
> Signed-off-by: Tyler Hicks <tyhi...@canonical.com>
Reviewed-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
itional code paths on whether or not the
> 'write' parameter evaluates to true.
>
> Signed-off-by: Tyler Hicks
Reviewed-by: James Morris
--
James Morris
On Wed, 25 Apr 2018, Paul Moore wrote:
> On Wed, Apr 25, 2018 at 2:44 PM, James Morris <jmor...@namei.org> wrote:
> > On Mon, 23 Apr 2018, David Herrmann wrote:
> >> This patch series tries to close this gap and makes both behave the
> >> same. A new LSM-hook is
On Wed, 25 Apr 2018, Paul Moore wrote:
> On Wed, Apr 25, 2018 at 2:44 PM, James Morris wrote:
> > On Mon, 23 Apr 2018, David Herrmann wrote:
> >> This patch series tries to close this gap and makes both behave the
> >> same. A new LSM-hook is added which allow
k backend and maybe the hook name change,
I'll merge this unless DaveM wants it to go in via his networking tree.
--
James Morris
<jmor...@namei.org>
k backend and maybe the hook name change,
I'll merge this unless DaveM wants it to go in via his networking tree.
--
James Morris
f-by: Sargun Dhillon <sar...@sargun.me>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing
--
James Morris
<jmor...@namei.org>
Sargun Dhillon
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
and next-testing
--
James Morris
ave preferred path for getting
> this change merged?
>
It can go via my tree if needed, but otherwise:
Acked-by: James Morris <james.mor...@microsoft.com>
--
James Morris
<jmor...@namei.org>
301 - 400 of 2193 matches
Mail list logo
