Re: [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions

2017-11-13 Thread James Morris
kref_put(>refcount, sgx_encl_release); > + return ret; > +} Don't you need an sgx_free_page() somewhere here? -- James Morris

Re: [RFC PATCH v2] fw_lockdown: new micro LSM module to prevent loading unsigned firmware

2017-11-13 Thread James Morris
first and only LSM with a larger > > name. > > Maybe the commit log should mention that then. Actually, make it a separate patch, so we can easily pinpoint the commit. -- James Morris <james.l.mor...@oracle.com>

Re: [RFC PATCH v2] fw_lockdown: new micro LSM module to prevent loading unsigned firmware

2017-11-13 Thread James Morris
first and only LSM with a larger > > name. > > Maybe the commit log should mention that then. Actually, make it a separate patch, so we can easily pinpoint the commit. -- James Morris

[GIT PULL] Security subsystem: integrity updates for v4.15

2017-11-12 Thread James Morris
Hi Linus, Please pull these fixes for the Integrity subsystem. (From Mimi) "There is a mixture of bug fixes, code cleanup, preparatory code for new functionality and new functionality. Commit 26ddabfe96bb "evm: enable EVM when X509 certificate is loaded" enabled EVM without loading a

[GIT PULL] Security subsystem: integrity updates for v4.15

2017-11-12 Thread James Morris
Hi Linus, Please pull these fixes for the Integrity subsystem. (From Mimi) "There is a mixture of bug fixes, code cleanup, preparatory code for new functionality and new functionality. Commit 26ddabfe96bb "evm: enable EVM when X509 certificate is loaded" enabled EVM without loading a

[GIT PULL] Security subsystem general updates for 4.15

2017-11-12 Thread James Morris
etticks static const to shrink object code size Eric Biggers (1): MAINTAINERS: remove David Safford as maintainer for encrypted+trusted keys James Morris (1): Merge tag 'v4.14-rc2' into next-general Jarkko Sakkinen (4): tpm: migrate pubek_show to struct tpm_buf tpm:

[GIT PULL] Security subsystem general updates for 4.15

2017-11-12 Thread James Morris
etticks static const to shrink object code size Eric Biggers (1): MAINTAINERS: remove David Safford as maintainer for encrypted+trusted keys James Morris (1): Merge tag 'v4.14-rc2' into next-general Jarkko Sakkinen (4): tpm: migrate pubek_show to struct tpm_buf tpm:

Re: [PATCH RFC v3 6/7] proc: support new 'pids=all|ptraceable' mount option

2017-11-09 Thread James Morris
ildren inside /proc/, allowing to support more tight > cases. > > [1] https://lkml.org/lkml/2017/4/26/646 > > Cc: Kees Cook <keesc...@chromium.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Suggested-by: Andy Lutomirski <l...@kernel.org> > Signed

Re: [PATCH RFC v3 6/7] proc: support new 'pids=all|ptraceable' mount option

2017-11-09 Thread James Morris
ildren inside /proc/, allowing to support more tight > cases. > > [1] https://lkml.org/lkml/2017/4/26/646 > > Cc: Kees Cook > Cc: Greg Kroah-Hartman > Suggested-by: Andy Lutomirski > Signed-off-by: Alexey Gladkov > Signed-off-by: Djalal Harouni Reviewed-by: James Morris -- James Morris

Re: [PATCH RFC v3 4/7] proc: support mounting private procfs instances inside same pid namespace

2017-11-09 Thread James Morris
lt;keesc...@chromium.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Suggested-by: Andy Lutomirski <l...@kernel.org> > Signed-off-by: Alexey Gladkov <gladkov.ale...@gmail.com> > Signed-off-by: Djalal Harouni <tix...@gmail.com> Reviewed-by: James Morris <james.l.mor...@oracle.com> -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH RFC v3 4/7] proc: support mounting private procfs instances inside same pid namespace

2017-11-09 Thread James Morris
> Cc: Greg Kroah-Hartman > Suggested-by: Andy Lutomirski > Signed-off-by: Alexey Gladkov > Signed-off-by: Djalal Harouni Reviewed-by: James Morris -- James Morris

[GIT PULL] keys: fix NULL pointer dereference during ASN.1 parsing

2017-11-08 Thread James Morris
er.c:233 RSP: 9b6b37973c78 CR2: Fixes: 42d5ec27f873 ("X.509: Add an ASN.1 decoder") Reported-by: syzbot <syzkal...@googlegroups.com> Cc: <sta...@vger.kernel.org> # v3.7+ Signed-off-by: Eric Biggers <ebigg...@google.com&g

[GIT PULL] keys: fix NULL pointer dereference during ASN.1 parsing

2017-11-08 Thread James Morris
6b37973c78 CR2: Fixes: 42d5ec27f873 ("X.509: Add an ASN.1 decoder") Reported-by: syzbot Cc: # v3.7+ Signed-off-by: Eric Biggers Signed-off-by: David Howells Signed-off-by: James Morris diff --git a/lib/asn1_decoder.c b/lib/asn1_decoder.c

[GIT PULL] Keys fixes for v4.15

2017-11-02 Thread James Morris
Hi Linus, Please pull these fixes for the Keys subsystem by Eric Biggers. The following changes since commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace (2017-11-01 16:04:27 -0700) are available

[GIT PULL] Keys fixes for v4.15

2017-11-02 Thread James Morris
Hi Linus, Please pull these fixes for the Keys subsystem by Eric Biggers. The following changes since commit 3a99df9a3d14cd866b5516f8cba515a3bfd554ab: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace (2017-11-01 16:04:27 -0700) are available

Re: [GIT PULL] Kernel lockdown for secure boot

2017-10-26 Thread James Morris
- Recently suggested, query sent to maintainer > perf- Not looked at yet. How useful is this really if it's incomplete? And I think it really needs more testing in -next. -- James Morris <james.l.mor...@oracle.com>

Re: [GIT PULL] Kernel lockdown for secure boot

2017-10-26 Thread James Morris
- Recently suggested, query sent to maintainer > perf- Not looked at yet. How useful is this really if it's incomplete? And I think it really needs more testing in -next. -- James Morris

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread James Morris
On Thu, 26 Oct 2017, Linus Torvalds wrote: > On Thu, Oct 26, 2017 at 8:54 PM, James Morris <james.l.mor...@oracle.com> > wrote: > > On Thu, 26 Oct 2017, Linus Torvalds wrote: > > > >> I'm *very* unhappy with the security layer as is > > > > W

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread James Morris
On Thu, 26 Oct 2017, Linus Torvalds wrote: > On Thu, Oct 26, 2017 at 8:54 PM, James Morris > wrote: > > On Thu, 26 Oct 2017, Linus Torvalds wrote: > > > >> I'm *very* unhappy with the security layer as is > > > > What are you unhappy with? > > We

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread James Morris
On Thu, 26 Oct 2017, Linus Torvalds wrote: > I'm *very* unhappy with the security layer as is What are you unhappy with? -- James Morris <james.l.mor...@oracle.com>

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread James Morris
On Thu, 26 Oct 2017, Linus Torvalds wrote: > I'm *very* unhappy with the security layer as is What are you unhappy with? -- James Morris

Re: [PATCH] Audit: remove unused audit_log_secctx function

2017-10-25 Thread James Morris
urity module. > > Signed-off-by: Casey Schaufler <ca...@schaufler-ca.com> Reviewed-by: James Morris <james.l.mor...@oracle.com> -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH] Audit: remove unused audit_log_secctx function

2017-10-25 Thread James Morris
urity module. > > Signed-off-by: Casey Schaufler Reviewed-by: James Morris -- James Morris

Re: [PATCH] [v2] tomoyo: fix timestamping for y2038

2017-10-20 Thread James Morris
t;penguin-ker...@i-love.sakura.ne.jp> > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > v2: fix year calculation Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH] [v2] tomoyo: fix timestamping for y2038

2017-10-20 Thread James Morris
a > Signed-off-by: Arnd Bergmann > --- > v2: fix year calculation Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris

Re: [PATCH 26/27] efi: Add an EFI_SECURE_BOOT flag to indicate secure boot mode

2017-10-20 Thread James Morris
n"); Perhaps make this pr_warning and include the unknown mode value? -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH 26/27] efi: Add an EFI_SECURE_BOOT flag to indicate secure boot mode

2017-10-20 Thread James Morris
n"); Perhaps make this pr_warning and include the unknown mode value? -- James Morris

Re: [PATCH 25/27] Lock down /proc/kcore

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > Disallow access to /proc/kcore when the kernel is locked down to prevent > access to cryptographic data. > > Signed-off-by: David Howells <dhowe...@redhat.com> Reviewed-by: James Morris <james.l.mor...@oracle.com> I have

Re: [PATCH 25/27] Lock down /proc/kcore

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > Disallow access to /proc/kcore when the kernel is locked down to prevent > access to cryptographic data. > > Signed-off-by: David Howells Reviewed-by: James Morris I have to wonder, though, after everything is locked do

Re: [PATCH 09/27] uswsusp: Disable when the kernel is locked down

2017-10-20 Thread James Morris
> Signed-off-by: Matthew Garrett <mj...@srcf.ucam.org> > Signed-off-by: David Howells <dhowe...@redhat.com> Reviewed-by: James Morris <james.l.mor...@oracle.com> -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH 09/27] uswsusp: Disable when the kernel is locked down

2017-10-20 Thread James Morris
Garrett > Signed-off-by: David Howells Reviewed-by: James Morris -- James Morris

Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set

2017-10-20 Thread James Morris
but not in git: > https://lkml.org/lkml/2015/3/13/778 > Reviewed-by: James Morris <james.l.mor...@oracle.com> -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set

2017-10-20 Thread James Morris
rg/lkml/2015/3/13/778 > Reviewed-by: James Morris -- James Morris

Re: [PATCH 05/27] kexec: Disable at runtime if the kernel is locked down

2017-10-20 Thread James Morris
com> > cc: ke...@lists.infradead.org Reviewed-by: James Morris <james.l.mor...@oracle.com> -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH 05/27] kexec: Disable at runtime if the kernel is locked down

2017-10-20 Thread James Morris
ffect kexec_file_load() which can check for a signature on the > image to be booted. > > Signed-off-by: Matthew Garrett > Signed-off-by: David Howells > Acked-by: Dave Young > cc: ke...@lists.infradead.org Reviewed-by: James Morris -- James Morris

Re: [PATCH 04/27] Restrict /dev/mem and /dev/kmem when the kernel is locked down

2017-10-20 Thread James Morris
ked down. > > Signed-off-by: Matthew Garrett <matthew.garr...@nebula.com> > Signed-off-by: David Howells <dhowe...@redhat.com> Reviewed-by: James Morris <james.l.mor...@oracle.com> -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH 04/27] Restrict /dev/mem and /dev/kmem when the kernel is locked down

2017-10-20 Thread James Morris
f-by: Matthew Garrett > Signed-off-by: David Howells Reviewed-by: James Morris -- James Morris

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > If the kernel is locked down, require that all modules have valid > signatures that we can verify. > > Signed-off-by: David Howells <dhowe...@redhat.com> Reviewed-by: James Morris <james.l.mor...@oracle.com> -- J

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > If the kernel is locked down, require that all modules have valid > signatures that we can verify. > > Signed-off-by: David Howells Reviewed-by: James Morris -- James Morris

Re: [PATCH 01/27] Add the ability to lock down access to the running kernel image

2017-10-20 Thread James Morris
en't validly signed with a key we recognise, fiddling with > MSR registers and disallowing hibernation, > > Signed-off-by: David Howells <dhowe...@redhat.com> Acked-by: James Morris <james.l.mor...@oracle.com> -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH 01/27] Add the ability to lock down access to the running kernel image

2017-10-20 Thread James Morris
en't validly signed with a key we recognise, fiddling with > MSR registers and disallowing hibernation, > > Signed-off-by: David Howells Acked-by: James Morris -- James Morris

Re: [PATCH GHAK16 V5 00/10] capabilities: do not audit log BPRM_FCAPS on set*id

2017-10-19 Thread James Morris
id. > > > > Serge? James? Can one of you two take this via your trees since Paul > has backed down citing (reasonably) that it is mostly capabilities > patches rather than audit? Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH GHAK16 V5 00/10] capabilities: do not audit log BPRM_FCAPS on set*id

2017-10-19 Thread James Morris
id. > > > > Serge? James? Can one of you two take this via your trees since Paul > has backed down citing (reasonably) that it is mostly capabilities > patches rather than audit? Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris

Re: [PATCH GHAK16 V5 00/10] capabilities: do not audit log BPRM_FCAPS on set*id

2017-10-19 Thread James Morris
> > > > security/commoncap.c | 193 > > ++- > > 1 file changed, 128 insertions(+), 65 deletions(-) > > > > -- > > 1.8.3.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-security-module" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > - RGB > > -- > Richard Guy Briggs <r...@redhat.com> > Sr. S/W Engineer, Kernel Security, Base Operating Systems > Remote, Ottawa, Red Hat Canada > IRC: rgb, SunRaycer > Voice: +1.647.777.2635, Internal: (81) 32635 > -- James Morris <james.l.mor...@oracle.com>

Re: [PATCH GHAK16 V5 00/10] capabilities: do not audit log BPRM_FCAPS on set*id

2017-10-19 Thread James Morris
> > > > security/commoncap.c | 193 > > ++- > > 1 file changed, 128 insertions(+), 65 deletions(-) > > > > -- > > 1.8.3.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-security-module" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > - RGB > > -- > Richard Guy Briggs > Sr. S/W Engineer, Kernel Security, Base Operating Systems > Remote, Ottawa, Red Hat Canada > IRC: rgb, SunRaycer > Voice: +1.647.777.2635, Internal: (81) 32635 > -- James Morris

[GIT PULL] Security subystem fixes for v4.14-rc5

2017-10-18 Thread James Morris
KEYS: Load key expiry time atomically in keyring_search_iterator() KEYS: load key flags and expiry time atomically in proc_keys_show() Eric Sesterhenn (1): pkcs7: Prevent NULL pointer dereference, since sinfo is not always set. James Morris (1): Merge commit 'tags/keys-fixe

[GIT PULL] Security subystem fixes for v4.14-rc5

2017-10-18 Thread James Morris
KEYS: Load key expiry time atomically in keyring_search_iterator() KEYS: load key flags and expiry time atomically in proc_keys_show() Eric Sesterhenn (1): pkcs7: Prevent NULL pointer dereference, since sinfo is not always set. James Morris (1): Merge commit 'tags/keys-fixe

Re: [GIT PULL] tpmdd updates for Linux 4.15

2017-10-18 Thread James Morris
:55 -0700) > > are available in the git repository at: > > git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-20171018 Thanks, merged to next-tpm and next-general in: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git - James -- James Morris <james.l.mor...@oracle.com>

Re: [GIT PULL] tpmdd updates for Linux 4.15

2017-10-18 Thread James Morris
:55 -0700) > > are available in the git repository at: > > git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-20171018 Thanks, merged to next-tpm and next-general in: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git - James -- James Morris

Re: [PATCH][capabilities-next] commoncap: move assignment of fs_ns to avoid null pointer dereference

2017-10-11 Thread James Morris
On Wed, 11 Oct 2017, Serge E. Hallyn wrote: > Hi James, > > it doesn't look like this has been picked up yet. Assuming I'm not looking > in the wrong place, can you pull it into the security tree? Sure, Colin, can you please resend this? > > Quoting Serge E. Hallyn (se...@hallyn.com): > >

Re: [PATCH][capabilities-next] commoncap: move assignment of fs_ns to avoid null pointer dereference

2017-10-11 Thread James Morris
On Wed, 11 Oct 2017, Serge E. Hallyn wrote: > Hi James, > > it doesn't look like this has been picked up yet. Assuming I'm not looking > in the wrong place, can you pull it into the security tree? Sure, Colin, can you please resend this? > > Quoting Serge E. Hallyn (se...@hallyn.com): > >

Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

2017-10-10 Thread James Morris
On Tue, 10 Oct 2017, Jarkko Sakkinen wrote: > The way I've agreed with James Morris to have my tree is to be rooted to > security trees next branch. > > James, what actions should we take? This process has changed recently -- I posted to lsm but forgot to post to linux-inte

Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

2017-10-10 Thread James Morris
On Tue, 10 Oct 2017, Jarkko Sakkinen wrote: > The way I've agreed with James Morris to have my tree is to be rooted to > security trees next branch. > > James, what actions should we take? This process has changed recently -- I posted to lsm but forgot to post to linux-inte

Re: [PATCH] fix security_release_secctx seems broken

2017-10-04 Thread James Morris
find leak. Presumably > because stale poiner stays on stack which could be reused nowdays. Thanks for finding this! -- James Morris <jmor...@namei.org>

Re: [PATCH] fix security_release_secctx seems broken

2017-10-04 Thread James Morris
find leak. Presumably > because stale poiner stays on stack which could be reused nowdays. Thanks for finding this! -- James Morris

[GIT PULL] lsm: fix smack_inode_removexattr and xattr_getsecurity memleak

2017-10-04 Thread James Morris
ff-by: Casey Schaufler <ca...@schaufler-ca.com> Reported-by: Konstantin Khlebnikov <khlebni...@yandex-team.ru> Cc: sta...@vger.kernel.org Signed-off-by: James Morris <james.l.mor...@oracle.com> diff --git a/fs/xattr.c b/fs/xattr.c index 4424f7f..61cd28b 100644 --- a/fs/xatt

[GIT PULL] lsm: fix smack_inode_removexattr and xattr_getsecurity memleak

2017-10-04 Thread James Morris
orted-by: Konstantin Khlebnikov Cc: sta...@vger.kernel.org Signed-off-by: James Morris diff --git a/fs/xattr.c b/fs/xattr.c index 4424f7f..61cd28b 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -250,7 +250,7 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name, }

Re: [PATCH] fix security_release_secctx seems broken

2017-10-04 Thread James Morris
rigger this? I plan to send this to Linus for -rc4 unless anyone has objections. -- James Morris <jmor...@namei.org>

Re: [PATCH] fix security_release_secctx seems broken

2017-10-04 Thread James Morris
urity(). Change Smack to allocate the string when > told to do so. > > Signed-off-by: Casey Schaufler Looks good to me. I wonder why security_release_secctx was used in the first place? (it arrived via commit 42492594) Konstantin: how did you trigger this? I plan to send this to Linus for -rc4 unless anyone has objections. -- James Morris

Re: [GIT PULL] security: keys fixes for v4.14-rc3

2017-09-28 Thread James Morris
On Fri, 29 Sep 2017, Jason A. Donenfeld wrote: > On Fri, Sep 29, 2017 at 12:33 AM, James Morris <jmor...@namei.org> wrote: > > Generally speaking, we likely need to improve the amount of crypto review > > for kernel crypto users including keys (I'll post a note separately t

Re: [GIT PULL] security: keys fixes for v4.14-rc3

2017-09-28 Thread James Morris
On Fri, 29 Sep 2017, Jason A. Donenfeld wrote: > On Fri, Sep 29, 2017 at 12:33 AM, James Morris wrote: > > Generally speaking, we likely need to improve the amount of crypto review > > for kernel crypto users including keys (I'll post a note separately to > > ksummit-

[GIT PULL] security: keys fixes for v4.14-rc3

2017-09-28 Thread James Morris
KEYS: reset parent each time before searching key_user_tree KEYS: restrict /proc/keys by credentials at open time KEYS: use kmemdup() in request_key_auth_new() James Morris (1): Merge commit 'keys-fixes-20170927' into fixes-v4.14-rc3 Jason A. Donenfeld (2): security/keys: prop

[GIT PULL] security: keys fixes for v4.14-rc3

2017-09-28 Thread James Morris
KEYS: reset parent each time before searching key_user_tree KEYS: restrict /proc/keys by credentials at open time KEYS: use kmemdup() in request_key_auth_new() James Morris (1): Merge commit 'keys-fixes-20170927' into fixes-v4.14-rc3 Jason A. Donenfeld (2): security/keys: prop

Re: [PATCH v2 0/2] Fix y2038 issues for security/keys subsystem

2017-09-28 Thread James Morris
On Thu, 28 Sep 2017, David Howells wrote: > James Morris <jmor...@namei.org> wrote: > > > David, have you taken these into your tree? I can apply them to mine if > > needed. > > I was intending to add them to my next tree for security/next. Ok, please

Re: [PATCH v2 0/2] Fix y2038 issues for security/keys subsystem

2017-09-28 Thread James Morris
On Thu, 28 Sep 2017, David Howells wrote: > James Morris wrote: > > > David, have you taken these into your tree? I can apply them to mine if > > needed. > > I was intending to add them to my next tree for security/next. Ok, please add Reviewed-by: James Morris to

Re: [PATCH v2 0/2] Fix y2038 issues for security/keys subsystem

2017-09-28 Thread James Morris
urity/keys/permission.c |3 +-- > security/keys/proc.c | 20 ++-- > security/keys/process_keys.c |2 +- > 9 files changed, 50 insertions(+), 57 deletions(-) David, have you taken these into your tree? I can apply them to mine if needed. -- James Morris <jmor...@namei.org>

Re: [PATCH v2 0/2] Fix y2038 issues for security/keys subsystem

2017-09-28 Thread James Morris
urity/keys/permission.c |3 +-- > security/keys/proc.c | 20 ++-- > security/keys/process_keys.c |2 +- > 9 files changed, 50 insertions(+), 57 deletions(-) David, have you taken these into your tree? I can apply them to mine if needed. -- James Morris

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
On Wed, 27 Sep 2017, Eric Biggers wrote: > On Thu, Sep 28, 2017 at 09:14:58AM +1000, James Morris wrote: > > On Wed, 27 Sep 2017, David Howells wrote: > > > > > (2) Fixing big_key to use safe crypto from Jason A. Donenfeld. > > > > > > > I'm concer

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
On Wed, 27 Sep 2017, Eric Biggers wrote: > On Thu, Sep 28, 2017 at 09:14:58AM +1000, James Morris wrote: > > On Wed, 27 Sep 2017, David Howells wrote: > > > > > (2) Fixing big_key to use safe crypto from Jason A. Donenfeld. > > > > > > > I'm concer

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
s code? If not, it would be good to make some. -- James Morris <jmor...@namei.org>

Re: [GIT PULL] KEYS: Fixes and crypto fixes

2017-09-27 Thread James Morris
s code? If not, it would be good to make some. -- James Morris

[GIT PULL] security: general update for v4.14

2017-09-23 Thread James Morris
This is the remaining "general" change in the security tree for v4.14, following the direct merging of SELinux (+ TOMOYO), AppArmor, and seccomp. That's everything now for the security tree except IMA, which will follow shortly (I've been traveling for the past week with patchy internet).

[GIT PULL] security: general update for v4.14

2017-09-23 Thread James Morris
This is the remaining "general" change in the security tree for v4.14, following the direct merging of SELinux (+ TOMOYO), AppArmor, and seccomp. That's everything now for the security tree except IMA, which will follow shortly (I've been traveling for the past week with patchy internet).

Re: [GIT PULL] Security susbsystem updates for v4.14 (v2)

2017-09-19 Thread James Morris
On Sun, 10 Sep 2017, James Morris wrote: > Here's an updated pull request with the IMA integrity_read() patch > reverted. Note that this restores the orginal buggy behavior with XFS/IMA > deadlock the builtin ima_tcb policy wand XFS rootfs. Linus, can you pull this v2 version? The

Re: [GIT PULL] Security susbsystem updates for v4.14 (v2)

2017-09-19 Thread James Morris
On Sun, 10 Sep 2017, James Morris wrote: > Here's an updated pull request with the IMA integrity_read() patch > reverted. Note that this restores the orginal buggy behavior with XFS/IMA > deadlock the builtin ima_tcb policy wand XFS rootfs. Linus, can you pull this v2 version? The

Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version

2017-09-14 Thread James Morris
On Thu, 14 Sep 2017, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 06:21:28AM +1000, James Morris wrote: > > So, to be clear, this patch solves the XFS deadlock using a different > > approach (to the now reverted integrity_read approach), which Christoph > > also

Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version

2017-09-14 Thread James Morris
On Thu, 14 Sep 2017, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 06:21:28AM +1000, James Morris wrote: > > So, to be clear, this patch solves the XFS deadlock using a different > > approach (to the now reverted integrity_read approach), which Christoph > > also

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-14 Thread James Morris
ore LSM changes. -- James Morris <jmor...@namei.org>

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-14 Thread James Morris
ore LSM changes. -- James Morris

Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version

2017-09-14 Thread James Morris
On Thu, 14 Sep 2017, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 06:21:28AM +1000, James Morris wrote: > > So, to be clear, this patch solves the XFS deadlock using a different > > approach (to the now reverted integrity_read approach), which Christoph > > also

Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version

2017-09-14 Thread James Morris
On Thu, 14 Sep 2017, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 06:21:28AM +1000, James Morris wrote: > > So, to be clear, this patch solves the XFS deadlock using a different > > approach (to the now reverted integrity_read approach), which Christoph > > also

Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version

2017-09-14 Thread James Morris
erent approach (to the now reverted integrity_read approach), which Christoph also says is more correct generally. Correct? What testing has this had? Should this go in with the rest of the security changes now or wait until either -rc or the next merge window? -- James Morris <jmor...@namei.org>

Re: [PATCH 2/2] integrity: replace call to integrity_read_file with kernel version

2017-09-14 Thread James Morris
he now reverted integrity_read approach), which Christoph also says is more correct generally. Correct? What testing has this had? Should this go in with the rest of the security changes now or wait until either -rc or the next merge window? -- James Morris

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-09 Thread James Morris
On Sun, 10 Sep 2017, James Morris wrote: > next-apparmor-next (JJ's next branch) > next-integrity-next (Mimi's) > next-tpm-next(Jarkko's) without '-next' on the end... (editing while jetlagged). -- James Morris <jmor...@namei.org>

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-09 Thread James Morris
On Sun, 10 Sep 2017, James Morris wrote: > next-apparmor-next (JJ's next branch) > next-integrity-next (Mimi's) > next-tpm-next(Jarkko's) without '-next' on the end... (editing while jetlagged). -- James Morris

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-09 Thread James Morris
nd to push to Linus, but he can pull individual branches feeding into it if something is broken in one of them. Does that sound useful? -- James Morris <jmor...@namei.org>

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-09 Thread James Morris
nd to push to Linus, but he can pull individual branches feeding into it if something is broken in one of them. Does that sound useful? -- James Morris

[GIT PULL] Security susbsystem updates for v4.14 (v2)

2017-09-09 Thread James Morris
owered-while-suspended binding documentation Geert Uytterhoeven (1): apparmor: Fix shadowed local variable in unpack_trans_table() Hamza Attak (1): tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers James Morris (4): sync to Linus v4.13-rc2 for subsystem develope

[GIT PULL] Security susbsystem updates for v4.14 (v2)

2017-09-09 Thread James Morris
owered-while-suspended binding documentation Geert Uytterhoeven (1): apparmor: Fix shadowed local variable in unpack_trans_table() Hamza Attak (1): tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers James Morris (4): sync to Linus v4.13-rc2 for subsystem develope

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-09 Thread James Morris
On Fri, 8 Sep 2017, Theodore Ts'o wrote: > On Fri, Sep 08, 2017 at 02:48:51PM +1000, James Morris wrote: > > > > Mimi and Christoph worked together on this over several iterations -- I'll > > let them respond. > > Mimi --- we should chat next week in LA. I've

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-09 Thread James Morris
On Fri, 8 Sep 2017, Theodore Ts'o wrote: > On Fri, Sep 08, 2017 at 02:48:51PM +1000, James Morris wrote: > > > > Mimi and Christoph worked together on this over several iterations -- I'll > > let them respond. > > Mimi --- we should chat next week in LA. I've

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread James Morris
ack is below. > As this impacts multiple LSMs, I'd prefer to take it via my tree. -- James Morris <jmor...@namei.org>

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2017-09-08 Thread James Morris
ack is below. > As this impacts multiple LSMs, I'd prefer to take it via my tree. -- James Morris

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-08 Thread James Morris
you pull it then? -- James Morris <jmor...@namei.org>

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-08 Thread James Morris
you pull it then? -- James Morris

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-07 Thread James Morris
On Thu, 7 Sep 2017, Linus Torvalds wrote: > On Mon, Sep 4, 2017 at 3:29 AM, James Morris <jmor...@namei.org> wrote: > > > > IMA: > > - A new integrity_read file operation method, avoids races when > > calculating file hashes > > Honestly, t

Re: [GIT PULL] Security subsystem updates for 4.14

2017-09-07 Thread James Morris
On Thu, 7 Sep 2017, Linus Torvalds wrote: > On Mon, Sep 4, 2017 at 3:29 AM, James Morris wrote: > > > > IMA: > > - A new integrity_read file operation method, avoids races when > > calculating file hashes > > Honestly, this seems really odd. > >

[GIT PULL] Security subsystem updates for 4.14

2017-09-04 Thread James Morris
Documentation: tpm: add powered-while-suspended binding documentation Geert Uytterhoeven (1): apparmor: Fix shadowed local variable in unpack_trans_table() Hamza Attak (1): tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers James Morris (3): syn

[GIT PULL] Security subsystem updates for 4.14

2017-09-04 Thread James Morris
Documentation: tpm: add powered-while-suspended binding documentation Geert Uytterhoeven (1): apparmor: Fix shadowed local variable in unpack_trans_table() Hamza Attak (1): tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers James Morris (3): syn

Re: [PATCH net-next v7 04/10] bpf: Define handle_fs and add a new helper bpf_handle_fs_get_mode()

2017-08-27 Thread James Morris
abstract FS struct */ > }; Looks like a spurious empty line. -- James Morris <jmor...@namei.org>

<    1   2   3   4   5   6   7   8   9   10   >