Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:34:04PM +0200, Jan Moskyto Matejka wrote: > On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > > From: Jan Moskyto Matejka <m...@ucw.cz> > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > > > -int rt6_dump_route(struct rt

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:34:04PM +0200, Jan Moskyto Matejka wrote: > On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > > > -int rt6_dump_route(struct rt6_info *rt, void *p_a

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > On 5/12/17 8:24 AM, David Miller wrote: > > From: Jan Moskyto Matejka <m...@ucw.cz> > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > >

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > On 5/12/17 8:24 AM, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > >> +int rt6_dump

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > From: Jan Moskyto Matejka <m...@ucw.cz> > Date: Fri, 12 May 2017 13:15:10 +0200 > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > From: Jan Moskyto Matejka > Date: Fri, 12 May 2017 13:15:10 +0200 > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); > >

[PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
is truncated This came to light by David Ahern's commit beb1afac518dec5a15dc ("net: ipv6: Add support to dump multipath routes via RTA_MULTIPATH attribute") but obviously existed before, just hidden. Signed-off-by: Jan Moskyto Matejka <m...@ucw.cz> --- include/net/ip6_route.h

[PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
is truncated This came to light by David Ahern's commit beb1afac518dec5a15dc ("net: ipv6: Add support to dump multipath routes via RTA_MULTIPATH attribute") but obviously existed before, just hidden. Signed-off-by: Jan Moskyto Matejka --- include/net/ip6_route.h | 2 +- include/

[PATCH] [linux-next] pwm: lpss: fix const qualifier discard warning

2014-05-02 Thread Jan Moskyto Matejka
Add support for PCI devices"). Signed-off-by: Jan Moskyto Matejka --- drivers/pwm/pwm-lpss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c index c718ad1..c4620c1 100644 --- a/drivers/pwm/pwm-lpss.c +++ b/drivers/pwm/pwm-lpss.c @@ -129,6 +129,7

[PATCH] [linux-next] watchdog: convert deprecated call to current interface

2014-05-02 Thread Jan Moskyto Matejka
_mb__after_clear_bit() call in favour of smp_mb__after_atomic(). Signed-off-by: Jan Moskyto Matejka --- kernel/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 4dbc7f8..d977f51 100644 --- a/kernel/watchdog.c +++ b/kernel/

[PATCH] [linux-next] serial: sc16is7xx: compile I2C when REGMAP_I2C is module

2014-05-02 Thread Jan Moskyto Matejka
as this driver selects REGMAP_I2C in Kconfig. This part of driver just didn't compile at all when REGMAP_I2C configured as module (CONFIG_REGMAP_I2C is not defined, just CONFIG_REGMAP_I2C_MODULE). Signed-off-by: Jan Moskyto Matejka --- drivers/tty/serial/sc16is7xx.c | 2 -- 1 file changed, 2

[PATCH] [linux-next] serial: sc16is7xx: compile I2C when REGMAP_I2C is module

2014-05-02 Thread Jan Moskyto Matejka
as this driver selects REGMAP_I2C in Kconfig. This part of driver just didn't compile at all when REGMAP_I2C configured as module (CONFIG_REGMAP_I2C is not defined, just CONFIG_REGMAP_I2C_MODULE). Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/tty/serial/sc16is7xx.c | 2 -- 1 file

[PATCH] [linux-next] watchdog: convert deprecated call to current interface

2014-05-02 Thread Jan Moskyto Matejka
() call in favour of smp_mb__after_atomic(). Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- kernel/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 4dbc7f8..d977f51 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c

[PATCH] [linux-next] pwm: lpss: fix const qualifier discard warning

2014-05-02 Thread Jan Moskyto Matejka
support for PCI devices). Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/pwm/pwm-lpss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c index c718ad1..c4620c1 100644 --- a/drivers/pwm/pwm-lpss.c +++ b/drivers/pwm/pwm-lpss.c @@ -129,6

[PATCH v2] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
by cleaning up BT_AUTO_REPORT_ONLY_8192E_2ANT (always set to 0, never used as constant) halbtc8192e2ant_iswifi_status_changed was called only from the unused code Signed-off-by: Jan Moskyto Matejka --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 43 -- .../staging

[PATCH] [linux-next] serial: sc16is7xx: fix defined-but-not-used warnings

2014-04-30 Thread Jan Moskyto Matejka
#ifdef-ing also some other functions that got defined but not used. Signed-off-by: Jan Moskyto Matejka --- drivers/tty/serial/sc16is7xx.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 7206a64

Re: [PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
On Wed, Apr 30, 2014 at 02:39:50PM +0200, Paul Bolle wrote: > On Wed, 2014-04-30 at 14:15 +0200, Jan Moskyto Matejka wrote: > > --- a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c > > +++ b/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c > > @@ -503,6

[PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
The function halbtc8192e2ant_iswifi_status_changed is called only at line 4158 which is #if'd in the same way as I'm now #if-ing the function. Signed-off-by: Jan Moskyto Matejka --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread Jan Moskyto Matejka
> > Also thanks for suggesting (void*)->(unsigned long), I didn't > > know that these two are defined to have the same size (in kernel code). > > The kernel assumes that throughout - the double cast is common. > The C99 type is uintptr_t - but I don't think that is defined in kernel. > The only

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread Jan Moskyto Matejka
> > So why not just: > > revision = (unsigned long)match->data; > > and add a comment that the 0x84 is the revision - #define ?? > > There is no particular reason why it should be u32 now - this is a > leftover from the previous iteration of code where revision was a > separate property

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread Jan Moskyto Matejka
So why not just: revision = (unsigned long)match-data; and add a comment that the 0x84 is the revision - #define ?? There is no particular reason why it should be u32 now - this is a leftover from the previous iteration of code where revision was a separate property in DT (sized

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread Jan Moskyto Matejka
Also thanks for suggesting (void*)-(unsigned long), I didn't know that these two are defined to have the same size (in kernel code). The kernel assumes that throughout - the double cast is common. The C99 type is uintptr_t - but I don't think that is defined in kernel. The only place I

[PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
The function halbtc8192e2ant_iswifi_status_changed is called only at line 4158 which is #if'd in the same way as I'm now #if-ing the function. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
On Wed, Apr 30, 2014 at 02:39:50PM +0200, Paul Bolle wrote: On Wed, 2014-04-30 at 14:15 +0200, Jan Moskyto Matejka wrote: --- a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c +++ b/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c @@ -503,6 +503,7 @@ static void

[PATCH] [linux-next] serial: sc16is7xx: fix defined-but-not-used warnings

2014-04-30 Thread Jan Moskyto Matejka
#ifdef-ing also some other functions that got defined but not used. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/tty/serial/sc16is7xx.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index

[PATCH v2] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning

2014-04-30 Thread Jan Moskyto Matejka
by cleaning up BT_AUTO_REPORT_ONLY_8192E_2ANT (always set to 0, never used as constant) halbtc8192e2ant_iswifi_status_changed was called only from the unused code Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 43

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-29 Thread Jan Moskyto Matejka
On Tue, Apr 29, 2014 at 10:09:01PM +0400, Alexey Charkov wrote: > 2014-04-29 21:36 GMT+04:00 Jan Moskyto Matejka : > > Fixed different size cast warning: > > > > drivers/net/ethernet/via/via-rhine.c: In function > > ‘rhine_init_one_platform’: > >

[PATCH] net: via-rhine: fix compiler warning

2014-04-29 Thread Jan Moskyto Matejka
ata; ^ That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 ("net: via-rhine: add OF bus binding"). Signed-off-by: Jan Moskyto Matejka --- drivers/net/ethernet/via/via-rhine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[RESEND][PATCH][linux-next] drivers: staging: removing never #def'd BP_PROC_SUPPORT

2014-04-29 Thread Jan Moskyto Matejka
BP_PROC_SUPPORT was never defined so removing all the #ifdef'd code including the bp_proc_create() function. Signed-off-by: Jan Moskyto Matejka --- drivers/staging/silicom/bpctl_mod.c | 39 - 1 file changed, 39 deletions(-) diff --git a/drivers/staging

[RESEND][PATCH][linux-next] drivers: staging: removing never #def'd BP_PROC_SUPPORT

2014-04-29 Thread Jan Moskyto Matejka
BP_PROC_SUPPORT was never defined so removing all the #ifdef'd code including the bp_proc_create() function. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/staging/silicom/bpctl_mod.c | 39 - 1 file changed, 39 deletions(-) diff --git a/drivers

[PATCH] net: via-rhine: fix compiler warning

2014-04-29 Thread Jan Moskyto Matejka
; ^ That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 (net: via-rhine: add OF bus binding). Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/net/ethernet/via/via-rhine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-29 Thread Jan Moskyto Matejka
On Tue, Apr 29, 2014 at 10:09:01PM +0400, Alexey Charkov wrote: 2014-04-29 21:36 GMT+04:00 Jan Moskyto Matejka m...@suse.cz: Fixed different size cast warning: drivers/net/ethernet/via/via-rhine.c: In function ‘rhine_init_one_platform’: drivers/net/ethernet/via/via

Re: Updated asmlinkage patch v2

2014-04-28 Thread Jan Moskyto Matejka
> On Tue, Apr 1, 2014 at 2:40 PM, Andi Kleen wrote: > > > > Did some basic sanity checks with LTO and everything > > works (still need the three other LTO patches to build) > > Ok, this series looks much better. Thanks, It seems this series hasn't made it to the torvalds tree yet so the

[RESEND][PATCH][linux-next] Revert "drm/i915: fix build warning on 32-bit (v2)"

2014-04-28 Thread Jan Moskyto Matejka
difference to unsigned long and the other commit changed the output type from long to ptrdiff_t. The other commit fixes the original warning the better way so I'm reverting this commit now. Signed-off-by: Jan Moskyto Matejka --- drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +- 1 file changed, 1

[RESEND][PATCH][linux-next] Revert drm/i915: fix build warning on 32-bit (v2)

2014-04-28 Thread Jan Moskyto Matejka
difference to unsigned long and the other commit changed the output type from long to ptrdiff_t. The other commit fixes the original warning the better way so I'm reverting this commit now. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +- 1 file

Re: Updated asmlinkage patch v2

2014-04-28 Thread Jan Moskyto Matejka
On Tue, Apr 1, 2014 at 2:40 PM, Andi Kleen a...@firstfloor.org wrote: Did some basic sanity checks with LTO and everything works (still need the three other LTO patches to build) Ok, this series looks much better. Thanks, It seems this series hasn't made it to the torvalds tree yet so

[PATCH][linux-next] wireless: fixed bad dev_info integer type warning

2014-04-23 Thread Jan Moskyto Matejka
The pointer difference (ptrdiff_t) should be formatted by %tx, not %lx. Signed-off-by: Jan Moskyto Matejka --- drivers/net/wireless/mwifiex/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c index

Re: [PATCH] proc: fix documentation for /proc/stat, line "intr"

2014-04-23 Thread Jan Moskyto Matejka
n Tue, Apr 22, 2014 at 03:35:39PM -0700, Randy Dunlap wrote: > On 04/22/14 11:19, Michael Kerrisk (man-pages) wrote: > > On 04/22/2014 05:29 PM, Jan Moskyto Matejka wrote: > >> The sum at the beginning of line "intr" includes also unnumbered > >> int

Re: [PATCH] proc: fix documentation for /proc/stat, line intr

2014-04-23 Thread Jan Moskyto Matejka
n Tue, Apr 22, 2014 at 03:35:39PM -0700, Randy Dunlap wrote: On 04/22/14 11:19, Michael Kerrisk (man-pages) wrote: On 04/22/2014 05:29 PM, Jan Moskyto Matejka wrote: The sum at the beginning of line intr includes also unnumbered interrupts. It implies that the sum at the beginning isn't

[PATCH][linux-next] wireless: fixed bad dev_info integer type warning

2014-04-23 Thread Jan Moskyto Matejka
The pointer difference (ptrdiff_t) should be formatted by %tx, not %lx. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/net/wireless/mwifiex/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex

[PATCH] proc: fix documentation for /proc/stat, line "intr"

2014-04-22 Thread Jan Moskyto Matejka
The sum at the beginning of line "intr" includes also unnumbered interrupts. It implies that the sum at the beginning isn't the sum of the remainder of the line, not even an estimation. Fixed the documentation to mention that. Signed-off-by: Jan Moskyto Matejka --- Documentation/f

[PATCH] proc: fix documentation for /proc/stat, line intr

2014-04-22 Thread Jan Moskyto Matejka
The sum at the beginning of line intr includes also unnumbered interrupts. It implies that the sum at the beginning isn't the sum of the remainder of the line, not even an estimation. Fixed the documentation to mention that. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- Documentation

[PATCH] Revert "drm/i915: fix build warning on 32-bit (v2)"

2014-04-07 Thread Jan Moskyto Matejka
This reverts commit 60f2b4af1258c05e6b037af866be81abc24438f7. The same warning has been fixed in e5081a538a565284fec5f30a937d98e460d5e780 and these two commits got merged in 74e99a84de2d0980320612db8015ba606af42114 which caused another warning. Simply, the reverted commit casted the pointer

[PATCH] Revert "drm/i915: fix build warning on 32-bit (v2)"

2014-04-07 Thread Jan Moskyto Matejka
difference to unsigned long and the other commit changed the output type from long to ptrdiff_t. The other commit fixes the original warning the better way so I'm reverting this commit now. Signed-off-by: Jan Moskyto Matejka --- drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +- 1 file changed, 1

[PATCH] drivers: staging: removing never #def'd BP_PROC_SUPPORT

2014-04-07 Thread Jan Moskyto Matejka
BP_PROC_SUPPORT was never defined so removing all the #ifdef'd code including the bp_proc_create() function. Signed-off-by: Jan Moskyto Matejka --- drivers/staging/silicom/bpctl_mod.c | 39 - 1 file changed, 39 deletions(-) diff --git a/drivers/staging

[PATCH] drivers: staging: removing never #def'd BP_PROC_SUPPORT

2014-04-07 Thread Jan Moskyto Matejka
BP_PROC_SUPPORT was never defined so removing all the #ifdef'd code including the bp_proc_create() function. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/staging/silicom/bpctl_mod.c | 39 - 1 file changed, 39 deletions(-) diff --git a/drivers

[PATCH] Revert drm/i915: fix build warning on 32-bit (v2)

2014-04-07 Thread Jan Moskyto Matejka
This reverts commit 60f2b4af1258c05e6b037af866be81abc24438f7. The same warning has been fixed in e5081a538a565284fec5f30a937d98e460d5e780 and these two commits got merged in 74e99a84de2d0980320612db8015ba606af42114 which caused another warning. Simply, the reverted commit casted the pointer

[PATCH] Revert drm/i915: fix build warning on 32-bit (v2)

2014-04-07 Thread Jan Moskyto Matejka
difference to unsigned long and the other commit changed the output type from long to ptrdiff_t. The other commit fixes the original warning the better way so I'm reverting this commit now. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +- 1 file

[PATCH] Modpost: fixed USB alias generation for ranges including 0x9 and 0xA

2014-02-07 Thread Jan Moskyto Matejka
xing this simple bug to fix the aliases. Also changing the hardcoded beginning of the range to uppercase as all the other letters are also uppercase in the device version numbers. Fortunately, this affects only the dvb-usb-dib0700 module, AFAIK. Signed-off-by: Jan Moskyto Matejka --- scripts/

[PATCH] Modpost: fixed USB alias generation for ranges including 0x9 and 0xA

2014-02-07 Thread Jan Moskyto Matejka
to fix the aliases. Also changing the hardcoded beginning of the range to uppercase as all the other letters are also uppercase in the device version numbers. Fortunately, this affects only the dvb-usb-dib0700 module, AFAIK. Signed-off-by: Jan Moskyto Matejka m...@suse.cz --- scripts/mod

[PATCH] inet: defines IPPROTO_* needed for module alias generation

2014-02-06 Thread Jan Moskyto Matejka
Signed-off-by: Jan Moskyto Matejka --- include/uapi/linux/in6.h | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/include/uapi/linux/in6.h b/include/uapi/linux/in6.h index 633b93c..e9a1d2d97 100644 --- a/include/uapi/linux/in6.h +++ b/include/uapi/l

[PATCH] inet: defines IPPROTO_* needed for module alias generation

2014-02-06 Thread Jan Moskyto Matejka
-by: Jan Moskyto Matejka m...@suse.cz --- include/uapi/linux/in6.h | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/include/uapi/linux/in6.h b/include/uapi/linux/in6.h index 633b93c..e9a1d2d97 100644 --- a/include/uapi/linux/in6.h +++ b/include/uapi/linux/in6