e safest parameters)");
>
> i915_param_named_unsafe(force_probe, charp, 0400,
> "Force probe the driver for specified devices. "
--
Jani Nikula, Intel Open Source Graphics Center
ean I get 2x of it next week,
> we'll see how it goes.
Been really quiet here, basically I only got GVT fixes pending.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
On Mon, 08 Jun 2020, David Howells wrote:
> Jani Nikula wrote:
>
>> David, please try [1].
>
> Assuming you mean this:
>
> https://patchwork.freedesktop.org/patch/366958/?series=77635=1
>
> yes, that works.
>
> Tested-by: David Howells
Many thanks,
Jani.
On Mon, 08 Jun 2020, "Saarinen, Jani" wrote:
> HI,
>> -Original Message-
>> From: Intel-gfx On Behalf Of Jani
>> Nikula
>> Sent: maanantai 8. kesäkuuta 2020 10.49
>> To: David Howells ; Joonas Lahtinen
>> ; Vivi, Rodrigo
>
On Sun, 07 Jun 2020, David Howells wrote:
> Hi,
>
> I'm seeing the attached oops and panic from the i915 drm driver. I've tried
> bisecting it, but there's a problem in that one of the merged branches causes
> the machine to hang without output.
Cc: Ville and GG, I thought this was fixed
be using
static tables for this. It's far from obvious.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
st review the changes.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
rop_value);
> @@ -468,7 +470,7 @@ static int set_property_legacy(struct drm_mode_object
> *obj,
> break;
> }
> drm_property_change_valid_put(prop, ref);
> - drm_modeset_unlock_all(dev);
> + DRM_MODESET_LOCK_ALL_END(ctx, ret);
>
> return ret;
> }
--
Jani Nikula, Intel Open Source Graphics Center
hould move the various yesno/onoff/enableddisabled helpers from
> i915_utils.h to drm_utils.h and use them more widely?
I'm trying to take it one step further by adding them to
include/linux/string-choice.h [1]. Maybe, uh, fourth time's the charm?
BR,
Jani.
[1] http://lore.kernel.org/r/20191023131308.9420-1-jani.nik...@intel.com
--
Jani Nikula, Intel Open Source Graphics Center
en
Cc: Rodrigo Vivi
Cc: intel-...@lists.freedesktop.org
Cc: Vishal Kulkarni
Cc: net...@vger.kernel.org
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
Cc: Andrew Morton
Cc: linux-kernel@vger.kernel.org
Cc: Julia Lawall
Cc: Rasmus Villemoes
Reviewed-by: Greg Kroah-Hartman
Signed-off-
On Mon, 07 Oct 2019, Krzysztof Kozlowski wrote:
> On Mon, 7 Oct 2019 at 18:09, Alex Deucher wrote:
>>
>> On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula
>> wrote:
>> >
>> > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote:
>> > > drivers/gpu/drm/i9
matches.
> + X: *Excluded* files and directories that are NOT maintained, same
> +rules as F:. Files exclusions are tested before file matches.
> Can be useful for excluding a specific subdirectory, for instance:
> F: net/
> X: net/ipv6/
> matches all files in and below net excluding net/ipv6/
> - K: Keyword perl extended regex pattern to match content in a
> -patch or file. For instance:
> + K: *Content regex* (perl extended) pattern match in a patch or file.
> +For instance:
> K: of_get_profile
> matches patches or files that contain "of_get_profile"
> K: \b(printk|pr_(info|err))\b
> @@ -128,13 +130,12 @@ Descriptions of section entries:
> printk, pr_info or pr_err
> One regex pattern per line. Multiple K: lines acceptable.
>
> -Note: For the hard of thinking, this list is meant to remain in alphabetical
> -order. If you could add yourselves to it in alphabetical order that would be
> -so much easier [Ed]
> -
> -Maintainers List (try to look for most precise areas first)
> +Maintainers List
> +
>
> - ---
> +.. note:: When reading this list, please look for the most precise areas
> + first. When adding to this list, please keep the entries in
> + alphabetical order.
>
> 3C59X NETWORK DRIVER
> M: Steffen Klassert
> --
> 2.17.1
--
Jani Nikula, Intel Open Source Graphics Center
SMOP. ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
n entries:
> Obsolete:Old code. Something tagged obsolete generally means
> it has been replaced by a better system and you
> should be using that.
> + P: Subsystem Profile document for more details submitting
> +pat
+ in.u.allocate_payload.vcpi = 0x7f;
> + DO_TEST();
> + in.u.allocate_payload.pbn = U16_MAX;
> + DO_TEST();
> +
> + in.req_type = DP_QUERY_PAYLOAD;
> + in.u.query_payload.port_number = 0xf;
> + DO_TEST();
> + in.u.query_payload.vcpi = 0x7f;
> + DO_TEST();
> +
> + in.req_type = DP_REMOTE_DPCD_READ;
> + in.u.dpcd_read.port_number = 0xf;
> + DO_TEST();
> + in.u.dpcd_read.dpcd_address = 0xfedcb;
> + DO_TEST();
> + in.u.dpcd_read.num_bytes = U8_MAX;
> + DO_TEST();
> +
> + in.req_type = DP_REMOTE_DPCD_WRITE;
> + in.u.dpcd_write.port_number = 0xf;
> + DO_TEST();
> + in.u.dpcd_write.dpcd_address = 0xfedcb;
> + DO_TEST();
> + in.u.dpcd_write.num_bytes = ARRAY_SIZE(data);
> + in.u.dpcd_write.bytes = data;
> + DO_TEST();
> +
> + in.req_type = DP_REMOTE_I2C_READ;
> + in.u.i2c_read.port_number = 0xf;
> + DO_TEST();
> + in.u.i2c_read.read_i2c_device_id = 0x7f;
> + DO_TEST();
> + in.u.i2c_read.num_transactions = 3;
> + in.u.i2c_read.num_bytes_read = ARRAY_SIZE(data) * 3;
> + for (i = 0; i < in.u.i2c_read.num_transactions; i++) {
> + in.u.i2c_read.transactions[i].bytes = data;
> + in.u.i2c_read.transactions[i].num_bytes = ARRAY_SIZE(data);
> + in.u.i2c_read.transactions[i].i2c_dev_id = 0x7f & ~i;
> + in.u.i2c_read.transactions[i].i2c_transaction_delay = 0xf & ~i;
> + }
> + DO_TEST();
> +
> + in.req_type = DP_REMOTE_I2C_WRITE;
> + in.u.i2c_write.port_number = 0xf;
> + DO_TEST();
> + in.u.i2c_write.write_i2c_device_id = 0x7f;
> + DO_TEST();
> + in.u.i2c_write.num_bytes = ARRAY_SIZE(data);
> + in.u.i2c_write.bytes = data;
> + DO_TEST();
> +
> +#undef DO_TEST
> + return 0;
> +}
> diff --git a/drivers/gpu/drm/selftests/test-drm_modeset_common.h
> b/drivers/gpu/drm/selftests/test-drm_modeset_common.h
> index 590bda35a683..0fcb8bbc6a1b 100644
> --- a/drivers/gpu/drm/selftests/test-drm_modeset_common.h
> +++ b/drivers/gpu/drm/selftests/test-drm_modeset_common.h
> @@ -40,5 +40,6 @@ int igt_damage_iter_damage_one_outside(void *ignored);
> int igt_damage_iter_damage_src_moved(void *ignored);
> int igt_damage_iter_damage_not_visible(void *ignored);
> int igt_dp_mst_calc_pbn_mode(void *ignored);
> +int igt_dp_mst_sideband_msg_req_decode(void *ignored);
>
> #endif
> diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h
> index 4a4507fe928d..5423a8adda78 100644
> --- a/include/drm/drm_dp_mst_helper.h
> +++ b/include/drm/drm_dp_mst_helper.h
> @@ -293,7 +293,7 @@ struct drm_dp_remote_dpcd_write {
> struct drm_dp_remote_i2c_read {
> u8 num_transactions;
> u8 port_number;
> - struct {
> + struct drm_dp_remote_i2c_read_tx {
> u8 i2c_dev_id;
> u8 num_bytes;
> u8 *bytes;
--
Jani Nikula, Intel Open Source Graphics Center
"on"
+ onoff(A != B)
|
- A != B ? "off" : "on"
+ onoff(A == B)
|
- A ? "off" : "on"
+ onoff(!A)
)
@plural@
expression E;
@@
(
- (E > 1) ? "s" : ""
+ plural(E)
|
- E > 1 ? "s" : ""
+ plural(E)
|
- (E == 1) ? "&
also some space savings to be had via better string constant
pooling.
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: intel-...@lists.freedesktop.org
Cc: Vishal Kulkarni
Cc: net...@vger.kernel.org
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
Cc: Andrew Morton
Cc: linux-kern
# cat /sys/module/foobar/parameters/mode
(unknown)
Signed-off-by: Jani Nikula
---
I've had this lying around in a branch for a long time, but never really
got around to contributing upstream. Don't have a user for it
either. But here goes, might be us
order to pick up changes and fixes done elsewhere
> +in the tree. As always, such a merge should pick a well-known release
> +point rather than some random spot. If your upstream-bound branch has
> +emptied entirely into the mainline during the merge window, you can pull
> it +forward with a command like::
> +
> + git merge v5.2-rc1^0
> +
> +The "^0" will cause Git to do a fast-forward merge (which should be
> +possible in this situation), thus avoiding the addition of a spurious
> merge +commit.
> +
> +The guidelines laid out above are just that: guidelines. There will
> always +be situations that call out for a different solution, and these
> guidelines +should not prevent developers from doing the right thing when
> the need +arises. But one should always think about whether the need has
> truly +arisen and be prepared to explain why something abnormal needs to
> be done. --
> 2.21.0
>
--
Jani Nikula, Intel Open Source Graphics Center
ts and Execlists
>
> -.. kernel-doc:: drivers/gpu/drm/i915/intel_lrc.c
> +.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_lrc.c
> :internal:
>
> Global GTT views
--
Jani Nikula, Intel Open Source Graphics Center
would be nice to be able to limit this implicit rule to
> header-test-y
> -$(obj)/%.header_test.c: $(src)/%.h FORCE
> +$(obj)/%.header_test.c:
> $(call if_changed,header_test)
>
> # Compile assembler sources (.S)
--
Jani Nikula, Intel Open Source Graphics Center
gt; +++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
> @@ -41,7 +41,7 @@ void intel_sseu_copy_subslices(const struct sseu_dev_info
> *sseu, int slice,
> u32 intel_sseu_get_subslices(const struct sseu_dev_info *sseu, u8 slice)
> {
> int i, offset = slice * sseu->ss_stride;
> - u32 mask;
>
https://bugs.freedesktop.org/show_bug.cgi?id=108085
>> > > Signed-off-by: Daniel Drake
>> > > Signed-off-by: Jian-Hong Pan
>> >
>> > Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ?
>> > Cc: Paulo Zanoni
>> > Cc: Dani
gt; I have now. It's simple and easy to understand, and doesn't seem to screw
> up anywhere in the current body of kernel docs as far as I can tell.
Fair enough. It's most important that this doesn't block us from
switching to a different implementation later once someone figures it
out.
BR,
Ja
On Thu, 18 Apr 2019, Mauro Carvalho Chehab wrote:
> Em Thu, 18 Apr 2019 17:42:29 +0300
> Jani Nikula escreveu:
>
>> On Thu, 18 Apr 2019, Mauro Carvalho Chehab
>> wrote:
>> > Those three new drivers were missed on the initial conversion
>> > to ReST form
u/drm/exynos/Kconfig |2 --
> drivers/gpu/drm/i915/Kconfig |3 ---
> drivers/gpu/drm/i915/Kconfig.debug | 13 -
For i915,
Acked-by: Jani Nikula
and can be merged through whichever tree you like.
> drivers/gpu/drm/msm/Kconfig |2 --
>
[0] =~ m/^--?(.*)/) {
> $output_mode = "none";
> } elsif ($cmd eq "module") { # not needed for XML, inherits from calling
> document
> $modulename = shift @ARGV;
> -} elsif ($cmd eq "function") { # to only output specific function
> + } e
On Thu, 07 Mar 2019, Thomas Preston wrote:
> Would you like me to resubmit with the suggested changes?
Nah, we can tweak the commit message while applying.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
On Thu, 07 Mar 2019, Thomas Preston wrote:
> Hi,
> Thanks for looking at this.
>
> On 07/03/2019 08:18, Jani Nikula wrote:
>>
>> The subject should probably have "drm/i915/bios" or "drm/i915/vbt".
>>
>
> Noted
>
>> On Wed, 06
notifiers to achieve the exact same goal.
See drivers/video/fbdev/aty/atyfb_base.c, look for
register_reboot_notifier().
HTH,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
at have a non-eDP output
on port A. I guess it's a risk we have to take, and handle the fallout
later.
Acked-by: Jani Nikula
> Fixes: commit a98d9c1d7e9b ("drm/i915/ddi: Rely on VBT DDI port info for eDP
> detection")
The Fixes: format does *not* include "commi
te to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Jani-Nikula/log2-make-is_power_of_2-integer-constant-expression-when-possible/20190304-153529
> config: microblaze-mmu_defconfig (attached as .config)
> compiler: microblaze-linux-gcc
On Fri, 01 Mar 2019, Andrew Morton wrote:
> On Fri, 1 Mar 2019 14:52:07 +0200 Jani Nikula wrote:
>
>> While is_power_of_2() is an inline function and likely gets optimized
>> for compile time constant arguments, it still doesn't produce an integer
>> constant expre
possible,
otherwise using the inline function to avoid multiple evaluation of the
parameter.
Cc: Chris Wilson
Signed-off-by: Jani Nikula
---
The alternative would be to define both a function and a macro version
of is_power_of_2(), and let the callers decide what to use.
---
include/linux/log2.h
On Mon, 25 Feb 2019, Hans Verkuil wrote:
> Hi Jani,
>
> On 2/25/19 2:40 PM, Jani Nikula wrote:
>> On Fri, 22 Feb 2019, Randy Dunlap wrote:
>>> This is 5.0-rc7 on an old Toshiba Portege laptop.
>>> No hdmi or other external video.
>>>
>>> Linux d
ro.
>
> Full boot log is attached.
On a hunch, caused by 9c229127aee2 ("drm/i915: hdmi: add CEC notifier to
intel_hdmi") referencing the encoder in connector destroy hook. We
should probably move the cec_notifier_put() call in the encoder destroy
hook.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
On Thu, 21 Feb 2019, Gerd Hoffmann wrote:
> On Thu, Feb 21, 2019 at 03:08:39PM +0200, Jani Nikula wrote:
>> On Thu, 21 Feb 2019, Gerd Hoffmann wrote:
>> > It'll be useful for other drivers too, so move it to drm_fb_helper.c
>> > (and rename it of course). Also add
> - ret = 0;
> - }
> - console_unlock();
> -
> - return ret;
> -}
> -#endif
> -
> static void intel_init_dpio(struct drm_i915_private *dev_priv)
> {
> /*
> @@ -1420,7 +1387,7 @@ static int i915_driver_init_hw(struct drm_i915_private
> *dev_priv)
> goto err_ggtt;
> }
>
> - ret = i915_kick_out_vgacon(dev_priv);
> + ret = drm_fb_helper_kick_out_vgacon();
> if (ret) {
> DRM_ERROR("failed to remove conflicting VGA console\n");
> goto err_ggtt;
--
Jani Nikula, Intel Open Source Graphics Center
On Fri, 01 Feb 2019, Andrzej Hajda wrote:
> On 01.02.2019 11:30, Jani Nikula wrote:
>> On Fri, 01 Feb 2019, Sam Ravnborg wrote:
>>> Hi Thierry.
>>>
>>>> I personally like the DRM_DEV_* variants better because of the
>>>> additional inf
truct device)
>
> DRM_DRM*, or DRM_DDEV* or ... But you get the idea.
>
> But this is not where we are today.
>
> Shall I redo the patch-set so we go back to dev_*() in probe() / remove()?
>
> Sam
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Graphics Center
t; drm-intel-fixes. IS_GEN(dev_priv, 6) needs to be converted to
> IS_GEN6(dev_priv).
>
> Lucas De Marchi
>
>>
>> I have reverted that commit for today.
Dropped the commit from drm-intel-fixes.
Somehow I had managed to screw up my kernel config in a way that avoided
the build failure.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
les touched the lists of include files was grouped
> and sorted.
>
> Build tested on x86 and arm allmodconfig / allyesconfig.
>
> Signed-off-by: Sam Ravnborg
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc
ror handling for
> prepare_execlist_workload")
>
> has these problem(s):
>
> - Subject does not match target commit subject
>
> Just some whitespace.
Thanks for the report. The commit being referenced seems to be the right
one, though, so I don't think I'm going to force pu
On Wed, 23 Jan 2019, Edwin Zimmerman wrote:
> On Wed, 23 Jan 2019, Jani Nikula wrote:
>> On Wed, 23 Jan 2019, Greg KH wrote:
>> > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote:
>> >> Variables declared in a switch statement before any case statements
&
On Wed, 23 Jan 2019, Jani Nikula wrote:
> On Wed, 23 Jan 2019, Greg KH wrote:
>> On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote:
>>> Variables declared in a switch statement before any case statements
>>> cannot be initialized, so move all instances out
ase 0:
/* ... */
}
but can have e.g.:
switch (i) {
case 0:
{
int j = 0;
/* ... */
}
}
I think Kees' approach of moving such variable declarations to the
enclosing block scope
@@ -869,7 +869,7 @@ intel_tv_get_config(struct intel_encoder *encoder,
> pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
> }
>
> -static bool
> +static int
> intel_tv_compute_config(struct intel_encoder *encoder,
> struct intel_crtc_state *pipe_config,
> struct drm_connector_state *conn_state)
> @@ -879,10 +879,10 @@ intel_tv_compute_config(struct intel_encoder *encoder,
> _config->base.adjusted_mode;
>
> if (!tv_mode)
> - return false;
> + return -EINVAL;
>
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> - return false;
> + return -EINVAL;
>
> pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> adjusted_mode->crtc_clock = tv_mode->clock;
> @@ -897,7 +897,7 @@ intel_tv_compute_config(struct intel_encoder *encoder,
>* or whether userspace is doing something stupid.
>*/
>
> - return true;
> + return 0;
> }
>
> static void
> diff --git a/drivers/gpu/drm/i915/vlv_dsi.c b/drivers/gpu/drm/i915/vlv_dsi.c
> index d116fead8514..c247ce74b71a 100644
> --- a/drivers/gpu/drm/i915/vlv_dsi.c
> +++ b/drivers/gpu/drm/i915/vlv_dsi.c
> @@ -256,9 +256,9 @@ static void band_gap_reset(struct drm_i915_private
> *dev_priv)
> mutex_unlock(_priv->sb_lock);
> }
>
> -static bool intel_dsi_compute_config(struct intel_encoder *encoder,
> - struct intel_crtc_state *pipe_config,
> - struct drm_connector_state *conn_state)
> +static int intel_dsi_compute_config(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi,
> @@ -284,7 +284,7 @@ static bool intel_dsi_compute_config(struct intel_encoder
> *encoder,
> }
>
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> - return false;
> + return -EINVAL;
>
> /* DSI uses short packets for sync events, so clear mode flags for DSI
> */
> adjusted_mode->flags = 0;
> @@ -302,16 +302,16 @@ static bool intel_dsi_compute_config(struct
> intel_encoder *encoder,
>
> ret = bxt_dsi_pll_compute(encoder, pipe_config);
> if (ret)
> - return false;
> + return -EINVAL;
> } else {
> ret = vlv_dsi_pll_compute(encoder, pipe_config);
> if (ret)
> - return false;
> + return -EINVAL;
> }
>
> pipe_config->clock_set = true;
>
> - return true;
> + return 0;
> }
>
> static bool glk_dsi_enable_io(struct intel_encoder *encoder)
--
Jani Nikula, Intel Open Source Graphics Center
lly would send a patch myself but since I'm not
> familiar with this code, I'd rather not shoot in the dark :) especially
> since it's for a trivial logging statement.
Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning
in debugfs"), thanks for the report &
amespacing it that way for the reason mentioned above - it
> does/will/should apply to more than just the gpu/drm/arm tree.
Fair enough. It's not like the name is part of the ABI, so I guess let's
go with this, and we can rename later if we come up with a better name.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
; > + * - DRM_FORMAT_YUV420_10BIT
>> > + - 10-bit per component YCbCr 420, single plane
>> > + - Plane 0: 3 components
>> > + * Component 0: Y(10)
>> > + * Component 1: Cb(10, 2x2 subsampled)
>> > + * Component 2: Cr(10, 2x2 subsampled)
>> > +
>> > + * - DRM_FORMAT_NV12
>> > + - 8-bit per component YCbCr 420, two plane
>> > + - Plane 0: 1 component
>> > + * Component 0: Y(8)
>> > + Plane 1: 2 components
>> > + * Component 0: Cb(8, 2x2 subsampled)
>> > + * Component 1: Cr(8, 2x2 subsampled)
>> > +
>> > + * - DRM_FORMAT_P010
>> > + - 10-bit per component YCbCr 420, two plane
>> > + - Plane 0: 1 component
>> > + * Component 0: Y(10)
>> > + Plane 1: 2 components
>> > + * Component 0: Cb(10, 2x2 subsampled)
>> > + * Component 1: Cr(10, 2x2 subsampled)
>> > diff --git a/Documentation/gpu/drivers.rst b/Documentation/gpu/drivers.rst
>> > index 7c16721..c176b34 100644
>> > --- a/Documentation/gpu/drivers.rst
>> > +++ b/Documentation/gpu/drivers.rst
>> > @@ -17,6 +17,7 @@ GPU Driver Documentation
>> > vkms
>> > bridge/dw-hdmi
>> > xen-front
>> > + afbc
>> >
>> > .. only:: subproject and html
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 254b7b2..aef18e3 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -1131,6 +1131,7 @@ M: Mali DP Maintainers
>> > S:Supported
>> > F:drivers/gpu/drm/arm/
>> > F:Documentation/devicetree/bindings/display/arm,malidp.txt
>> > +F:Documentation/gpu/afbc.rst
>> >
>> > ARM MFM AND FLOPPY DRIVERS
>> > M:Ian Molton
>> > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> > index 75c4b5a..0adde4d 100644
>> > --- a/include/uapi/drm/drm_fourcc.h
>> > +++ b/include/uapi/drm/drm_fourcc.h
>> > @@ -597,6 +597,9 @@ extern "C" {
>> > * AFBC has several features which may be supported and/or used, which are
>> > * represented using bits in the modifier. Not all combinations are valid,
>> > * and different devices or use-cases may support different combinations.
>> > + *
>> > + * Further information on the use of AFBC modifiers can be found in
>> > + * Documentation/gpu/afbc.rst
>> > */
>> > #define DRM_FORMAT_MOD_ARM_AFBC(__afbc_mode) fourcc_mod_code(ARM,
>> > __afbc_mode)
>> >
>>
>>
--
Jani Nikula, Intel Open Source Graphics Center
Include asm/div64.h for do_div() usage in DIV_ROUND_DOWN_ULL() and
DIV_ROUND_CLOSEST_ULL(). Remove the old CONFIG_LBDAF=y conditional
include.
Signed-off-by: Jani Nikula
---
include/linux/kernel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/kernel.h b
ude
> #include
> #include
> -#include
> #include "i915_drv.h"
> #include "intel_drv.h"
> #include "intel_dsi.h"
--
Jani Nikula, Intel Open Source Graphics Center
On Wed, 19 Dec 2018, Shayenne Moura wrote:
> On 12/19, Jani Nikula wrote:
>> On Tue, 18 Dec 2018, Shayenne Moura wrote:
>> > This patch serie removes drm_mode_object dependency from
>> > drm_display_mode struct. This is part of KMS cleanup.
>>
>> For
On Tue, 18 Dec 2018, Shayenne Moura wrote:
> This patch removes base.id prints from drm_display_mode
>
> objects in i915 files. It removes dependency from drm_mode_object.
As said, this could expand on the *why*. With that fixed,
Reviewed-by: Jani Nikula
+--
> include/drm/drm_modes.h | 10 --
> 17 files changed, 36 insertions(+), 49 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
On Fri, 16 Nov 2018, Joe Perches wrote:
> On Fri, 2018-11-16 at 14:44 +0200, Jani Nikula wrote:
>> I quickly cooked up this script to produce the top-5 commit prefixes for
>> the given files over the arbitrary last 200 commits. It'll give you a
>> pretty good idea
On Fri, 16 Nov 2018, Joe Perches wrote:
> On Fri, 2018-11-16 at 14:44 +0200, Jani Nikula wrote:
>> I quickly cooked up this script to produce the top-5 commit prefixes for
>> the given files over the arbitrary last 200 commits. It'll give you a
>> pretty good idea
On Wed, 10 Oct 2018, Nick Desaulniers wrote:
> On Wed, Oct 10, 2018 at 1:30 PM Michal Wajdeczko
> wrote:
>>
>> On Wed, 10 Oct 2018 14:01:40 +0200, Jani Nikula
>> wrote:
>>
>> > On Tue, 09 Oct 2018, Nick Desaulniers wrote:
>> >> On Tue, Oct
On Wed, 10 Oct 2018, Nick Desaulniers wrote:
> On Wed, Oct 10, 2018 at 1:30 PM Michal Wajdeczko
> wrote:
>>
>> On Wed, 10 Oct 2018 14:01:40 +0200, Jani Nikula
>> wrote:
>>
>> > On Tue, 09 Oct 2018, Nick Desaulniers wrote:
>> >> On Tue, Oct
son
> Cc: Jani Nikula
> Cc: Andy Gospodarek
> Cc: David S. Miller
> Cc: Thomas Gleixner
> Cc: Andrew Morton
> Cc: Ingo Molnar
Reviewed-by: Jani Nikula
> ---
> include/linux/bitops.h | 3 ++-
> include/linux/net_dim.h | 1 -
> 2 files changed, 2 insertions(+),
son
> Cc: Jani Nikula
> Cc: Andy Gospodarek
> Cc: David S. Miller
> Cc: Thomas Gleixner
> Cc: Andrew Morton
> Cc: Ingo Molnar
Reviewed-by: Jani Nikula
> ---
> include/linux/bitops.h | 3 ++-
> include/linux/net_dim.h | 1 -
> 2 files changed, 2 insertions(+),
gt; if (metasize)
> skb_metadata_set(skb, metasize);
>
> Thanks,
> Daniel
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
gt; if (metasize)
> skb_metadata_set(skb, metasize);
>
> Thanks,
> Daniel
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
On Thu, 24 May 2018, Joe Perches <j...@perches.com> wrote:
> On Fri, 2018-05-25 at 09:41 +0300, Jani Nikula wrote:
>> On Thu, 24 May 2018, Joe Perches <j...@perches.com> wrote:
>> > There is currently a mixture of octal and symbolic permissions uses
>> > i
On Thu, 24 May 2018, Joe Perches wrote:
> On Fri, 2018-05-25 at 09:41 +0300, Jani Nikula wrote:
>> On Thu, 24 May 2018, Joe Perches wrote:
>> > There is currently a mixture of octal and symbolic permissions uses
>> > in files in drivers/gpu/drm
-
> drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +-
Please send at least i915 changes separately. There's zero reason to
make our lives harder for this change.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
pe_crc.c | 2 +-
Please send at least i915 changes separately. There's zero reason to
make our lives harder for this change.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
gt;
>> Cc: Sean Paul <seanp...@chromium.org>
>> Cc: David Airlie <airl...@linux.ie>
>> Cc: dri-de...@lists.freedesktop.org
--
Jani Nikula, Intel Open Source Graphics Center
05d8e267 ("drm: panel-orientation-quirks: Convert to use match_string()
helper")
BR,
Jani.
>
>> Cc: Gustavo Padovan
>> Cc: Maarten Lankhorst
>> Cc: Sean Paul
>> Cc: David Airlie
>> Cc: dri-de...@lists.freedesktop.org
--
Jani Nikula, Intel Open Source Graphics Center
en coded variant.
>
> https://patchwork.kernel.org/patch/10382323/
Even more convincingly,
47d4cb8ae8e7 ("i915: Convert to use match_string() helper")
BR,
Jani.
>
>> Cc: Jani Nikula <jani.nik...@linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
ven more convincingly,
47d4cb8ae8e7 ("i915: Convert to use match_string() helper")
BR,
Jani.
>
>> Cc: Jani Nikula
>> Cc: Joonas Lahtinen
>> Cc: Rodrigo Vivi
>> Cc: David Airlie
>> Cc: intel-...@lists.freedesktop.org
>> Cc: dri-de...@lists.freedesktop.org
--
Jani Nikula, Intel Open Source Graphics Center
On Wed, 09 May 2018, Jani Nikula <jani.nik...@linux.intel.com> wrote:
> On Wed, 09 May 2018, Colin King <colin.k...@canonical.com> wrote:
>> From: Colin Ian King <colin.k...@canonical.com>
>>
>> Trivial fix to spelling mistakes in WARN warning message te
On Wed, 09 May 2018, Jani Nikula wrote:
> On Wed, 09 May 2018, Colin King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistakes in WARN warning message text and
>> in comments:
>>
>> "seqeuncer", "seqeuencer" ->
a Signed-off-by from their committer.
Zhi's rebase fail leading to change of committer that I failed to
reject. :(
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
mmitter.
Zhi's rebase fail leading to change of committer that I failed to
reject. :(
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
k is a literal block. Adding
heuristics (especially ones based on English language magic words) will
lead to bigger problems than it's trying to solve.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ally ones based on English language magic words) will
lead to bigger problems than it's trying to solve.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
quot;sequencer"
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
(Waiting for the CI runs before merging.)
> ---
>
> V2: Also fix seqeuencer in comments
>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 12 ++
On Wed, 09 May 2018, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistakes in WARN warning message text and
> in comments:
>
> "seqeuncer", "seqeuencer" -> "sequencer"
>
> Signed-off-by: Colin Ian King
Reviewed-
& DP_PORT_EN,
> - "skipping pipe %c power seqeuncer kick due to port %c being
> active\n",
> + "skipping pipe %c power sequencer kick due to port %c being
> active\n",
>pipe_name(pipe), port_name(intel_dig_port->base.port)))
> return;
--
Jani Nikula, Intel Open Source Technology Center
being
> active\n",
> + "skipping pipe %c power sequencer kick due to port %c being
> active\n",
> pipe_name(pipe), port_name(intel_dig_port->base.port)))
> return;
--
Jani Nikula, Intel Open Source Technology Center
--- a/Documentation/translations/ko_KR/memory-barriers.txt
>> +++ b/Documentation/translations/ko_KR/memory-barriers.txt
>> @@ -2846,7 +2846,7 @@ CPU 의 캐시에서 RAM 으로 쓰여지는 더티 캐시 라인에 의해 덮
>> 문제를 해결하기 위해선, 커널의 적절한 부분에서 각 CPU 의 캐시 안의 문제가 되는
>> 비트들을 무효화 시켜야 합니다.
>>
>> -캐시 관리에 대한 더 많은 정보를 위해선 Documentation/cachetlb.txt 를
>> +캐시 관리에 대한 더 많은 정보를 위해선 Documentation/core-api/cachetlb.rst 를
>> 참고하세요.
>>
>>
>> --
>> 2.17.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-doc" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jani Nikula, Intel Open Source Technology Center
b/Documentation/translations/ko_KR/memory-barriers.txt
>> @@ -2846,7 +2846,7 @@ CPU 의 캐시에서 RAM 으로 쓰여지는 더티 캐시 라인에 의해 덮
>> 문제를 해결하기 위해선, 커널의 적절한 부분에서 각 CPU 의 캐시 안의 문제가 되는
>> 비트들을 무효화 시켜야 합니다.
>>
>> -캐시 관리에 대한 더 많은 정보를 위해선 Documentation/cachetlb.txt 를
>> +캐시 관리에 대한 더 많은 정보를 위해선 Documentation/core-api/cachetlb.rst 를
>> 참고하세요.
>>
>>
>> --
>> 2.17.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-doc" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jani Nikula, Intel Open Source Technology Center
en documented since
commit 8e9b9362266dd16255473c080d846b13e27247bf
Author: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
Date: Sun Dec 6 12:24:31 2009 +0100
Doc/stable rules: add new cherry-pick logic
in v2.6.33 so seems like there should have been enough time to fix the
tools.
BR,
J
umented since
commit 8e9b9362266dd16255473c080d846b13e27247bf
Author: Sebastian Andrzej Siewior
Date: Sun Dec 6 12:24:31 2009 +0100
Doc/stable rules: add new cherry-pick logic
in v2.6.33 so seems like there should have been enough time to fix the
tools.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Fri, 04 May 2018, Satendra Singh Thakur <satendr...@samsung.com> wrote:
> Reviewed-by: Jani Nikula <jani.nik...@linux.intel.com>
No. I commented on the patch, but I never said Reviewed-by. Never assume
Reviewed-by based on random comments on patches.
BR,
Jani.
--
Jani Nik
On Fri, 04 May 2018, Satendra Singh Thakur wrote:
> Reviewed-by: Jani Nikula
No. I commented on the patch, but I never said Reviewed-by. Never assume
Reviewed-by based on random comments on patches.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Tue, 01 May 2018, "Theodore Y. Ts'o" <ty...@mit.edu> wrote:
> Post -rc3 or -rc4, in my opinion bug fixes should wait until the next
> merge window before they get merged at all.
What are -rc5 and later for then if not bug fixes? Baffled.
BR,
Jani.
--
Jani Nik
On Tue, 01 May 2018, "Theodore Y. Ts'o" wrote:
> Post -rc3 or -rc4, in my opinion bug fixes should wait until the next
> merge window before they get merged at all.
What are -rc5 and later for then if not bug fixes? Baffled.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
;
> - val = VIDTCON1_HBPD(hbpd - 1) |
> - VIDTCON1_HFPD(hfpd - 1) |
> - VIDTCON1_HSPW(hsync_len - 1);
> + val = VIDTCON1_HBPD(vm.hback_porch - 1) |
> + VIDTCON1_HFPD(vm.hfront_porch - 1) |
> + VIDTCON1_HSPW(vm.hsync_len - 1);
> writel(val, ctx->regs + driver_data->timing_base + VIDTCON1);
> }
>
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index 0d310be..9ac764b 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -473,6 +473,8 @@ void drm_display_mode_from_videomode(const struct
> videomode *vm,
>struct drm_display_mode *dmode);
> void drm_display_mode_to_videomode(const struct drm_display_mode *dmode,
> struct videomode *vm);
> +void drm_display_mode_crtc_to_videomode(const struct drm_display_mode *dmode,
> +struct videomode *vm);
> void drm_bus_flags_from_videomode(const struct videomode *vm, u32
> *bus_flags);
> int of_get_drm_display_mode(struct device_node *np,
> struct drm_display_mode *dmode, u32 *bus_flags,
--
Jani Nikula, Intel Open Source Technology Center
mode->crtc_hsync_start;
> - hbpd = mode->crtc_htotal - mode->crtc_hsync_end;
> - hfpd = mode->crtc_hsync_start - mode->crtc_hdisplay;
>
> - val = VIDTCON1_HBPD(hbpd - 1) |
> - VIDTCON1_HFPD(hfpd - 1) |
> -
Management version 2
> Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot-,D3cold-)
> Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> Capabilities: [a4] PCI Advanced Features
> AFCap: TP+ FLR+
> AFCtrl: FLR-
> AFStatus: TP-
> Kernel driver in use: i915
> Kernel modules: i915
>
> This warning does not seem to cause any problems.
>
> Thanks,
>
> Larry
--
Jani Nikula, Intel Open Source Technology Center
Address: fee00018 Data:
> Capabilities: [d0] Power Management version 2
> Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot-,D3cold-)
> Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> Capabilitie
(1 << 31) /* reserved for driver
> specific use */
Please also remove the
/* Upper 4 bits are reserved for driver internal use */
comment a few lines up to not give anyone ideas.
With that,
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
>
> };
--
Jani Nikula, Intel Open Source Technology Center
(1 << 1)/* backlight is under
> an fb blank event */
> -#define BL_CORE_DRIVER1 (1 << 31) /* reserved for driver
> specific use */
Please also remove the
/* Upper 4 bits are reserved for driver internal use */
comment a few lines up to
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index e19e64e0d094..c7cb4a7896f4 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -229,6 +229,7 @@ struct fbtft_par {
> ktime_t update_time;
> bool bgr;
> void *extra;
> + bool polarity;
> };
>
> #define NUMARGS(...) (sizeof((int[]){__VA_ARGS__})/sizeof(int))
--
Jani Nikula, Intel Open Source Technology Center
c: Daniel Thompson
> Cc: Jingoo Han
> Cc: Thomas Petazzoni
> Acked-by: Daniel Thompson
> Signed-off-by: Daniel Vetter
Reviewed-by: Jani Nikula
> ---
> drivers/staging/fbtft/fbtft-core.c | 4 ++--
> drivers/staging/fbtft/fbtft.h | 1 +
> 2 files changed, 3 insert
t; Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Jingoo Han <jingooh...@gmail.com>
> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Reviewed-by: Jani Nik
son
> Cc: Jingoo Han
> Acked-by: Daniel Thompson
> Signed-off-by: Daniel Vetter
Reviewed-by: Jani Nikula
> ---
> v2:
> - Consistently treating PANDORA_WAS_OFF as a non-bitfield
> - Drop the kfree that I left behind after switching to devm_kmalloc
> ---
o Han <jingooh...@gmail.com>
> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
> ---
> drivers/video/backlight/generic_bl.c | 5 -
> 1 file ch
101 - 200 of 1745 matches
Mail list logo
