On Wed, 25 Apr 2018, Daniel Vetter wrote:
> Nothing in the entire tree ever sets this, which means this is dead
> code. Remove it.
>
> Cc: Lee Jones
> Cc: Daniel Thompson
> Cc: Jingoo Han
> Acked-by: Daniel Thompson
> Signed-off-by: Daniel Vetter
Reviewed-by: Jani N
about all this.
>
> Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Jingoo Han <jingooh...@gmail.com>
> Cc: Meghana Madhyastha <meghana.madhyas...@gmail.com>
> Acked-by: Daniel Thompson <daniel.thomp...@lin
es
> Cc: Daniel Thompson
> Cc: Jingoo Han
> Cc: Meghana Madhyastha
> Acked-by: Daniel Thompson
> Signed-off-by: Daniel Vetter
Reviewed-by: Jani Nikula
> ---
> include/linux/backlight.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linu
e
backported later on, I'm just punting on that call right now to make
some forward progress here.
Joonas, please do pick f6d3e06f0747 ("drm/i915/glk: Add MODULE_FIRMWARE
for Geminilake") to drm-intel-fixes to queue it to v4.17.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
m just punting on that call right now to make
some forward progress here.
Joonas, please do pick f6d3e06f0747 ("drm/i915/glk: Add MODULE_FIRMWARE
for Geminilake") to drm-intel-fixes to queue it to v4.17.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
> error_entry+0x86/0x100
> [1.170900] softirqs last enabled at (1449580): []
> __do_softirq+0x3dd/0x521
> [1.170922] softirqs last disabled at (1449563): []
> irq_exit+0xb7/0xc0
>
>
> 00:02.0 VGA compatible controller: Intel Corporation Xeon E3-1200 v3/4th Gen
> Core Processor Integrated Graphics Controller (rev 06)
>
> (That's 8086:0402 fwiw)
>
--
Jani Nikula, Intel Open Source Technology Center
> [1.170900] softirqs last enabled at (1449580): []
> __do_softirq+0x3dd/0x521
> [1.170922] softirqs last disabled at (1449563): []
> irq_exit+0xb7/0xc0
>
>
> 00:02.0 VGA compatible controller: Intel Corporation Xeon E3-1200 v3/4th Gen
> Core Processor Integrated Graphics Controller (rev 06)
>
> (That's 8086:0402 fwiw)
>
--
Jani Nikula, Intel Open Source Technology Center
> -Illustration of the muxes behind a connector that supports an alternate mode:
> +Illustration of the muxes behind a connector that supports an alternate
> mode::
>
>
> | Connector |
--
Jani Nikula, Intel Open Source Technology Center
an alternate mode:
> +Illustration of the muxes behind a connector that supports an alternate
> mode::
>
>
> | Connector |
--
Jani Nikula, Intel Open Source Technology Center
>* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
>*/
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> struct drm_display_mode *mode);
Please
* otherwise.
>*/
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> struct drm_display_mode *mode);
Please adjust the alignment here as well. With that,
Reviewed-
On Fri, 20 Apr 2018, Ian W MORRISON <ianwmorri...@gmail.com> wrote:
> I've performed backport testing and some additional analysis as follows:
What testing did you do beyond booting? Did you run igt?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Fri, 20 Apr 2018, Ian W MORRISON wrote:
> I've performed backport testing and some additional analysis as follows:
What testing did you do beyond booting? Did you run igt?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ainer that you're splitting apart the
>> VM_FAULT and errno codes.
>>
>> Sorry for not catching this during initial review.
>
> Ok, I will make required changes and send v2. Sorry, even I missed this :)
I'm afraid Daniel is closer to the truth. My bad, sorry for the noise.
BR,
codes.
>>
>> Sorry for not catching this during initial review.
>
> Ok, I will make required changes and send v2. Sorry, even I missed this :)
I'm afraid Daniel is closer to the truth. My bad, sorry for the noise.
BR,
Jani.
>>
>> > On Tue, Apr 17,
case -EFAULT:
> - ret = VM_FAULT_SIGBUS;
> + retval = VM_FAULT_SIGBUS;
> break;
> default:
> WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
> - ret = VM_FAULT_SIGBUS;
> + retval = VM_FAULT_SIGBUS;
> break;
> }
> - return ret;
> + return retval;
> }
>
> static void __i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
> --
> 1.9.1
>
--
Jani Nikula, Intel Open Source Technology Center
retval = VM_FAULT_SIGBUS;
> break;
> default:
> WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
> - ret = VM_FAULT_SIGBUS;
> + retval = VM_FAULT_SIGBUS;
> break;
> }
> - return ret;
> + return retval;
> }
>
> static void __i915_gem_object_release_mmap(struct drm_i915_gem_object *obj)
> --
> 1.9.1
>
--
Jani Nikula, Intel Open Source Technology Center
On Mon, 16 Apr 2018, "Srivatsa, Anusha" <anusha.sriva...@intel.com> wrote:
>>-Original Message-----
>>From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
>>Sent: Wednesday, April 11, 2018 5:27 AM
>>To: Ian W MORRISON <ianwmorri...@gmail.com&g
On Mon, 16 Apr 2018, "Srivatsa, Anusha" wrote:
>>-Original Message-----
>>From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
>>Sent: Wednesday, April 11, 2018 5:27 AM
>>To: Ian W MORRISON
>>Cc: Vivi, Rodrigo ; Srivatsa, Anusha
>>; Wajd
t = block * EDID_LENGTH;
> + int retries = 5;
>
> /*
>* The core I2C driver will automatically retry the transfer if the
> @@ -1512,6 +1515,7 @@ bool drm_edid_is_valid(struct edid *edid)
> break;
> }
> } while (ret != xfers && --retries);
> +#endif /* CONFIG_I2C */
>
> return ret == xfers ? 0 : -1;
> }
--
Jani Nikula, Intel Open Source Technology Center
ies = 5;
>
> /*
>* The core I2C driver will automatically retry the transfer if the
> @@ -1512,6 +1515,7 @@ bool drm_edid_is_valid(struct edid *edid)
> break;
> }
> } while (ret != xfers && --retries);
> +#endif /* CONFIG_I2C */
>
> return ret == xfers ? 0 : -1;
> }
--
Jani Nikula, Intel Open Source Technology Center
y sent the patch to
> the same people as
> a similar patch (https://patchwork.kernel.org/patch/10143637/) however
> after realising
> this omitted required addresses I added them and resent the patch.
>
> Best regards,
> Ian
--
Jani Nikula, Intel Open Source Technology Center
me people as
> a similar patch (https://patchwork.kernel.org/patch/10143637/) however
> after realising
> this omitted required addresses I added them and resent the patch.
>
> Best regards,
> Ian
--
Jani Nikula, Intel Open Source Technology Center
@@ -35,6 +35,7 @@
> */
>
> #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> +MODULE_FIRMWARE(I915_CSR_GLK);
> #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
>
> #define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
--
Jani Nikula, Intel Open Source Technology Center
I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> +MODULE_FIRMWARE(I915_CSR_GLK);
> #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
>
> #define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
--
Jani Nikula, Intel Open Source Technology Center
> Fixes: bdecb33af34f ("usb: typec: API for controlling USB Type-C
> Multiplexers")
> Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com>
Reviewed-and-tested-by: Jani Nikula <jani.nik...@intel.com>
> ---
> Changed since v1:
> - Using literal-bl
Type-C
> Multiplexers")
> Signed-off-by: Heikki Krogerus
Reviewed-and-tested-by: Jani Nikula
> ---
> Changed since v1:
> - Using literal-block element instead of comment
> - Subject in v1 was "Documentation: typec.rst: Mark ascii art as a comment"
> ---
> Illustration of the muxes behind a connector that supports an alternate mode:
>
> -
> +..
> | Connector |
>
> | |
--
Jani Nikula, Intel Open Source Technology Center
ion of the muxes behind a connector that supports an alternate mode:
>
> -
> +..
> | Connector |
> ----
> | |
--
Jani Nikula, Intel Open Source Technology Center
kfree(lut);
> + kmem_cache_free(lut);
> goto err_obj;
> }
--
Jani Nikula, Intel Open Source Technology Center
fer *eb)
>
> err = radix_tree_insert(handles_vma, handle, vma);
> if (unlikely(err)) {
> - kfree(lut);
> + kmem_cache_free(lut);
> goto err_obj;
> }
--
Jani Nikula, Intel Open Source Technology Center
On Tue, 03 Apr 2018, Julia Lawall <julia.law...@lip6.fr> wrote:
> On Tue, 3 Apr 2018, Jani Nikula wrote:
>> Please do consider limiting the distribution in the future,
>> though. There's no need to include lkml or even dri-devel for trivial
>> patches like thi
On Tue, 03 Apr 2018, Julia Lawall wrote:
> On Tue, 3 Apr 2018, Jani Nikula wrote:
>> Please do consider limiting the distribution in the future,
>> though. There's no need to include lkml or even dri-devel for trivial
>> patches like this.
>
> It's complex to have
ASIC type: 0x%X\n", adev->asic_type);
> goto fail;
> }
>
> @@ -1715,7 +1715,7 @@ static int dm_early_init(void *handle)
> break;
> #endif
> default:
> - DRM_ERROR("Usupported ASIC type: 0x%X\n", adev-
> @@ -1715,7 +1715,7 @@ static int dm_early_init(void *handle)
> break;
> #endif
> default:
> - DRM_ERROR("Usupported ASIC type: 0x%X\n", adev->asic_type);
> + DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
> return -EINVAL;
> }
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 21 Mar 2018, Jonathan Corbet <cor...@lwn.net> wrote:
> To head that off, I think I'll apply your first version instead, sorry
> Jani.
No worries.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 21 Mar 2018, Jonathan Corbet wrote:
> To head that off, I think I'll apply your first version instead, sorry
> Jani.
No worries.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
on)
> +subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
>
> # Fine grained warnings disable
--
Jani Nikula, Intel Open Source Technology Center
, initializer-overrides)
> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
>
> # Fine grained warnings disable
--
Jani Nikula, Intel Open Source Technology Center
Jani.
> +
> +.. code-block:: c
> +
> + while (condition) {
> + if (test)
> + do_something();
> + }
> +
> 3.1) Spaces
> ***
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-doc
+ while (condition) {
> + if (test)
> + do_something();
> + }
> +
> 3.1) Spaces
> ***
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-doc" in
> the body of a message to majord...
-ccflags-y to prevent more from
cropping up:
c5c2b11894f4 ("drm/i915: Warn against variable length arrays")
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ent more from
cropping up:
c5c2b11894f4 ("drm/i915: Warn against variable length arrays")
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ve which has been available since
> docutils 0.5 released in 2009.
>
> Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1083694
> Co-developed-by: Takashi Iwai <ti...@suse.de>
> Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
I think this is the best approach
5 released in 2009.
>
> Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1083694
> Co-developed-by: Takashi Iwai
> Signed-off-by: Matthew Wilcox
I think this is the best approach.
FWIW,
Acked-by: Jani Nikula
>
> diff --git a/Documentation/sphinx/kerneldoc.py
> b/Do
+except ImportError:
> +from sphinx.util.compat import Directive
> from sphinx.ext.autodoc import AutodocReporter
>
> __version__ = '1.0'
--
Jani Nikula, Intel Open Source Technology Center
m sphinx.util.compat import Directive
> from sphinx.ext.autodoc import AutodocReporter
>
> __version__ = '1.0'
--
Jani Nikula, Intel Open Source Technology Center
ld code over to the new
API?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
gt; References: 91f9d330cc14 ("module: make it possible to have unsafe, tainting
> module params")
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nik...@intel.com>
> Cc: Rusty Russell <ru...@rustcorp.com.au>
> Cc: Je
quot;module: make it possible to have unsafe, tainting
> module params")
> Signed-off-by: Chris Wilson
> Cc: Jani Nikula
> Cc: Rusty Russell
> Cc: Jean Delvare
> Cc: Andrew Morton
> Cc: Li Zhong
> Cc: Petri Latvala
> Cc: Daniel Vetter
Acked-by: Jani Nikula
m_config(pchip->pwmd, duty, period, BIT(ffs(caps.modes) - 1));
>
> Well... I admit I've only really looked at the patches that impact
> backlight but dispersing this really odd looking bit twiddling
> throughout the kernel doesn't strike me a great API design.
>
> IMHO callers should not be required to find the first set bit in
> some specially crafted set of capability bits simply to get sane
> default behaviour.
Agreed. IMHO the regular use case becomes rather tedious, ugly, and
error prone.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
Well... I admit I've only really looked at the patches that impact
> backlight but dispersing this really odd looking bit twiddling
> throughout the kernel doesn't strike me a great API design.
>
> IMHO callers should not be required to find the first set bit in
> some specially crafted set of capability bits simply to get sane
> default behaviour.
Agreed. IMHO the regular use case becomes rather tedious, ugly, and
error prone.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
8 bpc, but is a 6 bpc panel */
> + { "CPT", 0x17df, EDID_QUIRK_FORCE_6BPC },
> +
> /* Belinea 10 15 55 */
> { "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 },
> { "MAX", 0x77e, EDID_QUIRK_PREFER_LARGE_60 },
--
Jani Nikula, Intel Open Source Technology Center
uct edid_quirk {
> /* AEO model 0 reports 8 bpc, but is a 6 bpc panel */
> { "AEO", 0, EDID_QUIRK_FORCE_6BPC },
>
> + /* CPT panel of Asus UX303LA reports 8 bpc, but is a 6 bpc panel */
> + { "CPT", 0x17df, EDID_QUIRK_FORCE_6BPC },
> +
> /* Belin
c commit while applying patch 6,
but I can't find the others. I guess applied literally meant just
applied, not pushed... ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
the others. I guess applied literally meant just
applied, not pushed... ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
dev_priv->bridge_dev =
>> +pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0));
>> if (!dev_priv->bridge_dev) {
>> DRM_ERROR("bridge device not found\n");
>> return -1;
>> --
>> 1.9.1
>>
>>
>> ___
>> linux-arm-kernel mailing list
>> linux-arm-ker...@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Jani Nikula, Intel Open Source Technology Center
> +pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0));
>> if (!dev_priv->bridge_dev) {
>> DRM_ERROR("bridge device not found\n");
>> return -1;
>> --
>> 1.9.1
>>
>>
>> ___
>> linux-arm-kernel mailing list
>> linux-arm-ker...@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Jani Nikula, Intel Open Source Technology Center
5c8bc426 ("drm/i915/selftests: add missing gtt shrinker test")
> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
(Having some issues with fdo connections, thus not pushing.)
> ---
> drivers/gpu/drm/i915/sel
ts: add missing gtt shrinker test")
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Jani Nikula
(Having some issues with fdo connections, thus not pushing.)
> ---
> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(
t; Apply a hack to the output code to recognize literal blocks and avoid
> performing any special markup on them. It's ugly, but that means it fits
> in well with the rest of the script.
With emphasis on part (d) of the reviewer's statement of oversight,
Reviewed-by: Jani Nikula <jan
to the output code to recognize literal blocks and avoid
> performing any special markup on them. It's ugly, but that means it fits
> in well with the rest of the script.
With emphasis on part (d) of the reviewer's statement of oversight,
Reviewed-by: Jani Nikula
>
&
f-by: Jonathan Corbet <cor...@lwn.net>
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
> ---
> scripts/kernel-doc | 65
> --
> 1 file changed, 9 insertions(+), 56 deletions(-)
>
> diff --git a/scripts/kernel-doc b/sc
t;";
> }
> @@ -2057,7 +2010,7 @@ sub process_file($) {
> $contents = $2;
> if ($contents ne "") {
> $contents .= "\n";
> - dump_section($file, $section, xml_escape($contents));
> + dump_section($file, $section, $contents);
> $section = $section_default;
> $contents = "";
> }
> @@ -2072,7 +2025,7 @@ sub process_file($) {
> } elsif ($state == STATE_DOCBLOCK) {
> if (/$doc_end/)
> {
> - dump_doc_section($file, $section,
> xml_escape($contents));
> + dump_doc_section($file, $section, $contents);
> $section = $section_default;
> $contents = "";
> $function = "";
--
Jani Nikula, Intel Open Source Technology Center
On Fri, 09 Feb 2018, Linus Torvalds <torva...@linux-foundation.org> wrote:
> On Fri, Feb 9, 2018 at 1:32 AM, Jani Nikula <jani.nik...@linux.intel.com>
> wrote:
>>> + # miguel-style comment kludge, look for blank lines after
>>> + # @parameter
On Fri, 09 Feb 2018, Linus Torvalds wrote:
> On Fri, Feb 9, 2018 at 1:32 AM, Jani Nikula
> wrote:
>>> + # miguel-style comment kludge, look for blank lines after
>>> + # @parameter line to signify start of description
>>
>> The "miguel-style"
not a good
>> solution because that way the desktop shell can't tell when a monitor is
>> plugged in or removed.
>>
>> Cc: Jani Nikula <jani.nik...@intel.com>
>> Fixes: 53fd40a ("drm: handle override and firmware EDID at drm_do_get_edid()
>> level"
lution because that way the desktop shell can't tell when a monitor is
>> plugged in or removed.
>>
>> Cc: Jani Nikula
>> Fixes: 53fd40a ("drm: handle override and firmware EDID at drm_do_get_edid()
>> level")
>
> Please disregard this, should have gi
it's deeper.
> + $line =~ /^(\s*)/;
> + $litprefix = '^' . $1 . ' ';
> + $output .= highlight_block($block);
> + $block = ""
> + }
> + }
> +}
> +
> +if ($block) {
> + $output .= highlight_block($block);
> +}
> +foreach $line (split "\n", $output) {
> print $lineprefix . $line . "\n";
> }
> }
--
Jani Nikula, Intel Open Source Technology Center
$line =~ /^(\s*)/;
> + $litprefix = '^' . $1 . ' ';
> + $output .= highlight_block($block);
> + $block = ""
> + }
> + }
> +}
> +
> +if ($block) {
> + $output .= highlight_block($block);
> +}
> +foreach $line (split "\n", $output) {
> print $lineprefix . $line . "\n";
> }
> }
--
Jani Nikula, Intel Open Source Technology Center
patch.
>>
>> if
>> {
>> ...
>> }
>> else
>> {
>> ...
>> }
>>
>> instead of
>>
>> if {
>> ...
>> } else {
>> eee
>> }
>
> True, that's worth fixing up while I'm in the neighborhood. I'll do that
&g
t; ...
>> }
>> else
>> {
>> ...
>> }
>>
>> instead of
>>
>> if {
>> ...
>> } else {
>> eee
>> }
>
> True, that's worth fixing up while I'm in the neighborhood. I'll do that
> before I commit the set.
With th
On Wed, 07 Feb 2018, Jonathan Corbet <cor...@lwn.net> wrote:
> Move the top-level prototype-processing code out of process_file().
>
> Signed-off-by: Jonathan Corbet <cor...@lwn.net>
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
>
On Wed, 07 Feb 2018, Jonathan Corbet wrote:
> Move the top-level prototype-processing code out of process_file().
>
> Signed-off-by: Jonathan Corbet
Reviewed-by: Jani Nikula
> ---
> scripts/kernel-doc | 46 --
> 1 file changed, 28
n_default;
> + $contents = "";
> + }
> + # look for doc_com + + doc_end:
> + if ($_ =~ m'\s*\*\s*[a-zA-Z_0-9:\.]+\*/') {
> + print STDERR "${file}:$.: warning: suspicious ending line: $_";
> + ++$warnings;
> + }
> +
>
;";
> + }
> + # look for doc_com + + doc_end:
> + if ($_ =~ m'\s*\*\s*[a-zA-Z_0-9:\.]+\*/') {
> + print STDERR "${file}:$.: warning: suspicious ending line: $_";
> + ++$warnings;
> + }
> +
> + $prototype = "";
> +
passing, but looks okay.
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
> ---
> scripts/kernel-doc | 137
> -
> 1 file changed, 72 insertions(+), 65 deletions(-)
>
> diff --git a/scripts/kernel-doc b/scripts/kern
On Wed, 07 Feb 2018, Jonathan Corbet wrote:
> Move this code out of process_file() in the name of readability and
> maintainability.
>
> Signed-off-by: Jonathan Corbet
I admit I don't fully understand the semantics of perl parameter
passing, but looks okay.
Reviewed-by:
te = STATE_NAME;# next line is always the function name
> + $in_doc_sect = 0;
> + $declaration_start_line = $. + 1;
> +}
> +}
> +
> +
> +
Superfluous whitespace, but fixed in the next patch so I'll look the
other way.
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
> sub process_
name
> + $in_doc_sect = 0;
> + $declaration_start_line = $. + 1;
> +}
> +}
> +
> +
> +
Superfluous whitespace, but fixed in the next patch so I'll look the
other way.
Reviewed-by: Jani Nikula
> sub process_file($) {
> my $file;
> my $identifier;
> @@ -1807
ting the script won. But just
barely.
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
> ---
> scripts/kernel-doc | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 5aa4ce21
a proper state (STATE_BODY_MAYBE) instead. This will make the
> subsequent process_file() splitup easier.
>
> Signed-off-by: Jonathan Corbet
I really wanted to avoid leaving behind any evidence that I've ever
reviewed perl, but my sympathy for you updating the script won. But just
barely.
$contents ne "") {
> $contents .= "\n";
> - dump_section($file, $section, xml_escape($contents));
> + dump_section($file, $section, $contents);
> $section = $section_default;
> $contents = "";
> }
> @@ -2072,7 +2025,7 @@ sub process_file($) {
> } elsif ($state == STATE_DOCBLOCK) {
> if (/$doc_end/)
> {
> - dump_doc_section($file, $section,
> xml_escape($contents));
> + dump_doc_section($file, $section, $contents);
> $section = $section_default;
> $contents = "";
> $function = "";
--
Jani Nikula, Intel Open Source Technology Center
+ dump_section($file, $section, $contents);
> $section = $section_default;
> $contents = "";
> }
> @@ -2057,7 +2010,7 @@ sub process_file($) {
> $contents = $2;
> if ($contents ne "") {
> $c
On Fri, 02 Feb 2018, Greg KH <gre...@linuxfoundation.org> wrote:
> On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote:
>>
>> +Knut, Fengguang
>>
>> On Fri, 02 Feb 2018, Greg KH <gre...@linuxfoundation.org> wrote:
>> >- If clang now
On Fri, 02 Feb 2018, Greg KH wrote:
> On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote:
>>
>> +Knut, Fengguang
>>
>> On Fri, 02 Feb 2018, Greg KH wrote:
>> >- If clang now builds the kernel "cleanly", yes, I want to take
>>
56d020b8e826a7da33b1823c059acd0c123f8b.1515072782.git-series.knut.omang@oracle.com
--
Jani Nikula, Intel Open Source Technology Center
23c059acd0c123f8b.1515072782.git-series.knut.omang@oracle.com
--
Jani Nikula, Intel Open Source Technology Center
erstand
> how we can contribute to turn results from bug finders and static analysis
> tools with the manual pre-assessment we can do into valuable contributions
> on the mailing list and the linux kernel development.
>
> We certainly do not intend to spam the mailing list with reports of
> findings nobody cares about.
Being brutally honest, please write shorter reports and shorter emails
to the lists.
The static analysis reports are welcome, but only when 1) we didn't
already fix it in linux-next, or 2) it reveals an actual bug, not just a
warning, warranting a backport.
Thanks,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
see if clang warnings are of interest
> at all, and we are glad that you came back to us so quickly with feedback.
>
> Greg, if you can continue to be a sparing partner and point out when
> we are moving in the wrong direction, we will try our best to understand
> how we can contribute to
later on, which is just backwards.
BR,
Jani.
>
> So I think this is either something that should go directly into
> ABI/obsolete (with a fairly short expiry time) or perhaps simply
> remove the property entirely.
>
>
> Daniel.
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
lete (with a fairly short expiry time) or perhaps simply
> remove the property entirely.
>
>
> Daniel.
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
ve the Maintainer: bit
from the end near the top as a reStructuredText field list. See 'git
grep :Author:' under Documentation for examples. Could even add a
MAINTAINERS entry to improve your chances of being Cc'd on changes.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
d near the top as a reStructuredText field list. See 'git
grep :Author:' under Documentation for examples. Could even add a
MAINTAINERS entry to improve your chances of being Cc'd on changes.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
losure closure = {
>> >.connector = connector,
>> > .edid = edid,
>> > - .preferred = 1,
>> > + .preferred = true,
>> >.quirks = quirks,
>> >};
>> >
>> > --
>> > 2.7.4
>> >
>>
>> --
>> Sean Paul, Software Engineer, Google / Chromium OS
>> ___
>> dri-devel mailing list
>> dri-de...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
gt;.edid = edid,
>> > - .preferred = 1,
>> > + .preferred = true,
>> >.quirks = quirks,
>> >};
>> >
>> > --
>> > 2.7.4
>> >
>>
>> --
>> Sean Paul, Software Engineer, Google / Chromium OS
>> ___
>> dri-devel mailing list
>> dri-de...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
+ return drm_gem_cma_dumb_create_internal(file, dev, args);
>> > +}
>> > +
>> >
>> > DEFINE_DRM_GEM_CMA_FOPS(drv_driver_fops);
>> >
>> > static struct drm_driver drv_driver = {
>> >
>> > @@ -44,7 +62,7 @@ static struct drm_driver drv_driver = {
>> >
>> > .minor = 0,
>> > .patchlevel = 0,
>> > .fops = _driver_fops,
>> >
>> > - .dumb_create = drm_gem_cma_dumb_create,
>> > + .dumb_create = stm_gem_cma_dumb_create,
>> >
>> > .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> > .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> > .gem_free_object_unlocked = drm_gem_cma_free_object,
>> >
>> > --
>> > 2.15.1
--
Jani Nikula, Intel Open Source Technology Center
r_fops);
>> >
>> > static struct drm_driver drv_driver = {
>> >
>> > @@ -44,7 +62,7 @@ static struct drm_driver drv_driver = {
>> >
>> > .minor = 0,
>> > .patchlevel = 0,
>> > .fops = _driver_fops,
>> >
>> > - .dumb_create = drm_gem_cma_dumb_create,
>> > + .dumb_create = stm_gem_cma_dumb_create,
>> >
>> > .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> > .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> > .gem_free_object_unlocked = drm_gem_cma_free_object,
>> >
>> > --
>> > 2.15.1
--
Jani Nikula, Intel Open Source Technology Center
we had enough duct tape in the Kconfig to keep the
issues at bay. Since you're replying to linux-next, are you saying this
is new? I wonder if something's changed elsewhere.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
201 - 300 of 1745 matches
Mail list logo
