Re: [PATCH] drm/i915: use udelay for very short delays

2016-12-15 Thread Jani Nikula
; > val |= (ULPS_STATE_ENTER | DEVICE_READY); > I915_WRITE(MIPI_DEVICE_READY(port), val); > - usleep_range(2, 3); > + udelay(2); > > /* 3. Exit ULPS */ > val = I915_READ(MIPI_DEVICE_READY(port)); -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] drm/i915: use udelay for very small delays

2016-12-15 Thread Jani Nikula
On Thu, 15 Dec 2016, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Thu, 15 Dec 2016, Nicholas Mc Guire <hof...@osadl.org> wrote: >> usleep_range() is intended for delays in the 10us to 10ms range that need >> good precision. a useleep_range(1, will

Re: [PATCH] drm/i915: use udelay for very small delays

2016-12-15 Thread Jani Nikula
On Thu, 15 Dec 2016, Jani Nikula wrote: > On Thu, 15 Dec 2016, Nicholas Mc Guire wrote: >> usleep_range() is intended for delays in the 10us to 10ms range that need >> good precision. a useleep_range(1, will effectively be no more than an >> imprecise udelay with some a

Re: [PATCH] drm/i915: use udelay for very small delays

2016-12-15 Thread Jani Nikula
tel_encoder > *encoder, > config->dsi_pll.ctrl & ~DSI_PLL_VCO_EN); > > /* wait at least 0.5 us after ungating before enabling VCO */ > - usleep_range(1, 10); > + udelay(1); > > vlv_cck_write(dev_priv, CCK_REG_DSI_PLL_CONTROL, config->dsi_pll.ctrl); -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] drm/i915: use udelay for very small delays

2016-12-15 Thread Jani Nikula
config->dsi_pll.ctrl & ~DSI_PLL_VCO_EN); > > /* wait at least 0.5 us after ungating before enabling VCO */ > - usleep_range(1, 10); > + udelay(1); > > vlv_cck_write(dev_priv, CCK_REG_DSI_PLL_CONTROL, config->dsi_pll.ctrl); -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] doc: add note on usleep_range range

2016-12-13 Thread Jani Nikula
On Tue, 13 Dec 2016, Nicholas Mc Guire <der.h...@hofr.at> wrote: > I fully agree - without automation it is almost usless > the coccinelle spatch is a seperate patch and it is tested butnot yet > submitted. Good, good! Sorry for the noise. BR, Jani. -- Jani Nikula, In

Re: [PATCH] doc: add note on usleep_range range

2016-12-13 Thread Jani Nikula
On Tue, 13 Dec 2016, Nicholas Mc Guire wrote: > I fully agree - without automation it is almost usless > the coccinelle spatch is a seperate patch and it is tested butnot yet > submitted. Good, good! Sorry for the noise. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] doc: add note on usleep_range range

2016-12-13 Thread Jani Nikula
less than 50 microseconds probably is only preventing > + timer subsystem optimization but providing no benefit. > + > SLEEPING FOR LARGER MSECS ( 10ms+ ) > * Use msleep or possibly msleep_interruptible -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] doc: add note on usleep_range range

2016-12-13 Thread Jani Nikula
y preventing > + timer subsystem optimization but providing no benefit. > + > SLEEPING FOR LARGER MSECS ( 10ms+ ) > * Use msleep or possibly msleep_interruptible -- Jani Nikula, Intel Open Source Technology Center

Re: [RFC PATCH 0/3] staging: remove fbdev drivers

2016-12-08 Thread Jani Nikula
w that is indeed the right answer, and the attitude we're looking for! Being able to say "no", especially wrt fbdev drivers, is a must have quality. You're hired! ;D BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [RFC PATCH 0/3] staging: remove fbdev drivers

2016-12-08 Thread Jani Nikula
re looking for! Being able to say "no", especially wrt fbdev drivers, is a must have quality. You're hired! ;D BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-08 Thread Jani Nikula
stead. I don't have the time for this. I hope the bug reporters who'll be told to report the bugs somewhere else do. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-08 Thread Jani Nikula
or this. I hope the bug reporters who'll be told to report the bugs somewhere else do. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-08 Thread Jani Nikula
On Thu, 08 Dec 2016, "Rafael J. Wysocki" <r...@rjwysocki.net> wrote: > On Wednesday, December 07, 2016 10:35:07 AM Jani Nikula wrote: >> On Wed, 07 Dec 2016, "Rafael J. Wysocki" <r...@rjwysocki.net> wrote: >> > On Monday, December 05, 2016 02:03:5

Re: [PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-08 Thread Jani Nikula
On Thu, 08 Dec 2016, "Rafael J. Wysocki" wrote: > On Wednesday, December 07, 2016 10:35:07 AM Jani Nikula wrote: >> On Wed, 07 Dec 2016, "Rafael J. Wysocki" wrote: >> > On Monday, December 05, 2016 02:03:59 PM Jani Nikula wrote: >> >> Different

Re: [PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-07 Thread Jani Nikula
On Wed, 07 Dec 2016, "Rafael J. Wysocki" <r...@rjwysocki.net> wrote: > On Monday, December 05, 2016 02:03:59 PM Jani Nikula wrote: >> Different subsystems and drivers have different preferences for where to >> file bugs and what information to include. 6865644

Re: [PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-07 Thread Jani Nikula
On Wed, 07 Dec 2016, "Rafael J. Wysocki" wrote: > On Monday, December 05, 2016 02:03:59 PM Jani Nikula wrote: >> Different subsystems and drivers have different preferences for where to >> file bugs and what information to include. 686564434e88 ("MAINTAINERS: >&

[PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-05 Thread Jani Nikula
g tracker directly, a web page for detailed info on filing bugs, or a mailto: URI. Fixes: 686564434e88 ("MAINTAINERS: Add bug tracking system location entry type") Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Cc: Andrew Morton <a...@linux-foundation.org> Signed-off-by: Jani

[PATCH] MAINTAINERS: clarify that "B:" is the URI where to file bugs

2016-12-05 Thread Jani Nikula
g tracker directly, a web page for detailed info on filing bugs, or a mailto: URI. Fixes: 686564434e88 ("MAINTAINERS: Add bug tracking system location entry type") Cc: Rafael J. Wysocki Cc: Andrew Morton Signed-off-by: Jani Nikula --- Rafael, I just noticed the "B:"

Re: [PATCH] drm/i915: Remove instructions to file a bug report.

2016-12-03 Thread Jani Nikula
an then reassign to the right > component if it's not a kernel issue.\n"); > - DRM_INFO("The gpu crash dump is required to analyze gpu hangs, > so please always attach it.\n"); > - DRM_INFO("GPU crash dump saved to > /sys/class/drm/card%d/error\n", > - dev_priv->drm.primary->index); > - warned = true; > - } > } > > void i915_error_state_get(struct drm_device *dev, -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] drm/i915: Remove instructions to file a bug report.

2016-12-03 Thread Jani Nikula
rnel issue.\n"); > - DRM_INFO("The gpu crash dump is required to analyze gpu hangs, > so please always attach it.\n"); > - DRM_INFO("GPU crash dump saved to > /sys/class/drm/card%d/error\n", > - dev_priv->drm.primary->index); > - warned = true; > - } > } > > void i915_error_state_get(struct drm_device *dev, -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] doc: Explain light-handed markup preference a bit better

2016-11-29 Thread Jani Nikula
That is all. Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] doc: Explain light-handed markup preference a bit better

2016-11-29 Thread Jani Nikula
On Tue, 29 Nov 2016, Mauro Carvalho Chehab wrote: > Sorry, but I agree with Daniel here: we should provide a guide > for those people that will be helping with the document conversion. That goal is not mutually exclusive with keeping this document concise. That is all. Jani. -- Jani

Re: [PATCH] doc: Explain light-handed markup preference a bit better

2016-11-29 Thread Jani Nikula
ar and consice. I don't approve of the changes here. This is going to sound like bikeshedding, but I just couldn't make myself not reply. > Cc: Jonathan Corbet <cor...@lwn.net> > Cc: linux-...@vger.kernel.org > Cc: Christoph Hellwig <h...@infradead.org> > Cc: Peter Zijlstra

Re: [PATCH] doc: Explain light-handed markup preference a bit better

2016-11-29 Thread Jani Nikula
e of the changes here. This is going to sound like bikeshedding, but I just couldn't make myself not reply. > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Christoph Hellwig > Cc: Peter Zijlstra > Cc: Jani Nikula > Cc: Mauro Carvalho Chehab > Signed-off-by: D

Re: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup

2016-11-28 Thread Jani Nikula
On Mon, 28 Nov 2016, Peter Zijlstra <pet...@infradead.org> wrote: > On Mon, Nov 28, 2016 at 01:16:45PM +0200, Jani Nikula wrote: >> Using rst we can produce decent HTML pages, and make them available at >> [1], in context. You don't have to read that, but it will be a lot

Re: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup

2016-11-28 Thread Jani Nikula
On Mon, 28 Nov 2016, Peter Zijlstra wrote: > On Mon, Nov 28, 2016 at 01:16:45PM +0200, Jani Nikula wrote: >> Using rst we can produce decent HTML pages, and make them available at >> [1], in context. You don't have to read that, but it will be a lot more >> discoverable for

Re: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup

2016-11-28 Thread Jani Nikula
l rst a "coding style" for plain text. We have pretty uniform C code, I don't think it's unreasonable to have a little bit of consistency in the plain text. And really, it's not much we're asking. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup

2016-11-28 Thread Jani Nikula
plain text. We have pretty uniform C code, I don't think it's unreasonable to have a little bit of consistency in the plain text. And really, it's not much we're asking. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup

2016-11-27 Thread Jani Nikula
ocks. It would result in a smaller diff. But other than that, it's fine. I'm sure Peter is capable of editing a file with a .rst extension, and we can clean up any hickups afterwards if getting the formatting right is insurmountable. > I will drop this patch. Please don't. Please let Jon be the judge of that. Thanks, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v3 2/4] Documentation/atomic_ops.txt: convert to ReST markup

2016-11-27 Thread Jani Nikula
that, it's fine. I'm sure Peter is capable of editing a file with a .rst extension, and we can clean up any hickups afterwards if getting the formatting right is insurmountable. > I will drop this patch. Please don't. Please let Jon be the judge of that. Thanks, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
On Wed, 23 Nov 2016, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: >> On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: >> > On Wed, 23 Nov 2016, Liviu Dudau <liviu.du...@arm.com> wrote: >> >

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
On Wed, 23 Nov 2016, Daniel Vetter wrote: > On Wed, Nov 23, 2016 at 11:23:23AM +, Liviu Dudau wrote: >> On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: >> > On Wed, 23 Nov 2016, Liviu Dudau wrote: >> > > drm_get_format_name() de-references the

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
annoy users that did not pass valid parameters to > function. > > Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name()) > Cc: Eric Engestrom <e...@engestrom.ch> > Cc: Rob Clark <robdcl...@gmail.com> > Cc: Jani Nikula <jani.ni

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Jani Nikula
not pass valid parameters to > function. > > Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name()) > Cc: Eric Engestrom > Cc: Rob Clark > Cc: Jani Nikula > Cc: Daniel Vetter > > Signed-off-by: Liviu Dudau > --- > I still think s

Re: [Ksummit-discuss] [PATCH 0/9] Get rid of bitmap images

2016-11-22 Thread Jani Nikula
lds. I think it should Just Work(tm). BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] [PATCH 0/9] Get rid of bitmap images

2016-11-22 Thread Jani Nikula
ork(tm). BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] [PATCH 0/9] Get rid of bitmap images

2016-11-22 Thread Jani Nikula
spaces within attributes with newlines, and they should be normalized back to spaces by any compliant xml parser. You can use tidy or xmllint to clean up the xml before committing. Unfortunately I couldn't make tidy actually wrap the long attributes, but could be PEBKAC. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] [PATCH 0/9] Get rid of bitmap images

2016-11-22 Thread Jani Nikula
aces by any compliant xml parser. You can use tidy or xmllint to clean up the xml before committing. Unfortunately I couldn't make tidy actually wrap the long attributes, but could be PEBKAC. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-21 Thread Jani Nikula
ms :) FWIW I'm all for doing this stuff in Sphinx, with Sphinx extensions. And to me it sounds like what you describe is interesting outside of kernel too. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-21 Thread Jani Nikula
his stuff in Sphinx, with Sphinx extensions. And to me it sounds like what you describe is interesting outside of kernel too. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-18 Thread Jani Nikula
ether they're seasoned kernel developers or newcomers purely interested in documentation. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-18 Thread Jani Nikula
ers or newcomers purely interested in documentation. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-17 Thread Jani Nikula
rting all the .gif and .png files to .pnm. This would > make the files patchable but also add around 25MB to the uncompressed > kernel source tree (118kb compressed, compared to 113kb for the .gif and > .png files). This is certainly worse than the uuencoded files you > had before > > Arnd > ___ > Ksummit-discuss mailing list > ksummit-disc...@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-17 Thread Jani Nikula
m. This would > make the files patchable but also add around 25MB to the uncompressed > kernel source tree (118kb compressed, compared to 113kb for the .gif and > .png files). This is certainly worse than the uuencoded files you > had before > > Arnd > ___ > Ksummit-discuss mailing list > ksummit-disc...@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH] doc: Document the new inline struct member kernel-doc style

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > We don't just need better doc toolchains, we also need better docs for > our doc toolchain! > > v2: Make sure we don't have foo twice (Jani). Thanks, *now* LGTM. :) > > Cc: Daniel Vetter <dan...@

Re: [PATCH] doc: Document the new inline struct member kernel-doc style

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Daniel Vetter wrote: > We don't just need better doc toolchains, we also need better docs for > our doc toolchain! > > v2: Make sure we don't have foo twice (Jani). Thanks, *now* LGTM. :) > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Jona

Re: [PATCH] doc: Document the new inline struct member kernel-doc style

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Jani Nikula <jani.nik...@intel.com> wrote: > On Thu, 17 Nov 2016, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: >> We don't just need better doc toolchains, we also need better docs for >> our doc toolchain! > > Mea culpa. Thanks, LGTM. Oh, th

Re: [PATCH] doc: Document the new inline struct member kernel-doc style

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Jani Nikula wrote: > On Thu, 17 Nov 2016, Daniel Vetter wrote: >> We don't just need better doc toolchains, we also need better docs for >> our doc toolchain! > > Mea culpa. Thanks, LGTM. Oh, the example struct now has too "foo" fields, do

Re: [PATCH] doc: Document the new inline struct member kernel-doc style

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > We don't just need better doc toolchains, we also need better docs for > our doc toolchain! Mea culpa. Thanks, LGTM. BR, Jani. > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: Jani Nikula <jani.nik..

Re: [PATCH] doc: Document the new inline struct member kernel-doc style

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Daniel Vetter wrote: > We don't just need better doc toolchains, we also need better docs for > our doc toolchain! Mea culpa. Thanks, LGTM. BR, Jani. > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org >

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: > On 16 November 2016 at 13:58, Jani Nikula <jani.nik...@linux.intel.com> wrote: >> On Wed, 16 Nov 2016, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: >>> On 15 November 2016 at 09:27, Jani

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > On 16 November 2016 at 13:58, Jani Nikula wrote: >> On Wed, 16 Nov 2016, Tomeu Vizoso wrote: >>> On 15 November 2016 at 09:27, Jani Nikula >>> wrote: >>>> On Tue, 15 Nov 2016, David Weinehall wrote: >>

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: > On 15 November 2016 at 09:27, Jani Nikula <jani.nik...@linux.intel.com> wrote: >> On Tue, 15 Nov 2016, David Weinehall <t...@kernel.org> wrote: >>> On Mon, Nov 14, 2016 at 12:44:25PM +0200

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-16 Thread Jani Nikula
On Wed, 16 Nov 2016, Tomeu Vizoso wrote: > On 15 November 2016 at 09:27, Jani Nikula wrote: >> On Tue, 15 Nov 2016, David Weinehall wrote: >>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >>>> On Thu, 06 Oct 2016, Tomeu Vizoso wrote: >>&g

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-15 Thread Jani Nikula
On Tue, 15 Nov 2016, David Weinehall <t...@kernel.org> wrote: > On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >> On Thu, 06 Oct 2016, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: >> > diff --git a/drivers/gpu/drm/i915/intel_display.c >> >

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-15 Thread Jani Nikula
On Tue, 15 Nov 2016, David Weinehall wrote: > On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >> On Thu, 06 Oct 2016, Tomeu Vizoso wrote: >> > diff --git a/drivers/gpu/drm/i915/intel_display.c >> > b/drivers/gpu/drm/i915/intel_display.c >> > ind

Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

2016-11-14 Thread Jani Nikula
nale for not expressing this dependency in terms of Kconfig to begin with. With this, it's hidden in code, and the hwmon stuff gets used if the conditions for "nouveau depends on hwmon" are met, by chance, but it's not enforced. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

2016-11-14 Thread Jani Nikula
pendency in terms of Kconfig to begin with. With this, it's hidden in code, and the hwmon stuff gets used if the conditions for "nouveau depends on hwmon" are met, by chance, but it's not enforced. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-14 Thread Jani Nikula
+ if (IS_G4X(dev_priv)) > + g4x_undo_pipe_scramble_reset(dev_priv, crtc->index); > + else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) > + vlv_undo_pipe_scramble_reset(dev_priv, crtc->index); > + else if (IS_HASWELL(dev_priv) && crtc->index == PIPE_A) > + hsw_trans_edp_pipe_A_crc_wa(dev_priv, false); > + > + hsw_enable_ips(intel_crtc); > + } > + > + pipe_crc->skipped = 0; > + *values_cnt = 5; > + > +out: > + intel_display_power_put(dev_priv, power_domain); > + > + return ret; > +} -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

2016-11-14 Thread Jani Nikula
g4x_undo_pipe_scramble_reset(dev_priv, crtc->index); > + else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) > + vlv_undo_pipe_scramble_reset(dev_priv, crtc->index); > + else if (IS_HASWELL(dev_priv) && crtc->index == PIPE_A) > + hsw_trans_edp_pipe_A_crc_wa(dev_priv, false); > + > + hsw_enable_ips(intel_crtc); > + } > + > + pipe_crc->skipped = 0; > + *values_cnt = 5; > + > +out: > + intel_display_power_put(dev_priv, power_domain); > + > + return ret; > +} -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH 4.8 118/138] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-11-11 Thread Jani Nikula
l.com> >> > References: https://bugs.freedesktop.org/show_bug.cgi?id=97877 >> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> >> > Link: >> > http://patchwork.freedesktop.org/patch/msgid/1476208368-5

Re: [PATCH 4.8 118/138] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-11-11 Thread Jani Nikula
port has no alternate aux >> > ch/ddc pin >> > >> > Cc: Maarten Maathuis >> > Tested-by: Maarten Maathuis >> > References: https://bugs.freedesktop.org/show_bug.cgi?id=97877 >> > Signed-off-by: Ville Syrjälä >> > Link: >>

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-11 Thread Jani Nikula
On Thu, 10 Nov 2016, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Thu, 10 Nov 2016, Markus Heiser <markus.hei...@darmarit.de> wrote: >> Could this POC persuade you, if so, I send a more elaborate RFC, >> what do you think about? > >

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-11 Thread Jani Nikula
On Thu, 10 Nov 2016, Jani Nikula wrote: > On Thu, 10 Nov 2016, Markus Heiser wrote: >> Could this POC persuade you, if so, I send a more elaborate RFC, >> what do you think about? > > Sorry, I do not wish to be part of this. That was uncalled for, apologies. Like

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

2016-11-10 Thread Jani Nikula
On Thu, 10 Nov 2016, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Jani, > > On Thursday 10 Nov 2016 12:30:09 Jani Nikula wrote: >> On Thu, 10 Nov 2016, Laurent Pinchart wrote: >> > The issue here is that printk can't format the fourcc as a string b

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

2016-11-10 Thread Jani Nikula
On Thu, 10 Nov 2016, Laurent Pinchart wrote: > Hi Jani, > > On Thursday 10 Nov 2016 12:30:09 Jani Nikula wrote: >> On Thu, 10 Nov 2016, Laurent Pinchart wrote: >> > The issue here is that printk can't format the fourcc as a string by >> > itself. There's a bu

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-10 Thread Jani Nikula
On Thu, 10 Nov 2016, Markus Heiser <markus.hei...@darmarit.de> wrote: > Could this POC persuade you, if so, I send a more elaborate RFC, > what do you think about? Sorry, I do not wish to be part of this. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-10 Thread Jani Nikula
On Thu, 10 Nov 2016, Markus Heiser wrote: > Could this POC persuade you, if so, I send a more elaborate RFC, > what do you think about? Sorry, I do not wish to be part of this. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

2016-11-10 Thread Jani Nikula
scary from the security standpoint. And what if the hook has to allocate memory? Can't do that in atomic contexts. BR, Jani. > >> Could you give me a quick explanation or point me to a doc/page that >> explains how the various trees and branches get merged? >> I googled a bit

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

2016-11-10 Thread Jani Nikula
if the hook has to allocate memory? Can't do that in atomic contexts. BR, Jani. > >> Could you give me a quick explanation or point me to a doc/page that >> explains how the various trees and branches get merged? >> I googled a bit and found this doc [4] by Jani, but it doe

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-09 Thread Jani Nikula
On Wed, 09 Nov 2016, Markus Heiser <markus.hei...@darmarit.de> wrote: > Am 09.11.2016 um 12:16 schrieb Jani Nikula <jani.nik...@linux.intel.com>: >>> So I vote for : >>> >>>> 1) copy (or symlink) all rst files to Documentation/output (or to

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-09 Thread Jani Nikula
On Wed, 09 Nov 2016, Markus Heiser wrote: > Am 09.11.2016 um 12:16 schrieb Jani Nikula : >>> So I vote for : >>> >>>> 1) copy (or symlink) all rst files to Documentation/output (or to the >>>> build dir specified via O= directive) and generate the

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-09 Thread Jani Nikula
On Wed, 09 Nov 2016, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > Em Wed, 09 Nov 2016 13:16:55 +0200 > Jani Nikula <jani.nik...@linux.intel.com> escreveu: > >> >> 1) copy (or symlink) all rst files to Documentation/output (or to the >> &

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-09 Thread Jani Nikula
On Wed, 09 Nov 2016, Mauro Carvalho Chehab wrote: > Em Wed, 09 Nov 2016 13:16:55 +0200 > Jani Nikula escreveu: > >> >> 1) copy (or symlink) all rst files to Documentation/output (or to the >> >> build dir specified via O= directive) and generate the *.pd

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-09 Thread Jani Nikula
that IMHO shouldn't exist... > IMO placing 'sourcedir' to O= is more sane since this marries the > Linux Makefile concept (relative to $PWD) with the sphinx concept > (in or below 'sourcedir'). > > > -- Markus -- > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-doc" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jani Nikula, Intel Open Source Technology Center

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-09 Thread Jani Nikula
this marries the > Linux Makefile concept (relative to $PWD) with the sphinx concept > (in or below 'sourcedir'). > > > -- Markus -- > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-doc" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] [REGRESSION] Linux 4.9-rc4: gfx glitches on Intel Sandybridge (was: Re: Linux 4.9-rc4)

2016-11-09 Thread Jani Nikula
rrent batch of fixes by making unsubstantiated claims. Please do file a bug about that issue over at [1] so we don't hijack this thread. Thanks, Jani. [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI=DRM/Intel -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] [REGRESSION] Linux 4.9-rc4: gfx glitches on Intel Sandybridge (was: Re: Linux 4.9-rc4)

2016-11-09 Thread Jani Nikula
g unsubstantiated claims. Please do file a bug about that issue over at [1] so we don't hijack this thread. Thanks, Jani. [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI=DRM/Intel -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v2 0/6] Fix PDF builds on media documentation

2016-11-08 Thread Jani Nikula
On Tue, 08 Nov 2016, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Mon, 07 Nov 2016, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: >> This series address a series of errors during PDF generation from >> media documentation. > > I'm missing p

Re: [PATCH v2 0/6] Fix PDF builds on media documentation

2016-11-08 Thread Jani Nikula
On Tue, 08 Nov 2016, Jani Nikula wrote: > On Mon, 07 Nov 2016, Mauro Carvalho Chehab wrote: >> This series address a series of errors during PDF generation from >> media documentation. > > I'm missing patches 3-6 of this series, and so is the archive. I meant 4-6. >

Re: [PATCH v2 0/6] Fix PDF builds on media documentation

2016-11-08 Thread Jani Nikula
On Mon, 07 Nov 2016, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > This series address a series of errors during PDF generation from > media documentation. I'm missing patches 3-6 of this series, and so is the archive. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v2 0/6] Fix PDF builds on media documentation

2016-11-08 Thread Jani Nikula
On Mon, 07 Nov 2016, Mauro Carvalho Chehab wrote: > This series address a series of errors during PDF generation from > media documentation. I'm missing patches 3-6 of this series, and so is the archive. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [BUG][REGRESSION] mangled display since -rc1

2016-11-07 Thread Jani Nikula
ranch of http://cgit.freedesktop.org/drm-intel. It's -rc4 plus half a dozen fixes, including "drm/i915: Round tile chunks up for constructing partial VMAs" which should fix the corruption. Please try that, and report back. If it doesn't fix the issue, please file a bug at the freedesktop.org bugzilla. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [BUG][REGRESSION] mangled display since -rc1

2016-11-07 Thread Jani Nikula
g/drm-intel. It's -rc4 plus half a dozen fixes, including "drm/i915: Round tile chunks up for constructing partial VMAs" which should fix the corruption. Please try that, and report back. If it doesn't fix the issue, please file a bug at the freedesktop.org bugzilla. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v2] drm: move allocation out of drm_get_format_name()

2016-11-07 Thread Jani Nikula
On Mon, 07 Nov 2016, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Monday, 2016-11-07 10:10:13 +0200, Jani Nikula wrote: >> On Mon, 07 Nov 2016, Eric Engestrom <e...@engestrom.ch> wrote: >> > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 >> >

Re: [PATCH v2] drm: move allocation out of drm_get_format_name()

2016-11-07 Thread Jani Nikula
On Mon, 07 Nov 2016, Eric Engestrom wrote: > On Monday, 2016-11-07 10:10:13 +0200, Jani Nikula wrote: >> On Mon, 07 Nov 2016, Eric Engestrom wrote: >> > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 >> > >> > drm: make drm_get_format_name thread-sa

Re: [Intel-gfx] [REGRESSION] Linux 4.9-rc4: gfx glitches on Intel Sandybridge (was: Re: Linux 4.9-rc4)

2016-11-07 Thread Jani Nikula
I hope I get a > chance to report it there as well and you get to decide. If drm-intel-fixes doesn't fix the issue for you, please file a *new* bug over at the freedesktop.org bugzilla. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] [REGRESSION] Linux 4.9-rc4: gfx glitches on Intel Sandybridge (was: Re: Linux 4.9-rc4)

2016-11-07 Thread Jani Nikula
to report it there as well and you get to decide. If drm-intel-fixes doesn't fix the issue for you, please file a *new* bug over at the freedesktop.org bugzilla. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] [REGRESSION] Linux 4.9-rc4: gfx glitches on Intel Sandybridge (was: Re: Linux 4.9-rc4)

2016-11-07 Thread Jani Nikula
gt; X.org runs with modesetting driver (default was changed in Debian Sid a while > back). > > Thanks, > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] [REGRESSION] Linux 4.9-rc4: gfx glitches on Intel Sandybridge (was: Re: Linux 4.9-rc4)

2016-11-07 Thread Jani Nikula
river (default was changed in Debian Sid a while > back). > > Thanks, > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center

Re: Including images on Sphinx documents

2016-11-07 Thread Jani Nikula
correct fix is to have this fixed in upstream Sphinx, but as a workaround an extension doing the above seems plausible, and not too much effort - provided that we can make the raw latex work. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: Including images on Sphinx documents

2016-11-07 Thread Jani Nikula
n upstream Sphinx, but as a workaround an extension doing the above seems plausible, and not too much effort - provided that we can make the raw latex work. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [BUG][REGRESSION] mangled display since -rc1

2016-11-07 Thread Jani Nikula
merge. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [BUG][REGRESSION] mangled display since -rc1

2016-11-07 Thread Jani Nikula
things... Pretty please? It's easier for us to direct folks at the bug, with history and logs in one place. I realize only Daniel and me were Cc'd here, not intel-gfx list. Also, please double check your bisect. Not sure why the finger points at i915 when the bisect points at iommu merge. BR, Jani. --

Re: [PATCH v2] drm: move allocation out of drm_get_format_name()

2016-11-07 Thread Jani Nikula
har *drm_get_format_name(uint32_t format) __malloc; > +char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf); I wonder if it would be better to make that return "const char *". If the user really wants to look under the hood, there's buf->str. *shrug* With the co

Re: [PATCH v2] drm: move allocation out of drm_get_format_name()

2016-11-07 Thread Jani Nikula
t plane); > int drm_format_plane_height(int height, uint32_t format, int plane); > -char *drm_get_format_name(uint32_t format) __malloc; > +char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf); I wonder if it would be better to make that return "const char *&quo

Re: [PATCH 3/3] tpm: move documentation under Documentation/security

2016-11-04 Thread Jani Nikula
100% > rename from Documentation/tpm/tpm_vtpm_proxy.rst > rename to Documentation/security/tpm/tpm_vtpm_proxy.rst > diff --git a/Documentation/tpm/xen-tpmfront.txt > b/Documentation/security/tpm/xen-tpmfront.txt > similarity index 100% > rename from Documentation/tpm/xen-tpmfront.txt > rename to Documentation/security/tpm/xen-tpmfront.txt -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH 3/3] tpm: move documentation under Documentation/security

2016-11-04 Thread Jani Nikula
entation/security/tpm/tpm_vtpm_proxy.rst > diff --git a/Documentation/tpm/xen-tpmfront.txt > b/Documentation/security/tpm/xen-tpmfront.txt > similarity index 100% > rename from Documentation/tpm/xen-tpmfront.txt > rename to Documentation/security/tpm/xen-tpmfront.txt -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH RFC 0/4] Fix PDF build errors

2016-11-03 Thread Jani Nikula
, we don't have all that many literal blocks that would benefit from syntax highlighting in the first place. BR, Jani. [1] http://lkml.kernel.org/r/1478164053-4562-1-git-send-email-jani.nik...@intel.com -- Jani Nikula, Intel Open Source Technology Center

<    2   3   4   5   6   7   8   9   10   11   >