; + /* ring should be idle before issuing a sync flush*/
> + WARN_ON((I915_READ_MODE(engine) & MODE_IDLE) == 0);
> +
> + I915_WRITE(reg, 0x0 | IOTLB_INVALID_IVT | IOTLB_GLOBAL_INV_REQ);
> +
> + if (intel_wait_for_register(dev_priv,
> + reg, IOTLB_INVALID_IAIG, 0,
> + 1000))
> + DRM_ERROR("%s: wait for TLB invalidation timed out\n",
> + engine->name);
> + } else if (IS_GEN(dev_priv, 6, 7)) {
> i915_reg_t reg = RING_INSTPM(engine->mmio_base);
>
> /* ring should be idle before issuing a sync flush*/
--
Jani Nikula, Intel Open Source Technology Center
ng a sync flush*/
> + WARN_ON((I915_READ_MODE(engine) & MODE_IDLE) == 0);
> +
> + I915_WRITE(reg, 0x0 | IOTLB_INVALID_IVT | IOTLB_GLOBAL_INV_REQ);
> +
> + if (intel_wait_for_register(dev_priv,
> + reg, IOTLB_INVALID_IAIG, 0,
> + 1000))
> + DRM_ERROR("%s: wait for TLB invalidation timed out\n",
> + engine->name);
> + } else if (IS_GEN(dev_priv, 6, 7)) {
> i915_reg_t reg = RING_INSTPM(engine->mmio_base);
>
> /* ring should be idle before issuing a sync flush*/
--
Jani Nikula, Intel Open Source Technology Center
those registers will
> + * cause the hardware to perform IOTLB invalidation.
> + */
> + if (IS_GEN8(dev_priv)) {
> + i915_reg_t reg = IOTLB_INVALID(engine->mmio_base);
> +
> + /* ring should be idle before issuing a sync flush*/
> + WARN_ON((I915_R
/
> + WARN_ON((I915_READ_MODE(engine) & MODE_IDLE) == 0);
> +
> + I915_WRITE(reg, 0x0 | IOTLB_INVALID_IVT | IOTLB_GLOBAL_INV_REQ);
> +
> + if (intel_wait_for_register(dev_priv,
> + reg, IOTLB_INVALID_IAIG, 0,
> + 1000))
> + DRM_ERROR("%s: wait for TLB invalidation timed out\n",
> + engine->name);
> + } else if (IS_GEN(dev_priv, 6, 7)) {
> i915_reg_t reg = RING_INSTPM(engine->mmio_base);
>
> /* ring should be idle before issuing a sync flush*/
--
Jani Nikula, Intel Open Source Technology Center
invalidation.
> + */
> + if (IS_GEN8(dev_priv)) {
> + i915_reg_t reg = IOTLB_INVALID(engine->mmio_base);
> +
> + /* ring should be idle before issuing a sync flush*/
> + WARN_ON((I915_READ_MODE(engine) & MODE_IDLE) == 0);
> +
> + I915_WRITE(reg, 0x0 | IOTLB_INVALID_IVT | IOTLB_GLOBAL_INV_REQ);
> +
> + if (intel_wait_for_register(dev_priv,
> + reg, IOTLB_INVALID_IAIG, 0,
> + 1000))
> + DRM_ERROR("%s: wait for TLB invalidation timed out\n",
> + engine->name);
> + } else if (IS_GEN(dev_priv, 6, 7)) {
> i915_reg_t reg = RING_INSTPM(engine->mmio_base);
>
> /* ring should be idle before issuing a sync flush*/
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 14 Sep 2016, Jani Nikula <jani.nik...@linux.intel.com> wrote:
> On Wed, 14 Sep 2016, Pavel Machek <pa...@ucw.cz> wrote:
>> For the "sometimes need xrandr after resume": I don't think I can
>> bisect that. It only happens sometimes :-(. But the
On Wed, 14 Sep 2016, Jani Nikula wrote:
> On Wed, 14 Sep 2016, Pavel Machek wrote:
>> For the "sometimes need xrandr after resume": I don't think I can
>> bisect that. It only happens sometimes :-(. But there's something
>> helpful in the logs:
>
>>
On Wed, 14 Sep 2016, Pavel Machek <pa...@ucw.cz> wrote:
> Intel folks, any ideas? Can you reproduce it?
It's possible (but not confirmed yet) we've seen this in our CI, but has
slipped through because it's sporadic.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 14 Sep 2016, Pavel Machek wrote:
> Intel folks, any ideas? Can you reproduce it?
It's possible (but not confirmed yet) we've seen this in our CI, but has
slipped through because it's sporadic.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Mon, 20 Jun 2016, James Bottomley <james.bottom...@hansenpartnership.com>
wrote:
> On Fri, 2016-06-17 at 16:06 -0700, James Bottomley wrote:
>> On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote:
>> > On Fri, 17 Jun 2016, Daniel Vetter <dan...@ffwll.ch> wrot
On Mon, 20 Jun 2016, James Bottomley
wrote:
> On Fri, 2016-06-17 at 16:06 -0700, James Bottomley wrote:
>> On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote:
>> > On Fri, 17 Jun 2016, Daniel Vetter wrote:
>> > > On Thu, Jun 16, 2016 at 03:42:12PM -0700, James Bo
f ff ff ff
> [ 1856.218863] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 1856.218863] i915 :00:02.0: HDMI-A-1: EDID block 0 invalid.
Pavel, Martin, do you always see this when the display fails to resume?
Is it HDMI/DVI for both of you?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
.218863] ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> [ 1856.218863] i915 :00:02.0: HDMI-A-1: EDID block 0 invalid.
Pavel, Martin, do you always see this when the display fails to resume?
Is it HDMI/DVI for both of you?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 14 Sep 2016, Jani Nikula <jani.nik...@linux.intel.com> wrote:
> On Wed, 14 Sep 2016, Pavel Machek <pa...@ucw.cz> wrote:
>> Hi!
>>
>>> I have
>>>
>>> 00:02.0 VGA compatible controller: Intel Corporation 4 Series Chipset
>>&g
On Wed, 14 Sep 2016, Jani Nikula wrote:
> On Wed, 14 Sep 2016, Pavel Machek wrote:
>> Hi!
>>
>>> I have
>>>
>>> 00:02.0 VGA compatible controller: Intel Corporation 4 Series Chipset
>>> Integrated Graphics Controller (rev 03)
>>>
>
d? That's probably the
fastest way to resolve this.
BR,
Jani.
>
> X log is attached as delme, kernel log as delme2. Nothing too
> suspicious :-(.
>
> Pavel
--
Jani Nikula, Intel Open Source Technology Center
the
fastest way to resolve this.
BR,
Jani.
>
> X log is attached as delme, kernel log as delme2. Nothing too
> suspicious :-(.
>
> Pavel
--
Jani Nikula, Intel Open Source Technology Center
hing else to help debug.
Please try [1].
BR,
Jani.
[1]
http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrj...@linux.intel.com
--
Jani Nikula, Intel Open Source Technology Center
chwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrj...@linux.intel.com
--
Jani Nikula, Intel Open Source Technology Center
On Tue, 13 Sep 2016, Shuah Khan <shua...@osg.samsung.com> wrote:
> On 09/13/2016 03:20 AM, Jani Nikula wrote:
>> FWIW, I'm in favor of moving *all* the code away from Documentation, not
>> just tests. Essentially removing the CONFIG_BUILD_DOCSRC config option,
>>
On Tue, 13 Sep 2016, Shuah Khan wrote:
> On 09/13/2016 03:20 AM, Jani Nikula wrote:
>> FWIW, I'm in favor of moving *all* the code away from Documentation, not
>> just tests. Essentially removing the CONFIG_BUILD_DOCSRC config option,
>> and reserving Documentation/Makef
quot;) display bug,
> + * whereas the VBT panel type (7) gives a normal display.
> + * Let's ignore the OpRegion panel type for this chip.
> + */
> + if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
> + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> + return -ENODEV;
> + }
> +
> return ret - 1;
> }
--
Jani Nikula, Intel Open Source Technology Center
> + * Let's ignore the OpRegion panel type for this chip.
> + */
> + if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) {
> + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> + return -ENODEV;
> + }
> +
> return ret - 1;
> }
--
Jani Nikula, Intel Open Source Technology Center
e/create/delete, checkpatch could look at
MAINTAINERS and remind the user if a MAINTAINERS update is needed.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ould look at
MAINTAINERS and remind the user if a MAINTAINERS update is needed.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ation, not
just tests. Essentially removing the CONFIG_BUILD_DOCSRC config option,
and reserving Documentation/Makefile for documentation build. After this
series, some of the remaining code belongs under samples, some under
tools.
We could make it possible to include the code samples from samples into
the Sphinx built documentation.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
D_DOCSRC config option,
and reserving Documentation/Makefile for documentation build. After this
series, some of the remaining code belongs under samples, some under
tools.
We could make it possible to include the code samples from samples into
the Sphinx built documentation.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Tue, 06 Sep 2016, li...@eikelenboom.it wrote:
> On 2016-09-06 11:25, Jani Nikula wrote:
>> On Tue, 06 Sep 2016, li...@eikelenboom.it wrote:
>>> L.S.,
>>>
>>> Since one of the last 4.8 RC's i'm getting the warning below when
>>> booting on my sandyb
On Tue, 06 Sep 2016, li...@eikelenboom.it wrote:
> On 2016-09-06 11:25, Jani Nikula wrote:
>> On Tue, 06 Sep 2016, li...@eikelenboom.it wrote:
>>> L.S.,
>>>
>>> Since one of the last 4.8 RC's i'm getting the warning below when
>>> booting on my sandyb
t; [ 15.847472] [] ? kthread+0xbd/0xe0
> [ 15.847475] [] ? ret_from_fork+0x1f/0x40
> [ 15.847478] [] ? kthread_worker_fn+0x160/0x160
> [ 15.847487] ---[ end trace ad9e991297d99be1 ]---
--
Jani Nikula, Intel Open Source Technology Center
[] ? ret_from_fork+0x1f/0x40
> [ 15.847478] [] ? kthread_worker_fn+0x160/0x160
> [ 15.847487] ---[ end trace ad9e991297d99be1 ]---
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 07 Sep 2016, Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
> Hi Jani,
>
> On Wed, Sep 7, 2016 at 3:28 PM, Jani Nikula <jani.nik...@linux.intel.com>
> wrote:
>> On Wed, 07 Sep 2016, Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
>>> Whe
On Wed, 07 Sep 2016, Geert Uytterhoeven wrote:
> Hi Jani,
>
> On Wed, Sep 7, 2016 at 3:28 PM, Jani Nikula
> wrote:
>> On Wed, 07 Sep 2016, Geert Uytterhoeven wrote:
>>> When running "make htmldocs O=/path/to/somewhere", *.pyc files end up
>>> i
\
Side note, I'm really sad the Sphinx build has grown so ugly and
complicated now. :(
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
Sphinx build has grown so ugly and
complicated now. :(
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Wed, 07 Sep 2016, Markus Heiser <markus.hei...@darmarit.de> wrote:
> Am 06.09.2016 um 15:36 schrieb Jonathan Corbet <cor...@lwn.net>:
>
>> On Sat, 27 Aug 2016 11:43:18 +0300
>> Jani Nikula <jani.nik...@intel.com> wrote:
>>
>>> On Fri,
On Wed, 07 Sep 2016, Markus Heiser wrote:
> Am 06.09.2016 um 15:36 schrieb Jonathan Corbet :
>
>> On Sat, 27 Aug 2016 11:43:18 +0300
>> Jani Nikula wrote:
>>
>>> On Fri, 26 Aug 2016, Jonathan Corbet wrote:
>>>> As far as I can tell, the handling o
; - int ret;
> -
> - ret = i915_gem_open(dev, file);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return i915_gem_open(dev, file);
> }
Seems to me the whole function could be replaced by a direct use of
i915_gem_open().
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
gt; - if (ret)
> - return ret;
> -
> - return 0;
> + return i915_gem_open(dev, file);
> }
Seems to me the whole function could be replaced by a direct use of
i915_gem_open().
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
0
> [2.846368] ---[ end trace da7b2ca8a6654bfa ]---
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
Meelis, what does 'lspci -nns 2' say for you?
BR,
Jani.
On Tue, 06 Sep 2016, Jani Nikula <jani.nik...@linux.intel.com> wrote:
> Lyude, this is due to
>
> commit 87660502f1a4d51fb043e89a45d30c9917787c22
> Author: Lyude <cp...@redhat.com>
> Date: Wed Aug 17 15:55:53
0
> [2.846368] ---[ end trace da7b2ca8a6654bfa ]---
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
Meelis, what does 'lspci -nns 2' say for you?
BR,
Jani.
On Tue, 06 Sep 2016, Jani Nikula wrote:
> Lyude, this is due to
>
> commit 87660502f1a4d51fb043e89a45d30c9917787c22
> Author: Lyude
> Date: Wed Aug 17 15:55:53 2016 -0400
>
> drm/i915/gen6+: Interpre
] [] ? process_one_work+0x3d0/0x3d0
> [2.846355] [] ? kthread+0xb8/0xd0
> [2.846362] [] ? ret_from_fork+0x1f/0x40
> [2.846365] [] ? kthread_worker_fn+0x180/0x180
> [2.846368] ---[ end trace da7b2ca8a6654bfa ]---
> __
one_work+0x3d0/0x3d0
> [2.846355] [] ? kthread+0xb8/0xd0
> [2.846362] [] ? ret_from_fork+0x1f/0x40
> [2.846365] [] ? kthread_worker_fn+0x180/0x180
> [2.846368] ---[ end trace da7b2ca8a6654bfa ]---
> ___
> Intel-gfx mailing
hread+0xbd/0xe0
> [ 15.847475] [] ? ret_from_fork+0x1f/0x40
> [ 15.847478] [] ? kthread_worker_fn+0x160/0x160
> [ 15.847487] ---[ end trace ad9e991297d99be1 ]---
--
Jani Nikula, Intel Open Source Technology Center
[] ? ret_from_fork+0x1f/0x40
> [ 15.847478] [] ? kthread_worker_fn+0x160/0x160
> [ 15.847487] ---[ end trace ad9e991297d99be1 ]---
--
Jani Nikula, Intel Open Source Technology Center
tc(crtc), _priv->wm.skl_results,
> -plane);
> + /*
> + * We only populate skl_results on watermark updates, and if the
> + * plane's visiblity isn't actually changing neither is its watermarks.
> + */
> + if (!dplane->state->visible)
> + skl_write_plane_wm(to_intel_crtc(crtc),
> +_priv->wm.skl_results, plane);
>
> I915_WRITE(PLANE_CTL(pipe, plane), 0);
--
Jani Nikula, Intel Open Source Technology Center
ts on watermark updates, and if the
> + * plane's visiblity isn't actually changing neither is its watermarks.
> + */
> + if (!dplane->state->visible)
> + skl_write_plane_wm(to_intel_crtc(crtc),
> +_priv->wm.skl_results, plane);
>
> I915_WRITE(PLANE_CTL(pipe, plane), 0);
--
Jani Nikula, Intel Open Source Technology Center
@ -2340,6 +2340,7 @@ sub push_parameter($$$) {
>
> if ($type eq "" && $param =~ /\.\.\.$/)
> {
> + $param = "...";
> if (!defined $parameterdescs{$param} || $parameterdescs{$param} eq
> "") {
> $parameterdescs{$param} = "variable arguments";
> }
--
Jani Nikula, Intel Open Source Technology Center
>
> if ($type eq "" && $param =~ /\.\.\.$/)
> {
> + $param = "...";
> if (!defined $parameterdescs{$param} || $parameterdescs{$param} eq
> "") {
> $parameterdescs{$param} = "variable arguments";
> }
--
Jani Nikula, Intel Open Source Technology Center
ented (either at the C code itself or at a header file);
>
> - on a *.h file, it should assume that *all* structs, enums, typedefs,
> function prototypes and static inline functions should be documented.
> As I stated before, we should also add a way to document defines.
> Assuming that we add such way, for defines, it should implicitly
> ignore the ones used inside the header to enable/disable part of
> its contents, like:
> #define _FOO_H_
> #ifndef _FOO_H_
>
> #endif
>
> Then, add an option to allow explicitly ignoring symbols. The lack
> of documentation for a symbol that matches the above criteria and
> isn't explicitly ignored should be warned, as this is a documentation
> gap that should be fixed.
>
> Thanks,
> Mauro
--
Jani Nikula, Intel Open Source Technology Center
>> should aware about this.
>
> I actually prefer the opposite:
Ditto.
Jani.
>
> - on a *.c file, it should assume that *all* exported symbols should be
> documented (either at the C code itself or at a header file);
>
> - on a *.h file, it should assume that *all* structs
g.
Finally, you don't always know in advance whether the patch should be
applied to -next or -fixes. We'd end up with cherry-picks like this
anyway. Now we can do QA on the fixes in -next, and choose the ones to
backport.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
lways know in advance whether the patch should be
applied to -next or -fixes. We'd end up with cherry-picks like this
anyway. Now we can do QA on the fixes in -next, and choose the ones to
backport.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
oll_init_work(struct work_struct *work) {
> +static void i915_hpd_poll_init_work(struct work_struct *work)
> +{
> struct drm_i915_private *dev_priv =
> container_of(work, struct drm_i915_private,
>hotplug.poll_init_work);
>
--
Jani Nikula, Intel Open Source Technology Center
struct drm_i915_private *dev_priv =
> container_of(work, struct drm_i915_private,
>hotplug.poll_init_work);
>
--
Jani Nikula, Intel Open Source Technology Center
did you actually build this? This is hurting not helping us. It
makes me think you didn't try your other patches either.
BR,
Jani.
> memset(best_clock, 0, sizeof(*best_clock));
>
> for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {
--
Jani Nikula, Intel Open Source Technology Center
me think you didn't try your other patches either.
BR,
Jani.
> memset(best_clock, 0, sizeof(*best_clock));
>
> for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {
--
Jani Nikula, Intel Open Source Technology Center
he better approach, avoiding problems if the type of s32 ever
changes.
BR,
Jani.
>> stats = compat_alloc_user_space(sizeof(*stats));
>> if (!stats)
>> return -EFAULT;
>> --
>> 2.1.4
>>
>> ___
>> dri-devel mailing list
>> dri-de...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
type of s32 ever
changes.
BR,
Jani.
>> stats = compat_alloc_user_space(sizeof(*stats));
>> if (!stats)
>> return -EFAULT;
>> --
>> 2.1.4
>>
>> ___
>> dri-devel mailing list
>> dri-de...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
his? Did you run this?
BR,
Jani.
> memset(best_clock, 0, sizeof(*best_clock));
>
> for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {
--
Jani Nikula, Intel Open Source Technology Center
t(best_clock, 0, sizeof(*best_clock));
>
> for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {
--
Jani Nikula, Intel Open Source Technology Center
pensource.com>
Date: Tue Aug 16 13:25:39 2016 -0300
docs-rst: Don't mangle with UTF-8 chars on LaTeX/PDF output
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
docs-rst: Don't mangle with UTF-8 chars on LaTeX/PDF output
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
Reviewed-by: Jani Nikula <jani.nik...@intel.com>
On Mon, 15 Aug 2016, Eric Engestrom <eric.engest...@imgtec.com> wrote:
> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com>
> ---
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +-
> drivers/
Reviewed-by: Jani Nikula
On Mon, 15 Aug 2016, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom
> ---
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c |
On Mon, 15 Aug 2016, Eric Engestrom <eric.engest...@imgtec.com> wrote:
> On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote:
>> On Mon, 15 Aug 2016, Eric Engestrom <e...@engestrom.ch> wrote:
>> > Signed-off-by: Eric Engestrom <e...@engestrom.ch>
>
On Mon, 15 Aug 2016, Eric Engestrom wrote:
> On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote:
>> On Mon, 15 Aug 2016, Eric Engestrom wrote:
>> > Signed-off-by: Eric Engestrom
>> > ---
>> >
>> > I moved the main bits to be the first diffs,
ed pixel format: %s\n",
> format_name);
> + kfree(format_name);
> return -EINVAL;
> }
> break;
> default:
> - DRM_DEBUG("unsupported pixel format: %s\n",
> - drm_get_format_name(mode_cmd->pixel_format));
> + format_name = drm_get_format_name(mode_cmd->pixel_format);
> + DRM_DEBUG("unsupported pixel format: %s\n", format_name);
> + kfree(format_name);
> return -EINVAL;
> }
>
> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
> b/drivers/gpu/drm/radeon/atombios_crtc.c
> index a97abc8..981ca3f 100644
> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> @@ -1154,6 +1154,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> u32 tmp, viewport_w, viewport_h;
> int r;
> bool bypass_lut = false;
> + const char *format_name;
>
> /* no fb bound */
> if (!atomic && !crtc->primary->fb) {
> @@ -1257,8 +1258,9 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> bypass_lut = true;
> break;
> default:
> - DRM_ERROR("Unsupported screen format %s\n",
> - drm_get_format_name(target_fb->pixel_format));
> + format_name = drm_get_format_name(target_fb->pixel_format);
> + DRM_ERROR("Unsupported screen format %s\n", format_name);
> + kfree(format_name);
> return -EINVAL;
> }
>
> @@ -1469,6 +1471,7 @@ static int avivo_crtc_do_set_base(struct drm_crtc *crtc,
> u32 viewport_w, viewport_h;
> int r;
> bool bypass_lut = false;
> + const char *format_name;
>
> /* no fb bound */
> if (!atomic && !crtc->primary->fb) {
> @@ -1558,8 +1561,9 @@ static int avivo_crtc_do_set_base(struct drm_crtc *crtc,
> bypass_lut = true;
> break;
> default:
> - DRM_ERROR("Unsupported screen format %s\n",
> - drm_get_format_name(target_fb->pixel_format));
> + format_name = drm_get_format_name(target_fb->pixel_format);
> + DRM_ERROR("Unsupported screen format %s\n", format_name);
> + kfree(format_name);
> return -EINVAL;
> }
--
Jani Nikula, Intel Open Source Technology Center
> + kfree(format_name);
> return -EINVAL;
> }
> break;
> default:
> - DRM_DEBUG("unsupported pixel format: %s\n",
> - drm_get_format_name(mode_cmd->pixel_format));
> + format_name = drm_get_format_name(mode_cmd->pixel_format);
> + DRM_DEBUG("unsupported pixel format: %s\n", format_name);
> + kfree(format_name);
> return -EINVAL;
> }
>
> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
> b/drivers/gpu/drm/radeon/atombios_crtc.c
> index a97abc8..981ca3f 100644
> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> @@ -1154,6 +1154,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> u32 tmp, viewport_w, viewport_h;
> int r;
> bool bypass_lut = false;
> + const char *format_name;
>
> /* no fb bound */
> if (!atomic && !crtc->primary->fb) {
> @@ -1257,8 +1258,9 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> bypass_lut = true;
> break;
> default:
> - DRM_ERROR("Unsupported screen format %s\n",
> - drm_get_format_name(target_fb->pixel_format));
> + format_name = drm_get_format_name(target_fb->pixel_format);
> + DRM_ERROR("Unsupported screen format %s\n", format_name);
> + kfree(format_name);
> return -EINVAL;
> }
>
> @@ -1469,6 +1471,7 @@ static int avivo_crtc_do_set_base(struct drm_crtc *crtc,
> u32 viewport_w, viewport_h;
> int r;
> bool bypass_lut = false;
> + const char *format_name;
>
> /* no fb bound */
> if (!atomic && !crtc->primary->fb) {
> @@ -1558,8 +1561,9 @@ static int avivo_crtc_do_set_base(struct drm_crtc *crtc,
> bypass_lut = true;
> break;
> default:
> - DRM_ERROR("Unsupported screen format %s\n",
> - drm_get_format_name(target_fb->pixel_format));
> + format_name = drm_get_format_name(target_fb->pixel_format);
> + DRM_ERROR("Unsupported screen format %s\n", format_name);
> + kfree(format_name);
> return -EINVAL;
> }
--
Jani Nikula, Intel Open Source Technology Center
On Sat, 13 Aug 2016, Jonathan Corbet <cor...@lwn.net> wrote:
> On Wed, 10 Aug 2016 18:54:06 +0300
> Jani Nikula <jani.nik...@intel.com> wrote:
>
>> With these you should be able to get started with pdf generation. It's a
>> quick transition to pdflatex
On Sat, 13 Aug 2016, Jonathan Corbet wrote:
> On Wed, 10 Aug 2016 18:54:06 +0300
> Jani Nikula wrote:
>
>> With these you should be able to get started with pdf generation. It's a
>> quick transition to pdflatex, the patches are not very pretty, but the
>> pdf
IMHO we would be better off using just the git history for the credits.
BR,
Jani.
PS. I am no saint here, I've got a couple of authors lines myself. I
promise not to add more. I certainly won't chastise anyone for adding
theirs.
--
Jani Nikula, Intel Open Source Technology Center
dits.
BR,
Jani.
PS. I am no saint here, I've got a couple of authors lines myself. I
promise not to add more. I certainly won't chastise anyone for adding
theirs.
--
Jani Nikula, Intel Open Source Technology Center
noise, and also fails in the end. We'll fix that next.
Signed-off-by: Jani Nikula <jani.nik...@intel.com>
---
Documentation/Makefile.sphinx | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx
noise, and also fails in the end. We'll fix that next.
Signed-off-by: Jani Nikula
---
Documentation/Makefile.sphinx | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx
index d24a9f12a280..fc29e08085aa
/3 for a quick fix for the media build.
Markus, you can now unleash your "I told you so" on the rst2pdf. ;)
BR,
Jani.
Jani Nikula (3):
Documentation/sphinx: build the media intermediate rst files for all
outputs
Documentation: switch to pdflatex for pdf generation
Documentatio
/3 for a quick fix for the media build.
Markus, you can now unleash your "I told you so" on the rst2pdf. ;)
BR,
Jani.
Jani Nikula (3):
Documentation/sphinx: build the media intermediate rst files for all
outputs
Documentation: switch to pdflatex for pdf generation
Documentatio
This is a stopgap measure to allow building outputs other than html.
Signed-off-by: Jani Nikula <jani.nik...@intel.com>
---
Documentation/Makefile.sphinx | 3 +--
Documentation/media/Makefile | 3 ++-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/Makefile.sp
This is a stopgap measure to allow building outputs other than html.
Signed-off-by: Jani Nikula
---
Documentation/Makefile.sphinx | 3 +--
Documentation/media/Makefile | 3 ++-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/Makefile.sphinx b/Documentation
Although pdflatex is more robust than rst2pdf, building media
documentation pdf still fails. Exclude media documentation from pdf
generation for now.
Signed-off-by: Jani Nikula <jani.nik...@intel.com>
---
Documentation/conf.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
Although pdflatex is more robust than rst2pdf, building media
documentation pdf still fails. Exclude media documentation from pdf
generation for now.
Signed-off-by: Jani Nikula
---
Documentation/conf.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/conf.py
mind for the documentation directory in
> general.
FWIW, the whole series is wholeheartedly
Acked-by: Jani Nikula <jani.nik...@intel.com>
--
Jani Nikula, Intel Open Source Technology Center
directory in
> general.
FWIW, the whole series is wholeheartedly
Acked-by: Jani Nikula
--
Jani Nikula, Intel Open Source Technology Center
le text file and one that can be used to generate pretty
documentation [1].
BR,
Jani.
[1] http://static.lwn.net/kerneldoc/dev-tools/sparse.html
--
Jani Nikula, Intel Open Source Technology Center
e used to generate pretty
documentation [1].
BR,
Jani.
[1] http://static.lwn.net/kerneldoc/dev-tools/sparse.html
--
Jani Nikula, Intel Open Source Technology Center
ous option enable_psr - tainting kernel
>
> which seems entirely bogus.
The warning comes from kernel/params.c for module_param_named_unsafe()
which has no way of knowing which values are safe, and complains if the
option is set at all.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ch seems entirely bogus.
The warning comes from kernel/params.c for module_param_named_unsafe()
which has no way of knowing which values are safe, and complains if the
option is set at all.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
ageflip,
>> "Force atomic modeset functionality; asynchronous mode is not
>> yet supported. (default: false).");
>>
>> /* WA to get away with the default setting in VBT for early platforms.Will
>> be removed */
>> -module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0400);
>> +module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, S_IRUSR);
>> MODULE_PARM_DESC(edp_vswing,
>> "Ignore/Override vswing pre-emph table selection from VBT "
>> "(0=use value from vbt [default], 1=low power swing(200mV),"
>> "2=default swing(400mV))");
>>
>> -module_param_named_unsafe(enable_guc_submission,
>> i915.enable_guc_submission, bool, 0400);
>> +module_param_named_unsafe(enable_guc_submission,
>> i915.enable_guc_submission, bool, S_IRUSR);
>> MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission
>> (default:false)");
>>
>> -module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
>> +module_param_named(guc_log_level, i915.guc_log_level, int, S_IRUSR);
>> MODULE_PARM_DESC(guc_log_level,
>> "GuC firmware logging level (-1:disabled (default), 0-3:enabled)");
>>
>> -module_param_named_unsafe(enable_dp_mst, i915.enable_dp_mst, bool, 0600);
>> +module_param_named_unsafe(enable_dp_mst, i915.enable_dp_mst, bool, S_IRUSR
>> | S_IWUSR);
>> MODULE_PARM_DESC(enable_dp_mst,
>> "Enable multi-stream transport (MST) for new DisplayPort sinks.
>> (default: true)");
>> -module_param_named_unsafe(inject_load_failure, i915.inject_load_failure,
>> uint, 0400);
>> +module_param_named_unsafe(inject_load_failure, i915.inject_load_failure,
>> uint, S_IRUSR);
>> MODULE_PARM_DESC(inject_load_failure,
>> "Force an error after a number of failure check points (0:disabled
>> (default), N:force failure at the Nth failure check point)");
>> --
>> 2.9.2
>>
>> ___
>> Intel-gfx mailing list
>> intel-...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
functionality; asynchronous mode is not
>> yet supported. (default: false).");
>>
>> /* WA to get away with the default setting in VBT for early platforms.Will
>> be removed */
>> -module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, 0400);
>> +module_param_named_unsafe(edp_vswing, i915.edp_vswing, int, S_IRUSR);
>> MODULE_PARM_DESC(edp_vswing,
>> "Ignore/Override vswing pre-emph table selection from VBT "
>> "(0=use value from vbt [default], 1=low power swing(200mV),"
>> "2=default swing(400mV))");
>>
>> -module_param_named_unsafe(enable_guc_submission,
>> i915.enable_guc_submission, bool, 0400);
>> +module_param_named_unsafe(enable_guc_submission,
>> i915.enable_guc_submission, bool, S_IRUSR);
>> MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission
>> (default:false)");
>>
>> -module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
>> +module_param_named(guc_log_level, i915.guc_log_level, int, S_IRUSR);
>> MODULE_PARM_DESC(guc_log_level,
>> "GuC firmware logging level (-1:disabled (default), 0-3:enabled)");
>>
>> -module_param_named_unsafe(enable_dp_mst, i915.enable_dp_mst, bool, 0600);
>> +module_param_named_unsafe(enable_dp_mst, i915.enable_dp_mst, bool, S_IRUSR
>> | S_IWUSR);
>> MODULE_PARM_DESC(enable_dp_mst,
>> "Enable multi-stream transport (MST) for new DisplayPort sinks.
>> (default: true)");
>> -module_param_named_unsafe(inject_load_failure, i915.inject_load_failure,
>> uint, 0400);
>> +module_param_named_unsafe(inject_load_failure, i915.inject_load_failure,
>> uint, S_IRUSR);
>> MODULE_PARM_DESC(inject_load_failure,
>> "Force an error after a number of failure check points (0:disabled
>> (default), N:force failure at the Nth failure check point)");
>> --
>> 2.9.2
>>
>> ___
>> Intel-gfx mailing list
>> intel-...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
0
> [8.733424] [] blocking_notifier_call_chain+0x16/0x20
> [8.733426] [] fb_notifier_call_chain+0x1b/0x20
> [8.733427] [] register_framebuffer+0x239/0x320
> [8.733430] [] ? vga_switcheroo_client_fb_set+0x60/0x70
> [8.733440] [] drm_fb_helper_initial_config+0x25a/0x3a3
> [drm_kms_helper]
> [8.733483] [] intel_fbdev_initial_config+0x18/0x30
> [i915]
> [8.733484] [] async_run_entry_fn+0x4a/0x140
> [8.733486] [] process_one_work+0x1de/0x670
> [8.733488] [] ? process_one_work+0x15f/0x670
> [8.733490] [] worker_thread+0x125/0x4a0
> [8.733492] [] ? process_one_work+0x670/0x670
> [8.733494] [] kthread+0xf2/0x110
> [8.733497] [] ret_from_fork+0x1f/0x40
> [8.733499] [] ? kthread_create_on_node+0x220/0x220
--
Jani Nikula, Intel Open Source Technology Center
[8.733424] [] blocking_notifier_call_chain+0x16/0x20
> [8.733426] [] fb_notifier_call_chain+0x1b/0x20
> [8.733427] [] register_framebuffer+0x239/0x320
> [8.733430] [] ? vga_switcheroo_client_fb_set+0x60/0x70
> [8.733440] [] drm_fb_helper_initial_config+0x25a/0x3a3
> [drm_kms_helper]
> [8.733483] [] intel_fbdev_initial_config+0x18/0x30
> [i915]
> [8.733484] [] async_run_entry_fn+0x4a/0x140
> [8.733486] [] process_one_work+0x1de/0x670
> [8.733488] [] ? process_one_work+0x15f/0x670
> [8.733490] [] worker_thread+0x125/0x4a0
> [8.733492] [] ? process_one_work+0x670/0x670
> [8.733494] [] kthread+0xf2/0x110
> [8.733497] [] ret_from_fork+0x1f/0x40
> [8.733499] [] ? kthread_create_on_node+0x220/0x220
--
Jani Nikula, Intel Open Source Technology Center
ernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
Jani Nikula, Intel Open Source Technology Center
Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
Jani Nikula, Intel Open Source Technology Center
Simply move the dochelp rule outside of the HAVE_SPHINX check,
overriding the .DEFAULT rule for HAVE_SPHINX=0.
Cc: Jonathan Corbet <cor...@lwn.net>
Cc: Christian Kujau <li...@nerdbynature.de>
Signed-off-by: Jani Nikula <jani.nik...@intel.com>
---
Documentation/Makefile.sphin
Simply move the dochelp rule outside of the HAVE_SPHINX check,
overriding the .DEFAULT rule for HAVE_SPHINX=0.
Cc: Jonathan Corbet
Cc: Christian Kujau
Signed-off-by: Jani Nikula
---
Documentation/Makefile.sphinx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
e'll make it happen.
I think we should still display the help (without warnings!) even if the
tool is not available. Patch follows.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
e help (without warnings!) even if the
tool is not available. Patch follows.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
On Fri, 01 Jul 2016, Mauro Carvalho Chehab <mche...@osg.samsung.com> wrote:
> Em Fri, 01 Jul 2016 20:24:48 +0300
> Jani Nikula <jani.nik...@intel.com> escreveu:
>> The current media DocBook docs are a prime example. There are really
>> great features there, but IMH
801 - 900 of 1745 matches
Mail list logo
