Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type

int ret; Maybe inside ks_wlan_start_xmit, instead of "return 0;", there should be "return NETDEV_TX_OK;" and "return NETDEV_TX_BUSY;" otherwise. It is just suggestion. Br, Janusz Lisiecki

Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type

int ret; Maybe inside ks_wlan_start_xmit, instead of "return 0;", there should be "return NETDEV_TX_OK;" and "return NETDEV_TX_BUSY;" otherwise. It is just suggestion. Br, Janusz Lisiecki

Re: [PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

W dniu 2017-07-02 o 23:23, Luc Van Oostenryck pisze: On Sun, Jul 2, 2017 at 10:49 PM, Janusz Lisiecki wrote: W dniu 2017-07-02 o 21:38, Luc Van Oostenryck pisze: On Sun, Jul 2, 2017 at 4:27 PM, Janusz Lisiecki wrote: This patch fixes the following Sparse warnings in ks_wlan_net.c: drivers

[PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

current_ap). Both sides of assignment are u16 (native order) so 'le16_to_cpu' is not needed and wrong. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/dr

[PATCH 0/1] Fix cast to restricted __le16 in ks7010 driver

) on it is wrong and must be removed. As this is not HW related structure we are free to choose its byte order and it is easier just to remove one wrong casting than rework all other places to treat it as __le16. Janusz Lisiecki (1): staging: ks7010: Fix warning of cast to restricted

Re: [PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

W dniu 2017-07-02 o 21:38, Luc Van Oostenryck pisze: On Sun, Jul 2, 2017 at 4:27 PM, Janusz Lisiecki wrote: This patch fixes the following Sparse warnings in ks_wlan_net.c: drivers/staging/ks7010/ks_wlan_net.c:1359:24: warning: cast to restricted __le16 Both sides of assignment are u16 so (as

[PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

capabilities' type of u16) 'le16_to_cpu' is not needed Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index 0c778aa..9a7

[PATCH 0/1] Fix cast to restricted __le16 in ks7010 driver

This patch fixes Sparse warining found in ks_wlan_net.c. This seems to be last of it reported by Sparse for that driver. Janusz Lisiecki (1): staging: ks7010: Fix warning of cast to restricted __le16 in ks_wlan_net.c drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1